On Mon, 2018-12-10 at 14:36 +0100, David Disseldorp wrote:
> Ping - any feedback on this change?
>
> On Thu, 22 Nov 2018 14:38:00 +0100, David Disseldorp wrote:
>
> > Block ALUA and PR state storage if any of the dynamic subdirectory
> > components include a path separator.
> >
> > Fixes: c66ac9db8d4a ("[SCSI] target: Add LIO target core v4.0.0-rc6")
> > Signed-off-by: David Disseldorp <dd...@suse.de>
> > Signed-off-by: Lee Duncan <ldun...@suse.com>
> > ---
> > Note:
> > Submitted as an RFC, as I've not properly tested the alua code path.
> > I'm also not sure whether it's reasonable to break existing setups
> > with a '/' in the configured unit_serial. Where "break" means fail
> > APTPL PR requests; ALUA state-save failures are ignored internally.
>
> I'd also be happy with any pointers on properly testing ALUA.
Embedding SCSI properties like the unit serial number in a file system path
seems wrong to me. I think the path in which these properties are stored
should be derived from configfs item names configured by the user. These
names are guaranteed to be ASCII strings. If you want to see an example of
alternative approach you are welcome to have a look at scst_pr_set_file_name()
and scst_pr_sync_device_file() in the SCST source code.
Regarding testing ALUA code: I use sg_rtpg and sg_stpg to test SCSI target
ALUA code.
Bart.
