Signed-off-by: Shivasharan S
---
drivers/scsi/megaraid/megaraid_sas.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas.h
b/drivers/scsi/megaraid/megaraid_sas.h
index 994c6ac6f920..8edba2227cd3 100644
--- a/drivers/scsi/megaraid/megaraid_s
The print related to number of VDs that a particular firmware supports is
misleading in some cases.
Even though supportMaxExtLDs is set, certain firmware profiles only
supports upto 64VDs.
Signed-off-by: Shivasharan S
---
drivers/scsi/megaraid/megaraid_sas_base.c | 6 +++---
1 file changed, 3 in
IOC INIT frame needs to be fired with a timeout of 180seconds.
Signed-off-by: Shivasharan S
---
drivers/scsi/megaraid/megaraid_sas_fusion.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c
b/drivers/scsi/megaraid/megaraid_sas_fusion
Signed-off-by: Shivasharan S
---
drivers/scsi/megaraid/megaraid_sas_fusion.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c
b/drivers/scsi/megaraid/megaraid_sas_fusion.c
index b13fd1c601d7..a26abc041435 100644
--- a/drivers/scsi
In megasas_init_adapter_fusion(), max_mfi_cmds is being calcuated as
(MEGASAS_FUSION_INTERNAL_CMDS + MEGASAS_FUSION_IOCTL_CMDS).
max_mfi_cmds can be used in megasas_configure_queue_sizes.
Signed-off-by: Shivasharan S
---
drivers/scsi/megaraid/megaraid_sas_fusion.c | 4 +---
1 file changed, 1 ins
Signed-off-by: Shivasharan S
---
drivers/scsi/megaraid/megaraid_sas.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas.h
b/drivers/scsi/megaraid/megaraid_sas.h
index 2c044106c35f..994c6ac6f920 100644
--- a/drivers/scsi/megaraid/megaraid_sas.h
+++ b/drivers/sc
No functional change.
Use local variables when accessing raid context in IO path.
Improves code readability.
Signed-off-by: Shivasharan S
---
drivers/scsi/megaraid/megaraid_sas_fusion.c | 74 -
1 file changed, 31 insertions(+), 43 deletions(-)
diff --git a/drivers/sc
Optimization -
No need to hold hba_lock in dpc context for reading atomic variable.
Signed-off-by: Shivasharan S
---
drivers/scsi/megaraid/megaraid_sas_fusion.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c
b/drivers/scsi/m
When driver fails to start the heartbeat timer, exit from FW init.
Signed-off-by: Shivasharan S
---
drivers/scsi/megaraid/megaraid_sas_base.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c
b/drivers/scsi/megaraid/megaraid_sas_
No functional change.
Rename the scratch pad registers to match firmware headers.
Signed-off-by: Sumit Saxena
Signed-off-by: Shivasharan S
---
drivers/scsi/megaraid/megaraid_sas.h| 9 +++
drivers/scsi/megaraid/megaraid_sas_base.c | 40 +--
drivers/scsi/meg
Fix -
For SRIOV based adapters, driver should not set the STOP_ADP bit as part
of kill adapter.
Signed-off-by: Shivasharan S
---
drivers/scsi/megaraid/megaraid_sas_base.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c
b/driv
Fix -
For Invader series, if FW supports more than 8 MSI-x vectors, driver needs
to enable combined reply queue mode. For Ventura series, driver enables
combined reply queue mode in case of more than 16 MSI-x vectors.
Signed-off-by: Sumit Saxena
Signed-off-by: Shivasharan S
---
drivers/scsi/meg
Module parameter description for rdpq_enable incorrectly lists the default
as enabled.
Also, provide range of valid values for resetwaittime in the description.
Signed-off-by: Shivasharan S
---
drivers/scsi/megaraid/megaraid_sas_base.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
Issue -
In megasas_transition_to_ready() driver waits 180seconds for controller
to change FW state. Here we are calling msleep(1) in a loop for this.
As explained in timers-howto.txt, msleep(1) will actually sleep longer
than 1ms. If a faulty controller is connected, we will end up waiting for
much
Issue -
Currently driver checks for Firmware state change from ISR context, and
only when there are interrupts tied with no I/O completions.
We have seen multiple cases where doorbell interrupts sent by firmware,
to indicate FW state change are not processed by driver and it takes long
time for dri
Fix -
During init, if pci_alloc_irq_vectors() fails, the driver has not yet
setup the IRQs. Fix the goto labels and error handling for this case.
Signed-off-by: Shivasharan S
---
drivers/scsi/megaraid/megaraid_sas_base.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/dr
Change copyright to Broadcom Inc. Also update any references to Avago with
Broadcom. Update copyright duration wherever required.
Signed-off-by: Shivasharan S
---
drivers/scsi/megaraid/megaraid_sas.h| 14 ++
drivers/scsi/megaraid/megaraid_sas_base.c | 18 --
Latest firmware adds a mechanism to save firmware logs just before
controller reset on pre-allocated internal controller DRAM. This feature
is called snapdump which will help debugging firmware issues.
This feature requires extra time and firmware reports these values through
new driver interface.
For SAS3 and later controllers, FW sets the reset adapter bit indicating
the driver to perform a controller reset.
Driver needs to check if this bit is set before doing a reset.
This reduces the driver probe failure time to 180seconds in case there
is a faulty controller connected.
Signed-off-by:
Changes in V2:
- Rebased the entire series on top of below patches -
"scsi: megaraid_sas: fix a missing-check bug"
"megaraid_sas: switch to generic DMA API"
- Patch 2/19: Replace PCI DMA APIs with generic DMA APIs.
Shivasharan S (19):
megaraid_sas: Add watchdog thread to detect Firmware faul
On 10/16/18 10:39 PM, Laurence Oberman wrote:
This message floods the log when enabling mask 0x7 for
/proc/sys/dev/scsi/logging_level
kernel: scsi_block_when_processing_errors: rtn: 1
Its not needed and makes tracing just scsi_eh* messages way too verbose
so get rid of it
Signed-off
This is to fix Sync cache and start stop command
failures with DID_NO_CONNECT during driver unload.
1) Release drives first from SML, then remove internally
in driver.
2) And allow sync cache and Start stop commands to firmware,
even when remove_host flag is set.
Signed-off-by: Suganath Prabu
-
No functional changes. This section of code
"wait for IOC to be operational" is used in many places
across the driver, and hence moved this code in to
a function "mpt3sas_wait_for_ioc_to_operational()"
Signed-off-by: Suganath Prabu
---
drivers/scsi/mpt3sas/mpt3sas_base.c | 77 +++
* If EEDPTagMode field in manufacturing page11 is set,
unset it. This is needed to fix a hardware bug
in SAS3/SAS2 cards, So, skipping EEDPTagMode changes
in Manufacturing page11 for SAS35 controllers.
* Fix driver modifying NVRAM/persistent data in
Manufacturing page11 along with current copy. Dr
Modify driver version to 27.100.00.00
(which is equivalent to PH8 OOB driver)
Signed-off-by: Suganath Prabu
---
drivers/scsi/mpt3sas/mpt3sas_base.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.h
b/drivers/scsi/mpt3sas/mpt3sas_base.h
i
V5 Change set:
V5 post has only defect fixes.
We are reworking and incorporating the suggestions from Bjorn.
And after covering tests, we ll be post Hot-Plug Surprise
removal patches.
V4 Change set:
Reframe split strings in print statement, to avoid
V3 Change Set:
Simplified function "mpt3sas_ba
On 10/17/18 3:55 AM, Martin K. Petersen wrote:
>> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
>> where we are expecting to fall through.
>
> Applied to 4.20/scsi-queue.
>
Thank you, Martin.
--
Gustavo
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Addresses-Coverity-ID: 114971 ("Missing break in switch")
Addresses-Coverity-ID: 744899 ("Missing break in switch")
Addresses-Coverity-ID: 744900 ("Missing break in switch")
Addresses-Cover
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Addresses-Coverity-ID: 1357351 ("Missing break in switch")
Addresses-Coverity-ID: 1357392 ("Missing break in switch")
Addresses-Coverity-ID: 114976 ("Missing break in switch")
Addresses-Cov
On Tue, 16 Oct 2018, Martin K. Petersen wrote:
>
> Finn,
>
> > This looks wrong to me. I think you've just prevented all START STOP
> > commands sent to logical volumes from reaching
> >
> > return ((*ha->func.issue) (ha, scb));
> >
> > I think a better patch is to add a "fall though" c
YueHaibing,
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/scsi/lpfc/lpfc_debugfs.c: In function 'lpfc_debugfs_nodelist_data':
> drivers/scsi/lpfc/lpfc_debugfs.c:553:29: warning:
> variable 'tgtp' set but not used [-Wunused-but-set-variable]
>
> It never used since 2b65e18202fd ("
Gustavo,
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
Applied to 4.20/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
YueHaibing,
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/scsi/lpfc/lpfc_hbadisc.c: In function 'lpfc_free_tx':
> drivers/scsi/lpfc/lpfc_hbadisc.c:5431:19: warning:
> variable 'psli' set but not used [-Wunused-but-set-variable]
>
> Since commit 895427bd012c ("scsi: lpfc: NVME Ini
Nathan,
> Clang warns when one enumerated type is implicitly converted to another.
>
> drivers/scsi/bfa/bfa_fcs_lport.c:379:26: warning: implicit conversion
> from enumeration type 'enum bfa_lport_aen_event' to different
> enumeration type 'enum bfa_ioc_aen_event' [-Wenum-conversion]
>
Nathan,
> Avoid all of these implicit conversion by just making
> sci_controller_start_task use sci_status. This silences Clang and has
> no functional change since sci_task_status has all of its values
> mapped to something in sci_status.
Applied to 4.20/scsi-queue.
--
Martin K. Petersen
Nathan,
> - status = SCI_IO_FAILURE_RESPONSE_VALID;
> + status = SCI_FAILURE_IO_RESPONSE_VALID;
Naming fail!
Applied to 4.20/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
Hi Yue Haibing,
> srb_tag = le32_to_cpu(scsiqp->srb_tag);
> - scp = scsi_host_find_tag(boardp->shost, scsiqp->srb_tag);
> + scp = scsi_host_find_tag(boardp->shost, srb_tag);
Maybe I'm missing something, but I don't see where in the code
scsiqp->srb_tag is being converted to le32.
Finn,
> This looks wrong to me. I think you've just prevented all START STOP
> commands sent to logical volumes from reaching
>
> return ((*ha->func.issue) (ha, scb));
>
> I think a better patch is to add a "fall though" comment not a "break"
> statement. (I no longer have access to a Se
On Tue, Oct 16, 2018 at 3:48 PM, John Stultz wrote:
> On Mon, Oct 15, 2018 at 8:41 PM, Martin K. Petersen
> wrote:
>>
>> John,
>>
>>> Hynix ufs has deviations on hi36xx platform which will result in ufs
>>> bursts transfer failures.
>>
>> Is this specific to the particular implementation on hi36x
On Mon, Oct 15, 2018 at 8:41 PM, Martin K. Petersen
wrote:
>
> John,
>
>> Hynix ufs has deviations on hi36xx platform which will result in ufs
>> bursts transfer failures.
>
> Is this specific to the particular implementation on hi36xx or all SK
> Hynix implementations?
I'd have to defer to Wei L
YueHaibing,
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/scsi/megaraid/megaraid_mbox.c: In function 'megaraid_mbox_sync_scb':
> drivers/scsi/megaraid/megaraid_mbox.c:2193:14: warning:
> variable 'ccb' set but not used [-Wunused-but-set-variable]
>
> drivers/scsi/megaraid/megarai
On Tue, 16 Oct 2018, Martin K. Petersen wrote:
>
> Gustavo,
>
> > Add missing break statement in order to prevent the code from falling
> > through to case TEST_UNIT_READY.
>
> Applied to 4.20/scsi-queue, thanks!
>
>
This looks wrong to me. I think you've just prevented all START STOP
comma
Nathan,
> Clang generates a warning when it sees a logical not followed by a
> conditional operator like ==, >, or < because it thinks that the logical
> not should be applied to the whole statement:
> Link: https://github.com/ClangBuiltLinux/linux/issues/80
> Signed-off-by: Nathan Chancellor
Nathan,
> However, upon further inspection, these functions aren't actually used
> anywhere; they're just defined. Rather than just removing the self
> assignments, remove all of this dead code.
>
> Link: https://github.com/ClangBuiltLinux/linux/issues/148
> Signed-off-by: Nathan Chancellor
Ap
Nathan,
> Clang warns when a variable is assigned to itself.
>
> drivers/scsi/qla2xxx/qla_mbx.c:1514:4: warning: explicitly assigning
> value of variable of type 'uint64_t' (aka 'unsigned long long') to
> itself [-Wself-assign]
> l = l;
> ~ ^ ~
> 1 warning generated.
Applied to
YueHaibing,
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/scsi/arcmsr/arcmsr_hba.c: In function 'arcmsr_drain_donequeue':
> drivers/scsi/arcmsr/arcmsr_hba.c:1320:10: warning:
> variable 'lun' set but not used [-Wunused-but-set-variable]
>
> drivers/scsi/arcmsr/arcmsr_hba.c:1320:6
Wenwen,
> This patch enforces a check on the two kernel variables 'local_sense_off'
> and 'user_sense_off' to make sure they are the same after the copy. In case
> they are not, an error code EINVAL will be returned.
Applied to 4.20/scsi-queue, thank you!
--
Martin K. Petersen Oracle Lin
Colin,
> Trivial fix to spelling mistake in beiscsi_log message.
Applied to 4.20/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
Colin,
> Trivial fix to spelling mistake in lpfc_printf_log message text.
Applied to 4.20/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
John,
> Currently a spin_unlock_irqrestore() call is missing on the error path, so
> add it.
Applied to 4.20/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
Jens,
> We just need to free the request here. Additionally, this is
> currently wrong for a queue that's using MQ currently, it'll
> crash.
Applied to 4.20/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
Jens,
> This is currently wrong since it isn't dependent on if we're using
> mq or not. At least now it'll be correct when we force mq.
Applied to 4.20/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Gustavo,
> Add missing break statement in order to prevent the code from falling
> through to case TEST_UNIT_READY.
Applied to 4.20/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
This message floods the log when enabling mask 0x7 for
/proc/sys/dev/scsi/logging_level
kernel: scsi_block_when_processing_errors: rtn: 1
Its not needed and makes tracing just scsi_eh* messages way too verbose
so get rid of it
Signed-off-by: Laurence Oberman
---
drivers/scsi/scsi_e
On Tue, 2018-10-16 at 01:19 -0400, Martin K. Petersen wrote:
> Bart,
>
> > During the 2018 edition of LSF/MM there was a session about increasing
> > SCSI disk probing concurrency. This patch series implements what has
> > been proposed during that session, namely: - Make sure that the driver
> >
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Addresses-Coverity-ID: 1195463 ("Missing break in switch")
Addresses-Coverity-ID: 1195464 ("Missing break in switch")
Addresses-Coverity-ID: 1195465 ("Missing break in switch")
Addresses-Co
From: Colin Ian King
Trivial fix to spelling mistake in beiscsi_log message.
Signed-off-by: Colin Ian King
---
drivers/scsi/be2iscsi/be_iscsi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/be2iscsi/be_iscsi.c b/drivers/scsi/be2iscsi/be_iscsi.c
index c8f0a214
From: "Bryant G. Ly"
There is currently a bug with the driver where there is never a
call to target_sess_cmd_list_set_waiting(), it only called
target_wait_for_sess_cmd(), which basically means that the
sess_wait_list would always be empty.
Thus, list_empty(&sess->sess_wait_list) = true,
(eg: no
Hi David,
can you give as any hint? We're running aroud 120 Adaptec Controllers
and i don't want to replace them all...
Greets,
Stefan
Am 27.09.2018 um 14:23 schrieb Stefan Priebe - Profihost AG:
>
> Am 27.09.2018 um 12:59 schrieb Emmanuel Florac:
>> Le Wed, 19 Sep 2018 08:10:41 +0200
>> Stefan
From: Colin Ian King
Trivial fix to spelling mistake in lpfc_printf_log message text.
Signed-off-by: Colin Ian King
---
drivers/scsi/lpfc/lpfc_init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
index 0bd3ae99
On Tue, 2018-10-16 at 11:23 -0400, Bill Kuzeja wrote:
> When doing a surprise removal of an adapter, some in flight I/Os can
> get
> stuck and take a while to complete (they actually timeout and are
> retried). We are not handling an early error exit from
> qla2xxx_eh_abort properly.
>
> Fixes:
On 2018-10-16 10:38 a.m., Jens Axboe wrote:
We just need to free the request here. Additionally, this is
currently wrong for a queue that's using MQ currently, it'll
crash.
Surprise removals are difficult code paths to check. That snippet
is after the request has been generated and before the c
When doing a surprise removal of an adapter, some in flight I/Os can get
stuck and take a while to complete (they actually timeout and are
retried). We are not handling an early error exit from
qla2xxx_eh_abort properly.
Fixes: 45235022da99 ("scsi: qla2xxx: Fix driver unload by shutting down ch
On Fri, Oct 12 2018 at 6:08am -0400,
Damien Le Moal wrote:
> Drivers exposing zoned block devices have to initialize and maintain
> correctness (i.e. revalidate) of the device zone bitmaps attached to
> the device request queue (seq_zones_bitmap and seq_zones_wlock).
>
> To simplify coding this
Jens,
>> How about adding Hannes' Signed-off-by? See also
>> https://www.spinics.net/lists/linux-scsi/msg123488.html.
>
> I had no idea this existed, I'll just replace with that one instead
> and your reviewed-by (and mine).
> Martin, is this queued up?
Nope, I was waiting for Hannes to addres
On Fri, Oct 12 2018 at 6:08am -0400,
Damien Le Moal wrote:
> From: Christoph Hellwig
>
> Dispatching a report zones command through the request queue is a major
> pain due to the command reply payload rewriting necessary. Given that
> blkdev_report_zones() is executing everything synchronously
On 10/16/18 9:09 AM, Martin K. Petersen wrote:
>
> Jens,
>
>>> How about adding Hannes' Signed-off-by? See also
>>> https://www.spinics.net/lists/linux-scsi/msg123488.html.
>>
>> I had no idea this existed, I'll just replace with that one instead
>> and your reviewed-by (and mine).
>
>> Martin,
Currently a spin_unlock_irqrestore() call is missing on the error path, so
add it.
Reported-by: Julia Lawall
Signed-off-by: John Garry
diff --git a/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
b/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
index 70d6b28..cc36b64 100644
--- a/drivers/scsi/hisi_sas/hisi_sas
On 10/16/18 8:55 AM, Bart Van Assche wrote:
> On Tue, 2018-10-16 at 08:31 -0600, Jens Axboe wrote:
>> This check is only viable for non scsi-mq. Since that is going away,
>> kill this legacy check.
>>
>> Cc: Bart Van Assche
>> Cc: Parav Pandit
>> Cc: linux-scsi@vger.kernel.org
>> Signed-off-by: J
On Tue, 2018-10-16 at 08:31 -0600, Jens Axboe wrote:
> This check is only viable for non scsi-mq. Since that is going away,
> kill this legacy check.
>
> Cc: Bart Van Assche
> Cc: Parav Pandit
> Cc: linux-scsi@vger.kernel.org
> Signed-off-by: Jens Axboe
> ---
> drivers/infiniband/ulp/srp/ib_sr
Requires a few changes to the FC transport class as well.
Cc: Johannes Thumshirn
Cc: Benjamin Block
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Jens Axboe
---
block/bsg-lib.c | 102 +--
drivers/scsi/scsi_transport_fc.c | 61 ++
2
We just need to free the request here. Additionally, this is
currently wrong for a queue that's using MQ currently, it'll
crash.
Cc: Doug Gilbert
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Jens Axboe
---
drivers/scsi/sg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dr
Martin,
> On Oct 15, 2018, at 11:13 PM, Martin K. Petersen
> wrote:
>
>
> Bryant,
>
>> VMs do not remove the I_T nexus while the VM is active, so we can remove
>> the target_wait_for_sess_cmd() call.
>
> Patch forthcoming?
I can put out a patch, I’m trying to get someone at IBM to test it
Would be nice to fix up the SCSI midlayer instead, but this will
do for now.
Cc: Christoph Hellwig
Cc: Satish Kharat
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Jens Axboe
---
drivers/scsi/fnic/fnic_scsi.c | 61 +++
1 file changed, 12 insertions(+), 49 deletio
This is currently wrong since it isn't dependent on if we're using
mq or not. At least now it'll be correct when we force mq.
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Jens Axboe
---
drivers/scsi/osd/osd_initiator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/
This check is only viable for non scsi-mq. Since that is going away,
kill this legacy check.
Cc: Bart Van Assche
Cc: Parav Pandit
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Jens Axboe
---
drivers/infiniband/ulp/srp/ib_srp.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/i
On Sun, 14 Oct 2018, 11:59am, Christoph Hellwig wrote:
> External Email
>
> The driver is currently using an odd mix of legacy PCI DMA API and
> generic DMA API calls, switch it over to the generic API entirely.
>
> Signed-off-by: Christoph Hellwig
> Reviewed-by: Johannes Thumshirn
> ---
>
On Fri, Oct 12, 2018 at 12:20 AM Christoph Hellwig wrote:
>
> Switch from the legacy PCI DMA API to the generic DMA API.
>
> Signed-off-by: Christoph Hellwig
> ---
> drivers/scsi/megaraid/megaraid_sas_base.c | 150 ++--
> drivers/scsi/megaraid/megaraid_sas_fusion.c | 16 +--
>
On Sun, Oct 7, 2018 at 12:04 AM Wenwen Wang wrote:
>
> In megasas_mgmt_compat_ioctl_fw(), to handle the structure
> compat_megasas_iocpacket 'cioc', a user-space structure megasas_iocpacket
> 'ioc' is allocated before megasas_mgmt_ioctl_fw() is invoked to handle the
> packet. Since the two data st
On Tue, Oct 02, 2018 at 09:43:35AM +, Ioana Ciornei wrote:
> > > Add BUS_ATTR_WO macro to make it easier to add attributes without
> > > auditing the mode settings. Also, use the newly added macro where
> > > appropriate.
> > >
> > > Signed-off-by: Ioana Ciornei
> > > ---
> > > arch/powerpc/p
Hi,
> +++ b/drivers/scsi/ufs/Makefile
> @@ -4,6 +4,8 @@ obj-$(CONFIG_SCSI_UFS_DWC_TC_PCI) += tc-dwc-g210-
> pci.o ufshcd-dwc.o tc-dwc-g210.
> obj-$(CONFIG_SCSI_UFS_DWC_TC_PLATFORM) += tc-dwc-g210-pltfrm.o
> ufshcd-dwc.o tc-dwc-g210.o
> obj-$(CONFIG_SCSI_UFS_QCOM) += ufs-qcom.o
> obj-$(CONFIG_SC
Add missing break statement in order to prevent the code from falling
through to case TEST_UNIT_READY.
Addresses-Coverity-ID: 1357338 ("Missing break in switch")
Suggested-by: Martin K. Petersen
Signed-off-by: Gustavo A. R. Silva
---
drivers/scsi/ips.c | 1 +
1 file changed, 1 insertion(+)
dif
On Tue, 16 Oct 2018 00:42:57 -0400, Martin K. Petersen wrote:
> > I guess I'll resend entire series in future to avoid false kbuild
> > reports.
>
> Yes, please. Patchwork can't handle individual patches getting updated
> either.
Okay, will do.
> Applied to 4.20/scsi-queue.
Thanks Martin.
C
This patch adds configfs support to provision UFS device at
runtime. This feature can be primarily useful in factory or
assembly line as some devices may be required to be configured
multiple times during initial system development phase.
Configuration Descriptors can be written multiple times unti
From: Subhash Jadavani
UFS host supplies the reference clock to UFS device and UFS device
specification allows host to provide one of the 4 frequencies (19.2 MHz,
26 MHz, 38.4 MHz, 52 MHz) for reference clock. Host should set the
device reference clock frequency setting in the device based on wha
This patch adds Configfs support to provision UFS device at
runtime. This feature can be primarily useful in factory or
assembly line as some devices may be required to be configured
multiple times during initial system development phase.
Configuration Descriptors can be written multiple times un
On 16/10/2018 05:28, Martin K. Petersen wrote:
John,
As I mentioned in the thread that spawned from this, we actually can't
expose multiple hw queues at the moment. And, if we did, we find a
performance drop due to having to go back to manage this IPTT
internally.
So how to handle? We're goin
Hi Christian,
thanks a lot for your feedback!
On Tue, Oct 16, 2018 at 7:36 AM Christian Franke
wrote:
> Linus Walleij wrote:
> > ...
> > - I am uncertain if this applies to SAS drives as well,
> >it appears not (Christian Frankes answer) they
> >require a different access method, and I c
88 matches
Mail list logo
