From: "Bryant G. Ly" <b...@catalogicsoftware.com>

There is currently a bug with the driver where there is never a
call to target_sess_cmd_list_set_waiting(), it only called
target_wait_for_sess_cmd(), which basically means that the
sess_wait_list would always be empty.

Thus, list_empty(&sess->sess_wait_list) = true,
(eg: no se_cmd I/O is quiesced, because no se_cmd in sess_wait_list),
since commit 712db3eb2c35 ("scsi: ibmvscsis: Properly deregister
target sessions") in 4.9.y code.

ibmvscsi_tgt does not remove the I_T Nexus when a VM is
active so we can fix this issue by removing the call to
target_wait_for_sess_cmd() altogether.

Signed-off-by: Bryant G. Ly <b...@catalogicsoftware.com>
---
 drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c 
b/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
index fac3773..2175e9e 100644
--- a/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
+++ b/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
@@ -2266,7 +2266,6 @@ static int ibmvscsis_drop_nexus(struct ibmvscsis_tport 
*tport)
        /*
         * Release the SCSI I_T Nexus to the emulated ibmvscsis Target Port
         */
-       target_wait_for_sess_cmds(se_sess);
        target_remove_session(se_sess);
        tport->ibmv_nexus = NULL;
        kfree(nexus);
-- 
1.8.3.1

Reply via email to