[PATCH V3 08/24] aacraid: Added support for response path

This patch enables the driver to actually process the I/O, or srb replies from adapter. In addition to any HBA1000 or SmartIOC2000 adapter events. Signed-off-by: Raghava Aditya Renukunta Signed-off-by: Dave Carroll --- Changes in V2: None Changes in V3: None drivers/scsi/aacraid/aachba.c

[PATCH V3 05/24] aacraid: Retrieve and update the device types

This patch adds support to retrieve the type of each adapter connected device. Applicable to HBA1000 and SmartIOC2000 products Signed-off-by: Raghava Aditya Renukunta Signed-off-by: Dave Carroll Reviewed-by: Johannes Thumshirn --- Changes in V2: Fixed uninitialized return value Changes in V

[PATCH V3 22/24] aacraid: Update copyrights

Added new copyright messages Signed-off-by: Raghava Aditya Renukunta Signed-off-by: Dave Carroll --- Changes in V2: None Changes in V3: None drivers/scsi/aacraid/aachba.c | 8 +++- drivers/scsi/aacraid/aacraid.h | 32 drivers/scsi/aacraid/commctrl.c

[PATCH V3 14/24] aacraid: Added support for hotplug

Added support for drive hotplug add and removal Signed-off-by: Raghava Aditya Renukunta Signed-off-by: Dave Carroll --- Changes in V2: None Changes in V2: None drivers/scsi/aacraid/aachba.c | 13 ++-- drivers/scsi/aacraid/aacraid.h | 17 +- drivers/scsi/aacraid/commsup.c | 136 +

[PATCH V3 13/24] aacraid: Added support to set QD of attached drives

Added support to set qd of drives in slave_configure.This only works for HBA1000 attached drives. Signed-off-by: Raghava Aditya Renukunta Signed-off-by: Dave Carroll --- Changes in V2: None Changes in V3: None drivers/scsi/aacraid/linit.c | 100 ---

[PATCH V3 04/24] aacraid: Added sa firmware support

sa_firmware adds the capability to differentiate the new SmartIOC family of adapters from the series 8 and below. Signed-off-by: Raghava Aditya Renukunta Signed-off-by: Dave Carroll --- Changes in V2: None Changes in V3: Removed unnecessary brackets drivers/scsi/aacraid/aacraid.h | 4 ++

[PATCH V3 17/24] aacraid: Added support to abort cmd and reset lun

Added task management command support to abort any timed out commands in case of a eh_abort call and to reset lun's in case of eh_reset call. Signed-off-by: Raghava Aditya Renukunta Signed-off-by: Dave Carroll --- Changes in V2: Fixed freeing of initialized address Changes in V3: None dri

[PATCH V3 12/24] aacraid: Retrieve Queue Depth from Adapter FW

Retrieved queue depth from fw and saved it for future use. Only applicable for HBA1000 drives. Signed-off-by: Raghava Aditya Renukunta Signed-off-by: Dave Carroll --- Changes in V2: None Changes in V3: None drivers/scsi/aacraid/aachba.c | 84 - driv

[PATCH V3 23/24] aacraid: Change Driver Version Prefix

Change the aacraid driver prefix from 1.2-1 to 1.2.1 Signed-off-by: Raghava Aditya Renukunta Signed-off-by: Dave Carroll --- Changes in V2: None Changes in V3: None drivers/scsi/aacraid/linit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/aacraid/linit.c

[PATCH V3 24/24] aacraid: update version

Update the driver version to 50740 Signed-off-by: Raghava Aditya Renukunta Signed-off-by: Dave Carroll --- Changes in V2: None Changes in V3: None drivers/scsi/aacraid/aacraid.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/aacraid/aacraid.h b/drivers

[PATCH V3 19/24] aacraid: Added new IWBR reset

Added a new IWBR soft reset type, reworked the IOP reset interface for a bit. Signed-off-by: Raghava Aditya Renukunta Signed-off-by: Dave Carroll --- Changes in V2: None Changes in V3: None drivers/scsi/aacraid/aacraid.h | 15 +++-- drivers/scsi/aacraid/commsup.c | 15 +++-- drivers/scsi

[PATCH V3 20/24] aacraid: Added ioctl to trigger IOP/IWBR reset

Added a new ioctl interface to trigger an IOP or IWBR reset from ioctl. Primary used by management utility to trigger resets. Signed-off-by: Raghava Aditya Renukunta Signed-off-by: Dave Carroll --- Changes in V2: None Changes in V3: None drivers/scsi/aacraid/aacraid.h | 1 + drivers/scsi

[PATCH V3 01/24] aacraid: Remove duplicate irq management code

Removed duplicate code that for acquiring and releasing irqs Signed-off-by: Raghava Aditya Renukunta Signed-off-by: Dave Carroll Reviewed-by: Johannes Thumshirn --- Changes in V2: None Changes in V3: None drivers/scsi/aacraid/linit.c | 58 +++- 1 file

[PATCH V3 09/24] aacraid: Added support for read medium error

This patch processes Raw IO read medium errors. Signed-off-by: Raghava Aditya Renukunta Signed-off-by: Dave Carroll --- Changes in V2: None Changes in V3: None drivers/scsi/aacraid/aachba.c | 10 ++ drivers/scsi/aacraid/aacraid.h | 1 + 2 files changed, 11 insertions(+) diff --g

[PATCH V3 07/24] aacraid: Process Error for response I/O

Make sure that the driver processes error conditions even in the fast response path for response from the adapter. Signed-off-by: Raghava Aditya Renukunta Signed-off-by: Dave Carroll Reviewed-by: Johannes Thumshirn --- Changes in V2: None Changes in V3: None drivers/scsi/aacraid/aachba.c

[PATCH V3 11/24] aacraid: Added support for periodic wellness sync

This patch adds a new functions that periodically sync the time of host to the adapter. In addition also informs the adapter that the driver is alive and kicking. Only applicable to the HBA1000 and SMARTIOC2000. Signed-off-by: Raghava Aditya Renukunta Signed-off-by: Dave Carroll --- Changes in

[PATCH V3 00/24] aacraid: Patchset for Smart Family Support

This patchset adds support to the HBA1000 and SMARTIOC2000 family of cards. The driver version is now updated to 50740 Changes in V2: Fixed kbuild test robot warnings Changes in V3: Removed Camel case definitions Misc fixes Raghava Aditya Renukunta (24): [SCSI] aacraid: Remove duplicate irq man

[PATCH V3 16/24] aacraid: Add task management functionality

Added support to send out task management commands. Signed-off-by: Raghava Aditya Renukunta Signed-off-by: Dave Carroll --- Changes in V2: Fixed overflow warning Changes in V3: None drivers/scsi/aacraid/aachba.c | 364 +- 1 file changed, 360 insertio

[PATCH V3 15/24] aacraid: Include HBA direct interface

Added support to send direct pasthru srb commands from management utilty to the controller. Signed-off-by: Raghava Aditya Renukunta Signed-off-by: Dave Carroll --- Changes in V2: None Changes in V3: None drivers/scsi/aacraid/aacraid.h | 175 ++-- drivers/scsi/aacraid/

[PATCH V3 21/24] aacraid: Retrieve HBA host information ioctl

Added a new ioctl interface to retrieve the host device information. Signed-off-by: Raghava Aditya Renukunta Signed-off-by: Dave Carroll --- Changes in V2: None Changes in V3: None drivers/scsi/aacraid/aacraid.h | 52 + drivers/scsi/aacraid/commctrl

[PATCH V3 10/24] aacraid: Reworked aac_command_thread

Reworked aac_command_thread into aac_process_events Signed-off-by: Raghava Aditya Renukunta Signed-off-by: Dave Carroll --- Changes in V2: None Changes in V3: None drivers/scsi/aacraid/commsup.c | 411 ++--- 1 file changed, 217 insertions(+), 194 deletio

[PATCH V3 06/24] aacraid: Reworked scsi command submission path

Moved the READ and WRITE switch cases to the top. Added a default case to the switch case and replaced duplicate scsi result value with a macro. Signed-off-by: Raghava Aditya Renukunta Signed-off-by: Dave Carroll --- Changes in V2: None Changes in V3: None drivers/scsi/aacraid/aachba.c |

[PATCH V3 02/24] aacraid: Added aacraid.h include guard

Added aacraid.h include guard Signed-off-by: Raghava Aditya Renukunta Signed-off-by: Dave Carroll Reviewed-by: Johannes Thumshirn --- Changes in V2: None Changes in V3: None drivers/scsi/aacraid/aacraid.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/scsi/aacraid/aacraid.

[PATCH V3 18/24] aacraid: VPD 83 type3 support

This patch adds support to retrieve the unique identifier data (VPD page 83 type3) for Logical drives created on SmartIOC 2000 products. In addition added a sysfs device structure to expose the id information. Signed-off-by: Raghava Aditya Renukunta Signed-off-by: Dave Carroll --- Changes in

[PATCH V3 03/24] aacraid: added support for init_struct_8

This patch lays the groundwork for supporting the new HBA-1000 controller family.A new INIT structure INIT_STRUCT_8 has been added which allows for a variable size for MSI-x vectors among other things, and is used for both Series-8, HBA-1000 and SmartIOC-2000. Signed-off-by: Raghava Aditya Renuk

[PATCH] target: Add WRITE_VERIFY_16 Support

For clients who want to utilize more than 2GB you need WRITE AND VERIFY 16 support. Reported-by: Michael Cyr Signed-off-by: Bryant G. Ly --- drivers/target/target_core_sbc.c | 1 + include/scsi/scsi_proto.h| 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/target/target_core_

Re: [PATCH] wd719x: add check for dma mapping errors

On Sat, 2017-01-28 at 01:30 +0300, Alexey Khoroshilov wrote: > wd719x_queuecommand() doesn't check if mapping dma memory succeed. > The patch adds the check and failure handling. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov > --- > dri

[PATCH] wd719x: add check for dma mapping errors

wd719x_queuecommand() doesn't check if mapping dma memory succeed. The patch adds the check and failure handling. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/scsi/wd719x.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/

Re: split scsi passthrough fields out of struct request V2

On Wed, 2017-01-25 at 18:25 +0100, Christoph Hellwig wrote: > this series splits the support for SCSI passthrough commands from the > main struct request used all over the block layer into a separate > scsi_request structure that drivers that want to support SCSI passthough > need to embedded as th

Re: [PATCH] target: Add WRITE_VERIFY_16 Support

On Fri, 2017-01-27 at 14:49 -0600, Bryant G. Ly wrote: For clients who want to utilize more than 2GB you need WRITE AND VERIFY 16 support. Hello Bryant, This patch introduces a bug for WRITE AND VERIFY(16) parsing that already exists for WRITE AND VERIFY(10) parsing, namely that the value of

Re: [PATCH] target: Add WRITE_VERIFY_16 Support

On Fri, 2017-01-27 at 14:49 -0600, Bryant G. Ly wrote: > For clients who want to utilize more than 2GB you need > WRITE AND VERIFY 16 support. Hello Bryant, This patch introduces a bug for WRITE AND VERIFY(16) parsing that already exists for WRITE AND VERIFY(10) parsing, namely that the value of

Re: [PATCH v2 2/2] virtio_scsi: Implement fc_host

- Original Message - > From: "Michael S. Tsirkin" > To: "Fam Zheng" > Cc: linux-ker...@vger.kernel.org, "Paolo Bonzini" , > linux-scsi@vger.kernel.org, "James E.J. > Bottomley" , "Jason Wang" , > "Martin K. Petersen" > , stefa...@redhat.com, > virtualizat...@lists.linux-foundation.or

Re: [PATCH] scsi: srp_transport: Fix 'always false comparison' in srp_tmo_valid()

On Fri, 2017-01-27 at 10:06 +, Augusto Mecking Caringi wrote: > On Thu, Jan 26, 2017 at 3:11 PM, Bart Van Assche > wrote: > > This patch is wrong. The purpose of the dev_loss_tmo >= LONG_MAX / HZ check > > is to avoid that the expression 1UL * dev_loss_tmo * HZ further down > > overflows. Can

Re: split scsi passthrough fields out of struct request V3

On Fri, 2017-01-27 at 17:34 +0100, Christoph Hellwig wrote: > this series splits the support for SCSI passthrough commands from the > main struct request used all over the block layer into a separate > scsi_request structure that drivers that want to support SCSI passthough > need to embedded as th

Re: [PATCH 16/18] block/bsg: move queue creation into bsg_setup_queue

On Wed, 2017-01-25 at 18:25 +0100, Christoph Hellwig wrote: > Simply the boilerplate code needed for bsg nodes a bit. Did you perhaps mean "Simplify"? Anyway, nice work! Reviewed-by: Bart Van Assche -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message

Re: [PATCH 15/18] scsi: allocate scsi_cmnd structures as part of struct request

On Wed, 2017-01-25 at 18:25 +0100, Christoph Hellwig wrote: > -unsigned char *scsi_alloc_sense_buffer(struct Scsi_Host *shost, gfp_t > gfp_mask, > -   int numa_node) > +static unsigned char *scsi_alloc_sense_buffer(struct Scsi_Host *shost, > +   gfp_t gfp_mask, int numa_node) >  {

RE: [PATCH V2 05/24] aacraid: Retrieve and update the device types

> -Original Message- > From: Johannes Thumshirn [mailto:jthumsh...@suse.de] > Sent: Friday, January 27, 2017 12:08 AM > To: Raghava Aditya Renukunta > > Cc: j...@linux.vnet.ibm.com; martin.peter...@oracle.com; linux- > s...@vger.kernel.org; Dave Carroll ; Gana > Sridaran ; Scott Benesh >

Re: [PATCH 05/18] block: allow specifying size for extra command data

On Fri, 2017-01-27 at 10:26 -0700, Jens Axboe wrote: > On 01/27/2017 10:21 AM, Bart Van Assche wrote: > > On Fri, 2017-01-27 at 17:12 +0100, Christoph Hellwig wrote: > > > On Wed, Jan 25, 2017 at 10:15:55PM -0500, Martin K. Petersen wrote: > > > > +static void *alloc_request_size(gfp_t gfp_mask, vo

Re: [PATCH 14/18] scsi: remove __scsi_alloc_queue

On Wed, 2017-01-25 at 18:25 +0100, Christoph Hellwig wrote: > diff --git a/include/scsi/scsi_transport.h b/include/scsi/scsi_transport.h > index 8129239..b6e07b5 100644 > --- a/include/scsi/scsi_transport.h > +++ b/include/scsi/scsi_transport.h > @@ -119,4 +119,6 @@ scsi_transport_device_data(struc

Re: [PATCH 13/18] scsi: remove scsi_cmd_dma_pool

On Wed, 2017-01-25 at 18:25 +0100, Christoph Hellwig wrote: > There is no need for GFP_DMA allocations of the scsi_cmnd structures > themselves, all that might be DMAed to or from is the actual payload, > or the sense buffers. Reviewed-by: Bart Van Assche -- To unsubscribe from this list: send the

Re: [PATCH 06/18] dm: remove incomple BLOCK_PC support

On Wed, 2017-01-25 at 18:25 +0100, Christoph Hellwig wrote: > DM tries to copy a few fields around for BLOCK_PC requests, but given > that no dm-target ever wires up scsi_cmd_ioctl BLOCK_PC can't actually > be sent to dm. Reviewed-by: Bart Van Assche -- To unsubscribe from this list: send the line

Re: [PATCH 12/18] scsi: respect unchecked_isa_dma for blk-mq

On Wed, 2017-01-25 at 18:25 +0100, Christoph Hellwig wrote: > Currently blk-mq always allocates the sense buffer using normal GFP_KERNEL > allocation. Refactor the cmd pool code to split the cmd and sense allocation > and share the code to allocate the sense buffers as well as the sense buffer > s

Re: [dm-devel] split scsi passthrough fields out of struct request V2

On Fri, 2017-01-27 at 09:56 -0700, Jens Axboe wrote: > I have no idea what this is, I haven't messed with life time or devices > or queues at all in that branch. The srp-test software passes with kernel v4.9. Something must have changed. I'll see whether I can find some time to look further into t

Re: [PATCH 11/18] scsi: remove gfp_flags member in scsi_host_cmd_pool

On Wed, 2017-01-25 at 18:25 +0100, Christoph Hellwig wrote: > When using the slab allocator we already decide at cache creation time if > an allocation comes from a GFP_DMA pool using the SLAB_CACHE_DMA flag, > and there is no point passing the kmalloc-family only GFP_DMA flag to > kmem_cache_alloc

Re: [PATCH 05/18] block: allow specifying size for extra command data

On Fri, 2017-01-27 at 17:12 +0100, Christoph Hellwig wrote: > On Wed, Jan 25, 2017 at 10:15:55PM -0500, Martin K. Petersen wrote: > > +static void *alloc_request_size(gfp_t gfp_mask, void *data) > > > > I like alloc_request_simple() but alloc_request_size() seems a bit > > contrived. _reserve? _ex

Re: split scsi passthrough fields out of struct request V2

On 01/27/2017 09:42 AM, Christoph Hellwig wrote: > On Fri, Jan 27, 2017 at 09:38:40AM -0700, Jens Axboe wrote: >>> Ok, I'll repost what I have right now, which is on top of a merge >>> of your block/for-4.11/next and your for-next from this morning >>> my time. >> >> Perfect. > > At least I tried,

Re: [PATCH 05/18] block: allow specifying size for extra command data

On 01/27/2017 10:30 AM, Bart Van Assche wrote: > On Fri, 2017-01-27 at 10:26 -0700, Jens Axboe wrote: >> On 01/27/2017 10:21 AM, Bart Van Assche wrote: >>> On Fri, 2017-01-27 at 17:12 +0100, Christoph Hellwig wrote: On Wed, Jan 25, 2017 at 10:15:55PM -0500, Martin K. Petersen wrote: > +sta

Re: split scsi passthrough fields out of struct request V2

On 01/27/2017 09:34 AM, Christoph Hellwig wrote: > On Fri, Jan 27, 2017 at 09:27:02AM -0700, Jens Axboe wrote: >> Feel free to repost it, I have no problem rebasing that branch as it's >> standalone for now. > > Ok, I'll repost what I have right now, which is on top of a merge > of your block/for-

Re: [PATCH 05/18] block: allow specifying size for extra command data

On 01/27/2017 10:21 AM, Bart Van Assche wrote: > On Fri, 2017-01-27 at 17:12 +0100, Christoph Hellwig wrote: >> On Wed, Jan 25, 2017 at 10:15:55PM -0500, Martin K. Petersen wrote: >>> +static void *alloc_request_size(gfp_t gfp_mask, void *data) >>> >>> I like alloc_request_simple() but alloc_reques

Re: [dm-devel] split scsi passthrough fields out of struct request V2

On Fri, 2017-01-27 at 01:04 -0700, Jens Axboe wrote: > The previous patch had a bug if you didn't use a scheduler, here's a > version that should work fine in both cases. I've also updated the > above mentioned branch, so feel free to pull that as well and merge to > master like before. Booting ti

Re: [dm-devel] split scsi passthrough fields out of struct request V2

On 01/27/2017 09:52 AM, Bart Van Assche wrote: > On Fri, 2017-01-27 at 01:04 -0700, Jens Axboe wrote: >> The previous patch had a bug if you didn't use a scheduler, here's a >> version that should work fine in both cases. I've also updated the >> above mentioned branch, so feel free to pull that as

Re: [dm-devel] split scsi passthrough fields out of struct request V2

On Thu, 2017-01-26 at 18:22 -0700, Jens Axboe wrote: > What's your boot device? I've been booting this on a variety of setups, > no problems observed. It's booting my laptop, and on SCSI and SATA as > well. What is your root drive? What is the queue depth of it? > Controller? The boot device in my

Re: split scsi passthrough fields out of struct request V2

On Fri, Jan 27, 2017 at 09:38:40AM -0700, Jens Axboe wrote: > > Ok, I'll repost what I have right now, which is on top of a merge > > of your block/for-4.11/next and your for-next from this morning > > my time. > > Perfect. At least I tried, looks like the mail server is overloaded and crapped ou

Re: [PATCH 07/18] dm: always defer request allocation to the owner of the request_queue

On Fri, Jan 27 2017 at 11:36am -0500, Christoph Hellwig wrote: > On Fri, Jan 27, 2017 at 11:34:34AM -0500, Mike Snitzer wrote: > > Noticed after further review that it seems a bit weird to have the non > > blk-mq support in drivers calling blk_mq_rq_to_pdu(). But I'm not sure > > a blk_rq_to_pdu

Re: split scsi passthrough fields out of struct request V2

On Fri, Jan 27, 2017 at 09:21:46AM -0700, Jens Axboe wrote: > On 01/27/2017 09:17 AM, Christoph Hellwig wrote: > > On Fri, Jan 27, 2017 at 09:11:14AM -0700, Jens Axboe wrote: > >> I've queued this up for 4.11. Since some of the patches had dependencies > >> on changes in master since for-4.11/block

Re: split scsi passthrough fields out of struct request V2

On 01/27/2017 09:17 AM, Christoph Hellwig wrote: > On Fri, Jan 27, 2017 at 09:11:14AM -0700, Jens Axboe wrote: >> I've queued this up for 4.11. Since some of the patches had dependencies >> on changes in master since for-4.11/block was forked, they are sitting >> in a separate branch that has both

Re: [PATCH 07/18] dm: always defer request allocation to the owner of the request_queue

On Fri, Jan 27, 2017 at 11:34:34AM -0500, Mike Snitzer wrote: > Noticed after further review that it seems a bit weird to have the non > blk-mq support in drivers calling blk_mq_rq_to_pdu(). But I'm not sure > a blk_rq_to_pdu() macro to blk_mq_rq_to_pdu() is the right thing. What > do you guys th

Re: [PATCH 07/18] dm: always defer request allocation to the owner of the request_queue

On Wed, Jan 25 2017 at 12:25pm -0500, Christoph Hellwig wrote: > DM already calls blk_mq_alloc_request on the request_queue of the > underlying device if it is a blk-mq device. But now that we allow drivers > to allocate additional data and initialize it ahead of time we need to do > the same fo

Re: split scsi passthrough fields out of struct request V2

On Fri, Jan 27, 2017 at 09:27:02AM -0700, Jens Axboe wrote: > Feel free to repost it, I have no problem rebasing that branch as it's > standalone for now. Ok, I'll repost what I have right now, which is on top of a merge of your block/for-4.11/next and your for-next from this morning my time. Btw

[PATCH 01/19] block: add a op_is_flush helper

This centralizes the checks for bios that needs to be go into the flush state machine. Signed-off-by: Christoph Hellwig Reviewed-by: Bart Van Assche Reviewed-by: Martin K. Petersen --- block/blk-core.c | 8 block/blk-mq-sched.c | 5 ++--- block/blk-mq.c

split scsi passthrough fields out of struct request V3

Hi all, this series splits the support for SCSI passthrough commands from the main struct request used all over the block layer into a separate scsi_request structure that drivers that want to support SCSI passthough need to embedded as the first thing into their request-private data, similar to h

[PATCH 02/19] md: cleanup bio op / flags handling in raid1_write_request

No need for the local variables, the bio is still live and we can just assign the bits we want directly. Make me wonder why we can't assign all the bio flags to start with. Signed-off-by: Christoph Hellwig Reviewed-by: Bart Van Assche Reviewed-by: Martin K. Petersen --- drivers/md/raid1.c | 7

Re: split scsi passthrough fields out of struct request V2

On 01/27/2017 09:23 AM, Christoph Hellwig wrote: > On Fri, Jan 27, 2017 at 09:21:46AM -0700, Jens Axboe wrote: >> On 01/27/2017 09:17 AM, Christoph Hellwig wrote: >>> On Fri, Jan 27, 2017 at 09:11:14AM -0700, Jens Axboe wrote: I've queued this up for 4.11. Since some of the patches had depende

Re: split scsi passthrough fields out of struct request V2

On Fri, Jan 27, 2017 at 09:11:14AM -0700, Jens Axboe wrote: > I've queued this up for 4.11. Since some of the patches had dependencies > on changes in master since for-4.11/block was forked, they are sitting > in a separate branch that has both for-4.11/block and v4.10-rc5 pulled > in first. for-ne

Re: [PATCH 05/18] block: allow specifying size for extra command data

On Wed, Jan 25, 2017 at 10:15:55PM -0500, Martin K. Petersen wrote: > +static void *alloc_request_size(gfp_t gfp_mask, void *data) > > I like alloc_request_simple() but alloc_request_size() seems a bit > contrived. _reserve? _extra? _special? Don't have any good suggestions, > I'm afraid. Not tha

Re: split scsi passthrough fields out of struct request V2

On Wed, Jan 25 2017, Christoph Hellwig wrote: > Hi all, > > this series splits the support for SCSI passthrough commands from the > main struct request used all over the block layer into a separate > scsi_request structure that drivers that want to support SCSI passthough > need to embedded as the

RE: [PATCH 1/2] scsi: scsi_transport_fc: Provide a lightweight option for Virtual FC Hosts.

> -Original Message- > From: Christoph Hellwig [mailto:h...@infradead.org] > Sent: Thursday, January 19, 2017 7:12 AM > To: Cathy Avery > Cc: KY Srinivasan ; Haiyang Zhang > ; j...@linux.vnet.ibm.com; > martin.peter...@oracle.com; de...@linuxdriverproject.org; linux- > ker...@vger.kernel

Re: [PATCH] scsi: srp_transport: Fix 'always false comparison' in srp_tmo_valid()

On Thu, Jan 26, 2017 at 3:11 PM, Bart Van Assche wrote: > This patch is wrong. The purpose of the dev_loss_tmo >= LONG_MAX / HZ check > is to avoid that the expression 1UL * dev_loss_tmo * HZ further down > overflows. Can you check whether changing the if-statement into if (1UL * > dev_loss_tmo >=

Re: [dm-devel] split scsi passthrough fields out of struct request V2

On 01/26/2017 11:40 PM, Jens Axboe wrote: > On 01/26/2017 06:22 PM, Jens Axboe wrote: >> On 01/26/2017 06:15 PM, Bart Van Assche wrote: >>> On Thu, 2017-01-26 at 17:41 -0700, Jens Axboe wrote: On 01/26/2017 05:38 PM, Bart Van Assche wrote: > I see similar behavior with the blk-mq-sched bra

Re: [PATCH V2 05/24] aacraid: Retrieve and update the device types

On Thu, Jan 26, 2017 at 09:00:42PM +, Raghava Aditya Renukunta wrote: > > > > -Original Message- > > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > > ow...@vger.kernel.org] On Behalf Of Raghava Aditya Renukunta > > Sent: Thursday, January 26, 2017 10:44 AM > > To: Johann