Re: [PATCH-v2 2/2] target/iblock: Use -EAGAIN/-ENOMEM to propigate SAM BUSY/TASK_SET_FULL

2016-03-05 Thread Christoph Hellwig
On Sat, Mar 05, 2016 at 02:51:27PM -0800, Nicholas A. Bellinger wrote: > > I think you;d be much better off killing ib_bio_err_cnt and having > > an ib_error that gets set to the last / most server error. > > That's what I was originally thinking too.. > > However, that means if one bio completed

[PATCH] target: Drop incorrect ABORT_TASK put for completed commands

2016-03-05 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch fixes a recent ABORT_TASK regression associated with commit febe562c, where a left-over target_put_sess_cmd() would still be called when __target_check_io_state() detected a command has already been completed, and explicit ABORT must be avoided. Note commit fe

Re: [RFC 22/34] iscsi-target: call Rx thread function

2016-03-05 Thread Nicholas A. Bellinger
On Tue, 2016-03-01 at 07:01 -0800, Christoph Hellwig wrote: > On Sun, Feb 14, 2016 at 11:15:29PM +0530, Varun Prakash wrote: > > call Rx thread function if registered > > by transport driver, so that transport > > drivers can use iscsi-target Rx thread > > for Rx processing. > > > > update iSER ta

[PATCH] sd: Fix discard granularity when LBPRZ=1

2016-03-05 Thread Martin K. Petersen
Commit 397737223c59 ("sd: Make discard granularity match logical block size when LBPRZ=1") accidentally set the granularity to one byte instead of one logical block on devices that provide determistic zeroes after UNMAP. Signed-off-by: Martin K. Petersen Reported-by: Mike Snitzer Fixes: 39773722

Re: [PATCH-v2 2/2] target/iblock: Use -EAGAIN/-ENOMEM to propigate SAM BUSY/TASK_SET_FULL

2016-03-05 Thread Nicholas A. Bellinger
On Sat, 2016-03-05 at 22:01 +0100, Christoph Hellwig wrote: > > - if (atomic_read(&ibr->ib_bio_err_cnt)) > > - status = SAM_STAT_CHECK_CONDITION; > > - else > > + /* > > +* Propigate use these two bio completion values from raw block > > +* drivers to signal up BUSY and TASK

Re: scsi-debug regression with 4.5-rc?

2016-03-05 Thread Martin K. Petersen
> "Mike" == Mike Snitzer writes: Mike> Seems not, I think that BZ may be due to the LBPRZ clause in Mike> commit 397737223 ("sd: Make discard granularity match logical Mike> block size when LBPRZ=1") ? Mike> should be: q->limits.discard_granularity = 1 * logical_block_size; *blush* Will fi

Re: [PATCH] be2iscsi:Add missing error check in beiscsi_eeh_resume

2016-03-05 Thread Martin K. Petersen
> "Nick" == nick writes: Nick> I have a few other patches against trees you are a maintainer of Nick> perhaps you want to take them off my hands? One patch per mail, please. We don't take patches without sufficient reviews. If you want your changes included you will have to convince somebo

Re: [PATCHv2 0/6] SCSI 'access_state' attribute

2016-03-05 Thread Martin K. Petersen
> "Hannes" == Hannes Reinecke writes: Hannes> Hi all, here's the patchset to add an 'access_state' and Hannes> 'preferred_path' attribute. It will display the access state of Hannes> a path if a hardware handler is attached. The access_state is Hannes> given in terms of SCSI ALUA, and the ve

Re: [PATCHv2] scsi_sysfs: add 'is_bin_visible' callback

2016-03-05 Thread Martin K. Petersen
> "Hannes" == Hannes Reinecke writes: Hannes> Add 'is_bin_visible' callback to blank out unsupported vpd Hannes> pages. Applied to 4.6/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a m

Re: [PATCH 08/14] scsi: mvumi: use __maybe_unused to hide pm functions

2016-03-05 Thread Martin K. Petersen
> "Arnd" == Arnd Bergmann writes: Arnd> The mvumi scsi hides the references to its suspend/resume Arnd> functions in an #ifdef but does not hide the implementation the Arnd> same way: Applied to 4.6/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this

Re: [PATCH v4 1/1] scsi: storvsc: Fix a build issue reported by kbuild test robot

2016-03-05 Thread Martin K. Petersen
> "kys" == K Y Srinivasan writes: kys> With this commit, the storvsc driver depends on FC kys> atttributes. Make this dependency explicit. Applied to 4.6/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi"

Re: [RFC 14/34] iscsi-target: export symbols

2016-03-05 Thread Nicholas A. Bellinger
Hi Varun & Co, On Wed, 2016-03-02 at 17:30 +0530, Varun Prakash wrote: > On Tue, Mar 01, 2016 at 08:19:21PM +0530, Christoph Hellwig wrote: > > This looks like pretty random exports and not something like a well > > defined interface to me :( > > I have exported functions which works on iscsi-tar

Re: [RFC 13/34] iscsi-target: add new transport type

2016-03-05 Thread Nicholas A. Bellinger
On Tue, 2016-03-01 at 06:48 -0800, Christoph Hellwig wrote: > This really looks like an odd interface. I think everyone will > be much happpier in the long run if you do a generic offload interface > instead of special casing each possible driver. Yes, I think iscsit_transport_type should to be r

Re: [RFC 18/34] iscsi-target: call complete on conn_logout_comp

2016-03-05 Thread Nicholas A. Bellinger
On Tue, 2016-03-01 at 06:52 -0800, Christoph Hellwig wrote: > On Mon, Feb 15, 2016 at 07:07:19PM +0200, Sagi Grimberg wrote: > > >+ if ((conn->conn_transport->transport_type == ISCSI_TCP) || > > >+ (conn->conn_transport->transport_type == ISCSI_TCP_CXGB4)) > > > complete(&conn->conn

Re: [PATCH-v2 1/2] target: Avoid DataIN transfers for non-GOOD SAM status

2016-03-05 Thread Christoph Hellwig
Looks fine, Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH-v2 2/2] target/iblock: Use -EAGAIN/-ENOMEM to propigate SAM BUSY/TASK_SET_FULL

2016-03-05 Thread Christoph Hellwig
> - if (atomic_read(&ibr->ib_bio_err_cnt)) > - status = SAM_STAT_CHECK_CONDITION; > - else > + /* > + * Propigate use these two bio completion values from raw block > + * drivers to signal up BUSY and TASK_SET_FULL status to the > + * host side initiator. The