On 02/04/2016 03:48 AM, Martin K. Petersen wrote:
>> "Hannes" == Hannes Reinecke writes:
>
> Hannes> If MODE SELECT returns with sense '05/91/36' (command lock
> Hannes> violation) it should always be retried without counting the
> Hannes> number of retries. During an HBA upgrade or similar
When a storage device rejects a WRITE SAME command we will disable write
same functionality for the device and return -EREMOTEIO to the block
layer. -EREMOTEIO will in turn prevent DM from retrying the I/O and/or
failing the path.
Yiwen Jiang discovered a small race where WRITE SAME requests issue
> "Mike" == Mike Snitzer writes:
Mike> The SCSI, or block layer, should return a non-retryable error for
Mike> this case. But we only have the differentiated IO errors for SCSI
Mike> cmds that are issued, so it seems we still need to train SCSI (and
Mike> block by association/dependency) to
On Wed, Feb 03 2016 at 10:49pm -0500,
jiangyiwen wrote:
> On 2016/2/4 11:24, Mike Snitzer wrote:
> > On Wed, Feb 03 2016 at 9:08pm -0500,
> > jiangyiwen wrote:
> >
> >> When two processes submit WRTIE SAME bio simultaneously and
> >> first IO return failed because of INVALID FIELD IN CDB, and
On 2016/2/4 11:24, Mike Snitzer wrote:
> On Wed, Feb 03 2016 at 9:08pm -0500,
> jiangyiwen wrote:
>
>> When two processes submit WRTIE SAME bio simultaneously and
>> first IO return failed because of INVALID FIELD IN CDB, and
>> then second IO can enter into an infinite loop.
>> The problem can
On Wed, Feb 03 2016 at 9:08pm -0500,
jiangyiwen wrote:
> When two processes submit WRTIE SAME bio simultaneously and
> first IO return failed because of INVALID FIELD IN CDB, and
> then second IO can enter into an infinite loop.
> The problem can be described as follows:
>
> process 1
> "Dan" == Dan Carpenter writes:
Dan> BFA_MFG_NAME is "QLogic" which is only 7 bytes, but we are copying
Dan> 8 bytes. It's harmless because the badding byte is likely zero but
Dan> it makes static checkers complain.
Applied to 4.6/scsi-queue.
--
Martin K. Petersen Oracle Linux Engin
> "Hannes" == Hannes Reinecke writes:
Hannes> If MODE SELECT returns with sense '05/91/36' (command lock
Hannes> violation) it should always be retried without counting the
Hannes> number of retries. During an HBA upgrade or similar
Hannes> circumstances one might see a flood of MODE SELECT
> "Kirill" == Kirill A Shutemov writes:
Kirill> It didn't help me.
OK, that's fine. I'll queue your patch if we can get somebody to review
it...
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a mes
> "Sumit" == Sumit Saxena writes:
Sumit,
Sumit> Patch looks good but it needs to be rebased with latest repo as
Sumit> very recently you have checked in few megaraid_sas patches and
Sumit> there are two critical patches for megaraid_sas are yet pending.
You still need to respond to Tomas' c
When two processes submit WRTIE SAME bio simultaneously and
first IO return failed because of INVALID FIELD IN CDB, and
then second IO can enter into an infinite loop.
The problem can be described as follows:
process 1 process 2
submit_bio(REQ_WRITE_SAME) and
wait io c
Hi Kai,
Tested with patched kernel 4.5.0-rc2-next-20160202+. It's looking good
everything partition related passed with DDS5 and LTO6. You can definitely add
me as a tested-by. I did find one issue below but it's not related to the
partitioning changes.
# ./mt -f /dev/st0 stsetoption debug
# .
The enum values for VIOSRP_LINUX_FORMAT and VIOSRP_INLINE_FORMAT are
off by one. They are currently defined as 0x06 and 0x07 respetively.
These values are defined in PAPR correctly as 0x05 and 0x06. This
inconsistency has gone unnoticed as neither enum is currently used.
The possible future support
Add defines for mad version and mad os_type, and replace the magic
numbers in set_adapter_info() accordingly.
Signed-off-by: Tyrel Datwyler
---
drivers/scsi/ibmvscsi/ibmvscsi.c | 4 ++--
drivers/scsi/ibmvscsi/viosrp.h | 2 ++
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drive
The PAPR defines four valid header values for the first byte of a
CRQ message. Namely, an unused/empty message (0x00), a valid
command/response entry (0x80), a valid initialization entry (0xC0),
and a transport event (0xFF). Define these values as enums and use
them in the code in place of their ma
A VIOSRP_HOST_CONFIG_TYPE management datagram (MAD) has existed in
the code for some time. From what information I've gathered from
Brian King this was likely implemented on the host side in a SLES 9
based VIOS, which is no longer supported anywhere. Further, it is
not defined in PAPR or supported
The values returned by the show functions for the host os_type,
mad_version, and partition_number attributes get their values
directly from the madapter_info struct whose associated fields are
__be32 typed. Added endian conversion to ensure these values are
sane on LE platforms.
Signed-off-by: Tyr
The root node of the OF device tree is exported as of_root. No need
to look up the root by path name. Instead just get a reference
directly via of_root.
Signed-off-by: Tyrel Datwyler
---
drivers/scsi/ibmvscsi/ibmvscsi.c | 14 ++
1 file changed, 6 insertions(+), 8 deletions(-)
diff -
Fixed up a couple spots that were out of line with the PAPR in regards
to its defined VSCSI protocol. Did away with some magic numbers directly
in the code. Fixed a minor endian issue.
Tyrel Datwyler (6):
ibmvscsi: Correct values for several viosrp_crq_format enums
ibmvscsi: Add and use enums
James Bottomley wrote:
> On Wed, 2016-02-03 at 23:38 +0100, Sebastian Herbszt wrote:
> > James Bottomley wrote:
> > > On Mon, 2016-02-01 at 19:43 -0800, Bart Van Assche wrote:
> > > > On 01/19/16 17:03, James Bottomley wrote:
> > > > > On Tue, 2016-01-19 at 19:30 -0500, Martin K. Petersen wrote:
>
From: Raghava Aditya Renukunta
Added support for PCI EEH(extended error handling).
Changes in V2:
Made local functions static
Removed call to aac_fib_free_tag
Set adapter_shutdown flag when PCI error detected
Changes in V3:
None
Changes in V4:
Removed setting of adapter_shutdown flag when \
P
From: Raghava Aditya Renukunta
Updated diver version to 41052
Changes in V2:
None
Changes in V3:
None
Changes in V4:
None
Changes in V5:
None
Changes in V6:
None
Signed-off-by: Raghava Aditya Renukunta
Reviewed-by: Johannes Thumshirn
---
drivers/scsi/aacraid/aacraid.h | 2 +-
1 file chan
From: Raghava Aditya Renukunta
During EEH PCI hotplug activity kernel unloads and loads the driver,
causing character device to be unregistered(aac_remove_one).When the
driver is loaded back using aac_probe_one the character device needs
to be registered again for the AIF management tools to work
From: Raghava Aditya Renukunta
aac_fib_map_free() calls pci_free_consistent() without checking that
dev->hw_fib_va is not NULL and dev->max_fib_size is not zero.If they
are indeed NULL/0, this will result in a hang as pci_free_consistent()
will attempt to invalidate cache for the entire 64-bit ad
aac_mutex was used to create protect the ioctl path for only the
compat path, it would be make more sense to place mutex in
aac_do_ioctl, which is the main ioctl function call that handles
all ioctl commands.
Created new mutex ioctl_mutex in struct aac_dev to protect switch
case in aac_do_ioctl an
From: Raghava Aditya Renukunta
The driver utilizes an array of atomic variables to keep track of
IO submissions to each vector. To submit an IO multiple threads
iterate through the array to find a vector which has empty slots
to send an IO. The reading and updating of the variable is not atomic,
From: Raghava Aditya Renukunta
The method to allocate and free FIB's in the present code utilizes
spinlocks.Multiple IO's have to wait on the spinlock to acquire or
free fibs creating a performance bottleneck.
An alternative solution would be to use block layer tags to keep track
of the fibs all
From: Raghava Aditya Renukunta
Series 7 does not support PCI hot reset used by EEH.
Enabled fundamental reset only for Series 7
Changes in V2:
None
Changes in V3:
None
Changes in V4:
None
Changes in V5:
None
Changes in V6:
None
Signed-off-by: Raghava Aditya Renukunta
Reviewed-by: Johannes
This patchset includes the following changes (bug fixes and new feature
support) specific to aacraid driver
V2:
Removed aac_fib_free_tag function
Setup relevant fib variables only once
Created aac_fib_vector_assign function
Made EEH functions static
Added character device status macros
changed lo
On Wed, 2016-02-03 at 23:38 +0100, Sebastian Herbszt wrote:
> James Bottomley wrote:
> > On Mon, 2016-02-01 at 19:43 -0800, Bart Van Assche wrote:
> > > On 01/19/16 17:03, James Bottomley wrote:
> > > > On Tue, 2016-01-19 at 19:30 -0500, Martin K. Petersen wrote:
> > > > > > > > > > "Bart" == Bart
From: Raghava Aditya Renukunta
During EEH recovery number of online CPU's might change thereby changing
the number of MSIx vectors. Since each fib is allocated to a vector,
changes in the number of vectors causes fib to be sent thru invalid
vectors.In addition the correct number of MSIx vectors i
From: Raghava Aditya Renukunta
while driver removal is in progress or PCI shutdown is invoked, driver
kills AIF aacraid thread, but IOCTL requests from the management tools
re-start AIF thread leading to IOP_RESET.
Fixed by setting adapter_shutdown flag when PCI shutdown is invoked.
Changes in
Hello Tomas,
> -Original Message-
> From: Tomas Henzl [mailto:the...@redhat.com]
> Sent: Wednesday, February 3, 2016 2:55 AM
> To: Raghava Aditya Renukunta; james.bottom...@hansenpartnership.com;
> martin.peter...@oracle.com; linux-scsi@vger.kernel.org
> Cc: Mahesh Rajashekhara; Murthy Bha
> -Original Message-
> From: Tomas Henzl [mailto:the...@redhat.com]
> Sent: Wednesday, February 3, 2016 2:38 AM
> To: Raghava Aditya Renukunta; james.bottom...@hansenpartnership.com;
> martin.peter...@oracle.com; linux-scsi@vger.kernel.org
> Cc: Mahesh Rajashekhara; Murthy Bhat; Gana Srid
James Bottomley wrote:
> On Mon, 2016-02-01 at 19:43 -0800, Bart Van Assche wrote:
> > On 01/19/16 17:03, James Bottomley wrote:
> > > On Tue, 2016-01-19 at 19:30 -0500, Martin K. Petersen wrote:
> > > > > > > > > "Bart" == Bart Van Assche
> > > > > > > > > writes:
> > > >
> > > > Bart> Instead o
> "Ruediger" == Ruediger Meier writes:
Ruediger> In past (kernel<=4.1) optimal_io_size io size was 32768. Is
Ruediger> this really correct now?
We recently bumped the scsi_debug optimal I/O size to something akin to
what real-world storage reports.
--
Martin K. Petersen Oracle Linux E
On Monday 01 February 2016, Martin K. Petersen wrote:
> > "Ruediger" == Ruediger Meier writes:
>
> Ruediger> I've noticed a possible problem with scsi_debug devices
> where Ruediger> optimal_io_size < minimum_io_size.
>
> Ruediger> The problem seems reproducable with kernel 4.4.0 and also
> wi
Martin K. Petersen wrote:
> > "Sebastian" == Sebastian Herbszt writes:
>
> >> The only change from the current workflow is that the DEL transition
> >> (now the reaped flag) is done before the spin lock is dropped which
> >> would fix a tiny window for two threads both trying to remove the
>
Odpoledne dobry,
Rád bych Vás informovali o investici stejných výhod pro nás, a ty me meli
kontaktovat na e-mailu níe tomto, pokud máte zájem.
email: fg.ni...@yandex.com
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel
-8<
--- ref/drivers/scsi/st.c 2015-12-21 18:54:05.068882001 +0200
+++ new/drivers/scsi/st.c 2016-02-03 20:31:33.709018742 +0200
@@ -9,7 +9,7 @@
Steve Hirsch, Andreas Koppenh"ofer, Michael Leodolter, Eyal Lebedinsky,
Mic
Add support in v1 hw driver for ACPI.
A check on whether an ACPI handle is available
for the device is used to decide on whether to
use ACPI reset handler or syscon for hw reset.
Signed-off-by: John Garry
Signed-off-by: Zhangfei Gao
---
drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 67 +
The hisi_sas driver is required to support both
device tree and ACPI. The scanning of the device
properties now uses the Unified Device Properties
API, which serves both OF and ACPI.
Since syscon is not supported by ACPI, syscon is
only used in the driver when device tree is used.
Signed-off-by:
This patchset introduces support for ACPI in the
HiSilicon SAS driver. The driver will support
both device tree and ACPI.
Currently only v1 hw will use ACPI.
John Garry (3):
hisi_sas: use Unified Device Properties API
hisi_sas: add v1 hw ACPI support
hisi_sas: update driver version to 1.2
Signed-off-by: John Garry
Signed-off-by: Zhangfei Gao
---
drivers/scsi/hisi_sas/hisi_sas.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/hisi_sas/hisi_sas.h b/drivers/scsi/hisi_sas/hisi_sas.h
index 5b8affd..02da7e4 100644
--- a/drivers/scsi/hisi_sas/hisi_sas.h
On Wed, 2016-02-03 at 18:17 +0100, Christoph Hellwig wrote:
> On Mon, Feb 01, 2016 at 08:11:29PM -0500, Martin K. Petersen wrote:
> > I am concerned about queuing something as a stable fix if it is
> > just
> > masking a fundamental underlying problem.
>
> It's not masking a fundamental problem.
++ Vinayak Holikatti
Hi Vinayak,
Could I please get your opinion about the patch set?
thanks.
On 2/3/2016 3:39 PM, Arnd Bergmann wrote:
> On Wednesday 03 February 2016 15:01:34 Joao Pinto wrote:
>>
>> Hi Arnd,
>>
>> On 2/3/2016 12:54 PM, Arnd Bergmann wrote:
>>> On Wednesday 03 February 2016 1
On Mon, Feb 01, 2016 at 08:11:29PM -0500, Martin K. Petersen wrote:
> I am concerned about queuing something as a stable fix if it is just
> masking a fundamental underlying problem.
It's not masking a fundamental problem. It fixes the target
state so that we can mark a starget as being under del
On Wed, 3 Feb 2016, Oliver Neukum wrote:
> On Tue, 2016-01-26 at 10:28 -0500, Alan Stern wrote:
> > On Tue, 26 Jan 2016, Oliver Neukum wrote:
>
> > > That is problematic. The ABORT_TMF does need IO for which we need
> > > to wait. And if we just submit and pretend the abort worked, the tag
> > >
Hi,
On 2/3/2016 3:39 PM, Arnd Bergmann wrote:
> On Wednesday 03 February 2016 15:01:34 Joao Pinto wrote:
>>
>> Hi Arnd,
>>
>> On 2/3/2016 12:54 PM, Arnd Bergmann wrote:
>>> On Wednesday 03 February 2016 11:28:26 Joao Pinto wrote:
Signed-off-by: Joao Pinto
>>>
>>> This needs a changelog
On Wednesday 03 February 2016 15:01:34 Joao Pinto wrote:
>
> Hi Arnd,
>
> On 2/3/2016 12:54 PM, Arnd Bergmann wrote:
> > On Wednesday 03 February 2016 11:28:26 Joao Pinto wrote:
> >>
> >> Signed-off-by: Joao Pinto
> >
> > This needs a changelog comment, like every patch.
> >
> >> @@ -0,0 +1,16
On Tue, Feb 2, 2016 at 10:48 PM, Kirill A. Shutemov
wrote:
> On Tue, Feb 02, 2016 at 09:45:48PM -0500, Martin K. Petersen wrote:
>> > "Kirill" == Kirill A Shutemov writes:
>>
>> Kirill> I have the same problem.
>>
>> Kirill> Shouldn't we put quirk for that?
>>
>> I was hoping that Hannes' pat
On 02/03/2016 02:32 PM, Sagi Grimberg wrote:
>
>> Indeed, something like this.
>> Quite some issues would be solved if we could push a hctx mapping
>> into blk-mq, instead of having it assign its own made-up one.
>
> For that you can provide your own .map_queue in blk_mq_ops I think
> (no one doe
Hi Arnd,
On 2/3/2016 12:54 PM, Arnd Bergmann wrote:
> On Wednesday 03 February 2016 11:28:26 Joao Pinto wrote:
>>
>> Signed-off-by: Joao Pinto
>
> This needs a changelog comment, like every patch.
>
>> @@ -0,0 +1,16 @@
>> +* Universal Flash Storage (UFS) DesignWare Host Controller
>> +
>> +DWC
On Tue, 2016-01-26 at 10:28 -0500, Alan Stern wrote:
> On Tue, 26 Jan 2016, Oliver Neukum wrote:
> > That is problematic. The ABORT_TMF does need IO for which we need
> > to wait. And if we just submit and pretend the abort worked, the tag
> > will be reused.
> > Perhaps we could drop the spinlock
Indeed, something like this.
Quite some issues would be solved if we could push a hctx mapping
into blk-mq, instead of having it assign its own made-up one.
For that you can provide your own .map_queue in blk_mq_ops I think
(no one does that at the moment). This requires every driver to
implem
On 02/03/2016 01:57 PM, Sagi Grimberg wrote:
> Hi Bart and Hannes,
>
>> This topic indeed needs further attention. I also encountered this
>> challenge while adding scsi-mq support to the SRP initiator
>> driver. What
>> I learned while working on the SRP driver is the following:
>> - Although I a
Hi Bart and Hannes,
This topic indeed needs further attention. I also encountered this
challenge while adding scsi-mq support to the SRP initiator driver. What
I learned while working on the SRP driver is the following:
- Although I agree that requests and interrupts should be processed on
th
On Wednesday 03 February 2016 11:28:26 Joao Pinto wrote:
>
> Signed-off-by: Joao Pinto
This needs a changelog comment, like every patch.
> @@ -0,0 +1,16 @@
> +* Universal Flash Storage (UFS) DesignWare Host Controller
> +
> +DWC_UFSHC nodes are defined to describe on-chip UFS host controllers.
https://bugzilla.kernel.org/show_bug.cgi?id=111341
--- Comment #1 from walter59 ---
error in kernel 4.5_rc2 not cleaned --- same error as in rc1
--
You are receiving this mail because:
You are watching the assignee of the bug.
--
To unsubscribe from this list: send the line "unsubscribe linux-s
Calling synchronize_irq() right before free_irq() is quite useless. On one
hand the IRQ can easily fire again before free_irq() is entered, on the
other hand free_irq() itself calls synchronize_irq() internally (in a race
condition free way), before any state associated with the IRQ is freed.
Patc
Calling synchronize_irq() right before free_irq() is quite useless. On one
hand the IRQ can easily fire again before free_irq() is entered, on the
other hand free_irq() itself calls synchronize_irq() internally (in a race
condition free way), before any state associated with the IRQ is freed.
Patc
Signed-off-by: Joao Pinto
---
drivers/scsi/ufs/ufshcd-pltfrm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/ufs/ufshcd-pltfrm.c b/drivers/scsi/ufs/ufshcd-pltfrm.c
index d2a7b12..0522891 100644
--- a/drivers/scsi/ufs/ufshcd-pltfrm.c
+++ b/drivers/scsi/ufs/ufshc
The work consisted of:
- Tweak ufshcd.c for UFS 2.0 support
- Implement ufshcd-dwc which contains all DWC HW specific code
- Implement a ufs-dwc glue platform driver
Joao Pinto (3):
fixed typo
added support for ufs 2.0
add support for DWC UFS Host Controller
Documentation/devicetree/bindin
Signed-off-by: Joao Pinto
---
drivers/scsi/ufs/ufshcd.c | 29 +
drivers/scsi/ufs/ufshci.h | 1 +
2 files changed, 26 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 85cd256..2b5f2bf 100644
--- a/drivers/scsi/ufs
Signed-off-by: Joao Pinto
---
Documentation/devicetree/bindings/ufs/ufs-dwc.txt | 16 +
MAINTAINERS | 6 +
drivers/scsi/ufs/Kconfig | 45 ++
drivers/scsi/ufs/Makefile | 2 +
drivers/scsi/ufs/ufs-dwc.c
On 3.2.2016 01:58, Raghava Aditya Renukunta wrote:
> From: Raghava Aditya Renukunta
>
> while driver removal is in progress or PCI shutdown is invoked, driver
> kills AIF aacraid thread, but IOCTL requests from the management tools
> re-start AIF thread leading to IOP_RESET.
>
> Fixed by setting a
On 3.2.2016 01:58, Raghava Aditya Renukunta wrote:
> aac_mutex was used to create protect the ioctl path for only the
> compat path, it would be make more sense to place mutex in
> aac_do_ioctl, which is the main ioctl function call that handles
> all ioctl commands.
>
> Created new mutex ioctl_mut
67 matches
Mail list logo
