RE: [PATCH scsi] libcxgbi : support ipv6 address host_param

> On 10/16/2014 05:59 PM, Anish Bhatt wrote: > > libcxgbi was always returning an ipv4 address for > > ISCSI_HOST_PARAM_IPADDRESS, return appropriate address based on > > address family > > > > Signed-off-by: Anish Bhatt > > Signed-off-by: Karen Xie > > --- > > drivers/scsi/cxgbi/libcxgbi.c | 42

RE: [PATCH 27/27] scsi: ratelimit I/O error messages

> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] > Sent: Friday, 24 October, 2014 7:27 AM > To: James Bottomley > Cc: Christoph Hellwig; Elliott, Robert (Server Storage); linux- > s...@vger.kernel.org; Hannes Reinecke > Subject: [PATCH 27/27] scsi: ratelimit I/O error mess

Re: virtio_blk - kernel BUG at drivers/virtio/virtio_ring.c:160!

On Wed, Oct 22, 2014 at 08:57:07AM +0800, Ming Lei wrote: > On Wed, Oct 22, 2014 at 4:05 AM, Jens Axboe wrote: > > On 10/17/2014 07:27 AM, Christoph Hellwig wrote: > >> On Thu, Oct 16, 2014 at 11:17:39AM -0400, Brian Foster wrote: > >>> Hi all, > >>> > >>> Hopefully this is the right list for this

Re: Concurrent SG_SCSI_RESET ioctls

On 14-10-24 04:51 PM, Christoph Hellwig wrote: On Tue, Oct 14, 2014 at 12:42:26PM -0400, Douglas Gilbert wrote: I don't mind if you change it. However I plan to release sg3_utils-1.40 in the next 2 or 3 weeks, so that would be the earliest a revised sg_reset would be available for distros. Impro

Re: [PATCH v2 10/12] IB/srp: Use block layer tags

On 10/24/14 2:45 AM, Bart Van Assche wrote: On 10/23/14 19:43, Webb Scales wrote: On 10/23/14 3:16 AM, Bart Van Assche wrote: All my tests with use_blk_mq=n were run with a WARN_ON_ONCE(req->tag < 0) statement present in srp_queuecommand(). I haven't seen any kernel warning being triggered duri

Re: [PATCHv8 00/27] scsi logging update (the boring part)

On Fri, Oct 24, 2014 at 02:26:40PM +0200, Hannes Reinecke wrote: > here is now the eigth iteration of my scsi logging update. > With this I've updated the patch to ratelimit I/O error messages > as suggested by Robert Elliott. > Additionally I've updated it to core-for-3.19 and included the > missi

Re: Concurrent SG_SCSI_RESET ioctls

On Tue, Oct 14, 2014 at 12:42:26PM -0400, Douglas Gilbert wrote: > I don't mind if you change it. However I plan to release > sg3_utils-1.40 in the next 2 or 3 weeks, so that would > be the earliest a revised sg_reset would be available for > distros. Improving error reports is something I always >

[PATCH 17/27] scsi: repurpose the last argument from print_opcode_name()

print_opcode_name() was only ever called with a '0' argument from LLDDs and ULDs which were _not_ supporting variable length CDBs, so the 'if' clause was never triggered. Instead we should be using the last argument to specify the cdb length to avoid accidental overflow when reading the cdb buffer.

[PATCH 19/27] scsi: separate out scsi_(host|driver)byte_string()

Export functions for later use. Reviewed-by: Robert Elliott Reviewed-by: Christoph Hellwig Signed-off-by: Hannes Reinecke --- drivers/scsi/constants.c | 58 include/scsi/scsi_dbg.h | 2 ++ 2 files changed, 46 insertions(+), 14 deletions(-) di

[PATCH 14/27] Implement scsi_opcode_sa_name

Implement a lookup array for SERVICE ACTION commands instead of hardcoding it in a large switch statement. Reviewed-by: Robert Elliott Reviewed-by: Christoph Hellwig Signed-off-by: Hannes Reinecke --- drivers/scsi/constants.c | 131 +++ 1 file change

[PATCH 13/27] scsi: remove scsi_print_status()

Last caller is gone, so we can remove it. Reviewed-by: Robert Elliott Reviewed-by: Christoph Hellwig Signed-off-by: Hannes Reinecke --- drivers/scsi/constants.c | 35 --- include/scsi/scsi_dbg.h | 1 - 2 files changed, 36 deletions(-) diff --git a/drivers/scs

[PATCH 18/27] scsi: Remove scsi_print_command when calling abort

Calling scsi_print_command should not be necessary during abort; if the information is required one should enable scsi logging. Reviewed-by: Robert Elliott Reviewed-by: Christoph Hellwig Signed-off-by: Hannes Reinecke --- drivers/scsi/53c700.c| 4 +--- drivers/scsi/NCR5380.c |

[PATCH 25/27] scsi: check for correct return code in scsi_eh_abort_cmds()

scsi_try_to_abort_cmd() might return SUCCESS, FAILED, or FAST_IO_FAIL. So just checking for FAILED will treat FAST_IO_FAIL as SUCCESS, which is wrong. Cc: Robert Elliott Signed-off-by: Hannes Reinecke --- drivers/scsi/scsi_error.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --gi

[PATCH 24/27] scsi_error: document scsi_try_to_abort_cmd

scsi_try_to_abort_cmd() should only return SUCCESS, FAILED, or FAST_IO_FAIL. So document that in the function description and simplify the logging message. Suggested-by: Christoph Hellwig Reviewed-by: Robert Elliott Reviewed-by: Christoph Hellwig Signed-off-by: Hannes Reinecke --- drivers/scs

[PATCH 26/27] scsi: correct return values for .eh_abort_handler implementations

The .eh_abort_handler needs to return SUCCESS, FAILED, or FAST_IO_FAIL. So fixup all callers to adhere to this requirement. Cc: Robert Elliott Cc: Signed-off-by: Hannes Reinecke --- drivers/scsi/NCR5380.c| 2 +- drivers/scsi/aha1740.c| 2 +- drivers/scsi/esas2r/esas2r_m

[PATCH 20/27] Remove scsi_show_result()

Open-code scsi_print_result in sd.c, and cleanup logging to not print duplicate informations. Also remove the call to scsi_show_result() in ufshcd.c to be consistent with other callers of scsi_execute(). With that we can remove scsi_show_result in constants.c Reviewed-by: Robert Elliott Reviewed

[PATCH 11/27] scsi: do not decode sense extras

Currently we're only decoding sense extras for tape devices. And even there only for fixed format sense formats. As this is of rather limited use in the general case we should be stop trying to decode sense extras; the tape driver does its own decoding anyway. Reviewed-by: Robert Elliott Reviewed

[PATCH 03/27] aha152x: Debug output update and whitespace cleanup

Remove all uncommented debugging code and move all printk() statements over to dev_printk(). And while we're at it we should be doing a whitespace cleanup, too. Reviewed-by: Robert Elliott Reviewed-by: Christoph Hellwig Signed-off-by: Hannes Reinecke --- drivers/scsi/aha152x.c | 994 ++

[PATCH 15/27] scsi: merge print_opcode_name()

Instead of having two versions of print_opcode_name() we should be consolidating them into one version. Reviewed-by: Robert Elliott Reviewed-by: Christoph Hellwig Signed-off-by: Hannes Reinecke --- drivers/scsi/constants.c | 88 ++-- 1 file changed,

[PATCH 27/27] scsi: ratelimit I/O error messages

There can be quite a lot of I/O error messages, even on smaller machines. So we need to ratelimit them to not overwhelm logging. Cc: Robert Elliott Signed-off-by: Hannes Reinecke --- drivers/scsi/scsi_lib.c | 32 1 file changed, 20 insertions(+), 12 deletions(-)

[PATCH 16/27] scsi: consolidate opcode lookup in scsi_opcode_sa_name()

Consolidate the CDB opcode lookup in scsi_opcode_sa_name(), so that we don't have to call several functions to figure out the CDB opcode string. Reviewed_by: Robert Elliott Reviewed-by: Christoph Hellweg Signed-off-by: Hannes Reinecke --- drivers/scsi/constants.c | 37 ++---

[PATCH 08/27] fas216: Update logging messages

Update logging messages to use dev_printk() variants for correct device annotations. Reviewed-by: Robert Elliott Reviewed-by: Christoph Hellwig Signed-off-by: Hannes Reinecke --- drivers/scsi/arm/fas216.c | 26 +++--- 1 file changed, 11 insertions(+), 15 deletions(-) diff

[PATCH 12/27] scsi: use 'bool' as return value for scsi_normalize_sense()

Convert scsi_normalize_sense() and friends to return 'bool' instead of an integer. Reviewed-by: Robert Elliott Reviewed-by: Yoshihiro Yunomae Reviewed-by: Christoph Hellwig Signed-off-by: Hannes Reinecke --- drivers/scsi/scsi_error.c | 16 drivers/scsi/scsi_lib.c | 2 +- i

[PATCH 22/27] scsi: fixup logging messages in scsi_error.c

Use the matching scope for logging messages to allow for better command tracing. Suggested-by: Robert Elliott Reviewed-by: Robert Elliott Reviewed-by: Christoph Hellwig Signed-off-by: Hannes Reinecke --- drivers/scsi/hosts.c | 4 +-- drivers/scsi/scsi_error.c | 77 ++

[PATCH 23/27] scsi: use shost argument in scsi_eh_prt_fail_stats

The EH statistics are per host, so we should be using shost_printk() here. Suggested-by: Robert Elliott Reviewed-by: Robert Elliott Reviewed-by: Christoph Hellwig Signed-off-by: Hannes Reinecke --- drivers/scsi/scsi_error.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/d

[PATCH 21/27] scsi: simplify scsi_log_(send|completion)

Simplify scsi_log_(send|completion) by externalizing scsi_mlreturn_string() and always print the command address. Reviewed-by: Robert Elliott Reviewed-by: Christoph Hellwig Signed-off-by: Hannes Reinecke --- drivers/scsi/constants.c | 41 ++--- drivers/scsi/

[PATCH 01/27] Remove scsi_cmd_print_sense_hdr()

Unused. Reviewed-by: Robert Elliott Reviewed-by: Christoph Hellwig Signed-off-by: Hannes Reinecke --- drivers/scsi/constants.c | 14 -- include/scsi/scsi_dbg.h | 2 -- 2 files changed, 16 deletions(-) diff --git a/drivers/scsi/constants.c b/drivers/scsi/constants.c index d35a5d6

[PATCHv8 00/27] scsi logging update (the boring part)

here is now the eigth iteration of my scsi logging update. With this I've updated the patch to ratelimit I/O error messages as suggested by Robert Elliott. Additionally I've updated it to core-for-3.19 and included the missing hunks for ufs as requested by Christoph Hellwig. Hannes Reinecke (27):

[PATCH 07/27] fas216: Return DID_ERROR for incomplete data transfer

fas216 returns DID_BAD_TARGET for an incomplete data transfer. The midlayer uses DID_BAD_TARGET to signal a non-existing or not reachable target. So we should rather be using DID_ERROR here. Reviewed-by: Robert Elliott Reviewed-by: Christoph Hellwig Signed-off-by: Hannes Reinecke --- drivers/s

[PATCH 04/27] scsi: introduce sdev_prefix_printk()

Like scmd_printk(), but the device name is passed in as a string. Can be used by eg ULDs which do not have access to the scsi_cmnd structure. Reviewed-by: Robert Elliott Reviewed-by: Christoph Hellwig Signed-off-by: Hannes Reinecke --- drivers/scsi/ch.c | 3 +-- drivers/scsi/sd.h

[PATCH 02/27] sd: Remove scsi_print_sense() in sd_done()

sd_done() was calling scsi_print_sense() for a sense code of 'NO_SENSE'. Reviewed-by: Robert Elliott Reviewed-by: Christoph Hellwig Signed-off-by: Hannes Reinecke --- drivers/scsi/sd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index cfba74c..52b40

[PATCH 05/27] scsi: Use sdev as argument for sense code printing

We should be using the standard dev_printk() variants for sense code printing. Reviewed-by: Robert Elliott Reviewed-by: Christoph Hellwig Signed-off-by: Hannes Reinecke --- drivers/scsi/53c700.c | 2 +- drivers/scsi/ch.c | 2 +- drivers/scsi/constants.c | 117 ++

[PATCH 06/27] acornscsi: use scsi_print_command()

Update acornscsi to use scsi_print_command() instead of the underscore version and use scmd_printk() in acornscsi_done(). This will add correct device annotations in the resulting message. And we should be using set_host_byte() for setting the final result. Reviewed-by: Robert Elliott Reviewed-by

[PATCH 10/27] scsi: stop decoding if scsi_normalize_sense() fails

If scsi_normalize_sense() fails we couldn't decode the sense buffer, and the scsi_sense_hdr fields are invalid. For those cases we should rather dump the sense buffer and not try to decode invalid fields. Reviewed-by: Robert Elliott Reviewed-by: Christoph Hellwig Signed-off-by: Hannes Reinecke

[PATCH 09/27] 53c700: remove scsi_print_sense() usage

The 53c700 driver would be using scsi_print_sense() in a debug statement, which was never compiled in. Plus the same information can get retrieved with logging. So remove it. Reviewed-by: Robert Elliott Reviewed-by: Christoph Hellwig Signed-off-by: Hannes Reinecke --- drivers/scsi/53c700.c | 9

Re: [PATCH] lib/scatterlist: fix memory leak with scsi-mq

On Thu, Oct 23, 2014 at 03:10:21PM -0400, Tony Battersby wrote: > Fix a memory leak with scsi-mq triggered by commands with large data > transfer length. Thanks, this was indeed caused by a last minute change due to someone complaining about my earlier version being a little too convoluted. Thank

Re: [PATCH 0/6] various fixes for UFS-PM series

On Fri, Oct 24, 2014 at 07:53:23AM -, Dolev Raviv wrote: > The first patch is Akinobu Mita's patch. > You can add my ack on it. Given that you passed them on to me you should normally sign off on them as well. Btw, MAINTAINERS doesn't mention you for the ufs driver, should it? -- To unsubscri

Re: [PATCH 0/6] various fixes for UFS-PM series

> On Thu, Oct 23, 2014 at 01:25:11PM +0300, Dolev Raviv wrote: >> Contains a couple of bug fixes reported by Akinobu Mita, In adition to >> "static checker" warnings reported by Dan Carpenter. > > Any reason you didn't add a signoff to the first patch? The first patch is Akinobu Mita's patch. You