On 10/24/14 2:45 AM, Bart Van Assche wrote:
On 10/23/14 19:43, Webb Scales wrote:
On 10/23/14 3:16 AM, Bart Van Assche wrote:
All my tests with use_blk_mq=n were run with a WARN_ON_ONCE(req->tag <
0) statement present in srp_queuecommand(). I haven't seen any kernel
warning being triggered during the tests I ran.

Bart, what's the data type of "req->tag", here?  (E.g., if it
"unsigned", it will never be less than zero, right?)

Hello Webb,

This is what I found in "struct request" in <linux/blkdev.h>:

struct request {
    [ ... ]
    int tag;
    [ ... ]
};

Bart.
Good: I just wanted to make sure that you weren't referencing the "tag" field in the "scsi_cmnd" struct (which _is_ unsigned).


                Webb
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to