Re: [PATCH 2/7] scsi: ufs: find out sense data over scsi status values

2013-07-28 Thread Subhash Jadavani
On 7/26/2013 7:16 PM, Seungwon Jeon wrote: Except for 'GOOD' and 'CHECK CONDITION', other status value This is what UFS device spec says: "A GOOD status indicates successful SCSI completion and therefore no Sense Data will be returned." So please change the commit text accordingly. in Response

Re: [PATCH 1/7] scsi: ufs: amend the ocs handling with fatal error

2013-07-28 Thread Subhash Jadavani
On 7/26/2013 7:15 PM, Seungwon Jeon wrote: Fatal error in OCS(overall command status) field indicates error conditions which is not covered by UFSHCI. It means that host cannot define the result of command status and therefore host may need to check transfer response UPIU's response and status fi

Re: Ejected Nook (usb mass storage) prevents suspend

2013-07-28 Thread Oliver Neukum
On Fri, 2013-07-26 at 16:31 -0400, Alan Stern wrote: > In addition to my earlier comment, the patch below should be applied. > It will fix your immediate problem, although not in the best way. Alan, I think your diagnosis is correct, but not the fix. This is run even in the runtime case. We mi

Re: Ejected Nook (usb mass storage) prevents suspend

2013-07-28 Thread Oliver Neukum
On Fri, 2013-07-26 at 09:54 -0700, Andy Lutomirski wrote: > This is kernel 3.9.9-302.fc19.x86_64. > > I plugged in a BN Nook (a usb mass storage device), used it, and > ejected it. This makes suspend fail: > > [50135.265514] PM: Entering freeze sleep > [50135.265517] Suspending console(s) (use n

[Bug 60644] MPT2SAS drops all HDDs when under high I/O

2013-07-28 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=60644 --- Comment #2 from livea...@live.com --- Kernel locks are rather "soft" , the machine functions but the HDDs activity LED stays on and the kernel doesn't respond to a reboot or shutdown command from console . It has to be hard-reset using the pow

[Bug 60644] MPT2SAS drops all HDDs when under high I/O

2013-07-28 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=60644 --- Comment #1 from livea...@live.com --- Created attachment 107032 --> https://bugzilla.kernel.org/attachment.cgi?id=107032&action=edit dmesg logs -- You are receiving this mail because: You are watching the assignee of the bug. -- To unsubscr

[Bug 60644] New: MPT2SAS drops all HDDs when under high I/O

2013-07-28 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=60644 Bug ID: 60644 Summary: MPT2SAS drops all HDDs when under high I/O Product: SCSI Drivers Version: 2.5 Kernel Version: 3.11 Hardware: x86-64 OS: Linux Tree: Main

Re: Kernel 3.10.3 "reset SuperSpeed USB device number 2 using xhci_hcd"

2013-07-28 Thread Alan Stern
On Sat, 27 Jul 2013, Stuart Foster wrote: > On 07/27/13 20:34, Alan Stern wrote: > > On Sat, 27 Jul 2013, Stuart Foster wrote: > > > >> On 07/27/13 15:58, Alan Stern wrote: > >>> On Sat, 27 Jul 2013, Stuart Foster wrote: > >>> > Hi, > > I have started having problems with an externa

[PATCH 9/9] drivers/scsi/ufs: don't check resource with devm_ioremap_resource

2013-07-28 Thread Santosh Y
From: Wolfram Sang devm_ioremap_resource does sanity checks on the given resource. No need to duplicate this in the driver. Signed-off-by: Wolfram Sang Signed-off-by: Santosh Y diff --git a/drivers/scsi/ufs/ufshcd-pltfrm.c b/drivers/scsi/ufs/ufshcd-pltfrm.c index 34f726c..3da4252 100644 --- a

[PATCH 6/9] ufs: don't disable_irq() if the IRQ can be shared among devices

2013-07-28 Thread Santosh Y
From: Akinobu Mita When removing the UFS driver, disable_irq() is called and the IRQ is not enabled again. Unfortunately, the IRQ is requested with IRQF_SHARED and it can be shared among several devices. So disabling the IRQ in this way is just breaking other devices which are sharing the IRQ.

[PATCH 7/9] ufs: don't stop controller before scsi_remove_host()

2013-07-28 Thread Santosh Y
From: Akinobu Mita scsi_remove_host() sends SYNCHRONIZE CACHE commands for write cache enabled scsi disk devices. So stopping controller working shouldn't be done before scsi_remove_host(). Signed-off-by: Akinobu Mita Cc: Vinayak Holikatti Cc: "James E.J. Bottomley" Cc: linux-scsi@vger.kerne

[PATCH 8/9] ufshcd-pltfrm: remove redundant dev_err call in ufshcd_pltfrm_probe()

2013-07-28 Thread Santosh Y
From: Wei Yongjun There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Signed-off-by: Wei Yongjun Signed-off-by: Santosh Y diff --git a/drivers/scsi/ufs/ufshcd-pltfrm.c b/drivers/scsi/ufs/ufshcd-pltfrm.c index 13b8c5a..34f

[PATCH 4/9] scsi: ufs: Add runtime PM support for UFS host controller driver

2013-07-28 Thread Santosh Y
From: Sujit Reddy Thumma Add runtime PM helpers to suspend/resume UFS controller at runtime. Enable runtime PM by default for pci and platform drivers as the initialized hardware can suspend if it is not used after bootup. Signed-off-by: Sujit Reddy Thumma Signed-off-by: Santosh Y diff --git

[PATCH 3/9] scsi: ufs: Add support for host assisted background operations

2013-07-28 Thread Santosh Y
From: Sujit Reddy Thumma Background operations in the UFS device can be disabled by the host to reduce the response latency of transfer requests. Add support for enabling/disabling the background operations during runtime suspend/resume of the device. If the device is in critical need of BKOPS i

[PATCH 5/9] ufshcd-pci: release ioremapped region during removing driver

2013-07-28 Thread Santosh Y
From: Akinobu Mita Before commit 2953f850c3b80bdca004967c83733365d8aa0aa2 ("[SCSI] ufs: use devres functions for ufshcd"), UFSHCI register was ioremapped by each glue-driver (ufshcd-pltfrm and ufshcd-pci) during probing and it was iounmapped by core-driver during removing driver. The commit conv

[PATCH 0/9] scsi:ufs: query, bkops support and other fixes

2013-07-28 Thread Santosh Y
Hi James, Please apply the following patches to 'misc' branch. Thanks, Santosh Akinobu Mita (3): ufshcd-pci: release ioremapped region during removing driver ufs: don't disable_irq() if the IRQ can be shared among devices ufs: don't stop controller before scsi_remove_host() Dolev Raviv (1

[PATCH 2/9] scsi: ufs: Set fDeviceInit flag to initiate device initialization

2013-07-28 Thread Santosh Y
From: Dolev Raviv Allow UFS device to complete its initialization and accept SCSI commands by setting fDeviceInit flag. The device may take time for this operation and hence the host should poll until fDeviceInit flag is toggled to zero. This step is mandated by UFS device specification for devic

[PATCH 1/9] scsi: ufs: Add support for sending NOP OUT UPIU

2013-07-28 Thread Santosh Y
From: Sujit Reddy Thumma As part of device initialization sequence, sending NOP OUT UPIU and waiting for NOP IN UPIU response is mandatory. This confirms that the device UFS Transport (UTP) layer is functional and the host can configure the device with further commands. Add support for sending NO