On Fri, 2013-07-19 at 14:01 -0700, Nicholas A. Bellinger wrote:
> On Fri, 2013-07-19 at 08:33 -0700, James Bottomley wrote:
> > On Thu, 2013-07-18 at 23:34 -0700, Nicholas A. Bellinger wrote:
> > > diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
> > > index 0101af5..191bc15 10064
When removing the UFS driver, disable_irq() is called and the IRQ is
not enabled again. Unfortunately, the IRQ is requested with IRQF_SHARED
and it can be shared among several devices. So disabling the IRQ in
this way is just breaking other devices which are sharing the IRQ.
Signed-off-by: Akino
scsi_remove_host() sends SYNCHRONIZE CACHE commands for write cache
enabled scsi disk devices. So stopping controller working shouldn't
be done before scsi_remove_host().
Signed-off-by: Akinobu Mita
Cc: Vinayak Holikatti
Cc: Santosh Y
Cc: "James E.J. Bottomley"
Cc: linux-scsi@vger.kernel.org
Before commit 2953f850c3b80bdca004967c83733365d8aa0aa2 ("[SCSI] ufs:
use devres functions for ufshcd"), UFSHCI register was ioremapped by
each glue-driver (ufshcd-pltfrm and ufshcd-pci) during probing and it
was iounmapped by core-driver during removing driver. The commit
converted ufshcd-pltfrm t
The changes in this patch set are almost same as the previous one
that I send on Jul 8. But the previous version wasn't cleanly applied
to the upstream kernel because it depend on my local work in progress
patches. So this version fixes it and it also includes another bug fix
in the same area.
A
On Fri, 19 July 2013 18:06:59 -0400, Jörn Engel wrote:
>
> The handling of broadcast primitives involves
> _scsih_block_io_all_device(), which does what the name implies. I have
> observed cases with >60s of blocking io on all devices, caused by a
> single bad device. The downsides of this code
The handling of broadcast primitives involves
_scsih_block_io_all_device(), which does what the name implies. I have
observed cases with >60s of blocking io on all devices, caused by a
single bad device. The downsides of this code are obvious, while the
upsides are more elusive.
Signed-off-by: J
On Wed, 17 July 2013 23:34:05 +0800, Vaughan Cao wrote:
>
> -static Sg_fd *sg_add_sfp(Sg_device * sdp, int dev);
> +static Sg_fd *sg_add_sfp(Sg_device * sdp, int dev, int * reason);
You can use ERR_PTR and friends instead of adding another parameter.
> static void sg_remove_sfp(struct kref *);
>
On Wed, 17 July 2013 23:34:06 +0800, Vaughan Cao wrote:
> Date: Wed, 17 Jul 2013 23:34:06 +0800
> From: Vaughan Cao
> To: jo...@logfs.org
> Cc: dgilb...@interlog.com, jbottom...@parallels.com,
> linux-scsi@vger.kernel.org, linux-ker...@vger.kernel.org,
> vaughan@oracle.com
> Subjec
On Wed, 17 July 2013 23:34:04 +0800, Vaughan Cao wrote:
> Date: Wed, 17 Jul 2013 23:34:04 +0800
> From: Vaughan Cao
> To: jo...@logfs.org
> Cc: dgilb...@interlog.com, jbottom...@parallels.com,
> linux-scsi@vger.kernel.org, linux-ker...@vger.kernel.org,
> vaughan@oracle.com
> Subjec
On Wed, 17 July 2013 23:34:03 +0800, Vaughan Cao wrote:
> Date: Wed, 17 Jul 2013 23:34:03 +0800
> From: Vaughan Cao
> To: jo...@logfs.org
> Cc: dgilb...@interlog.com, jbottom...@parallels.com,
> linux-scsi@vger.kernel.org, linux-ker...@vger.kernel.org,
> vaughan@oracle.com
> Subjec
On Fri, 2013-07-19 at 21:46 +, James Bottomley wrote:
> On Fri, 2013-07-19 at 14:22 -0700, Nicholas A. Bellinger wrote:
> > On Wed, 2013-07-17 at 04:52 +, James Bottomley wrote:
> > > On Tue, 2013-07-16 at 15:15 -0600, Jens Axboe wrote:
> > > > On Tue, Jul 16 2013, Nicholas A. Bellinger wro
On Fri, 2013-07-19 at 14:22 -0700, Nicholas A. Bellinger wrote:
> On Wed, 2013-07-17 at 04:52 +, James Bottomley wrote:
> > On Tue, 2013-07-16 at 15:15 -0600, Jens Axboe wrote:
> > > On Tue, Jul 16 2013, Nicholas A. Bellinger wrote:
> > > > On Sat, 2013-07-13 at 06:53 +, James Bottomley wro
On Wed, 2013-07-17 at 04:52 +, James Bottomley wrote:
> On Tue, 2013-07-16 at 15:15 -0600, Jens Axboe wrote:
> > On Tue, Jul 16 2013, Nicholas A. Bellinger wrote:
> > > On Sat, 2013-07-13 at 06:53 +, James Bottomley wrote:
> > > > Lets start with discussing this on the list, please, and
On Fri, 2013-07-19 at 09:58 -0600, Mike Christie wrote:
> On 07/18/2013 06:23 PM, Nicholas A. Bellinger wrote:
> >> Just saw this while trying out iscsi with the scsi-mq stuff :)
> >> >
> > Took at stab at this a while back, but ended getting distracted on other
> > items. Do you have an initial
On Fri, 2013-07-19 at 08:33 -0700, James Bottomley wrote:
> On Thu, 2013-07-18 at 23:34 -0700, Nicholas A. Bellinger wrote:
> > diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
> > index 0101af5..191bc15 100644
> > --- a/drivers/ata/libata-scsi.c
> > +++ b/drivers/ata/libata-scsi.
On 7/19/2013 7:28 PM, Seungwon Jeon wrote:
> On Tue, July 09, 2013, Sujit Reddy Thumma wrote:
>> Error handling in UFS driver is broken and resets the host controller
>> for fatal errors without re-initialization. Correct the fatal error
>> handling sequence according to UFS Host Controller Interfa
On 7/19/2013 7:27 PM, Seungwon Jeon wrote:
> On Tue, July 09, 2013, Sujit Reddy Thumma wrote:
>> As of now SCSI initiated error handling is broken because,
>> the reset APIs don't try to bring back the device initialized and
>> ready for further transfers.
>>
>> In case of timeouts, the scsi error
On 7/19/2013 7:26 PM, Seungwon Jeon wrote:
> On Tue, July 09, 2013, Sujit Reddy Thumma wrote:
>> There is a possible race condition in the hardware when the abort
>> command is issued to terminate the ongoing SCSI command as described
>> below:
>>
>> - A bit in the door-bell register is set in the
On 7/19/2013 7:26 PM, Seungwon Jeon wrote:
> On Tue, July 09, 2013 Sujit Reddy Thumma wrote:
>> Currently, sending Task Management (TM) command to the card might
>> be broken in some scenarios as listed below:
>>
>> Problem: If there are more than 8 TM commands the implementation
>> retur
On 7/19/2013 7:17 PM, Seungwon Jeon wrote:
On Thu, July 18, 2013, Sujit Reddy Thumma wrote:
+ * ufshcd_wait_for_register - wait for register value to change
+ * @hba - per-adapter interface
+ * @reg - mmio register offset
+ * @mask - mask to apply to read register value
+ * @val - wait condition
I'm not sure that BKOPS with runtime-pm associates.
Do you think it's helpful for power management?
How about hibernation scheme for runtime-pm?
I'm testing and I can introduce soon.
Well, I am thinking on following approach when we introduce
power management.
ufshcd_runtime_suspend() {
On 07/18/2013 06:23 PM, Nicholas A. Bellinger wrote:
>> Just saw this while trying out iscsi with the scsi-mq stuff :)
>> >
> Took at stab at this a while back, but ended getting distracted on other
> items. Do you have an initial conversion running yet..?
Not running well :) Have a patch but I
https://bugzilla.kernel.org/show_bug.cgi?id=59601
Jack Hill changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
On 07/17/2013 11:44 AM, Mike Christie wrote:
> On 07/08/2013 06:33 AM, adheer.chandravan...@qlogic.com wrote:
>> static ssize_t
>> @@ -181,8 +179,8 @@ qla4xxx_iscsi_version_show(struct device *dev, struct
>> device_attribute *attr,
>> char *buf)
>> {
>> struct scsi_q
On Fri, Jul 19, 2013 at 09:16:51AM +, Saurav Kashyap wrote:
> This should go to stable also, added in to list. This fixes a BZ
> https://bugzilla.kernel.org/show_bug.cgi?id=59601
>
> Thanks,
> ~Saurav
>
>
> -Original Message-
> From: Saurav Kashyap [mailto:saurav.kash...@qlogic.com]
On 07/08/2013 06:33 AM, adheer.chandravan...@qlogic.com wrote:
> From: Adheer Chandravanshi
>
> James,
>
> Please apply the following patches to the scsi tree at your earliest
> convenience.
>
> Adheer Chandravanshi (7):
> qla4xxx: Allow removal of failed session using logout.
> qla
On Thu, 2013-07-18 at 23:34 -0700, Nicholas A. Bellinger wrote:
> diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
> index 0101af5..191bc15 100644
> --- a/drivers/ata/libata-scsi.c
> +++ b/drivers/ata/libata-scsi.c
> @@ -1144,7 +1144,11 @@ static int ata_scsi_dev_config(struct scs
On Fri, 2013-07-12 at 14:47 -0400, Saurav Kashyap wrote:
> Signed-off-by: Saurav Kashyap
> Signed-off-by: Giridhar Malavali
This does not fix a bug ... therefore it's not really -rc fixes
material. In early -rc this rule can be relaxed a bit ... but what's
the reason to get this through the -rc
On 07/17/2013 12:52 AM, James Bottomley wrote:
On Tue, 2013-07-16 at 15:15 -0600, Jens Axboe wrote:
On Tue, Jul 16 2013, Nicholas A. Bellinger wrote:
On Sat, 2013-07-13 at 06:53 +, James Bottomley wrote:
On Fri, 2013-07-12 at 12:52 +0200, Hannes Reinecke wrote:
On 07/12/2013 03:33 AM, Nic
On Tue, July 09, 2013, Sujit Reddy Thumma wrote:
> Error handling in UFS driver is broken and resets the host controller
> for fatal errors without re-initialization. Correct the fatal error
> handling sequence according to UFS Host Controller Interface (HCI)
> v1.1 specification.
>
> o Upon deter
On Tue, July 09, 2013, Sujit Reddy Thumma wrote:
> There is a possible race condition in the hardware when the abort
> command is issued to terminate the ongoing SCSI command as described
> below:
>
> - A bit in the door-bell register is set in the controller for a
> new SCSI command.
> - In som
On Tue, July 09, 2013, Sujit Reddy Thumma wrote:
> As of now SCSI initiated error handling is broken because,
> the reset APIs don't try to bring back the device initialized and
> ready for further transfers.
>
> In case of timeouts, the scsi error handler takes care of handling aborts
> and reset
On Tue, July 09, 2013 Sujit Reddy Thumma wrote:
> Currently, sending Task Management (TM) command to the card might
> be broken in some scenarios as listed below:
>
> Problem: If there are more than 8 TM commands the implementation
> returns error to the caller.
> Fix: Wait for one of
On Thu, July 18, 2013, Sujit Reddy Thumma wrote:
> >>> > >I'm not sure that BKOPS with runtime-pm associates.
> >>> > >Do you think it's helpful for power management?
> >>> > >How about hibernation scheme for runtime-pm?
> >>> > >I'm testing and I can introduce soon.
> >> >
> >> >Well, I am thinkin
On Thursday, July 18, 2013, Dolev Raviv wrote:
> > Hi,
> >
> > Sorry for the late response. I had a few days off.
> >
> > On Thu, July 11, 2013, Dolev Raviv wrote:
> >> > On Tuesday, July 09, 2013, Sujit Reddy Thumma wrote:
> >> >> From: Dolev Raviv
> >> >> Allow UFS device to complete its initial
On Thu, July 18, 2013, Sujit Reddy Thumma wrote:
> + * ufshcd_wait_for_register - wait for register value to change
> + * @hba - per-adapter interface
> + * @reg - mmio register offset
> + * @mask - mask to apply to read register value
> + * @val - wait condition
> + *
This should go to stable also, added in to list. This fixes a BZ
https://bugzilla.kernel.org/show_bug.cgi?id=59601
Thanks,
~Saurav
-Original Message-
From: Saurav Kashyap [mailto:saurav.kash...@qlogic.com]
Sent: Saturday, July 13, 2013 12:18 AM
To: jbottom...@parallels.com
Cc: Giridhar
https://bugzilla.kernel.org/show_bug.cgi?id=59601
--- Comment #11 from Saurav Kashyap ---
Hi Jack,
This patch http://marc.info/?l=linux-scsi&m=137365649318663&w=2 is submitted to
upstream. Please close this BZ.
thanks,
~Saurav
--
You are receiving this mail because:
You are watching the assign
The usage of strict_strtoul() and strict_strtoull() is not preferred,
because strict_strtoul() and strict_strtoull() are obsolete. Thus,
kstrtoul() and kstrtoull() should be used.
Signed-off-by: Jingoo Han
---
drivers/target/iscsi/iscsi_target_configfs.c |8 ++---
drivers/target/iscsi/iscs
40 matches
Mail list logo
