Re: [PATCH 2/2] dm mpath: attach scsi_dh during table resume

2013-04-25 Thread Hannes Reinecke
On 04/25/2013 05:31 PM, Mike Snitzer wrote: > On Thu, Apr 25 2013 at 10:50am -0400, > Mikulas Patocka wrote: > >> >> >> On Thu, 25 Apr 2013, Mike Snitzer wrote: >> >>> On Thu, Apr 25 2013 at 9:48am -0400, >>> Mikulas Patocka wrote: >>> On Mon, 22 Apr 2013, Mike Snitzer wrote: >>>

RE: [PATCH 4/5] scsi: ufs: rework link start-up process

2013-04-25 Thread Seungwon Jeon
On Thursday, April 25, 2013 , Sujit Reddy Thumma wrote: > On 4/24/2013 9:36 PM, Seungwon Jeon wrote: > > Link start-up requires long time with multiphase handshakes > > between UFS host and device. This affects driver's probe time. > > This patch let link start-up run asynchronously. > > And comple

RE: [PATCH 2/5] scsi: ufs: wrap the i/o access operations

2013-04-25 Thread Seungwon Jeon
Hi, On Thursday, April 25, 2013, Sujit Reddy Thumma wrote: > On 4/24/2013 9:36 PM, Seungwon Jeon wrote: > > Simplify operations with hiding mmio_base. > > > > Signed-off-by: Seungwon Jeon > > --- > > drivers/scsi/ufs/ufshcd.c | 106 > > +++-- > > drive

Re: [PATCH 10/21] [SCSI] nsp32: use mdelay instead of large udelay constants

2013-04-25 Thread Masanori Goto
2013/4/25 Arnd Bergmann > > ARM cannot handle udelay for more than 2 miliseconds, so we > should use mdelay instead for those. > Singed-off-by: GOTO Masanori > Signed-off-by: Arnd Bergmann > Cc: GOTO Masanori > Cc: YOKOTA Hiroshi > Cc: "James E.J. Bottomley" > Cc: linux-scsi@vger.kernel.org

[PATCH 10/21] [SCSI] nsp32: use mdelay instead of large udelay constants

2013-04-25 Thread Arnd Bergmann
ARM cannot handle udelay for more than 2 miliseconds, so we should use mdelay instead for those. Signed-off-by: Arnd Bergmann Cc: GOTO Masanori Cc: YOKOTA Hiroshi Cc: "James E.J. Bottomley" Cc: linux-scsi@vger.kernel.org --- drivers/scsi/nsp32.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

[PATCH 00/21] more arm build fixes

2013-04-25 Thread Arnd Bergmann
Hi subsystem maintainers, Here is another set of patches that resulted from build testing on linux-next. Please apply directly into your trees if you agree, or let me know if I made a mistake. I can take whatever remains through the arm-soc tree if you prefer that or I don't hear back. A

Re: [PATCH v2 1/4] Wrap crc_t10dif function all to use crypto transform framework

2013-04-25 Thread Tim Chen
On Thu, 2013-04-25 at 21:22 +0800, Herbert Xu wrote: > Please wrap the generic implementation as we do for crc32c. > Herbert, I've updated this patch to add the generic crct10dif transform (see below). Let me know if this address your comment. Thanks. Tim When CRC T10 DIF is calculated usin

Re: [PATCH 2/2] dm mpath: attach scsi_dh during table resume

2013-04-25 Thread Bryn M. Reeves
On 04/25/2013 04:37 PM, Mike Snitzer wrote:> clariion_match does more than check the vendor and product; if tpgs is > set (ALUA mode) it returns false. > > So yes, while there is room for improvement in clariion_match the > current code should work just fine with reasoning between emc and alua.

Re: [PATCH 2/2] dm mpath: attach scsi_dh during table resume

2013-04-25 Thread Mike Snitzer
On Thu, Apr 25 2013 at 11:27am -0400, Bryn M. Reeves wrote: > On 04/25/2013 03:50 PM, Mikulas Patocka wrote: > >On Thu, 25 Apr 2013, Mike Snitzer wrote: > >>The handler that is automatically attached _should_ be the correct > >>handler. We now have the .match() hook for scsi_dh and it has made f

Re: [PATCH 2/2] dm mpath: attach scsi_dh during table resume

2013-04-25 Thread Mike Snitzer
On Thu, Apr 25 2013 at 10:50am -0400, Mikulas Patocka wrote: > > > On Thu, 25 Apr 2013, Mike Snitzer wrote: > > > On Thu, Apr 25 2013 at 9:48am -0400, > > Mikulas Patocka wrote: > > > > > > > > > > > On Mon, 22 Apr 2013, Mike Snitzer wrote: > > > > > > > I spoke with Hannes at LSF, to ad

Re: [PATCH 2/2] dm mpath: attach scsi_dh during table resume

2013-04-25 Thread Bryn M. Reeves
On 04/25/2013 03:50 PM, Mikulas Patocka wrote: On Thu, 25 Apr 2013, Mike Snitzer wrote: The handler that is automatically attached _should_ be the correct handler. We now have the .match() hook for scsi_dh and it has made for reliable scsi_dh attachment of the correct handler. The EMC devices

Re: [PATCH 2/2] dm mpath: attach scsi_dh during table resume

2013-04-25 Thread Mikulas Patocka
On Thu, 25 Apr 2013, Mike Snitzer wrote: > On Thu, Apr 25 2013 at 9:48am -0400, > Mikulas Patocka wrote: > > > > > > > On Mon, 22 Apr 2013, Mike Snitzer wrote: > > > > > I spoke with Hannes at LSF, to address the potential crashes in the > > > endio path (e.g. stpg_endio) we'd have to bump

Re: [PATCH 2/2] dm mpath: attach scsi_dh during table resume

2013-04-25 Thread Mike Snitzer
On Thu, Apr 25 2013 at 9:48am -0400, Mikulas Patocka wrote: > > > On Mon, 22 Apr 2013, Mike Snitzer wrote: > > > I spoke with Hannes at LSF, to address the potential crashes in the > > endio path (e.g. stpg_endio) we'd have to bump the scsi_dh_data kref > > where appropriate (e.g. for ALUA kr

Re: T10 WCE interpretation in Linux & device level access

2013-04-25 Thread James Bottomley
On Thu, 2013-04-25 at 07:35 -0400, Ric Wheeler wrote: > It was pointed out to me that RCD is "Read Cache Disable" so by > setting it to > zero, we are enabling the read cache (not that we ever look at this > bit or send > it down). The WCE bit is "write cache enable" so the polarity of the > bits

Re: [PATCH v2 1/4] Wrap crc_t10dif function all to use crypto transform framework

2013-04-25 Thread Herbert Xu
On Wed, Apr 17, 2013 at 09:12:52AM -0700, Tim Chen wrote: > When CRC T10 DIF is calculated using the crypto transform framework, we > wrap the crc_t10dif function call to utilize it. This allows us to > take advantage of any accelerated CRC T10 DIF transform that is > plugged into the crypto frame

Re: [PATCH 2/2] dm mpath: attach scsi_dh during table resume

2013-04-25 Thread Mikulas Patocka
On Mon, 22 Apr 2013, Mike Snitzer wrote: > I spoke with Hannes at LSF, to address the potential crashes in the > endio path (e.g. stpg_endio) we'd have to bump the scsi_dh_data kref > where appropriate (e.g. for ALUA kref_get in submit_stpg and kref_put in > stpg_endio). > > But that is just th

Re: T10 WCE interpretation in Linux & device level access

2013-04-25 Thread Ric Wheeler
On 04/24/2013 06:46 PM, James Bottomley wrote: On Wed, 2013-04-24 at 18:36 -0400, Ric Wheeler wrote: On 04/24/2013 06:09 PM, James Bottomley wrote: On Wed, 2013-04-24 at 23:54 +0200, Paolo Bonzini wrote: Il 24/04/2013 23:02, James Bottomley ha scritto: That just leaves us with random standard

[PATCH/for-next 1/3] iscsi-target: Fix solicited NopIN handling with RDMAExtentions=No

2013-04-25 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patches fixes a regression with solicited NopIN handling in traditional iSCSI code introduced during TX immediate queue refactoring for v3.10 for-next code. Cc: Or Gerlitz Signed-off-by: Nicholas Bellinger --- drivers/target/iscsi/iscsi_target.c |6 -- 1

[PATCH/for-next 0/3] iscsi-target/iser-target: Fix breakage

2013-04-25 Thread Nicholas A. Bellinger
From: Nicholas Bellinger Hi folks, This series addresses two bugs within v3.10 for-next code related to the upcoming iscsi-target series adding multi-transport support, along with a third iser-target bugfix related to early ISCSI_OP_SCSI_CMD exception handling. These three patches are being fol

[PATCH/for-next 2/3] iscsi-target: Fix iscsit_handle_scsi_cmd() exception se_cmd leak

2013-04-25 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch fixes a regression where failures before backend se_cmd execution in iscsit_handle_scsi_cmd() is leaking iscsi_cmd due to a missing target_put_sess_cmd() call to drop the extra kref. Introduced during the RX PDU refactoring in v3.10 for-next code. Cc: Or Gerl

[PATCH/for-next 3/3] iser-target: Add special case for early ISCSI_OP_SCSI_CMD exception handling

2013-04-25 Thread Nicholas A. Bellinger
From: Nicholas Bellinger During early ISCSI_OP_SCSI_CMD exception handling with non GOOD status, the TX thread context in isert_response_queue() needs to post IB_WR_SEND via isert_put_response() when processing ISTATE_SEND_STATUS. Cc: Or Gerlitz Signed-off-by: Nicholas Bellinger --- drivers/i