On Thu, 2008-01-31 at 20:14 +0100, Geert Uytterhoeven wrote:
> On Thu, 31 Jan 2008, Nicholas A. Bellinger wrote:
> > On Thu, 2008-01-31 at 11:53 -0600, James Bottomley wrote:
> > > On Thu, 2008-01-31 at 09:28 -0800, Nicholas A. Bellinger wrote:
> > > > The problem case is a SCSI Target Mode engine
On Thu, 2008-01-31 at 18:46 -0800, Randy Dunlap wrote:
> > Agreed, here is the patch to make this clear within SCSI. Randy, does
> > this look OK..?
> >
> > Thanks,
> >
> > --nab
> >
> > Signed-off-by: Nicholas A. Bellinger <[EMAIL PROTECTED]>
> >
> > diff --git a/Documentation/scsi/scsi_mid_l
On Thu, 31 Jan 2008 17:58:30 -0800 Nicholas A. Bellinger wrote:
> On Thu, 2008-01-31 at 13:42 -0600, James Bottomley wrote:
> > On Thu, 2008-01-31 at 10:44 -0800, Nicholas A. Bellinger wrote:
> > > > In short, and to repeat: almost every internal size counter to block is
> > > > in units of 512 by
On Thu, 2008-01-31 at 13:42 -0600, James Bottomley wrote:
> On Thu, 2008-01-31 at 10:44 -0800, Nicholas A. Bellinger wrote:
> > > In short, and to repeat: almost every internal size counter to block is
> > > in units of 512 byte sectors ... that includes capacity, maximum etc ...
> > >
> >
> > Ok
Chris Leech wrote:
In thinking about how FC should be represented, it seems to me that in
order to provide good interfaces at multiple levels of functionality
we have to make sure the we have the right data structures at each
level. At the highest level there's scsi_cmd, then there's sequence
--- On Thu, 1/31/08, Tony Battersby <[EMAIL PROTECTED]> wrote:
> From: Tony Battersby <[EMAIL PROTECTED]>
> Subject: [PATCH] [RFC] sd: make error handling more robust
> To: "James Bottomley" <[EMAIL PROTECTED]>, "Luben Tuikov" <[EMAIL
> PROTECTED]>, linux-scsi@vger.kernel.org
> Date: Thursday, Ja
Converted sun3x_esp driver to use esp_scsi.c
Signed-off-by: Thomas Bogendoerfer <[EMAIL PROTECTED]>
---
drivers/scsi/Kconfig |1 +
drivers/scsi/Makefile|2 +-
drivers/scsi/sun3x_esp.c | 546 --
3 files changed, 237 insertions(+), 312 d
[EMAIL PROTECTED] wrote:
+static inline int scsi_target_ready(struct scsi_device *sdev)
+{
+ struct scsi_target *starget = scsi_target(sdev);
+
+ if (starget->single_lun) {
+ if (starget->starget_sdev_user &&
+ starget->starget_sdev_user != sdev)
+
From: Mike Christie <[EMAIL PROTECTED]>
SCSI-ml manages the queueing limits for the device and host, but
does not do so at the target level. Currently this is not needed
and is probably more for the transport code to handle. However,
for bnx2i we will need to be able to limit queueing at this leve
From: Mike Christie <[EMAIL PROTECTED]>
This hooks iscsi_tcp and libiscsi into the target->can_queue
code and it has libiscsi use SCSI_MLQUEUE_TARGET_BUSY.
Signed-off-by: Mike Christie <[EMAIL PROTECTED]>
---
drivers/infiniband/ulp/iser/iscsi_iser.c |1 +
drivers/scsi/iscsi_tcp.c
These two patches are for RFC, but could go into scsi-misc for
2.6.26 if they are ok off the bat.
They add the ability to limit queueing at the target level.
This will be needed for bnx2i, but also may be useful to
limit transport level commands when using bsg.
-
To unsubscribe from this list: s
I have a RAID that returns a medium error on a read command. The
"information bytes valid" bit is set in the sense data, but the
information bytes are zero:
CDB: 28 00 02 B0 62 00 00 00 02 00
Status: 02 (CHECK CONDITION)
Sense data:
F0 00 03 00 | 00 00 00 0A | 00 00 00 00 | 00 00 00 00
00 00
For
On Thu, 31 Jan 2008, Boaz Harrosh wrote:
> >> The code in usb_stor_access_xfer_buf() will
> >> now correctly attempt to transfer according to buflen and what ever is
> >> available
> >> at the passed sg's. Now this can be less or it can be more. SCSI standard
> >> defines
> >> this as underflow
Signed-off-by: Andrew Vasquez <[EMAIL PROTECTED]>
---
drivers/scsi/qla2xxx/qla_os.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
index 3954ed2..bbdfd81 100644
--- a/drivers/scsi/qla2xxx/qla_os.c
+++ b/drivers
Signed-off-by: Andrew Vasquez <[EMAIL PROTECTED]>
---
drivers/scsi/qla2xxx/qla_version.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_version.h
b/drivers/scsi/qla2xxx/qla_version.h
index 2c2f6b4..c5742cc 100644
--- a/drivers/scsi/qla2xxx/qla_v
From: Seokmann Ju <[EMAIL PROTECTED]>
For following fc_host specific attributes, vports rely on the pport.
So, this patch changed way to access the data for those attributes so that
they can access pport's.
- get_host_speed (speed)
- get_host_port_state (port_state)
- get_host_port_type (por
There's no functional change involved with this update, instead
it simply migrates the "set cleared interrupt state" codes to a
more approprate method, qla2x00_request_irqs(), and cleans-up the
driver's probe() logic.
Signed-off-by: Andrew Vasquez <[EMAIL PROTECTED]>
---
drivers/scsi/qla2xxx/qla_
BIT_2 of the firmware attributes is only valid on FW-interface-2
type HBAs. Code in commit
c48339decceec8e011498b0fc4c7c7d8b2ea06c1 would cause the
incorrect initialize-firmware mailbox command to be issued for
non-NPIV capable ISPs. Correct this by reverting to previously
used (and correct) pre-
From: Seokmann Ju <[EMAIL PROTECTED]>
While running IO simultaneously through physical port and virtual
port, if user changes Data Rate (from scli utility), IO through
virtual port fails. It failed because the vport had not received
the ISP_ABORT_NEEDED notification.
Signed-Off-by: Seokmann Ju <
- Drop loop-till-allocated structure of code within
qla2x00_mem_alloc().
- Properly unwind deallcations of memory during failures.
- Drop qla2x00_allocate_sp_pool() and qla2x00_free_sp_pool()
functions as their implementations can easily be collapsed into
the callers.
- Defer DMA pool allocat
Collapse duplicate codes called during probe() and RISC-reset
into qla2x00_setup_chip().
Signed-off-by: Andrew Vasquez <[EMAIL PROTECTED]>
---
drivers/scsi/qla2xxx/qla_init.c | 70 +-
drivers/scsi/qla2xxx/qla_os.c | 12 ---
2 files changed, 24 inserti
To insure that there is no stale data present during EFT
re-registration.
Signed-off-by: Andrew Vasquez <[EMAIL PROTECTED]>
---
drivers/scsi/qla2xxx/qla_init.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.
Refactor SRB-failure completion codes in the process. Also,
signal the DPC routine to complete sooner as backend processing
at shutdown-time is superflous.
Signed-off-by: Andrew Vasquez <[EMAIL PROTECTED]>
---
drivers/scsi/qla2xxx/qla_gbl.h |1 +
drivers/scsi/qla2xxx/qla_init.c | 16 +
Hmm, it looks like the conversion to resource_size_t usage
(3776541d8a46347a4924353a192c6ce4a3d04e2e) requires some additional
fixups to cleanup the structure-pointer castings used during IO mapped
accesses to the chip.
There's only a small number of locations, where the driver uses IO
mapped acce
bidi support for iscsi_tcp
- access the right scsi_in() and/or scsi_out() side of things.
also for resid
Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
---
drivers/scsi/iscsi_tcp.c | 31 +--
1 files changed, 17 insertions(+), 14 deletions(-)
diff --git a/
Here's a batch of fixes for 2.6.24.
Changes include:
- Correct resource_size_t usages.
- Add MODULE_FIRMWARE hint for ISP25XX firmware.
- Cleanup any outstanding SRB resources during shutdown.
- Clear EFT buffer before firmware reinitialization.
- Cleanse memory allocation logic during probe.
- C
iscsi bidi support at the generic libiscsi level
- prepare the additional bidi_read rlength header.
- access the right scsi_in() and/or scsi_out() side of things.
also for resid.
- Handle BIDI underflow overflow from target
Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
---
drivers/
Support for extended CDBs in iscsi.
All we need is to check if command spills over 16 bytes then allocate
an iscsi-extended-header for the leftovers.
Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
---
drivers/scsi/iscsi_tcp.c |2 +-
drivers/scsi/libiscsi.c| 56
On Thu, Jan 31, 2008 at 10:05:19PM +0200, Boaz Harrosh wrote:
> On Thu, Jan 31 2008 at 21:49 +0200, Matthew Dharm <[EMAIL PROTECTED]> wrote:
> > No. No no no.
>
> Please re-inspect the code again.
> There is no device involved here. The code completely emulates this commands
> with a driver made
Adrian Bunk wrote:
__iscsi_complete_pdu() can now become static.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
Looks good. Thanks.
Acked-by: Mike Christie <[EMAIL PROTECTED]>
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED
On Thu, Jan 31 2008 at 21:49 +0200, Matthew Dharm <[EMAIL PROTECTED]> wrote:
> No. No no no.
>
> The ISD200 code was written by the ISD200 developers. I really don't want
> to go mucking about changing what commands actually get send to the ISD200
> parts. We have no idea if the will reliably a
On Thu, Jan 31 2008 at 21:34 +0200, Alan Stern <[EMAIL PROTECTED]> wrote:
> On Thu, 31 Jan 2008, Boaz Harrosh wrote:
>
>> On Thu, Jan 31 2008 at 19:49 +0200, Alan Stern <[EMAIL PROTECTED]> wrote:
>>> On Thu, 31 Jan 2008, Boaz Harrosh wrote:
>>>
@@ -228,9 +228,14 @@ void usb_stor_set_xfer_buf(
No. No no no.
The ISD200 code was written by the ISD200 developers. I really don't want
to go mucking about changing what commands actually get send to the ISD200
parts. We have no idea if the will reliably accept a 36-byte INQUIRY.
Just because it happens to work for a couple of people doesn'
On Thu, 2008-01-31 at 10:44 -0800, Nicholas A. Bellinger wrote:
> > In short, and to repeat: almost every internal size counter to block is
> > in units of 512 byte sectors ... that includes capacity, maximum etc ...
> >
>
> Ok, after reading your followup with Geert I see that this looks like a
On Thu, Jan 31, 2008 at 10:48:11AM -0800, Arjan van de Ven wrote:
> On Thu, 31 Jan 2008 19:34:25 +0100
> Sam Ravnborg <[EMAIL PROTECTED]> wrote:
>
> > On Thu, Jan 31, 2008 at 09:48:01AM -0800, Arjan van de Ven wrote:
> > > On Thu, 31 Jan 2008 19:14:36 +0200
> > > Adrian Bunk <[EMAIL PROTECTED]> wr
Greg KH <[EMAIL PROTECTED]> rote:
> As this is a regression and hits 2.6.24, can you send the final version
> of this patch to the [EMAIL PROTECTED] address so we can get it into the
> 2.6.24.y tree?
>
> thanks,
>
> greg k-h
Mark - This is for you on top of vanila v2.6.24 kernel from Linus.
---
From: Mike Christie <[EMAIL PROTECTED]>
Set iscsi version to 2.0-868
Signed-off-by: Mike Christie <[EMAIL PROTECTED]>
---
drivers/scsi/scsi_transport_iscsi.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/scsi_transport_iscsi.c
b/drivers/scsi/scsi_transpo
From: Mike Christie <[EMAIL PROTECTED]>
Some iscsi class messages have the dev_printk prefix and some libiscsi
and iscsi_tcp messages have "iscsi" or the module name as a prefix which
is normally pretty useless when trying to figure out which session
or connection the message is attached to. This
From: Mike Christie <[EMAIL PROTECTED]>
The session age mask is only 4 bits, but session->age is 32. When
it gets larger then 15 and we try to or the bits some bits get
dropped and the check for session age in iscsi_verify_itt is useless.
The ISCSI_CID_MASK related bits are also useless since cid
From: Mike Christie <[EMAIL PROTECTED]>
There are 13 iscsi conn attrs, but since the IF/OF markers were not being
used we did not notice that we forgot to increment the ISCSI_CONN_ATTRS
counter.
Signed-off-by: Mike Christie <[EMAIL PROTECTED]>
---
drivers/scsi/scsi_transport_iscsi.c |2 +-
1
From: Mike Christie <[EMAIL PROTECTED]>
If we rollover then we could get a next_timeout of zero, so we need
to set the new timer to that value.
Signed-off-by: Mike Christie <[EMAIL PROTECTED]>
---
drivers/scsi/libiscsi.c |9 +++--
1 files changed, 3 insertions(+), 6 deletions(-)
diff --
From: Mike Christie <[EMAIL PROTECTED]>
qla4xxx has the old school startup/probe where it finds presetup sessions
in its flash and then attempts to log into them before returning from the
probe. This however, makes it very simple to add a iscsi class scan finished
helper which the driver can use.
From: Mike Christie <[EMAIL PROTECTED]>
This just adds iscsi session scanning which works like fc rport scanning.
The future patches will hook the drivers into Mathew Wilcox's async
scanning infrastructure, so userspace does not have to special case
iscsi and so userspace does not have to make a e
From: Mike Christie <[EMAIL PROTECTED]>
In qla4xxx's probe it will call the iscsi session setup functions
for session that got setup on the initial start. This then makes
it easy for the iscsi class to export a helper which indicates
when those scans are done.
Signed-off-by: Mike Christie <[EMAIL
From: Mike Christie <[EMAIL PROTECTED]>
If qla4xxx is resetting up a session and the recovery timer
fires we do not want to just set it to dead, because
the dpc thread could have just set it to online and is in the
middle of resetting it up.
Signed-off-by: Mike Christie <[EMAIL PROTECTED]>
---
d
From: Mike Christie <[EMAIL PROTECTED]>
This has qla4xxx use the iscsi class's check ready function
in the queue command function, so all iscsi drivers return the
same error value for common problems.
Signed-off-by: Mike Christie <[EMAIL PROTECTED]>
---
drivers/scsi/qla4xxx/ql4_os.c | 12 +
From: Mike Christie <[EMAIL PROTECTED]>
Qla4xxx can just call the iscsi recovery functions directly.
There is no need for userspace to do this for qla4xxx, because
we do not use the mutex to iterate over devices anymore and iscsi_block
/unblock_session can be called from interrupt context or the d
From: Mike Christie <[EMAIL PROTECTED]>
This adds a iscsi session state file which exports the session
state for both software and hardware iscsi. It also hooks libiscsi
in.
Signed-off-by: Mike Christie <[EMAIL PROTECTED]>
---
drivers/scsi/libiscsi.c | 41 +-
drivers/sc
The following patches were made over scsi-misc.
The bugs fixed are:
- Have qla4xxx hook into block/unblock code, and use new session
state to fail/requeue IO during transport problems.
- Hook qla4xxx into async scanning code. Qla4xxx looks more
like a normal old scsi card than a iscsi card. There
On Thu, 31 Jan 2008, Boaz Harrosh wrote:
> On Thu, Jan 31 2008 at 19:49 +0200, Alan Stern <[EMAIL PROTECTED]> wrote:
> > On Thu, 31 Jan 2008, Boaz Harrosh wrote:
> >
> >> @@ -228,9 +228,14 @@ void usb_stor_set_xfer_buf(unsigned char *buffer,
> >> {
> >>unsigned int offset = 0;
> >>struct
On Thu, 2008-01-31 at 19:55 +0100, Geert Uytterhoeven wrote:
> On Thu, 31 Jan 2008, James Bottomley wrote:
> > On Mon, 2008-01-07 at 07:07 +0100, Kars de Jong wrote:
> > > On do, 2008-01-03 at 20:05 +0100, Geert Uytterhoeven wrote:
> > > > On Thu, 3 Jan 2008, James Bottomley wrote:
> > > > > On Thu
On Thu, 31 Jan 2008, Nicholas A. Bellinger wrote:
> On Thu, 2008-01-31 at 11:53 -0600, James Bottomley wrote:
> > On Thu, 2008-01-31 at 09:28 -0800, Nicholas A. Bellinger wrote:
> > > The problem case is a SCSI Target Mode engine that receives a 2048 Byte
> > > single sector ATAPI READ_10 request f
On Thu, Jan 31 2008 at 20:55 +0200, Geert Uytterhoeven <[EMAIL PROTECTED]>
wrote:
> On Thu, 31 Jan 2008, James Bottomley wrote:
>> On Mon, 2008-01-07 at 07:07 +0100, Kars de Jong wrote:
>>> On do, 2008-01-03 at 20:05 +0100, Geert Uytterhoeven wrote:
On Thu, 3 Jan 2008, James Bottomley wrote:
On Thu, Jan 31 2008 at 19:49 +0200, Alan Stern <[EMAIL PROTECTED]> wrote:
> On Thu, 31 Jan 2008, Boaz Harrosh wrote:
>
>> @@ -228,9 +228,14 @@ void usb_stor_set_xfer_buf(unsigned char *buffer,
>> {
>> unsigned int offset = 0;
>> struct scatterlist *sg = NULL;
>> +unsigned int count;
On Thu, 2008-01-31 at 18:08 +0100, Bart Van Assche wrote:
> If anyone has a suggestion for a better test than dd to compare the
> performance of SCSI storage protocols, please let it know.
xdd on /dev/sda, sdb, etc. using -dio to do direct IO seems to work
decently, though it is hard (ie, impossi
On Thu, 31 Jan 2008, James Bottomley wrote:
> On Mon, 2008-01-07 at 07:07 +0100, Kars de Jong wrote:
> > On do, 2008-01-03 at 20:05 +0100, Geert Uytterhoeven wrote:
> > > On Thu, 3 Jan 2008, James Bottomley wrote:
> > > > On Thu, 2008-01-03 at 17:40 +0200, Boaz Harrosh wrote:
> > > > > As recommend
On Thu, 31 Jan 2008, Chris Wedgwood wrote:
> On Thu, Jan 31, 2008 at 07:55:43PM +0200, Adrian Bunk wrote:
> > Who was talking about laptops?
>
> If laptops are mostly MP these days, then 'desktops' and 'servers'
> certainly are --- so pretty much everyone needs CPU hotplug.
Thank you for giving
On Thu, 31 Jan 2008 19:34:25 +0100
Sam Ravnborg <[EMAIL PROTECTED]> wrote:
> On Thu, Jan 31, 2008 at 09:48:01AM -0800, Arjan van de Ven wrote:
> > On Thu, 31 Jan 2008 19:14:36 +0200
> > Adrian Bunk <[EMAIL PROTECTED]> wrote:
> > > > cpuhotplug is required for suspend/resume.
> > >
> > > Not on UP
On Thu, 31 Jan 2008, James Bottomley wrote:
> On Thu, 2008-01-31 at 18:41 +0100, Geert Uytterhoeven wrote:
> > James, do you have any comment about the first email in this thread,
> > increasing
> > scsi_host_template.max_sectors?
>
> Assuming your BOUNCE_SIZE is in bytes, and represents your lar
On Thu, 2008-01-31 at 11:53 -0600, James Bottomley wrote:
> On Thu, 2008-01-31 at 09:28 -0800, Nicholas A. Bellinger wrote:
> > On Thu, 2008-01-31 at 10:26 -0600, James Bottomley wrote:
> > > On Thu, 2008-01-31 at 08:10 -0800, Nicholas A. Bellinger wrote:
> > > > On Thu, 2008-01-31 at 09:34 -0600,
On Thu, Jan 31, 2008 at 07:55:43PM +0200, Adrian Bunk wrote:
> Who was talking about laptops?
If laptops are mostly MP these days, then 'desktops' and 'servers'
certainly are --- so pretty much everyone needs CPU hotplug.
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" i
On Thu, Jan 31, 2008 at 09:48:01AM -0800, Arjan van de Ven wrote:
> On Thu, 31 Jan 2008 19:14:36 +0200
> Adrian Bunk <[EMAIL PROTECTED]> wrote:
> > > cpuhotplug is required for suspend/resume.
> >
> > Not on UP computers.
> >
>
> great! someone who still has one of those and uses a kernel withou
On Thu, Jan 31 2008 at 20:00 +0200, Greg KH <[EMAIL PROTECTED]> wrote:
> On Thu, Jan 31, 2008 at 07:19:57PM +0200, Boaz Harrosh wrote:
>> scsi_scan is issuing a 36-byte INQUIRY request to llds. isd200 would
>> volunteer 96 bytes of INQUIRY. This caused an underflow condition in
>> protocol.c
On Thu, 2008-01-31 at 18:40 +0100, Bart Van Assche wrote:
> On Jan 31, 2008 6:14 PM, Nicholas A. Bellinger <[EMAIL PROTECTED]> wrote:
> > Also, with STGT being a pretty new design which has not undergone alot
> > of optimization, perhaps profiling both pieces of code against similar
> > tests would
On Wed, 2007-09-12 at 08:42 +0100, Russell King wrote:
> On Wed, Sep 12, 2007 at 02:55:19AM +0300, Boaz Harrosh wrote:
> > - if (SCpnt->request_bufflen != len)
> > + if (scsi_bufflen(SCpnt) != len) {
> > + WARN_ON(1);
>
> NAK. The call trace generally doesn'
Cheers after 1.3 years these can go in.
[PATCH 1/3] iscsi: extended cdb support
The varlen support is not yet in mainline for
block and scsi-ml. But the API for drivers will
not change. All LLD need to do is max_command to
the it's maximum and be ready for bigger commands.
This is what'
On Mon, 2008-01-07 at 07:07 +0100, Kars de Jong wrote:
> On do, 2008-01-03 at 20:05 +0100, Geert Uytterhoeven wrote:
> > On Thu, 3 Jan 2008, James Bottomley wrote:
> > > On Thu, 2008-01-03 at 17:40 +0200, Boaz Harrosh wrote:
> > > > As recommended by Christoph Hellwig. There is no use
> > > > of F
On Thu, 2008-01-31 at 18:41 +0100, Geert Uytterhoeven wrote:
> On Thu, 31 Jan 2008, Nicholas A. Bellinger wrote:
> > On Thu, 2008-01-31 at 10:26 -0600, James Bottomley wrote:
> > > On Thu, 2008-01-31 at 08:10 -0800, Nicholas A. Bellinger wrote:
> > > > On Thu, 2008-01-31 at 09:34 -0600, James Botto
On Thu, Jan 31, 2008 at 07:19:57PM +0200, Boaz Harrosh wrote:
>
> scsi_scan is issuing a 36-byte INQUIRY request to llds. isd200 would
> volunteer 96 bytes of INQUIRY. This caused an underflow condition in
> protocol.c usb_stor_access_xfer_buf(). So first fix is to
> usb_stor_access_xfer_b
On Thu, Jan 31, 2008 at 09:45:26AM -0800, Chris Wedgwood wrote:
> On Thu, Jan 31, 2008 at 07:14:36PM +0200, Adrian Bunk wrote:
>
> > > cpuhotplug is required for suspend/resume.
> >
> > Not on UP computers.
>
> those are less and less common now, most modern laptops are dual core
Who was talking
On Thu, 2008-01-31 at 09:28 -0800, Nicholas A. Bellinger wrote:
> On Thu, 2008-01-31 at 10:26 -0600, James Bottomley wrote:
> > On Thu, 2008-01-31 at 08:10 -0800, Nicholas A. Bellinger wrote:
> > > On Thu, 2008-01-31 at 09:34 -0600, James Bottomley wrote:
> > > > On Thu, 2008-01-31 at 06:10 -0800,
On Thu, 31 Jan 2008, Boaz Harrosh wrote:
> @@ -228,9 +228,14 @@ void usb_stor_set_xfer_buf(unsigned char *buffer,
> {
> unsigned int offset = 0;
> struct scatterlist *sg = NULL;
> + unsigned int count;
>
> - usb_stor_access_xfer_buf(buffer, buflen, srb, &sg, &offset,
> +
On Thu, 31 Jan 2008 19:14:36 +0200
Adrian Bunk <[EMAIL PROTECTED]> wrote:
> > cpuhotplug is required for suspend/resume.
>
> Not on UP computers.
>
great! someone who still has one of those and uses a kernel without it.
Can you look at your system.map and see how many kilobytes you've gained?
Eg
On Thu, Jan 31, 2008 at 07:14:36PM +0200, Adrian Bunk wrote:
> > cpuhotplug is required for suspend/resume.
>
> Not on UP computers.
those are less and less common now, most modern laptops are dual core
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a messa
On Thu, 31 Jan 2008, Nicholas A. Bellinger wrote:
> On Thu, 2008-01-31 at 10:26 -0600, James Bottomley wrote:
> > On Thu, 2008-01-31 at 08:10 -0800, Nicholas A. Bellinger wrote:
> > > On Thu, 2008-01-31 at 09:34 -0600, James Bottomley wrote:
> > > > On Thu, 2008-01-31 at 06:10 -0800, Nicholas A. Be
On Jan 31, 2008 6:14 PM, Nicholas A. Bellinger <[EMAIL PROTECTED]> wrote:
> Also, with STGT being a pretty new design which has not undergone alot
> of optimization, perhaps profiling both pieces of code against similar
> tests would give us a better idea of where userspace bottlenecks reside.
> Al
On Thu, Jan 31 2008 at 19:29 +0200, Ingo Molnar <[EMAIL PROTECTED]> wrote:
> FYI, automated testing found the following build breakage:
>
> drivers/scsi/NCR53C9x.c: In function 'esp_get_dmabufs':
> drivers/scsi/NCR53C9x.c:913: error: 'Scsi_Cmnd' has no member named 'use_sg'
> drivers/scsi/NCR53C9x
On Thu, 2008-01-31 at 10:26 -0600, James Bottomley wrote:
> On Thu, 2008-01-31 at 08:10 -0800, Nicholas A. Bellinger wrote:
> > On Thu, 2008-01-31 at 09:34 -0600, James Bottomley wrote:
> > > On Thu, 2008-01-31 at 06:10 -0800, Nicholas A. Bellinger wrote:
> > > > Greetings Geert and Co,
> > > >
>
On Thu, Jan 31 2008 at 18:45 +0200, Alan Stern <[EMAIL PROTECTED]> wrote:
> On Thu, 31 Jan 2008, Boaz Harrosh wrote:
>
Please check the below patch.
one thing that I can see is that the isd200 does an INQUARY transfer
of sizeof(struct inquiry_data) which is 96 bytes, when scsi_
scsi_scan is issuing a 36-byte INQUIRY request to llds. isd200 would
volunteer 96 bytes of INQUIRY. This caused an underflow condition in
protocol.c usb_stor_access_xfer_buf(). So first fix is to
usb_stor_access_xfer_buf() to properly handle underflow conditions.
Then usb_stor_set_xfer_b
On Thu, 2008-01-31 at 18:50 +0300, Vladislav Bolkhovitin wrote:
> Bart Van Assche wrote:
> > On Jan 31, 2008 2:25 PM, Nicholas A. Bellinger <[EMAIL PROTECTED]> wrote:
> >
> >>Since this particular code is located in a non-data path critical
> >>section, the kernel vs. user discussion is a wash. I
On Thu, Jan 31, 2008 at 09:07:49AM -0800, Arjan van de Ven wrote:
> On Thu, 31 Jan 2008 18:21:42 +0200
> Adrian Bunk <[EMAIL PROTECTED]> wrote:
>
> > On Thu, Jan 31, 2008 at 08:11:20AM -0800, Arjan van de Ven wrote:
> > > On Thu, 31 Jan 2008 09:57:31 -0600
> > > James Bottomley <[EMAIL PROTECTED]>
Bart Van Assche wrote:
I have ran some tests with Bonnie++, but found out that on a fast
network like IB the filesystem used for the test has a really big
impact on the test results.
This is true of the file systems when physically directly connected to
the unit as well. Some file systems ar
On Jan 31, 2008 5:25 PM, Joe Landman <[EMAIL PROTECTED]> wrote:
> Vladislav Bolkhovitin wrote:
> > Actually, I don't know what kind of conclusions it is possible to make
> > from disktest's results (maybe only how throughput gets bigger or slower
> > with increasing number of threads?), it's a good
On Thu, 31 Jan 2008 18:21:42 +0200
Adrian Bunk <[EMAIL PROTECTED]> wrote:
> On Thu, Jan 31, 2008 at 08:11:20AM -0800, Arjan van de Ven wrote:
> > On Thu, 31 Jan 2008 09:57:31 -0600
> > James Bottomley <[EMAIL PROTECTED]> wrote:
> >
> > > No-one seems to see much value in these, and they cause abo
Vladislav Bolkhovitin wrote:
Bart Van Assche wrote:
[...]
I can run disktest on the same setups I ran dd on. This will take some
time however.
Disktest was already referenced in the beginning of the performance
comparison thread, but its results are not very interesting if we are
going to
On Thu, Jan 31 2008 at 18:39 +0200, Jan Engelhardt <[EMAIL PROTECTED]> wrote:
> Hi,
>
> On Jan 31 2008 14:35, Boaz Harrosh wrote:
>> Thanks, Perhaps someone else then.
>> Anyone with gdth HW that can test patches?
>
> Is bisecting down the existing chain and finding the bad commit
> sufficient?
On Thu, 31 Jan 2008, Boaz Harrosh wrote:
> >> Please check the below patch.
> >>
> >> one thing that I can see is that the isd200 does an INQUARY transfer
> >> of sizeof(struct inquiry_data) which is 96 bytes, when scsi_scan.c
> >> sends an INQUARY with 36 bytes buffer. So we have an underflow in
Hi,
On Jan 31 2008 14:35, Boaz Harrosh wrote:
>
>Thanks, Perhaps someone else then.
>Anyone with gdth HW that can test patches?
Is bisecting down the existing chain and finding the bad commit
sufficient? (I also take new patches.)
>Your lspci said: "Intel Corporation RAID Controller" Matthew
>
On Thu, 2008-01-31 at 08:10 -0800, Nicholas A. Bellinger wrote:
> On Thu, 2008-01-31 at 09:34 -0600, James Bottomley wrote:
> > On Thu, 2008-01-31 at 06:10 -0800, Nicholas A. Bellinger wrote:
> > > Greetings Geert and Co,
> > >
> > > I have a related patch that I have been using with ps3rom.c for
On Thu, Jan 31, 2008 at 08:11:20AM -0800, Arjan van de Ven wrote:
> On Thu, 31 Jan 2008 09:57:31 -0600
> James Bottomley <[EMAIL PROTECTED]> wrote:
>
> > No-one seems to see much value in these, and they cause about 90% of
> > our problems with __init/__exit markers, so simply eliminate them.
> >
On Thu, 31 Jan 2008 09:57:31 -0600
James Bottomley <[EMAIL PROTECTED]> wrote:
> No-one seems to see much value in these, and they cause about 90% of
> our problems with __init/__exit markers, so simply eliminate them.
> Rather than run over the whole tree removing them, this patch
> #defines them
On Thu, 2008-01-31 at 09:34 -0600, James Bottomley wrote:
> On Thu, 2008-01-31 at 06:10 -0800, Nicholas A. Bellinger wrote:
> > Greetings Geert and Co,
> >
> > I have a related patch that I have been using with ps3rom.c for some
> > time that fixes a bug in fs/bio.c that assumes 512 byte sectors f
No-one seems to see much value in these, and they cause about 90% of our
problems with __init/__exit markers, so simply eliminate them. Rather
than run over the whole tree removing them, this patch #defines them to
be nops.
Signed-off-by: James Bottomley <[EMAIL PROTECTED]>
---
I'll probably be
Bart Van Assche wrote:
On Jan 31, 2008 2:25 PM, Nicholas A. Bellinger <[EMAIL PROTECTED]> wrote:
Since this particular code is located in a non-data path critical
section, the kernel vs. user discussion is a wash. If we are talking
about data path, yes, the relevance of DD tests in kernel desi
On Thu, 2008-01-31 at 06:10 -0800, Nicholas A. Bellinger wrote:
> Greetings Geert and Co,
>
> I have a related patch that I have been using with ps3rom.c for some
> time that fixes a bug in fs/bio.c that assumes 512 byte sectors for
> ATAPI operations. This bug actually exists for all non 512 byt
On Thu, Jan 31 2008 at 17:08 +0200, Mark Glines <[EMAIL PROTECTED]> wrote:
> On Thu, 31 Jan 2008 11:27:39 +0200
> Boaz Harrosh <[EMAIL PROTECTED]> wrote:
>
>> Please check the below patch.
>>
>> one thing that I can see is that the isd200 does an INQUARY transfer
>> of sizeof(struct inquiry_data)
Hi Bart,
On Thu, 2008-01-31 at 15:34 +0100, Bart Van Assche wrote:
> On Jan 31, 2008 2:25 PM, Nicholas A. Bellinger <[EMAIL PROTECTED]> wrote:
> > Since this particular code is located in a non-data path critical
> > section, the kernel vs. user discussion is a wash. If we are talking
> > about d
On Jan 31, 2008 2:25 PM, Nicholas A. Bellinger <[EMAIL PROTECTED]> wrote:
> Since this particular code is located in a non-data path critical
> section, the kernel vs. user discussion is a wash. If we are talking
> about data path, yes, the relevance of DD tests in kernel designs are
> suspect :p.
Greetings Geert and Co,
I have a related patch that I have been using with ps3rom.c for some
time that fixes a bug in fs/bio.c that assumes 512 byte sectors for
ATAPI operations. This bug actually exists for all non 512 byte sector
devices go through this code path (I found it with
scsi_execute_a
1 - 100 of 107 matches
Mail list logo
