Re: [PATCH 0/5] sg_ring for scsi

2007-12-20 Thread FUJITA Tomonori
On Fri, 21 Dec 2007 14:26:47 +1100 Rusty Russell <[EMAIL PROTECTED]> wrote: > On Friday 21 December 2007 13:28:34 FUJITA Tomonori wrote: > > I'm not sure about chaining the headers (as your sg_ring and > > scsi_sgtable do) would simplify LLDs. Have you looked at ips or > > qla1280? > > Not yet, a

Re: [PATCH 0/5] sg_ring for scsi

2007-12-20 Thread Rusty Russell
On Friday 21 December 2007 13:28:34 FUJITA Tomonori wrote: > I'm not sure about chaining the headers (as your sg_ring and > scsi_sgtable do) would simplify LLDs. Have you looked at ips or > qla1280? Not yet, am working my way through the drivers, but I don't expect it will be a simplification to

Re: [PATCH 2/5] dma_map_sg_ring() helper

2007-12-20 Thread Rusty Russell
On Friday 21 December 2007 11:40:00 David Miller wrote: > From: Rusty Russell <[EMAIL PROTECTED]> > Date: Fri, 21 Dec 2007 11:35:12 +1100 > > > On Friday 21 December 2007 11:00:27 FUJITA Tomonori wrote: > > > We need to pass the whole sg entries to the IOMMUs at a time. > > > > Hi Fujita, > > > >

[PATCH 1/2] DMA buffer alignment annotations

2007-12-20 Thread Benjamin Herrenschmidt
This patch based on some earlier work by Roland Dreier introduces a pair of annotations that can be used to enforce alignment of objects that can be DMA'ed into, and to enforce that an DMA'able object within a structure isn't sharing a cache line with some other object. Such sharing of a data stru

[PATCH 2/2] scsi: Use new __dma_buffer to align sense buffer in scsi_cmnd

2007-12-20 Thread Benjamin Herrenschmidt
The sense buffer ins scsi_cmnd can nowadays be DMA'ed into directly by some low level drivers (that typically happens with USB mass storage). This is a problem on non cache coherent architectures such as embedded PowerPCs where the sense buffer can share cache lines with other structure members, w

Re: [PATCH 0/5] sg_ring for scsi

2007-12-20 Thread FUJITA Tomonori
On Fri, 21 Dec 2007 10:13:38 +1100 Rusty Russell <[EMAIL PROTECTED]> wrote: > On Thursday 20 December 2007 18:58:07 David Miller wrote: > > From: Rusty Russell <[EMAIL PROTECTED]> > > Date: Thu, 20 Dec 2007 18:53:48 +1100 > > > > > Manipulating the magic chains is horrible; it looks simple to the

Re: [PATCH 2/5] dma_map_sg_ring() helper

2007-12-20 Thread FUJITA Tomonori
On Thu, 20 Dec 2007 16:40:00 -0800 (PST) David Miller <[EMAIL PROTECTED]> wrote: > From: Rusty Russell <[EMAIL PROTECTED]> > Date: Fri, 21 Dec 2007 11:35:12 +1100 > > > On Friday 21 December 2007 11:00:27 FUJITA Tomonori wrote: > > > We need to pass the whole sg entries to the IOMMUs at a time. >

Re: [PATCH 2/5] dma_map_sg_ring() helper

2007-12-20 Thread David Miller
From: Rusty Russell <[EMAIL PROTECTED]> Date: Fri, 21 Dec 2007 11:35:12 +1100 > On Friday 21 December 2007 11:00:27 FUJITA Tomonori wrote: > > We need to pass the whole sg entries to the IOMMUs at a time. > > Hi Fujita, > > OK, it's certainly possible to have an arch override. For which >

Re: [PATCH 2/5] dma_map_sg_ring() helper

2007-12-20 Thread Rusty Russell
On Friday 21 December 2007 11:00:27 FUJITA Tomonori wrote: > We need to pass the whole sg entries to the IOMMUs at a time. Hi Fujita, OK, it's certainly possible to have an arch override. For which architecture is this BTW? Thanks, Rusty. - To unsubscribe from this list: send the line "u

Re: [PATCH 0/5] sg_ring for scsi

2007-12-20 Thread David Miller
From: Rusty Russell <[EMAIL PROTECTED]> Date: Fri, 21 Dec 2007 10:13:38 +1100 > But, as demonstrated, there are real benefits of having an explicit header: > > 1) It removes the chain-end/explicit count ambiguity (see > http://lkml.org/lkml/2007/10/25/209 & thread) > 2) It allows others to manip

Re: [PATCH 2/5] dma_map_sg_ring() helper

2007-12-20 Thread FUJITA Tomonori
On Fri, 21 Dec 2007 09:58:56 +1100 Rusty Russell <[EMAIL PROTECTED]> wrote: > On Thursday 20 December 2007 18:42:44 David Miller wrote: > > From: FUJITA Tomonori <[EMAIL PROTECTED]> > > Date: Thu, 20 Dec 2007 16:06:31 +0900 > > > > > On Thu, 20 Dec 2007 16:49:30 +1100 > > > > > > Rusty Russell <[E

Re: [PATCH 0/5] sg_ring for scsi

2007-12-20 Thread Rusty Russell
On Thursday 20 December 2007 18:58:07 David Miller wrote: > From: Rusty Russell <[EMAIL PROTECTED]> > Date: Thu, 20 Dec 2007 18:53:48 +1100 > > > Manipulating the magic chains is horrible; it looks simple to the > > places which simply want to iterate through it, but it's awful for > > code which w

Re: [PATCH 2/5] dma_map_sg_ring() helper

2007-12-20 Thread Rusty Russell
On Thursday 20 December 2007 18:42:44 David Miller wrote: > From: FUJITA Tomonori <[EMAIL PROTECTED]> > Date: Thu, 20 Dec 2007 16:06:31 +0900 > > > On Thu, 20 Dec 2007 16:49:30 +1100 > > > > Rusty Russell <[EMAIL PROTECTED]> wrote: > > > +/** > > > + * dma_map_sg_ring - Map an entire sg ring > > >

Re: [PATCH] fix page_alloc for larger I/O segments (improved)

2007-12-20 Thread Matthew Wilcox
On Fri, Dec 14, 2007 at 11:13:40AM -0700, Matthew Wilcox wrote: > I'll send it to our DB team to see if this improves our numbers at all. It does, by approximately 0.67%. This is about double the margin of error, and a significant improvement. Thanks! -- Intel are signing my paycheques ... the

Re: 2.6.24-rc5-mm1 - SCSI/blkdev probing hang

2007-12-20 Thread Andrew Morton
On Thu, 20 Dec 2007 15:57:45 -0500 Rik van Riel <[EMAIL PROTECTED]> wrote: > 2.6.24-rc5-mm1 seems to have a hang related to the SCSI or block > device probing code. > > This is on a dual quad-core x86-64 system with megaraid_sas controller. > > scsi 0:2:0:0: Direct-Access DELL PERC 5/i

Re: [PATCHSET 0/3] varlen extended and vendor-specific cdbs

2007-12-20 Thread Boaz Harrosh
On Tue, Dec 18 2007 at 15:33 +0200, Boaz Harrosh <[EMAIL PROTECTED]> wrote: > Submitted is a patchset for adding support for variable-length, extended, and > vendor specific CDBs. It should now cover the entire range of the > SCSI standard. > ping James. I understand that this is the last thing

Re: smp_utils 0.93 beta, adds sgv4 interface

2007-12-20 Thread James Bottomley
On Wed, 2007-12-19 at 23:46 -0500, Douglas Gilbert wrote: > smp_utils is a package of command line utilities for invoking > SMP functions to monitor and manage SAS expanders. SMP is the > Serial Attached SCSI (SAS) Management Protocol (SMP). A SAS Host > Bus Adapter (HBA) includes a SMP initiator

Re: INITIO scsi driver fails to work properly

2007-12-20 Thread James Bottomley
On Thu, 2007-12-20 at 01:32 -0800, Natalie Protasevich wrote: > On Dec 19, 2007 9:05 AM, Matthew Wilcox <[EMAIL PROTECTED]> wrote: > > On Wed, Dec 19, 2007 at 10:50:40AM -0600, James Bottomley wrote: > > > So, to get the best of both worlds, file a bugzilla and note the bugid. > > > Then email a c

Re: INITIO scsi driver fails to work properly

2007-12-20 Thread Theodore Tso
On Thu, Dec 20, 2007 at 01:32:02AM -0800, Natalie Protasevich wrote: > > The problem is that it appears to the casual observer as if they can > > then add information to the bug through the web interface. But that > > information will never be forwarded to the mailing list. Unless there's > > a w

Re: [PATCH 2/3] SG: Convert SCSI to use scatterlist helpers for sg chaining

2007-12-20 Thread Boaz Harrosh
On Thu, Dec 20 2007 at 16:03 +0200, Boaz Harrosh <[EMAIL PROTECTED]> wrote: > From: Jens Axboe <[EMAIL PROTECTED]> > > Signed-off-by: Jens Axboe <[EMAIL PROTECTED]> > --- > drivers/scsi/libsrp.c|2 +- > drivers/scsi/scsi_error.c|4 +- > drivers/scsi/scsi_lib.c | 150 > +

Re: [PATCH 1/3] SG: Move functions to lib/scatterlist.c and add sg chaining allocator helpers

2007-12-20 Thread Boaz Harrosh
A small comment in body On Thu, Dec 20 2007 at 16:00 +0200, Boaz Harrosh <[EMAIL PROTECTED]> wrote: > Manually doing chained sg lists is not trivial, so add some helpers > to make sure that drivers get it right. > > Signed-off-by: Jens Axboe <[EMAIL PROTECTED]> > --- > include/linux/scatterlist.

[PATCH 3/3] SG: Update ide/ to use sg_table

2007-12-20 Thread Boaz Harrosh
From: Jens Axboe <[EMAIL PROTECTED]> Signed-off-by: Jens Axboe <[EMAIL PROTECTED]> --- drivers/ide/arm/icside.c |6 +++--- drivers/ide/cris/ide-cris.c |2 +- drivers/ide/ide-dma.c |8 drivers/ide/ide-io.c |2 +- drivers/ide/ide-probe.c |6

[PATCH 2/3] SG: Convert SCSI to use scatterlist helpers for sg chaining

2007-12-20 Thread Boaz Harrosh
From: Jens Axboe <[EMAIL PROTECTED]> Signed-off-by: Jens Axboe <[EMAIL PROTECTED]> --- drivers/scsi/libsrp.c|2 +- drivers/scsi/scsi_error.c|4 +- drivers/scsi/scsi_lib.c | 150 +- drivers/usb/storage/isd200.c |4 +- include/sc

[PATCH 1/3] SG: Move functions to lib/scatterlist.c and add sg chaining allocator helpers

2007-12-20 Thread Boaz Harrosh
Manually doing chained sg lists is not trivial, so add some helpers to make sure that drivers get it right. Signed-off-by: Jens Axboe <[EMAIL PROTECTED]> --- include/linux/scatterlist.h | 125 --- lib/Makefile|2 +- lib/scatterlist.c | 281

Re: [PATCH 0/5] sg_ring for scsi

2007-12-20 Thread Boaz Harrosh
On Thu, Dec 20 2007 at 9:58 +0200, Jens Axboe <[EMAIL PROTECTED]> wrote: > On Thu, Dec 20 2007, Rusty Russell wrote: >> On Thursday 20 December 2007 18:07:41 FUJITA Tomonori wrote: >>> On Thu, 20 Dec 2007 16:45:18 +1100 >>> >>> Rusty Russell <[EMAIL PROTECTED]> wrote: OK, some fixes since last

[patch 6/6] zfcp: Hold queue lock when checking port/unit handle for task management cmd

2007-12-20 Thread Christof Schmitt
From: Christof Schmitt <[EMAIL PROTECTED]> We need to hold the queue-lock when checking whether we still have a valid unit/port handle for the task management command, i.e whether we can issue this request for this unit/port. If the error recovery is about to close this unit/port, then it competes

[patch 3/6] zfcp: Hold queue lock when checking port/unit handle for abort command

2007-12-20 Thread Christof Schmitt
From: Christof Schmitt <[EMAIL PROTECTED]> We need to hold the queue-lock when checking whether we still have a valid unit/port handle for the abort command, i.e whether we can issue this request for this unit/port. If the error recovery is about to close this unit/port, then it competes for the q

[patch 5/6] zfcp: Hold queue lock when checking port/unit handle for FCP command

2007-12-20 Thread Christof Schmitt
From: Christof Schmitt <[EMAIL PROTECTED]> We need to hold the queue-lock when checking whether we still have a valid unit/port handle for the FCP command, i.e whether we can issue this request for this unit/port. If the error recovery is about to close this unit/port, then it competes for the que

[patch 4/6] zfcp: Hold queue lock when checking port handle for ELS command

2007-12-20 Thread Christof Schmitt
From: Christof Schmitt <[EMAIL PROTECTED]> We need to hold the queue-lock when checking whether we still have a valid port handle for the ELS command, i.e whether we can issue this request for this port. If the error recovery is about to close this port, then it competes for the queue-lock. If the

[patch 1/6] zfcp: fix use after free bug.

2007-12-20 Thread Christof Schmitt
From: Heiko Carstens <[EMAIL PROTECTED]> zfcp_erp_strategy_check_fsfreq() checks if it is safe to access the fsf_req associated with the erp_action that gets passed. To test if it is safe it accesses the fsf_req in order to get its index into the hash list. This is broken since the fsf_req might b

[patch 2/6] zfcp: Fix evaluation of port handles in abort handler

2007-12-20 Thread Christof Schmitt
From: Christof Schmitt <[EMAIL PROTECTED]> According to the FSF spec, word 0 (bytes 0-3) has the handle specified with the abort command and word 1 (bytes 4-7) has the handle for the command to be aborted. Fix the if statements that try to compare those. Signed-off-by: Christof Schmitt <[EMAIL PR

[patch 0/6] zfcp fixes for scsi-misc

2007-12-20 Thread Christof Schmitt
James, here are some zfcp fixes. They apply on the current version of scsi-misc. Regards, Christof Schmitt - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: INITIO scsi driver fails to work properly

2007-12-20 Thread Natalie Protasevich
On Dec 19, 2007 9:05 AM, Matthew Wilcox <[EMAIL PROTECTED]> wrote: > On Wed, Dec 19, 2007 at 10:50:40AM -0600, James Bottomley wrote: > > So, to get the best of both worlds, file a bugzilla and note the bugid. > > Then email a complete report to the relevant list, but add [BUG ] > > to the subject

Re: [PATCH 0/5] sg_ring for scsi

2007-12-20 Thread Jens Axboe
On Wed, Dec 19 2007, David Miller wrote: > From: Rusty Russell <[EMAIL PROTECTED]> > Date: Thu, 20 Dec 2007 18:53:48 +1100 > > > Manipulating the magic chains is horrible; it looks simple to the > > places which simply want to iterate through it, but it's awful for > > code which wants to create t

Re: [PATCH 0/5] sg_ring for scsi

2007-12-20 Thread Jens Axboe
On Thu, Dec 20 2007, Rusty Russell wrote: > On Thursday 20 December 2007 18:07:41 FUJITA Tomonori wrote: > > On Thu, 20 Dec 2007 16:45:18 +1100 > > > > Rusty Russell <[EMAIL PROTECTED]> wrote: > > > OK, some fixes since last time, as I wade through more SCSI drivers. > > > Some drivers use "use_sg