Re: [PATCH 1/5] add dma_max_segment_size option to scsi_host_template

2007-09-28 Thread FUJITA Tomonori
On Thu, 27 Sep 2007 02:31:14 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > FUJITA Tomonori wrote: > > You are right. scsi_debug's pseudo-bus works. > > > > But probabaly, scsi_debug doesn't need to call > > blk_queue_max_segment_size now. > > Either way works for me. :) > > > >> Maybe dev_se

Re: [PATCH] aic94xx: fix SMP request DMA direction

2007-09-28 Thread Jeff Garzik
Muli Ben-Yehuda wrote: On Fri, Sep 28, 2007 at 04:55:34PM -0700, Darrick J. Wong wrote: On Thu, Sep 27, 2007 at 10:33:41PM -0400, Jeff Garzik wrote: Unless I'm missing something, the SMP request goes /to/ the PCI device :) Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> ACK; builds ok and SMP

Re: [PATCH] aic94xx: fix SMP request DMA direction

2007-09-28 Thread Muli Ben-Yehuda
On Fri, Sep 28, 2007 at 04:55:34PM -0700, Darrick J. Wong wrote: > On Thu, Sep 27, 2007 at 10:33:41PM -0400, Jeff Garzik wrote: > > > > Unless I'm missing something, the SMP request goes /to/ the PCI device :) > > > > Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> > > ACK; builds ok and SMP comm

Re: [PATCH 4/5] qla2xxx: add target mode support

2007-09-28 Thread FUJITA Tomonori
On Thu, 27 Sep 2007 07:34:52 -0700 Seokmann Ju <[EMAIL PROTECTED]> wrote: > FUJITA Tomonori wrote: > > On Fri, 21 Sep 2007 07:34:18 -0700 > > Seokmann Ju <[EMAIL PROTECTED]> wrote: > > > >> Andrew Vasquez wrote: > >>> On Sat, 01 Sep 2007, FUJITA Tomonori wrote: > >>> > This adds target mode

Re: [PATCH] aic94xx: fix SMP request DMA direction

2007-09-28 Thread Darrick J. Wong
On Thu, Sep 27, 2007 at 10:33:41PM -0400, Jeff Garzik wrote: > > Unless I'm missing something, the SMP request goes /to/ the PCI device :) > > Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> ACK; builds ok and SMP commands seem to work ok (not that they didn't before). --Darrick > --- > driver

initiator+target port attributes by transport: sam4r13

2007-09-28 Thread Douglas Gilbert
A new draft of SAM-4 was released yesterday and Annex B has been added. It tabulates various attributes (e.g. maximums) for 5 modern SCSI transports. [SPI has dropped out of both Annex A and B.] See: http://www.t10.org/ftp/t10/drafts/sam4/sam4r13.pdf That should be a useful design tool. Strangely

RE: Some plans for scsi_cmnd

2007-09-28 Thread Moore, Eric
On Tuesday, September 25, 2007 7:38 AM, Matthew Wilcox wrote: > As I said, it's ambitious. But it'll let us get rid of scsi_pointer > and host_scribble entirely. > Are you serious about removing the host_scribble? In fusion we currently are hanging our per request message frame pointer th

Re: [PATCH 7/8] scsi: megaraid_sas - support for poll_mode_io (reduced interrupt)

2007-09-28 Thread Brian King
bo yang wrote: > Added module parameter "poll_mode_io" to support for "polling" (reduced > interrupt operation). > In this mode, IO completion interrupts are delayed. At the end of > initiating IOs, > the driver schedules for cmd completion if there are pending cmds. >

Re: [linux-usb-devel] question on flushing buffers and spinning down disk

2007-09-28 Thread Oliver Neukum
Am Freitag 28 September 2007 schrieb Alan Stern: > On Fri, 28 Sep 2007, Oliver Neukum wrote: > > > Am Donnerstag 27 September 2007 schrieb Alan Stern: > > > Have you thought about how autoresume would fit into this picture?  I > > > don't think you can rely on usb-storage telling the SCSI core to

Re: [linux-usb-devel] question on flushing buffers and spinning down disk

2007-09-28 Thread Oliver Neukum
Am Freitag 28 September 2007 schrieb Alan Stern: > On Fri, 28 Sep 2007, Oliver Neukum wrote: > > > Am Donnerstag 27 September 2007 schrieb Alan Stern: > > > There's also a philosophical objection.  Who is in a better position to > > > judge when a device like a SCSI drive should be autosuspended:

Re: [PATCH 3/8] scsi: megaraid_sas - add module param max_sectors, cmd_per_lun

2007-09-28 Thread Brian King
bo yang wrote: > +static ssize_t > +sysfs_max_sectors_read(struct kobject *kobj, > + struct bin_attribute *bin_attr, > + char *buf, loff_t off, size_t count) > +{ > + struct Scsi_Host *host = class_to_shost(container_of(kobj, > +

Re: [linux-usb-devel] question on flushing buffers and spinning down disk

2007-09-28 Thread Alan Stern
On Fri, 28 Sep 2007, Oliver Neukum wrote: > Am Donnerstag 27 September 2007 schrieb Alan Stern: > > Have you thought about how autoresume would fit into this picture?  I > > don't think you can rely on usb-storage telling the SCSI core to resume > > devices when it gets handed a command, because t

Re: [PATCH 5/8] scsi: megaraid_sas - using unsigned long for sense_buff ptr

2007-09-28 Thread Randy Dunlap
On Wed, 26 Sep 2007 11:41:07 -0400 bo yang wrote: > MegaRAID utilities expect sense_buff to be of type unsigned long. > > Signed-off-by: Bo Yang <[EMAIL PROTECTED]> > > --- > drivers/scsi/megaraid/megaraid_sas.c | 13 - > 1 files changed, 8 insertions(+), 5 deletions(-) > > diff

Re: [PATCH 4/8] scsi: megaraid_sas - check max_sgl reported by FW for setting max_sectors_per_req

2007-09-28 Thread Randy Dunlap
On Wed, 26 Sep 2007 11:35:36 -0400 bo yang wrote: > 1. Setting the max_sectors_per_req based on max SGL supported by the FW. > Prior versions calculated > this value from controller info's max_sectors_1, max_sectors_2. For > certain controllers/FW, > this was resulting in a va

[PATCH 8/8] scsi: megaraid_sas - Update version and changelog

2007-09-28 Thread bo yang
Update version and changelog Signed-off-by: Bo Yang <[EMAIL PROTECTED]> --- Documentation/scsi/ChangeLog.megaraid_sas | 160 drivers/scsi/megaraid/megaraid_sas.c |2 drivers/scsi/megaraid/megaraid_sas.h |7 3 files changed, 165 insertions(+), 4 deletions(-

[PATCH 7/8] scsi: megaraid_sas - support for poll_mode_io (reduced interrupt)

2007-09-28 Thread bo yang
Added module parameter "poll_mode_io" to support for "polling" (reduced interrupt operation). In this mode, IO completion interrupts are delayed. At the end of initiating IOs, the driver schedules for cmd completion if there are pending cmds. A timer-based interrupt has

Re: PATCH [2/8] scsi: megaraid_sas - add module param fast_load

2007-09-28 Thread Randy Dunlap
On Wed, 26 Sep 2007 11:22:10 -0400 bo yang wrote: > Driver will skip physical devices scan for the first time if the fast_load is > set. This is to reduce time for loading driver. > > Signed-off-by: Bo Yang <[EMAIL PROTECTED]> > > --- > drivers/scsi/megaraid/megaraid_sas.c | 69 +

Re: [PATCH 3/8] scsi: megaraid_sas - add module param max_sectors, cmd_per_lun

2007-09-28 Thread Randy Dunlap
On Wed, 26 Sep 2007 11:27:50 -0400 bo yang wrote: > Adding module parameters to configure max sectors per request & # of cmds per > lun. > > Signed-off-by: Bo Yang <[EMAIL PROTECTED]> > > --- > drivers/scsi/megaraid/megaraid_sas.c | 94 - > drivers/scsi/megaraid/megar

[PATCH 6/8] scsi: megaraid_sas - call cmd completion from reset

2007-09-28 Thread bo yang
Driver will call cmd completion routine from Reset path without waiting for cmd completion from isr context. Signed-off-by: Bo Yang <[EMAIL PROTECTED]> --- drivers/scsi/megaraid/megaraid_sas.c | 107 - drivers/scsi/megaraid/megaraid_sas.h |2 2 files changed, 55 ins

[PATCH 5/8] scsi: megaraid_sas - using unsigned long for sense_buff ptr

2007-09-28 Thread bo yang
MegaRAID utilities expect sense_buff to be of type unsigned long. Signed-off-by: Bo Yang <[EMAIL PROTECTED]> --- drivers/scsi/megaraid/megaraid_sas.c | 13 - 1 files changed, 8 insertions(+), 5 deletions(-) diff -uprN linux-2.6.22_orig/drivers/scsi/megaraid/megaraid_sas.c linux-2

[PATCH 4/8] scsi: megaraid_sas - check max_sgl reported by FW for setting max_sectors_per_req

2007-09-28 Thread bo yang
1. Setting the max_sectors_per_req based on max SGL supported by the FW. Prior versions calculated this value from controller info's max_sectors_1, max_sectors_2. For certain controllers/FW, this was resulting in a value greater than max SGL supported by the FW. Now we take th

[PATCH 3/8] scsi: megaraid_sas - add module param max_sectors, cmd_per_lun

2007-09-28 Thread bo yang
Adding module parameters to configure max sectors per request & # of cmds per lun. Signed-off-by: Bo Yang <[EMAIL PROTECTED]> --- drivers/scsi/megaraid/megaraid_sas.c | 94 - drivers/scsi/megaraid/megaraid_sas.h |2 2 files changed, 94 insertions(+), 2 deletions(-)

PATCH [2/8] scsi: megaraid_sas - add module param fast_load

2007-09-28 Thread bo yang
Driver will skip physical devices scan for the first time if the fast_load is set. This is to reduce time for loading driver. Signed-off-by: Bo Yang <[EMAIL PROTECTED]> --- drivers/scsi/megaraid/megaraid_sas.c | 69 +++-- 1 files changed, 55 insertions(+), 14 deletions(-)

Re: [linux-usb-devel] question on flushing buffers and spinning down disk

2007-09-28 Thread Greg KH
On Fri, Sep 28, 2007 at 09:02:45AM +0200, Oliver Neukum wrote: > Am Freitag 28 September 2007 schrieb Greg KH: > > On Tue, Sep 25, 2007 at 05:11:00PM +0200, Oliver Neukum wrote: > > > > > > PS: Whoever designed klists is suffering from a case of > > > overengineeringosis. > > > > No objection fr

[PATCH 1/8] scsi: megaraid_sas - add hibernation support

2007-09-28 Thread bo yang
Adding hibernation support. suspend, resume routine implemented. Signed-off-by: Bo Yang <[EMAIL PROTECTED]> --- drivers/scsi/megaraid/megaraid_sas.c | 302 +++-- drivers/scsi/megaraid/megaraid_sas.h |1 2 files changed, 233 insertions(+), 70 deletions(-) diff -rupN linu

Re: [PATCH] 3w-9xxx: use PCI resource length correctly

2007-09-28 Thread Eduardo Pereira Habkost
On Fri, Sep 28, 2007 at 10:50:34AM -0400, Jeff Garzik wrote: > > > > /* Save base address */ > >-tw_dev->base_addr = ioremap(mem_addr, PAGE_SIZE); > >+tw_dev->base_addr = ioremap(mem_addr, mem_len); > > Have you verified that the hardware resource is always a reasonable size? I have

Re: [linux-usb-devel] question on flushing buffers and spinning down disk

2007-09-28 Thread Alan Stern
On Fri, 28 Sep 2007, Oliver Neukum wrote: > Am Donnerstag 27 September 2007 schrieb Alan Stern: > > There's also a philosophical objection.  Who is in a better position to > > judge when a device like a SCSI drive should be autosuspended: its own > > driver (sd) or someone else (usb-storage)? > >

Re: [linux-usb-devel] question on flushing buffers and spinning down disk

2007-09-28 Thread Alan Stern
On Fri, 28 Sep 2007, Oliver Neukum wrote: > > You're right; there's no showstopping reason particular subsystems like > > SCSI can't use a different approach. However bus activity alone isn't > > a sufficient criterion. For example, suppose somebody sends a PLAY > > AUDIO command to a SCSI cdrom

Re: [PATCH] 3w-9xxx: use PCI resource length correctly

2007-09-28 Thread Jeff Garzik
Eduardo Habkost wrote: Trying to ioremap() a larger area than pci_resource_len() may fail (e.g. under Xen). Fixes 3w-9xxx to use pci_resource_len() as length parameter to ioremap() instead of PAGE_SIZE. Signed-off-by: Eduardo Habkost <[EMAIL PROTECTED]> --- drivers/scsi/3w-9xxx.c | 14 +++

[PATCH] 3w-9xxx: use PCI resource length correctly

2007-09-28 Thread Eduardo Habkost
Trying to ioremap() a larger area than pci_resource_len() may fail (e.g. under Xen). Fixes 3w-9xxx to use pci_resource_len() as length parameter to ioremap() instead of PAGE_SIZE. Signed-off-by: Eduardo Habkost <[EMAIL PROTECTED]> --- drivers/scsi/3w-9xxx.c | 14 +- 1 files changed,

Re: [linux-usb-devel] question on flushing buffers and spinning down disk

2007-09-28 Thread Oliver Neukum
Am Donnerstag 27 September 2007 schrieb Alan Stern: > There's also a philosophical objection.  Who is in a better position to > judge when a device like a SCSI drive should be autosuspended: its own > driver (sd) or someone else (usb-storage)? Then a philosophical answer. The highest entity which

Re: [linux-usb-devel] question on flushing buffers and spinning down disk

2007-09-28 Thread Oliver Neukum
Am Donnerstag 27 September 2007 schrieb Alan Stern: > Have you thought about how autoresume would fit into this picture?  I > don't think you can rely on usb-storage telling the SCSI core to resume > devices when it gets handed a command, because the commands to spin-up > the drives would have to b

Re: [linux-usb-devel] question on flushing buffers and spinning down disk

2007-09-28 Thread Oliver Neukum
Am Donnerstag 27 September 2007 schrieb Alan Stern: > On Thu, 27 Sep 2007, Oliver Neukum wrote: > > > > > 1. autosuspend should not be specific to USB > > > > > > Correct. Which means support for it should be added to the SCSI > > > drivers. SCSI autosuspend shouldn't be kluged into usb-storage

Re: [linux-usb-devel] question on flushing buffers and spinning down disk

2007-09-28 Thread Oliver Neukum
Am Freitag 28 September 2007 schrieb Greg KH: > On Tue, Sep 25, 2007 at 05:11:00PM +0200, Oliver Neukum wrote: > > > > PS: Whoever designed klists is suffering from a case of overengineeringosis. > > No objection from me there.  If you can think of a way to do list > traversal without taking lock