Re: [PATCH 09/24] libata-scsi: convert to use the data buffer accessors

On 9/12/07, Matthew Dharm <[EMAIL PROTECTED]> wrote: > On Tue, Sep 11, 2007 at 08:09:51PM -0400, Jeff Garzik wrote: > > I would much rather see the !use_sg cleanup in a separate patch series... > > Are we really sure this can all go? No requests, not even ones from SG_IO > will ever use the non-sg

Re: [PATCH 09/24] libata-scsi: convert to use the data buffer accessors

On Tue, Sep 11, 2007 at 08:09:51PM -0400, Jeff Garzik wrote: > I would much rather see the !use_sg cleanup in a separate patch series... Are we really sure this can all go? No requests, not even ones from SG_IO will ever use the non-sg paths? Matt -- Matthew Dharm

Re: [PATCH 09/24] libata-scsi: convert to use the data buffer accessors

On Wed, Sep 12 2007 at 3:09 +0300, Jeff Garzik <[EMAIL PROTECTED]> wrote: > I would much rather see the !use_sg cleanup in a separate patch series... > > Jeff > > > Sure. Only its 3:22 am (of the next day) here. And I'm going on an Hebrew-new-year holiday so it will only be for Sunday ne

[PATCH 24/24] ide-scsi.c: convert to data accessors and !use_sg cleanup

- Convert ide-scsi to the new data accessors and cleanup the !use_sg code paths. Inspecting old code I can see places that still assume scsi_cmnd->request_buffer is a linear char pointer. Though I admit this assumption is hidden behind a flag: test_bit(PC_TRANSFORM, &pc->flags). I h

[PATCH 21/24] qlogicpti.c: convert to accessors and !use_sg cleanup

- convert to accessors and !use_sg cleanup [Note: This patch might conflict with upstream patches to this driver. If so, please tell me and I'll fix it.] Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]> --- drivers/scsi/qlogicpti.c | 54 + 1 files

[PATCH 23/24] wd7000.c - proper fix for boards without sg support

- code used to set sg_tablesize to zero for board revision less than 6. This is no longer supported, therefore I use sg_tablesize=1 and open code the sg handling for that case. - Get rid of use of SG_NONE which will be removed soon. Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]> ---

[PATCH 19/24] wd33c93.c: convert to accessors and !use_sg cleanup

- convert to accessors and !use_sg cleanup Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]> --- drivers/scsi/wd33c93.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/wd33c93.c b/drivers/scsi/wd33c93.c index b92ff04..0e3bdfb 100644 --- a/drivers/scs

Subject: [PATCH 22/24] Remove psi240i driver from kernel

The psi240i driver is still written for cmnd->request_buffer as a char pointer to actual data. There was never any attempt to use the scatterlist option. - remove all source files (3) from drivers/scsi - Remove from Makefile and Kconfig Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]> -

[PATCH 17/24] in2000.c: convert to accessors and !use_sg cleanup

- convert to accessors and !use_sg cleanup Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]> --- drivers/scsi/in2000.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/in2000.c b/drivers/scsi/in2000.c index 312190a..31e841c 100644 --- a/drivers/scsi/i

Re: [PATCH 09/24] libata-scsi: convert to use the data buffer accessors

I would much rather see the !use_sg cleanup in a separate patch series... Jeff - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Subject: [PATCH 20/24] scsi: esp family convert to accessors and !use_sg cleanup

- convert to scsi data accessors and !use_sg code path removal - When removing !use_sg code path I noticed that dma_mmu_get_scsi_one() && dma_mmu_release_scsi_one() are no longer used. So also remove all implementations of these. - This family of drivers is totally not ready

[PATCH 18/24] ppa.c: convert to accessors and !use_sg cleanup

- convert to accessors and !use_sg cleanup Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]> --- drivers/scsi/ppa.c | 12 +--- 1 files changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/scsi/ppa.c b/drivers/scsi/ppa.c index 67b6d76..f9fdc8a 100644 --- a/drivers/scsi/ppa.c ++

[PATCH 16/24] imm.c: convert to accessors and !use_sg cleanup

- convert to accessors and !use_sg cleanup - Not ready for sg-chaining Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]> --- drivers/scsi/imm.c | 13 + 1 files changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/scsi/imm.c b/drivers/scsi/imm.c index 005d2b0..5ee4e0a 1006

[PATCH 13/24] aha1542.c: convert to accessors and !use_sg cleanup

- convert to accessors and !use_sg cleanup Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]> --- drivers/scsi/aha1542.c | 54 +++ 1 files changed, 13 insertions(+), 41 deletions(-) diff --git a/drivers/scsi/aha1542.c b/drivers/scsi/aha1542.c index cb

[PATCH 15/24] fd_mcs.c: convert to accessors and !use_sg cleanup

- convert to accessors and !use_sg cleanup - Not ready for sg-chaining Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]> --- drivers/scsi/fd_mcs.c | 36 +++- 1 files changed, 11 insertions(+), 25 deletions(-) diff --git a/drivers/scsi/fd_mcs.c b/drivers/scsi/fd

[PATCH 12/24] a3000.c: convert to accessors and !use_sg cleanup

- convert to accessors and !use_sg cleanup Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]> --- drivers/scsi/a3000.c | 15 +++ 1 files changed, 3 insertions(+), 12 deletions(-) diff --git a/drivers/scsi/a3000.c b/drivers/scsi/a3000.c index 796f1c4..d7255c8 100644 --- a/drivers/scs

[PATCH 11/24] a2091.c: convert to accessors and !use_sg cleanup

- convert to accessors and !use_sg cleanup Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]> --- drivers/scsi/a2091.c | 36 +--- 1 files changed, 5 insertions(+), 31 deletions(-) diff --git a/drivers/scsi/a2091.c b/drivers/scsi/a2091.c index b7c5385..23f27c9 100

[PATCH 14/24] atp870u.c: convert to accessors and !use_sg cleanup

- convert to accessors and !use_sg cleanup - Probably not ready for sg-chaining Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]> --- drivers/scsi/atp870u.c | 102 1 files changed, 17 insertions(+), 85 deletions(-) diff --git a/drivers/scsi/atp8

[PATCH 10/24] eata_pio.c: convert to accessors and !use_sg cleanup

- convert to accessors and !use_sg cleanup Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]> --- drivers/scsi/eata_pio.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/eata_pio.c b/drivers/scsi/eata_pio.c index f33ad01..266ddc9 100644 --- a/driver

[PATCH 07/24] arm: scsi convert to accessors and !use_sg cleanup

- convert to accessors and !use_sg cleanup Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]> --- drivers/scsi/arm/acornscsi.c | 14 +++--- drivers/scsi/arm/scsi.h | 34 +++--- 2 files changed, 18 insertions(+), 30 deletions(-) diff --git a/drivers/scs

[PATCH 09/24] libata-scsi: convert to use the data buffer accessors

This is a minimal patch needed to use the data accessors but it is not a complete clean up of the !use_sg path. Libata-core still has the qc->flags & ATA_QCFLAG_SG and !qc->n_elem code paths. Perhaps an ata maintainer would have a go at it. - TODO: further cleanup of

[PATCH 08/24] nsp_cs.c convert to data accessors and !use_sg cleanup

- use scsi data accessors - cleanup !use_sg code paths - TODO: use next_sg() for Jens's sglist branch. Look for 2 places with "SCp.buffer++" Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]> --- drivers/scsi/pcmcia/nsp_cs.c | 54 ++--- 1 files chang

[PATCH 05/24] isd200.c: use one-element sg list in issuing commands

- isd200_action() was still using direct linear pointers in issuing commands to the USB transport level. This is no longer supported, use one-element scatterlist instead. - Adjustment of command's length in the case of scsi-to-ata translation is now restored before return to queuec

[PATCH 06/24] NCR5380 familly convert to accessors & !use_sg cleanup

- This patch depends on: NCR5380: Use scsi_eh API for REQUEST_SENSE invocation - convert to accessors and !use_sg cleanup - FIXME: Not sg-chain ready look for ++cmd->SCp.buffer Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]> --- drivers/scsi/NCR5380.c | 14 +++--- dri

[PATCH 01/24] usb: transport - convert to accessors and !use_sg code path removal

- This patch depends on: usb: transport.c use scsi_eh API in REQUEST_SENSE execution - Use scsi data accessors and remove of !use_sg code path. - New usb_stor_bulk_srb() for use by drivers Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]> --- drivers/usb/storage/transport.c | 44 +

[PATCH 04/24] usb: freecom.c & sddr09.c - convert to accessors and !use_sg cleanup

- Use scsi data accessors and remove of !use_sg code path - This patch is dependent on cleanup patch to usb transport.c/h Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]> --- drivers/usb/storage/freecom.c | 14 ++ drivers/usb/storage/sddr09.c |9 +++-- 2 files changed, 9

[PATCH 03/24] usb: shuttle_usbat.c - convert to accessors and !use_sg code path removal

- functions that received char* but where passed scatterlist* mostly were changed to receive void* - Use scsi data accessors and remove of !use_sg code path Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]> --- drivers/usb/storage/shuttle_usbat.c | 68 +- 1 f

[PATCH 02/24] usb: protocol.c - convert to accessors and !use_sg code path removal

- Use scsi data accessors and remove of !use_sg code path Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]> --- drivers/usb/storage/protocol.c | 120 --- 1 files changed, 49 insertions(+), 71 deletions(-) diff --git a/drivers/usb/storage/protocol.c b/drivers/

Re: [patchset 0/24] Lots of the Accessors patches and !use_sg cleanup

On Tue, Sep 11 2007 at 23:50 +0300, "Cameron, Steve" <[EMAIL PROTECTED]> wrote: > drivers/block/cciss_scsi.c Already done by Tomo 41ce639a1c50cb936f058f52f99f65740e3f550e cciss: convert to use the data buffer accessors - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in t

RE: [patchset 0/24] Lots of the Accessors patches and !use_sg cleanup

Boaz Harrosh wrote: > Here are more accessors patches. I have tried > to find Maintainers of drivers but please help me if > I missed any. The cciss tape drive code probably needs updating. It's in drivers/block/cciss_scsi.c -- steve - To unsubscribe from this list: send the line "u

[patchset 0/24] Lots of the Accessors patches and !use_sg cleanup

Here are more accessors patches. I have tried to find Maintainers of drivers but please help me if I missed any. After this there are 3 drivers left (I think) - gdth.c, pluto.c, seagate.c These I'll send only next week in a set of their own. {Please tell me I can kill pluto and seagate.} Some of

Re: sata & scsi suggestion for make menuconfig

Andi Kleen wrote on 09-09-07 23:22: When it costs 1 people half an hour to learn and correct this it wasted 5000 hours of previous livetime. ^^ ^ Poor me. Here I am -- still waiting for my 15 minutes of fame in /this/ life... ;-) bjd - To unsubscribe fr

Re: [PATCH 22/27] blk_end_request: changing xsysace (take 2)

On 9/11/07, Kiyoshi Ueda <[EMAIL PROTECTED]> wrote: > This patch converts xsysace to use blk_end_request(). > > xsysace is a little bit different from "normal" drivers. > xsysace driver has a state machine in it. > It calls end_that_request_first() and end_that_request_last() > from different state

[PATCH 26/27] blk_end_request: changing ide-cd (take 2)

This patch converts ide-cd (cdrom_newpc_intr()) to use blk_end_request(). Due to the oddness of the driver, the patch adds a variant of the interface, blk_end_request_callback(). cdrom_newpc_intr() of ide-cd is the only function in the kernel tree which needs to call end_that_request_first() and

[PATCH 27/27] blk_end_request: remove/unexport end_that_request_* (take 2)

This patch removes the following functions: o end_that_request_first() o end_that_request_chunk() and stops exporting the functions below: o end_that_request_last() Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- block/ll_rw_blk.c

[PATCH 25/27] blk_end_request: changing ide normal caller (take 2)

This patch converts "normal" parts of ide to use blk_end_request(). Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- drivers/ide/ide-cd.c |6 +++--- drivers/ide/ide-io.c | 22 +++--- 2 files changed, 10 insertions(+), 18

[PATCH 23/27] blk_end_request: changing cciss (take 2)

This patch converts cciss to use blk_end_request(). cciss is a little bit different from "normal" drivers. cciss directly calls bio_endio() and disk_stat_add() when completing request. But those can be replaced with __end_that_request_first(). After the replacement, request completion procedures

[PATCH 24/27] blk_end_request: changing cpqarray (take 2)

This patch converts cpqarray to use blk_end_request(). cpqarray is a little bit different from "normal" drivers. cpqarray directly calls bio_endio() and disk_stat_add() when completing request. But those can be replaced with __end_that_request_first(). After the replacement, request completion pr

[PATCH 21/27] blk_end_request: changing ide-scsi (take 2)

This patch converts ide-scsi to use blk_end_request(). Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- drivers/scsi/ide-scsi.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff -rupN 20-scsi-mid-caller-change/drivers/scs

[PATCH 22/27] blk_end_request: changing xsysace (take 2)

This patch converts xsysace to use blk_end_request(). xsysace is a little bit different from "normal" drivers. xsysace driver has a state machine in it. It calls end_that_request_first() and end_that_request_last() from different states. (ACE_FSM_STATE_REQ_TRANSFER and ACE_FSM_STATE_REQ_COMPLETE,

[PATCH 20/27] blk_end_request: changing scsi (take 2)

This patch converts scsi mid-layer to use blk_end_request(). Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- drivers/scsi/scsi_lib.c | 13 ++--- 1 files changed, 2 insertions(+), 11 deletions(-) diff -rupN 19-s390-caller-change/dri

[PATCH 19/27] blk_end_request: changing s390 (take 2)

This patch converts s390 to use blk_end_request(). Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- drivers/s390/block/dasd.c |4 +--- drivers/s390/char/tape_block.c |3 +-- 2 files changed, 2 insertions(+), 5 deletions(-) diff -

[PATCH 18/27] blk_end_request: changing mmc (take 2)

This patch converts mmc to use blk_end_request(). Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- drivers/mmc/card/block.c | 24 +--- drivers/mmc/card/queue.c |4 ++-- 2 files changed, 7 insertions(+), 21 deletions(-

[PATCH 16/27] blk_end_request: changing viocd (take 2)

This patch converts viocd to use blk_end_request(). Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- drivers/cdrom/viocd.c |5 + 1 files changed, 1 insertion(+), 4 deletions(-) diff -rupN 15-xen-caller-change/drivers/cdrom/viocd.c 16

[PATCH 17/27] blk_end_request: changing i2o_block (take 2)

This patch converts i2o_block to use blk_end_request(). Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- drivers/message/i2o/i2o_block.c |8 ++-- 1 files changed, 2 insertions(+), 6 deletions(-) diff -rupN 16-viocd-caller-change/drive

[PATCH 15/27] blk_end_request: changing xen-blkfront (take 2)

This patch converts xen-blkfront to use blk_end_request(). Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- drivers/block/xen-blkfront.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff -rupN 14-viodasd-caller-change/driver

[PATCH 14/27] blk_end_request: changing viodasd (take 2)

This patch converts viodasd to use blk_end_request(). Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- drivers/block/viodasd.c |5 + 1 files changed, 1 insertion(+), 4 deletions(-) diff -rupN 13-ub-caller-change/drivers/block/viodasd.

[PATCH 13/27] blk_end_request: changing ub (take 2)

This patch converts ub to use blk_end_request(). Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- drivers/block/ub.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff -rupN 12-sx8-caller-change/drivers/block/ub.c 13-ub-calle

[PATCH 12/27] blk_end_request: changing sx8 (take 2)

This patch converts sx8 to use blk_end_request(). Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- drivers/block/sx8.c |4 +--- 1 files changed, 1 insertion(+), 3 deletions(-) diff -rupN 11-sunvdc-caller-change/drivers/block/sx8.c 12-sx8

[PATCH 11/27] blk_end_request: changing sunvdc (take 2)

This patch converts sunvdc to use blk_end_request(). Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- drivers/block/sunvdc.c |5 + 1 files changed, 1 insertion(+), 4 deletions(-) diff -rupN 10-ps3disk-caller-change/drivers/block/sunvd

[PATCH 10/27] blk_end_request: changing ps3disk (take 2)

This patch converts ps3disk to use blk_end_request(). Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- drivers/block/ps3disk.c |6 +- 1 files changed, 1 insertion(+), 5 deletions(-) diff -rupN 09-nbd-caller-change/drivers/block/ps3dis

[PATCH 09/27] blk_end_request: changing nbd (take 2)

This patch converts nbd to use blk_end_request(). Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- drivers/block/nbd.c |4 +--- 1 files changed, 1 insertion(+), 3 deletions(-) diff -rupN 08-lguest-caller-change/drivers/block/nbd.c 09-nbd

[PATCH 08/27] blk_end_request: changing lguest (take 2)

This patch converts lguest to use blk_end_request(). Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- drivers/block/lguest_blk.c |5 + 1 files changed, 1 insertion(+), 4 deletions(-) diff -rupN 07-floppy-caller-change/drivers/block/lg

[PATCH 07/27] blk_end_request: changing floppy (take 2)

This patch converts floppy to use blk_end_request(). Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- drivers/block/floppy.c |8 +++- 1 files changed, 3 insertions(+), 5 deletions(-) diff -rupN 06-dac960-caller-change/drivers/block/fl

[PATCH 06/27] blk_end_request: changing DAC960 (take 2)

This patch converts DAC960 to use blk_end_request(). Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- drivers/block/DAC960.c |5 + 1 files changed, 1 insertion(+), 4 deletions(-) diff -rupN 05-um-caller-change/drivers/block/DAC960.c

[PATCH 05/27] blk_end_request: changing um (take 2)

This patch converts um to use blk_end_request(). Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- arch/um/drivers/ubd_kern.c | 10 +- 1 files changed, 1 insertion(+), 9 deletions(-) diff -rupN 04-arm-caller-change/arch/um/drivers/ub

[PATCH 04/27] blk_end_request: changing arm (take 2)

This patch converts arm to use blk_end_request(). Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- arch/arm/plat-omap/mailbox.c |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff -rupN 03-blkcore-caller-change/arch/arm/p

[PATCH 01/27] blk_end_request: add new request completion interface (take 2)

This patch adds 2 new interfaces for request completion: o blk_end_request() : called without queue lock o __blk_end_request() : called with queue lock held Some device drivers call some generic functions below between end_that_request_{first/chunk} and end_that_request_last(). o add_disk_

[PATCH 03/27] blk_end_request: changing block layer core (take 2)

This patch converts core parts of block layer to use blk_end_request(). Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- block/ll_rw_blk.c | 15 +-- 1 files changed, 5 insertions(+), 10 deletions(-) diff -rupN 02-rq-size-macro/b

[PATCH 02/27] blk_end_request: add blk_rq_size() functions (take 2)

This patch adds functions to get the size of request in bytes. They are useful because blk_end_request() takes bytes as a completed I/O size instead of sectors. Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- include/linux/blkdev.h | 24 +++

[PATCH 00/27] blk_end_request: full I/O completion handler (take 2)

Hello, The following is the revised patch-set, fixing the issue pointed out by Jens and Benny. Changes from the previous post are below: o Rebased on top of 2.6.23-rc4-mm1 o Don't pass the lock held information (PATCH 01) o Removed sect2byte() macro (PATCH 02) o fixed blk_rq_size() and bl

RE: SCSI device recover

Hi, We're seeing an issue where a SCSI device failure freezes the system and it takes about 13s for the system to recover. Not knowing enough about SCSI or how SCSI works on Linux I have a couple questions. - is there a way to configure the recovery timeouts such as aborts and resets? - if

Re: [0/22] Advansys updates 2007-09-09

On Tue, Sep 11, 2007 at 05:00:27AM +0900, FUJITA Tomonori wrote: > On Sun, 9 Sep 2007 08:53:58 -0600 > Matthew Wilcox <[EMAIL PROTECTED]> wrote: > > > Here's another mammoth patch series for the advansys driver against > > scsi-misc. I've tested that it compiles at each stage and that the > > fin

Re: [PATCH ver4 1/5] scsi_error: code cleanup before refactoring of scsi_send_eh_cmnd()

- regrouped variables for easier reviewing of next patch - Support of cmnd==NULL in call to scsi_send_eh_cmnd() - In the copy_sense case set transfer size to the minimum size of sense_buffer and passed @sense_bytes. cmnd[4] is set accordingly. - REQUEST_SENSE is set into cmnd[0] so

Re: [PATCH ver3 1/5] scsi_error: code cleanup before refactoring of scsi_send_eh_cmnd()

On Tue, Sep 11 2007 at 18:41 +0300, Alan Stern <[EMAIL PROTECTED]> wrote: > On Tue, 11 Sep 2007, Boaz Harrosh wrote: > >> - regrouped variables for easier reviewing of next patch >> - Support of cmnd==NULL in call to scsi_send_eh_cmnd() >> - In the copy_sense case set transfer size to the mi

Re: [PATCH][RFC] Use bio markers for request callback

Hi Hannes, On Tue, 11 Sep 2007 12:44:46 +0200, Hannes Reinecke <[EMAIL PROTECTED]> wrote: > this is a proposal for a different implementation of request > callbacks. The existing ->endio callback of a request is actually a > destructor function, to be called to terminate a request and free all

Re: [PATCH ver3 1/5] scsi_error: code cleanup before refactoring of scsi_send_eh_cmnd()

On Tue, 11 Sep 2007, Boaz Harrosh wrote: > - regrouped variables for easier reviewing of next patch > - Support of cmnd==NULL in call to scsi_send_eh_cmnd() > - In the copy_sense case set transfer size to the minimum > size of sense_buffer and passed @sense_bytes. cmnd[4] is > set ac

switch sdev sysfs attributes to default attributes

From: Kay Sievers <[EMAIL PROTECTED]> Subject: [SCSI] switch sdev sysfs attributes to default attributes This removes the unused sysfs attribute overwriting logic for most of the attributes, and plugs them into the driver core default attribute creation. Without this patch, at the time of the eve

Re: [PATCH][RFC] Use bio markers for request callback

Am Tue 11 Sep 2007 01:11:34 PM CEST schrieb Jens Axboe <[EMAIL PROTECTED]>: On Tue, Sep 11 2007, Hannes Reinecke wrote: Hi all, this is a proposal for a different implementation of request callbacks. The existing ->endio callback of a request is actually a destructor function, to be called t

Re: [PATCH][RFC] Use bio markers for request callback

On Tue, Sep 11 2007, Hannes Reinecke wrote: > Hi all, > > this is a proposal for a different implementation of request callbacks. The > existing ->endio callback of a request is actually a destructor function, > to be called to terminate a request and free all structures. > > However, on certain

[PATCH][RFC] Use bio markers for request callback

Hi all, this is a proposal for a different implementation of request callbacks. The existing ->endio callback of a request is actually a destructor function, to be called to terminate a request and free all structures. However, on certain occasions (like request-based multipathing) it is

Re: [dm-devel] [PATCH 7/7] blk_end_request: change rq->end_io to cover request completion as a whole

Am Sat 01 Sep 2007 12:43:57 AM CEST schrieb Kiyoshi Ueda <[EMAIL PROTECTED]>: This patch moves the rq->end_io() calling point to the top of blk_end_request() from the last of end_that_request_last(). This means that whole request completion can be hooked by rq->end_io() because all device driv

Re: [PATCH ver3 1/5] scsi_error: code cleanup before refactoring of scsi_send_eh_cmnd()

On Sep 11, 2007, 11:11 +0300, "Julian Calaby" <[EMAIL PROTECTED]> wrote: > (added CCs - that's what you get for sending emails after 5.) > > On 9/11/07, Boaz Harrosh <[EMAIL PROTECTED]> wrote: >> static int scsi_send_eh_cmnd(struct scsi_cmnd *scmd, unsigned char *cmnd, >> -

Re: 2.6.23-rc4-mm1

On Mon, Sep 10 2007, Torsten Kaiser wrote: > On 9/10/07, FUJITA Tomonori <[EMAIL PROTECTED]> wrote: > > On Mon, 10 Sep 2007 12:20:38 -0700 > > Andrew Morton <[EMAIL PROTECTED]> wrote: > > > > > On Mon, 10 Sep 2007 20:59:49 +0200 "Torsten Kaiser" <[EMAIL PROTECTED]> > > > wrote: > > > > The system

Re: [PATCH ver3 1/5] scsi_error: code cleanup before refactoring of scsi_send_eh_cmnd()

(added CCs - that's what you get for sending emails after 5.) On 9/11/07, Boaz Harrosh <[EMAIL PROTECTED]> wrote: > > static int scsi_send_eh_cmnd(struct scsi_cmnd *scmd, unsigned char *cmnd, > -int cmnd_size, int timeout, int copy_sense) > +

[PATCH ver3 2/5] scsi_error: Refactoring scsi_error to facilitate in synchronous REQUEST_SENSE

- Drivers/transports that want to send a synchronous REQUEST_SENSE command as part of their .queuecommand sequence, have 2 new API's that facilitate in doing so and abstract them from scsi-ml internals. void scsi_eh_prep_cmnd(struct scsi_cmnd *scmd, struct scsi_eh_save *sesci, u

[PATCH ver3 1/5] scsi_error: code cleanup before refactoring of scsi_send_eh_cmnd()

- regrouped variables for easier reviewing of next patch - Support of cmnd==NULL in call to scsi_send_eh_cmnd() - In the copy_sense case set transfer size to the minimum size of sense_buffer and passed @sense_bytes. cmnd[4] is set accordingly. - REQUEST_SENSE is set into cmnd[0] so

Re: [PATCH ver2 2/5] scsi_error: Refactoring scsi_error to facilitate in synchronous REQUEST_SENSE

On Tue, Sep 11 2007 at 0:15 +0300, Matthew Dharm <[EMAIL PROTECTED]> wrote: > On Mon, Sep 10, 2007 at 10:35:25PM +0300, Boaz Harrosh wrote: >> diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c >> index 20a72aa..a02400c 100644 >> --- a/drivers/scsi/scsi_error.c >> +++ b/drivers/scsi