Re: [PATCH] dm-mpath-rdac: don't stomp on a request's transfer bit.

2007-07-20 Thread Chandra Seetharaman
ACK'd. This patch is needed for rdac to work properly. Signed-off-by: Chandra Seetharaman <[EMAIL PROTECTED]> On Tue, 2007-07-17 at 14:07 -0700, Andrew Vasquez wrote: > Signed-off-by: Andrew Vasquez <[EMAIL PROTECTED]> > --- > > On Thu, 12 Jul 2007, Mike Anderson wrote: > > > Copyin

What does scsi_level mean?

2007-07-20 Thread jidong xiao
I noticed that there is a char scsi_level in the struct scsi_device, what does scsi_level mean? struct scsi_device { ... char scsi_level; ... } Is it SCSI revision? If the answer is true, then I am quite curious, from the code I have read, SCSI_2 is something special, see following funct

[PATCH] bsg: fix bsg_unregister_queue

2007-07-20 Thread FUJITA Tomonori
scsi_sysfs_add_sdev ignores the bsg_register_queue failure, so bsg_unregister_queue must check whether the queue has a bsg device. Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> --- block/bsg.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/block/bsg.c b/block/bsg.

Re: [PATCH 1/4] gdth: Split out EISA and ISA register code

2007-07-20 Thread Jeff Garzik
Notes: 1) If this is stomping on Christoph's work or anyone else's, feel free to discard. This is some "I was bored" PCI hotplug prep work, not a high priority at all. 2) This is to be applied on top of the previous gdth patch "remove redundant PCI stuff". 3) These changes can be found vi

[PATCH 2/4] gdth: Split out PCI register code

2007-07-20 Thread Jeff Garzik
No code changes, just indentation and blank line addition. commit 098f6915936406179b27a9f448d65953383ad628 Author: Jeff Garzik <[EMAIL PROTECTED]> Date: Fri Jul 20 20:23:20 2007 -0400 [SCSI] gdth: Split out PCI register into separate function Signed-off-by: Jeff Garzik <[EMAIL PRO

[PATCH 4/4] gdth: Isolate driver-global variables using helpers

2007-07-20 Thread Jeff Garzik
commit fa82107fcc8bb738d3be1a0786302d54d483900f Author: Jeff Garzik <[EMAIL PROTECTED]> Date: Fri Jul 20 22:13:36 2007 -0400 [SCSI] gdth: Isolate driver-global variables using helpers Sanitizes access to some driver-global variables, in preparation for making them dynamic rathe

[PATCH 3/4] gdth: Remove 2.4.x support, in-kernel changelog

2007-07-20 Thread Jeff Garzik
commit 095089554011aef3834fd7b7e35ce0c84349d9a9 Author: Jeff Garzik <[EMAIL PROTECTED]> Date: Fri Jul 20 21:17:45 2007 -0400 [SCSI] gdth: Remove 2.4.x support, in-kernel changelog * Remove in-source changelog. It's archived permanently in git and various kernel archives, and

[PATCH 1/4] gdth: Split out EISA and ISA register code

2007-07-20 Thread Jeff Garzik
No code changes, only indentation and blank line additions, plus code to call the new split-out functions. commit 61b41cec514e93a06e56869b78c2f86b01c0c594 Author: Jeff Garzik <[EMAIL PROTECTED]> Date: Fri Jul 20 20:05:32 2007 -0400 [SCSI] gdth: Split out EISA and ISA register into separate

Re: [PATCH] bsg: make class backlinks

2007-07-20 Thread FUJITA Tomonori
From: James Bottomley <[EMAIL PROTECTED]> Subject: [PATCH] bsg: make class backlinks Date: Fri, 20 Jul 2007 18:22:17 -0500 > Currently, bsg doesn't make class backlinks (a process whereby you'd get > a link to bsg in the device directory in the same way you get one for > sg). This is because the

Re: [PATCH] bsg: fix bsg_register_queue error path

2007-07-20 Thread FUJITA Tomonori
From: James Bottomley <[EMAIL PROTECTED]> Subject: [PATCH] bsg: fix bsg_register_queue error path Date: Fri, 20 Jul 2007 16:50:10 -0500 > unfortunately, if IS_ERR(class_dev) is true, that means class_dev isn't > null and the check in the error leg is pointless ... it's also asking > for trouble to

Re: ESP SCSI and QLGC,ISP SCSI drivers not finding attached devices

2007-07-20 Thread Mark Fortescue
Hi David, Thanks for the info. Having got the ESP driver going by increasing the Bus Timeout, I have a route forward to booting linux from disk. I will look into the msleep etc. functions and see if I can identify any issues with them. As you say, if these are not working correctly ... I h

[PATCH] (was Re: ESP SCSI and QLGC,ISP SCSI drivers not finding attached devices)

2007-07-20 Thread David Miller
James, can you queue this up to Linus? Thanks a lot! [SCSI] ESP: Increase ESP_BUS_TIMEOUT to 275. This matches the original driver's value and seems to be necessary for some disks on sun4c systems. Reported by Mark Fortescue <[EMAIL PROTECTED]> Signed-off-by: David S. Miller <[EMAIL PROTECTED

[PATCH] bsg: make class backlinks

2007-07-20 Thread James Bottomley
Currently, bsg doesn't make class backlinks (a process whereby you'd get a link to bsg in the device directory in the same way you get one for sg). This is because the bsg device is uninitialised, so the class device has nothing it can attach to. The fix is to make the bsg device point to the cde

Re: ESP SCSI and QLGC,ISP SCSI drivers not finding attached devices

2007-07-20 Thread David Miller
From: Mark Fortescue <[EMAIL PROTECTED]> Date: Fri, 20 Jul 2007 21:27:42 +0100 (BST) > I have found that on my sun4c, I need to increase the ESP_BUS_TIMEOUT from > 250ms to 275ms when I build the ESP driver into the kernel or the ESP > does not find the disk. > > If I build the driver as a modu

Re: ESP SCSI and QLGC,ISP SCSI drivers not finding attached devices

2007-07-20 Thread David Miller
I think these reports all point to a problem with the sparc32 kernel far outside of the drivers in question. We have no reports like this on sparc64. My running theory is that things like msleep() are returning immediately on sparc32, or at least too fast, instead of delaying the minimum necessa

[PATCH 1/1] 3ware 9000 add support for 9690SA

2007-07-20 Thread adam radford
The attached patch for scsi-misc-2.6 updates the 3ware 9000 driver: - Fix dma mask setting to fallback to 32-bit if 64-bit fails. - Add support for 9690SA controllers. Signed-off-by: Adam Radford <[EMAIL PROTECTED]> James, Please apply Thanks! -Adam Note: The patch is attached as an attachme

[PATCH] bsg: fix bsg_register_queue error path

2007-07-20 Thread James Bottomley
unfortunately, if IS_ERR(class_dev) is true, that means class_dev isn't null and the check in the error leg is pointless ... it's also asking for trouble to request unregistration of a device we haven't actually created (although it works currently). Fix by using explicit gotos and unregisters. J

Re: [PATCH] buggered kmalloc()

2007-07-20 Thread Arjan van de Ven
On Fri, 2007-07-20 at 16:05 -0400, Dave Jones wrote: > On Fri, Jul 20, 2007 at 04:03:40PM +0100, Al Viro wrote: > > Signed-off-by: Al Viro <[EMAIL PROTECTED]> > > --- > > diff --git a/drivers/scsi/iscsi_tcp.c b/drivers/scsi/iscsi_tcp.c > > index aebcd5f..7829ab1 100644 > > --- a/drivers/scsi/i

Re: [PATCH] buggered kmalloc()

2007-07-20 Thread Al Viro
On Fri, Jul 20, 2007 at 04:05:30PM -0400, Dave Jones wrote: > On Fri, Jul 20, 2007 at 04:03:40PM +0100, Al Viro wrote: > > Signed-off-by: Al Viro <[EMAIL PROTECTED]> > > --- > > diff --git a/drivers/scsi/iscsi_tcp.c b/drivers/scsi/iscsi_tcp.c > > index aebcd5f..7829ab1 100644 > > --- a/drivers

Re: ESP SCSI and QLGC,ISP SCSI drivers not finding attached devices

2007-07-20 Thread Mark Fortescue
Hi David, I have found that on my sun4c, I need to increase the ESP_BUS_TIMEOUT from 250ms to 275ms when I build the ESP driver into the kernel or the ESP does not find the disk. If I build the driver as a module, this extra 25ms is not required. Any idears? Given that the V1 EPS driver us

Re: [PATCH] buggered kmalloc()

2007-07-20 Thread Dave Jones
On Fri, Jul 20, 2007 at 04:03:40PM +0100, Al Viro wrote: > Signed-off-by: Al Viro <[EMAIL PROTECTED]> > --- > diff --git a/drivers/scsi/iscsi_tcp.c b/drivers/scsi/iscsi_tcp.c > index aebcd5f..7829ab1 100644 > --- a/drivers/scsi/iscsi_tcp.c > +++ b/drivers/scsi/iscsi_tcp.c > @@ -1885,7 +1885,

[PATCH] update mpt Kconfig help - with [TAB]

2007-07-20 Thread Gwendal Grignou
Update help in Kconfig for mptfc driver to indicate the driver supports Brocade FC 4G HBA. signed-off-by: Gwendal Grignou <[EMAIL PROTECTED]> --- drivers/message/fusion/Kconfig |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/message/fusion/Kconfig b/drivers/messag

[PATCH] fix remaining scr_read/write users and the documentation

2007-07-20 Thread James Bottomley
This fixes up the usage in libsas (which are easy to miss, since they're only in the scsi-misc tree) ... and also corrects the documentation on the point of what these two function pointers actually return. James diff --git a/Documentation/DocBook/libata.tmpl b/Documentation/DocBook/libata.tmpl

Re: [patch 3/3] scsi: wd33c93 needs

2007-07-20 Thread Matthew Wilcox
On Fri, Jul 20, 2007 at 09:43:47PM +0400, Sergei Shtylyov wrote: > Hello Christoph: > > >>>+#include > > >>These days that should probably be . > > >Not at all, linux/irq.h is something entirely different. > >Actually, Not for enable/disable_irq. For request_irq, yes. This is something

Re: [patch 3/3] scsi: wd33c93 needs

2007-07-20 Thread Ralf Baechle
On Fri, Jul 20, 2007 at 06:33:59PM +0100, Christoph Hellwig wrote: > On Fri, Jul 20, 2007 at 06:31:32PM +0100, Ralf Baechle wrote: > > > +#include > > > > These days that should probably be . > > Not at all, linux/irq.h is something entirely different. Well, fine. But checkpatch.pl will bitch

Re: [patch 3/3] scsi: wd33c93 needs

2007-07-20 Thread Sergei Shtylyov
Hello Christoph: +#include These days that should probably be . Not at all, linux/irq.h is something entirely different. Actually, WBR, Sergei - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordomo info a

Re: [patch 3/3] scsi: wd33c93 needs

2007-07-20 Thread Matthew Wilcox
On Fri, Jul 20, 2007 at 06:31:32PM +0100, Ralf Baechle wrote: > On Fri, Jul 20, 2007 at 06:40:46PM +0200, Geert Uytterhoeven wrote: > > +#include > > These days that should probably be . Go and read the comments at the top of linux/irq.h. And then report to Russell for your whipping. -- "Bill,

Re: [patch 3/3] scsi: wd33c93 needs

2007-07-20 Thread Christoph Hellwig
On Fri, Jul 20, 2007 at 06:31:32PM +0100, Ralf Baechle wrote: > > +#include > > These days that should probably be . Not at all, linux/irq.h is something entirely different. - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] Mor

Re: [patch 3/3] scsi: wd33c93 needs

2007-07-20 Thread Ralf Baechle
On Fri, Jul 20, 2007 at 06:40:46PM +0200, Geert Uytterhoeven wrote: > --- a/drivers/scsi/wd33c93.c > +++ b/drivers/scsi/wd33c93.c > @@ -89,6 +89,8 @@ > #include > #include > > +#include These days that should probably be . Ralf - To unsubscribe from this list: send the line "unsubscribe

Re: ESP SCSI and QLGC,ISP SCSI drivers not finding attached devices

2007-07-20 Thread Mark Fortescue
Ok. I have found a difference in the timeouts. V1 driver it is 275ms, V2 driver it is 250ms. It looks like that extra 25ms is needed on the sun4c :). I will do a quick test with the existing setup as a modular ESP and then re-build with a 275ms timeout and see if that fixes the problem. R

Re: [patch 3/3] scsi: wd33c93 needs

2007-07-20 Thread Adrian Bunk
On Fri, Jul 20, 2007 at 11:48:57AM -0500, James Bottomley wrote: > On Fri, 2007-07-20 at 18:40 +0200, Geert Uytterhoeven wrote: > > plain text document attachment (m68k-wd33c93-needs-asm-irq.diff) > > wd33c93 SCSI needs on m68k > > > > drivers/scsi/wd33c93.c: In function 'wd33c93_host_reset': > >

Re: [patch 3/3] scsi: wd33c93 needs

2007-07-20 Thread Geert Uytterhoeven
On Fri, 20 Jul 2007, James Bottomley wrote: > On Fri, 2007-07-20 at 18:40 +0200, Geert Uytterhoeven wrote: > > plain text document attachment (m68k-wd33c93-needs-asm-irq.diff) > > wd33c93 SCSI needs on m68k > > > > drivers/scsi/wd33c93.c: In function 'wd33c93_host_reset': > > drivers/scsi/wd33c93

Re: ESP SCSI and QLGC,ISP SCSI drivers not finding attached devices

2007-07-20 Thread James Bottomley
On Fri, 2007-07-20 at 16:22 +0100, Mark Fortescue wrote: > Thansk for the info. I will try some experiments and see if I can work > out where the scsi commands/responses are getting lost. Actually, for ESP it looks like you can alter the timeout ... it's the parameter ESP_BUS_TIMEOUT in drivers/s

Re: [PATCH] scsi_transport_sas: add destructor for bsg

2007-07-20 Thread FUJITA Tomonori
From: James Bottomley <[EMAIL PROTECTED]> Subject: [PATCH] scsi_transport_sas: add destructor for bsg Date: Fri, 20 Jul 2007 11:10:05 -0500 > There's currently no destructor for the bsg components. If you insert > and remove the module, you see the bsg devices building up and up. This > patch ad

Re: [patch 3/3] scsi: wd33c93 needs

2007-07-20 Thread James Bottomley
On Fri, 2007-07-20 at 18:40 +0200, Geert Uytterhoeven wrote: > plain text document attachment (m68k-wd33c93-needs-asm-irq.diff) > wd33c93 SCSI needs on m68k > > drivers/scsi/wd33c93.c: In function 'wd33c93_host_reset': > drivers/scsi/wd33c93.c:1582: error: implicit declaration of function > 'dis

[patch 3/3] scsi: wd33c93 needs

2007-07-20 Thread Geert Uytterhoeven
wd33c93 SCSI needs on m68k drivers/scsi/wd33c93.c: In function 'wd33c93_host_reset': drivers/scsi/wd33c93.c:1582: error: implicit declaration of function 'disable_irq' drivers/scsi/wd33c93.c:1603: error: implicit declaration of function 'enable_irq' The driver still compiles on MIPS (CONFIG_SG

[PATCH] scsi_transport_sas: add destructor for bsg

2007-07-20 Thread James Bottomley
There's currently no destructor for the bsg components. If you insert and remove the module, you see the bsg devices building up and up. This patch adds the destructor in the correct place in the transport class so that the bsg and request queue are removed just before the device destruction. Ja

Re: ESP SCSI and QLGC,ISP SCSI drivers not finding attached devices

2007-07-20 Thread Mark Fortescue
Hi James, Thansk for the info. I will try some experiments and see if I can work out where the scsi commands/responses are getting lost. I do not beleave the issue with the ESP is a hardware problem. The PROM and SunOS-4.1.1 have no problem finding/accessing the disk on the ESP and I did not

[PATCH] buggered kmalloc()

2007-07-20 Thread Al Viro
Signed-off-by: Al Viro <[EMAIL PROTECTED]> --- diff --git a/drivers/scsi/iscsi_tcp.c b/drivers/scsi/iscsi_tcp.c index aebcd5f..7829ab1 100644 --- a/drivers/scsi/iscsi_tcp.c +++ b/drivers/scsi/iscsi_tcp.c @@ -1885,7 +1885,7 @@ static int iscsi_tcp_get_addr(struct iscsi_conn *conn, struct socket *so

Re: ESP SCSI and QLGC,ISP SCSI drivers not finding attached devices

2007-07-20 Thread James Bottomley
On Fri, 2007-07-20 at 14:26 +0100, Mark Fortescue wrote: > I have been having intermittant issues with the QLGC,isp driver > (qlogicpti.c) not finding any attached devices on my sun4c. Having now > moved on to Linux-2.6.22 this problem is now also affecting the ESP SCSI > driver and is nolonger

ESP SCSI and QLGC,ISP SCSI drivers not finding attached devices

2007-07-20 Thread Mark Fortescue
Hi All, I have been having intermittant issues with the QLGC,isp driver (qlogicpti.c) not finding any attached devices on my sun4c. Having now moved on to Linux-2.6.22 this problem is now also affecting the ESP SCSI driver and is nolonger intermittant. My test setup uses an NFS root so it is

unexpected scsi timeout

2007-07-20 Thread Vasily Averin
Tejun, Jeff I've noticed that some scsi commands for DVD-drive attached to pata_via successfully finishes without any delays but reports about TIMEOUT condition. It happens because of ATA_ERR bit is set in status register. As result for each command Error Handler thread awakened, requests sense b