[PATCH 3/6] block: export blk_verify_command for SG v4

2006-12-19 Thread FUJITA Tomonori
blk_fill_sghdr_rq doesn't work for SG v4 so verify_command needed to be exported. Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> --- block/scsi_ioctl.c |7 --- include/linux/blkdev.h |1 + 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/block/scsi_ioctl.c b/bloc

[PATCH 5/6] bsg: replace SG v3 with SG v4

2006-12-19 Thread FUJITA Tomonori
This patch replaces SG v3 in bsg with SG v4 (except for SG_IO). Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> --- block/bsg.c | 198 --- 1 files changed, 121 insertions(+), 77 deletions(-) diff --git a/block/bsg.c b/block/bsg.c index

[PATCH 6/6] bsg: add SG_IO to SG v4

2006-12-19 Thread FUJITA Tomonori
This adds SG_IO support to SG v4. Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> --- block/bsg.c | 23 +-- 1 files changed, 21 insertions(+), 2 deletions(-) diff --git a/block/bsg.c b/block/bsg.c index 6d139d2..9dc5d36 100644 --- a/block/bsg.c +++ b/block/bsg.c @@ -945,

[PATCH 4/6] bsg: add sg_io_v4 structure

2006-12-19 Thread FUJITA Tomonori
This patch adds sg_io_v4 structure that Doug proposed last month. There's one major change from the RFC. I dropped iovec, which needs compat stuff. The bsg code simply calls blk_rq_map_user against dout_xferp/din_xferp. So if possible, the page frames are directly mapped. If not possible, the bloc

[PATCH 2/6] bsg: minor cleanups

2006-12-19 Thread FUJITA Tomonori
This just kills linux/config.h and dprintk warnings. Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> --- block/bsg.c | 13 ++--- 1 files changed, 6 insertions(+), 7 deletions(-) diff --git a/block/bsg.c b/block/bsg.c index 724b693..53a09a5 100644 --- a/block/bsg.c +++ b/block/bsg.c

[PATCH 1/6] block: changes for blk_rq_unmap_user new API

2006-12-19 Thread FUJITA Tomonori
This converts block/scsi_ioctl.c use blk_rq_unmap_user new API. blk_unmap_sghdr_rq is too simple and it might be better to remove it. Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> --- block/scsi_ioctl.c | 13 + 1 files changed, 1 insertions(+), 12 deletions(-) diff --git a/blo

[PATCH 0/6] SG v4 support

2006-12-19 Thread FUJITA Tomonori
The following patches add SG v4 support to bsg. They are over Jens' bsg branch (HEAD of the tree is fc68dbc4630ffef6dce5198fd90bdec37a9bbf44). I just replaced bsg's SG v3 support with SG v4 and haven't added anything new yet. So it can only handle SCSI commands. Changes from the previous submiss

Re: megaraid_sas waiting for command and then offline

2006-12-19 Thread Brett G. Durrett
Just replied to another poster but wanted to respond to this thread as well... Joe, Huge thanks for the pointer to the new firmware... I had a page bookmarked for the 2950 firmware but the bookmark went to an old page. We are running 16G machines, dual core, dual CPU, RAID 5 on Perc5i. Th

[patch 25/26] drivers/scsi/wd33c93.c: cleanups

2006-12-19 Thread akpm
From: Adrian Bunk <[EMAIL PROTECTED]> - #include for getting the prototypes of {dis,en}able_irq() - make the needlessly global wd33c93_setup() static Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/wd33c93.c |4 +++- 1 files

[patch 18/26] drivers/scsi/aic7xxx/: make functions static

2006-12-19 Thread akpm
From: Adrian Bunk <[EMAIL PROTECTED]> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/aic7xxx/aic79xx_osm.c |6 -- drivers/scsi/aic7xxx/aic79xx_osm.h |2 -- drivers/scsi/aic7xxx/aic7xxx.h |5 - drivers/sc

[patch 04/26] drivers/scsi/advansys.c: cleanups

2006-12-19 Thread akpm
From: Adrian Bunk <[EMAIL PROTECTED]> - remove the unneeded advansys.h - remove the unused advansys_setup() - make needlessly global functions static Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/advansys.c | 101 +++---

[patch 12/26] drivers/scsi/dpt_i2o.c: remove dead code

2006-12-19 Thread akpm
From: Adrian Bunk <[EMAIL PROTECTED]> The Coverity checker spotted this dead code introduced by commit a07f353701acae77e023f6270e8af353b37af7c4. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/dpt_i2o.c |2 -- 1 files changed,

[patch 02/26] drivers/scsi/aic7xxx/aic79xx_core.c: make ahd_match_scb() static

2006-12-19 Thread akpm
From: Adrian Bunk <[EMAIL PROTECTED]> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Cc: James Bottomley <[EMAIL PROTECTED]> Acked-by: Hannes Reinecke <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/aic7xxx/aic79xx.h |3 --- drivers/scsi/aic7xxx/aic

[patch 01/26] drivers/scsi/: small cleanups

2006-12-19 Thread akpm
From: Adrian Bunk <[EMAIL PROTECTED]> This patch contains the following cleanups: - make needlessly global functions static - every file should #include the headers containing the prototypes for it's global functions Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Cc: James Bottomley <[EMAIL PRO

[patch 24/26] sym53c8xx_2 claims cpqarray device

2006-12-19 Thread akpm
From: Chip Coldwell <[EMAIL PROTECTED]> Apropos this thread http://marc.theaimsgroup.com/?l=linux-scsi&m=115591706804045&w=2 which led to this patch http://www.kernel.org/git/?p=linux/kernel/git/jejb/scsi-rc-fixes-2.6.git;a=commit;h=b2b3c121076961333977f485f0d54c22121df920 do we not also need

[patch 20/26] make qla2x00_reg_remote_port() static

2006-12-19 Thread akpm
From: Adrian Bunk <[EMAIL PROTECTED]> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Acked-by: Andrew Vasquez <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/qla2xxx/qla_gbl.h |1 drivers/scsi/qla2xxx/qla_init.c | 68 +++--- 2

[patch 05/26] megaraid: fix warnings when CONFIG_PROC_FS=n

2006-12-19 Thread akpm
From: walter harms <[EMAIL PROTECTED]> Signed-off-by: walter harms <[EMAIL PROTECTED]> Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Cc: Adrian Bunk <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/megaraid.c | 17 +++-- drivers/scsi/megara

[patch 26/26] scsi: cover up bugs^W^W^WFix up compiler warnings in megaraid driver

2006-12-19 Thread akpm
From: Martin Bligh <[EMAIL PROTECTED]> Fix up compiler warnings in megaraid driver [EMAIL PROTECTED]: build fix] Signed-off-by: Martin J. Bligh <[EMAIL PROTECTED]> Cc: James Bottomley <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/megaraid.c | 22 +++

[patch 21/26] iscsi: fix crypto_alloc_hash() error check

2006-12-19 Thread akpm
From: Akinobu Mita <[EMAIL PROTECTED]> The return value of crypto_alloc_hash() should be checked by IS_ERR(). Cc: Dmitry Yusupov <[EMAIL PROTECTED]> Cc: Alex Aizman <[EMAIL PROTECTED]> Signed-off-by: Akinobu Mita <[EMAIL PROTECTED]> Cc: James Bottomley <[EMAIL PROTECTED]> Acked-by: Mike Christie

[patch 15/26] drivers/scsi/megaraid.c: Replacing yield() with a better alternative

2006-12-19 Thread akpm
From: Amol Lad <[EMAIL PROTECTED]> For this driver cond_resched() seems to be a better alternative Signed-off-by: Amol Lad <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/megaraid.c |3 ++- 1 files changed, 2 insertions(+), 1 deletion(-) diff -puN driv

[patch 23/26] scsi: 53c7xx brackets fix

2006-12-19 Thread akpm
From: Mariusz Kozlowski <[EMAIL PROTECTED]> Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/53c7xx.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff -puN drivers/scsi/53c7xx.c~scsi-53c7xx-brackets-fix driv

[patch 13/26] MPT fusion: handle PCI layer error on resume

2006-12-19 Thread akpm
From: Jeff Garzik <[EMAIL PROTECTED]> In the unlikely event of pci_enable_device() failure during resume, we do the minimalist solution and simply exit, rather than continuing to enable the hardware. Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> Cc: "Moore, Eric Dean" <[EMAIL PROTECTED]> Cc: Jam

[patch 22/26] scsi: sic7xxx stray bracket fix

2006-12-19 Thread akpm
From: Mariusz Kozlowski <[EMAIL PROTECTED]> Fix broken-but-unused macro. Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/aic7xxx/aic79xx_pci.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff -puN drivers/scsi

[patch 14/26] drivers/scsi/NCR5380.c: Replacing yield() with a better alternative

2006-12-19 Thread akpm
From: Amol Lad <[EMAIL PROTECTED]> Replaced yield() with cond_resched() Signed-off-by: Amol Lad <[EMAIL PROTECTED]> Acked-by: Alan Cox <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/NCR5380.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff

[patch 17/26] drivers/scsi/mca_53c9x.c : save_flags()/cli() removal

2006-12-19 Thread akpm
From: Amol Lad <[EMAIL PROTECTED]> Replaced save_flags()/cli() with spin_lock alternatives [EMAIL PROTECTED]: no longer BROKEN_ON_SMP] Signed-off-by: Amol Lad <[EMAIL PROTECTED]> Cc: James Bottomley <[EMAIL PROTECTED]> Cc: Alan Cox <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTE

[patch 19/26] SCSI: advansys, wrap PCI table inside ifdef CONFIG_PCI

2006-12-19 Thread akpm
From: Randy Dunlap <[EMAIL PROTECTED]> The Advansys ISA/EISA/PCI driver has a compile error when CONFIG_PCI=n, so wrap the pci_device_id table inside ifdef CONFIG_PCI. drivers/scsi/advansys.c: At top level: drivers/scsi/advansys.c:18219: error: array type has incomplete element type drivers/scsi/

[patch 16/26] scsi: whitespace cleanup in the dpt driver

2006-12-19 Thread akpm
From: Henne <[EMAIL PROTECTED]> Remove some trailing whitespaces and some replace whitespaces with tabs. Signed-off-by: Henrik Kretzschmar <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/dpt/dpti_i2o.h | 48 drivers/scsi

[patch 11/26] pci_module_init() convertion in tmscsim.c

2006-12-19 Thread akpm
From: Henrik Kretzschmar <[EMAIL PROTECTED]> pci_module_init() convertion in tmscsim.c Signed-off-by: Henrik Kretzschmar <[EMAIL PROTECTED]> Acked-by: Alan Cox <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/tmscsim.c |6 -- 1 files changed, 4 inser

[patch 08/26] remove extra newline from info message

2006-12-19 Thread akpm
From: Rolf Eike Beer <[EMAIL PROTECTED]> remove extra newline from info message This extra newline character introduces a completely empty line in dmesg as the calling function itself adds a newline. Signed-off-by: Rolf Eike Beer <[EMAIL PROTECTED]> Cc: James Bottomley <[EMAIL PROTECTED]> Signed

[patch 09/26] Fix scsi/scsi_transport.h compile error

2006-12-19 Thread akpm
From: Rolf Eike Beer <[EMAIL PROTECTED]> scsi_transport.h defines the inline function scsi_transport_device_data() that dereferences a pointer of "struct scsi_device *". Since the struct is not known by the header this might break compilation. Include scsi/scsi_device.h to not rely on users doin

[patch 03/26] scsi: clean up warnings in Advansys driver

2006-12-19 Thread akpm
From: Ken Witherow <[EMAIL PROTECTED]> Fix typecast warnings and switch from check_region to request_region (akpm: Ken and Jeffrey Phillips Freeman <[EMAIL PROTECTED]> are possible advansys testers) Signed-off-by: Ken Witherow <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>

[patch 07/26] scsi: remove unnecessary check in drivers/scsi/sg.c

2006-12-19 Thread akpm
From: Eric Sesterhenn <[EMAIL PROTECTED]> coverity spotted this (cid #758). All callers dereference sfp, so we dont need this check. In addition to this, we dereference it earlier in the function. Signed-off-by: Eric Sesterhenn <[EMAIL PROTECTED]> Cc: Douglas Gilbert <[EMAIL PROTECTED]> Cc: Jam

[patch 10/26] pci_module_init() convertion in the legacy megaraid driver

2006-12-19 Thread akpm
From: Henrik Kretzschmar <[EMAIL PROTECTED]> pci_module_init() convertion in the legacy megaraid driver. Signed-off-by: Henrik Kretzschmar <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/megaraid.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-)

[patch 06/26] drivers/scsi/pcmcia/nsp_cs.h: removal of old scsi code

2006-12-19 Thread akpm
From: Michal Piotrowski <[EMAIL PROTECTED]> Signed-off-by: Michal Piotrowski <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/pcmcia/nsp_cs.h | 66 - 1 files changed, 66 deletions(-) diff -puN drivers/scsi/pcmcia/nsp_cs.h~d

Re: [PATCH] scsi_execute_async() should add to the tail of the queue

2006-12-19 Thread Jon Escombe
Jens Axboe wrote: > On Tue, Dec 19 2006, Arjan van de Ven wrote: >> On Tue, 2006-12-19 at 10:35 +0200, Dan Aloni wrote: >>> Hello, >>> >>> scsi_execute_async() has replaced scsi_do_req() a few versions ago, >>> but it also incurred a change of behavior. I noticed that over-queuing >>> a SCSI devic

Re: [PATCH] scsi_execute_async() should add to the tail of the queue

2006-12-19 Thread Jens Axboe
On Tue, Dec 19 2006, Jon Escombe wrote: > Jens Axboe wrote: > > On Tue, Dec 19 2006, Arjan van de Ven wrote: > >> On Tue, 2006-12-19 at 10:35 +0200, Dan Aloni wrote: > >>> Hello, > >>> > >>> scsi_execute_async() has replaced scsi_do_req() a few versions ago, > >>> but it also incurred a change of b

Re: [PATCH 0/3] SG v4 support

2006-12-19 Thread FUJITA Tomonori
From: Jens Axboe <[EMAIL PROTECTED]> Subject: Re: [PATCH 0/3] SG v4 support Date: Fri, 15 Dec 2006 19:57:05 +0100 > On Sat, Dec 16 2006, FUJITA Tomonori wrote: > > The following patches add SG v4 support to bsg. They are over Jens' > > bsg branch. > > > > I just replaced bsg's SG v3 support with

Re: [PATCH 0/3] SG v4 support

2006-12-19 Thread FUJITA Tomonori
From: Jens Axboe <[EMAIL PROTECTED]> Subject: Re: [PATCH 0/3] SG v4 support Date: Tue, 19 Dec 2006 15:09:24 +0100 > On Tue, Dec 19 2006, Jens Axboe wrote: > > > Thanks. The patchset is on the top of the two minor patches: > > > > > > http://marc.theaimsgroup.com/?l=linux-scsi&m=116621265732083&w=

Re: [PATCH 0/3] SG v4 support

2006-12-19 Thread Jens Axboe
On Tue, Dec 19 2006, Jens Axboe wrote: > > Thanks. The patchset is on the top of the two minor patches: > > > > http://marc.theaimsgroup.com/?l=linux-scsi&m=116621265732083&w=2 > > http://marc.theaimsgroup.com/?l=linux-scsi&m=116621265731963&w=2 > > > > The latter needs small modifications if you

Re: [PATCH 0/3] SG v4 support

2006-12-19 Thread Jens Axboe
On Tue, Dec 19 2006, FUJITA Tomonori wrote: > From: Jens Axboe <[EMAIL PROTECTED]> > Subject: Re: [PATCH 0/3] SG v4 support > Date: Fri, 15 Dec 2006 19:57:05 +0100 > > > On Sat, Dec 16 2006, FUJITA Tomonori wrote: > > > The following patches add SG v4 support to bsg. They are over Jens' > > > bsg

Re: [PATCH] scsi_execute_async() should add to the tail of the queue

2006-12-19 Thread Jens Axboe
On Tue, Dec 19 2006, Arjan van de Ven wrote: > On Tue, 2006-12-19 at 10:35 +0200, Dan Aloni wrote: > > Hello, > > > > scsi_execute_async() has replaced scsi_do_req() a few versions ago, > > but it also incurred a change of behavior. I noticed that over-queuing > > a SCSI device using that functi

Re: [PATCH] scsi_execute_async() should add to the tail of the queue

2006-12-19 Thread Arjan van de Ven
On Tue, 2006-12-19 at 10:35 +0200, Dan Aloni wrote: > Hello, > > scsi_execute_async() has replaced scsi_do_req() a few versions ago, > but it also incurred a change of behavior. I noticed that over-queuing > a SCSI device using that function causes I/Os to be starved from > low-level queuing fo

Re: [PATCH] scsi_execute_async() should add to the tail of the queue

2006-12-19 Thread Dan Aloni
Arjan van de Ven wrote: On Tue, 2006-12-19 at 10:35 +0200, Dan Aloni wrote: Hello, scsi_execute_async() has replaced scsi_do_req() a few versions ago, but it also incurred a change of behavior. I noticed that over-queuing a SCSI device using that function causes I/Os to be starved from lo

[PATCH] scsi_execute_async() should add to the tail of the queue

2006-12-19 Thread Dan Aloni
Hello, scsi_execute_async() has replaced scsi_do_req() a few versions ago, but it also incurred a change of behavior. I noticed that over-queuing a SCSI device using that function causes I/Os to be starved from low-level queuing for no justified reason. I think it makes much more sense to per

[PATCH] scsi: raise error when sg slab/mempool cannot be initialized

2006-12-19 Thread Akinobu Mita
This patch raises error when sg slab or mempool cannot be initialized. It is better than crash after initialization. Cc: "James E.J. Bottomley" <[EMAIL PROTECTED]> Signed-off-by: Akinobu Mita <[EMAIL PROTECTED]> --- drivers/scsi/scsi_lib.c | 14 ++ 1 file changed, 14 insertions(+)

[PATCH] scsi_execute_async() should add to the tail of the queue

2006-12-19 Thread Dan Aloni
Hello, scsi_execute_async() has replaced scsi_do_req() a few versions ago, but it also incurred a change of behavior. I noticed that over-queuing a SCSI device using that function causes I/Os to be starved from low-level queuing for no justified reason. I think it makes much more sense to per