Hi Sakari,
On Monday 29 Aug 2016 12:13:40 Sakari Ailus wrote:
> On Wed, Aug 17, 2016 at 03:20:27PM +0300, Laurent Pinchart wrote:
> > The metadata buffer type is used to transfer metadata between userspace
> > and kernelspace through a V4L2 buffers queue. It comes with a new
>
On Friday 02 Sep 2016 00:22:42 Laurent Pinchart wrote:
> On Monday 29 Aug 2016 12:13:40 Sakari Ailus wrote:
> > On Wed, Aug 17, 2016 at 03:20:27PM +0300, Laurent Pinchart wrote:
> >> The metadata buffer type is used to transfer metadata between userspace
> >> and kernels
t; #define VI6_IP_VERSION_MODEL_VSPD_GEN2 (0x0b << 8)
> #define VI6_IP_VERSION_MODEL_VSPS_M2 (0x0c << 8)
> +#define VI6_IP_VERSION_MODEL_VSPS_V2H(0x12 << 8)
> +#define VI6_IP_VERSION_MODEL_VSPD_V2H (0x13 << 8)
> #define VI6_IP_VERSION_MODEL_VSPI_GEN3 (0x14 <&l
The metadata buffer type is used to transfer metadata between userspace
and kernelspace through a V4L2 buffers queue. It comes with a new
metadata capture capability and format description.
Signed-off-by: Laurent Pinchart
Tested-by: Guennadi Liakhovetski
---
Changes since v2:
- Dropped the
done while not holding the graph mutex.
>
> Signed-off-by: Sakari Ailus
> Acked-by: Hans Verkuil
Acked-by: Laurent Pinchart
> ---
> drivers/media/media-device.c | 190 +--
> 1 file changed, 90 insertions(+), 100 deletions(-)
>
> di
The metadata buffer type is used to transfer metadata between userspace
and kernelspace through a V4L2 buffers queue. It comes with a new
metadata capture capability and format description.
Signed-off-by: Laurent Pinchart
Tested-by: Guennadi Liakhovetski
Acked-by: Sakari Ailus
---
Changes
Hi Geert,
On Tuesday 23 Aug 2016 15:11:59 Geert Uytterhoeven wrote:
> On Wed, Aug 17, 2016 at 2:55 PM, Laurent Pinchart wrote:
> > On Tuesday 09 Aug 2016 17:36:41 Geert Uytterhoeven wrote:
> >> When resuming from suspend-to-RAM on r8a7795/salvator-x:
> &g
Hi Hans,
On Monday 05 Sep 2016 09:40:19 Hans Verkuil wrote:
> On 09/02/2016 02:07 PM, Laurent Pinchart wrote:
> > The metadata buffer type is used to transfer metadata between userspace
> > and kernelspace through a V4L2 buffers queue. It comes with a new
> > metadata c
Hi Geert,
On Monday 05 Sep 2016 10:20:52 Geert Uytterhoeven wrote:
> On Mon, Sep 5, 2016 at 10:17 AM, Laurent Pinchart wrote:
> >> BTW, it seems I missed a few more s2ram resume errors:
> >> dpm_run_callback(): pm_genpd_resume_noirq+0x0/0x90 returns -13
> >>
The Renesas multimedia drivers use ret to store return values, fix the
only exception in the rcar-fcp driver to keep the coding style
consistent.
Signed-off-by: Laurent Pinchart
---
drivers/media/platform/rcar-fcp.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a
ct, this function is only used in the file in which it is
> declared and don't need a declaration, but can be made static.
> so this patch marks this function with 'static'.
>
> Signed-off-by: Baoyou Xie
Acked-by: Laurent Pinchart
> ---
> drivers/staging/media/
for you to fetch changes up to a9a30bf86ed6af1fc2efefc98f0760f44fd859d9:
v4l: vsp1: Add R8A7792 VSP1V support (2016-09-05 11:38:22 +0300)
Laurent Pinchart (8):
v4l: Add metadata buffer type and format
v4l: Define a pixel
, n=0) [31:0]
> +* - 36
> + - :cspan:`4` Histogram bucket (m=0, n=1) [31:0]
> +* -
> + - :cspan:`4` ...
> +* - 156
> + - :cspan:`4` Histogram bucket (m=0, n=31) [31:0]
> +* - 160
> + - :cspan:`4` Histogram bucket (m=1, n=0) [31:0]
The code will be shared with the HGT entity, move it to the generic
histogram implementation.
Signed-off-by: Laurent Pinchart
---
drivers/media/platform/vsp1/vsp1_drv.c | 7 +-
drivers/media/platform/vsp1/vsp1_hgo.c | 308 ++--
drivers/media/platform/vsp1
lude
> +#include
> +
> +#include "vsp1_entity.h"
> +#include "vsp1_histo.h"
> +
> +struct vsp1_device;
> +
> +#define HGT_PAD_SINK 0
> +#define HGT_PAD_SOURCE 1
> +
> +#define HGT_NUM_HUE_AREAS
On Monday 05 Sep 2016 17:57:11 Geert Uytterhoeven wrote:
> On Mon, Sep 5, 2016 at 5:43 PM, Laurent Pinchart wrote:
> >> + for (n = 0; n < 6; n++)
> >
> > Nitpicking, the driver uses pre-increment in for loops (++n), not post-
> > increment. This used to be a
+Pixels with a hue value included in the centre of an area (between nL and
> nU +included) are are attributed to that single area and given a weight of
s/are are/are/
> 16. +Pixels with a hue value included in the overlapping region between two
> areas +(between n+1L and nU excluded) are attrib
Hi Niklas,
On Tuesday 06 Sep 2016 12:28:00 Niklas Söderlund wrote:
> On 2016-09-05 18:13:39 +0300, Laurent Pinchart wrote:
> > The code will be shared with the HGT entity, move it to the generic
> > histogram implementation.
> >
> > Signed-off-by: Laurent Pinchart
>
Hi Mauro,
On Tuesday 06 Sep 2016 14:06:51 Mauro Carvalho Chehab wrote:
> Em Wed, 17 Aug 2016 15:20:28 +0300 Laurent Pinchart escreveu:
> > The format is used on the R-Car VSP1 video queues that carry
> > 1-D histogram statistics data.
> >
> > Signed-off-by: Laurent
if (values[0] > values[1] && values[11] > values[0])
values[0] = values[1];
memcpy(hgt->hue_areas, ctrl->p_new.p_u8, sizeof(hgt->hue_areas));
return 0;
}
I'm also beginning to wonder whether it wouldn't make sense to r
Support both the HSV24 and HSV32 formats. From a hardware point of view
pretend the formats are RGB, the RPF and WPF will just pass the data
through without performing any processing.
Signed-off-by: Laurent Pinchart
---
This patch is based on top of Ricardo's "[PATCH v5 00/12] Add
Hi Ricardo,
On Wednesday 07 Sep 2016 09:07:35 Ricardo Ribalda Delgado wrote:
> Hi Laurent
>
> Thank you very much!
You're welcome.
> On Wed, Sep 7, 2016 at 2:14 AM, Laurent Pinchart wrote:
> > Support both the HSV24 and HSV32 formats. From a hardware point of view
>
The function is defined in a header file when HAVE_DVBV5_REMOTE is not
set. It needs to be marked as static inline.
Signed-off-by: Laurent Pinchart
---
lib/include/libdvbv5/dvb-dev.h | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/lib/include/libdvbv5/dvb-dev.h b/lib
Hi Niklas,
On Wednesday 07 Sep 2016 12:05:26 Niklas Söderlund wrote:
> On 2016-09-06 22:59:22 +0300, Laurent Pinchart wrote:
> > On Tuesday 06 Sep 2016 16:38:56 Niklas Söderlund wrote:
> >> The HGT is a Histogram Generator Two-Dimensions. It computes a weighted
> >> f
bsampling.
>
> Signed-off-by: Niklas Söderlund
Reviewed-by: Laurent Pinchart
However, please note that we might need to upstream HGT support before HGO. To
ease that, I've split the HGO patches in common code and HGO-specific code,
and rebased your patch on top of that. The result is avail
The S_FMT and TRY_FMT handlers in multiplane mode attempt at clearing
the reserved fields of the v4l2_format structure after the pix_mp
member. However, the reserved fields are inside pix_mp, not after it.
Signed-off-by: Laurent Pinchart
Tested-by: Kieran Bingham
---
drivers/media/v4l2-core
Ensure that the buffer field matches the field configured for the
format.
Signed-off-by: Laurent Pinchart
---
drivers/media/platform/rcar_fdp1.c | 40 +++---
1 file changed, 33 insertions(+), 7 deletions(-)
diff --git a/drivers/media/platform/rcar_fdp1.c
b
h, f->fmt.pix_mp.height, f->fmt.pix_mp.field);
return 0;
}
@@ -1989,6 +2076,7 @@ static int queue_init(void *priv, struct vb2_queue
*src_vq,
static int fdp1_open(struct file *file)
{
struct fdp1_dev *fdp1 = video_drvdata(file);
+ struct v4l2_pix_format_mplane format;
The struct fdp1_buffer instances are allocated separately from the vb2
buffers, with one instance per field. Simplify the allocation by
splitting the fdp1_buffer structure in per-buffer and per-field data,
and let vb2 allocate the the fdp1_buffer structure.
Signed-off-by: Laurent Pinchart
The menu control selects the operation mode of a video deinterlacer. The
menu entries are driver specific.
Signed-off-by: Laurent Pinchart
---
Documentation/media/uapi/v4l/extended-controls.rst | 4
drivers/media/v4l2-core/v4l2-ctrls.c | 2 ++
include/uapi/linux/v4l2
: OK
test VIDIOC_EXPBUF: OK
Test input 0:
Total: 43, Succeeded: 43, Failed: 0, Warnings: 0
Geert Uytterhoeven (1):
v4l: fdp1: vb2_queue dev conversion
Kieran Bingham (2):
v4l: Extend FCP compatible list to support the FDP
v4l: Add Renesas R-Car FDP1 Driver
Laurent Pinchart (7)
e the standard V4L2_CID_DEINTERLACER_MODE control
- Add missing white space
Signed-off-by: Laurent Pinchart
---
drivers/media/platform/rcar_fdp1.c | 111 +
1 file changed, 52 insertions(+), 59 deletions(-)
diff --git a/drivers/media/platform/rcar_fdp1.c
b/dr
The structure is not used, remove it.
Signed-off-by: Laurent Pinchart
---
drivers/media/platform/rcar_fdp1.c | 13 -
1 file changed, 13 deletions(-)
diff --git a/drivers/media/platform/rcar_fdp1.c
b/drivers/media/platform/rcar_fdp1.c
index bbeacf1527b5..fdab41165f5a 100644
--- a
From: Kieran Bingham
The FCP must be powered up for the FDP1 to function, even when the FDP1
does not make use of the FCNL features. Extend the compatible list
to allow us to use the power domain and runtime-pm support.
Signed-off-by: Kieran Bingham
Acked-by: Laurent Pinchart
Signed-off-by
: linux-renesas-...@vger.kernel.org
+T: git git://linuxtv.org/media_tree.git
+S: Supported
+F: Documentation/devicetree/bindings/media/renesas,fdp1.txt
+F: drivers/media/platform/rcar_fdp1.c
+
MEDIA DRIVERS FOR RENESAS - VSP1
M: Laurent Pinchart
L: linux-media
ove(struct platform_device *pdev)
v4l2_m2m_release(fdp1->m2m_dev);
video_unregister_device(&fdp1->vfd);
v4l2_device_unregister(&fdp1->v4l2_dev);
- vb2_dma_contig_cleanup_ctx(fdp1->alloc_ctx);
pm_runtime_disable(&pdev->dev);
return 0;
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Mauro,
Thank you for the patch.
On Thursday 08 Sep 2016 09:03:44 Mauro Carvalho Chehab wrote:
> The "struct" were inside the reference, causing it to break.
>
> Signed-off-by: Mauro Carvalho Chehab
Acked-by: Laurent Pinchart
> ---
> Documentation/media/kapi/v4l2
rl_ops,
> + V4L2_CID_AUTO_WHITE_BALANCE, 0, 1, 1, 1);
> + ov5645->pattern = v4l2_ctrl_new_std_menu_items(&ov5645->ctrls,
> + &ov5645_ctrl_ops, V4L2_CID_TEST_PATTERN,
> + ARRAY_SIZE(ov56
vddd-supply = <&camera_dvdd_1v2>;
> +
> + port {
> + ov5645_ep: endpoint {
> + clock-lanes = <1>;
> + data-lanes = <0 2>;
> + remote-endpoint = <&csi0_ep>;
> + };
> + };
> + };
> + };
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
2 +-
> drivers/media/platform/sh_vou.c |2 +-
> drivers/media/platform/soc_camera/atmel-isi.c|2 +-
> drivers/media/platform/soc_camera/sh_mobile_ceu_camera.c |2 +-
> drivers/media/platform/vim2m.c |2
= { ... };
> //
>
> Signed-off-by: Julia Lawall
For
> drivers/media/usb/uvc/uvc_queue.c |2 +-
Reviewed-by: Laurent Pinchart
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Kieran Bingham
The FCP must be powered up for the FDP1 to function, even when the FDP1
does not make use of the FCNL features. Extend the compatible list
to allow us to use the power domain and runtime-pm support.
Signed-off-by: Kieran Bingham
Reviewed-by: Laurent Pinchart
Signed-off-by
R-Car FCP power-domains usage
v4l: rcar-fcp: Extend compatible list to support the FDP
Laurent Pinchart (5):
v4l: ioctl: Clear the v4l2_pix_format_mplane reserved field
v4l: rcar-fcp: Keep the coding style consistent
v4l: rcar-fcp: Don't force users to check for
Hi Geert,
On Tuesday 13 Sep 2016 14:19:56 Geert Uytterhoeven wrote:
> On Wed, Aug 17, 2016 at 2:20 PM, Laurent Pinchart wrote:
> > This patch series implements support for the Renesas R-Car VSP1 1-D
> > histogram generator (HGO). It is based on top of the latest media tree'
to release each display list
back to the free list.
The chained lists use case (image partitioning) can require up to 64
lists per frame in the worst case scenario, bump up the number of
preallocated lists.
Signed-off-by: Kieran Bingham
Signed-off-by: Laurent Pinchart
---
drivers/media/platform
The RPF cropping offset for the chroma planes is incorrectly computed,
it needs to be divided by the horizontal subsampling factor.
Signed-off-by: Laurent Pinchart
---
drivers/media/platform/vsp1/vsp1_rpf.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/media
v4l: vsp1: Support multiple partitions per frame
Laurent Pinchart (7):
v4l: vsp1: Prevent pipelines from running when not streaming
v4l: vsp1: Protect against race conditions between get and set format
v4l: vsp1: Disable cropping on WPF sink pad
v4l: vsp1: Fix RPF cropping
v4l: vsp1:
From: Kieran Bingham
The vsp1_pipeline_ready() and vsp1_pipeline_run() functions must be
called with the pipeline lock held, fix the resume code path.
Signed-off-by: Kieran Bingham
Signed-off-by: Laurent Pinchart
---
drivers/media/platform/vsp1/vsp1_pipe.c | 3 +++
1 file changed, 3
o change the locking state of the buffer release code. This has been
analysed visually as acceptable, but it must be considered that this now
causes the video->irqlock to be taken under the pipe->irqlock context.
Signed-off-by: Laurent Pinchart
---
drivers/media/platform/vsp1/vsp1_video
From: Kieran Bingham
The DFE and FRE interrupts are both fired at frame completion, as each
display list processes a single frame. This won't be true anymore when
using image partitioning, switch to DFE in preparation.
Signed-off-by: Laurent Pinchart
Signed-off-by: Kieran Bingham
---
dr
.
Signed-off-by: Laurent Pinchart
---
drivers/media/platform/vsp1/vsp1_clu.c| 3 ++
drivers/media/platform/vsp1/vsp1_drm.c| 9 +---
drivers/media/platform/vsp1/vsp1_entity.h | 6 +--
drivers/media/platform/vsp1/vsp1_lut.c| 3 ++
drivers/media/platform/vsp1/vsp1_rpf.c| 78
runtime (through V4L2 controls)
This will allow future extensions when implementing image partitioning
support.
Signed-off-by: Laurent Pinchart
---
drivers/media/platform/vsp1/vsp1_bru.c| 5 ++--
drivers/media/platform/vsp1/vsp1_clu.c| 43 +--
drivers/media
Some WPF instances, on Gen3 devices, can perform 90° rotation when
writing frames to memory. Implement support for this using the
V4L2_CID_ROTATE control.
Signed-off-by: Laurent Pinchart
---
drivers/media/platform/vsp1/vsp1_rpf.c | 2 +-
drivers/media/platform/vsp1/vsp1_rwpf.c | 5
The subdev userspace API isn't serialized in the core, serialize access
to formats and selection rectangles in the driver.
Signed-off-by: Laurent Pinchart
---
drivers/media/platform/vsp1/vsp1_bru.c| 28 +++-
drivers/media/platform/vsp1/vsp1_clu.c| 15 ---
dr
Reported-by: Kieran Bingham
Tested-by: Kieran Bingham
Signed-off-by: Laurent Pinchart
---
drivers/media/platform/vsp1/vsp1_video.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/media/platform/vsp1/vsp1_video.c
b/drivers/media/platform/vsp1/vsp1_video.c
index 9fb4fc26a359.
be
processed by the algorithm.
Gen 2 hardware does not require multiple partitioning, and as such
will always return a single partition.
Signed-off-by: Kieran Bingham
Signed-off-by: Laurent Pinchart
---
drivers/media/platform/vsp1/vsp1_entity.h | 3 +++
drivers/media/platform/vsp1/vsp1_pipe.h
t any
following parition display lists are linked to the head by means of
vsp1_dl_list_add_chain().
Linking the chained display list headers to process using the auto start
mechanism of the hardware is performed during the vsp1_dl_list_commit().
Signed-off-by: Kieran Bingham
Signed-off-by: La
Cropping on the WPF sink pad restricts the left and top coordinates to
0-255. The same result can be obtained by cropping on the RPF without
any such restriction, this feature isn't useful. Disable it.
Signed-off-by: Laurent Pinchart
---
drivers/media/platform/vsp1/vsp1_rwpf.c
The wpf_configure() function can be called both from IRQ and non-IRQ
contexts, use spin_lock_irqsave().
Signed-off-by: Laurent Pinchart
---
drivers/media/platform/vsp1/vsp1_wpf.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/vsp1/vsp1_wpf.c
b
Hi Sakari,
Thank you for the patch.
On Tuesday 13 Sep 2016 11:28:15 Sakari Ailus wrote:
> As a result, a function that can be used to print information on a given
> entity only is provided.
>
> Signed-off-by: Sakari Ailus
Acked-by: Laurent Pinchart
> ---
> utils/media-ct
rgc, argv, "d:e:f:hil:p::rvV:",
> opts, NULL)) != -1) {
> switch (opt) {
> case 'd':
> @@ -182,6 +184,7 @@ int parse_cmdline(int argc, char **argv)
>
> case 'p':
>
Hi Niklas,
Thank you for the review.
On Wednesday 14 Sep 2016 20:23:18 Niklas Söderlund wrote:
> On 2016-09-14 02:16:55 +0300, Laurent Pinchart wrote:
> > The subdev userspace API isn't serialized in the core, serialize access
> > to formats and selection rect
Hi Niklas,
On Wednesday 14 Sep 2016 21:27:33 Niklas Söderlund wrote:
> On 2016-09-14 02:17:04 +0300, Laurent Pinchart wrote:
> > From: Kieran Bingham
> >
> > The partition algorithm needs to determine the capabilities of each
> > entity in the pipeline to identify th
int the device topology. If an entity\n");
printf("is specified through the -e option, print\n");
printf("information for that entity only.\n);
? I think the help text looks more natural when using articles :-)
>
entities.
>
> Signed-off-by: Sakari Ailus
Reviewed-by: Laurent Pinchart
> ---
> utils/media-ctl/media-ctl.c | 32 ++--
> utils/media-ctl/options.c | 4 +++-
> 2 files changed, 17 insertions(+), 19 deletions(-)
>
> diff --git a/utils/media-
Hi Niklas,
Thank you for the patch.
On Thursday 15 Sep 2016 14:18:36 Niklas Söderlund wrote:
> The driver is maintained and supported, document it as such.
>
> Signed-off-by: Niklas Söderlund
Acked-by: Laurent Pinchart
> ---
> MAINTAINERS | 9 +
> 1 file cha
car-vin/rcar-vin.h index 793184d..af815cc 100644
> --- a/drivers/media/platform/rcar-vin/rcar-vin.h
> +++ b/drivers/media/platform/rcar-vin/rcar-vin.h
> @@ -121,6 +121,7 @@ struct rvin_dev {
> struct video_device vdev;
> struct v4l2_device v4l2_dev;
> int src_
> else
> - state->pdata.default_input = -1;
> + state->pdata.default_input = 0;
>
> of_node_put(endpoint);
>
> + if (!of_property_read_u32(np, "default-input", &v))
> + state->pdata.default_input = v;
> +
>
Hi Hans,
On Thursday 15 Sep 2016 19:01:06 Hans Verkuil wrote:
> On 09/15/2016 06:47 PM, Laurent Pinchart wrote:
> > On Thursday 15 Sep 2016 15:24:08 Ulrich Hecht wrote:
> >> Adds G_EDID and S_EDID.
> >>
> >> Signed-off-by: Ulrich Hecht
> >> ---
>
Hi Ulrich,
Thank you for the patch.
On Thursday 15 Sep 2016 19:33:23 Ulrich Hecht wrote:
> Adds G_EDID and S_EDID.
>
> Signed-off-by: Ulrich Hecht
> Acked-by: Niklas Söderlund
Acked-by: Laurent Pinchart
> ---
> drivers/media/platform/rcar-vi
Hi Ulrich,
Thank you for the patch.
On Thursday 15 Sep 2016 19:33:24 Ulrich Hecht wrote:
> Signed-off-by: Ulrich Hecht
With a commit message explaining why this is needed,
Acked-by: Laurent Pinchart
> ---
> drivers/media/platform/rcar-vin/rcar-v4l2.c | 4 ++--
> 1 fil
The VYUY format isn't supported on Gen3 hardware, disable it.
Gen2 hardware supports VYUY in practice even though the documentation
doesn't advertise it, so keep it for Gen2 devices.
Signed-off-by: Laurent Pinchart
---
drivers/media/platform/vsp1/vsp1_drm.c | 2 +-
drivers/medi
v4l: vsp1: Determine partition requirements for scaled images
v4l: vsp1: Support multiple partitions per frame
Laurent Pinchart (8):
v4l: vsp1: Prevent pipelines from running when not streaming
v4l: vsp1: Protect against race conditions between get and set format
v4l:
lines of
"The example makes more sense as the default input is a property of the chip,
not of a particular port."
With that changed,
Reviewed-by: Laurent Pinchart
> Signed-off-by: Ulrich Hecht
> ---
> Documentation/devicetree/bindings/media/i2c/adv7604.txt | 3 +--
>
state->pdata.default_input = v;
> +
> flags = bus_cfg.bus.parallel.flags;
>
> if (flags & V4L2_MBUS_HSYNC_ACTIVE_HIGH)
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Mauro,
On Monday 19 Sep 2016 14:55:43 Mauro Carvalho Chehab wrote:
> Em Wed, 14 Sep 2016 02:16:59 +0300 Laurent Pinchart escreveu:
> > Cropping on the WPF sink pad restricts the left and top coordinates to
> > 0-255. The same result can be obtained by cropping on the RPF witho
Hi Mauro,
On Monday 19 Sep 2016 15:26:15 Mauro Carvalho Chehab wrote:
> Em Mon, 19 Sep 2016 20:59:56 +0300 Laurent Pinchart escreveu:
> > On Monday 19 Sep 2016 14:55:43 Mauro Carvalho Chehab wrote:
> >> Em Wed, 14 Sep 2016 02:16:59 +0300 Laurent Pinchart escreveu:
> >>
.h
> @@ -35,7 +35,7 @@ enum vsp1_entity_type {
> VSP1_ENTITY_WPF,
> };
>
> -/*
> +/**
Quoting another mail I've sent:
I don't think those comments should become part of the kernel documentation.
They're really about driver internals, and meant for the d
Hi Mauro,
On Monday 19 Sep 2016 16:10:31 Mauro Carvalho Chehab wrote:
> Em Mon, 19 Sep 2016 21:35:36 +0300 Laurent Pinchart escreveu:
> > On Monday 19 Sep 2016 15:26:19 Mauro Carvalho Chehab wrote:
> >> Several multi-line comments added at the vsp1 patch series
> >> vio
ine
else:
output += line
if in_table:
in_table = False
output += process_table(fname, table)
return output
fname = sys.argv[1]
data = file(fname, 'rb').read().decode('utf-8')
data = process
Hi Markus,
On Wednesday 21 Sep 2016 11:24:33 Markus Heiser wrote:
> Am 21.09.2016 um 10:48 schrieb Laurent Pinchart:
> > Hello,
> >
> > While documenting the metadata API I got annoyed by how tables were
> > converted from DocBook to ReST.
>
> I suggested
Hello Sakari,
On Wednesday 21 Sep 2016 14:33:29 Sakari Ailus wrote:
> Hi Laurent,
>
> On Wed, Aug 17, 2016 at 03:44:00PM +0300, Laurent Pinchart wrote:
> > > + assigned-clock-rates = <2400>;
> >
> > You should compute and set the clock
Hi Hans,
On Friday 26 Aug 2016 09:45:25 Hans Verkuil wrote:
> On 08/17/2016 02:44 PM, Laurent Pinchart wrote:
> > On Wednesday 17 Aug 2016 08:29:41 Hans Verkuil wrote:
> >> From: Hans Verkuil
> >>
> >> Add DT support. Use it to get the reset and pwdn pins
h the documentation.
>
> Based on patch by William Towle .
>
> Signed-off-by: Ulrich Hecht
> Signed-off-by: Hans Verkuil
Acked-by: Laurent Pinchart
> ---
> drivers/media/i2c/adv7604.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/
---[ end trace 1a4f7b9817d19b04 ]---
> [ 146.646180] g_webcam gadget: UVC connect failed with -22
> [ 146.653808] usb 1-9: USB disconnect, device number 5
> [ 146.653986] g_webcam gadget: UVC disconnect failed with -110
[snip]
> uvc-gadget keeps printing this error message:
>
>
uirement.
>
> f_uvc.c should be handling that by means for usb_function_deactivate().
>
> I'll try keeping cable disconnected until uvc-gadget is running.
Things might have changed since we've discussed the issue several years ago,
but back then at least the musb UDC started unconditionally connected.
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
tatic int isp_of_parse_nodes(struct device *dev,
> }
>
> isd->asd.match.of.node = of_graph_get_remote_port_parent(node);
> - of_node_put(node);
> +
This change is correct not because of_graph_get_next_endpoint() has called
of_node_put() but because it *
Hi Felipe,
Thanks for the patch.
On Wednesday 28 Sep 2016 16:05:23 Felipe Balbi wrote:
> We have introduced a helper to calculate multiplier
> value from wMaxPacketSize. Start using it.
>
> Cc: Laurent Pinchart
> Cc: Mauro Carvalho Chehab
> Cc:
> Signed-off-by: Felipe Ba
Hi Felipe,
Thank you for the patch.
On Wednesday 28 Sep 2016 16:05:39 Felipe Balbi wrote:
> Now that usb_endpoint_maxp() only returns the lowest
> 11 bits from wMaxPacketSize, we can remove the &
> operation from this driver.
>
> Cc: Laurent Pinchart
> Cc: Mauro
Hello Nikolaus,
On Friday 30 Sep 2016 10:28:40 H. Nikolaus Schaller wrote:
> > Am 29.09.2016 um 10:54 schrieb Laurent Pinchart:
> > On Thursday 08 Sep 2016 17:48:33 H. Nikolaus Schaller wrote:
> >> of_node_put() has already been called inside
> >&
.
At the time of writing, devices known to have such a broken chain are
- Acer Integrated Camera (5986:055a)
- Realtek rtl157a7 (0bda:57a7)
Signed-off-by: Henrik Ingo
Signed-off-by: Laurent Pinchart
---
drivers/media/usb/uvc/uvc_driver.c | 118 +++--
1 file
s = <&sysc R8A7793_PD_ALWAYS_ON>;
> + status = "disabled";
> + };
> +
As Geert mentioned, you should add vin2 here.
> qspi: spi@e6b1 {
> compatible = "renesas,qspi-r8a7793", "renesas,qspi";
> reg = <0 0xe6b1 0 0x2c>;
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Ulrich,
On Friday 30 Sep 2016 13:55:50 Laurent Pinchart wrote:
> On Friday 16 Sep 2016 15:09:33 Ulrich Hecht wrote:
> > Signed-off-by: Ulrich Hecht
> > ---
> >
> > arch/arm/boot/dts/r8a7793.dtsi | 20
> > 1 file changed, 20 insertions(
#address-cells = <1>;
> + #size-cells = <0>;
> +
> + vin0ep: endpoint {
> + remote-endpoint = <&adv7612>;
> + bus-width = <24>;
> + hsync-active = <0>;
> + vsync-active = <0>;
> + pclk-sample = <1>;
> + data-active = <1>;
> + };
> + };
> +};
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
&vin1 {
> + pinctrl-0 = <&vin1_pins>;
> + pinctrl-names = "default";
> +
> + status = "okay";
> +
> + port {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + vin1ep: endpoint {
> + remote-endpoint = <&adv7180>;
> + bus-width = <8>;
> + };
> + };
> +};
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Friday 30 Sep 2016 15:00:59 Geert Uytterhoeven wrote:
> On Fri, Sep 30, 2016 at 2:40 PM, Laurent Pinchart wrote:
> >> --- a/arch/arm/boot/dts/r8a7793-gose.dts
> >> +++ b/arch/arm/boot/dts/r8a7793-gose.dts
> >> @@ -374,6 +374,11 @@
> >&
* implemented.
> + /* Try the get selection operation first and
> + * fallback to get format if not implemented.
Lines can be up to 80 characters long, there's no need to wrap them after 52
characters only.
>*/
> sdsel.pad = pad;
> ret =
IPIPE_SRC_COL_OO_GR BIT(6)
> #define IPIPE_SRC_COL_OO_B (3 << 6)
> #define IPIPE_SRC_COL_OO_GB (2 << 6)
> #define IPIPE_SRC_COL_OE_R (0 << 4)
> -#define IPIPE_SRC_COL_OE_GR (1 << 4)
> +#define IPIPE_SRC_COL_OE_GR BIT(4)
> #define IPIPE_SRC_COL_OE_B (3 << 4)
> #define IPIPE_SRC_COL_OE_GB (2 << 4)
> #define IPIPE_SRC_COL_EO_R (0 << 2)
> -#define IPIPE_SRC_COL_EO_GR (1 << 2)
> +#define IPIPE_SRC_COL_EO_GR BIT(2)
> #define IPIPE_SRC_COL_EO_B (3 << 2)
> #define IPIPE_SRC_COL_EO_GB (2 << 2)
> #define IPIPE_SRC_COL_EE_R (0 << 0)
> -#define IPIPE_SRC_COL_EE_GR (1 << 0)
> +#define IPIPE_SRC_COL_EE_GR BIT(0)
> #define IPIPE_SRC_COL_EE_B (3 << 0)
> #define IPIPE_SRC_COL_EE_GB (2 << 0)
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
ISS_CTRL_INPUT_SEL_CSI2BBIT(2)
>
> Yet, not sure if I would like such patch, as this kind of change
> could easily break the driver if you make any typo at the GENMASK
> parameters.
It would be best to automate such a change with a script than performing it
manually.
--
Regards,
Laurent
amp;vin0 {
> + status = "okay";
> + pinctrl-0 = <&vin0_pins>;
> + pinctrl-names = "default";
> +
> + port {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + vin0
1 - 100 of 8134 matches
Mail list logo
