This module implements V4L2 controls for the Texas Instruments
WL1273 FM Radio and handles the communication with the chip.
Signed-off-by: Matti J. Aaltonen
---
drivers/media/radio/radio-wl1273.c | 360 +++-
1 files changed, 106 insertions(+), 254 deletions(-)
d
Hello.
Thanks for the comment Mark.
On Tue, 2011-03-01 at 11:54 +, ext Mark Brown wrote:
On Tue, Mar 01, 2011 at 10:00:50AM +0200, Matti J. Aaltonen wrote:
> > These changes are needed to keep up with the changes in the
> > MFD core and V4L2 parts of the wl1273 FM radio driver.
This module implements V4L2 controls for the Texas Instruments
WL1273 FM Radio and handles the communication with the chip.
Signed-off-by: Matti J. Aaltonen
---
drivers/media/radio/radio-wl1273.c | 360 +++-
1 files changed, 106 insertions(+), 254 deletions(-)
d
d-by: Samuel Ortiz
Cheers,
Matti
Matti J. Aaltonen (3):
MFD: WL1273 FM Radio: MFD driver for the FM radio.
V4L2: WL1273 FM Radio: TI WL1273 FM radio driver
ASoC: WL1273 FM radio: Access I2C IO functions through pointers.
drivers/media/radio/radio-wl1273.c | 360 +++
Hello.
And thanks for the comments. If we now move quickly enough we can
get this thing in before it becomes deprecated...
Samuel wrote:
> for Mauro to take this one you'd have to provide a
> diff against the already existing wl1273-core.
I've made these patches against the existing stuff.
>> +
Hi Mauro,
On Tue, Feb 15, 2011 at 05:59:52PM -0200, Mauro Carvalho Chehab wrote:
> Em 15-02-2011 06:13, Matti J. Aaltonen escreveu:
> > Hello.
> >
> > Now I've refactored the code so that the I2C I/O functions are in the
> > MFD core. Also now the codec can be compiled without compiling the V4L2
Em 15-02-2011 06:13, Matti J. Aaltonen escreveu:
> Hello.
>
> Now I've refactored the code so that the I2C I/O functions are in the
> MFD core. Also now the codec can be compiled without compiling the V4L2
> driver.
>
> I haven't implemented the audio routing (yet), but I've added a TODO
> comme
This module implements V4L2 controls for the Texas Instruments
WL1273 FM Radio and handles the communication with the chip.
Signed-off-by: Matti J. Aaltonen
---
drivers/media/radio/Kconfig| 16 +
drivers/media/radio/Makefile |1 +
drivers/media/radio/radio-wl1273.c | 2183 +++
tti J. Aaltonen (3):
MFD: WL1273 FM Radio: MFD driver for the FM radio.
V4L2: WL1273 FM Radio: TI WL1273 FM radio driver
ASoC: WL1273 FM radio: Access I2C IO functions through pointers.
drivers/media/radio/Kconfig| 16 +
drivers/media/radio/Makefile |1 +
drivers/me
On Thu, Feb 10, 2011 at 02:57:47PM +0200, Matti J. Aaltonen wrote:
> And a comment to the above from the earlier mentioned local BT expert:
> "It would need some hack to generic hci code. Or maybe some kind of
> management api extension. That should be a few line only.. but getting
> it to upstrea
On Thu, 2011-02-10 at 12:28 +, ext Mark Brown wrote:
> On Thu, Feb 10, 2011 at 02:10:40PM +0200, Matti J. Aaltonen wrote:
>
> > But I got the following quick comment from a local BT expert: "No you
> > cannot change line discipline if bt is already in use. And it's not uart
> > interface but h
On Thu, Feb 10, 2011 at 02:10:40PM +0200, Matti J. Aaltonen wrote:
> But I got the following quick comment from a local BT expert: "No you
> cannot change line discipline if bt is already in use. And it's not uart
> interface but hci interface. uart can be replaced with sdio for example
> and you
On Thu, 2011-02-10 at 11:02 +, ext Mark Brown wrote:
> On Thu, Feb 10, 2011 at 12:03:43PM +0200, Matti J. Aaltonen wrote:
>
> > We know these messages, they are mentioned in the documentation and we
> > use them already, but we send them from the user space. The problem is
> > how to send the
On Thu, Feb 10, 2011 at 12:03:43PM +0200, Matti J. Aaltonen wrote:
> We know these messages, they are mentioned in the documentation and we
> use them already, but we send them from the user space. The problem is
> how to send the messages from the driver within the kernel.
Set up a line discipli
Hello.
On Thu, 2011-02-10 at 09:35 +, ext Bensaid, Selma wrote:
> > On Tue, 2011-02-08 at 13:02 +0200, Peter Ujfalusi wrote:
> > > > For both configuration we have a set of HCI commands to configure the FM
> > audio
> > > > path and one of my concerns is to know if the wl1273_codec should hand
> On Tue, 2011-02-08 at 13:02 +0200, Peter Ujfalusi wrote:
> > > For both configuration we have a set of HCI commands to configure the FM
> audio
> > > path and one of my concerns is to know if the wl1273_codec should handle
> the audio path configuration
> > > and the switch between FM and BT SCO?
On Mon, 2011-02-07 at 14:00 -0200, ext Mauro Carvalho Chehab wrote:
> Em 07-02-2011 12:17, Matti J. Aaltonen escreveu:
> > On Mon, 2011-02-07 at 13:52 +, ext Mark Brown wrote:
> >> On Mon, Feb 07, 2011 at 11:48:17AM -0200, Mauro Carvalho Chehab wrote:
> >>> Em 07-02-2011 11:10, Mark Brown escre
On Tue, 2011-02-08 at 11:15 +0200, Peter Ujfalusi
>
> I have not looked deeply into the wl1273 datasheets, but I'm sure
> there's a way to nicely divide the parts between the MFD, V4L, and ASoC.
>
I don't think there's much to be moved between the sub-systems after
moving the I2C communication
On Tue, 2011-02-08 at 13:02 +0200, Peter Ujfalusi wrote:
> > For both configuration we have a set of HCI commands to configure the FM
> > audio
> > path and one of my concerns is to know if the wl1273_codec should handle
> > the audio path configuration
> > and the switch between FM and BT SCO?
e Combined Interface Mode (host controls both the BT and FM
> radio via BT HCI) this could be possible. However, you use the Separate
> Interface (FM controlled vi I2C).
> Is there a plan to handle also the Combined Interface Mode for WL1273 FM
> Radio driver?
We haven'
eparate
Interface (FM controlled vi I2C).
Is there a plan to handle also the Combined Interface Mode for WL1273 FM Radio
driver?
Selma.
> --
> Péter
-
Intel Corporation SAS (French simplified joint stock company)
Registere
On 02/08/11 12:09, ext Bensaid, Selma wrote:
> 2 Digital interfaces are possible for FM WL1273:
> - the external connection: the I2S lines are used for the FM PCM samples
> - the internal connection: the BT PCM interface is used for the FM PCM samples
Yes, that is correct, I just did not wanted to
> The wl1273 as such is designed for embedded systems.
> It can be connected in several ways to the system:
> - analog only
> In this way the RX/TX is connected to some codec's Line IN/OUT
> For this to work, we don't need any audio driver for the FM chip
> (basically the same configuration as rx51
Hi,
On 02/07/11 18:00, ext Mauro Carvalho Chehab wrote:
> We don't need any brand names or specific details, but it would be good to
> have an overview, in general lines, about the architecture, in order to help
> you to map how this would fit. In particular, the architecturre of
> things that
On Mon, Feb 07, 2011 at 01:57:10PM -0200, Mauro Carvalho Chehab wrote:
> Em 07-02-2011 12:09, Matti J. Aaltonen escreveu:
> > Both children depend on the MFD driver for I/O and the codec also
> > depends on the presence of the radio-wl1273 driver because without the
> > v4l2 part nothing can be do
Em 07-02-2011 12:17, Matti J. Aaltonen escreveu:
> On Mon, 2011-02-07 at 13:52 +, ext Mark Brown wrote:
>> On Mon, Feb 07, 2011 at 11:48:17AM -0200, Mauro Carvalho Chehab wrote:
>>> Em 07-02-2011 11:10, Mark Brown escreveu:
>>
There is an audio driver for this chip and it is using those fu
Em 07-02-2011 12:09, Matti J. Aaltonen escreveu:
> On Mon, 2011-02-07 at 11:48 -0200, ext Mauro Carvalho Chehab wrote:
>> Em 07-02-2011 11:10, Mark Brown escreveu:
>>> On Mon, Feb 07, 2011 at 10:48:03AM -0200, Mauro Carvalho Chehab wrote:
Em 07-02-2011 10:02, Mark Brown escreveu:
> On Mon,
On Mon, 2011-02-07 at 13:52 +, ext Mark Brown wrote:
> On Mon, Feb 07, 2011 at 11:48:17AM -0200, Mauro Carvalho Chehab wrote:
> > Em 07-02-2011 11:10, Mark Brown escreveu:
>
> > > There is an audio driver for this chip and it is using those functions.
>
> > Where are the other drivers that de
On Mon, 2011-02-07 at 11:48 -0200, ext Mauro Carvalho Chehab wrote:
> Em 07-02-2011 11:10, Mark Brown escreveu:
> > On Mon, Feb 07, 2011 at 10:48:03AM -0200, Mauro Carvalho Chehab wrote:
> >> Em 07-02-2011 10:02, Mark Brown escreveu:
> >>> On Mon, Feb 07, 2011 at 10:00:16AM -0200, Mauro Carvalho Ch
On Mon, Feb 07, 2011 at 11:48:17AM -0200, Mauro Carvalho Chehab wrote:
> Em 07-02-2011 11:10, Mark Brown escreveu:
> > There is an audio driver for this chip and it is using those functions.
> Where are the other drivers that depend on it?
Nothing's been merged yet to my knowledge, Matti can com
Em 07-02-2011 11:10, Mark Brown escreveu:
> On Mon, Feb 07, 2011 at 10:48:03AM -0200, Mauro Carvalho Chehab wrote:
>> Em 07-02-2011 10:02, Mark Brown escreveu:
>>> On Mon, Feb 07, 2011 at 10:00:16AM -0200, Mauro Carvalho Chehab wrote:
>
the MFD part (for example,
wl1273_fm_read_reg/wl12
On Mon, 2011-02-07 at 13:28 +, ext Mark Brown wrote:
> On Mon, Feb 07, 2011 at 03:27:12PM +0200, Matti J. Aaltonen wrote:
>
> > So you are suggesting a more or less complete rewrite, so that I'd
> > create a directory like media/radio/wl1273 and then place there all of
> > the driver files: wl
On Mon, Feb 07, 2011 at 03:27:12PM +0200, Matti J. Aaltonen wrote:
> So you are suggesting a more or less complete rewrite, so that I'd
> create a directory like media/radio/wl1273 and then place there all of
> the driver files: wl1273-radio.c, wl1273-alsa.c and maybe wl1273-core.c?
Don't move th
On Mon, 2011-02-07 at 10:48 -0200, ext Mauro Carvalho Chehab wrote:
> Em 07-02-2011 10:02, Mark Brown escreveu:
> > On Mon, Feb 07, 2011 at 10:00:16AM -0200, Mauro Carvalho Chehab wrote:
> >
> >> the MFD part (for example,
> >> wl1273_fm_read_reg/wl1273_fm_write_cmd/wl1273_fm_write_data).
> >> T
On Mon, Feb 07, 2011 at 10:48:03AM -0200, Mauro Carvalho Chehab wrote:
> Em 07-02-2011 10:02, Mark Brown escreveu:
> > On Mon, Feb 07, 2011 at 10:00:16AM -0200, Mauro Carvalho Chehab wrote:
> >> the MFD part (for example,
> >> wl1273_fm_read_reg/wl1273_fm_write_cmd/wl1273_fm_write_data).
> >> Th
Em 07-02-2011 10:02, Mark Brown escreveu:
> On Mon, Feb 07, 2011 at 10:00:16AM -0200, Mauro Carvalho Chehab wrote:
>
>> the MFD part (for example,
>> wl1273_fm_read_reg/wl1273_fm_write_cmd/wl1273_fm_write_data).
>> The logic that are related to control the radio (wl1273_fm_set_audio,
>> wl1273
On Mon, Feb 07, 2011 at 10:00:16AM -0200, Mauro Carvalho Chehab wrote:
> the MFD part (for example,
> wl1273_fm_read_reg/wl1273_fm_write_cmd/wl1273_fm_write_data).
> The logic that are related to control the radio (wl1273_fm_set_audio,
> wl1273_fm_set_volume,
> etc) are not related to access t
Em 07-02-2011 08:52, Matti J. Aaltonen escreveu:
> Hello.
>
> Mark Brown wrote:
>> On Wed, Feb 02, 2011 at 01:35:01PM -0200, Mauro
>> Carvalho Chehab wrote:
>>
>> [Reflowed into 80 columns.]
>>> My concerns is that the V4L2-specific part of the code should be at
>>> drivers/media. I prefer that
Hello.
Mark Brown wrote:
> On Wed, Feb 02, 2011 at 01:35:01PM -0200, Mauro
> Carvalho Chehab wrote:
>
> [Reflowed into 80 columns.]
>> My concerns is that the V4L2-specific part of the code should be at
>> drivers/media. I prefer that the specific MFD I/O part to be at
>> drivers/mfd, just like
Hi Mauro,
On Wed, Feb 02, 2011 at 01:35:01PM -0200, Mauro Carvalho Chehab wrote:
> Em 30-01-2011 21:23, Samuel Ortiz escreveu:
> > Hi Matti,
> >
> > On Tue, Jan 18, 2011 at 05:04:23PM +0200, Matti J. Aaltonen wrote:
> >> Hello
> >>
> >> I have be
On Wed, Feb 02, 2011 at 01:35:01PM -0200, Mauro Carvalho Chehab wrote:
[Reflowed into 80 columns.]
> My concerns is that the V4L2-specific part of the code should be at
> drivers/media. I prefer that the specific MFD I/O part to be at
> drivers/mfd, just like the other drivers.
Currently that's
Em 30-01-2011 21:23, Samuel Ortiz escreveu:
> Hi Matti,
>
> On Tue, Jan 18, 2011 at 05:04:23PM +0200, Matti J. Aaltonen wrote:
>> Hello
>>
>> I have been trying to get the WL1273 FM radio driver into the kernel for
>> some time. It has been kind of diffic
Hi Matti,
On Tue, Jan 18, 2011 at 05:04:23PM +0200, Matti J. Aaltonen wrote:
> Hello
>
> I have been trying to get the WL1273 FM radio driver into the kernel for
> some time. It has been kind of difficult, one of the reasons is that I
> didn't realize I should have tried to
On Tue, Jan 18, 2011 at 05:04:23PM +0200, Matti J. Aaltonen wrote:
> The driver consists of an MFD core and two child drivers (the audio
> codec and the V4L2 driver). And the question is mainly about the role of
> the MFD driver: the original design had the IO functions in the core.
> Currently th
Hello
I have been trying to get the WL1273 FM radio driver into the kernel for
some time. It has been kind of difficult, one of the reasons is that I
didn't realize I should have tried to involve all relevant maintainers
to the discussion form the beginning (AsoC, Media and MFD). At M
g/media_tree.git tree:
> >
> > Subject: [media] [v18,2/2] V4L2: WL1273 FM Radio: TI WL1273 FM radio driver
> > Author: Matti Aaltonen
> > Date:Fri Dec 10 11:41:34 2010 -0300
> >
> > This module implements V4L2 controls for the Texas Instruments
> > WL1273 FM Radio a
On Tuesday, December 21, 2010 15:05:08 Mauro Carvalho Chehab wrote:
> This is an automatic generated email to let you know that the following patch
> were queued at the
> http://git.linuxtv.org/media_tree.git tree:
>
> Subject: [media] [v18,2/2] V4L2: WL1273 FM Radio: TI WL1273
gh Mauro's tree, please
> add my: Acked-by: Samuel Ortiz
OK.
> > \ No newline at end of file
> Please add a new line here.
Added...
Cheers,
Matti
Matti J. Aaltonen (2):
MFD: WL1273 FM Radio: MFD driver for the FM radio.
V4L2: WL1273 FM Radio: TI WL1273 FM radio driv
> > + if (r) {
> > + dev_err(radio->dev, "TUNER_MODE_SET fails\n");
>
> why complete here ? radio->busy is just initialized .. who is waiting
> on radio->busy ?
A good question. I removed the complete call and moved the init after the tes
Em 16-11-2010 11:35, Matti J. Aaltonen escreveu:
> Hi.
>
> The radio pull request, now using http protocol.
>
> The following changes since commit
> f6614b7bb405a9b35dd28baea989a749492c46b2:
> Linus Torvalds (1):
> Merge git://git.kernel.org/.../sfrench/cifs-2.6
>
> are available in th
Hi.
The radio pull request, now using http protocol.
The following changes since commit
f6614b7bb405a9b35dd28baea989a749492c46b2:
Linus Torvalds (1):
Merge git://git.kernel.org/.../sfrench/cifs-2.6
are available in the git repository at:
http://git.gitorious.org/wl1273-fm-driver/wl1
Hello Mauro.
Here is the pull request for the TI wl1273 FM radio driver.
The following changes since commit
f6614b7bb405a9b35dd28baea989a749492c46b2:
Linus Torvalds (1):
Merge git://git.kernel.org/.../sfrench/cifs-2.6
are available in the git repository at:
g
Hi Matti,
I've acked patches 1 and 2 and added some comments to patch 3.
Two other patches are needed, though: the new BLOCK_IO and CONTROLS
capabilities also need to be set in existing RDS drivers:
video/saa6588.c
radio/radio-cadet.c
radio/si4713-i2c.c
radio/si470x/radio-si470x-common.c
The ot
Hello Mauro, Hans and others.
I haven't gotten any comments to the latest patch set. The audio part
of the driver has already been accepted so I'm now trying to apply a
similar approach as with the codec. I've abstracted out the physical
control layer from the driver, it could use I2c or UART but
Hello again!
I've only received one comment from Hans (thank you) and I'm still
expecting to get comments also from Mauro. But I'm sending
the eleventh version anyway to keep the wheels rolling so to speak...
Hans wrote:
>> + V4L2_CAP_RDS_OUTPUT | V4L2_TUNER_CAP_RDS_BLOCK_IO;
>> +
>>
Hello all.
This is the tenth version of this patch set. Thank you for
comments, especially to Mauro.
I'll go through Mauro's comments one by one.
Patch 1/4:
>> + case V4L2_CID_FM_BAND: return "FM Band";
>
> There's no need for a FM control, as there's already an ioctl pair
Hello,
and thank you for the comments.
The audio codec has been accepted on the ALSA list...
I've converted the driver to the new control framework
as Hans strongly suggested.
P.S. I thought that I sent the patches on the day I created them,
but something clearly went wrong here...
Hans wrote
> Hello.
>
> It starts to look like the ALSA codec could be
> accepted on the ALSA list pretty soon.
> So I'd be very interested to hear from you if
> the rest of the driver still needs fixes...
Thanks for reminding me. I'll do a final review this evening.
> By the way, now the newest wl1273 fi
Hello.
It starts to look like the ALSA codec could be
accepted on the ALSA list pretty soon.
So I'd be very interested to hear from you if
the rest of the driver still needs fixes...
By the way, now the newest wl1273 firmware supports
a special form of hardware seek, they call it the
'bulk searc
Hello all,
and thanks for the comments Hans.
Now I've done a couple of iterations with the codec on the ALSA mailing
list and that still continues... I've removed all "#undef DEBUG" lines,
because the ALSA people didn't like them.
I'll go through the comments and the rest of the changes:
>> +
Hello All!
And thank for comments Hans and Mauro.
Here is the list of changes from v5:
include/linux/videodev2.h
Hans wrote:
>> +
>> +#define V4L2_CID_FM_RX_BAND (V4L2_CID_FM_TX_CLASS_BASE + 1)
>> +enum v4l2_fm_rx_band {
>
> Just a very small change: rename v4l2_fm_rx_band to
Hello all,
and thanks for the comments Hans. NowIn this version there are several small
fixes
because now I had time to actually test the driver...
Hans wrote:
> I've been thinking about this a bit more. Would it be possible to do this
> automatically
> in the driver? I.e. based on the frequen
Hello again,
and thank you for the comments.
New in this version of the patch set:
General headers:
I removed the seek level stuff and added the FM RX class. And I've added the
BAND IOCTL and I defined the three existing bands: I also added the OIRT band
because I think it's nicer to have thre
On Monday 24 May 2010 14:21:39 Matti J. Aaltonen wrote:
> Hello again.
>
> And thanks for the comments.
>
> It the first patch I'm kind of suggesting a couple of additions to the
> general interface: signal level stuff in the hw seek struct and then a
> function / IOCTL for asking for minimum an
Hello again.
And thanks for the comments.
It the first patch I'm kind of suggesting a couple of additions to the
general interface: signal level stuff in the hw seek struct and then a
function / IOCTL for asking for minimum and maximum for the level.
There are many changes I'll follow by commen
On Friday 30 April 2010 14:59:45 Matti J. Aaltonen wrote:
> Hello.
>
> I've implemented most of the changes proposed on the previous review round.
> There are some things to be done in the RDS handling...
>
> I've left the region handling as it was because neither of the chip's
> regions cover t
Hello.
I've implemented most of the changes proposed on the previous review round.
There are some things to be done in the RDS handling...
I've left the region handling as it was because neither of the chip's
regions cover the complete range. Japan is from 76 - 90MHz and
Europe/US is 87.5 to 108
67 matches
Mail list logo
