Re: [PATCH v4 5/5] v4l: Add driver for Micron MT9M032 camera sensor

2012-03-10 Thread Sakari Ailus
Hi Laurent, On Fri, Mar 09, 2012 at 09:20:47PM +0100, Laurent Pinchart wrote: > > Laurent Pinchart wrote: > > ... > > > > > +static int mt9m032_setup_pll(struct mt9m032 *sensor) > > > +{ > > > + static const struct aptina_pll_limits limits = { > > > + .ext_clock_min = 800, > > > +

Re: [PATCH v4 5/5] v4l: Add driver for Micron MT9M032 camera sensor

2012-03-09 Thread Laurent Pinchart
Hi Sakari, On Friday 09 March 2012 21:15:28 Sakari Ailus wrote: > Hi Laurent, > > Thanks for the patch. Just a few minor comments below. Thanks for the review. > Laurent Pinchart wrote: > ... > > > +static int mt9m032_setup_pll(struct mt9m032 *sensor) > > +{ > > + static const struct aptina_

Re: [PATCH v4 5/5] v4l: Add driver for Micron MT9M032 camera sensor

2012-03-09 Thread Sakari Ailus
Hi Laurent, Thanks for the patch. Just a few minor comments below. Laurent Pinchart wrote: ... > +static int mt9m032_setup_pll(struct mt9m032 *sensor) > +{ > + static const struct aptina_pll_limits limits = { > + .ext_clock_min = 800, > + .ext_clock_max = 1650,

[PATCH v4 5/5] v4l: Add driver for Micron MT9M032 camera sensor

2012-03-09 Thread Laurent Pinchart
From: Martin Hostettler The MT9M032 is a parallel 1.6MP sensor from Micron controlled through I2C. The driver creates a V4L2 subdevice. It currently supports cropping, gain, exposure and v/h flipping controls in monochrome mode with an external pixel clock. Signed-off-by: Martin Hostettler [Lo