Re: [PATCH v2 2/2] v4l: Add v4l2 subdev driver for S5K6AAFX sensor

2011-10-06 Thread Sakari Ailus
On Thu, Oct 06, 2011 at 10:00:50PM +0200, Sylwester Nawrocki wrote: > Moikka Sakari, Hi, Sylwester! > On 10/02/2011 09:20 AM, Sakari Ailus wrote: > > On Sat, Oct 01, 2011 at 11:17:27AM +0200, Sylwester Nawrocki wrote: [clip] > > That's fine because it's implemented by the sensor already. My poi

Re: [PATCH v2 2/2] v4l: Add v4l2 subdev driver for S5K6AAFX sensor

2011-10-06 Thread Sylwester Nawrocki
Moikka Sakari, On 10/02/2011 09:20 AM, Sakari Ailus wrote: > On Sat, Oct 01, 2011 at 11:17:27AM +0200, Sylwester Nawrocki wrote: >> Hi Sakari, >> >> I'm sorry, I've been a little bit busy in the week to get back to this. > > Hi Sylwester, > > No worries! > >> On 09/27/2011 10:55 PM, Sakari Ailu

Re: [PATCH v2 2/2] v4l: Add v4l2 subdev driver for S5K6AAFX sensor

2011-10-03 Thread Laurent Pinchart
Hi Sylwester and Sakari, On Sunday 02 October 2011 09:20:11 Sakari Ailus wrote: > On Sat, Oct 01, 2011 at 11:17:27AM +0200, Sylwester Nawrocki wrote: > > On 09/27/2011 10:55 PM, Sakari Ailus wrote: > > > Sylwester Nawrocki wrote: > > >> On 09/25/2011 12:08 PM, Sakari Ailus wrote: > > >>> On Fri, S

Re: [PATCH v2 2/2] v4l: Add v4l2 subdev driver for S5K6AAFX sensor

2011-10-02 Thread Sakari Ailus
On Sat, Oct 01, 2011 at 11:17:27AM +0200, Sylwester Nawrocki wrote: > Hi Sakari, > > I'm sorry, I've been a little bit busy in the week to get back to this. Hi Sylwester, No worries! > On 09/27/2011 10:55 PM, Sakari Ailus wrote: > > Sylwester Nawrocki wrote: > >> On 09/25/2011 12:08 PM, Sakari

Re: [PATCH v2 2/2] v4l: Add v4l2 subdev driver for S5K6AAFX sensor

2011-10-01 Thread Sylwester Nawrocki
Hi Sakari, I'm sorry, I've been a little bit busy in the week to get back to this. On 09/27/2011 10:55 PM, Sakari Ailus wrote: > Sylwester Nawrocki wrote: >> On 09/25/2011 12:08 PM, Sakari Ailus wrote: >>> On Fri, Sep 23, 2011 at 12:12:58PM +0200, Sylwester Nawrocki wrote: On 09/23/2011 12:0

Re: [PATCH v2 2/2] v4l: Add v4l2 subdev driver for S5K6AAFX sensor

2011-09-28 Thread Sylwester Nawrocki
Hi Sakari, On 09/27/2011 10:58 PM, Sakari Ailus wrote: > On Tue, Sep 27, 2011 at 11:55:32PM +0300, Sakari Ailus wrote: >> Sylwester Nawrocki wrote: >>> Hello Sakari, >> >> Hi Sylwester, > > What I forgot to ask was whether there is a public datasheet for this > sensor? Unfortunately I'm not awar

Re: [PATCH v2 2/2] v4l: Add v4l2 subdev driver for S5K6AAFX sensor

2011-09-27 Thread Sakari Ailus
On Tue, Sep 27, 2011 at 11:55:32PM +0300, Sakari Ailus wrote: > Sylwester Nawrocki wrote: > > Hello Sakari, > > Hi Sylwester, What I forgot to ask was whether there is a public datasheet for this sensor? Regards, -- Sakari Ailus e-mail: sakari.ai...@iki.fi jabber/XMPP/Gmail: sai...@retiisi

Re: [PATCH v2 2/2] v4l: Add v4l2 subdev driver for S5K6AAFX sensor

2011-09-27 Thread Sakari Ailus
Sylwester Nawrocki wrote: > Hello Sakari, Hi Sylwester, > On 09/25/2011 12:08 PM, Sakari Ailus wrote: >> On Fri, Sep 23, 2011 at 12:12:58PM +0200, Sylwester Nawrocki wrote: >>> On 09/23/2011 12:02 AM, Sakari Ailus wrote: Hi Sylwester, I have a few additional comments below, they do

Re: [PATCH v2 2/2] v4l: Add v4l2 subdev driver for S5K6AAFX sensor

2011-09-27 Thread Sylwester Nawrocki
On 09/27/2011 09:14 AM, Hans Verkuil wrote: > On Monday, September 26, 2011 23:49:56 Sylwester Nawrocki wrote: >> Hi Hans, >> >> thanks for the comments. It's good to see you back, this mailing list >> had been much more quiet when you've been away for a while;) >> I hope everything got well for yo

Re: [PATCH v2 2/2] v4l: Add v4l2 subdev driver for S5K6AAFX sensor

2011-09-27 Thread Hans Verkuil
On Monday, September 26, 2011 23:49:56 Sylwester Nawrocki wrote: > Hi Hans, > > thanks for the comments. It's good to see you back, this mailing list > had been much more quiet when you've been away for a while;) > I hope everything got well for you. > > On 09/26/2011 03:21 PM, Hans Verkuil wrote

Re: [PATCH v2 2/2] v4l: Add v4l2 subdev driver for S5K6AAFX sensor

2011-09-26 Thread Sylwester Nawrocki
Hi Hans, thanks for the comments. It's good to see you back, this mailing list had been much more quiet when you've been away for a while;) I hope everything got well for you. On 09/26/2011 03:21 PM, Hans Verkuil wrote: > On Wednesday, September 21, 2011 19:45:07 Sylwester Nawrocki wrote: >> This

Re: [PATCH v2 2/2] v4l: Add v4l2 subdev driver for S5K6AAFX sensor

2011-09-26 Thread Hans Verkuil
On Wednesday, September 21, 2011 19:45:07 Sylwester Nawrocki wrote: > This driver exposes preview mode operation of the S5K6AAFX sensor with > embedded SoC ISP. It uses one of the five user predefined configuration > register sets. There is yet no support for capture (snapshot) operation. > Followi

Re: [PATCH v2 2/2] v4l: Add v4l2 subdev driver for S5K6AAFX sensor

2011-09-25 Thread Sylwester Nawrocki
Hello Sakari, On 09/25/2011 12:08 PM, Sakari Ailus wrote: > On Fri, Sep 23, 2011 at 12:12:58PM +0200, Sylwester Nawrocki wrote: >> On 09/23/2011 12:02 AM, Sakari Ailus wrote: >>> Hi Sylwester, >>> >>> I have a few additional comments below, they don't depend on my earlier >>> ones. >> >> Thanks a

Re: [PATCH v2 2/2] v4l: Add v4l2 subdev driver for S5K6AAFX sensor

2011-09-25 Thread Sakari Ailus
On Fri, Sep 23, 2011 at 12:12:58PM +0200, Sylwester Nawrocki wrote: > Hi Sakari, Hi Sylwester, > On 09/23/2011 12:02 AM, Sakari Ailus wrote: > > Hi Sylwester, > > > > I have a few additional comments below, they don't depend on my earlier > > ones. > > Thanks a lot for your follow up review! >

Re: [PATCH v2 2/2] v4l: Add v4l2 subdev driver for S5K6AAFX sensor

2011-09-23 Thread Sylwester Nawrocki
Hi Sakari, On 09/23/2011 12:02 AM, Sakari Ailus wrote: > Hi Sylwester, > > I have a few additional comments below, they don't depend on my earlier > ones. Thanks a lot for your follow up review! > > On Wed, Sep 21, 2011 at 07:45:07PM +0200, Sylwester Nawrocki wrote: >> This driver exposes prev

Re: [PATCH v2 2/2] v4l: Add v4l2 subdev driver for S5K6AAFX sensor

2011-09-22 Thread Sakari Ailus
Hi Sylwester, I have a few additional comments below, they don't depend on my earlier ones. On Wed, Sep 21, 2011 at 07:45:07PM +0200, Sylwester Nawrocki wrote: > This driver exposes preview mode operation of the S5K6AAFX sensor with > embedded SoC ISP. It uses one of the five user predefined conf

[PATCH v2 2/2] v4l: Add v4l2 subdev driver for S5K6AAFX sensor

2011-09-21 Thread Sylwester Nawrocki
This driver exposes preview mode operation of the S5K6AAFX sensor with embedded SoC ISP. It uses one of the five user predefined configuration register sets. There is yet no support for capture (snapshot) operation. Following controls are supported: manual/auto exposure and gain, power line frequen