Re: [PATCH 2/5] pcm990 baseboard: add camera bus width switch setting

2009-04-14 Thread Sascha Hauer
On Tue, Apr 14, 2009 at 11:53:54AM +0200, Guennadi Liakhovetski wrote: > On Tue, 14 Apr 2009, Sascha Hauer wrote: > > > On Tue, Apr 14, 2009 at 11:20:03AM +0200, Guennadi Liakhovetski wrote: > > > > > > If you don't object, I'll just add a .free_bus method to soc_camera_link, > > > and switch pc

Re: [PATCH 2/5] pcm990 baseboard: add camera bus width switch setting

2009-04-14 Thread Guennadi Liakhovetski
On Tue, 14 Apr 2009, Sascha Hauer wrote: > On Tue, Apr 14, 2009 at 11:20:03AM +0200, Guennadi Liakhovetski wrote: > > > > If you don't object, I'll just add a .free_bus method to soc_camera_link, > > and switch pcm990 to only use two values: a negative value for a > > non-allocated gpio - eithe

Re: [PATCH 2/5] pcm990 baseboard: add camera bus width switch setting

2009-04-14 Thread Sascha Hauer
On Tue, Apr 14, 2009 at 11:20:03AM +0200, Guennadi Liakhovetski wrote: > On Tue, 14 Apr 2009, Sascha Hauer wrote: > > > On Tue, Apr 14, 2009 at 10:57:32AM +0200, Guennadi Liakhovetski wrote: > > > On Thu, 9 Apr 2009, Guennadi Liakhovetski wrote: > > [snip] > > > > > > +static unsigned long pcm99

Re: [PATCH 2/5] pcm990 baseboard: add camera bus width switch setting

2009-04-14 Thread Guennadi Liakhovetski
On Tue, 14 Apr 2009, Sascha Hauer wrote: > On Tue, Apr 14, 2009 at 10:57:32AM +0200, Guennadi Liakhovetski wrote: > > On Thu, 9 Apr 2009, Guennadi Liakhovetski wrote: [snip] > > > > +static unsigned long pcm990_camera_query_bus_param(struct > > > > soc_camera_link *link) > > > > +{ > > > > +

Re: [PATCH 2/5] pcm990 baseboard: add camera bus width switch setting

2009-04-14 Thread Sascha Hauer
On Tue, Apr 14, 2009 at 10:57:32AM +0200, Guennadi Liakhovetski wrote: > On Thu, 9 Apr 2009, Guennadi Liakhovetski wrote: > > > Hi Sascha, > > > > something, that skipped both of us: > > ...and one more: > > > On Thu, 12 Mar 2009, Sascha Hauer wrote: > > > > > Some Phytec cameras have a I2C GP

Re: [PATCH 2/5] pcm990 baseboard: add camera bus width switch setting

2009-04-14 Thread Guennadi Liakhovetski
On Thu, 9 Apr 2009, Guennadi Liakhovetski wrote: > Hi Sascha, > > something, that skipped both of us: ...and one more: > On Thu, 12 Mar 2009, Sascha Hauer wrote: > > > Some Phytec cameras have a I2C GPIO expander which allows it to > > switch between different sensor bus widths. This was previ

Re: [PATCH 2/5] pcm990 baseboard: add camera bus width switch setting

2009-04-09 Thread Guennadi Liakhovetski
Hi Sascha, something, that skipped both of us: On Thu, 12 Mar 2009, Sascha Hauer wrote: > Some Phytec cameras have a I2C GPIO expander which allows it to > switch between different sensor bus widths. This was previously > handled in the camera driver. Since handling of this switch > varies on se

Re: [PATCH 2/5] pcm990 baseboard: add camera bus width switch setting

2009-03-12 Thread Sascha Hauer
On Thu, Mar 12, 2009 at 08:11:27PM +0100, Guennadi Liakhovetski wrote: > ...one more thing. I noticed, that after patch 2 the cameras would stop > work, because iclink->gpio would be set to 0. Which would break bisection. > Ok, this is rather theoretical, still I modified the patches a bit. > Pl

Re: [PATCH 2/5] pcm990 baseboard: add camera bus width switch setting

2009-03-12 Thread Guennadi Liakhovetski
...one more thing. I noticed, that after patch 2 the cameras would stop work, because iclink->gpio would be set to 0. Which would break bisection. Ok, this is rather theoretical, still I modified the patches a bit. Please, have a look, if you're ok with these changes, that's how I'm going to co

Re: [PATCH 2/5] pcm990 baseboard: add camera bus width switch setting

2009-03-12 Thread Sascha Hauer
ost drivers ;) Ok, changed it to support only ten bit without gpio switch and return -EINVAL for any other width. Sasche >From 58485f136579273d4da41d65974ce6ed02ba877a Mon Sep 17 00:00:00 2001 From: Sascha Hauer Date: Tue, 10 Mar 2009 16:45:58 +0100 Subject: [PATCH 2/5] pcm990 baseboard: ad

Re: [PATCH 2/5] pcm990 baseboard: add camera bus width switch setting

2009-03-12 Thread Guennadi Liakhovetski
On Thu, 12 Mar 2009, Sascha Hauer wrote: > Some Phytec cameras have a I2C GPIO expander which allows it to > switch between different sensor bus widths. This was previously > handled in the camera driver. Since handling of this switch > varies on several boards the cameras are used on, the board >

[PATCH 2/5] pcm990 baseboard: add camera bus width switch setting

2009-03-12 Thread Sascha Hauer
Some Phytec cameras have a I2C GPIO expander which allows it to switch between different sensor bus widths. This was previously handled in the camera driver. Since handling of this switch varies on several boards the cameras are used on, the board support seems a better place to handle the switch