On Tue, 14 Apr 2009, Sascha Hauer wrote: > On Tue, Apr 14, 2009 at 11:20:03AM +0200, Guennadi Liakhovetski wrote: > > > > If you don't object, I'll just add a .free_bus method to soc_camera_link, > > and switch pcm990 to only use two values: a negative value for a > > non-allocated gpio - either before the first attempt or after an error, > > thus re-trying every time if gpio is negative, in case a driver has been > > loaded in the meantime. > > For the sake of symmetry, shouldn't we have an init function aswell?
Well, for the sake of symmetry - yes, but I'm not sure we want to bloat this simple API further just to make it symmetric... You think it's worth it? Or do you have any "practical" reasons for that? Of course, we could also add a void *bus_resource to soc_camera_link and get rid of the static gpio_bus_switch and allocate it dynamically in .bus_init and free it in .bus_release, but... Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
