Re: [PATCH 2/4] pcm990 baseboard: add camera bus width switch setting

2009-03-12 Thread Sascha Hauer
On Thu, Mar 12, 2009 at 10:25:35AM +0100, Guennadi Liakhovetski wrote: > On Thu, 12 Mar 2009, Sascha Hauer wrote: > > > On Thu, Mar 12, 2009 at 09:40:46AM +0100, Guennadi Liakhovetski wrote: > > > One more thing I noticed while looking at your patch 3/4: > > > > > > > +static int pcm990_camera_se

Re: [PATCH 2/4] pcm990 baseboard: add camera bus width switch setting

2009-03-12 Thread Guennadi Liakhovetski
On Thu, 12 Mar 2009, Sascha Hauer wrote: > On Thu, Mar 12, 2009 at 09:40:46AM +0100, Guennadi Liakhovetski wrote: > > One more thing I noticed while looking at your patch 3/4: > > > > > +static int pcm990_camera_set_bus_param(struct device *dev, > > > + unsigned long flags) > > > +{ > > >

Re: [PATCH 2/4] pcm990 baseboard: add camera bus width switch setting

2009-03-12 Thread Sascha Hauer
On Thu, Mar 12, 2009 at 09:40:46AM +0100, Guennadi Liakhovetski wrote: > One more thing I noticed while looking at your patch 3/4: > > > +static int pcm990_camera_set_bus_param(struct device *dev, > > + unsigned long flags) > > +{ > > + if (gpio_bus_switch <= 0) > > + return

Re: [PATCH 2/4] pcm990 baseboard: add camera bus width switch setting

2009-03-12 Thread Guennadi Liakhovetski
One more thing I noticed while looking at your patch 3/4: > +static int pcm990_camera_set_bus_param(struct device *dev, > + unsigned long flags) > +{ > + if (gpio_bus_switch <= 0) > + return 0; > + > + if (flags & SOCAM_DATAWIDTH_8) > + gpio_set_value(NR

Re: [PATCH 2/4] pcm990 baseboard: add camera bus width switch setting

2009-03-12 Thread Sascha Hauer
On Thu, Mar 12, 2009 at 09:31:55AM +0100, Guennadi Liakhovetski wrote: > On Wed, 11 Mar 2009, Sascha Hauer wrote: > > > Some Phytec cameras have a I2C GPIO expander which allows it to > > switch between different sensor bus widths. This was previously > > handled in the camera driver. Since handli

Re: [PATCH 2/4] pcm990 baseboard: add camera bus width switch setting

2009-03-12 Thread Guennadi Liakhovetski
On Wed, 11 Mar 2009, Sascha Hauer wrote: > Some Phytec cameras have a I2C GPIO expander which allows it to > switch between different sensor bus widths. This was previously > handled in the camera driver. Since handling of this switch > varies on several boards the cameras are used on, the board >

[PATCH 2/4] pcm990 baseboard: add camera bus width switch setting

2009-03-11 Thread Sascha Hauer
Some Phytec cameras have a I2C GPIO expander which allows it to switch between different sensor bus widths. This was previously handled in the camera driver. Since handling of this switch varies on several boards the cameras are used on, the board support seems a better place to handle the switch