From: Edgar Thier
Use flags the device exposes for UVC controls.
This allows the device to define which property flags are set.
Since some cameras offer auto-adjustments for properties (e.g. auto-gain),
the values of other properties (e.g. gain) can change in the camera.
Examining the flags ensu
Hi Edgar,
On Wednesday, 3 January 2018 08:07:44 EET Edgar Thier wrote:
> Hi Emmanuel,
If we pick names randomly I'll call you David :-)
> >>> + int flags = 0;
> >>> +
> >>> + data = kmalloc(2, GFP_KERNEL);
> >
> > Isn't 1 byte enough ?
>
> To quote from Kieran further up this thread:
>
> >> k
Hi Emmanuel,
>>> + int flags = 0;
>>> +
>>> + data = kmalloc(2, GFP_KERNEL);
>
> Isn't 1 byte enough ?
>
To quote from Kieran further up this thread:
>> kmalloc seems a bit of an overhead for 2 bytes (only one of which is used).
>> Can this use local stack storage?
>>
>> (Laurent, looks lik
Hi Edgar,
A few more comments.
On Tuesday, 2 January 2018 22:07:24 EET Laurent Pinchart wrote:
> On Thursday, 12 October 2017 10:54:17 EET Edgar Thier wrote:
> > Use flags the device exposes for UVC controls.
> > This allows the device to define which property flags are set.
> >
> > Since some c
Hi Edgar,
Thank you for the patch.
On Thursday, 12 October 2017 10:54:17 EET Edgar Thier wrote:
> Use flags the device exposes for UVC controls.
> This allows the device to define which property flags are set.
>
> Since some cameras offer auto-adjustments for properties (e.g. auto-gain),
> the v
Hi,
Another month, another mail. Are there still issues keeping this from being
merged?
Regards,
Edgar
On 11/15/2017 12:54 PM, Kieran Bingham wrote:
> Hi Edgar,
>
> Thanks for addressing my concerns in this updated patch.
>
> On 12/10/17 08:54, Edgar Thier wrote:
>>
>> Use flags the device e
Hi Kieran,
> I think it's easier to see updated patches if they are posted as a new thread,
> with an increased version number. [PATCH v2], [PATCH v3] etc...
>
> Not a problem now - but might help your updated patches get seen next time.
I will keep that in mind for next time. :)
> Looks like my
Hi Edgar,
Thanks for addressing my concerns in this updated patch.
On 12/10/17 08:54, Edgar Thier wrote:
>
> Use flags the device exposes for UVC controls.
> This allows the device to define which property flags are set.
>
> Since some cameras offer auto-adjustments for properties (e.g. auto-ga
Hi Edgar,
On 15/11/17 08:11, Edgar Thier wrote:
> Hi,
>
> I was wondering if there are any problems with my latest patch or if it
> simply slipped through.
Slipped though in high mail volumes :)
I think it's easier to see updated patches if they are posted as a new thread,
with an increased ve
Hi,
I was wondering if there are any problems with my latest patch or if it simply
slipped through.
Regards,
Edgar
On 10/12/2017 09:54 AM, Edgar Thier wrote:
>
> Use flags the device exposes for UVC controls.
> This allows the device to define which property flags are set.
>
> Since some cam
Use flags the device exposes for UVC controls.
This allows the device to define which property flags are set.
Since some cameras offer auto-adjustments for properties (e.g. auto-gain),
the values of other properties (e.g. gain) can change in the camera.
Examining the flags ensures that the driver
Hi Edgar,
Sorry for not replying to you yesterday on IRC, but by the time I got to reply
to the message you weren't online..
On 11/10/17 12:56, Edgar Thier wrote:
>
> Use flags the device exposes for UVC controls.
> This allows the device to define which property flags are set.
>
> Since some c
Use flags the device exposes for UVC controls.
This allows the device to define which property flags are set.
Since some cameras offer auto-adjustments for properties (e.g. auto-gain),
the values of other properties (e.g. gain) can change in the camera.
Examining the flags ensures that the driver
Hi Edgar,
Thank you for the patch respin.
I'm still a bit concerned about that -ENOMEM though:
On 06/10/17 11:34, Edgar Thier wrote:
>
> Use flags the device exposes for UVC controls.
> This allows the device to define which property flags are set.
>
> Since some cameras offer auto-adjustments
Hi Kieran,
> Rather than forward declaring the function ... Could you put the function
> higher
> in the module please?
Will do. Patch will come as a reply shortly.
>>> + if (data == NULL)
>>> + return -ENOMEM;
>>
>> This will set the callers 'flags' to -ENOMEM ? Is that desired?
>
Use flags the device exposes for UVC controls.
This allows the device to define which property flags are set.
Since some cameras offer auto-adjustments for properties (e.g. auto-gain),
the values of other properties (e.g. gain) can change in the camera.
Examining the flags ensures that the driver
Hi Edgar,
On 05/10/17 10:43, Kieran Bingham wrote:
> Hi Edgar,
>
> On 18/08/17 11:12, Edgar Thier wrote:
>>
>> Use flags the device exposes for UVC controls.
>> This allows the device to define which property flags are set.
>>
>> Since some cameras offer auto-adjustments for properties (e.g. auto
Hi Edgar,
On 18/08/17 11:12, Edgar Thier wrote:
>
> Use flags the device exposes for UVC controls.
> This allows the device to define which property flags are set.
>
> Since some cameras offer auto-adjustments for properties (e.g. auto-gain),
> the values of other properties (e.g. gain) can chan
Hi all,
I was wondering if there are any problems with my latest patch or if it simply
slipped through.
Feedback would be welcome.
Regards,
Edgar
On 08/18/2017 12:12 PM, Edgar Thier wrote:
>
> Use flags the device exposes for UVC controls.
> This allows the device to define which property fla
Use flags the device exposes for UVC controls.
This allows the device to define which property flags are set.
Since some cameras offer auto-adjustments for properties (e.g. auto-gain),
the values of other properties (e.g. gain) can change in the camera.
Examining the flags ensures that the driver
Hi Edgar,
Thank you for the patch.
On Tuesday 15 Aug 2017 12:59:47 Edgar Thier wrote:
> Use flags the device exposes for UVC controls.
In addition to explaining what the patch does, the commit message should
explain why the change is needed. What is the problem you're trying to address
here ?
Use flags the device exposes for UVC controls.
Signed-off-by: Edgar Thier
---
drivers/media/usb/uvc/uvc_ctrl.c | 26 +-
1 file changed, 25 insertions(+), 1 deletion(-)
diff --git a/drivers/media/usb/uvc/uvc_ctrl.c b/drivers/media/usb/uvc/uvc_ctrl.c
index c2ee6e3..bc69e92
22 matches
Mail list logo
