Fwd: Re: [PATCH] fix lock imbalances in /drivers/media/video/cafe_ccic.c

2009-09-11 Thread iceberg
On Thu, Sep 10, 2009 at 09:30:03AM -0600, Jonathan Corbet wrote: > On Thu, 10 Sep 2009 18:37:34 + > iceberg wrote: > > > In ./drivers/media/video/cafe_ccic.c, in function cafe_pci_probe: > > Mutex must be unlocked before exit > > 1. On paths starting with mutex lock in line 1912, then co

Re: [PATCH] fix lock imbalances in /drivers/media/video/cafe_ccic.c

2009-09-11 Thread iceberg
On Thursday 10 September 2009 15:30:03 you wrote: Incorrect patch. See path starting with "if (cam->sensor == null) {" in line 1960. In this case we goto out_smbs and try mutex_unlock on unlocking mutex. > On Thu, 10 Sep 2009 18:37:34 + > > iceberg wrote: > > In ./drivers/media/vid

Re: [PATCH] fix lock imbalances in /drivers/media/video/cafe_ccic.c

2009-09-10 Thread Steven Rostedt
On Thu, Sep 10, 2009 at 09:30:03AM -0600, Jonathan Corbet wrote: > On Thu, 10 Sep 2009 18:37:34 + > iceberg wrote: > > > In ./drivers/media/video/cafe_ccic.c, in function cafe_pci_probe: > > Mutex must be unlocked before exit > > 1. On paths starting with mutex lock in line 1912, then co

Re: [PATCH] fix lock imbalances in /drivers/media/video/cafe_ccic.c

2009-09-10 Thread Jonathan Corbet
On Thu, 10 Sep 2009 18:37:34 + iceberg wrote: > In ./drivers/media/video/cafe_ccic.c, in function cafe_pci_probe: > Mutex must be unlocked before exit > 1. On paths starting with mutex lock in line 1912, then continuing in > lines: > 1929, 1936 (goto unreg) and 1940 (goto iounmap) .

Re: Re: [PATCH] fix lock imbalances in /drivers/media/video/cafe_ccic.c

2009-09-10 Thread iceberg
In ./drivers/media/video/cafe_ccic.c, in function cafe_pci_probe: Mutex must be unlocked before exit 1. On paths starting with mutex lock in line 1912, then continuing in lines: 1929, 1936 (goto unreg) and 1940 (goto iounmap) . 2. On path starting in line 1971 mutex lock, and th

[PATCH] fix lock imbalances in /drivers/media/video/cafe_ccic.c

2009-09-10 Thread iceberg
In ./drivers/media/video/cafe_ccic.c, in function cafe_pci_probe: Mutex must be unlocked before exit 1. On paths starting with mutex lock in line 1912, then continuing in lines: 1929, 1936 (goto unreg) and 1940 (goto iounmap) . 2. On path starting in line 1971 mutex lock, and th

Re: [PATCH] fix lock imbalances in /drivers/media/video/cafe_ccic.c

2009-09-10 Thread Daniel Walker
On Thu, 2009-09-10 at 18:37 +, iceberg wrote: > In ./drivers/media/video/cafe_ccic.c, in function cafe_pci_probe: > Mutex must be unlocked before exit > 1. On paths starting with mutex lock in line 1912, then continuing in > lines: > 1929, 1936 (goto unreg) and 1940 (goto iounmap) . >