Re: [PATCH/RFC] media: vb2: change queue initialization order

2011-08-23 Thread Hans Verkuil
On Tuesday, August 23, 2011 12:14:17 Marek Szyprowski wrote: > Hello, > > On Tuesday, August 23, 2011 12:11 PM Hans Verkuil wrote: > > > Are you planning a RFCv2 for this? > > > > I've been implementing vb2 in an internal driver and this initialization > > order of vb2 is a bit of a pain to be h

RE: [PATCH/RFC] media: vb2: change queue initialization order

2011-08-23 Thread Marek Szyprowski
Hello, On Tuesday, August 23, 2011 12:11 PM Hans Verkuil wrote: > Are you planning a RFCv2 for this? > > I've been implementing vb2 in an internal driver and this initialization > order of vb2 is a bit of a pain to be honest. (snipped) Yes, I will post it till the end of the week. I'm sorry fo

Re: [PATCH/RFC] media: vb2: change queue initialization order

2011-08-23 Thread Hans Verkuil
Hi Marek, Are you planning a RFCv2 for this? I've been implementing vb2 in an internal driver and this initialization order of vb2 is a bit of a pain to be honest. Regards, Hans On Wednesday, June 29, 2011 11:49:06 Marek Szyprowski wrote: > This patch introduces VB2_STREAMON_WITHOUT_BU

Re: [PATCH/RFC] media: vb2: change queue initialization order

2011-07-24 Thread Pawel Osciak
Hi Jon and Marek, On Thu, Jun 30, 2011 at 15:18, Jonathan Corbet wrote: > On Wed, 29 Jun 2011 16:10:45 +0200 > Marek Szyprowski wrote: > >> > I do still wonder why this is an issue - why not pass the buffers through >> > to the driver at VIDIOC_QBUF time?  I assume there must be a reason for >>

RE: [PATCH/RFC] media: vb2: change queue initialization order

2011-07-06 Thread Marek Szyprowski
Hello, On Friday, July 01, 2011 12:18 AM Jonathan Corbet wrote: > On Wed, 29 Jun 2011 16:10:45 +0200 > Marek Szyprowski wrote: > > > > I do still wonder why this is an issue - why not pass the buffers > through > > > to the driver at VIDIOC_QBUF time? I assume there must be a reason for > > >

Re: [PATCH/RFC] media: vb2: change queue initialization order

2011-06-30 Thread Jonathan Corbet
On Wed, 29 Jun 2011 16:10:45 +0200 Marek Szyprowski wrote: > > I do still wonder why this is an issue - why not pass the buffers through > > to the driver at VIDIOC_QBUF time? I assume there must be a reason for > > doing things this way, I'd like to understand what it is. > > I want to delay

RE: [PATCH/RFC] media: vb2: change queue initialization order

2011-06-29 Thread Marek Szyprowski
Hello, On Wednesday, June 29, 2011 3:26 PM wrote: > On Wed, 29 Jun 2011 11:49:06 +0200 > Marek Szyprowski wrote: > > > This patch introduces VB2_STREAMON_WITHOUT_BUFFERS io flag and changes > > the order of operations during stream on operation. Now the buffer are > > first queued to the driver

Re: [PATCH/RFC] media: vb2: change queue initialization order

2011-06-29 Thread Jonathan Corbet
On Wed, 29 Jun 2011 11:49:06 +0200 Marek Szyprowski wrote: > This patch introduces VB2_STREAMON_WITHOUT_BUFFERS io flag and changes > the order of operations during stream on operation. Now the buffer are > first queued to the driver and then the start_streaming method is called. Thanks for addr

RE: [PATCH/RFC] media: vb2: change queue initialization order

2011-06-29 Thread Marek Szyprowski
Hello, On Wednesday, June 29, 2011 1:02 PM Hans Verkuil wrote: > On Wednesday, June 29, 2011 12:44:48 Laurent Pinchart wrote: > > Hi Marek, > > > > On Wednesday 29 June 2011 11:49:06 Marek Szyprowski wrote: > > > This patch introduces VB2_STREAMON_WITHOUT_BUFFERS io flag and changes > > > the ord

RE: [PATCH/RFC] media: vb2: change queue initialization order

2011-06-29 Thread Marek Szyprowski
Hello, On Wednesday, June 29, 2011 1:15 PM Hans Verkuil wrote: > On Wednesday, June 29, 2011 11:49:06 Marek Szyprowski wrote: > > This patch introduces VB2_STREAMON_WITHOUT_BUFFERS io flag and changes > > the order of operations during stream on operation. Now the buffer are > > first queued to t

Re: [PATCH/RFC] media: vb2: change queue initialization order

2011-06-29 Thread Hans Verkuil
On Wednesday, June 29, 2011 11:49:06 Marek Szyprowski wrote: > This patch introduces VB2_STREAMON_WITHOUT_BUFFERS io flag and changes > the order of operations during stream on operation. Now the buffer are > first queued to the driver and then the start_streaming method is called. > This resolves

Re: [PATCH/RFC] media: vb2: change queue initialization order

2011-06-29 Thread Hans Verkuil
On Wednesday, June 29, 2011 12:44:48 Laurent Pinchart wrote: > Hi Marek, > > On Wednesday 29 June 2011 11:49:06 Marek Szyprowski wrote: > > This patch introduces VB2_STREAMON_WITHOUT_BUFFERS io flag and changes > > the order of operations during stream on operation. Now the buffer are > > first qu

RE: [PATCH/RFC] media: vb2: change queue initialization order

2011-06-29 Thread Marek Szyprowski
Hello, On Wednesday, June 29, 2011 12:45 PM Laurent Pinchart wrote: > On Wednesday 29 June 2011 11:49:06 Marek Szyprowski wrote: > > This patch introduces VB2_STREAMON_WITHOUT_BUFFERS io flag and changes > > the order of operations during stream on operation. Now the buffer are > > first queued t

Re: [PATCH/RFC] media: vb2: change queue initialization order

2011-06-29 Thread Laurent Pinchart
Hi Marek, On Wednesday 29 June 2011 11:49:06 Marek Szyprowski wrote: > This patch introduces VB2_STREAMON_WITHOUT_BUFFERS io flag and changes > the order of operations during stream on operation. Now the buffer are > first queued to the driver and then the start_streaming method is called. > This

[PATCH/RFC] media: vb2: change queue initialization order

2011-06-29 Thread Marek Szyprowski
This patch introduces VB2_STREAMON_WITHOUT_BUFFERS io flag and changes the order of operations during stream on operation. Now the buffer are first queued to the driver and then the start_streaming method is called. This resolves the most common case when the driver needs to know buffer addresses t