On Wed, 29 Jun 2011 11:49:06 +0200 Marek Szyprowski <m.szyprow...@samsung.com> wrote:
> This patch introduces VB2_STREAMON_WITHOUT_BUFFERS io flag and changes > the order of operations during stream on operation. Now the buffer are > first queued to the driver and then the start_streaming method is called. Thanks for addressing this. But I do have to wonder if this flag is really necessary. The effort to set a "they want to start streaming" flag and start things for real in buf_queue() is not *that* great; if doing so avoids causing failures in applications which are following the rules, it seems worth it. > /* > + * If any buffers were queued before streamon, > + * we can now pass them to driver for processing. > + */ > + list_for_each_entry(vb, &q->queued_list, queued_entry) > + __enqueue_in_driver(vb); > + > + /* > * Let driver notice that streaming state has been enabled. > */ > ret = call_qop(q, start_streaming, q); I do still wonder why this is an issue - why not pass the buffers through to the driver at VIDIOC_QBUF time? I assume there must be a reason for doing things this way, I'd like to understand what it is. Thanks, jon -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
