Hi,
On Tue, Jul 23, 2019 at 12:58:54PM +0200, Hans Verkuil wrote:
> On 7/23/19 11:48 AM, Pali Rohár wrote:
> > On Tuesday 23 July 2019 11:09:53 Pavel Machek wrote:
> >> On Tue 2019-07-23 10:51:52, Hans Verkuil wrote:
> >>> This staging driver is now almost 6 years old, but hasn't seen any real
> >
Hi,
On Sat, Dec 22, 2018 at 09:08:28PM +0100, Pavel Machek wrote:
> Merry Christmas!
>
> > This moves all remaining users of the legacy TI_ST driver to hcill (patches
> > 1-3). Then patches 4-7 convert wl128x-radio driver to a standard platform
> > device driver with support for multiple instance
Hi Pavel,
On Sat, Dec 22, 2018 at 08:29:34PM +0100, Pavel Machek wrote:
> On Fri 2018-12-21 02:17:48, Sebastian Reichel wrote:
> > From: Sebastian Reichel
> >
> > Remove unused return code from fmc_prepare() and fmc_release() to
> > simplify the code a bit.
>
&g
Hi Marcel,
First of all thanks for your review.
On Sun, Dec 23, 2018 at 04:56:47PM +0100, Marcel Holtmann wrote:
> Hi Sebastian,
[...]
> > +static int ll_register_fm(struct ll_device *lldev)
> > +{
> > + struct device *dev = &lldev->serdev->dev;
> > + int err;
> > +
> > + if (!of_device_i
Hi,
On Fri, Dec 21, 2018 at 03:10:52PM -0600, Adam Ford wrote:
> On Fri, Dec 21, 2018 at 2:13 AM Sebastian Reichel wrote:
> >
> > From: Sebastian Reichel
> >
> > This driver has been superseded by the serdev based Bluetooth
> > hci_ll driver, which is initia
Hi,
On Fri, Dec 21, 2018 at 10:02:05AM -0800, Tony Lindgren wrote:
> * Sebastian Reichel [181221 01:18]:
> > The new code has been tested on the Motorola Droid 4. For testing the audio
> > should be configured to route Ext to Speaker or Headphone. Then you need to
> > plug
From: Sebastian Reichel
Move global radio_disconnected into device structure to
prepare converting this driver into a normal platform
device driver supporting multiple instances.
Signed-off-by: Sebastian Reichel
---
drivers/media/radio/wl128x/fmdrv.h | 1 +
drivers/media/radio/wl128x
From: Sebastian Reichel
Drop module version. We already have the kernel's version and
this module is mainline.
Signed-off-by: Sebastian Reichel
---
drivers/media/radio/wl128x/fmdrv.h| 1 -
drivers/media/radio/wl128x/fmdrv_common.c | 5 ++---
2 files changed, 2 insertions(
From: Sebastian Reichel
Add a node for the UART part of WiLink chip.
Cc: Enric Balletbo i Serra
Signed-off-by: Sebastian Reichel
---
This is compile tested only!
---
arch/arm/boot/dts/omap3-igep0020-rev-f.dts | 8
arch/arm/boot/dts/omap3-igep0030-rev-g.dts | 8
2 files
From: Sebastian Reichel
All TI_ST users have been migrated to the new serdev based HCILL
bluetooth driver. That driver is initialized from DT and does not
need any platform quirks.
Signed-off-by: Sebastian Reichel
---
arch/arm/mach-omap2/pdata-quirks.c | 52 --
1
From: Sebastian Reichel
This driver has been superseded by the serdev based Bluetooth
hci_ll driver, which is initialized from DT. All mainline users
have been converted and this driver can be safely dropped.
Signed-off-by: Sebastian Reichel
---
drivers/misc/Kconfig | 1 -
drivers
From: Sebastian Reichel
Remove unused return code from fmc_prepare() and fmc_release() to
simplify the code a bit.
Signed-off-by: Sebastian Reichel
---
drivers/media/radio/wl128x/fmdrv_common.c | 26 +--
drivers/media/radio/wl128x/fmdrv_common.h | 4 ++--
drivers/media
From: Sebastian Reichel
This fixes incorrect code in the TX/RX skb debug print
function and add stubs in receive/transmit packet path.
Signed-off-by: Sebastian Reichel
---
drivers/media/radio/wl128x/fmdrv_common.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git
From: Sebastian Reichel
Move global radio_dev into device structure to prepare converting
this driver into a normal platform device driver supporting multiple
instances.
Signed-off-by: Sebastian Reichel
---
drivers/media/radio/wl128x/fmdrv.h| 2 +-
drivers/media/radio/wl128x
From: Sebastian Reichel
All users of this driver have been converted to the serdev based
hci_ll driver. The unused driver can be safely dropped now.
Signed-off-by: Sebastian Reichel
---
drivers/bluetooth/Kconfig| 11 --
drivers/bluetooth/Makefile | 1 -
drivers/bluetooth/btwilink.c
From: Sebastian Reichel
This converts the wl128x FM radio module into a platform device.
It's a preparation for using it from hci_ll Bluetooth driver instead
of TI_ST.
Signed-off-by: Sebastian Reichel
---
drivers/media/radio/wl128x/fmdrv_common.c | 30 ---
1 file ch
From: Sebastian Reichel
This simplifies memory allocation and removes a few useless
errors in case of -ENOMEM errors.
Signed-off-by: Sebastian Reichel
---
drivers/media/radio/wl128x/fmdrv_common.c | 41 +++
1 file changed, 13 insertions(+), 28 deletions(-)
diff --git a
From: Sebastian Reichel
Add a node for the UART part of WiLink chip.
Cc: Adam Ford
Signed-off-by: Sebastian Reichel
---
This is compile tested only!
---
arch/arm/boot/dts/logicpd-torpedo-37xx-devkit.dts | 8
1 file changed, 8 insertions(+)
diff --git a/arch/arm/boot/dts/logicpd
ce initial get_frequency returns an error:
$ radio -f 100.0
Merry Christmas!
-- Sebastian
Sebastian Reichel (14):
ARM: dts: LogicPD Torpedo: Add WiLink UART node
ARM: dts: IGEP: Add WiLink UART node
ARM: OMAP2+: pdata-quirks: drop TI_ST/KIM support
media: wl128x-radio: remove module versi
From: Sebastian Reichel
All TI WiLink firmware files are loaded from the ti-connectivity
subdirectory, so let's also move the FM firmware.
Signed-off-by: Sebastian Reichel
---
drivers/media/radio/wl128x/fmdrv_common.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --
From: Sebastian Reichel
This updates the wl128x-radio driver to be used with hci_ll
instead of the deprecated TI_ST driver.
Signed-off-by: Sebastian Reichel
---
drivers/bluetooth/hci_ll.c| 115 --
drivers/media/radio/wl128x/Kconfig| 2 +-
drivers
772x_write(struct i2c_client *client, u8 addr, u8
> > value)
> > {
> > - return i2c_smbus_write_byte_data(client, addr, value);
> > + return sccb_write_byte(client, addr, value);
> > }
Reviewed-by: Sebastian Reichel
> Minor nit: I'd rather drop these t
ers.
>
> With the sccb_read_byte() that issues two separated requests in order to
> avoid repeated start, the driver doesn't require I2C_FUNC_PROTOCOL_MANGLING.
>
> Cc: Sebastian Reichel
> Cc: Wolfram Sang
> Cc: Jacopo Mondi
> Cc: Laurent Pinchart
> Cc: Hans Ve
Ailus
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> since v2.2:
>
> - Fix property name in code.
>
> .../devicetree/bindings/media/i2c/nokia,smia.txt | 2 ++
> drivers/media/i2c/smiapp/smiapp-core.c | 16
>
> 2 files chang
t
> order by setting both horizontal and vertical flipping.
>
> This patch documents the "rotation" property for camera sensors, mirroring
> what is defined for displays in
> Documentation/devicetree/bindings/display/panel/panel.txt .
>
> Signed-off-by: Sakari Ailu
Hi,
On Fri, May 25, 2018 at 03:27:26PM +0300, Sakari Ailus wrote:
> Use the "upside-down" property to tell that the sensor is mounted upside
> down. This reverses the behaviour of the VFLIP and HFLIP controls as well
> as the pixel order.
>
> Signed-off-by: Sakari Ailus
> ---
Patch subject and
Hi,
On Fri, Apr 27, 2018 at 01:13:32AM +0900, Akinobu Mita wrote:
> diff --git a/drivers/media/i2c/sccb.c b/drivers/media/i2c/sccb.c
> new file mode 100644
> index 000..80a3fb7
> --- /dev/null
> +++ b/drivers/media/i2c/sccb.c
> @@ -0,0 +1,35 @@
> +// SPDX-License-Identifier: GPL-2.0
> +
> +#in
Hi,
I just got the following error message every ms with 4.17-rc3 after
upgrading to for first ~192 seconds after system start (Debian
4.17~rc3-1~exp1 kernel) on my Thinkpad X250:
> uvcvideo: Failed to query (GET_MIN) UVC control 2 on unit 1: -32 (exp. 1).
I see /dev/video0 and /dev/video1. The
Hi,
On Thu, May 03, 2018 at 12:31:14AM +0300, Sakari Ailus wrote:
> Camera sensors are occasionally mounted upside down. In order to use such
> a sensor without having to turn every image upside down separately, most
> camera sensors support reversing the readout order by setting both
> horizontal
or flash and lens devices")
> Signed-off-by: Arnd Bergmann
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/media/i2c/et8ek8/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/i2c/et8ek8/Kconfig
> b/drivers/media/i2c/et8ek8/Kconfig
> i
Hi,
On Sun, Nov 12, 2017 at 12:27:29PM +0100, Pavel Machek wrote:
>
> Document dts support of LED/focus.
>
> Signed-off-by: Pavel Machek
Reviewed-by: Sebastian Reichel
-- Sebastian
> diff --git a/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt
> b/Docume
Hi,
On Wed, Nov 01, 2017 at 11:55:33AM +, Sean Young wrote:
> The ir-rx51 is a pwm-based TX driver specific to the n900. This can be
> handled entirely by the generic pwm-ir-tx driver.
>
> Note that the suspend code in the ir-rx51 driver is unnecessary, since
> during transmit, the current pr
used-but-set-variable]
>bool is_available;
> ^~~~
>
> Fixes: 9ca465312132 ("media: v4l: fwnode: Support generic parsing of graph
> endpoints in a device")
> Cc: Sakari Ailus
> Signed-off-by: Mauro Carvalho Chehab
> ---
Reviewed-by: Sebastian Reichel
-- S
Hi,
On Thu, Oct 26, 2017 at 10:53:42AM +0300, Sakari Ailus wrote:
> Add flash and indicator LED phandles to the sensor node.
>
> Signed-off-by: Sakari Ailus
> Acked-by: Hans Verkuil
> Acked-by: Pavel Machek
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> arch/
Hi,
On Thu, Oct 26, 2017 at 10:53:41AM +0300, Sakari Ailus wrote:
> Parse async sub-devices related to the sensor by switching the async
> sub-device registration function.
>
> Signed-off-by: Sakari Ailus
> Acked-by: Hans Verkuil
> ---
Reviewed-by: Sebastian Reichel
-- Seb
Hi,
On Thu, Oct 26, 2017 at 10:53:40AM +0300, Sakari Ailus wrote:
> Parse async sub-devices related to the sensor by switching the async
> sub-device registration function.
>
> Signed-off-by: Sakari Ailus
> Acked-by: Hans Verkuil
> ---
Reviewed-by: Sebastian Reichel
-- Seb
Hi,
On Thu, Oct 26, 2017 at 10:53:39AM +0300, Sakari Ailus wrote:
> Parse async sub-devices related to the sensor by switching the async
> sub-device registration function.
>
> Signed-off-by: Sakari Ailus
> Acked-by: Hans Verkuil
> Acked-by: Pavel Machek
> ---
Reviewed-
tion to do that.
>
> Signed-off-by: Sakari Ailus
> Acked-by: Hans Verkuil
> Acked-by: Pavel Machek
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/media/i2c/smiapp/smiapp-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/driver
Hi,
On Thu, Oct 26, 2017 at 10:53:37AM +0300, Sakari Ailus wrote:
> Document optional lens-focus and flash-leds properties for the smiapp
> driver.
>
> Signed-off-by: Sakari Ailus
> Acked-by: Hans Verkuil
> Acked-by: Pavel Machek
Reviewed-by: Sebastian Reic
This should be useful for sensor drivers that do not have device specific
> requirements related to firmware information parsing or the async
> framework.
>
> Signed-off-by: Sakari Ailus
> Acked-by: Hans Verkuil
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> driver
regular driver needs to
> know about these devices as such.
>
> Signed-off-by: Sakari Ailus
> Acked-by: Hans Verkuil
> Acked-by: Pavel Machek
Reviewd-by: Sebastian Reichel
-- Sebastian
> ---
> since v16:
>
> - use const char * const *props for string arrays wit
igned-off-by: Sakari Ailus
> Acked-by: Hans Verkuil
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> since v16:
>
> - use const char * const *props for string arrays with property names.
>
> drivers/media/v4l2-core/v4l2-fwnode.c | 287
>
-off-by: Sakari Ailus
> Acked-by: Hans Verkuil
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/media/v4l2-core/v4l2-fwnode.c | 69
> +++
> 1 file changed, 69 insertions(+)
>
> diff --git a/drivers/media/v4l2-core/v4l2-fwnode
Verkuil
> Acked-by: Pavel Machek
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/media/v4l2-core/v4l2-fwnode.c | 75
> include/media/v4l2-fwnode.h | 81
> ++-
> 2 files changed, 80 insertions(
ilus
> Cc: Rob Herring
> Cc: devicet...@vger.kernel.org
> Acked-by: Hans Verkuil
> Acked-by: Pavel Machek
> Acked-by: Rob Herring
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> Documentation/devicetree/bindings/media/video-interfaces.txt | 8
> 1 file cha
>
> - mutex_lock(&list_lock);
> -
> ret = v4l2_async_notifier_try_all_subdevs(notifier);
> - if (ret)
> + if (ret < 0)
> goto err_unbind;
the error path does no unlock?
> ret = v4l2_async_notifier_try_complete(notifier);
> - if (ret)
> + if (ret < 0)
> goto err_unbind;
dito
> + ret = 0;
>
> /* Keep also completed notifiers on the list */
> list_add(¬ifier->list, ¬ifier_list);
>
> +out_unlock:
> mutex_unlock(&list_lock);
>
> - return 0;
> + return ret;
>
> err_unbind:
> /*
Otherwise:
Reviewed-by: Sebastian Reichel
-- Sebastian
signature.asc
Description: PGP signature
2_device is available and no notifier has pending sub-devices to bind.
> No complete callbacks are supported for sub-device notifiers.
>
> Signed-off-by: Sakari Ailus
> Acked-by: Hans Verkuil
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/media/v4l2-core/v4l2-asy
sier
> to review.
>
> Signed-off-by: Sakari Ailus
> Acked-by: Hans Verkuil
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/media/v4l2-core/v4l2-async.c | 69
> ++--
> 1 file changed, 50 insertions(+), 19 deletions(-)
>
&g
d by the bound
> callback.
>
> Signed-off-by: Sakari Ailus
> Acked-by: Hans Verkuil
> Acked-by: Pavel Machek
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/media/v4l2-core/v4l2-async.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff
e async sub-devices available,
> it can be done by inspecting the notifier's num_subdevs field which tells
> the number of async sub-devices.
>
> Signed-off-by: Sakari Ailus
> Acked-by: Hans Verkuil
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/media/v4l
Hi,
On Thu, Oct 26, 2017 at 10:53:22AM +0300, Sakari Ailus wrote:
> If no source pads are found in an entity, print the name of the entity.
>
> Signed-off-by: Sakari Ailus
> Acked-by: Hans Verkuil
> Acked-by: Pavel Machek
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
gt; Acked-by: Hans Verkuil
> Acked-by: Pavel Machek
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/media/v4l2-core/v4l2-async.c | 56
> +---
> 1 file changed, 39 insertions(+), 17 deletions(-)
>
> diff --git a/drivers/media/v4l2-co
able, this creates a potential
> security risk as the function pointers are mutable.
>
> To fix this, move the function pointers to a new
> v4l2_async_subdev_operations structure that can be made const in
> drivers.
>
> Signed-off-by: Laurent Pinchart
> Acked-by: Hans Ve
-off-by: Sakari Ailus
> Acked-by: Hans Verkuil
> Acked-by: Pavel Machek
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/media/platform/omap3isp/isp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/omap3i
Reviewed-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/media/platform/omap3isp/isp.c | 121
> +++---
> drivers/media/platform/omap3isp/isp.h | 5 +-
> 2 files changed, 40 insertions(+), 86 deletions(-)
>
test_notify and undo the work that was done either in async
> sub-device or async notifier registration.
>
> Reported-by: Russell King
> Signed-off-by: Sakari Ailus
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/media/v4l2-core/v4l2-async.c | 78
> ++
Hi,
On Thu, Oct 05, 2017 at 12:50:26AM +0300, Sakari Ailus wrote:
> The V4L2 async wasn't part of the documentation build. Fix this.
>
> Signed-off-by: Sakari Ailus
> Reviewed-by: Niklas Söderlund
> Acked-by: Hans Verkuil
> Reviewed-by: Laurent Pinchart
Reviewe
v4l2_async_belongs v4l2_async_find_match
>
> Signed-off-by: Sakari Ailus
> Acked-by: Hans Verkuil
> Acked-by: Pavel Machek
> Reviewed-by: Laurent Pinchart
Reviewed-by: Sebastian Reichel
-- Sebastian
> ---
> drivers/media/v4l2-core/v4l2-async.c | 19 ++---
gt; proceeds to take the lock.
>
> Fix this by first acquiring the lock and then proceeding with the check.
>
> Signed-off-by: Sakari Ailus
Reviewed-by: Sebastian Reichel
-- Sebastian
> ---
> drivers/media/v4l2-core/v4l2-async.c | 18 +++---
> 1 file chang
or to cleaning up the subdevice to avoid this.
>
> Signed-off-by: Niklas Söderlund
> Signed-off-by: Sakari Ailus
Reviewed-by: Sebastian Reichel
-- Sebastian
> ---
> drivers/media/v4l2-core/v4l2-async.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
&
; Signed-off-by: Sakari Ailus
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/media/v4l2-core/v4l2-async.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/media/v4l2-core/v4l2-async.c
> b/drivers/media/v4l2-core/v4l2-async.c
> index 60a1a50b9537.
c locks.
> Considering the complexity of the re-probing and that it isn't really a
> solution to a problem but a workaround, remove re-probing instead.
>
> Signed-off-by: Sakari Ailus
> Acked-by: Hans Verkuil
> Acked-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian
buscfg->bus.ccp2.lanecfg.data[0].pol =
> vep.bus.mipi_csi1.lane_polarity[1];
>
> - dev_dbg(dev, "data lane %u polarity %u, pos %u\n", i,
> + dev_dbg(dev, "data lane polarity %u, pos %u\n",
> buscfg->bus.ccp2.lanecfg.data[0].pol,
> buscfg->bus.ccp2.lanecfg.data[0].pos);
Reviewed-by: Sebastian Reichel
-- Sebastian
signature.asc
Description: PGP signature
Hi,
On Tue, Jul 18, 2017 at 01:01:11AM +0300, Sakari Ailus wrote:
> From: Pavel Machek
>
> Add support for parsing CSI1 configuration.
>
> Signed-off-by: Pavel Machek
> Signed-off-by: Sakari Ailus
Reviewed-by: Sebastian Reichel
-- Sebastian
> ---
> drivers/media
Hi,
On Tue, Jul 18, 2017 at 01:01:13AM +0300, Sakari Ailus wrote:
> From: Pavel Machek
>
> If regulator returns -EPROBE_DEFER, we need to return it too, so that
> omap3isp will be re-probed when regulator is ready.
>
> Signed-off-by: Pavel Machek
> Reviewed-by: Laurent Pinchart
> Signed-off-b
Hi,
On Tue, Jul 18, 2017 at 01:01:10AM +0300, Sakari Ailus wrote:
> If endpoint has an invalid configuration, ignore it instead of happily
> proceeding to use it nonetheless. Ignoring such an endpoint is better than
> failing since there could be multiple endpoints, only some of which are
> bad.
Hi,
On Thu, Jul 06, 2017 at 02:00:18AM +0300, Sakari Ailus wrote:
> Check that we do have a valid port in an endpoint, return an error if not.
>
> Signed-off-by: Sakari Ailus
Reviewed-by: Sebastian Reichel
-- Sebastian
> ---
> drivers/media/platform/omap3isp/isp.c | 2 +-
&g
Hi,
On Thu, Jul 06, 2017 at 02:00:16AM +0300, Sakari Ailus wrote:
> From: Sakari Ailus
>
> CCP2 and CSI-1, are older single data lane serial busses.
>
> Signed-off-by: Sakari Ailus
> Signed-off-by: Pavel Machek
Reviewed-by: Sebastian Reichel
-- Sebastian
> ---
>
i Ailus
Reviewed-by: Sebastian Reichel
-- Sebastian
> ---
> drivers/media/v4l2-core/v4l2-fwnode.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/v4l2-core/v4l2-fwnode.c
> b/drivers/media/v4l2-core/v4l2-fwnode.c
> index 15
Hi,
On Thu, Jul 06, 2017 at 02:00:15AM +0300, Sakari Ailus wrote:
> From: Sakari Ailus
>
> Just obtain it. It'll actually get used soon with CSI-1/CCP2.
>
> Signed-off-by: Sakari Ailus
Reviewed-by: Sebastian Reichel
-- Sebastian
> ---
> drivers/media/v4
Hi,
On Thu, Jun 15, 2017 at 03:32:10PM +0300, Sakari Ailus wrote:
> On Thu, Jun 15, 2017 at 11:24:26AM +0200, Sebastian Reichel wrote:
> > On Wed, Jun 14, 2017 at 12:47:16PM +0300, Sakari Ailus wrote:
> > > None of the flash operations are not mandatory and therefore there shoul
; Signed-off-by: Sakari Ailus
Reviewed-by: Sebastian Reichel
-- Sebastian
> ---
> drivers/media/v4l2-core/v4l2-flash-led-class.c | 19 +++
> include/media/v4l2-flash-led-class.h | 6 +++---
> 2 files changed, 10 insertions(+), 15 deletions(-)
>
> dif
Hi,
On Wed, Jun 14, 2017 at 12:47:19PM +0300, Sakari Ailus wrote:
> From: Sakari Ailus
>
> Add the as3645a flash controller to the DT source as well as the flash
> property with the as3645a device phandle to the sensor DT node.
>
> Signed-off-by: Sakari Ailus
Reviewed-by:
Hi,
On Wed, Jun 14, 2017 at 12:47:16PM +0300, Sakari Ailus wrote:
> None of the flash operations are not mandatory and therefore there should
> be no need for the flash ops structure either. Accept NULL.
I think you negated one time too much :). Otherwise:
Reviewed-by: Sebastian R
s
Reviewed-by: Sebastian Reichel
-- Sebastian
> ---
> Documentation/devicetree/bindings/media/video-interfaces.txt | 8
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/media/video-interfaces.txt
> b/Documentation/devicetree/bi
ugh
> the mbus configuration of the active input to the output side.
>
> Signed-off-by: Sascha Hauer
> Signed-off-by: Philipp Zabel
> Signed-off-by: Steve Longerbeam
Reviewed-by: Sebastian Reichel
-- Sebastian
> ---
> No changes since v4 [1]:
>
> This patch depends
>
> Signed-off-by: Sakari Ailus
> Acked-by: Pavel Machek
Reviewed-by: Sebastian Reichel
> diff --git a/Documentation/devicetree/bindings/media/video-interfaces.txt
> b/Documentation/devicetree/bindings/media/video-interfaces.txt
> index 0a33240..38e3916 100644
> --- a/Documen
d-by: Pavel Machek
Reviewed-by: Sebastian Reichel
> ---
> Documentation/devicetree/bindings/media/video-interfaces.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/media/video-interfaces.txt
> b/Documentation/devicetree/binding
Hi,
On Fri, May 05, 2017 at 11:28:34AM +0300, Sakari Ailus wrote:
> Sebastian Reichel wrote:
> > On Tue, May 02, 2017 at 01:25:47PM +0300, Sakari Ailus wrote:
> > > +- flash: An array of phandles that refer to the flash light sources
> > > + related to an image senso
Hi,
On Tue, May 02, 2017 at 01:25:49PM +0300, Sakari Ailus wrote:
> Many camera sensor devices contain EEPROM chips that describe the
> properties of a given unit --- the data is specific to a given unit can
> thus is not stored e.g. in user space or the driver.
>
> Some sensors embed the EEPROM
Hi,
On Tue, May 02, 2017 at 01:25:48PM +0300, Sakari Ailus wrote:
> The lens-focus property contains a phandle to the lens voice coil driver
> that is associated to the sensor; typically both are contained in the same
> camera module.
>
> Signed-off-by: Sakari Ailus
> ---
> Documentation/device
LED, then the phandles here refer to
> + the child nodes of the LED driver describing individual LEDs. Only
> + valid for device nodes that are related to an image sensor.
s/driver/controller/g - DT describes HW. Otherwise
Reviewed-by: Sebastian Reichel
-- Sebastian
signature.asc
Description: PGP signature
Hi,
On Thu, May 04, 2017 at 03:38:57PM +0200, Philipp Zabel wrote:
> This driver can handle SoC internal and external video bus multiplexers,
> controlled by mux controllers provided by the mux controller framework,
> such as MMIO register bitfields or GPIOs. The subdevice passes through
> the mbu
i Ailus
Reviewed-by: Sebastian Reichel
-- Sebastian
> ---
> No changes since v2 [1].
>
> This was previously sent as part of Steve's i.MX media series [2].
>
> [1] https://patchwork.kernel.org/patch/9708235/
> [2] https://patchwork.kernel.org/patch/9647951/
>
Hi,
On Fri, Apr 28, 2017 at 08:08:59AM -0700, Tony Lindgren wrote:
> * Tomi Valkeinen [170428 04:15]:
> > On 14/04/17 13:25, Hans Verkuil wrote:
> > > From: Hans Verkuil
> > >
> > > The CEC pin was always pulled up, making it impossible to use it.
> > >
> > > Change to PIN_INPUT so it can be u
Hi,
On Wed, Feb 15, 2017 at 11:23:01AM +0100, Pavel Machek wrote:
> It seems csiphy_routing_cfg_3430 is not called at all. I added
> printks, but they don't trigger. If you have an idea what is going on
> there, it would help...
You added printk to csiphy_routing_cfg_3630 instead of csiphy_routin
Hi,
On Tue, Feb 14, 2017 at 02:39:56PM +0100, Pavel Machek wrote:
> From: Sebastian Reichel
>
> Without this, camera support breaks boot on N900.
That's kind of vague. I just checked my original patch and it looks
like I did not bother to write a proper patch description. I s
Hi,
On Sun, Feb 05, 2017 at 10:12:20PM +0100, Pavel Machek wrote:
> > > 9) Highly reconfigurable hardware - Julien Beraud
> > >
> > > - 44 sub-devices connected with an interconnect.
> > > - As long as formats match, any sub-device could be connected to any
> > > - other sub-device through a link
Hi,
On Fri, Feb 03, 2017 at 10:07:28PM +0100, Pavel Machek wrote:
> On Fri 2017-02-03 14:32:19, Pali Rohár wrote:
> > On Friday 03 February 2017 13:35:08 Pavel Machek wrote:
> > > N900 contains front and back camera, with a switch between the
> > > two. This adds support for the switch component,
interpreted
>as 0 (normal). This property is valid for serial busses only.
> -
> +- strobe: Whether the clock signal is used as clock or strobe. Used
> + with CCP2, for instance.
>
> Example
> ---
>
>
Reviewed-By: Sebastian Reichel
-- Sebastian
signature.asc
Description: PGP signature
rivers/power/supply/rx51_battery.c
TI BQ27XXX POWER SUPPLY DRIVER
R: Andrew F. Davis
F: include/linux/power/bq27xxx_battery.h
F: drivers/power/supply/bq27xxx_battery.c
F: drivers/power/supply/bq27xxx_battery_i2c.c
POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS
M: Sebastian Reichel
L:
Hi,
On Thu, Dec 22, 2016 at 11:42:26PM +0100, Pavel Machek wrote:
> On Thu 2016-12-22 15:32:44, Sebastian Reichel wrote:
> > Hi Pavel,
> >
> > On Thu, Dec 22, 2016 at 02:39:38PM +0100, Pavel Machek wrote:
> > > N900 contains front and back camera, with a switch be
Hi,
On Thu, Dec 22, 2016 at 09:53:17PM +0100, Pavel Machek wrote:
> > 1. Settings must be applied before the streaming starts instead of
> > at probe time, since the settings may change (based one the selected
> > camera). That should be fairly easy to implement by just moving the
> > code to the
Hi Pavel,
On Thu, Dec 22, 2016 at 02:39:38PM +0100, Pavel Machek wrote:
> N900 contains front and back camera, with a switch between the
> two. This adds support for the swich component.
>
> Signed-off-by: Sebastian Reichel
> Signed-off-by: Ivaylo Dimitrov
> Signed-of
Hi Sakari,
On Mon, Nov 14, 2016 at 11:58:28PM +0200, Sakari Ailus wrote:
> [...]
>
> On Fri, Nov 04, 2016 at 01:05:25AM +0100, Sebastian Reichel wrote:
> > I'm not sure what part relevant for video-bus-switch is currently
> > not supported?
> >
> > vi
Hi,
On Fri, Nov 04, 2016 at 01:05:01AM +0200, Sakari Ailus wrote:
> On Thu, Nov 03, 2016 at 11:48:43PM +0100, Sebastian Reichel wrote:
> > On Tue, Nov 01, 2016 at 12:54:08AM +0200, Sakari Ailus wrote:
> > > > > Thanks, this answered half
Hi,
On Tue, Nov 01, 2016 at 12:54:08AM +0200, Sakari Ailus wrote:
> > > Thanks, this answered half of my questions already. ;-)
> > :-).
> >
> > I'll have to go through the patches, et8ek8 driver is probably not
> > enough to get useful video. platform/video-bus-switch.c is needed for
> > camera
+-
> drivers/media/i2c/smiapp/smiapp-regs.c | 5 ++
> drivers/media/i2c/smiapp/smiapp.h | 11 +--
> 3 files changed, 67 insertions(+), 79 deletions(-)
Reviewed-By: Sebastian Reichel
-- Sebastian
signature.asc
Description: PGP signature
crement it before returning. This
> avoids a serialisation problem with autosuspend.
>
> drivers/media/i2c/smiapp/smiapp-core.c | 10 +++---
> drivers/media/i2c/smiapp/smiapp-regs.c | 21 +++--
> 2 files changed, 22 insertions(+), 9 deletions(-)
Rev
frame descriptor (image data lines are
> among embedded data lines)
>
> - Fix error handling in registered() callback, add unregistered()
> callback
>
> - smiapp_create_subdev() will return immediately if its ssd argument is
> NULL. No need for caller to check this.
1 - 100 of 176 matches
Mail list logo
