Re: [PATCH v15 06/32] v4l: async: Use more intuitive names for internal functions

[Sebastian Reichel]

Hi,

On Thu, Oct 05, 2017 at 12:50:25AM +0300, Sakari Ailus wrote:
> Rename internal functions to make the names of the functions better
> describe what they do.
> 
>       Old name                        New name
>       v4l2_async_test_notify  v4l2_async_match_notify
>       v4l2_async_belongs      v4l2_async_find_match
> 
> Signed-off-by: Sakari Ailus <sakari.ai...@linux.intel.com>
> Acked-by: Hans Verkuil <hans.verk...@cisco.com>
> Acked-by: Pavel Machek <pa...@ucw.cz>
> Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>

Reviewed-by: Sebastian Reichel <sebastian.reic...@collabora.co.uk>

-- Sebastian

> ---
>  drivers/media/v4l2-core/v4l2-async.c | 19 ++++++++++---------
>  1 file changed, 10 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/media/v4l2-core/v4l2-async.c 
> b/drivers/media/v4l2-core/v4l2-async.c
> index cde2cf2ab4b0..8b84fea50c2a 100644
> --- a/drivers/media/v4l2-core/v4l2-async.c
> +++ b/drivers/media/v4l2-core/v4l2-async.c
> @@ -60,8 +60,8 @@ static LIST_HEAD(subdev_list);
>  static LIST_HEAD(notifier_list);
>  static DEFINE_MUTEX(list_lock);
>  
> -static struct v4l2_async_subdev *v4l2_async_belongs(struct 
> v4l2_async_notifier *notifier,
> -                                                 struct v4l2_subdev *sd)
> +static struct v4l2_async_subdev *v4l2_async_find_match(
> +     struct v4l2_async_notifier *notifier, struct v4l2_subdev *sd)
>  {
>       bool (*match)(struct v4l2_subdev *, struct v4l2_async_subdev *);
>       struct v4l2_async_subdev *asd;
> @@ -95,9 +95,9 @@ static struct v4l2_async_subdev *v4l2_async_belongs(struct 
> v4l2_async_notifier *
>       return NULL;
>  }
>  
> -static int v4l2_async_test_notify(struct v4l2_async_notifier *notifier,
> -                               struct v4l2_subdev *sd,
> -                               struct v4l2_async_subdev *asd)
> +static int v4l2_async_match_notify(struct v4l2_async_notifier *notifier,
> +                                struct v4l2_subdev *sd,
> +                                struct v4l2_async_subdev *asd)
>  {
>       int ret;
>  
> @@ -187,11 +187,11 @@ int v4l2_async_notifier_register(struct v4l2_device 
> *v4l2_dev,
>       list_for_each_entry_safe(sd, tmp, &subdev_list, async_list) {
>               int ret;
>  
> -             asd = v4l2_async_belongs(notifier, sd);
> +             asd = v4l2_async_find_match(notifier, sd);
>               if (!asd)
>                       continue;
>  
> -             ret = v4l2_async_test_notify(notifier, sd, asd);
> +             ret = v4l2_async_match_notify(notifier, sd, asd);
>               if (ret < 0) {
>                       mutex_unlock(&list_lock);
>                       return ret;
> @@ -255,13 +255,14 @@ int v4l2_async_register_subdev(struct v4l2_subdev *sd)
>       INIT_LIST_HEAD(&sd->async_list);
>  
>       list_for_each_entry(notifier, &notifier_list, list) {
> -             struct v4l2_async_subdev *asd = v4l2_async_belongs(notifier, 
> sd);
> +             struct v4l2_async_subdev *asd = v4l2_async_find_match(notifier,
> +                                                                   sd);
>               int ret;
>  
>               if (!asd)
>                       continue;
>  
> -             ret = v4l2_async_test_notify(notifier, sd, asd);
> +             ret = v4l2_async_match_notify(notifier, sd, asd);
>               if (ret)
>                       goto err_unlock;
>  
> -- 
> 2.11.0
> 

signature.asc
Description: PGP signature