Re: [RFC] Removal of drivers/staging/media/bcm2048

2019-07-24 Thread Sebastian Reichel
/kernel/git/torvalds/linux.git/tree/arch/arm/boot/dts/omap3-n900.dts > > Is there any chance that this bcm2048 driver will be fixed and > moved out of staging by the end of this year? If not, then I want > to remove it. FWIW I do _not_ plan to work on this, since I'm too busy with other things (e.g. moving the wl128x radio driver to use the new hci_ll driver). -- Sebastian signature.asc Description: PGP signature

Re: [PATCH 00/14] Add support for FM radio in hcill and kill TI_ST

2019-01-10 Thread Sebastian Reichel
t.bin > /lib/firmware/ti-connectivity/wl128x-fw-5-mr.bin > /lib/firmware/ti-connectivity/wl128x-fw-5-sr.bin > /lib/firmware/ti-connectivity/wl128x-nvs.bin > root@devuan:/home/user# > > Ideas welcome... ... ... am I supposed to compile wl128-nvs.bin into > the kernel us

Re: [PATCH 10/14] media: wl128x-radio: simplify fmc_prepare/fmc_release

2019-01-09 Thread Sebastian Reichel
Hi Pavel, On Sat, Dec 22, 2018 at 08:29:34PM +0100, Pavel Machek wrote: > On Fri 2018-12-21 02:17:48, Sebastian Reichel wrote: > > From: Sebastian Reichel > > > > Remove unused return code from fmc_prepare() and fmc_release() to > > simplify the code a bit. > &g

Re: [PATCH 12/14] media: wl128x-radio: move from TI_ST to hci_ll driver

2019-01-09 Thread Sebastian Reichel
Hi Marcel, First of all thanks for your review. On Sun, Dec 23, 2018 at 04:56:47PM +0100, Marcel Holtmann wrote: > Hi Sebastian, [...] > > +static int ll_register_fm(struct ll_device *lldev) > > +{ > > + struct device *dev = &lldev->serdev->dev; &g

Re: [PATCH 14/14] misc: ti-st: Drop superseded driver

2018-12-21 Thread Sebastian Reichel
Hi, On Fri, Dec 21, 2018 at 03:10:52PM -0600, Adam Ford wrote: > On Fri, Dec 21, 2018 at 2:13 AM Sebastian Reichel wrote: > > > > From: Sebastian Reichel > > > > This driver has been superseded by the serdev based Bluetooth > > hci_ll driver, which is initia

Re: [PATCH 00/14] Add support for FM radio in hcill and kill TI_ST

2018-12-21 Thread Sebastian Reichel
Hi, On Fri, Dec 21, 2018 at 10:02:05AM -0800, Tony Lindgren wrote: > * Sebastian Reichel [181221 01:18]: > > The new code has been tested on the Motorola Droid 4. For testing the audio > > should be configured to route Ext to Speaker or Headphone. Then you need to > > plug

[PATCH 05/14] media: wl128x-radio: remove global radio_disconnected

2018-12-20 Thread Sebastian Reichel
From: Sebastian Reichel Move global radio_disconnected into device structure to prepare converting this driver into a normal platform device driver supporting multiple instances. Signed-off-by: Sebastian Reichel --- drivers/media/radio/wl128x/fmdrv.h | 1 + drivers/media/radio/wl128x

[PATCH 04/14] media: wl128x-radio: remove module version

2018-12-20 Thread Sebastian Reichel
From: Sebastian Reichel Drop module version. We already have the kernel's version and this module is mainline. Signed-off-by: Sebastian Reichel --- drivers/media/radio/wl128x/fmdrv.h| 1 - drivers/media/radio/wl128x/fmdrv_common.c | 5 ++--- 2 files changed, 2 insertions(

[PATCH 02/14] ARM: dts: IGEP: Add WiLink UART node

2018-12-20 Thread Sebastian Reichel
From: Sebastian Reichel Add a node for the UART part of WiLink chip. Cc: Enric Balletbo i Serra Signed-off-by: Sebastian Reichel --- This is compile tested only! --- arch/arm/boot/dts/omap3-igep0020-rev-f.dts | 8 arch/arm/boot/dts/omap3-igep0030-rev-g.dts | 8 2 files

[PATCH 03/14] ARM: OMAP2+: pdata-quirks: drop TI_ST/KIM support

2018-12-20 Thread Sebastian Reichel
From: Sebastian Reichel All TI_ST users have been migrated to the new serdev based HCILL bluetooth driver. That driver is initialized from DT and does not need any platform quirks. Signed-off-by: Sebastian Reichel --- arch/arm/mach-omap2/pdata-quirks.c | 52 -- 1

[PATCH 14/14] misc: ti-st: Drop superseded driver

2018-12-20 Thread Sebastian Reichel
From: Sebastian Reichel This driver has been superseded by the serdev based Bluetooth hci_ll driver, which is initialized from DT. All mainline users have been converted and this driver can be safely dropped. Signed-off-by: Sebastian Reichel --- drivers/misc/Kconfig | 1 - drivers

[PATCH 10/14] media: wl128x-radio: simplify fmc_prepare/fmc_release

2018-12-20 Thread Sebastian Reichel
From: Sebastian Reichel Remove unused return code from fmc_prepare() and fmc_release() to simplify the code a bit. Signed-off-by: Sebastian Reichel --- drivers/media/radio/wl128x/fmdrv_common.c | 26 +-- drivers/media/radio/wl128x/fmdrv_common.h | 4 ++-- drivers/media

[PATCH 11/14] media: wl128x-radio: fix skb debug printing

2018-12-20 Thread Sebastian Reichel
From: Sebastian Reichel This fixes incorrect code in the TX/RX skb debug print function and add stubs in receive/transmit packet path. Signed-off-by: Sebastian Reichel --- drivers/media/radio/wl128x/fmdrv_common.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git

[PATCH 06/14] media: wl128x-radio: remove global radio_dev

2018-12-20 Thread Sebastian Reichel
From: Sebastian Reichel Move global radio_dev into device structure to prepare converting this driver into a normal platform device driver supporting multiple instances. Signed-off-by: Sebastian Reichel --- drivers/media/radio/wl128x/fmdrv.h| 2 +- drivers/media/radio/wl128x

[PATCH 13/14] Bluetooth: btwilink: drop superseded driver

2018-12-20 Thread Sebastian Reichel
From: Sebastian Reichel All users of this driver have been converted to the serdev based hci_ll driver. The unused driver can be safely dropped now. Signed-off-by: Sebastian Reichel --- drivers/bluetooth/Kconfig| 11 -- drivers/bluetooth/Makefile | 1 - drivers/bluetooth/btwilink.c

[PATCH 07/14] media: wl128x-radio: convert to platform device

2018-12-20 Thread Sebastian Reichel
From: Sebastian Reichel This converts the wl128x FM radio module into a platform device. It's a preparation for using it from hci_ll Bluetooth driver instead of TI_ST. Signed-off-by: Sebastian Reichel --- drivers/media/radio/wl128x/fmdrv_common.c | 30 --- 1 file ch

[PATCH 08/14] media: wl128x-radio: use device managed memory allocation

2018-12-20 Thread Sebastian Reichel
From: Sebastian Reichel This simplifies memory allocation and removes a few useless errors in case of -ENOMEM errors. Signed-off-by: Sebastian Reichel --- drivers/media/radio/wl128x/fmdrv_common.c | 41 +++ 1 file changed, 13 insertions(+), 28 deletions(-) diff --git a

[PATCH 01/14] ARM: dts: LogicPD Torpedo: Add WiLink UART node

2018-12-20 Thread Sebastian Reichel
From: Sebastian Reichel Add a node for the UART part of WiLink chip. Cc: Adam Ford Signed-off-by: Sebastian Reichel --- This is compile tested only! --- arch/arm/boot/dts/logicpd-torpedo-37xx-devkit.dts | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/logicpd

[PATCH 00/14] Add support for FM radio in hcill and kill TI_ST

2018-12-20 Thread Sebastian Reichel
ce initial get_frequency returns an error: $ radio -f 100.0 Merry Christmas! -- Sebastian Sebastian Reichel (14): ARM: dts: LogicPD Torpedo: Add WiLink UART node ARM: dts: IGEP: Add WiLink UART node ARM: OMAP2+: pdata-quirks: drop TI_ST/KIM support media: wl128x-radio: remove module versi

[PATCH 09/14] media: wl128x-radio: load firmware from ti-connectivity/

2018-12-20 Thread Sebastian Reichel
From: Sebastian Reichel All TI WiLink firmware files are loaded from the ti-connectivity subdirectory, so let's also move the FM firmware. Signed-off-by: Sebastian Reichel --- drivers/media/radio/wl128x/fmdrv_common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --

[PATCH 12/14] media: wl128x-radio: move from TI_ST to hci_ll driver

2018-12-20 Thread Sebastian Reichel
From: Sebastian Reichel This updates the wl128x-radio driver to be used with hci_ll instead of the deprecated TI_ST driver. Signed-off-by: Sebastian Reichel --- drivers/bluetooth/hci_ll.c| 115 -- drivers/media/radio/wl128x/Kconfig| 2 +- drivers

Re: v4l controls API

2018-12-03 Thread Sebastian Süsens
Ok, nevertheless thank your for your reply. Sebastian Süsens Tel. +49 4321 559 56-27 mycable GmbH Fax+49 4321 559 56-10 Gartenstrasse 10 24534 Neumuenster, Germany Email

Re: v4l controls API

2018-12-03 Thread Sebastian Süsens
Hey, I use the driver mx6s_capture kernel 4.9.88 On the device tree it is registered with following name "fsl,imx6s-csi". Hint: I have no sub-devices on my systems only /dev/video0 ---- Sebastian Süsens

v4l controls API

2018-12-03 Thread Sebastian Süsens
s...@mycable.de ---- Sebastian Süsens Tel. +49 4321 559 56-27 mycable GmbH Fax+49 4321 559 56-10 Gartenstrasse 10 24534 Neumuenster, Germany Email s...@mycable.de mycable GmbH, M

Re: [git:media_tree/master] media: em28xx-audio: use GFP_KERNEL for memory allocation during init

2018-09-12 Thread Sebastian Andrzej Siewior
re also in Greg's USB tree for the > next merge-window. Just ignore what I just wrote here. I didn't take my pills yet. Sebastian

Re: [git:media_tree/master] media: em28xx-audio: use GFP_KERNEL for memory allocation during init

2018-09-12 Thread Sebastian Andrzej Siewior
On 2018-09-12 12:00:36 [+], Mauro Carvalho Chehab wrote: > This is an automatic generated email to let you know that the following patch > were queued: The three patches you just enqueued are also in Greg's USB tree for the next merge-window. Sebastian

Re: [PATCH -next v3 2/2] media: ov772x: use SCCB helpers

2018-07-09 Thread Sebastian Reichel
772x_write(struct i2c_client *client, u8 addr, u8 > > value) > > { > > - return i2c_smbus_write_byte_data(client, addr, value); > > + return sccb_write_byte(client, addr, value); > > } Reviewed-by: Sebastian Reichel > Minor nit: I'd rather drop these t

Re: [RFC PATCH v2] media: i2c: add SCCB helpers

2018-06-12 Thread Sebastian Reichel
ers. > > With the sccb_read_byte() that issues two separated requests in order to > avoid repeated start, the driver doesn't require I2C_FUNC_PROTOCOL_MANGLING. > > Cc: Sebastian Reichel > Cc: Wolfram Sang > Cc: Jacopo Mondi > Cc: Laurent Pinchart > Cc: Hans Ve

Re: [PATCH v2.2 2/2] smiapp: Support the "rotation" property

2018-05-25 Thread Sebastian Reichel
Ailus > --- Reviewed-by: Sebastian Reichel -- Sebastian > since v2.2: > > - Fix property name in code. > > .../devicetree/bindings/media/i2c/nokia,smia.txt | 2 ++ > drivers/media/i2c/smiapp/smiapp-core.c | 16 > > 2 files chang

Re: [PATCH v2 1/2] dt-bindings: media: Define "rotation" property for sensors

2018-05-25 Thread Sebastian Reichel
t > order by setting both horizontal and vertical flipping. > > This patch documents the "rotation" property for camera sensors, mirroring > what is defined for displays in > Documentation/devicetree/bindings/display/panel/panel.txt . > > Signed-off-by: Sakari Ailu

Re: [PATCH v2 2/2] smiapp: Support the "upside-down" property

2018-05-25 Thread Sebastian Reichel
+ /* Fall through */ > + case 0: > + break; > + default: > + dev_err(dev, "invalid rotation %u\n", rotation); > + goto out_err; > + } > + } > + > /* NVM size is not mandatory */ > fwnode_property_read_u32(fwnode, "nokia,nvm-size", &hwcfg->nvm_size); -- Sebastian signature.asc Description: PGP signature

Re: [RFC PATCH] media: i2c: add SCCB helpers

2018-05-09 Thread Sebastian Reichel
ns > + */ > + > +#ifndef __SCCB_H__ > +#define __SCCB_H__ > + > +#include > + > +int sccb_read_byte(struct i2c_client *client, u8 addr); > +int sccb_write_byte(struct i2c_client *client, u8 addr, u8 data); > + > +#endif /* __SCCB_H__ */ The functions look very simple. Have you considered moving them into sccb.h as static inline? -- Sebastian signature.asc Description: PGP signature

4.17-rc3 regression in UVC driver

2018-05-04 Thread Sebastian Reichel
1 > N: video1 > E: DEVNAME=/dev/video1 > E: > DEVPATH=/devices/pci:00/:00:14.0/usb1/1-8/1-8:1.0/video4linux/video1 > E: MAJOR=81 > E: MINOR=1 > E: SUBSYSTEM=video4linux > sre@earth ~ % lsusb -d 04ca:703c > Bus 001 Device 004: ID 04ca:703c Lite-On Technology Corp. -- Sebastian signature.asc Description: PGP signature

Re: [PATCH 1/2] dt-bindings: media: Add "upside-down" property to tell sensor orientation

2018-05-03 Thread Sebastian Reichel
ngs/display/panel/panel.txt -- Sebastian > --- > Documentation/devicetree/bindings/media/video-interfaces.txt | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/media/video-interfaces.txt > b/Documentation/devicetree/bindings/me

Re: [PATCH] media: et8ek8: select V4L2_FWNODE

2017-11-13 Thread Sebastian Reichel
or flash and lens devices") > Signed-off-by: Arnd Bergmann > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/media/i2c/et8ek8/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/media/i2c/et8ek8/Kconfig > b/drivers/media/i2c/et8ek8/Kconfig > i

Re: et8ek8: Document support for flash and lens devices

2017-11-12 Thread Sebastian Reichel
Hi, On Sun, Nov 12, 2017 at 12:27:29PM +0100, Pavel Machek wrote: > > Document dts support of LED/focus. > > Signed-off-by: Pavel Machek Reviewed-by: Sebastian Reichel -- Sebastian > diff --git a/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt > b/Docume

Re: [PATCH] media: rc: remove ir-rx51 in favour of generic pwm-ir-tx

2017-11-01 Thread Sebastian Reichel
TS working with old kernel. Also we want it working the other way around (old DTS with new kernel), so we need to add the "nokia,n900-ir" compatible to the generic PWM IR driver. Also the DT binding document needs update: Documentation/devicetree/bindings/media/nokia,n900-ir [Adding Ro

Re: [PATCH] media: v4l2-fwnode: use the cached value instead of getting again

2017-11-01 Thread Sebastian Reichel
used-but-set-variable] >bool is_available; > ^~~~ > > Fixes: 9ca465312132 ("media: v4l: fwnode: Support generic parsing of graph > endpoints in a device") > Cc: Sakari Ailus > Signed-off-by: Mauro Carvalho Chehab > --- Reviewed-by: Sebastian Reichel -- S

Re: [PATCH v16 32/32] arm: dts: omap3: N9/N950: Add flash references to the camera

2017-10-29 Thread Sebastian Reichel
Hi, On Thu, Oct 26, 2017 at 10:53:42AM +0300, Sakari Ailus wrote: > Add flash and indicator LED phandles to the sensor node. > > Signed-off-by: Sakari Ailus > Acked-by: Hans Verkuil > Acked-by: Pavel Machek > --- Reviewed-by: Sebastian Reichel -- Sebastian > arch/

Re: [PATCH v16 31/32] ov13858: Add support for flash and lens devices

2017-10-29 Thread Sebastian Reichel
Hi, On Thu, Oct 26, 2017 at 10:53:41AM +0300, Sakari Ailus wrote: > Parse async sub-devices related to the sensor by switching the async > sub-device registration function. > > Signed-off-by: Sakari Ailus > Acked-by: Hans Verkuil > --- Reviewed-by: Sebastian Reichel -- Seb

Re: [PATCH v16 30/32] ov5670: Add support for flash and lens devices

2017-10-29 Thread Sebastian Reichel
Hi, On Thu, Oct 26, 2017 at 10:53:40AM +0300, Sakari Ailus wrote: > Parse async sub-devices related to the sensor by switching the async > sub-device registration function. > > Signed-off-by: Sakari Ailus > Acked-by: Hans Verkuil > --- Reviewed-by: Sebastian Reichel -- Seb

Re: [PATCH v16 29/32] et8ek8: Add support for flash and lens devices

2017-10-29 Thread Sebastian Reichel
Hi, On Thu, Oct 26, 2017 at 10:53:39AM +0300, Sakari Ailus wrote: > Parse async sub-devices related to the sensor by switching the async > sub-device registration function. > > Signed-off-by: Sakari Ailus > Acked-by: Hans Verkuil > Acked-by: Pavel Machek > --- Reviewed-

Re: [PATCH v16 28/32] smiapp: Add support for flash and lens devices

2017-10-29 Thread Sebastian Reichel
tion to do that. > > Signed-off-by: Sakari Ailus > Acked-by: Hans Verkuil > Acked-by: Pavel Machek > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/media/i2c/smiapp/smiapp-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/driver

Re: [PATCH v16 27/32] dt: bindings: smiapp: Document lens-focus and flash-leds properties

2017-10-29 Thread Sebastian Reichel
Hi, On Thu, Oct 26, 2017 at 10:53:37AM +0300, Sakari Ailus wrote: > Document optional lens-focus and flash-leds properties for the smiapp > driver. > > Signed-off-by: Sakari Ailus > Acked-by: Hans Verkuil > Acked-by: Pavel Machek Reviewed-by: Sebastian Reic

Re: [PATCH v16 26/32] v4l: fwnode: Add a convenience function for registering sensors

2017-10-29 Thread Sebastian Reichel
This should be useful for sensor drivers that do not have device specific > requirements related to firmware information parsing or the async > framework. > > Signed-off-by: Sakari Ailus > Acked-by: Hans Verkuil > --- Reviewed-by: Sebastian Reichel -- Sebastian > driver

Re: [PATCH v16.1 25/32] v4l: fwnode: Add convenience function for parsing common external refs

2017-10-29 Thread Sebastian Reichel
regular driver needs to > know about these devices as such. > > Signed-off-by: Sakari Ailus > Acked-by: Hans Verkuil > Acked-by: Pavel Machek Reviewd-by: Sebastian Reichel -- Sebastian > --- > since v16: > > - use const char * const *props for string arrays wit

Re: [PATCH v16.1 24/32] v4l: fwnode: Add a helper function to obtain device / integer references

2017-10-29 Thread Sebastian Reichel
igned-off-by: Sakari Ailus > Acked-by: Hans Verkuil > --- Reviewed-by: Sebastian Reichel -- Sebastian > since v16: > > - use const char * const *props for string arrays with property names. > > drivers/media/v4l2-core/v4l2-fwnode.c | 287 >

Re: [PATCH v16 23/32] v4l: fwnode: Add a helper function for parsing generic references

2017-10-29 Thread Sebastian Reichel
-off-by: Sakari Ailus > Acked-by: Hans Verkuil > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/media/v4l2-core/v4l2-fwnode.c | 69 > +++ > 1 file changed, 69 insertions(+) > > diff --git a/drivers/media/v4l2-core/v4l2-fwnode

Re: [PATCH v16 22/32] v4l: fwnode: Move KernelDoc documentation to the header

2017-10-29 Thread Sebastian Reichel
Verkuil > Acked-by: Pavel Machek > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/media/v4l2-core/v4l2-fwnode.c | 75 > include/media/v4l2-fwnode.h | 81 > ++- > 2 files changed, 80 insertions(

Re: [PATCH v16 20/32] dt: bindings: Add a binding for flash LED devices associated to a sensor

2017-10-29 Thread Sebastian Reichel
ilus > Cc: Rob Herring > Cc: devicet...@vger.kernel.org > Acked-by: Hans Verkuil > Acked-by: Pavel Machek > Acked-by: Rob Herring > --- Reviewed-by: Sebastian Reichel -- Sebastian > Documentation/devicetree/bindings/media/video-interfaces.txt | 8 > 1 file cha

Re: [PATCH v16.1 19/32] v4l: async: Ensure only unique fwnodes are registered to notifiers

2017-10-29 Thread Sebastian Reichel
> > - mutex_lock(&list_lock); > - > ret = v4l2_async_notifier_try_all_subdevs(notifier); > - if (ret) > + if (ret < 0) > goto err_unbind; the error path does no unlock? > ret = v4l2_async_notifier_try_complete(notifier); > - if (ret) > + if (ret < 0) > goto err_unbind; dito > + ret = 0; > > /* Keep also completed notifiers on the list */ > list_add(¬ifier->list, ¬ifier_list); > > +out_unlock: > mutex_unlock(&list_lock); > > - return 0; > + return ret; > > err_unbind: > /* Otherwise: Reviewed-by: Sebastian Reichel -- Sebastian signature.asc Description: PGP signature

Re: [PATCH v16.1 18/32] v4l: async: Allow binding notifiers to sub-devices

2017-10-29 Thread Sebastian Reichel
2_device is available and no notifier has pending sub-devices to bind. > No complete callbacks are supported for sub-device notifiers. > > Signed-off-by: Sakari Ailus > Acked-by: Hans Verkuil > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/media/v4l2-core/v4l2-asy

Re: [PATCH v16.1 17/32] v4l: async: Prepare for async sub-device notifiers

2017-10-27 Thread Sebastian Reichel
sier > to review. > > Signed-off-by: Sakari Ailus > Acked-by: Hans Verkuil > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/media/v4l2-core/v4l2-async.c | 69 > ++-- > 1 file changed, 50 insertions(+), 19 deletions(-) > &g

Re: [PATCH v16 15/32] v4l: async: Register sub-devices before calling bound callback

2017-10-27 Thread Sebastian Reichel
d by the bound > callback. > > Signed-off-by: Sakari Ailus > Acked-by: Hans Verkuil > Acked-by: Pavel Machek > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/media/v4l2-core/v4l2-async.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff

Re: [PATCH v16 16/32] v4l: async: Allow async notifier register call succeed with no subdevs

2017-10-27 Thread Sebastian Reichel
e async sub-devices available, > it can be done by inspecting the notifier's num_subdevs field which tells > the number of async sub-devices. > > Signed-off-by: Sakari Ailus > Acked-by: Hans Verkuil > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/media/v4l

Re: [PATCH v16 12/32] omap3isp: Print the name of the entity where no source pads could be found

2017-10-27 Thread Sebastian Reichel
Hi, On Thu, Oct 26, 2017 at 10:53:22AM +0300, Sakari Ailus wrote: > If no source pads are found in an entity, print the name of the entity. > > Signed-off-by: Sakari Ailus > Acked-by: Hans Verkuil > Acked-by: Pavel Machek > --- Reviewed-by: Sebastian Reichel -- Sebastian

Re: [PATCH v16 14/32] v4l: async: Introduce helpers for calling async ops callbacks

2017-10-27 Thread Sebastian Reichel
gt; Acked-by: Hans Verkuil > Acked-by: Pavel Machek > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/media/v4l2-core/v4l2-async.c | 56 > +--- > 1 file changed, 39 insertions(+), 17 deletions(-) > > diff --git a/drivers/media/v4l2-co

Re: [PATCH v16 13/32] v4l: async: Move async subdev notifier operations to a separate structure

2017-10-27 Thread Sebastian Reichel
able, this creates a potential > security risk as the function pointers are mutable. > > To fix this, move the function pointers to a new > v4l2_async_subdev_operations structure that can be made const in > drivers. > > Signed-off-by: Laurent Pinchart > Acked-by: Hans Ve

Re: [PATCH v16 11/32] omap3isp: Fix check for our own sub-devices

2017-10-27 Thread Sebastian Reichel
-off-by: Sakari Ailus > Acked-by: Hans Verkuil > Acked-by: Pavel Machek > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/media/platform/omap3isp/isp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/omap3i

Re: [PATCH v16 09/32] omap3isp: Use generic parser for parsing fwnode endpoints

2017-10-27 Thread Sebastian Reichel
Reviewed-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/media/platform/omap3isp/isp.c | 121 > +++--- > drivers/media/platform/omap3isp/isp.h | 5 +- > 2 files changed, 40 insertions(+), 86 deletions(-) >

Re: [PATCH v16 04/32] v4l: async: Fix notifier complete callback error handling

2017-10-27 Thread Sebastian Reichel
test_notify and undo the work that was done either in async > sub-device or async notifier registration. > > Reported-by: Russell King > Signed-off-by: Sakari Ailus > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/media/v4l2-core/v4l2-async.c | 78 > ++

Re: [PATCH v15 07/32] v4l: async: Add V4L2 async documentation to the documentation build

2017-10-08 Thread Sebastian Reichel
Hi, On Thu, Oct 05, 2017 at 12:50:26AM +0300, Sakari Ailus wrote: > The V4L2 async wasn't part of the documentation build. Fix this. > > Signed-off-by: Sakari Ailus > Reviewed-by: Niklas Söderlund > Acked-by: Hans Verkuil > Reviewed-by: Laurent Pinchart Reviewe

Re: [PATCH v15 06/32] v4l: async: Use more intuitive names for internal functions

2017-10-08 Thread Sebastian Reichel
v4l2_async_belongs v4l2_async_find_match > > Signed-off-by: Sakari Ailus > Acked-by: Hans Verkuil > Acked-by: Pavel Machek > Reviewed-by: Laurent Pinchart Reviewed-by: Sebastian Reichel -- Sebastian > --- > drivers/media/v4l2-core/v4l2-async.c | 19 ++---

Re: [PATCH v15 05/32] v4l: async: Correctly serialise async sub-device unregistration

2017-10-08 Thread Sebastian Reichel
gt; proceeds to take the lock. > > Fix this by first acquiring the lock and then proceeding with the check. > > Signed-off-by: Sakari Ailus Reviewed-by: Sebastian Reichel -- Sebastian > --- > drivers/media/v4l2-core/v4l2-async.c | 18 +++--- > 1 file chang

Re: [PATCH v15 03/32] v4l: async: fix unbind error in v4l2_async_notifier_unregister()

2017-10-08 Thread Sebastian Reichel
or to cleaning up the subdevice to avoid this. > > Signed-off-by: Niklas Söderlund > Signed-off-by: Sakari Ailus Reviewed-by: Sebastian Reichel -- Sebastian > --- > drivers/media/v4l2-core/v4l2-async.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > &

Re: [PATCH v15 02/32] v4l: async: Don't set sd->dev NULL in v4l2_async_cleanup

2017-10-08 Thread Sebastian Reichel
; Signed-off-by: Sakari Ailus > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/media/v4l2-core/v4l2-async.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/media/v4l2-core/v4l2-async.c > b/drivers/media/v4l2-core/v4l2-async.c > index 60a1a50b9537.

Re: [PATCH v15 01/32] v4l: async: Remove re-probing support

2017-10-08 Thread Sebastian Reichel
c locks. > Considering the complexity of the re-probing and that it isn't really a > solution to a problem but a workaround, remove re-probing instead. > > Signed-off-by: Sakari Ailus > Acked-by: Hans Verkuil > Acked-by: Laurent Pinchart > --- Reviewed-by: Sebastian

dw2102 kernel oops

2017-09-07 Thread Sebastian Schmachtel
48 8b 78 10 [ 11.147366] RIP: dw2102_disconnect+0x1a/0x70 [dvb_usb_dw2102] RSP: b75841bb7c28 [ 11.147433] CR2: 0050 [ 11.147489] ---[ end trace 9643f635d6b5f94e ]--- Sebastian

Re: [PATCH] media: omap3isp: fix uninitialized variable use

2017-08-23 Thread Sebastian Reichel
buscfg->bus.ccp2.lanecfg.data[0].pol = > vep.bus.mipi_csi1.lane_polarity[1]; > > - dev_dbg(dev, "data lane %u polarity %u, pos %u\n", i, > + dev_dbg(dev, "data lane polarity %u, pos %u\n", > buscfg->bus.ccp2.lanecfg.data[0].pol, > buscfg->bus.ccp2.lanecfg.data[0].pos); Reviewed-by: Sebastian Reichel -- Sebastian signature.asc Description: PGP signature

Re: [PATCH 2/7] omap3isp: Parse CSI1 configuration from the device tree

2017-07-18 Thread Sebastian Reichel
Hi, On Tue, Jul 18, 2017 at 01:01:11AM +0300, Sakari Ailus wrote: > From: Pavel Machek > > Add support for parsing CSI1 configuration. > > Signed-off-by: Pavel Machek > Signed-off-by: Sakari Ailus Reviewed-by: Sebastian Reichel -- Sebastian > --- > drivers/media

Re: [PATCH 4/7] omap3isp: Return -EPROBE_DEFER if the required regulators can't be obtained

2017-07-18 Thread Sebastian Reichel
I wonder if the right approach wouldn't be to always bail out for errors. devm_regulator_get should provide a dummy regulator if none is specified. If we get an error here it means something is configured incorrectly or we have serious problems. > dev_dbg(isp->dev, > "Could not get regulator vdds_csib\n"); > ccp2->vdds_csib = NULL; -- Sebastian signature.asc Description: PGP signature

Re: [PATCH 1/7] omap3isp: Ignore endpoints with invalid configuration

2017-07-17 Thread Sebastian Reichel
are > bad. I would expect a dev_warn(dev, "Ignore endpoint (broken configuration)!"); -- Sebastian > Signed-off-by: Sakari Ailus > Tested-by: Pavel Machek > --- > drivers/media/platform/omap3isp/isp.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) >

Re: [PATCH 7/8] omap3isp: Check for valid port in endpoints

2017-07-06 Thread Sebastian Reichel
Hi, On Thu, Jul 06, 2017 at 02:00:18AM +0300, Sakari Ailus wrote: > Check that we do have a valid port in an endpoint, return an error if not. > > Signed-off-by: Sakari Ailus Reviewed-by: Sebastian Reichel -- Sebastian > --- > drivers/media/platform/omap3isp/isp.c | 2 +- &g

Re: [PATCH 5/8] v4l: Add support for CSI-1 and CCP2 busses

2017-07-06 Thread Sebastian Reichel
Hi, On Thu, Jul 06, 2017 at 02:00:16AM +0300, Sakari Ailus wrote: > From: Sakari Ailus > > CCP2 and CSI-1, are older single data lane serial busses. > > Signed-off-by: Sakari Ailus > Signed-off-by: Pavel Machek Reviewed-by: Sebastian Reichel -- Sebastian > --- >

Re: [PATCH 3/8] v4l: fwnode: Call CSI2 bus csi2, not csi

2017-07-06 Thread Sebastian Reichel
i Ailus Reviewed-by: Sebastian Reichel -- Sebastian > --- > drivers/media/v4l2-core/v4l2-fwnode.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/media/v4l2-core/v4l2-fwnode.c > b/drivers/media/v4l2-core/v4l2-fwnode.c > index 15

Re: [PATCH 4/8] v4l: fwnode: Obtain data bus type from FW

2017-07-06 Thread Sebastian Reichel
Hi, On Thu, Jul 06, 2017 at 02:00:15AM +0300, Sakari Ailus wrote: > From: Sakari Ailus > > Just obtain it. It'll actually get used soon with CSI-1/CCP2. > > Signed-off-by: Sakari Ailus Reviewed-by: Sebastian Reichel -- Sebastian > --- > drivers/media/v4

Re: Null Pointer Dereference in mceusb

2017-06-29 Thread Sebastian
Sorry for the long delay, Johan. 2017-06-01 9:20 GMT+02:00 Johan Hovold : > [ +CC: media list ] > > On Wed, May 31, 2017 at 08:25:42PM +0200, Sebastian wrote: > > What is the lsusb -v output for your device? And have you successfully > used this device with this driver before?

Re: [PATCH 5/8] v4l2-flash: Flash ops aren't mandatory

2017-06-15 Thread Sebastian Reichel
Hi, On Thu, Jun 15, 2017 at 03:32:10PM +0300, Sakari Ailus wrote: > On Thu, Jun 15, 2017 at 11:24:26AM +0200, Sebastian Reichel wrote: > > On Wed, Jun 14, 2017 at 12:47:16PM +0300, Sakari Ailus wrote: > > > None of the flash operations are not mandatory and therefore there shoul

Re: [PATCH 4/8] v4l2-flash: Use led_classdev instead of led_classdev_flash for indicator

2017-06-15 Thread Sebastian Reichel
; Signed-off-by: Sakari Ailus Reviewed-by: Sebastian Reichel -- Sebastian > --- > drivers/media/v4l2-core/v4l2-flash-led-class.c | 19 +++ > include/media/v4l2-flash-led-class.h | 6 +++--- > 2 files changed, 10 insertions(+), 15 deletions(-) > > dif

Re: [PATCH 8/8] arm: dts: omap3: N9/N950: Add AS3645A camera flash

2017-06-15 Thread Sebastian Reichel
Hi, On Wed, Jun 14, 2017 at 12:47:19PM +0300, Sakari Ailus wrote: > From: Sakari Ailus > > Add the as3645a flash controller to the DT source as well as the flash > property with the as3645a device phandle to the sensor DT node. > > Signed-off-by: Sakari Ailus Reviewed-by:

Re: [PATCH 5/8] v4l2-flash: Flash ops aren't mandatory

2017-06-15 Thread Sebastian Reichel
Hi, On Wed, Jun 14, 2017 at 12:47:16PM +0300, Sakari Ailus wrote: > None of the flash operations are not mandatory and therefore there should > be no need for the flash ops structure either. Accept NULL. I think you negated one time too much :). Otherwise: Reviewed-by: Sebastian R

Re: [PATCH 1/8] dt: bindings: Add a binding for flash devices associated to a sensor

2017-06-15 Thread Sebastian Reichel
s Reviewed-by: Sebastian Reichel -- Sebastian > --- > Documentation/devicetree/bindings/media/video-interfaces.txt | 8 > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/devicetree/bindings/media/video-interfaces.txt > b/Documentation/devicetree/bi

Re: [PATCH v5 2/3] platform: add video-multiplexer subdevice driver

2017-05-20 Thread Sebastian Reichel
ugh > the mbus configuration of the active input to the output side. > > Signed-off-by: Sascha Hauer > Signed-off-by: Philipp Zabel > Signed-off-by: Steve Longerbeam Reviewed-by: Sebastian Reichel -- Sebastian > --- > No changes since v4 [1]: > > This patch depends

Re: [RFC v2 3/3] dt: bindings: Add a binding for referencing EEPROM from camera sensors

2017-05-05 Thread Sebastian Reichel
> > Signed-off-by: Sakari Ailus > Acked-by: Pavel Machek Reviewed-by: Sebastian Reichel > diff --git a/Documentation/devicetree/bindings/media/video-interfaces.txt > b/Documentation/devicetree/bindings/media/video-interfaces.txt > index 0a33240..38e3916 100644 > --- a/Documen

Re: [RFC v2 2/3] dt: bindings: Add lens-focus binding for image sensors

2017-05-05 Thread Sebastian Reichel
d-by: Pavel Machek Reviewed-by: Sebastian Reichel > --- > Documentation/devicetree/bindings/media/video-interfaces.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/media/video-interfaces.txt > b/Documentation/devicetree/binding

Re: [RFC 1/3] dt: bindings: Add a binding for flash devices associated to a sensor

2017-05-05 Thread Sebastian Reichel
Hi, On Fri, May 05, 2017 at 11:28:34AM +0300, Sakari Ailus wrote: > Sebastian Reichel wrote: > > On Tue, May 02, 2017 at 01:25:47PM +0300, Sakari Ailus wrote: > > > +- flash: An array of phandles that refer to the flash light sources > > > + related to an image senso

Re: [RFC 3/3] dt: bindings: Add a binding for referencing EEPROM from camera sensors

2017-05-04 Thread Sebastian Reichel
eady in the first sentence :) Instead it should be mentioned, that this is to be used by devices not having their own embedded eeprom. How about: eeprom: A phandle to the node of the EEPROM describing the camera sensor (i.e. device specific calibration data), in case it differs from the sensor node. -- Sebastian signature.asc Description: PGP signature

Re: [RFC 2/3] dt: bindings: Add lens-focus binding for image sensors

2017-05-04 Thread Sebastian Reichel
related to an image sensor. > > +- lens-focus: A phandle to the node of the lens. Only valid for device > + nodes that are related to an image sensor. s/of the lens/of the focus lens controller/ Also I wonder about the second sentence. That sentence could basically be adde

Re: [RFC 1/3] dt: bindings: Add a binding for flash devices associated to a sensor

2017-05-04 Thread Sebastian Reichel
LED, then the phandles here refer to > + the child nodes of the LED driver describing individual LEDs. Only > + valid for device nodes that are related to an image sensor. s/driver/controller/g - DT describes HW. Otherwise Reviewed-by: Sebastian Reichel -- Sebastian signature.asc Description: PGP signature

Re: [PATCH v3 2/2] [media] platform: add video-multiplexer subdevice driver

2017-05-04 Thread Sebastian Reichel
*vmux->format_mbus) * > + num_pads, GFP_KERNEL); > + vmux->endpoint = devm_kzalloc(dev, sizeof(*vmux->endpoint) * > + (num_pads - 1), GFP_KERNEL); devm_kcalloc(dev, num_pads, sizeof(*foo), GFP_KERNEL). -- Sebastian signature.asc Description: PGP signature

Re: [PATCH v3 1/2] [media] dt-bindings: Add bindings for video-multiplexer device

2017-05-04 Thread Sebastian Reichel
i Ailus Reviewed-by: Sebastian Reichel -- Sebastian > --- > No changes since v2 [1]. > > This was previously sent as part of Steve's i.MX media series [2]. > > [1] https://patchwork.kernel.org/patch/9708235/ > [2] https://patchwork.kernel.org/patch/9647951/ >

Re: [PATCH 1/8] arm: omap4: enable CEC pin for Pandaboard A4 and ES

2017-04-28 Thread Sebastian Reichel
> > > > Change to PIN_INPUT so it can be used by the new CEC support. > ... > > > Reviewed-by: Tomi Valkeinen > > > > Tony, can you queue this? It's safe to apply separately from the rest of > > the HDMI CEC work. > > Sure will do. I gu

Re: [PATCH] omap3isp: add support for CSI1 bus

2017-02-15 Thread Sebastian Reichel
630 instead of csiphy_routing_cfg_3430 and N900 has OMAP3430. Function should be called when you start (or stop) using the camera: csiphy_routing_cfg_3430(...) csiphy_routing_cfg(...) omap3isp_csiphy_config(...) omap3isp_csiphy_acquire(...) & omap3isp_csiphy_release(...) ccp2_s_stream(...) -- Sebasti

Re: [RFC 06/13] v4l2-async: per notifier locking

2017-02-14 Thread Sebastian Reichel
Hi, On Tue, Feb 14, 2017 at 02:39:56PM +0100, Pavel Machek wrote: > From: Sebastian Reichel > > Without this, camera support breaks boot on N900. That's kind of vague. I just checked my original patch and it looks like I did not bother to write a proper patch description. I s

Re: [PATCH] devicetree: Add video bus switch

2017-02-05 Thread Sebastian Reichel
r Julien will want a different solution, but > then... they'll have to suggest something doable now, not in couple of > months. > > Does that sound like a plan? > > Mauro added to cc list, so we can get some input. side note: It's an kernel-internal API only used by the media subsystem. Code can be easily updated to use an improved API at any time. -- Sebastian signature.asc Description: PGP signature

Re: [PATCH] devicetree: Add video bus switch

2017-02-03 Thread Sebastian Reichel
.uni-oldenburg.de/fileadmin/user_upload/informatik/ag/svs/download/thesis/Reichel_Sebastian.pdf The schematic is on page 37 (or 45 if your PDF reader does not use different numbers for the preamble stuff). --Sebastian signature.asc Description: PGP signature

Re: [PATCHv2] dt: bindings: Add support for CSI1 bus

2017-01-11 Thread Sebastian Reichel
interpreted >as 0 (normal). This property is valid for serial busses only. > - > +- strobe: Whether the clock signal is used as clock or strobe. Used > + with CCP2, for instance. > > Example > --- > > Reviewed-By: Sebastian Reichel -- Sebastian signature.asc Description: PGP signature

Re: [PATCH] mark myself as mainainer for camera on N900

2016-12-27 Thread Sebastian Reichel
rivers/power/supply/rx51_battery.c TI BQ27XXX POWER SUPPLY DRIVER R: Andrew F. Davis F: include/linux/power/bq27xxx_battery.h F: drivers/power/supply/bq27xxx_battery.c F: drivers/power/supply/bq27xxx_battery_i2c.c POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS M: Sebastian Reichel L:

Re: [RFC/PATCH] media: Add video bus switch

2016-12-22 Thread Sebastian Reichel
Hi, On Thu, Dec 22, 2016 at 11:42:26PM +0100, Pavel Machek wrote: > On Thu 2016-12-22 15:32:44, Sebastian Reichel wrote: > > Hi Pavel, > > > > On Thu, Dec 22, 2016 at 02:39:38PM +0100, Pavel Machek wrote: > > > N900 contains front and back camera, with a switch be

Re: [RFC/PATCH] media: Add video bus switch

2016-12-22 Thread Sebastian Reichel
ement the remaining > > bits. > > :-). > > > (*) Actually it does not for CCP2, but there are some old patches > > from Sakari adding it for CCP2. It is implemented for parallel port > > and CSI in this way. > > I think I got the patches in my tree. Camera currently works for me. If you have working camera you have the CCP2 DT patches in your tree. They are not yet mainline, though. As far as I can see. -- Sebastian signature.asc Description: PGP signature

  1   2   3   >