Hi Kumar,
I don't have time for the em28xx driver at the moment (and I also do not
have access to a device with tda18271 tuner).
But...
Am 08.07.2017 um 22:29 schrieb Kumar Vivek:
> New subscriber and first time poster. I have tried to read most of the
> instructions and etiquettes regarding the
*dev, unsigned bus,
> dev_err(&dev->intf->dev,
> "%s: em28xx_i2_eeprom failed! retval [%d]\n",
> __func__, retval);
> -
> - return retval;
> }
> }
>
Makes sense.
Acked-by: Frank Schäfer
Am 03.05.2017 um 04:12 schrieb Mauro Carvalho Chehab:
> There's a new version of Terratec H6 with uses USB ID
> 0ccd:10b2. This version is similar to the old one (with is
> supported via the HTC entry), except that this one has the
> eeprom on the second bus.
Last half of the sentence isn't true (
Am 01.05.2017 um 19:54 schrieb Mauro Carvalho Chehab:
> Hi Frank,
>
> Em Mon, 1 May 2017 16:11:51 +0200
> Frank Schäfer escreveu:
>
>> Am 01.05.2017 um 13:38 schrieb Mauro Carvalho Chehab:
>>> Right now, all devices use bus 0 for eeprom. However, newer
>>>
Am 01.05.2017 um 13:38 schrieb Mauro Carvalho Chehab:
> Right now, all devices use bus 0 for eeprom. However, newer
> versions of Terratec H6 use a different buffer for eeprom.
>
> So, add support to use a different I2C address for eeprom.
Has this been tested ?
Did you read my reply to the previ
Am 28.04.2017 um 13:22 schrieb Giuseppe Toscano:
> I am trying to use eMPIA Technology, Inc. GrabBeeX+ Video Encoder
> (card=21) but the em28xx driver erroneously identifies it as
> EM2860/SAA711X Reference Design (card = 19).
> Attached the output of lsusb and dmesg.
>
Card 21 is an em2800 device
Hi Mauro,
is there a chance that we can clean up the em28xx debug module parameter
mess ?
There are currently 8 (!) of them.
Do we have to maintain them all forever as "stable userspace interface" ?
For example:
- "reg_debug" is actually used for usb control message debugging
- "core_debug" is a
- avoid duplicate debugging messages in em28xx_read_reg_req_len()
- do not describe successful usb transfers in em28xx_read_reg_len()
as "failed"
- report errors in em28xx_write_regs_req(), too
- print the usb error numbers, too
Signed-off-by: Frank Schäfer
---
drivers/media/usb/em2
Am 25.04.2017 um 12:06 schrieb Mauro Carvalho Chehab:
> Right now, all devices use bus 0 for eeprom. However,
> it seems that newer versions of Terratec H6 uses a different
> buffer for eeprom.
>
> So, add support to use a different I2C address for eeprom and
> add a new card ID for the board desc
Am 15.04.2017 um 20:28 schrieb Anders Eriksson:
> Hi Mauro,
>
> I've two devices using this driver, and whenever I have them both in
> use I eventually (between 10K and 100K secs uptime) i2c write errors
> such as in the log below. If only have one of the devices in use, the
> machine is stable.
>
es the ID as if they were read
in big-endian. So, we need to change the byte order in order to
match the ID number as described on their datasheets.
Signed-off-by: Frank Schäfer
Acked-by: Mauro Carvalho Chehab
---
drivers/media/usb/em28xx/em28xx-camera.c | 28
1 fil
ov2640_select_win() returns height and width values as part of struct
ov2640_win_size, so there is no point in modifying the passed height and
width parameters, too.
Signed-off-by: Frank Schäfer
---
drivers/media/i2c/ov2640.c | 18 +++---
1 file changed, 7 insertions(+), 11
Signed-off-by: Frank Schäfer
---
drivers/media/i2c/ov2640.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/drivers/media/i2c/ov2640.c b/drivers/media/i2c/ov2640.c
index 6aba0ffe486d..618230e782e7 100644
--- a/drivers/media/i2c/ov2640.c
+++ b/drivers/media/i2c/ov2640.c
t the current documentation of sensor register 0x04
is wrong (has changed after preliminary datasheet version 2.2).
I'm pretty sure that automatic vertical line shift/switch can be enabled,
too, but until anyone finds ot how this works, we have to stick with manual
switching.
Signed-off-by: Fra
HSIZE and VSIZE bits 0 to 2 and HSIZE bit 11 are encoded in DSP register
SIZEL.
Signed-off-by: Frank Schäfer
---
drivers/media/i2c/ov2640.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/media/i2c/ov2640.c b/drivers/media/i2c/ov2640.c
index 11f1b807c292..6f0cc722477d 100644
(e.g. large blue background)
2) Advanced AWB: uses color temperature information
+ more accurate, works with all image contents
- lens specific, requires calibration
Signed-off-by: Frank Schäfer
---
drivers/media/i2c/ov2640.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --
- add missing initialisation of sensor register COM25 (2 MSBs of banding
filter AEC values)
- add macros for setting the banding filter AEC values
- add definitions for sensor register 0x5a, which is documented in
Omnivisions software application notes
Signed-off-by: Frank Schäfer
First 5 patches are minor fixes/cleanups/improvements which I came
across while testing Hans Verkuils patches and trying to figure out
what's going wrong with vflip control.
Patch 6 finally fixes the vflip bug.
Patch 7 adds support for 2 new pixel formats.
Frank Schäfer (7):
ov2640: fix
While we are at it, remove a misleading comment (copy/paste mistake)
Signed-off-by: Frank Schäfer
---
drivers/media/i2c/ov2640.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/media/i2c/ov2640.c b/drivers/media/i2c/ov2640.c
index
With MEDIA_SUBDRV_AUTOSELECT enabled in the kernel config, the em28xx
driver currently does't select some used subdrivers.
Fix this by adding the missing auto-selections to the Kconfig file.
Signed-off-by: Frank Schäfer
---
drivers/media/usb/em28xx/Kconfig | 7 ++-
1 file chang
The v4l2 dummy clock has been added with commit fc5d0f8a8878
("V4L2: em28xx: register a V4L2 clock source") to be able to use the ov2640
soc_camera driver.
Since commit 46796cfcd346 ("ov2640: use standard clk and enable it") it is
no longer required.
Signed-off-by: Frank S
very low and therefore not worth the efforts.
Instead, just don't treat the device as camera.
A message will then be printed to the log that the device isn't supported.
Signed-off-by: Frank Schäfer
---
drivers/media/usb/em28xx/em28xx-cards.c | 10 +++---
1 file changed, 7 insert
Signed-off-by: Frank Schäfer
---
drivers/media/usb/em28xx/em28xx-video.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/media/usb/em28xx/em28xx-video.c
b/drivers/media/usb/em28xx/em28xx-video.c
index aaa83f9e5c1a..8d253a5df0a9 100644
--- a/drivers/media/usb/em28xx/em28xx
two camera devices and 0x08-0x0b
are at least 16 bits per pixel formats on em2710/em2820, too, and
0x0c-0x0f are at least 8 bits per pixel formats on em2765, too.
Signed-off-by: Frank Schäfer
---
drivers/media/usb/em28xx/em28xx-camera.c | 10 --
drivers/media/usb/em28xx/em28xx-reg.h| 18
Am 26.03.2017 um 16:24 schrieb Frank Schäfer:
>
>
> Am 24.03.2017 um 20:16 schrieb Mauro Carvalho Chehab:
>> Em Thu, 23 Mar 2017 19:03:20 +0100
>> Frank Schäfer escreveu:
>>
>>> Am 23.03.2017 um 13:56 schrieb Mauro Carvalho Chehab:
>>>> Em Th
Am 24.03.2017 um 20:16 schrieb Mauro Carvalho Chehab:
Em Thu, 23 Mar 2017 19:03:20 +0100
Frank Schäfer escreveu:
Am 23.03.2017 um 13:56 schrieb Mauro Carvalho Chehab:
Em Thu, 23 Mar 2017 13:01:32 +0100
Frank Schäfer escreveu:
Am 22.03.2017 um 15:46 schrieb Mauro Carvalho Chehab:
Em
Am 23.03.2017 um 13:56 schrieb Mauro Carvalho Chehab:
Em Thu, 23 Mar 2017 13:01:32 +0100
Frank Schäfer escreveu:
Am 22.03.2017 um 15:46 schrieb Mauro Carvalho Chehab:
Em Sun, 19 Feb 2017 19:29:18 +0100
Frank Schäfer escreveu:
Use i2c_smbus_read_word_data() instead of i2c_master_send
Am 22.03.2017 um 15:46 schrieb Mauro Carvalho Chehab:
Em Sun, 19 Feb 2017 19:29:18 +0100
Frank Schäfer escreveu:
Use i2c_smbus_read_word_data() instead of i2c_master_send() and
i2c_master_recv() for reading the ID of Micorn sensors.
Bytes need to be swapped afterwards, because
Am 06.03.2017 um 15:56 schrieb Hans Verkuil:
From: Hans Verkuil
Convert ov2640 to a standard subdev driver. The soc-camera driver no longer
uses this driver, so it can safely be converted.
Note: the s_power op has been dropped: this never worked. When the last open()
is closed, then the power
Am 27.02.2017 um 21:21 schrieb Łukasz Strzeszkowski:
Hi,
I’ve found a new device which is not listed
model: LogiLink VG0011
vendor/product: [1d19:6901] Dexatek Technology Ltd.
mode: analog
I am unable to load a driver, because there is no such vendor in driver list.
dmesg output:
[
with 16 bit register width use big endian
byte order.
Signed-off-by: Frank Schäfer
---
drivers/media/usb/em28xx/em28xx-camera.c | 28
1 file changed, 4 insertions(+), 24 deletions(-)
diff --git a/drivers/media/usb/em28xx/em28xx-camera.c
b/drivers/media/usb/em28xx
ff-by: Frank Schäfer
---
drivers/media/usb/em28xx/em28xx-camera.c | 42 +++-
1 file changed, 20 insertions(+), 22 deletions(-)
diff --git a/drivers/media/usb/em28xx/em28xx-camera.c
b/drivers/media/usb/em28xx/em28xx-camera.c
index 89c890ba7dd6..7b4129ab1cf9 100644
Hi Arnd,
Am 13.02.2017 um 15:00 schrieb Hans Verkuil:
Hi Arnd,
I'll take the others of this patch series, but will postpone this one until it
has
been tested.
I've asked Frank to see if he can test it, if not, then it will have to wait
until
March when I have access to an omnivision-em28xx d
8
> drivers/media/usb/em28xx/em28xx-core.c | 4 ++--
> drivers/media/usb/em28xx/em28xx-dvb.c | 14 +++---
> drivers/media/usb/em28xx/em28xx-input.c | 9 -
> drivers/media/usb/em28xx/em28xx-video.c | 6 +++---
> 5 files changed, 20 insertions(+), 21 deletion
Am 20.12.2014 um 15:51 schrieb Russell King - ARM Linux:
> On Sat, Dec 20, 2014 at 03:11:54PM +0100, Frank Schäfer wrote:
>> Hi Russel,
> I guess you won't mind if I mis-spell your name too...
Wow... it seems to be very easy to offend you...
Sorry, that was definitely not my int
Am 20.12.2014 um 13:44 schrieb Russell King - ARM Linux:
> It isn't clear who is the maintainer for this driver; there is no
> MAINTAINERS entry. If there is a maintainer, please ensure that they
> add themselves to this critical file. Thanks.
(line 3598)
EM28XX VIDEO4LINUX DRIVER
M:Mauro
NOT been tested with all possible cases.
I don't have the hardware and could only verify that it fixes the reported
bug.
Reported-by: Fengguag Wu
Signed-off-by: Frank Schäfer
Cc:
---
drivers/media/usb/dvb-usb/af9005.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/me
Am 25.09.2014 um 16:49 schrieb Dan Carpenter:
> On Thu, Sep 25, 2014 at 04:08:31PM +0200, Frank Schäfer wrote:
>>> ir = kzalloc(sizeof(*ir), GFP_KERNEL);
>>> + if (!ir)
>>> + return -ENOMEM;
>>> rc = rc_allocate_device();
(Resending because my crappy modem crashed while sending)
Am 25.09.2014 um 16:07 schrieb Mauro Carvalho Chehab:
> Em Thu, 25 Sep 2014 15:59:12 +0200
> Frank Schäfer escreveu:
>
>> Am 24.09.2014 um 01:18 schrieb Mauro Carvalho Chehab:
>>> Em Tue, 23 Sep 2014 21:32:02
Hi Dan,
Am 25.09.2014 um 13:39 schrieb Dan Carpenter:
> We call "kfree(ir->i2c_client);" in the error handling and that doesn't
> work if "ir" is NULL.
>
> Fixes: 78e719a5f30b ('[media] em28xx-input: i2c IR decoders: improve
> i2c_client handling')
> Signed-off-by: Dan Carpenter
>
> diff --git a
Am 24.09.2014 um 01:18 schrieb Mauro Carvalho Chehab:
> Em Tue, 23 Sep 2014 21:32:02 +0200
> Frank Schäfer escreveu:
>
>> Am 19.09.2014 um 18:02 schrieb Mauro Carvalho Chehab:
>>> When both VBI and video are streaming, and video stream is stopped,
>>> a subsequ
Am 23.09.2014 um 23:03 schrieb Luca Olivetti:
> El 23/09/14 20:52, Frank Schäfer ha escrit:
>
>>>> This seems to be an ancient bug, which is known at least since 5 1/2 years:
>>>> https://lkml.org/lkml/2009/2/4/350
> [...]
>>> #if defined(CONFIG_MODUL
Am 19.09.2014 um 18:02 schrieb Mauro Carvalho Chehab:
> When both VBI and video are streaming, and video stream is stopped,
> a subsequent trial to restart it will fail, because S_FMT will
> return -EBUSY.
>
> That prevents applications like zvbi to work properly.
>
> Please notice that, while thi
Am 19.09.2014 um 21:55 schrieb Luca Olivetti:
> El 19/09/14 21:22, Frank Schäfer ha escrit:
>
>>> So symbol_request() returns pointers.!= NULL
>>>
>>> A closer look at the definition of symbol_request() shows, that it does
>>> nothing if CONFIG_MODULES
Am 23.09.2014 um 04:27 schrieb kbuild test robot:
> tree: git://linuxtv.org/media_tree.git devel-3.17-rc6
> head: 7f8de65b0dc84c19e79d7a642a5655524c57035c
> commit: f5ac7a471e156f997833f94bad2228e57122c227 [491/499] [media] em28xx:
> remove some unnecessary fields from struct em28xx_audio_mod
Am 23.09.2014 um 02:02 schrieb Mauro Carvalho Chehab:
> Em Sat, 13 Sep 2014 10:52:22 +0200
> Frank Schäfer escreveu:
>
>> Now that we have enum em28xx_int_audio (none/i2s/ac97), it is no longer
>> necessary to check dev->audio_mode.ac97 to determine the type of inter
(adjusting the title and adding Luca Olivetti (dvb_usb_af9005 author)
and Antti Palosaari)
Am 19.09.2014 um 21:01 schrieb Frank Schäfer:
> Hi Fengguang,
>
> thank you for reporting this issue.
>
> Am 19.09.2014 um 03:41 schrieb Fengguang Wu:
[...]
>> [8.528015] us
struct
> em28xx to struct em28xx_audio
>
> Both wq_trigger and stream_started are used only to control the em28xx
> alsa streaming. They don't belong to em28xx common struct.
>
> Signed-off-by: Frank Schäfer
> Signed-off-by: Hans Verkuil
> Signe
ice node is open and a second device node is opened
(closed), the device is reinitialized (streaming is stopped).
Reported-by: Hans Verkuil
Signed-off-by: Frank Schäfer
---
drivers/media/usb/em28xx/em28xx-video.c | 23 ++-
drivers/media/usb/em28xx/em28xx.h | 1 +
2 fi
Hi Hans,
Am 18.09.2014 um 21:13 schrieb Hans Verkuil:
> Hi Frank,
>
> On 07/25/2014 07:48 PM, Frank Schäfer wrote:
>> Instead of counting the number of opened file handles, use function
>> v4l2_fh_is_singular_file() in em28xx_v4l2_open() and em28xx_v4l2_close() to
>> d
Setting the value of the chip config register to EM28XX_CHIPCFG_AC97 in case of
a read error is a leftover from the past which is no longer needed.
Signed-off-by: Frank Schäfer
---
drivers/media/usb/em28xx/em28xx-core.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a
Fields "ac97_feat", "ac97_vendor_id" and "i2s_samplerates" of struct
em28xx_audio_mode are used nowhere, except in function em28xx_audio_setup().
So get rid of them and use local variables instead.
Signed-off-by: Frank Schäfer
---
drivers/media
7 with equivalent checks
of dev->int_audio_type and get rid of struct em28xx_ac97_mode and finally the
whole struct em28xx_audio_mode.
Signed-off-by: Frank Schäfer
---
drivers/media/usb/em28xx/em28xx-audio.c | 2 +-
drivers/media/usb/em28xx/em28xx-core.c | 36 ++---
driv
by replacing fields
"has_audio_class" (device has usb audio class compliant interface) and
"has_alsa_audio" (device has vendor audio interface) in struct em28xx with a
single enum em28xx_usb_audio_type.
Signed-off-by: Frank Schäfer
---
drivers/media/usb/em28xx/em28xx-audio.c |
de and finally the
whole struct em28xx_audio_mode.
Signed-off-by: Frank Schäfer
---
drivers/media/usb/em28xx/em28xx-core.c | 14 --
drivers/media/usb/em28xx/em28xx-video.c | 6 +++---
drivers/media/usb/em28xx/em28xx.h | 8 +++-
3 files changed, 18 insertions(+), 10 deleti
th the obsolete structs
"em28xx_audio_mode" and "em28xx_ac97_mode".
This simplifies the audio code a lot, making it much more self-explaining and
easier to understand.
It will hopefully reduce the risk of audio regression in the future.
Frank Schäfer (4):
em28xx: remove some unneces
Am 02.09.2014 um 08:28 schrieb Lorenzo Marcantonio:
> On Mon, Sep 01, 2014 at 07:58:52PM -0400, Andy Walls wrote:
>> A Merlin firmware of 16 kB strongly suggests that this chip has an
>> integarted Conexant CX25843 (Merlin Audio + Thresher Video = Mako)
>> Broadtcast A/V decoder core. The chip mi
Am 01.09.2014 um 21:03 schrieb Lorenzo Marcantonio:
> On Mon, Sep 01, 2014 at 08:14:25PM +0200, Frank Schäfer wrote:
>
>> What's the other device using this vid:pid and which hardware does it use ?
> The previous generation of the tool:
>
> http://www.linuxtv.org/wiki/i
ls out immediately at the beginning.
Revert the faulty commit to restore the old audio detection procedure, which
checks
the chip configuration register to determine if the device has analog audio.
Cc: # 3.14 to 3.16
Reported-by: Oravecz Csaba
Tested-by: Oravecz Csaba
Signed-off-by: Frank S
Am 01.09.2014 um 09:31 schrieb Oravecz Csaba:
> Sun Aug 31 17:07:00 2014 =?windows-1252?Q?Frank_Sch=E4fer?= kirjutas:
>>
>> Am 22.08.2014 um 21:03 schrieb Oravecz Csaba:
>>> I reported this issue earlier but for some reason it went pretty much
>>> unnoticed. The essence is that with the newest em2
Am 31.08.2014 um 17:41 schrieb Lorenzo Marcantonio:
> On Sun, Aug 31, 2014 at 04:50:08PM +0200, Frank Schäfer wrote:
>> Hmm... could you send us the output of "lsusb -v -d 1b80:e31d ?
> Sure, here is it. However it seems that roxio violated the most sacred
> USB rule (i.e. t
Am 22.08.2014 um 21:03 schrieb Oravecz Csaba:
> I reported this issue earlier but for some reason it went pretty much
> unnoticed. The essence is that with the newest em28xx drivers now present in
> 3.14 kernels (i'm on stock fedora 3.14.15-100.fc19.i686.PAE) I can't get
> analogue sound from this
Am 31.08.2014 um 16:47 schrieb Frank Schäfer:
> Hi Lorenzo,
>
> Am 25.08.2014 um 21:01 schrieb Lorenzo Marcantonio:
>> Just bought a roxio video capture dongle. Read around that it was an
>> easycap clone (supported, then); it seems it's not so anymore :(
>>
>
Hi Lorenzo,
Am 25.08.2014 um 21:01 schrieb Lorenzo Marcantonio:
> Just bought a roxio video capture dongle. Read around that it was an
> easycap clone (supported, then); it seems it's not so anymore :(
>
> It identifies as 1b80:e31d Roxio Video Capture USB
>
> (it also uses audio class for audio)
bit.
Also make sure that all fields of struct i2c_client are initialized properly.
Signed-off-by: Frank Schäfer
---
drivers/media/usb/em28xx/em28xx-input.c | 23 +--
1 file changed, 13 insertions(+), 10 deletions(-)
diff --git a/drivers/media/usb/em28xx/em28xx-input.c
b
Am 09.08.2014 um 11:58 schrieb Hans Verkuil:
> On 08/07/2014 06:36 PM, Frank Schäfer wrote:
>> Am 07.08.2014 um 08:45 schrieb Hans Verkuil:
>>> On 08/05/2014 05:18 PM, Frank Schäfer wrote:
>>>> Hi Hans,
>>>>
>>>> Am 05.08.2014 um 09:00 s
The correct field order in progressive mode is V4L2_FIELD_NONE, not
V4L2_FIELD_INTERLACED.
Cc:
Signed-off-by: Frank Schäfer
---
drivers/media/usb/em28xx/em28xx-video.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/media/usb/em28xx/em28xx-video.c
b/drivers
8/0x80
[] sysenter_do_call+0x12/0x12
---[ end trace 5545f934409f13f4 ]---
...
Many thanks to Hans Verkuil, whose recently added check in the vb2 core unveiled
this long standing issue and who has investigated it further.
Cc:
Signed-off-by: Frank Schäfer
---
drivers/media/usb/em28xx/em28xx-v
Am 07.08.2014 um 08:45 schrieb Hans Verkuil:
> On 08/05/2014 05:18 PM, Frank Schäfer wrote:
>> Hi Hans,
>>
>> Am 05.08.2014 um 09:00 schrieb Hans Verkuil:
>>> Fix three compiler warnings:
>>>
>>> drivers/media/usb/em28xx/em28xx-input.c: In funct
Hi Hans,
Am 05.08.2014 um 09:00 schrieb Hans Verkuil:
> Fix three compiler warnings:
>
> drivers/media/usb/em28xx/em28xx-input.c: In function
> ‘em28xx_i2c_ir_handle_key’:
> drivers/media/usb/em28xx/em28xx-input.c:318:1: warning: the frame size of
> 1096 bytes is larger than 1024 bytes [-Wframe-
Am 28.07.2014 um 17:27 schrieb Hans Verkuil:
...
> OK, I looked at it: the problem is in get_next_buf() and
> finish_field_prepare_next().
> In get_next_buf() the driver gets a buffer from the active list and deletes
> it from
> that list. In finish_field_prepare_next() that buffer is given back
care.
>*/
> val = ptr.p_s64[idx];
> - if (ctrl->maximum >= 0 && val >= ctrl->maximum - ctrl->step / 2)
> + if (ctrl->maximum >= 0 && val >= ctrl->maximum -
> (s64)(ctrl->step / 2))
>
Am 25.07.2014 21:07, schrieb Hans Verkuil:
> On 07/25/2014 06:20 PM, Frank Schäfer wrote:
>> Hi Hans,
>>
>> I'm getting the following warnings with the em28xx driver on streaming stop:
>>
>> [ 7597.346168] WARNING: CPU: 1 PID: 3730 at
>> d
Hans,
sorry for bothering you with another issue on friday evening. :-/
But it seems that commit 958c7c7e65 ("[media] v4l2-ctrls: fix corner
case in round-to-range code") introduced a regression for controls which
are using a negative integer value range.
All negative values are mapped to the maxi
Fixes an old copy+paste bug that has survived all recent code
changes in this code area.
Signed-off-by: Frank Schäfer
---
drivers/media/usb/em28xx/em28xx-video.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/usb/em28xx/em28xx-video.c
b/drivers/media/usb
This patch series consists of 4 cleanup patches for the em28xx-v4l module.
Frank Schäfer (4):
em28xx-v4l: simplify some pointers in em28xx_init_camera()
em28xx-v4l: get rid of struct em28xx_fh
em28xx-v4l: simplify em28xx_v4l2_open() by using v4l2_fh_open()
em28xx-v4l: get rid of field
Pointer v4l2" can be used instead of "dev->v4l2, which saves some characters.
Signed-off-by: Frank Schäfer
---
drivers/media/usb/em28xx/em28xx-camera.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/usb/em28xx/em28xx-camera.c
b/drivers/med
struct em28xx_fh isn't needed anymore because the only used field which is left
is struct v4l2_fh fh.
Use struct v4l2_fh directly and remvove struct em28xx_fh.
Signed-off-by: Frank Schäfer
---
drivers/media/usb/em28xx/em28xx-video.c | 83 -
drivers/medi
Instead of counting the number of opened file handles, use function
v4l2_fh_is_singular_file() in em28xx_v4l2_open() and em28xx_v4l2_close() to
determine if the file handle is the first/last opened one.
Signed-off-by: Frank Schäfer
---
drivers/media/usb/em28xx/em28xx-video.c | 23
Instead of calling
...
struct v4l2_fh *fh = kzalloc(sizeof(*fh), GFP_KERNEL);
filp->private_data = fh;
v4l2_fh_init(fh, vdev);
v4l2_fh_add(fh);
...
simply use function v4l2_fh_open() which does all of these calls for us.
Signed-off-by: Frank Schäfer
---
drivers/media/usb/em28xx/em28xx-vide
Hi Hans,
I'm getting the following warnings with the em28xx driver on streaming stop:
[ 7597.346168] WARNING: CPU: 1 PID: 3730 at
drivers/media/v4l2-core/videobuf2-core.c:2126
__vb2_queue_cancel+0xf5/0x150 [videobuf2_core]()
[ 7597.346171] Modules linked in: em28xx_rc snd_usb_audio ov2640
soc_cam
e=1
>
>
> What could be wrong?
Before kernel 3.10, the brightness (contrast, ...) controls are provided
by the subdevice drivers.
With kernel 3.10 I have introduced bridge level image controls, but they
are currently only used/activated if the subdevice doesn't already
provide them (as sugg
rg/patch/23883/
All other patches still apply.
Many thanks for reviewing the patches and your comments !
Regards,
Frank
>
> Regards,
>
> Hans
>
> On 03/24/2014 08:33 PM, Frank Schäfer wrote:
>> This patch series cleans up the main device struct of the em28xx driver.
&g
Signed-off-by: Frank Schäfer
---
drivers/media/usb/em28xx/em28xx-video.c | 27 +++
drivers/media/usb/em28xx/em28xx.h | 5 +++--
2 files changed, 18 insertions(+), 14 deletions(-)
diff --git a/drivers/media/usb/em28xx/em28xx-video.c
b/drivers/media/usb/em28xx
Am 09.05.2014 11:19, schrieb Hans Verkuil:
> On 03/24/2014 08:33 PM, Frank Schäfer wrote:
>> Signed-off-by: Frank Schäfer
>> ---
>> drivers/media/usb/em28xx/em28xx-video.c | 120
>> ++--
>> drivers/media/usb/em28xx/em28xx.h
Am 09.05.2014 11:17, schrieb Hans Verkuil:
> Some comments for future improvements:
>
> On 03/24/2014 08:33 PM, Frank Schäfer wrote:
>> Signed-off-by: Frank Schäfer
>> ---
>> drivers/media/usb/em28xx/em28xx-camera.c | 4 +-
>> drivers/media
It is no longer needed since nobody is calling i2c_get_adapdata() anymore.
Signed-off-by: Frank Schäfer
---
drivers/media/usb/em28xx/em28xx-i2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/usb/em28xx/em28xx-i2c.c
b/drivers/media/usb/em28xx/em28xx-i2c.c
Hi Hans,
Am 09.05.2014 10:40, schrieb Hans Verkuil:
> Hi Frank,
>
> I've got a comment about this patch:
>
> On 03/22/2014 02:01 PM, Frank Schäfer wrote:
>> Signed-off-by: Frank Schäfer
>> ---
>> drivers/media/usb/em28xx/em28xx-i2c.c | 2 +-
>>
699.476200] em2750 #0: board has no eeprom
> [12699.547792] em2750 #0: No sensor detected
As you can see, no sensor is found.
Does this also happen with the working kernel ?
Regards,
Frank Schäfer
> [12699.583014] em2750 #0: found i2c device @ 0xba on bus 0 [webcam
> sensor or tvp5150a]
Signed-off-by: Frank Schäfer
---
drivers/media/usb/em28xx/em28xx-camera.c | 4 +-
drivers/media/usb/em28xx/em28xx-video.c | 160 +--
drivers/media/usb/em28xx/em28xx.h| 8 +-
3 files changed, 116 insertions(+), 56 deletions(-)
diff --git a/drivers/media
Signed-off-by: Frank Schäfer
---
drivers/media/usb/em28xx/em28xx-video.c | 16 +---
drivers/media/usb/em28xx/em28xx.h | 3 ++-
2 files changed, 11 insertions(+), 8 deletions(-)
diff --git a/drivers/media/usb/em28xx/em28xx-video.c
b/drivers/media/usb/em28xx/em28xx-video.c
Signed-off-by: Frank Schäfer
---
drivers/media/usb/em28xx/em28xx-camera.c | 20 ++--
drivers/media/usb/em28xx/em28xx-video.c | 6 --
drivers/media/usb/em28xx/em28xx.h| 10 ++
3 files changed, 20 insertions(+), 16 deletions(-)
diff --git a/drivers/media/usb
The tda9887 configuration is already stored in the board data, and it is used
only one time by the v4l2 sub-module at tuner setup.
Signed-off-by: Frank Schäfer
---
drivers/media/usb/em28xx/em28xx-cards.c | 3 ---
drivers/media/usb/em28xx/em28xx-video.c | 6 +++---
drivers/media/usb/em28xx
Signed-off-by: Frank Schäfer
---
drivers/media/usb/em28xx/em28xx-camera.c | 16
drivers/media/usb/em28xx/em28xx-video.c | 10 +-
drivers/media/usb/em28xx/em28xx.h| 6 +++---
3 files changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/media/usb
Signed-off-by: Frank Schäfer
---
drivers/media/usb/em28xx/em28xx-camera.c | 11 ++-
drivers/media/usb/em28xx/em28xx-video.c | 6 +++---
drivers/media/usb/em28xx/em28xx.h| 2 +-
3 files changed, 10 insertions(+), 9 deletions(-)
diff --git a/drivers/media/usb/em28xx/em28xx
Signed-off-by: Frank Schäfer
---
drivers/media/usb/em28xx/em28xx-video.c | 44 +
drivers/media/usb/em28xx/em28xx.h | 13 +-
2 files changed, 29 insertions(+), 28 deletions(-)
diff --git a/drivers/media/usb/em28xx/em28xx-video.c
b/drivers/media/usb
Signed-off-by: Frank Schäfer
---
drivers/media/usb/em28xx/em28xx-video.c | 35 ++---
drivers/media/usb/em28xx/em28xx.h | 3 ++-
2 files changed, 21 insertions(+), 17 deletions(-)
diff --git a/drivers/media/usb/em28xx/em28xx-video.c
b/drivers/media/usb/em28xx
The tuner address is only used by the v4l submodule and at tuner setup and
can be obtained from the board data directly (if specified).
Signed-off-by: Frank Schäfer
---
drivers/media/usb/em28xx/em28xx-cards.c | 2 --
drivers/media/usb/em28xx/em28xx-video.c | 17 -
drivers/media
Signed-off-by: Frank Schäfer
---
drivers/media/usb/em28xx/em28xx-vbi.c | 10 +++--
drivers/media/usb/em28xx/em28xx-video.c | 80 +++--
drivers/media/usb/em28xx/em28xx.h | 16 ---
3 files changed, 61 insertions(+), 45 deletions(-)
diff --git a/drivers
Signed-off-by: Frank Schäfer
---
drivers/media/usb/em28xx/em28xx-video.c | 14 +++---
drivers/media/usb/em28xx/em28xx.h | 3 +--
2 files changed, 8 insertions(+), 9 deletions(-)
diff --git a/drivers/media/usb/em28xx/em28xx-video.c
b/drivers/media/usb/em28xx/em28xx-video.c
index
1 - 100 of 836 matches
Mail list logo
