Re: video capture driver interlacing question (easycap)

2012-04-29 Thread Ezequiel García
Hi, > > i.e., no, you should not merge fields in the driver, IIRC, you just hand > them over to the user in separate buffers. > Thanks a lot for your answer. However, in that case I'm a little confused by the fact that em28xx driver merges both fields by copying one line from each into a buffer b

Re: video capture driver interlacing question (easycap)

2012-04-28 Thread Ezequiel García
On Thu, Apr 26, 2012 at 5:33 PM, Ezequiel García wrote: > Hi everyone, > > As you may know I'm re-writing from scratch the staging/easycap driver. > > Finally, after digging through the labyrinthic staging/easycap code, > I've reached a point where I'm able to u

video capture driver interlacing question (easycap)

2012-04-26 Thread Ezequiel García
Hi everyone, As you may know I'm re-writing from scratch the staging/easycap driver. Finally, after digging through the labyrinthic staging/easycap code, I've reached a point where I'm able to understand isoc packets. Despite not having any documentation (I asked several times) from chip vendor,

Re: [PATCH] TDA9887 PAL-Nc fix

2012-04-20 Thread Ezequiel García
Hola ;) > > From other discussions we've had at the ML, it seems that devices sold in > Argentina with analog tuners sometimes come with a NTSC tuner, and sometimes > come with an European PAL tuner. They solve the frequency shifts that > happen there via some tda9887 (and/or tuner-simple) adjustm

Re: dvb lock patch

2012-04-18 Thread Ezequiel García
Josu, On Tue, Apr 17, 2012 at 10:30 AM, Josu Lazkano wrote: > 2012/3/24 Mauro Carvalho Chehab : [snip] >> >> That doesn't sound right to me, and can actually cause race issues. >> >> Regards, >> Mauro. > > Thanks for the patch Mauro. > I think Mauro is *not* giving you a patch, rather the opposi

Re: [PATCH 0/5] Make em28xx-input.c a separate module

2012-04-10 Thread Ezequiel García
2012/3/26 Ezequiel García : > Hi, [snip] > >  drivers/media/video/em28xx/Kconfig        |    4 +- >  drivers/media/video/em28xx/Makefile       |    5 +- >  drivers/media/video/em28xx/em28xx-cards.c |   66 + >  drivers/media/video/em28xx/em28xx-core.c  |    3 + >  drive

Re: Hauppauge WinTV HVR 930C-HD - new USB ID 2040:b130 ?

2012-03-26 Thread Ezequiel García
On 3/26/12, Neumann, Steffen wrote: > Not the answer I was looking for, > But thanks everybody for the clarification. > I'll try to register for the wiki and add I guess as a customer you could also contact the vendors and ask to support the device. Can't hurt, right? -- To unsubscribe from this

Re: Hauppauge WinTV HVR 930C-HD - new USB ID 2040:b130 ?

2012-03-26 Thread Ezequiel García
Hi, 2012/3/26 Steffen Neumann : > sorry for bothering you directly, but I saw that No problem. > you kinda work on em288xx. I asked yesterday on linux-media True about "kinda", I don't own any em28xx devices :) > about my problems with the em28xx based 930C > on a 3.3 vanilla kernel. Yes, I s

[PATCH 0/5] Make em28xx-input.c a separate module

2012-03-26 Thread Ezequiel García
Hi, This patchset isolates em28xx-input code and turns it into a module, as suggested by Mauro [1]. Contrary to my initial expectations, the patch produces code that's actually cleaner and a slightly less spaghetti. I've tried to make the whole change as clear as possible by splitting it into se

Re: [Q] v4l buffer format inside isoc

2012-03-21 Thread Ezequiel García
2012/3/21 Devin Heitmueller : > I'm not sure what you mean by "no video".  Do you have capture > disabled?  Are you saying that you didn't connect the video cable to > your input?  Most devices will continue to generate video frames over > isoc even if there is no actual video signal present. I me

Re: [Q] v4l buffer format inside isoc

2012-03-21 Thread Ezequiel García
Hi, 2012/3/21 Devin Heitmueller : > > Every USB bridge provides their raw video over isoc in a slightly > different format (not just in terms of the colorspace but also how to > read the isoc header to detect the start of video frame, which field > is being sent, etc).  Regarding the colorspace, i

Re: [Q] v4l buffer format inside isoc

2012-03-21 Thread Ezequiel García
Hi, 2012/3/21 Jean-Francois Moine : > In the gspca test tarball (see my site), I merged the spca506 code into > the spca505 for a webcam which may also do analog video capture. The > webcam works, but the analog video capture has never been tested. > Also, the gspca_main <-> subdriver interface fo

Re: [Q] v4l buffer format inside isoc

2012-03-21 Thread Ezequiel García
2012/3/20 Andy Walls : > > Section 8.10 of the SAA7113 data sheet shows 16 "data formats".  The > interesting one for video is #15 Y:U:V 4:2:2. Thanks. Perhaps, I should have done my homework. > > The EM28xx chip programming might rearrange some data, but I have no > knowledge or experience with

[Q] v4l buffer format inside isoc

2012-03-20 Thread Ezequiel García
Hello, I'm a little lost while writing a driver for an easycap device (saa7113 capture device). I have my isoc handler, and the isoc urb flying OK. I also have the videobuf2 queue setup (or at least I think so), and I understand I need to call vb2_buffer_done() with a filled buffer. What I DON'T

Re: [PATCH] go7007 patch for 3.2.x

2012-03-20 Thread Ezequiel García
Hi Volokh, > > You would need to make this at least against the 3.3 kernel, preferably > against the linux-next branch. You can follow the instructions here to work off the for_v3.4 branch: http://git.linuxtv.org/media_tree.git > > Also, you didn't read the Documentation/SubmittingPatches file,

Re: A second easycap driver implementation

2012-03-19 Thread Ezequiel García
Hi Mauro, On 3/7/12, Mauro Carvalho Chehab wrote: > > The usage of saa711x is simple. All you need to do is to implement > an I2C bus at your easycap driver, load the module, and then, redirect > any demod ioctl call to the I2C bus, like: > > static int vidioc_querystd(struct file *file, void *pr

Re: [PATCH v2] media: rc: Pospone ir raw decoders loading until really needed

2012-03-15 Thread Ezequiel García
Hi Jarod, On Thu, Mar 15, 2012 at 6:35 PM, Jarod Wilson wrote: > > So yeah, ok, I'm fine with this. Haven't tested it with actual raw IR > hardware, but I don't see any reason it wouldn't work. > > Acked-by: Jarod Wilson Thanks for the feedback. I have a paranoid question: Is it ok to solve thi

Re: [PATCH] media: rc: Pospone ir raw decoders loading until really needed

2012-03-15 Thread Ezequiel García
>>       if (dev->driver_type == RC_DRIVER_IR_RAW) { >> +             /* Load raw decoders, if they aren't already */ >> +             if (dev->raw_init) { > > The logic here seems to be inverted. it should be, instead !dev->raw_init. Duh! Sorry about that. I'm *way* too accustomed to test things

Re: eMPIA EM2710 Webcam (em28xx) and LIRC

2012-03-15 Thread Ezequiel García
Hi Mauro, On 3/15/12, Mauro Carvalho Chehab wrote: > If you won't take it, it is likely that some day someone will do it, > but, as this is just a cleanup, the main developers won't likely > have time for doing it, as they're generally busy adding support for > new hardware. > I have no problem

Re: eMPIA EM2710 Webcam (em28xx) and LIRC

2012-03-14 Thread Ezequiel García
Hi, > > I'm positive, the LIRC modules aren't loaded at all if I boot with the > webcam disconnected. As soon as I plug it into an USB port, em28xx and > LIRC are loaded. > So... why don't you post *this* dmesg: First boot the computer. Then change the kernel debug level so to get every output po

[Q] tracing/printing

2012-03-14 Thread Ezequiel García
Hi, I'm writing a video capture device and have a doubt about how to correctly print to screen. First, I suppose I should follow the rule "don't print unless there is something surprising to say", right? Second, I've found I need to print in a very verbose manner at developing stage so I should i

Re: eMPIA EM2710 Webcam (em28xx) and LIRC

2012-03-14 Thread Ezequiel García
Hi, 2012/3/14 Rui Salvaterra : > > Hi, Ezequiel. Thanks a lot for your reply. > I'm attaching a copy of my full dmesg, its a bit hard to spot exactly > where all modules are loaded (since the boot sequence became > asynchronous). Indeed. > > > Sure, no problem at all. I booted with em28xx disabl

Re: eMPIA EM2710 Webcam (em28xx) and LIRC

2012-03-14 Thread Ezequiel García
Hi Rui, On Wed, Mar 14, 2012 at 8:28 AM, Rui Salvaterra wrote: > Hi, everyone. > > I apologise in advance for the noise if this is the wrong place to ask > such questions. I have a couple of eMPIA EM2710 (Silvercrest) USB > webcams which work quite well, except for the fact that most of LIRC Exa

Re: A second easycap driver implementation

2012-03-07 Thread Ezequiel García
Hi Mauro, > > em28xx is a good reference. > I'm looking at it. In fact, I have a first question: why there is a limit to the number of devices the driver support? I found the same idea in easycap original implementation, but I can't understand why do we have to limit in such a way. /* Ch

Re: A second easycap driver implementation

2012-03-07 Thread Ezequiel García
On Wed, Mar 7, 2012 at 1:35 PM, Mauro Carvalho Chehab wrote: > > Yes, the driver is weird, as it encapsulates the demod code > inside it , instead of using the saa7115 driver, that covers most > of saa711x devices, including saa7113. > > Btw, is this driver really needed? The em28xx driver has sup

Re: A second easycap driver implementation

2012-03-07 Thread Ezequiel García
Hi, > > Have you considered instead slowly moving the existing easycap driver > over to all the new infrastructure we have now. For starters replace > its buffer management with videobuf2, then in another patch replace > some other bits, etc. ?  See what I've done to the pwc driver :) Yes. And th

A second easycap driver implementation

2012-03-06 Thread Ezequiel García
Hello, After some research on v4l2 and videbuf2, and considering that easycap driver is pretty outdated I've decided to start writing a new driver from scratch. I am using the excellent vivi driver and some usb video capture drivers as a starting point. And of course, I'm using the current easyca

A second easycap driver implementation

2012-03-06 Thread Ezequiel García
Hello, After some research on v4l2 and videbuf2, and considering that easycap driver is pretty outdated I've decided to start writing a new driver from scratch. I am using the excellent vivi driver and some usb video capture drivers as a starting point. And of course, I'm using the current easyca

Re: easycap: reset()

2012-02-28 Thread Ezequiel García
Hi Mike, On Sun, Feb 26, 2012 at 6:56 AM, R.M. Thomas wrote: > Hi Ezequiel, > > As you probably know, I originally developed the driver on the Sourceforge > site.  Before uploading any new version of the driver I carried out > extensive automated testing using various scripts I had written for th

Re: [question] v4l read() operation

2012-02-27 Thread Ezequiel García
Hi Dave, 2012/2/25 Dave Hylands : > > I'm not all that familiar with v4l, but based on what you've posted, > you need to populate the read routine in your v4l2_fops structure to > support read. > My bad! You are totally right: I forgot about my webcam. When I did: $ cat /dev/video0 I was actual

[question] v4l read() operation

2012-02-25 Thread Ezequiel García
Hi, If I register a video device with this fops: static const struct v4l2_file_operations v4l2_fops = { .owner = THIS_MODULE, .open= xxx_open, .unlocked_ioctl = xxx_unlocked_ioctl, .poll = xxx_poll, .mmap = xxx_mmap, }; then if

[question] between probe() and open()

2012-02-25 Thread Ezequiel García
Hello, This is a question in general about usb drivers and in particular about easycap driver. Is there any way a driver can be accesed between after usb_probe() but before device open()? I guess not, since any further operation on the device needs a struct file pointer, i.e. a file descriptor on

Re: [PATCH 5/9] staging: easycap: Push video registration to easycap_register_video()

2012-02-24 Thread Ezequiel García
Hi Dan, On Fri, Feb 24, 2012 at 3:39 PM, Dan Carpenter wrote: > On Fri, Feb 24, 2012 at 12:24:18PM -0300, Ezequiel Garcia wrote: >> +             rc = easycap_register_video(peasycap); >> +             if (rc < 0) >>                       return -ENODEV; > > Don't resend.  These are beautiful pat

[question] USB video capture reference driver

2012-02-23 Thread Ezequiel García
Hi, I'm doing some work on easycap (staging) driver and I would like to ask which similar driver is available and/or recommended to follow code style and code design. Reading cx231xx driver I noticed that video buffer allocation and ioctl handling are done in a very different way using some v4l f

Cleanup proposal for media/gspca

2011-11-16 Thread Ezequiel García
Hi folks, In 'media/video/gspca/gspca.c' I really hated this cast (maybe because I am too dumb to understand it): gspca_dev = (struct gspca_dev *) video_devdata(file); wich is only legal because a struct video_device is the first member of gspca_dev. IMHO, this is 'unnecesary obfuscation'. The