[PATCH] media: wl128x: Fix an error code in fm_download_firmware()

We forgot to set "ret" on this error path. Fixes: e8454ff7b9a4 ("[media] drivers:media:radio: wl128x: FM Driver Common sources") Signed-off-by: Dan Carpenter --- drivers/media/radio/wl128x/fmdrv_common.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/media/radi

[PATCH] media: mtk-vcodec: fix access to vb2_v4l2_buffer struct

Commit 0650a91499e0 ("media: mtk-vcodec: Correct return type for mem2mem buffer helpers") fixed the return types for mem2mem buffer helper functions, but omitted two occurrences that are accessed in the mtk_v4l2_debug() macro. These only trigger compiler errors when DEBUG is defined. Fixes: 0650a9

Re: [PATCH] media: uvcvideo: Add boottime clock support

On Fri, Nov 23, 2018 at 11:46 PM Tomasz Figa wrote: > > Hi Laurent, > > On Fri, Nov 2, 2018 at 12:03 AM Lars-Peter Clausen wrote: > > > > On 11/01/2018 03:30 PM, Tomasz Figa wrote: > > > On Thu, Nov 1, 2018 at 11:03 PM Laurent Pinchart > > > wrote: > > >> > > >> Hi Alexandru, > > >> > > >> On Th

cron job: media_tree daily build: ERRORS

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Wed Mar 6 05:05:05 CET 2019 media-tree git hash:15d90a6ae98e6d2c68497b44a491cb9efbb98ab1 media_build git

Re: [PATCH] media: drxk: add a missed check of the return value of write16

On Tue, Dec 25, 2018 at 02:03:07AM -0600, Kangjie Lu wrote: > write16() could fail. The fix inserts a check for its return value > in case it fails. > > Signed-off-by: Kangjie Lu Unless it is tested on the actual hardware we can't apply this. This could introduce regressions. Sean > --- > dri

Re: [PATCH v2] media: si2165: fix a missing check of return value

On Fri, Dec 21, 2018 at 09:24:46AM +0100, Matthias Schwarzott wrote: > Am 21.12.18 um 05:54 schrieb Kangjie Lu: > > si2165_readreg8() may fail. Looking into si2165_readreg8(), we will find > > that "val_tmp" will be an uninitialized value when regmap_read() fails. > > "val_tmp" is then assigned to

Re: [PATCH v1.1 4/4] ti-vpe: Parse local endpoint for properties, not the remote one

On Tue, Mar 05, 2019 at 11:38:42AM -0600, Benoit Parrot wrote: > Sakari Ailus wrote on Tue [2019-Mar-05 > 18:32:40 +0200]: > > Hi Benoit, > > > > On Tue, Mar 05, 2019 at 08:34:09AM -0600, Benoit Parrot wrote: > > > Sakari, > > > > > > Thank you for the patch. > > > > > > Sakari Ailus wrote on

Re: Question about drivers/media/usb/uvc/uvc_v4l2.c

Hello Shoabo, On Sat, Mar 02, 2019 at 03:29:25PM -0700, Shaobo He wrote: > Hi Laurent, > > Thank you very much for your reply. This is what I thought, too. It seems > that > there's an implicit order of execution that is not clearly implied in the > code, > meaning `uvc_parse_streaming` is ca

Re: [PATCH v2 09/30] media: entity: Swap pads if route is checked from source to sink

Hi Jacopo, On Mon, Mar 04, 2019 at 01:35:36PM +0100, Jacopo Mondi wrote: > On Fri, Feb 22, 2019 at 02:18:11PM +0200, Laurent Pinchart wrote: > > On Mon, Feb 18, 2019 at 10:21:07AM +0100, Jacopo Mondi wrote: > >> On Tue, Jan 22, 2019 at 05:20:30PM +0200, Laurent Pinchart wrote: > >>> On Tue, Jan 22

Re: [PATCH V3 1/2] init i2c already in it930x_frontend_attach

Hi Jose, On Tue, 05 Mar 2019 19:37:25 +0100 Jose Alberto Reguero wrote: > i2c bus is already needed when the frontend is probed, so init it already in > it930x_frontend_attach.That prevents errors like > si2168: probe of 6-0067 failed with error -5 > > Andreas, can I have your Signed-off-by? >

Re: [PATCH v4 1/2] media: uapi: Add H264 low-level decoder API compound controls.

On Tue, 2019-03-05 at 12:16 +0100, Maxime Ripard wrote: > On Fri, Feb 22, 2019 at 04:46:17PM +0900, Tomasz Figa wrote: > > Hi Maxime, > > > > On Wed, Feb 20, 2019 at 11:17 PM Maxime Ripard > > wrote: > > > From: Pawel Osciak > > > > > > Stateless video codecs will require both the H264 metadata

Re: [PATCHv2 9/9] vimc: use new release op

Hi Hans, Thank you for the patch. On Tue, Mar 05, 2019 at 10:58:47AM +0100, hverkuil-ci...@xs4all.nl wrote: > From: Hans Verkuil > > Use the new v4l2_subdev_internal_ops release op to free the > subdev memory only once the last user closed the file handle. > > Signed-off-by: Hans Verkuil > --

Re: [PATCHv2 7/9] v4l2-subdev: handle module refcounting here

Hi Hans, (CC'ing Sakari) Thank you for the patch. On Tue, Mar 05, 2019 at 10:58:45AM +0100, hverkuil-ci...@xs4all.nl wrote: > From: Hans Verkuil > > The module ownership refcounting was done in media_entity_get/put, > but that was very confusing and it did not work either in case an > applicat

Re: [PATCHv2 6/9] v4l2-subdev: add release() internal op

Hi Hans, Thank you for the patch. On Tue, Mar 05, 2019 at 10:58:44AM +0100, hverkuil-ci...@xs4all.nl wrote: > From: Hans Verkuil > > If the subdevice created a device node, then the v4l2_subdev cannot > be freed until the last user of the device node closes it. > > This means that we need a re

Re: [PATCHv2 4/9] media-entity: set ent_enum->bmap to NULL after freeing it

Hi Hans, Thank you for the patch. On Tue, Mar 05, 2019 at 10:58:42AM +0100, hverkuil-ci...@xs4all.nl wrote: > From: Hans Verkuil > > Ensure that this pointer is set to NULL after it is freed. > The vimc driver has a static media_entity and after > unbinding and rebinding the vimc device the med

Re: [PATCH 6/7] v4l2-device: v4l2_device_release_subdev_node can't reference sd

On Fri, Mar 01, 2019 at 12:46:52PM +0100, Hans Verkuil wrote: > On 2/22/19 12:32 PM, Laurent Pinchart wrote: > > Hi Hans, > > > > Thank you for the patch. > > > > On Thu, Feb 21, 2019 at 03:21:47PM +0100, Hans Verkuil wrote: > >> When the v4l-subdev device node is released it calls the > >> v4l2_

[PATCH v3 00/31] v4l: add support for multiplexed streams

Hello, third version of multiplexed stream support patch series. V2 sent by Niklas is available at: https://patchwork.kernel.org/cover/10573817/ As per v2, most of the core patches are work from Sakari and Laurent, with Niklas' support on top for adv748x and rcar-csi2. The use case of the ser

[PATCH v3 25/31] adv748x: csi2: describe the multiplexed stream

From: Niklas Söderlund The adv748x CSI-2 transmitter can only transmit one stream over the CSI-2 link, however it can choose which virtual channel is used. This choice effects the CSI-2 receiver and needs to be captured in the frame descriptor information, solve this by implementing .get_frame_de

[PATCH v3 30/31] rcar-csi2: expose the subdevice internal routing

From: Niklas Söderlund Expose the subdevice internal routing from the single multiplexed sink pad to its source pads by implementing .get_routing(). This information is used to do link validation at stream start and allows user-space to view the route configuration. Signed-off-by: Niklas Söderlu

[PATCH v3 19/31] media: Documentation: Add GS_ROUTING documentation

Add documentation for VIDIOC_SUBDEV_G/S_ROUTING ioctl and add description of multiplexed media pads and internal routing to the V4L2-subdev documentation section. Signed-off-by: Jacopo Mondi --- Documentation/media/uapi/v4l/dev-subdev.rst | 90 +++ Documentation/media/uapi/v4l/user-fu

[PATCH v3 28/31] adv748x: afe: Implement has_route()

Now that the adv748x subdevice supports internal routing, add an has_route() operation used during media graph traversal. Signed-off-by: Jacopo Mondi --- drivers/media/i2c/adv748x/adv748x-afe.c | 26 + 1 file changed, 26 insertions(+) diff --git a/drivers/media/i2c/adv74

[PATCH v3 31/31] media: rcar-csi2: Implement has_route()

Now that the rcar-csi2 subdevice supports internal routing, add an has_route() operation used during graph traversal. The internal routing between the sink and the source pads depends on the virtual channel used to transmit the video stream from the remote subdevice to the R-Car CSI-2 receiver. S

[PATCH v3 18/31] v4l: subdev: Add [GS]_ROUTING subdev ioctls and operations

From: Laurent Pinchart Signed-off-by: Laurent Pinchart Signed-off-by: Michal Simek - Add sink and source streams for multiplexed links - Copy the argument back in case of an error. This is needed to let the caller know the number of routes. Signed-off-by: Sakari Ailus Reviewed-by: Niklas S

[PATCH v3 14/31] media: entity: Add debug information in graph walk route check

From: Sakari Ailus Signed-off-by: Sakari Ailus Reviewed-by: Niklas Söderlund Reviewed-by: Laurent Pinchart Reviewed-by: Jacopo Mondi --- drivers/media/media-entity.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/media-entity.c b/drivers/media/media-entity.c index b48dd

[PATCH v3 29/31] rcar-csi2: use frame description information to configure CSI-2 bus

From: Niklas Söderlund The driver can now access frame descriptor information, use it when configuring the CSI-2 bus. Only enable the virtual channels which are described in the frame descriptor and calculate the link based on all enabled streams. With multiplexed stream supported it's now meani

[PATCH v3 17/31] v4l: Add stream to frame descriptor

From: Sakari Ailus The stream field identifies the stream this frame descriptor applies to in routing configuration across a multiplexed link. Signed-off-by: Sakari Ailus Reviewed-by: Niklas Söderlund Reviewed-by: Jacopo Mondi --- include/media/v4l2-subdev.h | 2 ++ 1 file changed, 2 inserti

[PATCH v3 24/31] adv748x: csi2: only allow formats on sink pads

From: Niklas Söderlund Once the CSI-2 subdevice of the ADV748X becomes aware of multiplexed streams the format of the source pad is of no value as it carries multiple streams. Prepare for this by explicitly denying setting a format on anything but the sink pad. Signed-off-by: Niklas Söderlund S

[PATCH v3 21/31] v4l: subdev: Improve link format validation debug messages

From: Sakari Ailus The existing link format validation failure debug message in media-entity.c helped to poinpoint the point of failure but provided no additional information what's wrong. Tell the user exactly why the validation failed. Signed-off-by: Sakari Ailus Reviewed-by: Niklas Söderlund

[PATCH v3 27/31] adv748x: afe: add routing support

From: Niklas Söderlund The adv748x afe has eight analog sink pads, currently one of them is chosen to be the active route based on device tree configuration. With the new routing API it's possible to expose and change which of the eight sink pads are routed to the source pad. Signed-off-by: Nikl

[PATCH v3 13/31] media: entity: Add only connected pads to the pipeline

From: Sakari Ailus A single entity may contain multiple pipelines. Only add pads that were connected to the pad through which the entity was reached to the pipeline. Signed-off-by: Sakari Ailus Reviewed-by: Niklas Söderlund Reviewed-by: Laurent Pinchart Signed-off-by: Jacopo Mondi --- drive

[PATCH v3 26/31] adv748x: csi2: add internal routing configuration

From: Niklas Söderlund Add support to get and set the internal routing between the adv748x CSI-2 transmitters sink pad and its multiplexed source pad. This routing includes which stream of the multiplexed pad to use, allowing the user to select which CSI-2 virtual channel to use when transmitting

[PATCH v3 20/31] v4l: subdev: Take routing information into account in link validation

From: Sakari Ailus The routing information is essential in link validation for multiplexed links: the pads at the ends of a multiplexed link have no single format defined for them. Instead, the format is accessible in the sink (or source) pads of the sub-devices at both ends of that link. Signed

[PATCH v3 23/31] adv748x: csi2: add translation from pixelcode to CSI-2 datatype

From: Niklas Söderlund Prepare to implement frame descriptors to support multiplexed streams by adding a function to map pixelcode to CSI-2 datatype. This is needed to properly be able to fill out the struct v4l2_mbus_frame_desc. Signed-off-by: Niklas Söderlund Reviewed-by: Jacopo Mondi --- d

[PATCH v3 16/31] v4l: Add CSI-2 bus configuration to frame descriptors

From: Sakari Ailus Add CSI-2 bus specific configuration to the frame descriptors. This allows obtaining the virtual channel and data type information for each stream the transmitter is sending. Signed-off-by: Sakari Ailus Reviewed-by: Niklas Söderlund Reviewed-by: Jacopo Mondi --- include/me

[PATCH v3 11/31] media: entity: Skip link validation for pads to which there is no route to

From: Sakari Ailus Links are validated along the pipeline which is about to start streaming. Not all the pads in entities that are traversed along that pipeline are part of the pipeline, however. Skip the link validation for such pads, and while at there rename "other_pad" to "local_pad" to conve

[PATCH v3 06/31] media: entity: Move the pipeline from entity to pads

From: Sakari Ailus This moves the pipe and stream_count fields from struct media_entity to struct media_pad. Effectively streams become pad-specific rather than being entity specific, allowing several independent streams to traverse a single entity and an entity to be part of several streams. Si

[PATCH v3 01/31] media: entity: Use pad as a starting point for graph walk

From: Sakari Ailus With the upcoming use of the recently added has_route() media entity op, all the pads in an entity will no longer be considered interconnected. This has an effect where the media graph is traversed: the starting pad does make a difference. Prepare for this change by using pad

[PATCH v3 03/31] media: entity: Walk the graph based on pads

From: Sakari Ailus Instead of iterating over graph entities during the walk, iterate the pads through which the entity was first reached. This is required in order to make the entity pipeline pad-based rather than entity based. Signed-off-by: Sakari Ailus Reviewed-by: Niklas Söderlund Reviewed

[PATCH v3 15/31] v4l: Add bus type to frame descriptors

From: Sakari Ailus Signed-off-by: Sakari Ailus Reviewed-by: Niklas Söderlund - Make the bus type a named enum Signed-off-by: Jacopo Mondi --- include/media/v4l2-subdev.h | 9 + 1 file changed, 9 insertions(+) diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h ind

[PATCH v3 05/31] media: entity: Add iterator helper for entity pads

Add an iterator helper to easily cycle through all pads in an entity and use it in media-entity and media-device code where appropriate. Signed-off-by: Jacopo Mondi --- drivers/media/media-device.c | 13 ++--- drivers/media/media-entity.c | 11 ++- include/media/media-entity.h |

[PATCH v3 09/31] media: entity: Add media_has_route() function

From: Laurent Pinchart This is a wrapper around the media entity has_route operation. Signed-off-by: Laurent Pinchart Signed-off-by: Michal Simek Signed-off-by: Sakari Ailus Signed-off-by: Jacopo Mondi --- drivers/media/media-entity.c | 19 +++ include/media/media-entity.h |

[PATCH v3 10/31] media: entity: Use routing information during graph traversal

From: Laurent Pinchart Take internal routing information as reported by the entity has_route operation into account during graph traversal to avoid following unrelated links. Signed-off-by: Laurent Pinchart Signed-off-by: Michal Simek Signed-off-by: Sakari Ailus Reviewed-by: Niklas Söderlund

[PATCH v3 07/31] media: entity: Use pad as the starting point for a pipeline

From: Sakari Ailus The pipeline has been moved from the entity to the pads; reflect this in the media pipeline function API. Signed-off-by: Sakari Ailus Signed-off-by: Niklas Söderlund Reviewed-by: Laurent Pinchart Reviewed-by: Jacopo Mondi --- Documentation/media/kapi/mc-core.rst

[PATCH v3 04/31] v4l: mc: Start walk from a specific pad in use count calculation

From: Sakari Ailus With the addition of the recent has_route() media entity op, the pads of a media entity are no longer all interconnected. This has to be taken into account in power management. Prepare for the addition of a helper function supporting S_ROUTING. Signed-off-by: Sakari Ailus Re

[PATCH v3 22/31] v4l: mc: Add an S_ROUTING helper function for power state changes

From: Sakari Ailus With the addition of the has_route() media entity operation, all pads of an entity are no longer interconnected. The S_ROUTING IOCTL for sub-devices can be used to enable and disable routes for an entity. The consequence is that the routing information has to be taken into acco

[PATCH v3 02/31] media: entity: Use pads instead of entities in the media graph walk stack

From: Sakari Ailus Change the media graph walk stack structure to use media pads instead of using media entities. In addition to the entity, the pad contains the information which pad in the entity are being dealt with. Signed-off-by: Sakari Ailus Reviewed-by: Niklas Söderlund Reviewed-by: Lau

[PATCH v3 08/31] media: entity: Add has_route entity operation

From: Laurent Pinchart The optional operation can be used by entities to report whether two pads are internally connected. While at there, fix a Sphinx compiler warning in a comment block a few lines above. Signed-off-by: Laurent Pinchart Signed-off-by: Michal Simek Signed-off-by: Sakari Ailu

[PATCH v3 12/31] media: entity: Add an iterator helper for connected pads

From: Sakari Ailus Add a helper macro for iterating over pads that are connected through enabled routes. This can be used to find all the connected pads within an entity, for instance starting from the pad which has been obtained during the graph walk. Signed-off-by: Sakari Ailus Reviewed-by: N

[PATCH V3 2/2] Add support for the Avermedia TD310

This patch add support for Avermedia TD310 usb stick. V3 add a table for the i2c addresses an other needed options. Signed-off-by: Jose Alberto Reguero diff -upr linux/drivers/media/usb/dvb-usb-v2/af9035.c linux.new/drivers/media/usb/dvb-usb-v2/af9035.c --- linux/drivers/media/usb/dvb-usb-v

[PATCH V3 0/3] Add support for the Avermedia TD310

Diferences from V2: changes as requested. Jose Alberto Reguero -- Enviado desde mi dispositivo Android con K-9 Mail. Por favor, disculpa mi brevedad.

[PATCH V3 1/2] init i2c already in it930x_frontend_attach

i2c bus is already needed when the frontend is probed, so init it already in it930x_frontend_attach.That prevents errors like si2168: probe of 6-0067 failed with error -5 Andreas, can I have your Signed-off-by? From: Andreas Kemnade Signed-off-by: Jose Alberto Reguero diff -upr linux/drivers

Re: [PATCH 1/3] media: dt-bindings: add bindings for Toshiba TC358746

Hi Rob, I think you didn't followed the discussion in detail so I will ask you personal. In short the tc358746 can act as parallel-in -> csi-out or as csi->in -> parallel-out device. The phyiscal pins are always the same only the internal timings are different. So we have two ports with two endpoi

Re: [PATCH v1.1 4/4] ti-vpe: Parse local endpoint for properties, not the remote one

Sakari Ailus wrote on Tue [2019-Mar-05 18:32:40 +0200]: > Hi Benoit, > > On Tue, Mar 05, 2019 at 08:34:09AM -0600, Benoit Parrot wrote: > > Sakari, > > > > Thank you for the patch. > > > > Sakari Ailus wrote on Tue [2019-Mar-05 > > 16:02:24 +0200]: > > > ti-vpe driver parsed the remote endpo

Re: [PATCH] media: i2c: adv748x: select V4L2_FWNODE

Hi Arnd, Thanks for your work. On 2019-03-05 14:23:13 +0100, Arnd Bergmann wrote: > Building adv748x fails now unless V4L2_FWNODE is selected: > > drivers/media/i2c/adv748x/adv748x-core.o: In function `adv748x_probe': > adv748x-core.c:(.text+0x1b2c): undefined reference to > `v4l2_fwnode_endpoi

Re: [PATCH v4 2/2] media: cedrus: Add H264 decoding support

Dne torek, 05. marec 2019 ob 11:17:32 CET je Maxime Ripard napisal(a): > Hi Jernej, > > On Wed, Feb 20, 2019 at 06:50:54PM +0100, Jernej Škrabec wrote: > > I really wanted to do another review on previous series but got distracted > > by analyzing one particulary troublesome H264 sample. It still

Re: [PATCH v1.1 4/4] ti-vpe: Parse local endpoint for properties, not the remote one

Hi Benoit, On Tue, Mar 05, 2019 at 08:34:09AM -0600, Benoit Parrot wrote: > Sakari, > > Thank you for the patch. > > Sakari Ailus wrote on Tue [2019-Mar-05 > 16:02:24 +0200]: > > ti-vpe driver parsed the remote endpoints for properties but ignored the > > local ones. Fix this by parsing the lo

Re: [linux-uvc-devel] HD Camera (4e45:5501) support

Hi Laurent, Thank you very much for the reply. I tried it on a Windows 10 computer and it worked fine without installing any additional software. Also managed to capture USB traffic on Linux (didn't capture on Windows yet). I don't see a lot of traffic, most of the messages are USB and USBHID pr

Re: [linux-next:master 1790/12310] drivers/media/platform/seco-cec/seco-cec.c:355: undefined reference to `devm_rc_allocate_device'

On Tue, Mar 05, 2019 at 10:53:40PM +0800, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > master > head: baf5a9d1f9b95eb97e9eb54932e20dbbf814771c > commit: f27dd0ad68850fdb806536a733a32d8f74810f1e [1790/12310] media: > seco-cec: fix RC_CO

[linux-next:master 1790/12310] drivers/media/platform/seco-cec/seco-cec.c:355: undefined reference to `devm_rc_allocate_device'

tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: baf5a9d1f9b95eb97e9eb54932e20dbbf814771c commit: f27dd0ad68850fdb806536a733a32d8f74810f1e [1790/12310] media: seco-cec: fix RC_CORE dependency config: x86_64-randconfig-s5-03051951 (attached as .config) com

Re: [PATCH v1.1 4/4] ti-vpe: Parse local endpoint for properties, not the remote one

Sakari, Thank you for the patch. Sakari Ailus wrote on Tue [2019-Mar-05 16:02:24 +0200]: > ti-vpe driver parsed the remote endpoints for properties but ignored the > local ones. Fix this by parsing the local endpoint properties instead. I am not sure I understand the logic here. For CSI2 sens

Re: [PATCH] [v2] media: staging/intel-ipu3: reduce kernel stack usage

On Tue, Mar 05, 2019 at 02:26:29PM +0100, Arnd Bergmann wrote: > The imgu_css_queue structure is too large to be put on the kernel > stack, as we can see in 32-bit builds: > > drivers/staging/media/ipu3/ipu3-css.c: In function 'imgu_css_fmt_try': > drivers/staging/media/ipu3/ipu3-css.c:1863:1: err

[PATCH v1.1 4/4] ti-vpe: Parse local endpoint for properties, not the remote one

ti-vpe driver parsed the remote endpoints for properties but ignored the local ones. Fix this by parsing the local endpoint properties instead. Signed-off-by: Sakari Ailus --- since v1: - Remove of_node_put(remote_ep) as well, the only remaining reference to it. drivers/media/platform/ti-vpe/c

[PATCH 2/4] v4l2-fwnode: The first default data lane is 0 on C-PHY

C-PHY has no clock lanes. Therefore the first data lane is 0 by default. Fixes: edc6d56c2e7e ("media: v4l: fwnode: Support parsing of CSI-2 C-PHY endpoints") Signed-off-by: Sakari Ailus --- drivers/media/v4l2-core/v4l2-fwnode.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --

[PATCH 3/4] pxa-camera: Match with device node, not the port node

V4L2 fwnode matching right now still works based on device nodes, not port nodes. Fix this. Signed-off-by: Sakari Ailus --- drivers/media/platform/pxa_camera.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/pxa_camera.c b/drivers/media/platform/pxa_ca

[PATCH 4/4] ti-vpe: Parse local endpoint for properties, not the remote one

ti-vpe driver parsed the remote endpoints for properties but ignored the local ones. Fix this by parsing the local endpoint properties instead. Signed-off-by: Sakari Ailus --- drivers/media/platform/ti-vpe/cal.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/driv

[PATCH 0/4] V4L2 fwnode framework and driver fixes

Hi folks, Here are a few fixes for the parsing fwnodes in the V4L2 framework as well as drivers using it. Sakari Ailus (4): v4l2-fwnode: Defaults may not override endpoint configuration in firmware v4l2-fwnode: The first default data lane is 0 on C-PHY pxa-camera: Match with device node

[PATCH 1/4] v4l2-fwnode: Defaults may not override endpoint configuration in firmware

The lack of defaults provided by the caller to v4l2_fwnode_endpoint_parse() signals the use of the default lane mapping. The default lane mapping must not be used however if the firmmare contains the lane mapping. Disable the default lane mapping in that case, and improve the debug messages telling

Re: [linux-uvc-devel] HD Camera (4e45:5501) support

Hi Amila, On Mon, Mar 04, 2019 at 03:02:33PM +0100, Amila Manoj wrote: > Hello Laurent and Kieran, > > Thank you very much for the information.  > > I haven't tried other uvc cameras on the system. This is a fresh Ubuntu > installation.  > > Installed all available updates for Ubuntu and now th

Re: [PATCH] media: i2c: adv748x: select V4L2_FWNODE

Hi Arnd, Thank you for the patch. On Tue, Mar 05, 2019 at 02:23:13PM +0100, Arnd Bergmann wrote: > Building adv748x fails now unless V4L2_FWNODE is selected: > > drivers/media/i2c/adv748x/adv748x-core.o: In function `adv748x_probe': > adv748x-core.c:(.text+0x1b2c): undefined reference to > `v4l

[PATCH] [v2] media: staging: davinci_vpfe: disallow building with COMPILE_TEST

The driver should really call dm365_isif_setup_pinmux() through a callback, but uses a hack to include a davinci specific machine header file when compile testing instead. This works almost everywhere, but not on the ARM omap1 platform, which has another header named mach/mux.h. This causes a build

[PATCH] [v2] media: staging/intel-ipu3: reduce kernel stack usage

The imgu_css_queue structure is too large to be put on the kernel stack, as we can see in 32-bit builds: drivers/staging/media/ipu3/ipu3-css.c: In function 'imgu_css_fmt_try': drivers/staging/media/ipu3/ipu3-css.c:1863:1: error: the frame size of 1172 bytes is larger than 1024 bytes [-Werror=fram

[PATCH] media: i2c: adv748x: select V4L2_FWNODE

Building adv748x fails now unless V4L2_FWNODE is selected: drivers/media/i2c/adv748x/adv748x-core.o: In function `adv748x_probe': adv748x-core.c:(.text+0x1b2c): undefined reference to `v4l2_fwnode_endpoint_parse' Fixes: 6a18865da8e3 ("media: i2c: adv748x: store number of CSI-2 lanes described i

Re: [PATCH] media: uvcvideo: Read support

Hi Hugues, On Tue, Mar 05, 2019 at 10:24:15AM +, Hugues FRUCHET wrote: > On 3/4/19 4:44 PM, Laurent Pinchart wrote: > > On Mon, Mar 04, 2019 at 03:36:32PM +, Kieran Bingham wrote: > >> On 04/03/2019 12:35, Hugues Fruchet wrote: > >>> Add support of read() call from userspace by implementin

Re: [PATCH v4 1/2] media: uapi: Add H264 low-level decoder API compound controls.

On Fri, Feb 22, 2019 at 04:46:17PM +0900, Tomasz Figa wrote: > Hi Maxime, > > On Wed, Feb 20, 2019 at 11:17 PM Maxime Ripard > wrote: > > > > From: Pawel Osciak > > > > Stateless video codecs will require both the H264 metadata and slices in > > order to be able to decode frames. > > > > This in

[PATCH v4l-utils] ir-ctl: various typos

Signed-off-by: Sean Young --- utils/ir-ctl/ir-ctl.1.in | 4 ++-- utils/ir-ctl/ir-ctl.c | 2 +- utils/keytable/keytable.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/utils/ir-ctl/ir-ctl.1.in b/utils/ir-ctl/ir-ctl.1.in index c3ab118f..03fcf438 100644 --- a/utils/ir-c

Re: [PATCH] media: uvcvideo: Read support

Hi Kieran, Laurent, On 3/4/19 4:44 PM, Laurent Pinchart wrote: > Hello, > > On Mon, Mar 04, 2019 at 03:36:32PM +, Kieran Bingham wrote: >> On 04/03/2019 12:35, Hugues Fruchet wrote: >>> Add support of read() call from userspace by implementing >>> uvc_v4l2_read() with vb2_read() helper. >> >>

Re: [PATCH v4 2/2] media: cedrus: Add H264 decoding support

Hi Jernej, On Wed, Feb 20, 2019 at 06:50:54PM +0100, Jernej Škrabec wrote: > I really wanted to do another review on previous series but got distracted by > analyzing one particulary troublesome H264 sample. It still doesn't work > correctly, so I would ask you if you can test it with your stack

[PATCHv2 4/9] media-entity: set ent_enum->bmap to NULL after freeing it

From: Hans Verkuil Ensure that this pointer is set to NULL after it is freed. The vimc driver has a static media_entity and after unbinding and rebinding the vimc device the media code will try to free this pointer again since it wasn't set to NULL. Signed-off-by: Hans Verkuil --- drivers/medi

[PATCHv2 9/9] vimc: use new release op

From: Hans Verkuil Use the new v4l2_subdev_internal_ops release op to free the subdev memory only once the last user closed the file handle. Signed-off-by: Hans Verkuil --- drivers/media/platform/vimc/vimc-common.c | 2 ++ drivers/media/platform/vimc/vimc-common.h | 2 ++ drivers/media/pla

[PATCHv2 5/9] vim2m: replace devm_kzalloc by kzalloc

From: Hans Verkuil It is not possible to use devm_kzalloc since that memory is freed immediately when the device instance is unbound. Various objects like the video device may still be in use since someone has the device node open, and when that is closed it expects the memory to be around. So

[PATCHv2 8/9] vimc: free vimc_cap_device when the last user disappears

From: Hans Verkuil Don't free vimc_cap_device immediately, instead do this in the video_device release function which is called when the last user closes the video device. Only then is it safe to free the memory. Signed-off-by: Hans Verkuil Reviewed-by: Laurent Pinchart --- drivers/media/plat

[PATCHv2 3/9] vivid: use vzalloc for dev->bitmap_out

From: Hans Verkuil When vivid is unloaded it used vfree to free dev->bitmap_out, but it was actually allocated using kmalloc. Use vzalloc instead, conform what vivid-vid-cap.c does. Signed-off-by: Hans Verkuil Reviewed-by: Laurent Pinchart --- drivers/media/platform/vivid/vivid-vid-out.c | 14

[PATCHv2 6/9] v4l2-subdev: add release() internal op

From: Hans Verkuil If the subdevice created a device node, then the v4l2_subdev cannot be freed until the last user of the device node closes it. This means that we need a release() callback in v4l2_subdev_internal_ops that is called from the video_device release function so the subdevice driver

[PATCHv2 0/9] Various core and virtual driver fixes

From: Hans Verkuil Various fixes for bugs that I found while working on the regression test-media script. The CONFIG_DEBUG_KOBJECT_RELEASE=y option in particular found a bunch of bugs where things were not released in the right order. Note that the first two patches are not bug fixes, but they

[PATCHv2 2/9] media-devnode: fill in media chardev kobject to ease debugging

From: Hans Verkuil The media chardev kobject has no name, which made it hard to debug when kobject debugging is turned on. Signed-off-by: Hans Verkuil Reviewed-by: Laurent Pinchart --- drivers/media/media-devnode.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/media-devnod

[PATCHv2 7/9] v4l2-subdev: handle module refcounting here

From: Hans Verkuil The module ownership refcounting was done in media_entity_get/put, but that was very confusing and it did not work either in case an application had a v4l-subdevX device open and the module was unbound. When the v4l-subdevX device was closed the media_entity_put was never calle

[PATCHv2 1/9] cec: fill in cec chardev kobject to ease debugging

From: Hans Verkuil The cec chardev kobject has no name, which made it hard to debug when kobject debugging is turned on. Signed-off-by: Hans Verkuil Reviewed-by: Laurent Pinchart --- drivers/media/cec/cec-core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/cec/cec-core.c

Re: [PATCH v4 0/7] TVP5150 new features

Hi Mauro, it would be cool to receive some feedback. I hoped to get this in the media_tree/master a long time ago.. Regards, Marco On 19-02-12 17:09, Marco Felsch wrote: > Hi Mauro, > > gentle ping.. > > On 19-01-29 17:07, Marco Felsch wrote: > > Hi, > > > > this is the v4 of my TVP5150 serie

Re: [PATCH v4 1/2] media: uapi: Add H264 low-level decoder API compound controls.

Hi, On Mon, Mar 04, 2019 at 03:49:11PM -0300, Ezequiel Garcia wrote: > On Wed, 2019-02-20 at 15:17 +0100, Maxime Ripard wrote: > > From: Pawel Osciak > > > > Stateless video codecs will require both the H264 metadata and slices in > > order to be able to decode frames. > > > > This introduces t

Re: [PATCH] media: staging/intel-ipu3: reduce kernel stack usage

On Tue, Mar 5, 2019 at 9:47 AM Sakari Ailus wrote: > On Tue, Mar 05, 2019 at 09:40:24AM +0100, Arnd Bergmann wrote: > > On Tue, Mar 5, 2019 at 8:53 AM Sakari Ailus > > wrote: > > > On Tue, Mar 05, 2019 at 12:25:18AM +, Cao, Bingbu wrote: > > > > > > > struct v4l2_pix_format_mplane *const

Re: [PATCH 1/3] media: dt-bindings: add bindings for Toshiba TC358746

Hi Sakari, Marco, On Mon, Mar 04, 2019 at 08:17:48PM +0200, Sakari Ailus wrote: > Hi Marco, > > On Mon, Mar 04, 2019 at 05:55:28PM +0100, Marco Felsch wrote: > > > > (more device specific) > > > > tc358746,default-mode = /* Parallel-in -> CSI-out */ > > > > tc358746,default-mode = /* CSI-in -> P

Re: [PATCH] media: staging: davinci_vpfe: disallow building with COMPILE_TEST

On Tue, Mar 5, 2019 at 9:05 AM Geert Uytterhoeven wrote: > On Mon, Mar 4, 2019 at 9:30 PM Arnd Bergmann wrote: > > The driver should really call dm365_isif_setup_pinmux() through a callback, > > but it runs platform specific code by itself, which never actually compiled: > > > > /git/arm-soc/driv

Re: [PATCH] media: staging/intel-ipu3: reduce kernel stack usage

On Tue, Mar 05, 2019 at 09:40:24AM +0100, Arnd Bergmann wrote: > On Tue, Mar 5, 2019 at 8:53 AM Sakari Ailus > wrote: > > On Tue, Mar 05, 2019 at 12:25:18AM +, Cao, Bingbu wrote: > > > > > struct v4l2_pix_format_mplane *const in = > > > > &q[IPU3_CSS_QU

Re: [PATCH] media: staging/intel-ipu3: reduce kernel stack usage

On Tue, Mar 5, 2019 at 8:53 AM Sakari Ailus wrote: > On Tue, Mar 05, 2019 at 12:25:18AM +, Cao, Bingbu wrote: > > > struct v4l2_pix_format_mplane *const in = > > > &q[IPU3_CSS_QUEUE_IN].fmt.mpix; > > > struct v4l2_pix_format_mplane *const out = @@ -

Re: [PATCH] media: staging: davinci_vpfe: disallow building with COMPILE_TEST

Hi Arnd, On Mon, Mar 4, 2019 at 9:30 PM Arnd Bergmann wrote: > The driver should really call dm365_isif_setup_pinmux() through a callback, > but it runs platform specific code by itself, which never actually compiled: > > /git/arm-soc/drivers/staging/media/davinci_vpfe/dm365_isif.c:2028:2: error: