[PATCH] imx7-media-csi.c: fix merge breakage

Commit 5964cbd86922 ("imx: Set capture compose rectangle in capture_device_set_format") broke the compilation of commit 05f634040c0d ("staging/imx7: add imx7 CSI subdev driver"). These patches came in through different pull requests and nobody noticed that the first changed functions that the seco

[BUG] Regression caused by "media: gspca: convert to vb2"

Hello! Last week while testing some webcams that use gspca-based v4l2 drivers, I noticed that the driver was spewing some errors in klog whenever the program using them issued VIDIOC_STREAMOFF ioctl. This seems to be a regression caused by commit 1f5965c4dfd7665f2914a1f1095dcc6020656b04 "med

cron job: media_tree daily build: ERRORS

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Feb 19 05:00:11 CET 2019 media-tree git hash:b3c786566d8f3f69b9f4144c2707db74158caf9a media_build git

Hi_.

Hello, Can you partner with me in a venture that will benefit both of us. Please get back to me for more details. Thank you in anticipation.

Re: [PATCH v4 7/7] media: vsp1: Provide a writeback video device

Hi Kieran, On Sun, Feb 17, 2019 at 08:06:32PM +, Kieran Bingham wrote: > On 17/02/2019 02:48, Laurent Pinchart wrote: > > From: Kieran Bingham > > > > When the VSP1 is used in an active display pipeline, the output of the > > WPF can supply the LIF entity directly and simultaneously write to

Re: [PATCH v4 5/7] media: vsp1: Refactor vsp1_video_complete_buffer() for later reuse

Hi Kieran, On Sun, Feb 17, 2019 at 08:35:25PM +, Kieran Bingham wrote: > On 17/02/2019 02:48, Laurent Pinchart wrote: > > The vsp1_video_complete_buffer() function completes the current buffer > > and returns a pointer to the next buffer. Split the code that completes > > the buffer to a separ

Re: [PATCH v4 2/7] media: vsp1: wpf: Fix partition configuration for display pipelines

Hi Kieran, On Sun, Feb 17, 2019 at 08:16:27PM +, Kieran Bingham wrote: > On 17/02/2019 02:48, Laurent Pinchart wrote: > > The WPF accesses partition configuration from pipe->partition in the > > partition configuration that is not used for display pipelines. > > That sentence is hard to read.

Re: [PATCH v4 0/7] VSP1: Display writeback support

Hi Brian, On Mon, Feb 18, 2019 at 12:22:58PM +, Brian Starkey wrote: > On Sun, Feb 17, 2019 at 04:48:45AM +0200, Laurent Pinchart wrote: > > Hello, > > > > This patch series implements display writeback support for the R-Car > > Gen3 platforms in the VSP1 driver. > > > > DRM/KMS provides a w

Re: [PATCH 02/14] ARM: dts: IGEP: Add WiLink UART node

Hi Sebastian, Sorry to take so long to reply Missatge de Sebastian Reichel del dia dv., 21 de des. 2018 a les 9:05: > > From: Sebastian Reichel > > Add a node for the UART part of WiLink chip. > > Cc: Enric Balletbo i Serra > Signed-off-by: Sebastian Reichel > --- > This is compile tested onl

[PATCH 3/3] [media] rc/keymaps: add keytable for Khadas IR Remote Controller

The mouse button key did not have an obvious target and was mapped to KEY_CONTEXT_MENU. Signed-off-by: Jonas Karlman --- drivers/media/rc/keymaps/Makefile| 1 + drivers/media/rc/keymaps/rc-khadas.c | 46 include/media/rc-map.h | 1 + 3 files chang

[PATCH 2/3] [media] rc/keymaps: add keytable for ODROID IR Remote Controller

This RC map is based on remote key schema at [1] [1] https://wiki.odroid.com/accessory/connectivity/ir_remote_controller Signed-off-by: Jonas Karlman --- drivers/media/rc/keymaps/Makefile| 1 + drivers/media/rc/keymaps/rc-odroid.c | 46 include/media/rc-map.h

[PATCH 0/3] Add keytable for Pine64, ODROID and Khadas IR Remote

Add keymaps for the following single board computer vendors IR remotes: - Pine64 IR Remote - ODROID IR Remote - Khadas IR Remote Regards, Jonas Jonas Karlman (3): [media] rc/keymaps: add keytable for Pine64 IR Remote Controller [media] rc/keymaps: add keytable for ODROID IR Remote Controller

[PATCH 1/3] [media] rc/keymaps: add keytable for Pine64 IR Remote Controller

This RC map is based on remote key schema at [1], the mouse button key did not have an obvious target and was mapped to KEY_CONTEXT_MENU. [1] http://files.pine64.org/doc/Pine%20A64%20Schematic/remote-wit-logo.jpg Signed-off-by: Jonas Karlman --- drivers/media/rc/keymaps/Makefile| 1 + driv

Re: [PATCH 04/14] media: i2c: fix several typos

On Mon, Feb 18, 2019 at 02:28:58PM -0500, Mauro Carvalho Chehab wrote: > Use codespell to fix lots of typos over frontends. > > Manually verified to avoid false-positives. > > Signed-off-by: Mauro Carvalho Chehab Acked-by: Sakari Ailus -- Sakari Ailus

Re: [PATCH] media: dvb/earth-pt1: fix wrong initialization for demod blocks

Hello, Thank you for your patch. On Thu, Jan 10, 2019 at 06:56:23PM +0900, tsk...@gmail.com wrote: > From: Akihiro Tsukada > > earth-pt1 driver was decomposed/restructured by the commit: b732539efdba > ("media: dvb: earth-pt1: decompose pt1 driver into sub drivers"), > but it introduced a probl

[PATCH] media: imx7.rst: Fix ReST syntax

Sphinx didn't like the code-blocks on this file: Documentation/media/v4l-drivers/imx7.rst:19: WARNING: Inline substitution_reference start-string without end-string. Documentation/media/v4l-drivers/imx7.rst:20: WARNING: Block quote ends without a blank line; unexpected unindent.

[PATCH 2/4] media: v4l: Improve debug dprintk macro

Instead of checking the dev_debug flags before each dprintk call, make the macro smarter by passing the parameters. This makes the code simpler and will allow to add more debug logic. Signed-off-by: Ezequiel Garcia --- drivers/media/v4l2-core/v4l2-dev.c | 38 +- 1 fi

[PATCH 4/4] media: v4l: ctrls: Add debug messages

Currently, the v4l2 control code is a bit silent on errors. To ease debugging of the control logic, add debug messages on (hopefully) most of the error paths. Signed-off-by: Ezequiel Garcia --- drivers/media/v4l2-core/v4l2-ctrls.c | 63 +++- include/media/v4l2-ioctl.h

[PATCH 3/4] media: v4l: Add a module parameter to control global debugging

In addition to the dev_debug device attribute, which controls per-device debugging, we now add a module parameter to control debugging globally. This will allow to add debugging of v4l2 control logic, using the newly introduced debug parameter. In addition, this module parameter adds consistency

[PATCH 1/4] media: v4l: Simplify dev_debug flags

In preparation to cleanup the debug logic, simplify the dev_debug usage. In particular, make sure that a single flag is used to control each debug print. Before this commit V4L2_DEV_DEBUG_STREAMING and V4L2_DEV_DEBUG_FOP were needed to enable read and write debugging. After this commit only the fo

[PATCH 0/4] Add debug messages to v4l2-ctrls

Even though the goal was fairly simple (adding debug to v4l2-ctrls) it ended up spanning this little patchset. The motivation for this cleanup is being able to turn on/off debugging messages in v4l2-ctrls.c, using a knob common to the videodev driver's core. So, in addition to the dev_debug attri

[PATCH 07/14] media: rc: fix several typos

Use codespell to fix lots of typos over frontends. Manually verified to avoid false-positives. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/rc/Kconfig| 4 ++-- drivers/media/rc/ati_remote.c | 2 +- drivers/media/rc/ene_ir.c

[PATCH 14/14] media: staging: fix several typos

Use codespell to fix lots of typos over frontends. Manually verified to avoid false-positives. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c | 2 +- drivers/staging/media/davinci_vpfe/dm365_isif.c | 4 ++-- drivers/staging/media/davinci_vpfe/

[PATCH 01/14] media: dvb-frontends: fix several typos

Use codespell to fix lots of typos over frontends. Manually verified to avoid false-positives. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/cxd2841er.c | 2 +- drivers/media/dvb-frontends/dib0090.c | 2 +- drivers/media/dvb-frontends/dib7000m.c|

[PATCH 08/14] media: tuners: fix several typos

Use codespell to fix lots of typos over frontends. Manually verified to avoid false-positives. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/tuners/mxl5005s.c| 2 +- drivers/media/tuners/qm1d1b0004.h | 2 +- drivers/media/tuners/r820t.c | 4 ++-- drivers/media

[PATCH 11/14] media: common: fix several typos

Use codespell to fix lots of typos over frontends. Manually verified to avoid false-positives. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/common/saa7146/saa7146_video.c | 2 +- drivers/media/common/siano/sms-cards.c| 2 +- drivers/media/common/siano/smscoreapi.h

[PATCH 09/14] media: usb: fix several typos

Use codespell to fix lots of typos over frontends. Manually verified to avoid false-positives. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/usb/au0828/au0828-core.c| 2 +- drivers/media/usb/au0828/au0828.h | 2 +- drivers/media/usb/cx231xx/cx231xx-avcore.

[PATCH 12/14] media: include: fix several typos

Use codespell to fix lots of typos over frontends. Manually verified to avoid false-positives. Signed-off-by: Mauro Carvalho Chehab --- include/linux/platform_data/media/si4713.h | 4 ++-- include/media/davinci/dm355_ccdc.h | 4 ++-- include/media/davinci/dm644x_ccdc.h| 2 +- in

[PATCH 10/14] media: v4l2-core: fix several typos

Use codespell to fix lots of typos over frontends. Manually verified to avoid false-positives. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/v4l2-core/v4l2-fwnode.c | 16 drivers/media/v4l2-core/v4l2-ioctl.c | 2 +- drivers/media/v4l2-core/videobuf-co

[PATCH 05/14] media: pci: fix several typos

Use codespell to fix lots of typos over frontends. Manually verified to avoid false-positives. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/pci/bt8xx/bttv-audio-hook.c | 2 +- drivers/media/pci/bt8xx/bttv-audio-hook.h | 2 +- drivers/media/pci/bt8xx/bttv-cards.c | 12 ++-

[PATCH 04/14] media: i2c: fix several typos

Use codespell to fix lots of typos over frontends. Manually verified to avoid false-positives. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/i2c/adv7175.c | 2 +- drivers/media/i2c/adv7842.c | 10 +- drivers/media/i2c/bt819.c| 4 ++--

[PATCH 03/14] media: dvb-core: fix several typos

Use codespell to fix lots of typos over frontends. Manually verified to avoid false-positives. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-core/dvb_frontend.c | 2 +- drivers/media/dvb-core/dvbdev.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/driv

[PATCH 02/14] media: radio: fix several typos

Use codespell to fix lots of typos over frontends. Manually verified to avoid false-positives. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/radio/radio-si476x.c | 2 +- drivers/media/radio/wl128x/fmdrv.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/

[PATCH 13/14] media: Documentation: fix several typos

Use codespell to fix lots of typos over frontends. Manually verified to avoid false-positives. Signed-off-by: Mauro Carvalho Chehab --- Documentation/media/dvb-drivers/dvb-usb.rst| 2 +- Documentation/media/kapi/dtv-core.rst | 2 +- Documentation/media/kapi/dtv-fron

[GIT PULL FOR v5.1] RC fixes v2

Hi Mauro, Here are the last RC fixes for 5.1, this time with the documentation warnings fixed. Thanks, Sean The following changes since commit 46c039d06b6ecabb94bd16c3a999b28dc83b79ce: media: cx25840: mark pad sig_types to fix cx231xx init (2019-02-18 12:33:20 -0500) are available in the Gi

Re: [GIT PULL FOR v5.1] RC fixes

On Mon, Feb 18, 2019 at 02:22:52PM -0300, Mauro Carvalho Chehab wrote: > Em Fri, 8 Feb 2019 22:15:22 + > Sean Young escreveu: > > > Hi Mauro, > > > > Here are the last RC fixes for 5.1. > > > > Thanks, > > > > Sean > > > > The following changes since commit 6fd369dd1cb65a032f1ab9227033ecb

Re: [PATCH v3 1/3] media: dt-bindings: media: document allegro-dvt bindings

On Wed, 13 Feb 2019 18:51:22 +0100, Michael Tretter wrote: > Add device-tree bindings for the Allegro DVT video IP core found on the > Xilinx ZynqMP EV family. > > Signed-off-by: Michael Tretter > --- > v2 -> v3: > - rename node to video-codec > - drop interrupt-names > - fix compatible in exampl

Re: [PATCH 0/2] Media Controller "taint" fixes

Hi Hans, On 18/02/2019 10.08, Hans Verkuil wrote: > Hi Brad, > > On 1/15/19 2:24 AM, Brad Love wrote: >> Hauppauge USBLive2 was reported broken. A change in media controller >> logic appears to be the culprit. >> >> Fixes: 9d6d20e652 ("v4l2-mc: switch it to use the new approach to setup >> pipel

Re: [PATCH v1] media: smipcie: add universal ir capability

The original file uses CamelCase. I've updated the functionality, but not try to fix this issue. Patrick. Mauro Carvalho Chehab wrote: Em Thu, 24 Jan 2019 01:04:20 +0100 Patrick Lerda escreveu: smipcie: switch to RC_DRIVER_IR_RAW. Signed-off-by: Patrick Lerda --- drivers/media/pci/smipc

Re: [PATCH v1] media: smipcie: add universal ir capability

Em Thu, 24 Jan 2019 01:04:20 +0100 Patrick Lerda escreveu: > smipcie: switch to RC_DRIVER_IR_RAW. > > Signed-off-by: Patrick Lerda > --- > drivers/media/pci/smipcie/smipcie-ir.c | 133 + > drivers/media/pci/smipcie/smipcie.h| 1 - > 2 files changed, 46 insertions(

Re: [GIT PULL FOR v5.1] RC fixes

Em Fri, 8 Feb 2019 22:15:22 + Sean Young escreveu: > Hi Mauro, > > Here are the last RC fixes for 5.1. > > Thanks, > > Sean > > The following changes since commit 6fd369dd1cb65a032f1ab9227033ecb7b759656d: > > media: vimc: fill in bus_info in media_device_info (2019-02-07 12:38:59 > -0

[GIT PULL FOR v5.1] Various fixes

The following changes since commit 16597c2744f79aaf5f9ec0107be477639985bf44: media: i2c: adv748x: Remove PAGE_WAIT (2019-02-18 11:25:30 -0500) are available in the Git repository at: git://linuxtv.org/hverkuil/media_tree.git tags/br-v5.1r2 for you to fetch changes up to 69bcb353abb07b1ad061

Re: [PATCH 0/2] Media Controller "taint" fixes

Hi Brad, On 1/15/19 2:24 AM, Brad Love wrote: > Hauppauge USBLive2 was reported broken. A change in media controller > logic appears to be the culprit. > > Fixes: 9d6d20e652 ("v4l2-mc: switch it to use the new approach to setup > pipelines") > > Without "taint" set for signal type, devices > wi

Re: [PATCH v2] media: vim2m: fix build breakage due to a merge conflict

On 2/18/19 4:52 PM, Mauro Carvalho Chehab wrote: > A merge conflict rised when merging from -rc7. Fix it. > > In this specific case, we don't need the if anymore, as the > work_run was moved to its rightful place (struct vim2m_ctx). > > Fixes: b3e64e5b0778 ("media: vim2m: use per-file handler wor

[PATCH v2] media: vim2m: fix build breakage due to a merge conflict

A merge conflict rised when merging from -rc7. Fix it. In this specific case, we don't need the if anymore, as the work_run was moved to its rightful place (struct vim2m_ctx). Fixes: b3e64e5b0778 ("media: vim2m: use per-file handler work queue") Fixes: 240809ef6630 ("media: vim2m: only cancel wor

Re: [PATCH] media: vim2m: fix build breakage due to a merge conflict

On 2/18/19 4:34 PM, Mauro Carvalho Chehab wrote: > A merge conflict rised when merging from -rc7. Fix it. > > Signed-off-by: Mauro Carvalho Chehab > --- > drivers/media/platform/vim2m.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/platform/vim2m.c b/d

[PATCH] media: vim2m: fix build breakage due to a merge conflict

A merge conflict rised when merging from -rc7. Fix it. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/platform/vim2m.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/vim2m.c b/drivers/media/platform/vim2m.c index 04250adf58e0..3e4cda2db0bf 10

Re: [PATCH] media: v4l: ioctl: Sanitize num_planes before using it

On 2/18/19 11:25 AM, Ezequiel Garcia wrote: > The linked commit changed s_fmt/try_fmt to fail if num_planes is bogus. > This, however, is against the spec, which mandates drivers > to return a proper num_planes value, without an error. > > Replace the num_planes check and instead clamp it to a san

[PATCH] media: imx: vdic: add frame skipping support

The VDIC can skip frames, allowing to reduce the frame rate at its output pad by small fractions. With this commit, once can specify the frame interval with media-ctl. media-ctl -V "'ipu1_vdic':2 [fmt: UYVY8_2X8/720x576@1/30 field:interlaced-tb]" The commit is an adaptation for VDIC of the commi

RE: [PATCH] media: atmel: atmel-isc: reworked driver and formats

> -Original Message- > From: eugen.hris...@microchip.com > Sent: Friday, February 15, 2019 3:38 AM > To: linux-media@vger.kernel.org; linux-arm-ker...@lists.infradead.org; linux- > ker...@vger.kernel.org; mche...@kernel.org; > nicolas.fe...@microchip.com; Ken Sloat ; > sakari.ai...@iki.fi;

Re: [PATCH v4 0/7] VSP1: Display writeback support

Hi Laurent, On Sun, Feb 17, 2019 at 04:48:45AM +0200, Laurent Pinchart wrote: > Hello, > > This patch series implements display writeback support for the R-Car > Gen3 platforms in the VSP1 driver. > > DRM/KMS provides a writeback API through a special type of writeback > connectors. This series

Re: [PATCH v3 2/2] media: atmel-isc: Update device tree binding documentation

On Thu, Feb 14, 2019 at 09:44:22AM -0600, Rob Herring wrote: > On Mon, Feb 04, 2019 at 02:18:14PM +, Ken Sloat wrote: > > From: Ken Sloat > > Needs a better subject, not one that applies to any change. Update with > what? > > > Update device tree binding documentation specifying how to > >

Re: [PATCH 3/3] media: tc358746: update MAINTAINERS file

Hi Marco, On Tue, Dec 18, 2018 at 03:12:40PM +0100, Marco Felsch wrote: > Add me as partial maintainer, others are welcome too. > > Signed-off-by: Marco Felsch > --- > MAINTAINERS | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 546f8d936589..f9

Re: [PATCH] media: v4l: ioctl: Sanitize num_planes before using it

Hi Ezequiel, On Mon, Feb 18, 2019 at 07:25:42AM -0300, Ezequiel Garcia wrote: > The linked commit changed s_fmt/try_fmt to fail if num_planes is bogus. > This, however, is against the spec, which mandates drivers > to return a proper num_planes value, without an error. > > Replace the num_planes

Re: [PATCH 2/3] media: tc358746: add Toshiba TC358746 Parallel to CSI-2 bridge driver

Hi Marco, On Tue, Dec 18, 2018 at 03:12:39PM +0100, Marco Felsch wrote: > Adding support for the TC358746 bridge. The Bridge can receive images on > the parallel input port and send it to the host using the CSI-TX unit. > Furthermore the Bridge can receive images from the host using the CSI-RX > u

Re: [PATCH v2 17/30] v4l: subdev: compat: Implement handling for VIDIOC_SUBDEV_[GS]_ROUTING

Hi Laurent, Sakari, On Wed, Jan 16, 2019 at 01:53:03AM +0200, Laurent Pinchart wrote: > Hi Niklas, > > Thank you for the patch. > > On Fri, Nov 02, 2018 at 12:31:31AM +0100, Niklas Söderlund wrote: > > From: Sakari Ailus > > > > Implement compat IOCTL handling for VIDIOC_SUBDEV_G_ROUTING and > >

Re: [PATCH 3/3] rcar-csi2: Move setting of Field Detection Control Register

Hi Niklas, On 18/02/2019 10:03, Niklas Söderlund wrote: > Latest datasheet (rev 1.50) clarifies that the FLD register should be > set after LINKCNT. > > Signed-off-by: Niklas Söderlund > --- > drivers/media/platform/rcar-vin/rcar-csi2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [PATCH 2/3] rcar-csi2: Update start procedure for H3 ES2

> On February 18, 2019 at 11:03 AM Niklas Söderlund > wrote: > > > Latest information from hardware engineers reveals that H3 ES2 and ES3 > of behaves differently when working with link speeds bellow 250 Mpbs. > Add a SoC match for H3 ES2.* and use the correct startup sequence. It would be h

Re: [PATCH 2/3] rcar-csi2: Update start procedure for H3 ES2

Hi Niklas, On 18/02/2019 10:03, Niklas Söderlund wrote: > Latest information from hardware engineers reveals that H3 ES2 and ES3 > of behaves differently when working with link speeds bellow 250 Mpbs. of? "of the rcar-csi2?" > Add a SoC match for H3 ES2.* and use the correct startup sequence. >

Re: [PATCH 1/3] rcar-csi2: Update V3M and E3 start procedure

> On February 18, 2019 at 11:03 AM Niklas Söderlund > wrote: > > > The latest datasheet (rev 1.50) updates the start procedure for V3M and > E3. Update the driver to match these changes. > > Signed-off-by: Niklas Söderlund > --- > drivers/media/platform/rcar-vin/rcar-csi2.c | 10 +-

Re: [PATCH 3/3] rcar-csi2: Move setting of Field Detection Control Register

> On February 18, 2019 at 11:03 AM Niklas Söderlund > wrote: > > > Latest datasheet (rev 1.50) clarifies that the FLD register should be > set after LINKCNT. > > Signed-off-by: Niklas Söderlund > --- > drivers/media/platform/rcar-vin/rcar-csi2.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCH] rcar-vin: Fix lockdep warning at stream on

Hi Niklas, On 18/02/2019 01:43, Niklas Söderlund wrote: > Hi Kieran, > > On 2019-02-17 22:27:27 +, Kieran Bingham wrote: >> Hi Niklas, >> >> On 13/02/2019 22:07, Niklas Söderlund wrote: >>> Changes to v4l2-fwnode in commit [1] triggered a lockdep warning in >>> rcar-vin. The first attempt to

[PATCH] media: v4l: ioctl: Sanitize num_planes before using it

The linked commit changed s_fmt/try_fmt to fail if num_planes is bogus. This, however, is against the spec, which mandates drivers to return a proper num_planes value, without an error. Replace the num_planes check and instead clamp it to a sane value, so we still make sure we don't overflow the p

[PATCH] rcar-csi2: restart CSI-2 link if error is detected

Restart the CSI-2 link if the CSI-2 receiver detects an error during reception. The driver did nothing when a link error happened and the data flow simply stopped without the user knowing why. Change the driver to try and recover from errors by restarting the link and informing the user that somet

[PATCH 3/3] rcar-csi2: Move setting of Field Detection Control Register

Latest datasheet (rev 1.50) clarifies that the FLD register should be set after LINKCNT. Signed-off-by: Niklas Söderlund --- drivers/media/platform/rcar-vin/rcar-csi2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/rcar-vin/rcar-csi2.c b/drivers/medi

[PATCH 2/3] rcar-csi2: Update start procedure for H3 ES2

Latest information from hardware engineers reveals that H3 ES2 and ES3 of behaves differently when working with link speeds bellow 250 Mpbs. Add a SoC match for H3 ES2.* and use the correct startup sequence. Signed-off-by: Niklas Söderlund --- drivers/media/platform/rcar-vin/rcar-csi2.c | 39 +++

[PATCH 0/3] rcar-csi2: Update start procedures to latest revision of datasheet

Hi, This series update the driver to match changes in the latest datasheet (rev 1.50). All changes are related to register setup when starting the stream. Niklas Söderlund (3): rcar-csi2: Update V3M and E3 start procedure rcar-csi2: Update start procedure for H3 ES2 rcar-csi2: Move settin

[PATCH 1/3] rcar-csi2: Update V3M and E3 start procedure

The latest datasheet (rev 1.50) updates the start procedure for V3M and E3. Update the driver to match these changes. Signed-off-by: Niklas Söderlund --- drivers/media/platform/rcar-vin/rcar-csi2.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/media/platf

Re: [PATCH 1/3] media: dt-bindings: add bindings for Toshiba TC358746

Hi Marco, My apologies for reviewing this so late. You've received good comments already. I have a few more. On Tue, Dec 18, 2018 at 03:12:38PM +0100, Marco Felsch wrote: > Add corresponding dt-bindings for the Toshiba tc358746 device. > > Signed-off-by: Marco Felsch > --- > .../bindings/media

[GIT PULL for 5.1] Ov7740 fix

Hi Mauro, If it's not too late, it'd be nice to get this little fix to 5.1. Please pull. The following changes since commit 6fd369dd1cb65a032f1ab9227033ecb7b759656d: media: vimc: fill in bus_info in media_device_info (2019-02-07 12:38:59 -0500) are available in the git repository at: ssh

Re: [PATCH v2 09/30] media: entity: Swap pads if route is checked from source to sink

Hi Laurent, Sakari, On Tue, Jan 22, 2019 at 05:20:30PM +0200, Laurent Pinchart wrote: > Hi Sakari, > > On Tue, Jan 22, 2019 at 05:15:06PM +0200, Sakari Ailus wrote: > > On Wed, Jan 16, 2019 at 12:57:43AM +0200, Laurent Pinchart wrote: > > >> > > >> This way the pads are always passed to the has_ro

Re: [PATCH] rcar-csi2: Use standby mode instead of resetting

Hi Niklas, On Sun, Feb 17, 2019 at 8:54 AM Niklas Söderlund wrote: > Later versions of the datasheet updates the reset procedure to more > closely resemble the standby mode. Update the driver to enter and exit > the standby mode instead of resetting the hardware before and after > streaming is st

Re: [PATCH] media: ov7740: fix runtime pm initialization

On 17.02.2019 17:17, Akinobu Mita wrote: > The runtime PM of this device is enabled after v4l2_ctrl_handler_setup(), > and this makes this device's runtime PM usage count a negative value. > > The ov7740_set_ctrl() tries to do something only if the device's runtime > PM usage counter is nonzero.