Re: [PATCH 4/4] arm64: dts: rockchip: add video codec for rk3399

2019-01-07 Thread Ayaka
Sent from my iPad > On Jan 8, 2019, at 2:33 PM, Tomasz Figa wrote: > >> On Mon, Jan 7, 2019 at 2:30 AM Ayaka wrote: >> >> Hello Ezequiel >> >> Sent from my iPad >> On Jan 7, 2019, at 1:21 AM, Ezequiel Garcia wrote: On Sun, 6 Jan 2019 at 13:16, Ayaka wrote: >>

Re: [PATCH v7 00/16] Intel IPU3 ImgU patchset

2019-01-07 Thread Tomasz Figa
Hi Raj, Yong, Bingbu, Tianshu, On Fri, Dec 21, 2018 at 12:04 PM Tomasz Figa wrote: > > On Fri, Dec 21, 2018 at 7:24 AM Laurent Pinchart > wrote: > > > > Hellon > > > > On Sunday, 16 December 2018 09:26:18 EET Laurent Pinchart wrote: > > > Hello Yong, > > > > > > Could you please have a look at t

Re: [PATCH 4/4] arm64: dts: rockchip: add video codec for rk3399

2019-01-07 Thread Tomasz Figa
On Mon, Jan 7, 2019 at 2:30 AM Ayaka wrote: > > Hello Ezequiel > > Sent from my iPad > > > On Jan 7, 2019, at 1:21 AM, Ezequiel Garcia > > wrote: > > > >> On Sun, 6 Jan 2019 at 13:16, Ayaka wrote: > >> > >> > >> > >> Sent from my iPad > >> > >>> On Jan 7, 2019, at 12:04 AM, Ezequiel Garcia >

Re: [PATCH 1/2] v4l2-mem2mem: add job_write callback

2019-01-07 Thread Tomasz Figa
Hi Hans, On Mon, Jan 7, 2019 at 11:43 PM Hans Verkuil wrote: > > Tomasz, Ezequiel, Philipp, > > I'd really like to have a review of this patch. If you have some time to > look at this, then that would be very nice. > Sorry for the long delay. I'm just back from the holidays. (The end year holida

Re: [PATCH -next] media: staging/intel-ipu3: Fix err handle of ipu3_css_find_binary

2019-01-07 Thread Bingbu Cao
On 01/07/2019 07:00 PM, Sakari Ailus wrote: Hi Bingbu, On Mon, Jan 07, 2019 at 10:38:19AM +0800, Bingbu Cao wrote: Hi, Haibing Thanks for your patch, it looks fine for me. Reviewed-by: Bingbu Cao On 12/29/2018 10:45 AM, YueHaibing wrote: css->pipes[pipe].bindex = binary; I'm taking Colin

Re: [PATCH 0/2] Ipu3-cio2 and dw9714 driver e-mail and reviewer update

2019-01-07 Thread Bingbu Cao
I agree this change and wish no more changes like this. :) On 01/07/2019 07:10 PM, Sakari Ailus wrote: Hi, This set removes Jian Xu from the driver's reviewers as well as removes his e-mail address from the module author. Sakari Ailus (2): MAINTAINERS: Update reviewers for ipu3-cio2 ipu3

Re: [linux-sunxi] [PATCH v2 1/2] media: v4l: Add definitions for the HEVC slice format and controls

2019-01-07 Thread Ayaka
Sent from my iPad > On Jan 7, 2019, at 5:57 PM, Paul Kocialkowski > wrote: > > Hi, > >> On Mon, 2019-01-07 at 11:49 +0800, Randy Li wrote: >>> On 12/12/18 8:51 PM, Paul Kocialkowski wrote: >>> Hi, >>> >>> On Wed, 2018-12-05 at 21:59 +0100, Jernej Škrabec wrote: >>> > + > +#define

Re: drivers/staging/media/ipu3/ipu3-css.c:1831: bad compare ?

2019-01-07 Thread sakari.ai...@linux.intel.com
Hi David, On Mon, Jan 07, 2019 at 10:30:55PM +, David Binderman wrote: > Hello there, > > drivers/staging/media/ipu3/ipu3-css.c:1831:30: warning: comparison of > unsigned expression < 0 is always false [-Wtype-limits] > > Source code is > css->pipes[pipe].bindex = >

Re: [GIT PULL v4 for 4.21] META_OUTPUT buffer type and the ipu3 staging driver

2019-01-07 Thread Sakari Ailus
Hi Mauro, On Mon, Jan 07, 2019 at 04:11:34PM -0200, Mauro Carvalho Chehab wrote: > Em Mon, 7 Jan 2019 16:01:07 -0200 > Mauro Carvalho Chehab escreveu: > > > Hi Sakari/Bingbu, > > > > Em Thu, 13 Dec 2018 14:03:40 +0200 > > sakari.ai...@iki.fi escreveu: > > > > > Hi Mauro, > > > > > > Here's th

Re: [PATCH v5] media: imx: add mem2mem device

2019-01-07 Thread Nicolas Dufresne
Le lundi 03 décembre 2018 à 12:48 +0100, Philipp Zabel a écrit : > Add a single imx-media mem2mem video device that uses the IPU IC PP > (image converter post processing) task for scaling and colorspace > conversion. > On i.MX6Q/DL SoCs with two IPUs currently only the first IPU is used. > > The h

Aviso !!! Sua caixa de correio excedeu!

2019-01-07 Thread Administrador
Serviço de TI, Você excedeu o limite de cota em sua caixa postal, você terá problemas para enviar e receber e-mails. Até você validar novamente sua conta, você deve atualizar as informações para validar sua conta. Clique no link abaixo ou copie e cole no seu navegador para validar sua caixa de

Re: [PATCH] media: drx: fix a missing check of return value

2019-01-07 Thread Mauro Carvalho Chehab
Em Thu, 20 Dec 2018 00:57:44 -0600 Kangjie Lu escreveu: > Function drxj_dap_write_reg16(), which writes data to buffer, may fail. > We need to check if it fails, and if so, we should goto error. Did you test this on a real hardware? This kind of patch has a potential of breaking things, as, on

Re: [GIT PULL v4 for 4.21] META_OUTPUT buffer type and the ipu3 staging driver

2019-01-07 Thread Mauro Carvalho Chehab
Em Mon, 7 Jan 2019 16:01:07 -0200 Mauro Carvalho Chehab escreveu: > Hi Sakari/Bingbu, > > Em Thu, 13 Dec 2018 14:03:40 +0200 > sakari.ai...@iki.fi escreveu: > > > Hi Mauro, > > > > Here's the ipu3 staging driver plus the META_OUTPUT buffer type needed to > > pass the parameters for the device.

[PATCH] ipu3: add missing #include

2019-01-07 Thread Mauro Carvalho Chehab
Lots of warning due to non-static functions are generated because the headers with define them were not included. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/media/ipu3/ipu3-css-params.c | 1 + drivers/staging/media/ipu3/ipu3-dmamap.c | 1 + 2 files changed, 2 insertions(+) dif

Re: [GIT PULL v4 for 4.21] META_OUTPUT buffer type and the ipu3 staging driver

2019-01-07 Thread Mauro Carvalho Chehab
Hi Sakari/Bingbu, Em Thu, 13 Dec 2018 14:03:40 +0200 sakari.ai...@iki.fi escreveu: > Hi Mauro, > > Here's the ipu3 staging driver plus the META_OUTPUT buffer type needed to > pass the parameters for the device. If you think this there's still time to > get this to 4.21, then please pull. The non

RE: [bug report] media: staging/intel-ipu3: Add imgu top level pci device driver

2019-01-07 Thread Zhi, Yong
Cc Tianshu and others. Hi, Dan, Thanks a lot for the code review. > -Original Message- > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > Sent: Friday, January 4, 2019 6:29 AM > To: Zhi, Yong > Cc: linux-media@vger.kernel.org > Subject: [bug report] media: staging/intel-ipu3: Add

Re: [PATCH v2] media: venus: add debugfs support

2019-01-07 Thread Al Viro
On Mon, Jan 07, 2019 at 07:59:00PM +0530, Malathi Gottam wrote: > +static struct dentry *venus_debugfs_init_drv(void) > +{ > + bool ok = false; > + struct dentry *dir = NULL; > + > + dir = debugfs_create_dir("venus", NULL); > + if (IS_ERR_OR_NULL(dir)) { > + dir = NULL;

Re: [PATCH] media: s5p-mfc: fix incorrect bus assignment in virtual child device

2019-01-07 Thread Paweł Chmiel
Dnia poniedziałek, 7 stycznia 2019 13:04:14 CET Marek Szyprowski pisze: > Virtual MFC codec's child devices must not be assigned to platform bus, > because they are allocated as raw 'struct device' and don't have the > corresponding 'platform' part. This fixes NULL pointer access revealed > recentl

Re: [PATCH 12/12] media: mt9m001: set all mbus format field when G_FMT and S_FMT ioctls

2019-01-07 Thread Sakari Ailus
On Mon, Jan 07, 2019 at 11:18:47PM +0900, Akinobu Mita wrote: > 2019年1月7日(月) 20:32 Sakari Ailus : > > > > Hi Mita-san, > > > > On Sun, Dec 23, 2018 at 02:12:54AM +0900, Akinobu Mita wrote: > > > This driver doesn't set all members of mbus format field when the > > > VIDIOC_SUBDEV_{S,G}_FMT ioctls a

Re: [PATCH 03/12] media: mt9m001: convert to SPDX license identifer

2019-01-07 Thread Sakari Ailus
On Mon, Jan 07, 2019 at 11:20:29PM +0900, Akinobu Mita wrote: > 2019年1月7日(月) 20:37 Sakari Ailus : > > > > Hi Mita-san, > > > > On Sun, Dec 23, 2018 at 02:12:45AM +0900, Akinobu Mita wrote: > > > Replace GPL license statements with SPDX license identifiers (GPL-2.0). > > > > > > Cc: Guennadi Liakhov

Re: [PATCH 1/2] v4l2-mem2mem: add job_write callback

2019-01-07 Thread Hans Verkuil
Tomasz, Ezequiel, Philipp, I'd really like to have a review of this patch. If you have some time to look at this, then that would be very nice. On a related note: I am also thinking of adding a new callback to help decoders search for headers containing the resolution. This as per the stateful de

Re: [PATCH v3] [bug/urgent] dvb-usb-v2: Fix incorrect use of transfer_flags URB_FREE_BUFFER

2019-01-07 Thread Mauro Carvalho Chehab
Em Sat, 05 Jan 2019 20:49:00 -0500 Dan Ziemba escreveu: > On Mon, 2018-11-26 at 20:18 +, Malcolm Priestley wrote: > > In commit 1a0c10ed7b media: dvb-usb-v2: stop using coherent memory > > for URBs > > incorrectly adds URB_FREE_BUFFER after every urb transfer. > > > > It cannot use this flag

Re: epoll and vb2_poll: can't wake_up

2019-01-07 Thread Yi Qingliang
Thanks! It should work now. BTW, I don't know if we should think about the error case before calling poll_wait, just like not streamon. if poll return error, does epoll framework need and how to remove waiter for client? for epoll framework, does it have some requirements or some tutorial for the i

[PATCH v2] media: venus: add debugfs support

2019-01-07 Thread Malathi Gottam
Enable logs in venus through debugfs to print debug information. Signed-off-by: Malathi Gottam --- drivers/media/platform/qcom/venus/core.c | 62 - drivers/media/platform/qcom/venus/core.h | 32 + drivers/media/platform/qcom/venus/firmware.c | 6 +- drivers/media/pl

Re: [PATCH 03/12] media: mt9m001: convert to SPDX license identifer

2019-01-07 Thread Akinobu Mita
2019年1月7日(月) 20:37 Sakari Ailus : > > Hi Mita-san, > > On Sun, Dec 23, 2018 at 02:12:45AM +0900, Akinobu Mita wrote: > > Replace GPL license statements with SPDX license identifiers (GPL-2.0). > > > > Cc: Guennadi Liakhovetski > > Cc: Sakari Ailus > > Cc: Mauro Carvalho Chehab > > Signed-off-by:

Re: [PATCH 12/12] media: mt9m001: set all mbus format field when G_FMT and S_FMT ioctls

2019-01-07 Thread Akinobu Mita
2019年1月7日(月) 20:32 Sakari Ailus : > > Hi Mita-san, > > On Sun, Dec 23, 2018 at 02:12:54AM +0900, Akinobu Mita wrote: > > This driver doesn't set all members of mbus format field when the > > VIDIOC_SUBDEV_{S,G}_FMT ioctls are called. > > > > This is detected by v4l2-compliance. > > > > Cc: Guennadi

Re: [PATCH 11/12] media: mt9m001: make VIDIOC_SUBDEV_G_FMT ioctl work with V4L2_SUBDEV_FORMAT_TRY

2019-01-07 Thread Akinobu Mita
2019年1月7日(月) 20:30 Sakari Ailus : > > Hi Mita-san, > > On Sun, Dec 23, 2018 at 02:12:53AM +0900, Akinobu Mita wrote: > > The VIDIOC_SUBDEV_G_FMT ioctl for this driver doesn't recognize > > V4L2_SUBDEV_FORMAT_TRY and always works as if V4L2_SUBDEV_FORMAT_ACTIVE > > is specified. > > > > Cc: Guennadi

Re: epoll and vb2_poll: can't wake_up

2019-01-07 Thread Hans Verkuil
On 01/07/2019 02:45 PM, Hans Verkuil wrote: > On 12/29/2018 03:10 AM, Yi Qingliang wrote: >> Hello, I encountered a "can't wake_up" problem when use camera on imx6. >> >> if delay some time after 'streamon' the /dev/video0, then add fd >> through epoll_ctl, then the process can't be waken_up after

Re: [PATCH 07/12] media: mt9m001: remove remaining soc_camera specific code

2019-01-07 Thread Akinobu Mita
2019年1月7日(月) 20:29 Sakari Ailus : > > Hi Mita-san, > > On Sun, Dec 23, 2018 at 02:12:49AM +0900, Akinobu Mita wrote: > > Remove remaining soc_camera specific code and drop soc_camera dependency > > from this driver. > > > > Cc: Guennadi Liakhovetski > > Cc: Sakari Ailus > > Cc: Mauro Carvalho Che

Re: [PATCH 06/12] media: mt9m001: switch s_power callback to runtime PM

2019-01-07 Thread Sakari Ailus
Hi Mita-san, On Mon, Jan 07, 2019 at 11:07:18PM +0900, Akinobu Mita wrote: > 2019年1月7日(月) 19:00 Sakari Ailus : > > > > Hi Mita-san, > > > > Thanks for the patchset. > > > > On Sun, Dec 23, 2018 at 02:12:48AM +0900, Akinobu Mita wrote: > > > Switch s_power() callback to runtime PM framework. This

Re: [PATCH 09/12] media: mt9m001: register to V4L2 asynchronous subdevice framework

2019-01-07 Thread Akinobu Mita
2019年1月7日(月) 20:27 Sakari Ailus : > > Hi Mita-san, > > On Sun, Dec 23, 2018 at 02:12:51AM +0900, Akinobu Mita wrote: > > Register a sub-device to the asynchronous subdevice framework, and also > > create subdevice device node. > > > > Cc: Guennadi Liakhovetski > > Cc: Sakari Ailus > > Cc: Mauro C

Re: [PATCH 06/12] media: mt9m001: switch s_power callback to runtime PM

2019-01-07 Thread Akinobu Mita
2019年1月7日(月) 19:00 Sakari Ailus : > > Hi Mita-san, > > Thanks for the patchset. > > On Sun, Dec 23, 2018 at 02:12:48AM +0900, Akinobu Mita wrote: > > Switch s_power() callback to runtime PM framework. This also removes > > soc_camera specific power management code and introduces reset and standby

Você excedeu seu limite de caixa de correio

2019-01-07 Thread Administrador
Serviço de TI, Você excedeu o limite de cota em sua caixa postal, você terá problemas para enviar e receber e-mails. Até você validar novamente sua conta, você deve atualizar as informações para validar sua conta. Clique no link abaixo ou copie e cole no seu navegador para validar sua caixa de

Re: epoll and vb2_poll: can't wake_up

2019-01-07 Thread Hans Verkuil
On 12/29/2018 03:10 AM, Yi Qingliang wrote: > Hello, I encountered a "can't wake_up" problem when use camera on imx6. > > if delay some time after 'streamon' the /dev/video0, then add fd > through epoll_ctl, then the process can't be waken_up after some time. > > I checked both the epoll / vb2_po

Re: [PATCH v5 2/6] media: sun6i: Add mod_rate quirk

2019-01-07 Thread Maxime Ripard
On Mon, Dec 24, 2018 at 08:57:48PM +0530, Jagan Teki wrote: > On Fri, Dec 21, 2018 at 6:30 PM Maxime Ripard > wrote: > > > > On Thu, Dec 20, 2018 at 06:24:34PM +0530, Jagan Teki wrote: > > > Unfortunately default CSI_SCLK rate cannot work properly to > > > drive the connected sensor interface, pa

[PATCHv2 0/3] vb2: add buf_out_validate callback

2019-01-07 Thread hverkuil-cisco
From: Hans Verkuil Adding the request API uncovered a pre-existing problem with validating output buffers. The problem is that for output buffers the driver has to validate the 'field' field of struct v4l2_buffer. This is critical when encoding or deinterlacing interlaced video. Drivers always

[PATCHv2 1/3] vb2: add buf_out_validate callback

2019-01-07 Thread hverkuil-cisco
From: Hans Verkuil Adding the request API uncovered a pre-existing problem with validating output buffers. The problem is that for output buffers the driver has to validate the 'field' field of struct v4l2_buffer. This is critical when encoding or deinterlacing interlaced video. Drivers always

[PATCHv2 2/3] vim2m: add buf_out_validate callback

2019-01-07 Thread hverkuil-cisco
From: Hans Verkuil Split off the field validation from buf_prepare into a new buf_out_validate function. Field validation for output buffers should be done there since buf_prepare is not guaranteed to be called at QBUF time. Signed-off-by: Hans Verkuil --- drivers/media/platform/vim2m.c | 16 +

[PATCHv2 3/3] vivid: add buf_out_validate callback

2019-01-07 Thread hverkuil-cisco
From: Hans Verkuil Split off the field validation from buf_prepare into a new buf_out_validate function. Field validation for output buffers should be done there since buf_prepare is not guaranteed to be called at QBUF time. Signed-off-by: Hans Verkuil --- drivers/media/platform/vivid/vivid-vi

Re: [PATCH v2 6/6] media: adv748x: Implement TX link_setup callback

2019-01-07 Thread Kieran Bingham
Hi Jacopo, On 06/01/2019 15:54, Jacopo Mondi wrote: > When the adv748x driver is informed about a link being created from HDMI or > AFE to a CSI-2 TX output, the 'link_setup()' callback is invoked. Make > sure to implement proper routing management at link setup time, to route > the selected video

[PATCH] media: s5p-mfc: fix incorrect bus assignment in virtual child device

2019-01-07 Thread Marek Szyprowski
Virtual MFC codec's child devices must not be assigned to platform bus, because they are allocated as raw 'struct device' and don't have the corresponding 'platform' part. This fixes NULL pointer access revealed recently by commit a66d972465d1 ("devres: Align data[] to ARCH_KMALLOC_MINALIGN"). Rep

Re: [V3, 2/4] media: platform: dwc: Add DW MIPI DPHY Rx platform

2019-01-07 Thread Sakari Ailus
Hi Luis, On Fri, Oct 19, 2018 at 02:52:24PM +0200, Luis Oliveira wrote: > Add of Synopsys MIPI D-PHY in RX mode support. > Separated in the implementation are platform dependent probing functions. > > Signed-off-by: Luis Oliveira Maxime has a patchset adding D-PHY parameters to the PHY API. I t

Aviso !!! Sua caixa de correio excedeu!

2019-01-07 Thread Administrador
Serviço de TI, Você excedeu o limite de cota em sua caixa postal, você terá problemas para enviar e receber e-mails. Até você validar novamente sua conta, você deve atualizar as informações para validar sua conta. Clique no link abaixo ou copie e cole no seu navegador para validar sua caixa de

Re: [PATCH 03/12] media: mt9m001: convert to SPDX license identifer

2019-01-07 Thread Sakari Ailus
Hi Mita-san, On Sun, Dec 23, 2018 at 02:12:45AM +0900, Akinobu Mita wrote: > Replace GPL license statements with SPDX license identifiers (GPL-2.0). > > Cc: Guennadi Liakhovetski > Cc: Sakari Ailus > Cc: Mauro Carvalho Chehab > Signed-off-by: Akinobu Mita > --- > drivers/media/i2c/mt9m001.c

Re: [GIT PULL FOR v5.1] vb2/cedrus: use timestamps to identify buffers

2019-01-07 Thread Hans Verkuil
On 01/07/2019 12:30 PM, Hans Verkuil wrote: > As was discussed here (among other places): > > https://lkml.org/lkml/2018/10/19/440 > > using capture queue buffer indices to refer to reference frames is > not a good idea. > > Instead, after a long irc discussion: > > https://linuxtv.org/irc/ircl

[PATCHv6 8/8] extended-controls.rst: update the mpeg2 compound controls

2019-01-07 Thread hverkuil-cisco
From: Hans Verkuil The layout of the compound controls has changed to fix 32/64 bit alignment issues and the use of timestamps instead of buffer indices to refer to buffers. Signed-off-by: Hans Verkuil --- .../media/uapi/v4l/extended-controls.rst | 28 +++ 1 file changed,

[PATCHv6 6/8] vb2: add vb2_find_timestamp()

2019-01-07 Thread hverkuil-cisco
From: Hans Verkuil Use v4l2_timeval_to_ns instead of timeval_to_ns to ensure that both kernelspace and userspace will use the same conversion function. Next add a new vb2_find_timestamp() function to find buffers with a specific timestamp. This function will only look at DEQUEUED and DONE buffe

[PATCHv6 5/8] videodev2.h: add v4l2_timeval_to_ns inline function

2019-01-07 Thread hverkuil-cisco
From: Hans Verkuil We want to be able to uniquely identify buffers for stateless codecs. The internal timestamp (a u64) as stored internally in the kernel is a suitable candidate for that, but in struct v4l2_buffer it is represented as a struct timeval. Add a v4l2_timeval_to_ns() function that c

[PATCHv6 7/8] cedrus: identify buffers by timestamp

2019-01-07 Thread hverkuil-cisco
From: Hans Verkuil Use the new v4l2_m2m_buf_copy_data helper function and use timestamps to refer to reference frames instead of using buffer indices. Also remove the padding fields in the structs, that's a bad idea. Just use the right types to keep everything aligned. Signed-off-by: Hans Verku

[PATCHv6 3/8] vicodec: use v4l2_m2m_buf_copy_data

2019-01-07 Thread hverkuil-cisco
From: Hans Verkuil Use the new v4l2_m2m_buf_copy_data() function in vicodec. Signed-off-by: Hans Verkuil --- drivers/media/platform/vicodec/vicodec-core.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/media/platform/vicodec/vicodec-core.c b/drivers/m

[PATCHv6 1/8] v4l2-mem2mem: add v4l2_m2m_buf_copy_data helper function

2019-01-07 Thread hverkuil-cisco
From: Hans Verkuil Memory-to-memory devices should copy various parts of struct v4l2_buffer from the output buffer to the capture buffer. Add a helper function that does that to simplify the driver code. Signed-off-by: Hans Verkuil Reviewed-by: Paul Kocialkowski Reviewed-by: Alexandre Courbot

[PATCHv6 2/8] vim2m: use v4l2_m2m_buf_copy_data

2019-01-07 Thread hverkuil-cisco
From: Hans Verkuil Use the new v4l2_m2m_buf_copy_data() function in vim2m. Signed-off-by: Hans Verkuil --- drivers/media/platform/vim2m.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/media/platform/vim2m.c b/drivers/media/platform/vim2m.c index d0182

[PATCHv6 4/8] buffer.rst: clean up timecode documentation

2019-01-07 Thread hverkuil-cisco
From: Hans Verkuil V4L2_BUF_FLAG_TIMECODE is not video capture specific, so drop that part. The 'Timecodes' section was a bit messy, so that's cleaned up. Signed-off-by: Hans Verkuil Reviewed-by: Paul Kocialkowski Reviewed-by: Alexandre Courbot --- Documentation/media/uapi/v4l/buffer.rst |

[PATCHv6 0/8] vb2/cedrus: use timestamps to identify buffers

2019-01-07 Thread hverkuil-cisco
From: Hans Verkuil As was discussed here (among other places): https://lkml.org/lkml/2018/10/19/440 using capture queue buffer indices to refer to reference frames is not a good idea. Instead, after a long irc discussion: https://linuxtv.org/irc/irclogger_log/v4l?date=2018-12-12,Wed it was

Re: [PATCH 12/12] media: mt9m001: set all mbus format field when G_FMT and S_FMT ioctls

2019-01-07 Thread Sakari Ailus
Hi Mita-san, On Sun, Dec 23, 2018 at 02:12:54AM +0900, Akinobu Mita wrote: > This driver doesn't set all members of mbus format field when the > VIDIOC_SUBDEV_{S,G}_FMT ioctls are called. > > This is detected by v4l2-compliance. > > Cc: Guennadi Liakhovetski > Cc: Sakari Ailus > Cc: Mauro Carv

Re: [PATCH 11/12] media: mt9m001: make VIDIOC_SUBDEV_G_FMT ioctl work with V4L2_SUBDEV_FORMAT_TRY

2019-01-07 Thread Sakari Ailus
Hi Mita-san, On Sun, Dec 23, 2018 at 02:12:53AM +0900, Akinobu Mita wrote: > The VIDIOC_SUBDEV_G_FMT ioctl for this driver doesn't recognize > V4L2_SUBDEV_FORMAT_TRY and always works as if V4L2_SUBDEV_FORMAT_ACTIVE > is specified. > > Cc: Guennadi Liakhovetski > Cc: Sakari Ailus > Cc: Mauro Car

[GIT PULL FOR v5.1] vb2/cedrus: use timestamps to identify buffers

2019-01-07 Thread Hans Verkuil
As was discussed here (among other places): https://lkml.org/lkml/2018/10/19/440 using capture queue buffer indices to refer to reference frames is not a good idea. Instead, after a long irc discussion: https://linuxtv.org/irc/irclogger_log/v4l?date=2018-12-12,Wed it was decided to use the tim

Re: [PATCH 07/12] media: mt9m001: remove remaining soc_camera specific code

2019-01-07 Thread Sakari Ailus
Hi Mita-san, On Sun, Dec 23, 2018 at 02:12:49AM +0900, Akinobu Mita wrote: > Remove remaining soc_camera specific code and drop soc_camera dependency > from this driver. > > Cc: Guennadi Liakhovetski > Cc: Sakari Ailus > Cc: Mauro Carvalho Chehab > Signed-off-by: Akinobu Mita > --- > drivers

Re: [PATCH 09/12] media: mt9m001: register to V4L2 asynchronous subdevice framework

2019-01-07 Thread Sakari Ailus
Hi Mita-san, On Sun, Dec 23, 2018 at 02:12:51AM +0900, Akinobu Mita wrote: > Register a sub-device to the asynchronous subdevice framework, and also > create subdevice device node. > > Cc: Guennadi Liakhovetski > Cc: Sakari Ailus > Cc: Mauro Carvalho Chehab > Signed-off-by: Akinobu Mita > ---

Re: [PATCHv5 6/8] vb2: add vb2_find_timestamp()

2019-01-07 Thread Hans Verkuil
On 12/19/2018 08:16 AM, Tomasz Figa wrote: > On Wed, Dec 19, 2018 at 4:04 PM Jonas Karlman wrote: >> >> On 2018-12-19 06:10, Tomasz Figa wrote: >>> On Thu, Dec 13, 2018 at 9:28 PM Hans Verkuil >>> wrote: On 12/12/18 7:28 PM, Jonas Karlman wrote: > Hi Hans, > > Since this functio

[PATCH 2/2] ipu3-cio2, dw9714: Remove Jian Xu's e-mail

2019-01-07 Thread Sakari Ailus
Jian Xu has left the company. Remove his e-mail address that no longer works. Signed-off-by: Sakari Ailus --- drivers/media/i2c/dw9714.c | 2 +- drivers/media/pci/intel/ipu3/ipu3-cio2.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c/dw9714.

[PATCH 0/2] Ipu3-cio2 and dw9714 driver e-mail and reviewer update

2019-01-07 Thread Sakari Ailus
Hi, This set removes Jian Xu from the driver's reviewers as well as removes his e-mail address from the module author. Sakari Ailus (2): MAINTAINERS: Update reviewers for ipu3-cio2 ipu3-cio2, dw9714: Remove Jian Xu's e-mail MAINTAINERS | 1 - drivers/media/i2c/d

Re: [PATCH v1 2/2] media: atmel-isc: Update device tree binding documentation

2019-01-07 Thread Eugen.Hristev
On 28.12.2018 18:59, Ken Sloat wrote: > From: Ken Sloat > > Update device tree binding documentation specifying how to > enable BT656 with CRC decoding. > > Signed-off-by: Ken Sloat Acked-by: Eugen Hristev > --- > Documentation/devicetree/bindings/media/atmel-isc.txt | 3 +++ > 1 file ch

[PATCH 1/2] MAINTAINERS: Update reviewers for ipu3-cio2

2019-01-07 Thread Sakari Ailus
Remove Jian Xu from the driver's reviewers. Signed-off-by: Sakari Ailus --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index e6b8a746b53f..0216fbedae23 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7589,7 +7589,6 @@ M:Yong Zhi M: Sakar

Re: [PATCH v1 1/2] media: atmel-isc: Add support for BT656 with CRC decoding

2019-01-07 Thread Eugen.Hristev
On 28.12.2018 18:59, Ken Sloat wrote: > From: Ken Sloat > > The ISC driver currently supports ITU-R 601 encoding which > utilizes the external hysync and vsync signals. ITU-R 656 > format removes the need for these pins by embedding the > sync pulses within the data packet. > > To support this

Re: [PATCH -next] media: staging/intel-ipu3: Fix err handle of ipu3_css_find_binary

2019-01-07 Thread Sakari Ailus
Hi Bingbu, On Mon, Jan 07, 2019 at 10:38:19AM +0800, Bingbu Cao wrote: > Hi, Haibing > > Thanks for your patch, it looks fine for me. > Reviewed-by: Bingbu Cao > > On 12/29/2018 10:45 AM, YueHaibing wrote: > > css->pipes[pipe].bindex = binary; I'm taking Colin's patch with equivalent content;

Re: [PATCH v2 5/6] media: adv748x: Store the TX sink in HDMI/AFE

2019-01-07 Thread Kieran Bingham
Hi Jacopo, On 06/01/2019 15:54, Jacopo Mondi wrote: > Both the AFE and HDMI s_stream routines (adv748x_afe_s_stream() and > adv748x_hdmi_s_stream()) have to enable the CSI-2 TX they are streaming video > data to. > > With the introduction of dynamic routing between HDMI and AFE entities to > TXA,

Re: [PATCH v2 4/6] media: adv748x: Store the source subdevice in TX

2019-01-07 Thread Kieran Bingham
Hi Jacopo, On 06/01/2019 15:54, Jacopo Mondi wrote: > The power_up_tx() procedure needs to set a few registers conditionally to > the selected video source, but it currently checks for the provided tx to > be either TXA or TXB. > > With the introduction of dynamic routing between HDMI and AFE ent

Re: [PATCH v2 1/6] media: adv748x: Add is_txb()

2019-01-07 Thread Kieran Bingham
Hi Jacopo, On 07/01/2019 10:05, Jacopo Mondi wrote: > Hi Kieran, >>> diff --git a/drivers/media/i2c/adv748x/adv748x.h >>> b/drivers/media/i2c/adv748x/adv748x.h >>> index b482c7fe6957..bc2da1b5ce29 100644 >>> --- a/drivers/media/i2c/adv748x/adv748x.h >>> +++ b/drivers/media/i2c/adv748x/adv748x.

Re: [PATCH v2 3/6] media: adv748x: csi2: Link AFE with TXA and TXB

2019-01-07 Thread Kieran Bingham
Hi Jacopo, On 06/01/2019 15:54, Jacopo Mondi wrote: > The ADV748x chip supports routing AFE output to either TXA or TXB. > In order to support run-time configuration of video stream path, create an > additional (not enabled) "AFE:8->TXA:0" link, and remove the IMMUTABLE flag > from existing ones.

Re: [RFC PATCH 0/5] v4l2-ctl: list controls values in a machine-readable format

2019-01-07 Thread Hans Verkuil
On 01/03/2019 07:00 PM, Antonio Ospite wrote: > Hi, > > here is an experiment about listing controls values with v4l2-ctl in > a way that makes it more easy to reload them, I would use something like > that for https://git.ao2.it/v4l2-persistent-settings.git/ > > Patches 1 and 2 are just warm-up

Re: [RFC PATCH 5/5] v4l2-ctl: add an option to list controls in a machine-readable format

2019-01-07 Thread Hans Verkuil
On 01/03/2019 07:01 PM, Antonio Ospite wrote: > Add a new option --list-ctrls-values to list the values of controls in > a format which can be passed again to --set-ctrl. > > This can be useful to save and restore device settings: > > $ v4l2-ctl --list-ctrls-values >settings.txt 2>/dev/null >

Re: [PATCH v2 1/6] media: adv748x: Add is_txb()

2019-01-07 Thread Jacopo Mondi
Hi Kieran, On Mon, Jan 07, 2019 at 09:49:25AM +, Kieran Bingham wrote: > Hi Jacopo > > On 06/01/2019 15:54, Jacopo Mondi wrote: > > Add small is_txb() macro to the existing is_txa() and use it where > > appropriate. > > Thank you. > > I think this will make the code much better to read than if

Re: [PATCH v2 2/6] media: adv748x: Rename reset procedures

2019-01-07 Thread Kieran Bingham
Hi Jacopo, On 06/01/2019 15:54, Jacopo Mondi wrote: > Rename the chip reset procedure as they configure the CP (HDMI) and SD > (AFE) cores. Reviewed-by: Kieran Bingham > Reviewed-by: Laurent Pinchart > Signed-off-by: Jacopo Mondi > --- > drivers/media/i2c/adv748x/adv748x-core.c | 24 +

Re: [linux-sunxi] [PATCH v2 1/2] media: v4l: Add definitions for the HEVC slice format and controls

2019-01-07 Thread Paul Kocialkowski
Hi, On Mon, 2019-01-07 at 11:49 +0800, Randy Li wrote: > On 12/12/18 8:51 PM, Paul Kocialkowski wrote: > > Hi, > > > > On Wed, 2018-12-05 at 21:59 +0100, Jernej Škrabec wrote: > > > > > > + > > > > +#define V4L2_HEVC_DPB_ENTRY_RPS_ST_CURR_BEFORE 0x01 > > > > +#define V4L2_HEVC_DPB_ENTRY_RPS_ST_C

Re: [PATCH 00/12] media: mt9m001: switch soc_mt9m001 to a standard subdev sensor driver

2019-01-07 Thread Sakari Ailus
On Mon, Jan 07, 2019 at 11:36:03AM +0200, Sakari Ailus wrote: > Hi Mita-san, > > On Sun, Dec 23, 2018 at 02:12:42AM +0900, Akinobu Mita wrote: > > This patchset converts soc_camera mt9m001 driver to a standard subdev > > sensor driver. > > > > Akinobu Mita (12): > > media: i2c: mt9m001: copy mt

Re: [PATCH v2 1/6] media: adv748x: Add is_txb()

2019-01-07 Thread Kieran Bingham
Hi Jacopo On 06/01/2019 15:54, Jacopo Mondi wrote: > Add small is_txb() macro to the existing is_txa() and use it where > appropriate. Thank you. I think this will make the code much better to read than if (!is_txa). > Signed-off-by: Jacopo Mondi Reviewed-by: Kieran Bingham > --- > driver

Re: [v4l-utils PATCH v3] v4l2-ctl: Add support for crop and compose selection in streaming

2019-01-07 Thread Hans Verkuil
On 01/04/2019 09:20 PM, Dafna Hirschfeld wrote: > Support crop and compose selection. > If the driver supports crop/compose then the raw frame is arranged > inside a padded buffer. > > Signed-off-by: Dafna Hirschfeld > --- > Chnages from v2: > 1. cleanups > 2. change the code of read_write_padded

Re: [PATCH 00/12] media: mt9m001: switch soc_mt9m001 to a standard subdev sensor driver

2019-01-07 Thread Sakari Ailus
Hi Mita-san, On Sun, Dec 23, 2018 at 02:12:42AM +0900, Akinobu Mita wrote: > This patchset converts soc_camera mt9m001 driver to a standard subdev > sensor driver. > > Akinobu Mita (12): > media: i2c: mt9m001: copy mt9m001 soc_camera sensor driver > media: i2c: mt9m001: dt: add binding for mt