From: Sakari Ailus
[ Upstream commit 30efae3d789cd0714ef795545a46749236e29558 ]
While there are issues related to object lifetime management, unregister the
media device first when the driver is being unbound. This is slightly
safer.
Signed-off-by: Sakari Ailus
Reviewed-by: Laurent Pinchart
S
From: Sakari Ailus
[ Upstream commit 30efae3d789cd0714ef795545a46749236e29558 ]
While there are issues related to object lifetime management, unregister the
media device first when the driver is being unbound. This is slightly
safer.
Signed-off-by: Sakari Ailus
Reviewed-by: Laurent Pinchart
S
From: Sakari Ailus
[ Upstream commit 32388d6ef7cffc7d8291b67f8dfa26acd45217fd ]
While there are issues related to object lifetime management, unregister
the media device first, followed immediately by other device nodes when
the driver is being unbound. Only then the resources needed by the driv
From: Hans Verkuil
[ Upstream commit 7cf7b2e977abf3f992036939e35a8eab60013aff ]
Lower the minimum height to 360 to be consistent with the webcam input of vivid.
The 480 was rather arbitrary but it made it harder to use vivid as a source for
encoding since the default resolution when you load vi
From: Hans Verkuil
[ Upstream commit 55623b4169056d7bb493d1c6f715991f8db67302 ]
During the configuration phase of a CEC adapter it is trying to claim a
free logical address by polling.
However, the code doesn't check if there were errors other than OK or NACK,
those are just treated as if the p
From: Sakari Ailus
[ Upstream commit 30efae3d789cd0714ef795545a46749236e29558 ]
While there are issues related to object lifetime management, unregister the
media device first when the driver is being unbound. This is slightly
safer.
Signed-off-by: Sakari Ailus
Reviewed-by: Laurent Pinchart
S
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Thu Nov 29 05:00:11 CET 2018
media-tree git hash:708d75fe1c7c6e9abc5381b6fcc32b49830383d0
media_build git
The driver fixed the TXA CSI-2 transmitter in 4-lane mode while it could
operate using 1-, 2- and 4-lanes. Update the driver to support all
available modes.
The driver makes use of large tables of static register/value writes
when powering up/down the TXA and TXB transmitters which include the
wri
The CSI-2 transmitters can use a different number of lanes to transmit
data. Make the data-lanes mandatory for the endpoints that describe the
transmitters as no good default can be set to fallback on.
Signed-off-by: Niklas Söderlund
---
* Changes since v3
- Add paragraph to describe the accepte
The adv748x CSI-2 transmitters TXA and TXB can use different number of
lanes to transmit data. In order to be able to configure the device
correctly this information need to be parsed from device tree and stored
in each TX private data structure.
TXA supports 1, 2 and 4 lanes while TXB supports 1
Extend the MIPI CSI-2 power up sequence to match the power up sequence
in the hardware manual chapter "9.5.1 Power Up Sequence". This change
allows the power up functions to be reused when initializing the
hardware reducing code duplicating as well aligning with the
documentation.
Signed-off-by: N
Hi,
This series allows the TXA CSI-2 transmitter of the adv748x to function
in 1-, 2- and 4- lane mode. Currently the driver fixes the hardware in
4-lane mode. The driver looks at the standard DT property 'data-lanes'
to determine which mode it should operate in.
Patch 1/4 lists the 'data-lanes'
Hi Hans,
> Subject: Re: [PATCH v7 03/16] v4l: Add Intel IPU3 meta data uAPI
>
> On 11/07/18 00:27, Mani, Rajmohan wrote:
> > Hi Mauro,
> >
> > Thanks for the reviews.
> >
> >> Subject: Re: [PATCH v7 03/16] v4l: Add Intel IPU3 meta data uAPI
> >>
> >> Hi Mauro,
> >>
> >> On Fri, Nov 2, 2018 at 10:
On Wed, Nov 28, 2018 at 10:05 AM Ezequiel Garcia wrote:
>
> On Tue, 2018-11-27 at 19:09 +0900, Tomasz Figa wrote:
> > On Fri, Nov 23, 2018 at 5:24 AM Ezequiel Garcia
> > wrote:
> > [snip]
> > > > > +const struct rockchip_vpu_variant rk3288_vpu_variant = {
> > > > > + .enc_offset = 0x0,
> >
Hi Yong,
On Mon, Oct 29, 2018 at 03:23:03PM -0700, Yong Zhi wrote:
...
> diff --git a/drivers/media/pci/intel/ipu3/ipu3-css-fw.h
> b/drivers/media/pci/intel/ipu3/ipu3-css-fw.h
> new file mode 100644
> index 000..954bb31
> --- /dev/null
> +++ b/drivers/media/pci/intel/ipu3/ipu3-css-fw.h
> @@ -
The state structure contains the resolution expected by the decoder
and encoder. For an encoder that resolution should be taken from the
OUTPUT format, and for a decoder from the CAPTURE format.
If the wrong format is picked, a buffer overrun can occur if there is
a mismatch between the CAPTURE an
Hi Mauro,
So I've gone through the outstanding DVB patches and picked up the easier
ones to deal with first. Please scrutinise.
Thanks,
Sean
The following changes since commit 708d75fe1c7c6e9abc5381b6fcc32b49830383d0:
media: dvb-pll: don't re-validate tuner frequencies (2018-11-23 12:27:18
Hi Mauro,
The following changes since commit a7c3a0d5f8d8cd5cdb32c06d4d68f5b4e4d2104b:
media: mediactl docs: Fix licensing message (2018-11-27 13:52:46 -0500)
are available in the Git repository at:
git://linuxtv.org/pinchartl/media.git tags/vsp1-fixes-20181128
for you to fetch changes up
On Tue, 2018-11-27 at 19:09 +0900, Tomasz Figa wrote:
> On Fri, Nov 23, 2018 at 5:24 AM Ezequiel Garcia
> wrote:
> [snip]
> > > > +const struct rockchip_vpu_variant rk3288_vpu_variant = {
> > > > + .enc_offset = 0x0,
> > > > + .enc_fmts = rk3288_vpu_enc_fmts,
> > > > + .num_enc_
Dear Linux folks,
I tried to get a Terratec Grabster AV 350 working, but unfortunately, it
doesn't work correctly.
The software capture stop if i connect a video sourve to composite input.Sound
doesn't work.
I checked it with V4L2 Test Bench.
Using UBUNTU 18.04.1. LTS
uwe@Uwe-Desktop-PC:~$
Provide a dummy implementation when configured without
CONFIG_VIDEO_V4L2_SUBDEV_API to avoid ifdef dance in the drivers that can
be built either with or without the option.
Suggested-by: Jacopo Mondi
Signed-off-by: Lubomir Rintel
---
include/media/v4l2-subdev.h | 11 +++
1 file changed,
Stubbed v4l2_subdev_get_try_format() will return a correct error when
configured without CONFIG_VIDEO_V4L2_SUBDEV_API.
Signed-off-by: Lubomir Rintel
---
drivers/media/i2c/ov7740.c | 25 ++---
1 file changed, 10 insertions(+), 15 deletions(-)
diff --git a/drivers/media/i2c/ov
Stubbed v4l2_subdev_get_try_format() will return a correct error when
configured without CONFIG_VIDEO_V4L2_SUBDEV_API.
Signed-off-by: Lubomir Rintel
---
drivers/media/i2c/ov2680.c | 17 ++---
1 file changed, 6 insertions(+), 11 deletions(-)
diff --git a/drivers/media/i2c/ov2680.c b/
Stubbed v4l2_subdev_get_try_format() will return a correct error when
configured without CONFIG_VIDEO_V4L2_SUBDEV_API.
Signed-off-by: Lubomir Rintel
---
drivers/media/i2c/ov2659.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/media/i2c/ov2659.c b/driver
Stubbed v4l2_subdev_get_try_format() will return a correct error when
configured without CONFIG_VIDEO_V4L2_SUBDEV_API.
Signed-off-by: Lubomir Rintel
---
drivers/media/i2c/ov7670.c | 16
1 file changed, 4 insertions(+), 12 deletions(-)
diff --git a/drivers/media/i2c/ov7670.c b/d
Stubbed v4l2_subdev_get_try_format() will return a correct error when
configured without CONFIG_VIDEO_V4L2_SUBDEV_API.
Signed-off-by: Lubomir Rintel
---
drivers/media/i2c/ov5695.c | 38 --
1 file changed, 20 insertions(+), 18 deletions(-)
diff --git a/drivers
Hi,
this patch set does a minor cleanup as suggested by Jacopo.
All driver patches (2-6) depend on the first one.
I've just compile-tested most of these as the only actual sensor I have is
the ov7670.
Cheers,
Lubo
In-Reply-To:
On Thu, 2018-11-22 at 19:37 +0100, jacopo mondi wrote:
> Hi Lubomir,
>
> On Tue, Nov 20, 2018 at 11:03:06AM +0100, Lubomir Rintel wrote:
> > This will allow us to restore the last set format after the device
> > returns
> > from a power off.
> >
> > Signed-off-by: Lubomir Rintel
> >
> > ---
> >
With the GREY format at the beginning, the default format selected
by vicodec would be GREY instead of YUV420. That didn't make sense,
so move it to the end of the list.
Signed-off-by: Hans Verkuil
---
diff --git a/drivers/media/platform/vicodec/codec-v4l2-fwht.c
b/drivers/media/platform/vicodec
Hi Philipp,
On 11/28/18 3:01 PM, Philipp Zabel wrote:
> Hi,
>
> the coda driver handles the H.264 loop filter alpha/beta offset controls
> incorrectly. When trying to fix them, I noticed that the documentation
> is not clear about what these values actually are.
>
> From the value range of -6 to
Hi Jernej,
On Tue, Nov 27, 2018 at 06:23:10PM +0100, Jernej Škrabec wrote:
> > @@ -1156,4 +1164,162 @@ struct v4l2_ctrl_mpeg2_quantization {
> > __u8chroma_non_intra_quantiser_matrix[64];
> > };
> >
> > +/* Compounds controls */
> > +
> > +#define V4L2_H264_SPS_CONSTRAINT_SET0_FLAG
From: Colin Ian King
There is a spelling mistake in the module description as well
as a comment. Fix them.
Signed-off-by: Colin Ian King
---
drivers/media/i2c/tda7432.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/i2c/tda7432.c b/drivers/media/i2c/tda74
Am Donnerstag, 15. November 2018, 16:45:30 CET schrieb Souptick Joarder:
> Previouly drivers have their own way of mapping range of
> kernel pages/memory into user vma and this was done by
> invoking vm_insert_page() within a loop.
>
> As this pattern is common across different drivers, it can
> b
On Wed, Nov 28, 2018 at 09:37:42AM +0100, hverkuil-ci...@xs4all.nl wrote:
> From: Hans Verkuil
>
> While improving the v4l2-compliance tests I came across several vb2
> problems.
>
> After modifying v4l2-compliance I was now able to use the vivid error
> injection feature to test what happens if
Hi,
the coda driver handles the H.264 loop filter alpha/beta offset controls
incorrectly. When trying to fix them, I noticed that the documentation
is not clear about what these values actually are.
>From the value range of -6 to +6 used in the existing drivers (s5p-mfc,
venus), it looks like the
Add support for the third loop filter mode
V4L2_MPEG_VIDEO_H264_LOOP_FILTER_MODE_DISABLED_AT_SLICE_BOUNDARY,
and fix V4L2_CID_MPEG_VIDEO_H264_LOOP_FILTER_ALPHA and
V4L2_CID_MPEG_VIDEO_H264_LOOP_FILTER_BETA controls.
The filter offset controls are signed values in the -6 to 6 range and
are stored i
The venus and s5p-mfc drivers add the loop filter alpha/beta offset
controls V4L2_CID_MPEG_VIDEO_H264_LOOP_FILTER_ALPHA/BETA with a range of
-6 to +6, inclusive. This is exactly the range specified for the slice
header fields slice_alpha_c0_offset_div2 and slice_beta_offset_div2,
which store half t
Hi Sakari,
Thank you for your review,
On 20/11/2018 08:34, Sakari Ailus wrote:
> Hi Kieran,
>
> On Fri, Nov 02, 2018 at 03:47:23PM +, Kieran Bingham wrote:
>> From: Kieran Bingham
>>
>> The RDACM20 is a GMSL camera supporting 1280x800 resolution images
>> developed by IMI based on an Omnivi
On 2018-11-03 08:31, Tomasz Figa wrote:
Hi Malathi,
On Fri, Nov 2, 2018 at 9:58 PM Malathi Gottam
wrote:
When client requests for a keyframe, set the property
to hardware to generate the sync frame.
Signed-off-by: Malathi Gottam
---
drivers/media/platform/qcom/venus/venc_ctrls.c | 20
+++
On Wed, Nov 28, 2018 at 09:37:43AM +0100, hverkuil-ci...@xs4all.nl wrote:
> From: Hans Verkuil
>
> vb2_start_streaming() already rolls back the buffers, so there is no
> need to call __vb2_queue_cancel(). Especially since __vb2_queue_cancel()
> does too much, such as zeroing the q->queued_count v
On Thu, 2018-11-22 at 14:21 +0200, Sakari Ailus wrote:
> Hi Lubomir,
>
> On Tue, Nov 20, 2018 at 11:03:08AM +0100, Lubomir Rintel wrote:
> > The commit 71862f63f351 ("media: ov7670: Add the ov7670_s_power function")
> > added a power control routing. However, it was not good enough to use as
> > a
Add a new vivid button control to inject an error into the req_validate request
callback.
This will help testing with v4l2-compliance.
Signed-off-by: Hans Verkuil
---
diff --git a/drivers/media/platform/vivid/vivid-core.c
b/drivers/media/platform/vivid/vivid-core.c
index c1b5976af3e6..1adf7cd86
On Wed, Nov 28, 2018 at 09:29:01AM +0100, Marco Felsch wrote:
> On 18-11-27 23:15, Sakari Ailus wrote:
> > On Tue, Nov 27, 2018 at 11:02:53AM +0100, Marco Felsch wrote:
> > > From: Enrico Scholz
> > >
> > > The chip can be configured to output data transitions on the
> > > rising or falling edge
On 11/27/2018 09:16 AM, Alexandre Courbot wrote:
> Hi Hans,
>
> On Tue, Nov 27, 2018 at 1:41 AM Hans Verkuil wrote:
>>
>> On 11/26/2018 05:07 PM, Tomasz Figa wrote:
>>> On Tue, Nov 27, 2018 at 1:00 AM Hans Verkuil wrote:
On 11/26/2018 04:44 PM, Tomasz Figa wrote:
> Hi Hans,
>
>
From: Hans Verkuil
When vb2_buffer_done is called the buffer is unbound from the
request and put. The media_request_object_put also 'put's the
request reference. If the application has already closed the
request fd, then that means that the request reference at that
point goes to 0 and the whole
From: Hans Verkuil
When a buffer is returned to state QUEUED (that happens when
start_streaming fails), then do not unbind and put the object
from the request. Nothing has changed yet, so just keep it as
is.
Signed-off-by: Hans Verkuil
---
drivers/media/common/videobuf2/videobuf2-core.c | 2 +-
From: Hans Verkuil
vb2_start_streaming() already rolls back the buffers, so there is no
need to call __vb2_queue_cancel(). Especially since __vb2_queue_cancel()
does too much, such as zeroing the q->queued_count value, causing vb2
to think that no buffers have been queued.
It appears that this c
From: Hans Verkuil
While improving the v4l2-compliance tests I came across several vb2
problems.
After modifying v4l2-compliance I was now able to use the vivid error
injection feature to test what happens if VIDIOC_STREAMON fails and
a following STREAMON succeeds.
This generated patches 1/5 an
From: Hans Verkuil
If start_streaming() fails and all queued buffers are returned to
vb2, then do not call v4l2_ctrl_request_complete(). Nothing happened
to the request and the state should remain as it was before
start_streaming was called.
Signed-off-by: Hans Verkuil
---
drivers/media/platfo
From: Hans Verkuil
VIDIOC_PREPARE_BUF should ignore V4L2_BUF_FLAG_REQUEST_FD since it isn't
doing anything with requests. So inform vb2_queue_or_prepare_buf whether
it is called from vb2_prepare_buf or vb2_qbuf and just return 0 in the
first case.
This was found when adding new v4l2-compliance c
On 18-11-27 23:15, Sakari Ailus wrote:
> On Tue, Nov 27, 2018 at 11:02:53AM +0100, Marco Felsch wrote:
> > From: Enrico Scholz
> >
> > The chip can be configured to output data transitions on the
> > rising or falling edge of PIXCLK (Datasheet R58:1[9]), default is on the
> > falling edge.
> >
>
51 matches
Mail list logo
