Re: [PATCH] udmabuf: set read/write flag when exporting

2018-11-15 Thread Gerd Hoffmann
On Thu, Nov 15, 2018 at 05:46:30PM -0800, Gurchetan Singh wrote: > Reviewed-by: Gurchetan Singh > Tested-by: Gurchetan Singh Thanks. Pushed to drm-misc-fixes. cheers, Gerd

Re: [PATCH v2 0/2] media: cedrus: Add H264 decoding support

2018-11-15 Thread Tomasz Figa
Hi Maxime, On Thu, Nov 15, 2018 at 11:56 PM Maxime Ripard wrote: > > > Hi, > > Here is a new version of the H264 decoding support in the cedrus > driver. > > As you might already know, the cedrus driver relies on the Request > API, and is a reverse engineered driver for the video decoding engine

Re: [PATCH 1/9] mm: Introduce new vm_insert_range API

2018-11-15 Thread Matthew Wilcox
On Fri, Nov 16, 2018 at 11:00:30AM +0530, Souptick Joarder wrote: > On Thu, Nov 15, 2018 at 11:44 PM Randy Dunlap wrote: > > On 11/15/18 7:45 AM, Souptick Joarder wrote: > > What is the opposite of vm_insert_range() or even of vm_insert_page()? > > or is there no need for that? > > There is no op

Re: [PATCH] media: venus: amend buffer size for bitstream plane

2018-11-15 Thread Tomasz Figa
On Fri, Nov 16, 2018 at 1:35 PM wrote: > > On 2018-11-14 09:21, Tomasz Figa wrote: > > On Tue, Nov 13, 2018 at 7:46 PM Stanimir Varbanov > > wrote: > >> > >> Hi Tomasz, > >> > >> On 11/13/18 11:13 AM, Tomasz Figa wrote: > >> > On Tue, Nov 13, 2018 at 5:12 PM Stanimir Varbanov > >> > wrote: > >>

Re: [PATCH 1/9] mm: Introduce new vm_insert_range API

2018-11-15 Thread Souptick Joarder
On Thu, Nov 15, 2018 at 11:44 PM Randy Dunlap wrote: > > On 11/15/18 7:45 AM, Souptick Joarder wrote: > > Previouly drivers have their own way of mapping range of > > kernel pages/memory into user vma and this was done by > > invoking vm_insert_page() within a loop. > > > > As this pattern is comm

cron job: media_tree daily build: WARNINGS

2018-11-15 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Fri Nov 16 05:00:11 CET 2018 media-tree git hash:fbe57dde7126d1b2712ab5ea93fb9d15f89de708 media_build git

Re: [PATCH] media: venus: amend buffer size for bitstream plane

2018-11-15 Thread mgottam
On 2018-11-14 09:21, Tomasz Figa wrote: On Tue, Nov 13, 2018 at 7:46 PM Stanimir Varbanov wrote: Hi Tomasz, On 11/13/18 11:13 AM, Tomasz Figa wrote: > On Tue, Nov 13, 2018 at 5:12 PM Stanimir Varbanov > wrote: >> >> Hi Malathi, >> >> On 11/13/18 9:28 AM, mgot...@codeaurora.org wrote: >>> On

Re: [PATCH] media: venus: fix reported size of 0-length buffers

2018-11-15 Thread Tomasz Figa
On Fri, Nov 16, 2018 at 1:50 AM Nicolas Dufresne wrote: > > Le mercredi 14 novembre 2018 à 13:12 +0900, Alexandre Courbot a écrit : > > On Wed, Nov 14, 2018 at 3:54 AM Nicolas Dufresne > > wrote: > > > > > > > > > Le mar. 13 nov. 2018 04 h 30, Alexandre Courbot a > > > écrit : > > > > The last

Re: [PATCH] udmabuf: set read/write flag when exporting

2018-11-15 Thread Gurchetan Singh
Reviewed-by: Gurchetan Singh Tested-by: Gurchetan Singh On Wed, Nov 14, 2018 at 4:20 AM Gerd Hoffmann wrote: > > Otherwise, mmap fails when done with PROT_WRITE. > > Suggested-by: Gurchetan Singh > Signed-off-by: Gerd Hoffmann > --- > drivers/dma-buf/udmabuf.c | 1 + > 1 file changed, 1 inser

Re: [PATCH 3/5] media: sunxi: Add A10 CSI driver

2018-11-15 Thread Maxime Ripard
Hi Hans, Thanks for your review! I'll address the other comments you made. On Tue, Nov 13, 2018 at 01:24:47PM +0100, Hans Verkuil wrote: > > +static int csi_probe(struct platform_device *pdev) > > +{ > > + struct sun4i_csi *csi; > > + struct resource *res; > > + int ret; > > + int irq; >

Re: [PATCH 0/5] media: Allwinner A10 CSI support

2018-11-15 Thread Maxime Ripard
Hi, On Wed, Nov 14, 2018 at 11:24:48AM +0800, Chen-Yu Tsai wrote: > On Tue, Nov 13, 2018 at 4:24 PM Maxime Ripard > wrote: > > Here is a series introducing the support for the A10 (and SoCs of the same > > generation) CMOS Sensor Interface (called CSI, not to be confused with > > MIPI-CSI, which

Re: [PATCH 1/5] dt-bindings: media: Add Allwinner A10 CSI binding

2018-11-15 Thread Maxime Ripard
Hi Sakari, On Tue, Nov 13, 2018 at 10:38:55AM +0200, Sakari Ailus wrote: > > + - allwinner,has-isp: Whether the CSI controller has an ISP > > + associated to it or not > > Is the ISP a part of the same device? It sounds like that this is actually > a different device if it

Re: TechnoTrend CT2-4500 remote not working

2018-11-15 Thread martin.kono...@mknetz.de
Sean, Am 15.11.2018 um 00:07 schrieb Sean Young: >> >> I turned on dynamic debug and got the following messages in the kernel log: >> >> [ 837.160992] rc rc0: get_key_fusionhdtv: ff ff ff ff >> [ 837.263927] rc rc0: ir_key_poll >> [ 837.264528] rc rc0: get_key_fusionhdtv: ff ff ff ff >> [ 837

Re: [PATCH 1/9] mm: Introduce new vm_insert_range API

2018-11-15 Thread Randy Dunlap
On 11/15/18 7:45 AM, Souptick Joarder wrote: > Previouly drivers have their own way of mapping range of > kernel pages/memory into user vma and this was done by > invoking vm_insert_page() within a loop. > > As this pattern is common across different drivers, it can > be generalized by creating a

Re: [PATCH 07/15] arm64: dts: allwinner: h5: Add system-control node with SRAM C1

2018-11-15 Thread Chen-Yu Tsai
On Thu, Nov 15, 2018 at 10:50 PM Paul Kocialkowski wrote: > > Add the H5-specific system control node description to its device-tree > with support for the SRAM C1 section, that will be used by the video > codec node later on. > > Signed-off-by: Paul Kocialkowski > --- > arch/arm64/boot/dts/allw

Re: [PATCH] media: venus: fix reported size of 0-length buffers

2018-11-15 Thread Nicolas Dufresne
Le jeudi 15 novembre 2018 à 11:49 -0500, Nicolas Dufresne a écrit : > Sending buffers with payload size to 0 just for the sake of setting the > V4L2_BUF_FLAG_LAST was considered a waste. Specially that after that, > every polls should return EPIPE. So in the end, we decided the it > should just unb

Re: [PATCH] media: venus: fix reported size of 0-length buffers

2018-11-15 Thread Nicolas Dufresne
Le mercredi 14 novembre 2018 à 13:12 +0900, Alexandre Courbot a écrit : > On Wed, Nov 14, 2018 at 3:54 AM Nicolas Dufresne wrote: > > > > > > Le mar. 13 nov. 2018 04 h 30, Alexandre Courbot a > > écrit : > > > The last buffer is often signaled by an empty buffer with the > > > V4L2_BUF_FLAG_LA

Re: [PATCH 10/15] arm64: dts: allwinner: a64: Add support for the SRAM C1 section

2018-11-15 Thread Chen-Yu Tsai
On Thu, Nov 15, 2018 at 10:50 PM Paul Kocialkowski wrote: > > Add the description for the SRAM C1 section to the A64 device-tree. > > Signed-off-by: Paul Kocialkowski > --- > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git a/ar

RE: [PATCH v7 14/16] intel-ipu3: Add v4l2 driver based on media framework

2018-11-15 Thread Zhi, Yong
Hi, Hans, Thanks for the review. > -Original Message- > From: Hans Verkuil [mailto:hverk...@xs4all.nl] > Sent: Thursday, November 15, 2018 6:51 AM > To: Zhi, Yong ; linux-media@vger.kernel.org; > sakari.ai...@linux.intel.com > Cc: tf...@chromium.org; mche...@kernel.org; hans.verk...@cisco

[PATCH v4] media: vb2: Allow reqbufs(0) with "in use" MMAP buffers

2018-11-15 Thread Philipp Zabel
From: John Sheu Videobuf2 presently does not allow VIDIOC_REQBUFS to destroy outstanding buffers if the queue is of type V4L2_MEMORY_MMAP, and if the buffers are considered "in use". This is different behavior than for other memory types and prevents us from deallocating buffers in following two

[PATCH v2] v4l2-compliance: test orphaned buffer support

2018-11-15 Thread Philipp Zabel
Test that V4L2_BUF_CAP_SUPPORTS_ORPHANED_BUFS is reported equally for both MMAP and DMABUF memory types. If supported, try to orphan buffers by calling reqbufs(0) before unmapping or closing DMABUF fds. Also close exported DMABUF fds and free buffers in testDmaBuf if orphaned buffers are not suppo

Re: [PATCH 04/15] soc: sunxi: sram: Enable EMAC clock access for H3 variant

2018-11-15 Thread Chen-Yu Tsai
On Thu, Nov 15, 2018 at 10:50 PM Paul Kocialkowski wrote: > > Just like the A64 and H5, the H3 SoC uses the system control block > to enable the EMAC clock. > > Add a variant structure definition for the H3 and use it over the A10 > one. This will allow using the H3-specific binding for the syscon

Re: [PATCH 03/15] ARM: dts: sun8i-h3: Fix the system-control register range

2018-11-15 Thread Chen-Yu Tsai
On Thu, Nov 15, 2018 at 10:50 PM Paul Kocialkowski wrote: > > Unlike in previous generations, the system-control register range is not > limited to a size of 0x30 on the H3. In particular, the EMAC clock > configuration register (accessed through syscon) is at offset 0x30 in > that range. > > Exte

Re: [PATCH 02/15] ARM: dts: sun8i-h3: Remove heading 0 in video-codec unit address

2018-11-15 Thread Chen-Yu Tsai
On Thu, Nov 15, 2018 at 10:50 PM Paul Kocialkowski wrote: > > This cosmetic change removes the heading 0 in the video-codec unit > address, as it's done for other nodes. > > Signed-off-by: Paul Kocialkowski Other than the subject format we can fix when applying, Acked-by: Chen-Yu Tsai

Re: [PATCH 01/15] ARM: dts: sun8i-a33: Remove heading 0 in video-codec unit address

2018-11-15 Thread Chen-Yu Tsai
On Thu, Nov 15, 2018 at 10:50 PM Paul Kocialkowski wrote: > > This cosmetic change removes the heading 0 in the video-codec unit > address, as it's done for other nodes. > > Signed-off-by: Paul Kocialkowski Nit: I'd prefer the subject prefix format be ": : ... ", or "sun8i: a33:" in this case. T

[PATCH 7/9] videobuf2/videobuf2-dma-sg.c: Convert to use vm_insert_range

2018-11-15 Thread Souptick Joarder
Convert to use vm_insert_range to map range of kernel memory to user vma. Signed-off-by: Souptick Joarder Reviewed-by: Matthew Wilcox --- drivers/media/common/videobuf2/videobuf2-dma-sg.c | 23 +++ 1 file changed, 7 insertions(+), 16 deletions(-) diff --git a/drivers/media/

Re: [Ksummit-discuss] [RFC PATCH 2/3] MAINTAINERS, Handbook: Subsystem Profile

2018-11-15 Thread Mauro Carvalho Chehab
Em Wed, 14 Nov 2018 20:53:25 -0800 Dan Williams escreveu: > As presented at the 2018 Linux Plumbers conference [1], the Subsystem > Profile is proposed as a way to reduce friction between committers and > maintainers and perhaps encourage conversations amongst maintainers > about best practice po

[PATCH 1/9] mm: Introduce new vm_insert_range API

2018-11-15 Thread Souptick Joarder
Previouly drivers have their own way of mapping range of kernel pages/memory into user vma and this was done by invoking vm_insert_page() within a loop. As this pattern is common across different drivers, it can be generalized by creating a new function and use it across the drivers. vm_insert_ra

[PATCH 0/9] Use vm_insert_range

2018-11-15 Thread Souptick Joarder
Previouly drivers have their own way of mapping range of kernel pages/memory into user vma and this was done by invoking vm_insert_page() within a loop. As this pattern is common across different drivers, it can be generalized by creating a new function and use it across the drivers. vm_insert_ra

Re: [linux-sunxi] [PATCH 14/15] arm64: dts: allwinner: h5: Add Video Engine and reserved memory node

2018-11-15 Thread Chen-Yu Tsai
On Thu, Nov 15, 2018 at 10:51 PM Paul Kocialkowski wrote: > > This adds nodes for the Video Engine and the associated reserved memory > for the H5. Up to 96 MiB of memory are dedicated to the CMA pool. > > The pool is located at the end of the first 256 MiB of RAM so that the > VPU can access it.

[PATCH v2 2/2] media: cedrus: Add H264 decoding support

2018-11-15 Thread Maxime Ripard
Introduce some basic H264 decoding support in cedrus. So far, only the baseline profile videos have been tested, and some more advanced features used in higher profiles are not even implemented. Signed-off-by: Maxime Ripard --- drivers/staging/media/sunxi/cedrus/Makefile | 3 +- drivers/stag

[PATCH v2 0/2] media: cedrus: Add H264 decoding support

2018-11-15 Thread Maxime Ripard
Hi, Here is a new version of the H264 decoding support in the cedrus driver. As you might already know, the cedrus driver relies on the Request API, and is a reverse engineered driver for the video decoding engine found on the Allwinner SoCs. This work has been possible thanks to the work done

[PATCH v2 1/2] media: uapi: Add H264 low-level decoder API compound controls.

2018-11-15 Thread Maxime Ripard
From: Pawel Osciak Stateless video codecs will require both the H264 metadata and slices in order to be able to decode frames. This introduces the definitions for a new pixel format for H264 slices that have been parsed, as well as the structures used to pass the metadata from the userspace to t

[PATCH 05/15] dt-bindings: sram: sunxi: Add bindings for the H5 with SRAM C1

2018-11-15 Thread Paul Kocialkowski
This introduces new bindings for the H5 SoC in the SRAM controller. Because the SRAM layout is different from other SoCs, no backward compatibility is assumed with any of them. However, the C1 SRAM section alone looks similar to previous SoCs, so it is compatible with the initial A10 binding. Sig

[PATCH 02/15] ARM: dts: sun8i-h3: Remove heading 0 in video-codec unit address

2018-11-15 Thread Paul Kocialkowski
This cosmetic change removes the heading 0 in the video-codec unit address, as it's done for other nodes. Signed-off-by: Paul Kocialkowski --- arch/arm/boot/dts/sun8i-h3.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/s

[PATCH 00/15] Cedrus support for the Allwinner H5 and A64 platforms

2018-11-15 Thread Paul Kocialkowski
This series adds support for the Allwinner H5 and A64 platforms to the cedrus stateless video codec driver, with minor fixes to H3 support. It requires changes to the SRAM driver bindings and driver, to properly support the H5 and the A64 C1 SRAM section. Because a H5-specific system-control node

[PATCH 01/15] ARM: dts: sun8i-a33: Remove heading 0 in video-codec unit address

2018-11-15 Thread Paul Kocialkowski
This cosmetic change removes the heading 0 in the video-codec unit address, as it's done for other nodes. Signed-off-by: Paul Kocialkowski --- arch/arm/boot/dts/sun8i-a33.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/sun8i-a33.dtsi b/arch/arm/boot/dts

[PATCH 03/15] ARM: dts: sun8i-h3: Fix the system-control register range

2018-11-15 Thread Paul Kocialkowski
Unlike in previous generations, the system-control register range is not limited to a size of 0x30 on the H3. In particular, the EMAC clock configuration register (accessed through syscon) is at offset 0x30 in that range. Extend the register size to its full range (0x1000) as a result. Signed-off

[PATCH 06/15] soc: sunxi: sram: Add support for the H5 SoC system control

2018-11-15 Thread Paul Kocialkowski
This adds the H5 SoC compatible to the list of device-tree matches for the SRAM driver. Since the variant is the same as the A64 (that precedes the H5), the same variant description is used. Signed-off-by: Paul Kocialkowski --- drivers/soc/sunxi/sunxi_sram.c | 4 1 file changed, 4 insertion

[PATCH 09/15] dt-bindings: sram: sunxi: Add compatible for the A64 SRAM C1

2018-11-15 Thread Paul Kocialkowski
This introduces a new compatible for the A64 SRAM C1 section, that is compatible with the SRAM C1 section as found on the A10. Signed-off-by: Paul Kocialkowski --- Documentation/devicetree/bindings/sram/sunxi-sram.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/b

[PATCH 11/15] dt-bindings: media: cedrus: Add compatibles for the A64 and H5

2018-11-15 Thread Paul Kocialkowski
This introduces two new compatibles for the cedrus driver, for the A64 and H5 platforms. Signed-off-by: Paul Kocialkowski --- Documentation/devicetree/bindings/media/cedrus.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/media/cedrus.txt b/Documentati

[PATCH 10/15] arm64: dts: allwinner: a64: Add support for the SRAM C1 section

2018-11-15 Thread Paul Kocialkowski
Add the description for the SRAM C1 section to the A64 device-tree. Signed-off-by: Paul Kocialkowski --- arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 14 ++ 1 file changed, 14 insertions(+) diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinne

[PATCH 04/15] soc: sunxi: sram: Enable EMAC clock access for H3 variant

2018-11-15 Thread Paul Kocialkowski
Just like the A64 and H5, the H3 SoC uses the system control block to enable the EMAC clock. Add a variant structure definition for the H3 and use it over the A10 one. This will allow using the H3-specific binding for the syscon node attached to the EMAC instead of the generic syscon binding. Sig

[PATCH 13/15] media: cedrus: Add device-tree compatible and variant for A64 support

2018-11-15 Thread Paul Kocialkowski
Add the necessary compatible for supporting the A64 SoC along with a description of the capabilities of this variant. Signed-off-by: Paul Kocialkowski --- drivers/staging/media/sunxi/cedrus/cedrus.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/staging/media/sunxi/cedrus/ce

[PATCH 14/15] arm64: dts: allwinner: h5: Add Video Engine and reserved memory node

2018-11-15 Thread Paul Kocialkowski
This adds nodes for the Video Engine and the associated reserved memory for the H5. Up to 96 MiB of memory are dedicated to the CMA pool. The pool is located at the end of the first 256 MiB of RAM so that the VPU can access it. It is unclear whether this is still a hard requirement for this platfo

[PATCH 15/15] arm64: dts: allwinner: a64: Add Video Engine and reserved memory node

2018-11-15 Thread Paul Kocialkowski
This adds nodes for the Video Engine and the associated reserved memory for the A64. Up to 96 MiB of memory are dedicated to the CMA pool. The pool is located at the end of the first 256 MiB of RAM so that the VPU can access it. It is unclear whether this is still a hard requirement for this platf

[PATCH 12/15] media: cedrus: Add device-tree compatible and variant for H5 support

2018-11-15 Thread Paul Kocialkowski
Add the necessary compatible for supporting the H5 SoC along with a description of the capabilities of this variant. Signed-off-by: Paul Kocialkowski --- drivers/staging/media/sunxi/cedrus/cedrus.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/staging/media/sunxi/cedrus/ced

[PATCH 08/15] ARM/arm64: sunxi: Move H3/H5 syscon label over to soc-specific nodes

2018-11-15 Thread Paul Kocialkowski
Now that we have specific nodes for the H3 and H5 system-controller that allow proper access to the EMAC clock configuration register, we no longer need a common dummy syscon node. Switch the syscon label over to each platform's dtsi file. Signed-off-by: Paul Kocialkowski --- arch/arm/boot/dts/

[PATCH 07/15] arm64: dts: allwinner: h5: Add system-control node with SRAM C1

2018-11-15 Thread Paul Kocialkowski
Add the H5-specific system control node description to its device-tree with support for the SRAM C1 section, that will be used by the video codec node later on. Signed-off-by: Paul Kocialkowski --- arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi | 22 1 file changed, 22 inserti

[PATCH] media: cedrus: Remove global IRQ spin lock from the driver

2018-11-15 Thread Paul Kocialkowski
We initially introduced a spin lock to ensure that the VPU registers are not accessed concurrently between our setup function and IRQ handler. Because the V4L2 M2M API only allows one job to run at a time and our jobs are completed following the IRQ handler, there is actually no chance of an interr

Re: [PATCH v2 1/2] media: docs-rst: Document memory-to-memory video decoder interface

2018-11-15 Thread Hans Verkuil
On 10/22/2018 04:48 PM, Tomasz Figa wrote: > Due to complexity of the video decoding process, the V4L2 drivers of > stateful decoder hardware require specific sequences of V4L2 API calls > to be followed. These include capability enumeration, initialization, > decoding, seek, pause, dynamic resolut

Re: [PATCH v4l-utils] v4l2-compliance: test orphaned buffer support

2018-11-15 Thread Hans Verkuil
On 11/15/18 13:52, Philipp Zabel wrote: > On Thu, 2018-11-15 at 11:21 +0100, Hans Verkuil wrote: >> On 11/14/18 15:38, Philipp Zabel wrote: >>> Test that V4L2_BUF_CAP_SUPPORTS_ORPHANED_BUFS is reported equally for >>> both MMAP and DMABUF memory types. If supported, try to orphan buffers >>> by cal

Re: [PATCH v4l-utils] v4l2-compliance: test orphaned buffer support

2018-11-15 Thread Philipp Zabel
On Thu, 2018-11-15 at 11:21 +0100, Hans Verkuil wrote: > On 11/14/18 15:38, Philipp Zabel wrote: > > Test that V4L2_BUF_CAP_SUPPORTS_ORPHANED_BUFS is reported equally for > > both MMAP and DMABUF memory types. If supported, try to orphan buffers > > by calling reqbufs(0) before unmapping or closing

Re: [PATCH v7 14/16] intel-ipu3: Add v4l2 driver based on media framework

2018-11-15 Thread Hans Verkuil
On 10/29/18 23:23, Yong Zhi wrote: > Implement video driver that utilizes v4l2, vb2 queue support > and media controller APIs. The driver exposes single > subdevice and six nodes. > > Signed-off-by: Yong Zhi > --- > drivers/media/pci/intel/ipu3/ipu3-v4l2.c | 1091 > +

Re: [PATCH v7 03/16] v4l: Add Intel IPU3 meta data uAPI

2018-11-15 Thread Hans Verkuil
On 10/29/18 23:22, Yong Zhi wrote: > These meta formats are used on Intel IPU3 ImgU video queues > to carry 3A statistics and ISP pipeline parameters. > > V4L2_META_FMT_IPU3_3A > V4L2_META_FMT_IPU3_PARAMS > > Signed-off-by: Yong Zhi > Signed-off-by: Chao C Li > Signed-off-by: Rajmohan Mani > -

Re: [PATCH v3] media: vb2: Allow reqbufs(0) with "in use" MMAP buffers

2018-11-15 Thread Sakari Ailus
On Thu, Nov 15, 2018 at 11:29:35AM +0100, Hans Verkuil wrote: > On 11/14/18 20:59, Laurent Pinchart wrote: > > Hi Philipp, > > > > Thank you for the patch. > > > > On Wednesday, 14 November 2018 17:04:49 EET Philipp Zabel wrote: > >> From: John Sheu > >> > >> Videobuf2 presently does not allow V

Re: Logitech QuickCam USB detected by Linux, but not user space applications

2018-11-15 Thread Mauro Carvalho Chehab
Em Thu, 15 Nov 2018 11:42:32 +0100 Paul Menzel escreveu: > Dear Linux folks, > > > I tried to get a Logitech QuickCam USB camera working, but unfortunately, it > is > not detected by user space (Cheese, MPlayer). Could you please try it with Camorama? https://github.com/alessio/camo

[PATCH vicodec v4 3/3] media: vicodec: Add support for 4 planes formats

2018-11-15 Thread Dafna Hirschfeld
Add support for formats with 4 planes: V4L2_PIX_FMT_ABGR32, V4L2_PIX_FMT_ARGB32. Also add alpha plane related flags to the header of the encoded file. Signed-off-by: Dafna Hirschfeld --- drivers/media/platform/vicodec/codec-fwht.c | 15 + drivers/media/platform/vicodec/codec-fwht.h |

[PATCH vicodec v4 2/3] media: vicodec: Add support of greyscale format

2018-11-15 Thread Dafna Hirschfeld
Add support for single plane greyscale format V4L2_PIX_FMT_GREY. Also change the header of the encoded file to include the number of components. Signed-off-by: Dafna Hirschfeld --- drivers/media/platform/vicodec/codec-fwht.c | 56 +++ drivers/media/platform/vicodec/codec-fwht.h

[PATCH vicodec v4 1/3] media: vicodec: prepare support for various number of planes

2018-11-15 Thread Dafna Hirschfeld
Add fields to the structs `fwht_raw_frame`, `v4l2_fwht_pixfmts` to support various number of planes - formats with alpha channel that have 4 planes and greyscale formats that have 1 plane. Signed-off-by: Dafna Hirschfeld --- drivers/media/platform/vicodec/codec-fwht.c | 2 +- drivers/media/pl

[PATCH vicodec v4 0/3] Add support to more pixel formats in vicodec

2018-11-15 Thread Dafna Hirschfeld
The new supported formats are V4L2_PIX_FMT_GREY, V4L2_PIX_FMT_ARGB32, V4L2_PIX_FMT_ABGR32. The returned encoded format is chaned to support various numbers of planes instead of assuming 3 planes. The first patch adds new fields to structs. The second patch adds support for V4L2_PIX_FMT_GREY. The

Re: [PATCH v7 03/16] v4l: Add Intel IPU3 meta data uAPI

2018-11-15 Thread Hans Verkuil
On 11/07/18 00:27, Mani, Rajmohan wrote: > Hi Mauro, > > Thanks for the reviews. > >> Subject: Re: [PATCH v7 03/16] v4l: Add Intel IPU3 meta data uAPI >> >> Hi Mauro, >> >> On Fri, Nov 2, 2018 at 10:49 PM Mauro Carvalho Chehab >> wrote: >>> >>> Em Mon, 29 Oct 2018 15:22:57 -0700 >>> Yong Zhi es

Logitech QuickCam USB detected by Linux, but not user space applications

2018-11-15 Thread Paul Menzel
Dear Linux folks, I tried to get a Logitech QuickCam USB camera working, but unfortunately, it is not detected by user space (Cheese, MPlayer). It’s an old device, so it could be broken, but as it’s detected by the Linux kernel, I wanted to check with you first. Linux 4.18.10 from Debian Sid/u

Re: [PATCH v3] media: vb2: Allow reqbufs(0) with "in use" MMAP buffers

2018-11-15 Thread Hans Verkuil
On 11/14/18 16:04, Philipp Zabel wrote: > From: John Sheu > > Videobuf2 presently does not allow VIDIOC_REQBUFS to destroy outstanding > buffers if the queue is of type V4L2_MEMORY_MMAP, and if the buffers are > considered "in use". This is different behavior than for other memory > types and pr

Re: [PATCH v3] media: vb2: Allow reqbufs(0) with "in use" MMAP buffers

2018-11-15 Thread Hans Verkuil
On 11/14/18 20:59, Laurent Pinchart wrote: > Hi Philipp, > > Thank you for the patch. > > On Wednesday, 14 November 2018 17:04:49 EET Philipp Zabel wrote: >> From: John Sheu >> >> Videobuf2 presently does not allow VIDIOC_REQBUFS to destroy outstanding >> buffers if the queue is of type V4L2_MEM

Re: [PATCH v4l-utils] v4l2-compliance: test orphaned buffer support

2018-11-15 Thread Hans Verkuil
On 11/14/18 15:38, Philipp Zabel wrote: > Test that V4L2_BUF_CAP_SUPPORTS_ORPHANED_BUFS is reported equally for > both MMAP and DMABUF memory types. If supported, try to orphan buffers > by calling reqbufs(0) before unmapping or closing DMABUF fds. > > Also close exported DMABUF fds and free buffe

Re: [PATCH v5 0/2] media: platform: Add Aspeed Video Engine Driver

2018-11-15 Thread Hans Verkuil
On 11/12/2018 10:00 PM, Eddie James wrote: > From: Eddie James > > The Video Engine (VE) embedded in the Aspeed AST2400 and AST2500 SOCs > can capture and compress video data from digital or analog sources. With > the Aspeed chip acting as a service processor, the Video Engine can > capture the h

Re: [PATCH v2] media: venus: dynamic handling of bitrate

2018-11-15 Thread Stanimir Varbanov
Hi Malathi, Thanks for the patch! On 11/2/18 2:41 PM, Malathi Gottam wrote: > Any request for a change in bitrate after both planes > are streamed on is handled by setting the target bitrate > property to hardware. > > Signed-off-by: Malathi Gottam > --- > drivers/media/platform/qcom/venus/ven

Re: [PATCH v5 2/2] media: platform: Add Aspeed Video Engine driver

2018-11-15 Thread Hans Verkuil
On 11/12/2018 10:00 PM, Eddie James wrote: > The Video Engine (VE) embedded in the Aspeed AST2400 and AST2500 SOCs > can capture and compress video data from digital or analog sources. With > the Aspeed chip acting a service processor, the Video Engine can capture > the host processor graphics outp

Re: [PATCH] cedrus: add action item to the TODO

2018-11-15 Thread Paul Kocialkowski
Hi, On Thu, 2018-11-15 at 08:49 +0100, Hans Verkuil wrote: > Mention that the request validation should increment the memory refcount > of reference buffers so we don't forget to do this. Thanks for adding this item, we should definitely take care of it before unstaging. Acked-by: Paul Kocialkow

vim2m/vicodec: set device_caps in video_device struct

2018-11-15 Thread Hans Verkuil
Instead of setting device_caps/capabilities in the querycap ioctl, set it in struct video_device instead. Signed-off-by: Hans Verkuil --- diff --git a/drivers/media/platform/vicodec/vicodec-core.c b/drivers/media/platform/vicodec/vicodec-core.c index 72245183b077..35703c251d1b 100644 --- a/drive

Re: [PATCH] media: vb2: Allow reqbufs(0) with "in use" MMAP buffers

2018-11-15 Thread Hans Verkuil
On 11/15/2018 08:49 AM, Laurent Pinchart wrote: > Hi Hans, > > > On Thursday, 15 November 2018 09:30:55 EET Hans Verkuil wrote: >> On 11/14/2018 08:52 PM, Laurent Pinchart wrote: >>> On Tuesday, 13 November 2018 17:43:48 EET Hans Verkuil wrote: On 11/13/18 16:06, Philipp Zabel wrote: > F