cron job: media_tree daily build: ERRORS

2017-08-29 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Wed Aug 30 05:00:15 CEST 2017 media-tree git hash:9a45bf28bc39ff6ed45a008f7201289c8e9e60a6 media_build gi

GP fault in cx18 module from v4l-dvb drivers on linuxtv.org (Ubuntu 17.04)

2017-08-29 Thread Mike Atkinson
Having a problem with a #GP fault when loading the cx18 driver from v4l-dvb from the linuxtv.org site. Device: Hauppauge HVR-1600 (lspci output at pastebin.com/e7G52kqQ) (ATSC signals) Environment: Ubuntu 17.04, kernel 4.10.0-33-generic, 64-bit Hardware: Motherboard: Gigabyte GA-B150M-D3H

[media] cx24113: Improve a size determination in cx24113_attach()

2017-08-29 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 29 Aug 2017 22:17:25 +0200 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Mar

[PATCH 2/3] [media] cx24113: Return directly after a failed kzalloc() in cx24113_attach()

2017-08-29 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 29 Aug 2017 22:10:49 +0200 Return directly after a call of the function "kzalloc" failed at the beginning. Signed-off-by: Markus Elfring --- drivers/media/dvb-frontends/cx24113.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/d

[PATCH 1/3] [media] cx24113: Delete an error message for a failed memory allocation in cx24113_attach()

2017-08-29 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 29 Aug 2017 22:08:09 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/media/dvb-frontends/cx24113.c | 5 ++--- 1 file changed, 2 ins

Re: [PATCH 2/4] [media] media: pci: make i2c_adapter const

2017-08-29 Thread Wolfram Sang
On Sat, Aug 19, 2017 at 04:04:13PM +0530, Bhumika Goyal wrote: > Make these const as they are only used in a copy operation. > Done using Coccinelle > > Signed-off-by: Bhumika Goyal Acked-by: Wolfram Sang signature.asc Description: PGP signature

Re: [PATCH 3/4] [media] radio-usb-si4713: make i2c_adapter const

2017-08-29 Thread Wolfram Sang
On Sat, Aug 19, 2017 at 04:04:14PM +0530, Bhumika Goyal wrote: > Make this const as it is only used in a copy operation. > Done using Coccinelle > > Signed-off-by: Bhumika Goyal Acked-by: Wolfram Sang signature.asc Description: PGP signature

[PATCH 0/3] [media] cx24113: Adjustments for cx24113_attach()

2017-08-29 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 29 Aug 2017 22:23:45 +0200 Three update suggestions were taken into account from static source code analysis. Markus Elfring (3): Delete an error message for a failed memory allocation Return directly after a failed kzalloc() Improve a size determination d

Re: [PATCH 4/4] [media] usb: make i2c_adapter const

2017-08-29 Thread Wolfram Sang
On Sat, Aug 19, 2017 at 04:04:15PM +0530, Bhumika Goyal wrote: > Make these const as they are only used in a copy operation. > Done using Coccinelle > > Signed-off-by: Bhumika Goyal Acked-by: Wolfram Sang signature.asc Description: PGP signature

Re: [PATCH 1/4] i2c: busses: make i2c_adapter const

2017-08-29 Thread Wolfram Sang
On Sat, Aug 19, 2017 at 04:04:12PM +0530, Bhumika Goyal wrote: > Make these const as they are only used in a copy operation. > Done using Coccinelle. > > Signed-off-by: Bhumika Goyal Applied to for-next, thanks! signature.asc Description: PGP signature

Re: [PATCH 1/2] i2c: busses: make i2c_algorithm const

2017-08-29 Thread Wolfram Sang
On Fri, Aug 18, 2017 at 09:36:57PM +0530, Bhumika Goyal wrote: > Make these const as they are only stored in the algo field of > i2c_adapter structure, which is const. > > Signed-off-by: Bhumika Goyal Applied to for-next, thanks! signature.asc Description: PGP signature

[PATCH 0/2] [media] as102_fe: Adjustments for as102_attach()

2017-08-29 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 29 Aug 2017 21:39:12 +0200 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation Improve a size determination drivers/media/dvb-frontends/as102_fe.c | 7 +++

[media] as102_fe: Improve a size determination in as102_attach()

2017-08-29 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 29 Aug 2017 21:30:38 +0200 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was det

[PATCH 1/2] [media] as102_fe: Delete an error message for a failed memory allocation in as102_attach()

2017-08-29 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 29 Aug 2017 21:26:12 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/media/dvb-frontends/as102_fe.c | 5 ++--- 1 file changed, 2 in

make menuconfig on media_build

2017-08-29 Thread Thomas Kaiser
Dear List When I run "make menuconfig" on media_build the following errors occur: thomas@Intel64:~/Projects/dvb/media_build$ make menuconfig make -C /home/thomas/Projects/dvb/media_build/v4l menuconfig make[1]: Entering directory '/home/thomas/Projects/dvb/media_build/v4l' /lib/modules/4.10.0-33

[PATCH] [media] img-ir: Delete an error message for a failed memory allocation in img_ir_probe()

2017-08-29 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 29 Aug 2017 21:04:20 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/media/rc/img-ir/img-ir-core.c | 5 ++--- 1 file changed, 2 ins

Re: [PATCH] linux-firmware: intel: Add Kabylake IPU3 firmware

2017-08-29 Thread Kyle McMartin
On Thu, Aug 24, 2017 at 10:10:25AM +0900, Tomasz Figa wrote: > On Thu, Aug 24, 2017 at 1:54 AM, Kyle McMartin wrote: > > On Fri, Jul 21, 2017 at 12:08:32AM +, Mani, Rajmohan wrote: > >> I am also following up on the second approach to submit the IPU3 firmware > >> patch. > >> > >> git remote

Re: [PATCH v4 04/21] doc: media/v4l-drivers: Add Qualcomm Camera Subsystem driver document

2017-08-29 Thread Daniel Mack
Hi Todor, On 08/28/2017 09:10 AM, Todor Tomov wrote: > On 25.08.2017 17:10, Daniel Mack wrote: >> I have a userspace test setup that works fine for USB webcams, but when >> operating on any of the video devices exposed by this driver, the >> lowlevel functions such as .s_power of the ISPIF, CSID,

Inquiry 29-08-2017

2017-08-29 Thread Julian Smith
Hello, My name is Ms Julian Smith and i am from Sinara Group Co.,LTD in Russia..We are glad to know about your company from the web and we are interested in your products.Please send us your Latest catalog and price list for our trial order Julian Smith, Purchasing Manager

Re: [PATCH 1/1] dt: bindings: Add a binding for flash devices associated to a sensor

2017-08-29 Thread Rob Herring
On Fri, Aug 18, 2017 at 03:58:57PM +0300, Sakari Ailus wrote: > Camera flash drivers (and LEDs) are separate from the sensor devices in > DT. In order to make an association between the two, provide the > association information to the software. > > Signed-off-by: Sakari Ailus > --- > Hi Rob and

Re: [PATCH 00/20] Add multiplexed media pads to support CSI-2 virtual channels

2017-08-29 Thread Maxime Ripard
Hi Niklas, On Fri, Aug 11, 2017 at 11:56:43AM +0200, Niklas Söderlund wrote: > This series is a RFC for how I think one could add CSI-2 virtual channel > support to the V4L2 framework. The problem is that there is no way to in > the media framework describe and control links between subdevices w

Re: [PATCH v5 4/5] v4l: fwnode: Support generic parsing of graph endpoints in a device

2017-08-29 Thread Sakari Ailus
Hi Laurent, On Tue, Aug 29, 2017 at 05:02:54PM +0300, Laurent Pinchart wrote: > Hi Sakari, > > Thank you for the patch. Thanks for the review! > > On Tuesday, 29 August 2017 14:03:12 EEST Sakari Ailus wrote: > > The current practice is that drivers iterate over their endpoints and > > parse ea

Re: [PATCH v5 4/5] v4l: fwnode: Support generic parsing of graph endpoints in a device

2017-08-29 Thread Laurent Pinchart
Hi Sakari, Thank you for the patch. On Tuesday, 29 August 2017 14:03:12 EEST Sakari Ailus wrote: > The current practice is that drivers iterate over their endpoints and > parse each endpoint separately. This is very similar in a number of > drivers, implement a generic function for the job. Drive

[PATCH 1/1] media: Check for active and has_no_links overrun

2017-08-29 Thread Sakari Ailus
From: Sakari Ailus The active and has_no_links arrays will overrun in media_entity_pipeline_start() if there's an entity which has more than MEDIA_ENTITY_MAX_PAD pads. Ensure in media_entity_init() that there are fewer pads than that. Signed-off-by: Sakari Ailus --- drivers/media/media-entity.

Re: [PATCH v5 3/5] docs-rst: v4l: Include Qualcomm CAMSS in documentation build

2017-08-29 Thread Laurent Pinchart
Hi Sakari, Thank you for the patch. On Tuesday, 29 August 2017 14:03:11 EEST Sakari Ailus wrote: > Qualcomm CAMSS was left out from documentation build. Fix this. > > Signed-off-by: Sakari Ailus I've tested the qcom_camss documentation build and haven't noticed any new warning or error, so R

Re: [PATCH v5 1/5] v4l: fwnode: Move KernelDoc documentation to the header

2017-08-29 Thread Sakari Ailus
On Tue, Aug 29, 2017 at 04:20:10PM +0300, Sakari Ailus wrote: > Hi Laurent, > > On Tue, Aug 29, 2017 at 04:15:22PM +0300, Laurent Pinchart wrote: > > Hi Sakari, > > > > Thank you for the patch. > > > > On Tuesday, 29 August 2017 14:03:09 EEST Sakari Ailus wrote: > > > In V4L2 the practice is to

Re: [PATCH v5 1/5] v4l: fwnode: Move KernelDoc documentation to the header

2017-08-29 Thread Sakari Ailus
Hi Laurent, On Tue, Aug 29, 2017 at 04:15:22PM +0300, Laurent Pinchart wrote: > Hi Sakari, > > Thank you for the patch. > > On Tuesday, 29 August 2017 14:03:09 EEST Sakari Ailus wrote: > > In V4L2 the practice is to have the KernelDoc documentation in the header > > and not in .c source code fil

[PATCH v6 3/7] media: open.rst: remove the minor number range

2017-08-29 Thread Mauro Carvalho Chehab
minor numbers use to range between 0 to 255, but that was changed a long time ago. While it still applies when CONFIG_VIDEO_FIXED_MINOR_RANGES, when the minor number is dynamically allocated, this may not be true. In any case, this is not relevant, as udev will take care of it. So, remove this use

[PATCH v6 2/7] media: open.rst: better document device node naming

2017-08-29 Thread Mauro Carvalho Chehab
Right now, only kAPI documentation describes the device naming. However, such description is needed at the uAPI too. Add it, and describe how to get an unique identify for a given device. Acked-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab --- Documentation/media/uapi/v4l/open.rst | 44

[PATCH v6 6/7] media: videodev2: add a flag for MC-centric devices

2017-08-29 Thread Mauro Carvalho Chehab
As both vdev-centric and MC-centric devices may implement the same APIs, we need a flag to allow userspace to distinguish between them. Signed-off-by: Mauro Carvalho Chehab --- Documentation/media/uapi/v4l/open.rst| 7 +++ Documentation/media/uapi/v4l/vidioc-querycap.rst | 5

[PATCH v6 0/7] document types of hardware control for V4L2

2017-08-29 Thread Mauro Carvalho Chehab
On Kernel 2.6.39, the omap3 driver was introduced together with a new way to control complex V4L2 devices used on embedded systems, but this was never documented, as the original idea were to have "soon" support for standard apps to use it as well, via libv4l, but that didn't happen so far. Also,

[PATCH v6 5/7] media: open.rst: Adjust some terms to match the glossary

2017-08-29 Thread Mauro Carvalho Chehab
As we now have a glossary, some terms used on open.rst require adjustments. Acked-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab --- Documentation/media/uapi/v4l/open.rst | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/Documentation/media/uapi/v4l/open.rs

[PATCH v6 4/7] media: open.rst: document devnode-centric and mc-centric types

2017-08-29 Thread Mauro Carvalho Chehab
When we added support for omap3, back in 2010, we added a new type of V4L2 devices that aren't fully controlled via the V4L2 device node. Yet, we have never clearly documented in the V4L2 specification the differences between the two types. Let's document them based on the the current implementat

[PATCH v6 7/7] media: open.rst: add a notice about subdev-API on vdev-centric

2017-08-29 Thread Mauro Carvalho Chehab
The documentation doesn't mention if vdev-centric hardware control would have subdev API or not. Add a notice about that, reflecting the current status, where three drivers use it, in order to support some subdev-specific controls. Signed-off-by: Mauro Carvalho Chehab --- Documentation/media/ua

[PATCH v6 1/7] media: add glossary.rst with a glossary of terms used at V4L2 spec

2017-08-29 Thread Mauro Carvalho Chehab
Add a glossary of terms for V4L2, as several concepts are complex enough to cause misunderstandings. Signed-off-by: Mauro Carvalho Chehab --- Documentation/media/uapi/v4l/glossary.rst | 150 ++ Documentation/media/uapi/v4l/v4l2.rst | 1 + 2 files changed, 151 in

Re: [PATCH v5 1/5] v4l: fwnode: Move KernelDoc documentation to the header

2017-08-29 Thread Laurent Pinchart
Hi Sakari, Thank you for the patch. On Tuesday, 29 August 2017 14:03:09 EEST Sakari Ailus wrote: > In V4L2 the practice is to have the KernelDoc documentation in the header > and not in .c source code files. This consequientally makes the V4L2 > fwnode function documentation part of the Media doc

Re: [PATCH v5 1/7] media: add glossary.rst with a glossary of terms used at V4L2 spec

2017-08-29 Thread Mauro Carvalho Chehab
Em Tue, 29 Aug 2017 10:47:48 +0300 Sakari Ailus escreveu: > Hi Mauro, > > Thanks for the update. A few comments below. > > On Mon, Aug 28, 2017 at 09:53:55AM -0300, Mauro Carvalho Chehab wrote: > > Add a glossary of terms for V4L2, as several concepts are complex > > enough to cause misundersta

Re: [PATCH v5 5/5] v4l: fwnode: Support generic parsing of graph endpoints in a single port

2017-08-29 Thread Niklas Söderlund
Hi Sakari, Thanks for your patch, I like how this turned out :-) On 2017-08-29 14:03:13 +0300, Sakari Ailus wrote: > This is the preferred way to parse the endpoints. > > Comment rcar-vin as an example. > > Signed-off-by: Sakari Ailus Acked-by: Niklas Söderlund > --- > drivers/media/platfo

Re: [PATCH v5 2/5] v4l: async: Add V4L2 async documentation to the documentation build

2017-08-29 Thread Niklas Söderlund
Hi Sakari, Thanks for your patch. On 2017-08-29 14:03:10 +0300, Sakari Ailus wrote: > The V4L2 async wasn't part of the documentation build. Fix this. > > Signed-off-by: Sakari Ailus Reviewed-by: Niklas Söderlund > --- > Documentation/media/kapi/v4l2-async.rst | 3 +++ > Documentation/media

Re: [PATCH v5 1/5] v4l: fwnode: Move KernelDoc documentation to the header

2017-08-29 Thread Niklas Söderlund
Hi Sakari, Thanks for your patch. On 2017-08-29 14:03:09 +0300, Sakari Ailus wrote: > In V4L2 the practice is to have the KernelDoc documentation in the header > and not in .c source code files. This consequientally makes the V4L2 > fwnode function documentation part of the Media documentation bu

[PATCH 4/4] smiapp: Make clock control optional

2017-08-29 Thread Sakari Ailus
The clock control is not explicitly controlled by the driver in two cases: ACPI based systems and when the clock is part of the power sequence of the camera module. Signed-off-by: Sakari Ailus --- drivers/media/i2c/smiapp/smiapp-core.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) d

[PATCH 1/4] smiapp: Fix error handling in power on sequence

2017-08-29 Thread Sakari Ailus
The error handling code in smiapp_power_on() returned in case of a failed I2C write instead of cleaning up the mess. Fix this. Signed-off-by: Sakari Ailus --- drivers/media/i2c/smiapp/smiapp-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/smiapp/smiap

[PATCH 2/4] smiapp: Verify clock frequency after setting it, prevent changing it

2017-08-29 Thread Sakari Ailus
The external clock frequency was set by the driver but the obtained frequency was never verified. Do that. Being able to obtain the exact frequency is important as the value is used for PLL calculations which may result in frequencies that violate the PLL tree limits. Signed-off-by: Sakari Ailus

[PATCH 0/4] Better support for ACPI in smiapp

2017-08-29 Thread Sakari Ailus
Hi, The few patches here fix a bug (power sequence error handling) and change clock handling in a way that allow using the driver in systems without explicit clock control, e.g. ACPI. Sakari Ailus (4): smiapp: Fix error handling in power on sequence smiapp: Verify clock frequency after settin

[PATCH 3/4] smiapp: Get clock rate if it's not available through DT

2017-08-29 Thread Sakari Ailus
Obtain the clock rate from the clock framework if it's not available through DT. The assumption is that the parent device (camera module) defines the rate as clock control is a part of the power on and power off sequences --- which are camera module specific. Also use the clock rate from DT if no

Re: [PATCH][media-next] media: qcom: camss: Make function vfe_set_selection static

2017-08-29 Thread Todor Tomov
On 29.08.2017 13:21, Colin King wrote: > From: Colin Ian King > > The function vfe_set_selection is local to the source and does > not need to be in global scope, so make it static. > > Cleans up sparse warning: > warning: symbol 'vfe_set_selection' was not declared. Should it be static? > > Si

[bug report] media: v4l2-flash-led-class: Create separate sub-devices for indicators

2017-08-29 Thread Dan Carpenter
Hello Sakari Ailus, This is a semi-automatic email about new static checker warnings. The patch 503dd28af108: "media: v4l2-flash-led-class: Create separate sub-devices for indicators" from Jul 18, 2017, leads to the following Smatch complaint: drivers/media/v4l2-core/v4l2-flash-led-class.c:210

[PATCH] media: vb2: unify calling of set_page_dirty_lock

2017-08-29 Thread Stanimir Varbanov
Currently videobuf2-dma-sg checks for dma direction for every single page and videobuf2-dc lacks any dma direction checks and calls set_page_dirty_lock unconditionally. Thus unify and align the invocations of set_page_dirty_lock for videobuf2-dc, videobuf2-sg memory allocators with videobuf2-vmal

[PATCH 2/2] [media] imon: Improve a size determination in two functions

2017-08-29 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 29 Aug 2017 12:45:59 +0200 Replace the specification of data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was detec

[PATCH 1/2] [media] imon: Delete an error message for a failed memory allocation in imon_init_intf0()

2017-08-29 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 29 Aug 2017 12:40:07 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/media/rc/imon.c | 5 ++--- 1 file changed, 2 insertions(+), 3

[PATCH 0/2] [media] imon: Adjustments for two function implementations

2017-08-29 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 29 Aug 2017 12:56:54 +0200 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation in imon_init_intf0() Improve a size determination in two functions drivers/

[PATCH v5 3/5] docs-rst: v4l: Include Qualcomm CAMSS in documentation build

2017-08-29 Thread Sakari Ailus
Qualcomm CAMSS was left out from documentation build. Fix this. Signed-off-by: Sakari Ailus --- Documentation/media/v4l-drivers/index.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/media/v4l-drivers/index.rst b/Documentation/media/v4l-drivers/index.rst index 10f2ce42ece2.

[PATCH v5 1/5] v4l: fwnode: Move KernelDoc documentation to the header

2017-08-29 Thread Sakari Ailus
In V4L2 the practice is to have the KernelDoc documentation in the header and not in .c source code files. This consequientally makes the V4L2 fwnode function documentation part of the Media documentation build. Also correct the link related function and argument naming in documentation. Signed-o

[PATCH v5 0/5] Unified fwnode endpoint parser

2017-08-29 Thread Sakari Ailus
Hi folks, We have a large influx of new, unmerged, drivers that are now parsing fwnode endpoints and each one of them is doing this a little bit differently. The needs are still exactly the same for the graph data structure is device independent. This is still a non-trivial task and the majority o

[PATCH v5 4/5] v4l: fwnode: Support generic parsing of graph endpoints in a device

2017-08-29 Thread Sakari Ailus
The current practice is that drivers iterate over their endpoints and parse each endpoint separately. This is very similar in a number of drivers, implement a generic function for the job. Driver specific matters can be taken into account in the driver specific callback. Convert the omap3isp as an

[PATCH v5 5/5] v4l: fwnode: Support generic parsing of graph endpoints in a single port

2017-08-29 Thread Sakari Ailus
This is the preferred way to parse the endpoints. Comment rcar-vin as an example. Signed-off-by: Sakari Ailus --- drivers/media/platform/rcar-vin/rcar-core.c | 111 drivers/media/platform/rcar-vin/rcar-dma.c | 10 +-- drivers/media/platform/rcar-vin/rcar-v4l2.c |

[PATCH v5 2/5] v4l: async: Add V4L2 async documentation to the documentation build

2017-08-29 Thread Sakari Ailus
The V4L2 async wasn't part of the documentation build. Fix this. Signed-off-by: Sakari Ailus --- Documentation/media/kapi/v4l2-async.rst | 3 +++ Documentation/media/kapi/v4l2-core.rst | 1 + 2 files changed, 4 insertions(+) create mode 100644 Documentation/media/kapi/v4l2-async.rst diff --gi

[PATCH][media-next] media: qcom: camss: Make function vfe_set_selection static

2017-08-29 Thread Colin King
From: Colin Ian King The function vfe_set_selection is local to the source and does not need to be in global scope, so make it static. Cleans up sparse warning: warning: symbol 'vfe_set_selection' was not declared. Should it be static? Signed-off-by: Colin Ian King --- drivers/media/platform/

Re: DRM Format Modifiers in v4l2

2017-08-29 Thread Brian Starkey
On Mon, Aug 28, 2017 at 10:49:07PM +0200, Daniel Vetter wrote: On Mon, Aug 28, 2017 at 8:07 PM, Nicolas Dufresne wrote: Le jeudi 24 ao??t 2017 ?? 13:26 +0100, Brian Starkey a ??crit : > What I mean was: an application can use the modifier to give buffers from > one device to another without ne

Re: [PATCH v2 2/2] media:imx274 V4l2 driver for Sony imx274 CMOS sensor

2017-08-29 Thread Sakari Ailus
Hi Sören, Thanks for the patch. Some comments below. On Mon, Aug 28, 2017 at 06:40:26PM -0700, Soren Brinkmann wrote: > From: Leon Luo > > The imx274 is a Sony CMOS image sensor that has 1/2.5 image size. > It supports up to 3840x2160 (4K) 60fps, 1080p 120fps. The interface > is 4-lane MIPI run

Re: DRM Format Modifiers in v4l2

2017-08-29 Thread Brian Starkey
On Fri, Aug 25, 2017 at 10:14:03AM +0200, Hans Verkuil wrote: On 24/08/17 14:26, Brian Starkey wrote: On Thu, Aug 24, 2017 at 01:37:35PM +0200, Hans Verkuil wrote: On 08/24/17 13:14, Brian Starkey wrote: Hi Hans, On Mon, Aug 21, 2017 at 06:36:29PM +0200, Hans Verkuil wrote: On 08/21/2017 06:

Re: [PATCH v4 7/7] media: open.rst: add a notice about subdev-API on vdev-centric

2017-08-29 Thread Mauro Carvalho Chehab
Em Tue, 29 Aug 2017 10:39:52 +0200 Hans Verkuil escreveu: > On 29/08/17 10:31, Ramesh Shanmugasundaram wrote: > > Hi Hans, > > > >> On 28/08/17 12:30, Mauro Carvalho Chehab wrote: > >>> Em Mon, 28 Aug 2017 12:05:06 +0200 > >>> Hans Verkuil escreveu: > >>> > On 26/08/17 13:53, Mauro C

Re: [PATCH 4/4] [media] zr364xx: Fix a typo in a comment line of the file header

2017-08-29 Thread Joe Perches
On Tue, 2017-08-29 at 07:35 +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 28 Aug 2017 22:46:30 +0200 > > Fix a word in this description. > > Signed-off-by: Markus Elfring > --- > drivers/media/usb/zr364xx/zr364xx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [PATCH v5 2/7] media: open.rst: better document device node naming

2017-08-29 Thread Mauro Carvalho Chehab
Hi Sakari, Em Tue, 29 Aug 2017 11:34:06 +0300 Sakari Ailus escreveu: > Hi Mauro, > > On Mon, Aug 28, 2017 at 09:53:56AM -0300, Mauro Carvalho Chehab wrote: > > Right now, only kAPI documentation describes the device naming. > > However, such description is needed at the uAPI too. Add it, > > an

Re: [PATCH v2 1/2] media:imx274 device tree binding file

2017-08-29 Thread Sakari Ailus
Hi Sören, On Mon, Aug 28, 2017 at 06:40:25PM -0700, Soren Brinkmann wrote: > From: Leon Luo > > The binding file for imx274 CMOS sensor V4l2 driver > > Signed-off-by: Leon Luo > Acked-by: Sören Brinkmann > --- > .../devicetree/bindings/media/i2c/imx274.txt | 32 > +

Re: [PATCH v4 7/7] media: open.rst: add a notice about subdev-API on vdev-centric

2017-08-29 Thread Hans Verkuil
On 29/08/17 10:31, Ramesh Shanmugasundaram wrote: > Hi Hans, > >> On 28/08/17 12:30, Mauro Carvalho Chehab wrote: >>> Em Mon, 28 Aug 2017 12:05:06 +0200 >>> Hans Verkuil escreveu: >>> On 26/08/17 13:53, Mauro Carvalho Chehab wrote: > The documentation doesn't mention if vdev-centric hard

Re: [PATCH v5 2/7] media: open.rst: better document device node naming

2017-08-29 Thread Sakari Ailus
Hi Mauro, On Mon, Aug 28, 2017 at 09:53:56AM -0300, Mauro Carvalho Chehab wrote: > Right now, only kAPI documentation describes the device naming. > However, such description is needed at the uAPI too. Add it, > and describe how to get an unique identify for a given device. > > Acked-by: Hans Ver

Re: [PATCH v5 3/7] media: open.rst: remove the minor number range

2017-08-29 Thread Sakari Ailus
On Mon, Aug 28, 2017 at 09:53:57AM -0300, Mauro Carvalho Chehab wrote: > minor numbers use to range between 0 to 255, but that > was changed a long time ago. While it still applies when > CONFIG_VIDEO_FIXED_MINOR_RANGES, when the minor number is > dynamically allocated, this may not be true. In any

RE: [PATCH v4 7/7] media: open.rst: add a notice about subdev-API on vdev-centric

2017-08-29 Thread Ramesh Shanmugasundaram
Hi Hans, > On 28/08/17 12:30, Mauro Carvalho Chehab wrote: > > Em Mon, 28 Aug 2017 12:05:06 +0200 > > Hans Verkuil escreveu: > > > >> On 26/08/17 13:53, Mauro Carvalho Chehab wrote: > >>> The documentation doesn't mention if vdev-centric hardware control > >>> would have subdev API or not. > >>>

[PATCH] media: venus: init registered list on streamoff

2017-08-29 Thread Stanimir Varbanov
Add missing init_list_head for the registered buffer list. Absence of the init could lead to a unhandled kernel paging request as below, when streamon/streamoff are called in row. [338046.571321] Unable to handle kernel paging request at virtual address fe00 [338046.574849] pgd =

Re: [PATCH v5 1/7] media: add glossary.rst with a glossary of terms used at V4L2 spec

2017-08-29 Thread Sakari Ailus
Hi Mauro, Thanks for the update. A few comments below. On Mon, Aug 28, 2017 at 09:53:55AM -0300, Mauro Carvalho Chehab wrote: > Add a glossary of terms for V4L2, as several concepts are complex > enough to cause misunderstandings. > > Signed-off-by: Mauro Carvalho Chehab > --- > Documentation/