The error handling code in smiapp_power_on() returned in case of a failed
I2C write instead of cleaning up the mess. Fix this.

Signed-off-by: Sakari Ailus <sakari.ai...@linux.intel.com>
---
 drivers/media/i2c/smiapp/smiapp-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/i2c/smiapp/smiapp-core.c 
b/drivers/media/i2c/smiapp/smiapp-core.c
index 700f433261d0..d581625d7826 100644
--- a/drivers/media/i2c/smiapp/smiapp-core.c
+++ b/drivers/media/i2c/smiapp/smiapp-core.c
@@ -1313,7 +1313,7 @@ static int smiapp_power_on(struct device *dev)
        rval = smiapp_write(sensor, SMIAPP_REG_U8_DPHY_CTRL,
                            SMIAPP_DPHY_CTRL_UI);
        if (rval < 0)
-               return rval;
+               goto out_cci_addr_fail;
 
        rval = smiapp_call_quirk(sensor, post_poweron);
        if (rval) {
-- 
2.11.0

Reply via email to