Re: [PATCH 0/2] [media] c8sectpfe: Deletion of a few unnecessary checks

2015-11-05 Thread Maxime Coquelin
Hi Markus, On 11/05/2015 07:45 PM, SF Markus Elfring wrote: From: Markus Elfring Date: Thu, 5 Nov 2015 19:39:32 +0100 Another update suggestion was taken into account after a patch was applied from static source code analysis. Markus Elfring (2): Delete unnecessary checks before two functi

Re: Geniatech / Mygica T230

2015-11-05 Thread Olli Salonen
Hi Mike, Can you also paste the dmesg output here, so we can see if the driver is starting up correctly? Cheers, -olli On 3 November 2015 at 23:35, Mike Parkins wrote: > Hi, > I can't get this dvb-t2 USB device to work despite the linuxtv site > claiming it is working since 3.19 kernel. I tried

Re: [PATCH 1/2] vb2: drop v4l2_format argument from queue_setup

2015-11-05 Thread Junghak Sung
Hi Hans, I leave some comments on the body of your patch. On 10/29/2015 01:24 PM, Hans Verkuil wrote: From: Hans Verkuil The queue_setup callback has a void pointer that is just for V4L2 and is the pointer to the v4l2_format struct that was passed to VIDIOC_CREATE_BUFS. The idea was that driv

cron job: media_tree daily build: ERRORS

2015-11-05 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Fri Nov 6 04:00:27 CET 2015 git branch: test git hash: 79f5b6ae960d380c829fb67d5dadcd1d025d2775 gcc versio

[PATCH 2/2] [media] c8sectpfe: Combine three checks into a single if block

2015-11-05 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 5 Nov 2015 19:23:50 +0100 The variable "tsin" was checked three times in a loop iteration of the c8sectpfe_tuner_unregister_frontend() function. This implementation detail could be improved by the combination of the involved statements into a single if block so tha

[PATCH 1/2] [media] c8sectpfe: Delete unnecessary checks before two function calls

2015-11-05 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 5 Nov 2015 18:55:19 +0100 The functions i2c_put_adapter() and module_put() test whether their argument is NULL and then return immediately. Thus the tests around their calls are not needed. This issue was detected by using the Coccinelle software. Signed-off-by:

[PATCH 0/2] [media] c8sectpfe: Deletion of a few unnecessary checks

2015-11-05 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 5 Nov 2015 19:39:32 +0100 Another update suggestion was taken into account after a patch was applied from static source code analysis. Markus Elfring (2): Delete unnecessary checks before two function calls Combine three checks into a single if block drivers

Re: [PATCH] [media] rc-core: Remove 'struct timeval' usage

2015-11-05 Thread Arnd Bergmann
On Thursday 29 October 2015 00:16:57 Tina Ruchandani wrote: > streamzap uses 'struct timeval' to store the start time of a signal for > gap tracking. struct timeval uses a 32-bit seconds representation which > will overflow in year 2038 and beyond. Replace struct timeval with ktime_t > which uses a

Re: [RFC PATCH v9 6/6] media: videobuf2: Move vb2_fileio_data and vb2_thread to core part

2015-11-05 Thread Hans Verkuil
On 11/03/15 11:16, Junghak Sung wrote: > Move things related with vb2 file I/O and vb2_thread without doing any > functional changes. After that, videobuf2-internal.h is removed because > it is not necessary any more. > > Signed-off-by: Junghak Sung > Signed-off-by: Geunyoung Kim > Acked-by: Seu

Re: [RFC PATCH v9 5/6] media: videobuf2: Refactor vb2_fileio_data and vb2_thread

2015-11-05 Thread Hans Verkuil
On 11/03/15 11:16, Junghak Sung wrote: > Replace v4l2-stuffs with common things in struct vb2_fileio_data and > vb2_thread(). > > Signed-off-by: Junghak Sung > Signed-off-by: Geunyoung Kim > Acked-by: Seung-Woo Kim > Acked-by: Inki Dae Acked-by: Hans Verkuil Thanks! Hans -- To unsu

Re: [RFC PATCH v9 4/6] media: videobuf2: last_buffer_queued is set at fill_v4l2_buffer()

2015-11-05 Thread Hans Verkuil
On 11/03/15 11:16, Junghak Sung wrote: > The location in which last_buffer_queued is set is moved to > fill_v4l2_buffer(). > So, __vb2_perform_fileio() can use vb2_core_dqbuf() instead of > vb2_internal_dqbuf(). > > Signed-off-by: Junghak Sung > Signed-off-by: Geunyoung Kim > Acked-by: Seung-Wo

Re: [RFC PATCH v9 3/6] media: videobuf2: Separate vb2_poll()

2015-11-05 Thread Hans Verkuil
Hi Junghak, One comment below: On 11/03/15 11:16, Junghak Sung wrote: > Separate vb2_poll() into core and v4l2 part. > > Signed-off-by: Junghak Sung > Signed-off-by: Geunyoung Kim > Acked-by: Seung-Woo Kim > Acked-by: Inki Dae > --- > drivers/media/v4l2-core/videobuf2-v4l2.c | 80 > +

Re: [Y2038] Which type to use for timestamps: u64 or s64?

2015-11-05 Thread Arnd Bergmann
On Thursday 05 November 2015 10:05:44 Hans Verkuil wrote: > On 11/05/15 09:36, Arnd Bergmann wrote: > > On Thursday 05 November 2015 08:41:11 Hans Verkuil wrote: > >> Hi Arnd, > >> > >> We're redesigning the timestamp handling in the video4linux subsystem > >> moving away > >> from struct timeval

Re: [Y2038] Which type to use for timestamps: u64 or s64?

2015-11-05 Thread Hans Verkuil
On 11/05/15 09:36, Arnd Bergmann wrote: > On Thursday 05 November 2015 08:41:11 Hans Verkuil wrote: >> Hi Arnd, >> >> We're redesigning the timestamp handling in the video4linux subsystem moving >> away >> from struct timeval to a single timestamp in ns (what ktime_get_ns() gives >> us). >> But I

Re: Which type to use for timestamps: u64 or s64?

2015-11-05 Thread Arnd Bergmann
On Thursday 05 November 2015 08:41:11 Hans Verkuil wrote: > Hi Arnd, > > We're redesigning the timestamp handling in the video4linux subsystem moving > away > from struct timeval to a single timestamp in ns (what ktime_get_ns() gives > us). > But I was wondering: ktime_get_ns() gives a s64, so s