From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Thu, 5 Nov 2015 18:55:19 +0100

The functions i2c_put_adapter() and module_put() test whether their
argument is NULL and then return immediately.
Thus the tests around their calls are not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net>
---
 drivers/media/platform/sti/c8sectpfe/c8sectpfe-common.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-common.c 
b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-common.c
index 95223ab..07fd6d9 100644
--- a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-common.c
+++ b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-common.c
@@ -214,12 +214,11 @@ void c8sectpfe_tuner_unregister_frontend(struct c8sectpfe 
*c8sectpfe,
                        dvb_frontend_detach(tsin->frontend);
                }
 
-               if (tsin && tsin->i2c_adapter)
+               if (tsin)
                        i2c_put_adapter(tsin->i2c_adapter);
 
                if (tsin && tsin->i2c_client) {
-                       if (tsin->i2c_client->dev.driver->owner)
-                               module_put(tsin->i2c_client->dev.driver->owner);
+                       module_put(tsin->i2c_client->dev.driver->owner);
                        i2c_unregister_device(tsin->i2c_client);
                }
        }
-- 
2.6.2

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to