Re: [PATCH 4/6] android: convert sync to fence api, v4

2014-03-03 Thread Maarten Lankhorst
op 03-03-14 22:11, Daniel Vetter schreef: On Mon, Feb 17, 2014 at 04:57:19PM +0100, Maarten Lankhorst wrote: Android syncpoints can be mapped to a timeline. This removes the need to maintain a separate api for synchronization. I've left the android trace events in place, but the core fence event

Re: [PATCH 7/7] v4l: ti-vpe: Add crop support in VPE driver

2014-03-03 Thread Hans Verkuil
On 03/04/2014 08:38 AM, Archit Taneja wrote: > Hi Hans, > > On Monday 03 March 2014 01:20 PM, Hans Verkuil wrote: >> Hi Archit! >> >> On 03/03/2014 08:33 AM, Archit Taneja wrote: >>> Add crop ioctl ops. For VPE, cropping only makes sense with the input to >>> VPE, or >>> the V4L2_BUF_TYPE_VIDEO_O

Re: [PATCH 7/7] v4l: ti-vpe: Add crop support in VPE driver

2014-03-03 Thread Archit Taneja
Hi Hans, On Monday 03 March 2014 01:20 PM, Hans Verkuil wrote: Hi Archit! On 03/03/2014 08:33 AM, Archit Taneja wrote: Add crop ioctl ops. For VPE, cropping only makes sense with the input to VPE, or the V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE buffer type. For the CAPTURE type, a S_CROP ioctl resul

Re: SAA7134 warning during resume from S3: regression 3.8.13 -> 3.9.0

2014-03-03 Thread valerio.va...@inwind.it
>Messaggio originale >Da: valerio.va...@inwind.it >Data: 14/02/2014 16.29 >The full report is on bugzilla: >https://bugzilla.kernel.org/show_bug.cgi?id=69581 >[1.] One line summary of the problem: > >Kernel gives a oops warning during resume >from S3 sleep. > >[2.] Full description of the

cron job: media_tree daily build: ERRORS

2014-03-03 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Mar 4 04:00:19 CET 2014 git branch: test git hash: cd701c89751d5c63230f47da9a78cdbb39384fdc gcc versio

Re: Support for Empia 2980 video/audio capture chip set

2014-03-03 Thread Keith Lawson
On Sun, Mar 02, 2014 at 06:54:41PM +0100, Frank Schäfer wrote: > > Am 27.02.2014 02:47, schrieb Keith Lawson: > > On Mon, Feb 24, 2014 at 06:38:59PM +0100, Frank Schäfer wrote: > >> Am 06.02.2014 13:57, schrieb Keith Lawson: > >>> On Mon, Jan 20, 2014 at 09:08:25PM +0100, Frank Schäfer wrote: > >>

[GIT PULL FOR v3.15] OMAP3 ISP and OMAP4 ISS fixes

2014-03-03 Thread Laurent Pinchart
Hi Mauro, The following changes since commit cd701c89751d5c63230f47da9a78cdbb39384fdc: [media] em28xx: implement em28xx_usb_driver suspend, resume, reset_resume hooks (2014-03-03 06:46:48 -0300) are available in the git repository at: git://linuxtv.org/pinchartl/media.git omap3isp/next fo

[GIT PULL FOR v3.15] uvcvideo fixes

2014-03-03 Thread Laurent Pinchart
Hi Mauro, The following changes since commit cd701c89751d5c63230f47da9a78cdbb39384fdc: [media] em28xx: implement em28xx_usb_driver suspend, resume, reset_resume hooks (2014-03-03 06:46:48 -0300) are available in the git repository at: git://linuxtv.org/pinchartl/uvcvideo.git uvcvideo-next

Re: V4L2 and frames vs fields

2014-03-03 Thread Hans Verkuil
On 03/03/2014 09:27 PM, Devin Heitmueller wrote: > Hi Hans, > >> For field formats where both fields are used the spec is reasonably clear. >> The >> v4l2_format height field refers to the full frame height (combining both >> fields). > > No dispute here. > >> For the TOP/BOTTOM/ALTERNATE sett

Re: [PATCH 4/6] android: convert sync to fence api, v4

2014-03-03 Thread Daniel Vetter
On Mon, Feb 17, 2014 at 04:57:19PM +0100, Maarten Lankhorst wrote: > Android syncpoints can be mapped to a timeline. This removes the need > to maintain a separate api for synchronization. I've left the android > trace events in place, but the core fence events should already be > sufficient for de

Re: [PATCH 2/6] seqno-fence: Hardware dma-buf implementation of fencing (v4)

2014-03-03 Thread Daniel Vetter
On Wed, Feb 19, 2014 at 02:25:59PM +0100, Maarten Lankhorst wrote: > op 17-02-14 19:41, Christian König schreef: > >Am 17.02.2014 19:24, schrieb Rob Clark: > >>On Mon, Feb 17, 2014 at 12:36 PM, Christian König > >> wrote: > >>>Am 17.02.2014 18:27, schrieb Rob Clark: > >>> > On Mon, Feb 17, 2014

[PATCHv2 1/2] tda18212: add support for ATSC and clearQAM on tda18272

2014-03-03 Thread Mauro Carvalho Chehab
tda18272 is programmed just like tda18212, but it also supports ClearQAM and ATSC. Add support for them. Tested with a Kworld UB435-Q on both 8VSB and 256QAM modes. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/tuners/tda18212.c | 12 drivers/media/tuners/tda18212.h | 2 +

[PATCHv2 2/2] em28xx: add support for Kworld UB435-Q version 3

2014-03-03 Thread Mauro Carvalho Chehab
This device is close to Kworld UB435-Q, but it uses a different tuner. Add support for it. Tested with both 8VSB and 256QAM modulations. Signed-off-by: Mauro Carvalho Chehab --- Documentation/video4linux/CARDLIST.em28xx | 1 + drivers/media/usb/em28xx/Kconfig | 1 + drivers/media/usb

Re: V4L2 and frames vs fields

2014-03-03 Thread Devin Heitmueller
Hi Hans, > For field formats where both fields are used the spec is reasonably clear. The > v4l2_format height field refers to the full frame height (combining both > fields). No dispute here. > For the TOP/BOTTOM/ALTERNATE setting the format's height refers to that of the > field, not the fram

Re: Driver for KWorld UB435Q Version 3 (ATSC) USB id: 1b80:e34c

2014-03-03 Thread Mauro Carvalho Chehab
Em Fri, 07 Feb 2014 12:23:36 -0600 The Bit Pit escreveu: > Last May I started writing a driver for a KWorld UB435Q Version 3 > tuner. I was able to make the kernel recognize the device, light it's > LED, and try to enable the decoder and tuner. > > I was unable to locate any information for the

[PATCH 4/4] em28xx: add support for Kworld UB435-Q version 3

2014-03-03 Thread Mauro Carvalho Chehab
This device is close to Kworld UB435-Q, but it uses a different tuner. Add support for it. Tested only in 8VSB mode. Signed-off-by: Mauro Carvalho Chehab --- Documentation/video4linux/CARDLIST.em28xx | 1 + drivers/media/usb/em28xx/Kconfig | 1 + drivers/media/usb/em28xx/em28xx-cards

[PATCH 3/4] tda18212: add experimental support for ATSC (tda18272)

2014-03-03 Thread Mauro Carvalho Chehab
Add experimental support for ATSC. Currently, only 8VSB was tested. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/tuners/tda18212.c | 12 drivers/media/tuners/tda18212.h | 2 ++ 2 files changed, 14 insertions(+) diff --git a/drivers/media/tuners/tda18212.c b/drivers/media

[PATCH 2/4] [media] Update CARDLIST.cx23885

2014-03-03 Thread Mauro Carvalho Chehab
Some boards got added there. Update the cardlist to reflect the current status. Signed-off-by: Mauro Carvalho Chehab --- Documentation/video4linux/CARDLIST.cx23885 | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Documentation/video4linux/CARDLIST.cx23885 b/Documentation/

[PATCH 1/4] [media] em28xx: update CARDLIST.em28xx

2014-03-03 Thread Mauro Carvalho Chehab
Some new boards got added. Update the cardlist. Signed-off-by: Mauro Carvalho Chehab --- Documentation/video4linux/CARDLIST.em28xx | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/video4linux/CARDLIST.em28xx b/Documentation/video4linux/CARDLIST.em28xx index 404ac9b5f440..cb

[PATCH] staging/dt3155v4l: use PCI_VENDOR_ID_INTEL

2014-03-03 Thread Jon Mason
Use PCI_VENDOR_ID_INTEL instead of creating its own vendor ID #define. Signed-off-by: Jon Mason Cc: Mauro Carvalho Chehab --- drivers/staging/media/dt3155v4l/dt3155v4l.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/media/dt3155v4l/dt3155v4l.c b/drive

V4L2 and frames vs fields

2014-03-03 Thread Hans Verkuil
Hi all, I've been testing and looking at how V4L2 should handle fields. The spec is awfully vague when it comes to the V4L2_FIELD_TOP/BOTTOM/ALTERNATE field settings, so I'm writing this down as a clarification, also for Devin who asked me about this a few days ago and since I gave him the wron

Re: [PATCH 5/7] v4l: ti-vpe: Allow usage of smaller images

2014-03-03 Thread Archit Taneja
Hi, On Monday 03 March 2014 05:44 PM, Kamil Debski wrote: Hi Archit, From: Archit Taneja [mailto:arc...@ti.com] Sent: Monday, March 03, 2014 8:33 AM The minimum width and height for VPE input/output was kept as 128 pixels. VPE doesn't have a constraint on the image height, it requires the ima

Re: [PATCH 7/7] v4l: ti-vpe: Add crop support in VPE driver

2014-03-03 Thread Archit Taneja
Hi, On Monday 03 March 2014 05:51 PM, Kamil Debski wrote: Hi Archit, From: Archit Taneja [mailto:arc...@ti.com] Sent: Monday, March 03, 2014 9:26 AM Hi, On Monday 03 March 2014 01:20 PM, Hans Verkuil wrote: Hi Archit! On 03/03/2014 08:33 AM, Archit Taneja wrote: Add crop ioctl ops. For VP

RE: [PATCH 7/7] v4l: ti-vpe: Add crop support in VPE driver

2014-03-03 Thread Kamil Debski
Hi Archit, > From: Archit Taneja [mailto:arc...@ti.com] > Sent: Monday, March 03, 2014 9:26 AM > > Hi, > > On Monday 03 March 2014 01:20 PM, Hans Verkuil wrote: > > Hi Archit! > > > > On 03/03/2014 08:33 AM, Archit Taneja wrote: > >> Add crop ioctl ops. For VPE, cropping only makes sense with th

RE: [PATCH 5/7] v4l: ti-vpe: Allow usage of smaller images

2014-03-03 Thread Kamil Debski
Hi Archit, > From: Archit Taneja [mailto:arc...@ti.com] > Sent: Monday, March 03, 2014 8:33 AM > > The minimum width and height for VPE input/output was kept as 128 > pixels. VPE doesn't have a constraint on the image height, it requires > the image width to be atleast 16 bytes. "16 bytes" - sho

Re: [REVIEWv3 PATCH 06/17] vb2: call buf_finish from __queue_cancel.

2014-03-03 Thread Laurent Pinchart
Hi Hans, Thank you for the patch. On Friday 28 February 2014 18:42:04 Hans Verkuil wrote: > From: Hans Verkuil > > If a queue was canceled, then the buf_finish op was never called for the > pending buffers. So add this call to queue_cancel. Before calling buf_finish > set the buffer state to PR

Re: [REVIEWv3 PATCH 05/17] vb2: change result code of buf_finish to void

2014-03-03 Thread Laurent Pinchart
Hi Hans, Thank you for the pathc. On Friday 28 February 2014 18:42:03 Hans Verkuil wrote: > From: Hans Verkuil > > The buf_finish op should always work, so change the return type to void. > Update the few drivers that use it. > > Signed-off-by: Hans Verkuil > Acked-by: Pawel Osciak > Reviewe

[PATCH 23/79] [media] drx-j: a few more CodingStyle fixups

2014-03-03 Thread Mauro Carvalho Chehab
Some whitespace cleanups. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/drx39xyj/drx_driver.c | 2 +- drivers/media/dvb-frontends/drx39xyj/drxj.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/dvb-frontends/drx39xyj/drx_driver.

[PATCH 35/79] [media] drx-j: remove drxj_options.h

2014-03-03 Thread Mauro Carvalho Chehab
This file is empty (actually, all commented there). So, remove it. We should latter remove those macros too, or convert them into a struct to allow dynamically enable the options during device probing time. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/drx39xyj/drxj.c

[PATCH 36/79] [media] drx-j: make checkpatch.pl happy

2014-03-03 Thread Mauro Carvalho Chehab
Fix the remaining checkpatch.pl compliants at drxj. Signed-off-by: Mauro Carvalho Chehab --- .../media/dvb-frontends/drx39xyj/drx_dap_fasi.c| 69 +-- .../media/dvb-frontends/drx39xyj/drx_dap_fasi.h| 9 +- drivers/media/dvb-frontends/drx39xyj/drx_driver.c | 123 ++ drivers/media/d

[PATCH 46/79] [media] drx-j: Allow standard selection

2014-03-03 Thread Mauro Carvalho Chehab
ClearQAM is currently not working. Add support for it too. Unlikely other ATSC tuners, though, this device will not auto-detect between ATSC and ClearQAM. So, the delivery system should be properly set. Also, this frontend seems to also support DVB-C annex A/C. Add experimental support for them.

[PATCH 50/79] [media] drx-j: Avoid any regressions by preserving old behavior

2014-03-03 Thread Mauro Carvalho Chehab
The version is initialized with zero at drx_driver.c. Keep it, in order to avoid the risk of causing any regression. While here, remove the drx_driver.h from drxj, as this is not required there. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/drx39xyj/drxj.c | 9 -

[PATCH 79/79] [media] drx-j: set it to serial mode by default

2014-03-03 Thread Mauro Carvalho Chehab
Currently, there's just one device using this frontend: PCTV 80e, and it works on serial mode. Change the default here to serial mode. If we add more devices, then this option should be set via config structure. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/drx39xyj/drxj.

[PATCH 47/79] [media] drx-j: Some cleanups at drx_driver.c source

2014-03-03 Thread Mauro Carvalho Chehab
This is mostly CodingStyle fixes and improvements. No functional changes. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/drx39xyj/drx39xxj.h | 2 +- drivers/media/dvb-frontends/drx39xyj/drx_driver.c | 269 ++ 2 files changed, 118 insertions(+), 153

[PATCH 54/79] [media] drx-j: move drx39xxj into drxj.c

2014-03-03 Thread Mauro Carvalho Chehab
While drxj is already too big, moving the code there will make easier to get rid of the drxj_ctrl function. It will also help to detect and remove the unused functions, helping to remove lots of dead code there. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/drx39xyj/Makef

[PATCH 77/79] [media] drx-j: disable OOB

2014-03-03 Thread Mauro Carvalho Chehab
Just like the windows driver, disable OOB after setting the driver version. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/drx39xyj/drxj.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/media/dvb-frontends/drx39xyj/drxj.c b/drivers/medi

[PATCH 44/79] [media] drx-j: get rid of its own be??_to_cpu() implementation

2014-03-03 Thread Mauro Carvalho Chehab
Instead of handling endiannes with its own internal way, use the already existing macros. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/drx39xyj/drx_driver.c | 86 +-- 1 file changed, 16 insertions(+), 70 deletions(-) diff --git a/drivers/media/dvb-fro

[PATCH 38/79] [media] drx-j: Fix release and error path on drx39xxj.c

2014-03-03 Thread Mauro Carvalho Chehab
There are memory leaks on both DVB release and dvb attach error path. Fix them. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/drx39xyj/drx39xxj.c | 31 +++-- 1 file changed, 19 insertions(+), 12 deletions(-) diff --git a/drivers/media/dvb-frontends/drx

[PATCH 52/79] [media] drx-j: get rid of drx_ctrl

2014-03-03 Thread Mauro Carvalho Chehab
This function is used only as an abstraction layer to call the two firmware functions. Remove it. As a bonus, the drx_ctrl_function is now unused and can be removed. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/drx39xyj/drx39xxj.c | 24 +-- drivers/media/dvb-frontends

[PATCH 72/79] [media] drx-j: be sure to send the powerup command at device open

2014-03-03 Thread Mauro Carvalho Chehab
As drxj_close puts the device in powerdown, we need to power it up properly at drxj_open. This is the behavior noticed at the Windows driver. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/drx39xyj/drxj.c | 39 + 1 file changed, 23 insertions(+)

[PATCH 39/79] [media] drx-j: Be sure that all allocated data are properly initialized

2014-03-03 Thread Mauro Carvalho Chehab
The state struct is allocated without cleaning the memory. This causes random bugs. Clean it, and move the memcpy functions just below each kalloc, to be clearer that all those data are properly filled. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/drx39xyj/drx39xxj.c | 1

[PATCH 78/79] [media] drx-j: Properly initialize mpeg struct before using it

2014-03-03 Thread Mauro Carvalho Chehab
The cfg_mpeg_output has more fields than what it is initialized when the code is called. Be sure to initialize everything before use, in order to avoid random behaviors. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/drx39xyj/drxj.c | 56 ++--- 1 fil

[PATCH 53/79] [media] drx-j: get rid of the remaining drx generic functions

2014-03-03 Thread Mauro Carvalho Chehab
Get rid of drx_open and drx_close, as those are just wrapper functions to drxj_open/drxj_close. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/drx39xyj/drx39xxj.c | 2 +- drivers/media/dvb-frontends/drx39xyj/drx_driver.h | 25 - drivers/media/dvb-frontends/drx39xyj

[PATCH 05/79] [media] drx-j: Fix CodingStyle

2014-03-03 Thread Mauro Carvalho Chehab
From: Mauro Carvalho Chehab Make checkpatch.pl happy. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/drx39xyj/bsp_i2c.h | 36 +++- drivers/media/dvb-frontends/drx39xyj/drx39xxj.c | 55 + 2 files changed, 35 insertions(+), 56 deletions(

[PATCH 76/79] [media] drx-j: fix boot failure due to null pointer dereference

2014-03-03 Thread Mauro Carvalho Chehab
From: Shuah Khan DJH_DEBUG only code path in drxbsp_i2c_write_read() dereferences w_dev_addr and subsequently w_dev_addr->user_data->i2c which results in failure during boot. This patch fixes the null pointer derefence bug as well as the following compile errors: LD arch/x86/built-in.o

[PATCH 43/79] [media] drx-j: remove unused code from drx_driver.c

2014-03-03 Thread Mauro Carvalho Chehab
There are several drx-j code there that are never used, as they don't even fit into Linux DVB subystem model. Remove them, in order to simplify the code. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/drx39xyj/drx_driver.c | 789 +- drivers/media/dvb-fr

[PATCH 18/79] [media] drx-j: Some minor CodingStyle fixes at headers

2014-03-03 Thread Mauro Carvalho Chehab
No functional changes. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/drx39xyj/bsp_i2c.h | 22 -- drivers/media/dvb-frontends/drx39xyj/bsp_tuner.h | 9 ++--- 2 files changed, 10 insertions(+), 21 deletions(-) diff --git a/drivers/media/dvb-fronte

[PATCH 15/79] [media] drx-j: do more CodingStyle fixes

2014-03-03 Thread Mauro Carvalho Chehab
This time, use checkpatch --strict --fix. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/drx39xyj/drx39xxj.c| 2 +- drivers/media/dvb-frontends/drx39xyj/drx39xxj.h| 2 +- .../media/dvb-frontends/drx39xyj/drx39xxj_dummy.c | 2 +- .../media/dvb-frontends/drx39x

[PATCH 10/79] [media] drx-j: get rid of the bsp*.h headers

2014-03-03 Thread Mauro Carvalho Chehab
From: Mauro Carvalho Chehab Move them into drx_driver.h That makes easier to cleanup further what's there at the headers. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/drx39xyj/bsp_host.h| 78 --- drivers/media/dvb-frontends/drx39xyj/bsp_types.h | 55 -

[PATCH 41/79] [media] drx-j: Split firmware size check from the main routine

2014-03-03 Thread Mauro Carvalho Chehab
The firmware upload routine is already complex enough. Split the first loop that verifies the firmware size into a separate routine, making the code more readable. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/drx39xyj/drx_driver.c | 215 -- 1 file chan

[PATCH 49/79] [media] drx-j: get rid of drx_driver.c

2014-03-03 Thread Mauro Carvalho Chehab
This file contains just the firmware load code, that it is also somewhat duplicated at drxj.c. Move the code into there. Latter patches will remove the duplicated code. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/drx39xyj/Makefile | 2 +- drivers/media/dvb-fronten

[PATCH 75/79] [media] drx-j: remove return that prevents DJH_DEBUG code to run

2014-03-03 Thread Mauro Carvalho Chehab
From: Shuah Khan drxbsp_i2c_write_read() has return that prevents DJH_DEBUG code to run. Remove it. Signed-off-by: Shuah Khan Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/drx39xyj/drxj.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/media/dvb-frontends/d

[PATCH 66/79] [media] drx-j: get rid of function prototypes at drx_dap_fasi.c

2014-03-03 Thread Mauro Carvalho Chehab
Reorder functions and data at drx_dap_fasi.c, in order to avoid having function prototypes. This is in preparation to merge this code inside drxj, removing some duplicated bits there, and getting rid of yet another abstraction layer. Signed-off-by: Mauro Carvalho Chehab --- .../media/dvb-fronte

[PATCH 71/79] [media] drx-j: Use single master mode

2014-03-03 Thread Mauro Carvalho Chehab
There are no other I2C masters here. Also, the Windows driver uses this mode (and both drxd and drxk Kernel drivers). So, switch to it. That helps to compare the logs between the Linux driver and the Windows one. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/drx39xyj/drx_

[PATCH 65/79] [media] drx-j: Get rid of I2C protocol version

2014-03-03 Thread Mauro Carvalho Chehab
This is not used anywere. Get rid of it. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/drx39xyj/drx_dap_fasi.c | 15 --- drivers/media/dvb-frontends/drx39xyj/drx_driver.h | 1 - drivers/media/dvb-frontends/drx39xyj/drxj.c | 15 --- 3 file

[PATCH 68/79] [media] drx-j: get rid of struct drx_dap_fasi_funct_g

2014-03-03 Thread Mauro Carvalho Chehab
This struct contains the first abstraction layer for the I2C access routines. Get rid of it. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/drx39xyj/drxj.c | 45 ++--- 1 file changed, 15 insertions(+), 30 deletions(-) diff --git a/drivers/media/dvb-

[PATCH 74/79] [media] drx-j: fix pr_dbg undefined compile errors when DJH_DEBUG is defined

2014-03-03 Thread Mauro Carvalho Chehab
From: Shuah Khan drxj.c fails to compile with the following errors when DJH_DEBUG is defined. drivers/media/dvb-frontends/drx39xyj/drxj.c:1567:2: error: implicit declaration of function ‘pr_dbg’ [-Werror=implicit-function-declaration] pr_dbg("drx3933 i2c operation addr=%x i2c=%p, wc=%x rc=%x\

[PATCH 32/79] [media] drx-j: Replace printk's by pr_foo()

2014-03-03 Thread Mauro Carvalho Chehab
Instead of using printk's, use the pr_foo() macros. That fixes some checkpatch warnings and provide a better error, warning and debug support. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/drx39xyj/drx39xxj.c| 36 -- .../media/dvb-frontends/drx39xy

[PATCH 70/79] [media] drx-j: Allow userspace control of LNA

2014-03-03 Thread Mauro Carvalho Chehab
Instead of just disabling the LNA every time, allow to control it from userspace. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/drx39xyj/drxj.c | 41 + 1 file changed, 41 insertions(+) diff --git a/drivers/media/dvb-frontends/drx39xyj/drxj.c b

[PATCH 34/79] [media] drx-j: remove typedefs at drx_driver.c

2014-03-03 Thread Mauro Carvalho Chehab
Get rid of another typedef defined on this driver. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/drx39xyj/drx_driver.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/media/dvb-frontends/drx39xyj/drx_driver.c b/drivers/media/dvb-fronte

[PATCH 73/79] [media] drx-j: be sure to do a full software reset

2014-03-03 Thread Mauro Carvalho Chehab
Mimic what windows driver does here: it writes 0x07 to SIO_CC_SOFT_RST__A, instead of just 0x03. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/drx39xyj/drxj.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/media/dvb-frontends/drx39x

[PATCH 33/79] [media] drx-j: get rid of some ugly macros

2014-03-03 Thread Mauro Carvalho Chehab
There are several get/set macros that are bogus: they just call another macro and do either: x = FOO(d) or FOO(d) = x As checkpatch complains about that, and replacing all of them are as easy as running a small coccinelle script, get rid of all of them. Script used: @@ expression

[PATCH 37/79] [media] drx-j: remove the useless microcode_size

2014-03-03 Thread Mauro Carvalho Chehab
This var is not used. Remove it from the code, as we'll now be converting the driver to load the firmware from an external file. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/drx39xyj/drx_driver.h | 4 drivers/media/dvb-frontends/drx39xyj/drxj.c | 10 +++---

[PATCH 63/79] [media] drx-j: remove some unused data

2014-03-03 Thread Mauro Carvalho Chehab
Those struct data aren't used anymore. Get rid of them. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/drx39xyj/drx39xxj.h | 2 -- drivers/media/dvb-frontends/drx39xyj/drxj.c | 3 --- 2 files changed, 5 deletions(-) diff --git a/drivers/media/dvb-frontends/drx39xyj/drx

[PATCH 60/79] [media] drx-j: avoid calling power_down_foo twice

2014-03-03 Thread Mauro Carvalho Chehab
When switching from one video standard to another one, power_down_vsb is called twice. Well, as the device is already in power_down mode, the second call always fail. This causes that any subsequent frontend set to fail as well: [145074.501243] drx39xyj:power_down_vsb: called [145089.195396] drx39

[PATCH 64/79] [media] drx-j: Fix qam/256 mode

2014-03-03 Thread Mauro Carvalho Chehab
QAM/256 currently doesn't work, as the code is only called if channel->mirror is DRX_MIRROR_AUTO, but a prevous if prevents this condition to happen. While here, returns -EINVAL to not supported QAM modes and simplify the code, reducing the number of indents. Signed-off-by: Mauro Carvalho Chehab

[PATCH 62/79] [media] drx-j: use the proper timeout code on scu_command

2014-03-03 Thread Mauro Carvalho Chehab
Checking if a time is after another one can have issues, as times are generally u32 wide. Use the proper macros for that at scu_command(). It should be noticed that other places also use jiffies calculus on an improper way. This should be fixed too, but the logic there is more complex. So, let's

[PATCH 24/79] [media] drx-j: Don't use buffer if an error occurs

2014-03-03 Thread Mauro Carvalho Chehab
drivers/media/dvb-frontends/drx39xyj/drxj.c: In function ‘drxj_dap_scu_atomic_read_reg16’: drivers/media/dvb-frontends/drx39xyj/drxj.c:4170:9: warning: ‘*((void *)&buf+1)’ may be used uninitialized in this function [-Wmaybe-uninitialized] word = (u16) (buf[0] + (buf[1] << 8)); ^ driver

[PATCH 55/79] [media] drx-j: get rid of drxj_ctrl()

2014-03-03 Thread Mauro Carvalho Chehab
With this change, we finally got rid of all abstraction layers on this driver. This patch also fixes the LNA GPIO settings, as the original code were using a wrong control name for it. This patch exposes the several functions that aren't used. Some of them are related to analog demod that might b

[PATCH 29/79] [media] drx-j: Remove typedefs in drxj.c

2014-03-03 Thread Mauro Carvalho Chehab
Remove three typedefs from drxj.c, using the following script: use File::Find; use strict; my $dir = shift or die "need a dir"; my $type = shift or die "need type"; my $var = shift or die "need var"; sub handle_file { my $file = shift; my $out; open IN, $file or die "ca

[PATCH 51/79] [media] drx-j: Remove duplicated firmware upload code

2014-03-03 Thread Mauro Carvalho Chehab
Remove the duplicated firmware upload code that was commented inside drxj.c. This code is not used, and will not work anyway, as it doesn't download the firmware from userspace. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/drx39xyj/drxj.c | 388 --

[PATCH 67/79] [media] drx-j: get rid of drx_dap_fasi.c

2014-03-03 Thread Mauro Carvalho Chehab
This file contains an abstract layer for the I2C transfer functions. Get rid of it, merging it at drxj. This will allow to remove another abstraction layer there, making the code easier to read, and removing the functions that just return -EIO. Signed-off-by: Mauro Carvalho Chehab --- drivers/me

[PATCH 57/79] [media] drx-j: remove some ugly bindings from drx39xxj_dummy.c

2014-03-03 Thread Mauro Carvalho Chehab
This file does an ugly binding between drxj and DVB frontend. Remove most of the functions there. We still need to get rid of get_frequency and set_frequency, but such patch is a little more complex, as it should also remove some previous tuner bindings. Signed-off-by: Mauro Carvalho Chehab ---

[PATCH 42/79] [media] em28xx: add support for PCTV 80e remote controller

2014-03-03 Thread Mauro Carvalho Chehab
This stick uses the same RC-5 remote controll found on other PCTV devices. So, just use the existing keymap. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/usb/em28xx/em28xx-cards.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/usb/em28xx/em28xx-cards.c b/drivers/med

[PATCH 27/79] [media] drx-j: Simplify logic expressions

2014-03-03 Thread Mauro Carvalho Chehab
Don't need to test boolean x == true or x == false. That makes the code more compact. patch generated with make coccicheck and manually reviewed. While here, remove uneeded ';'. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/drx39xyj/drx_driver.c | 22 ++--- drivers/med

[PATCH 58/79] [media] drx-j: get rid of tuner dummy get/set frequency

2014-03-03 Thread Mauro Carvalho Chehab
Those functions will never be used with Linux DVB binding. Get rid of them. Signed-off-by: Mauro Carvalho Chehab --- .../media/dvb-frontends/drx39xyj/drx39xxj_dummy.c | 21 -- drivers/media/dvb-frontends/drx39xyj/drx_driver.h | 3 - drivers/media/dvb-frontends/drx39xyj/drxj.c| 217

[PATCH 59/79] [media] drx-j: be sure to use tuner's IF

2014-03-03 Thread Mauro Carvalho Chehab
Instead of just hardcoding an IF value of 5MHz, use the one provided by the tuner, with can be different for QAM and VSB. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/drx39xyj/drxj.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/

[PATCH 28/79] [media] drx-j: More CamelCase fixups

2014-03-03 Thread Mauro Carvalho Chehab
Signed-off-by: Mauro Carvalho Chehab --- .../media/dvb-frontends/drx39xyj/drx_dap_fasi.c| 6 +- drivers/media/dvb-frontends/drx39xyj/drx_driver.c | 26 ++--- drivers/media/dvb-frontends/drx39xyj/drx_driver.h | 8 +- drivers/media/dvb-frontends/drx39xyj/drxj.c| 126 ++---

[PATCH 20/79] [media] drx-j: Get rid of drx39xyj/bsp_tuner.h

2014-03-03 Thread Mauro Carvalho Chehab
This file is not used anywhere. Drop it. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/drx39xyj/bsp_tuner.h | 204 --- 1 file changed, 204 deletions(-) delete mode 100644 drivers/media/dvb-frontends/drx39xyj/bsp_tuner.h diff --git a/drivers/media/dvb-

[PATCH 56/79] [media] drx-j: comment or remove unused code

2014-03-03 Thread Mauro Carvalho Chehab
In order to avoid warnings and to remove dead code, remove the functions that don't make sense to happen, while commenting the others that might still be useful some day. That reduced a lot the text size: Before: textdata bss dec hex filename 584192916 4 61339

[PATCH 61/79] [media] drx-j: call ctrl_set_standard even if a standard is powered

2014-03-03 Thread Mauro Carvalho Chehab
Modulation and other parameters might have changed. So, better to call ctrl_set_standard() even if the device is already powered. That helps to put the device into a sane state, if something got wrong on a previous set_frontend call. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-fr

[PATCH 00/79] Add support for ATSC PCTV 80e USB stick

2014-03-03 Thread Mauro Carvalho Chehab
This patch series finally merge a long waited driver, for Micronas/Trident DRX-J ATSC frontends. It is based on a previous work from Devin, who made the original port of the Trident driver and got license to ship the firmware. Latter, it got some attention from Patrick that tried to upstream it.

[PATCH 19/79] [media] drx-j: make a few functions static

2014-03-03 Thread Mauro Carvalho Chehab
drivers/media/dvb-frontends/drx39xyj/drx_driver.c:181:7: warning: no previous prototype for 'get_scan_context' [-Wmissing-prototypes] void *get_scan_context(pdrx_demod_instance_t demod, void *scan_context) drivers/media/dvb-frontends/drx39xyj/drx_driver.c: At top level: drivers/media/dvb-fronten

[PATCH 45/79] [media] drx-j: reset the DVB scan configuration at powerup

2014-03-03 Thread Mauro Carvalho Chehab
Without this fixup, the DRX-J will not be properly initialized, loosing several PIDs. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/drx39xyj/drxj.c | 151 +++- 1 file changed, 80 insertions(+), 71 deletions(-) diff --git a/drivers/media/dvb-fronten

[PATCH 07/79] [media] drx-j: remove the "const" annotate on HICommand()

2014-03-03 Thread Mauro Carvalho Chehab
From: Mauro Carvalho Chehab After removing the typedef, it is now clear that HICommand() were abusing of a var that was expecting to be constant: drivers/media/dvb-frontends/drx39xyj/drxj.c: In function ‘HICommand’: drivers/media/dvb-frontends/drx39xyj/drxj.c:2272:3: warning: passing argument 1

[PATCH 12/79] [media] drx-j: fix whitespacing on pointer parmameters

2014-03-03 Thread Mauro Carvalho Chehab
Patch generated with this script: for i in drivers/media/dvb-frontends/drx39xyj/*.[ch]; do perl -ne 's,(enum|struct|void|int|u32|u64|u16|u8|s8|s16|s32|s64)\s+(\S+)\s+\*[ ]+,\1 \2 *,g; print $_' <$i >a && mv a $i; done Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/drx39x

[PATCH 16/79] [media] drx-j: remove the unused tuner_i2c_write_read() function

2014-03-03 Thread Mauro Carvalho Chehab
This function is not static. Also, it is not used anywhere. So, drop it. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/drx39xyj/drxj.c | 16 1 file changed, 16 deletions(-) diff --git a/drivers/media/dvb-frontends/drx39xyj/drxj.c b/drivers/media/dvb-fron

[PATCH 48/79] [media] drx-j: prepend function names with drx_ at drx_driver.c

2014-03-03 Thread Mauro Carvalho Chehab
In order to prepare to get rid of drx_driver.c, prepend all functions there with drx_. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/drx39xyj/drx_driver.c | 28 +++ 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/media/dvb-fronte

[PATCH 17/79] [media] drx-j: Remove a bunch of unused but assigned vars

2014-03-03 Thread Mauro Carvalho Chehab
None of those vars are used on those functions. Just remove them. After this patch, there's just one of such warnings: drivers/media/dvb-frontends/drx39xyj/drxj.c: In function 'ctrl_get_qam_sig_quality': drivers/media/dvb-frontends/drx39xyj/drxj.c:7872:6: warning: variable 'ber_

[PATCH 04/79] [media] drx-j: Fix compilation and un-comment it

2014-03-03 Thread Mauro Carvalho Chehab
From: Mauro Carvalho Chehab There were some DVB internal API changes, since this driver were written. Change it to work with the new API. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/drx39xyj/Kconfig| 1 - drivers/media/dvb-frontends/drx39xyj/Makefile | 3 +++ d

[RFC v7 0/3] add new Dual LED FLASH LM3646

2014-03-03 Thread Daniel Jeong
This patch is to add new dual led flash, lm3646. LM3646 is the product of ti and it has two 1.5A sync. boost converter with dual white current source. 2 files are created and 4 files are modified. And 3 patch files are created and sent. v7 - change log Changed V4L2_FLASH_FAULT_UNDER_VOLT

[RFC v7,2/3] controls.xml : add addtional Flash fault bits

2014-03-03 Thread Daniel Jeong
Descriptions for flash faluts. V4L2_FLASH_FAULT_UNDER_VOLTAGE, V4L2_FLASH_FAULT_INPUT_VOLTAGE, and V4L2_FLASH_FAULT_LED_OVER_TEMPERATURE v7 : Changed V4L2_FLASH_FAULT_UNDER_VOLTAGE description Signed-off-by: Daniel Jeong --- Documentation/DocBook/media/v4l/controls.xml | 18 +++

[RFC v7 1/3] v4l2-controls.h: add addtional Flash fault bits

2014-03-03 Thread Daniel Jeong
Three Flash fault are added. V4L2_FLASH_FAULT_UNDER_VOLTAGE for the case low voltage below the min. limit. V4L2_FLASH_FAULT_INPUT_VOLTAGE for the case falling input voltage and chip adjust flash current not occur under voltage event. V4L2_FLASH_FAULT_LED_OVER_TEMPERATURE for the case the tem

[RFC v7,3/3] media: i2c: add new dual LED Flash driver, lm364

2014-03-03 Thread Daniel Jeong
This patch adds the driver for the LM3646, dual LED Flash driver. The LM3646 has two 1.5A sync. boost converter with dual white current source. It is controlled via an I2C compatible interface. Each flash brightness, torch brightness and enable/disable can be controlled. Under voltage, input volta

[PATCH 4/4] [media] DocBook: document DVB DMX_[ADD|REMOVE]_PID

2014-03-03 Thread Mauro Carvalho Chehab
Those ioctls were added back in 2009, at changeset 1cb662a3144 but were never documented. Fortunately, the original commit is good enough to serve as the basis for documenting it. Also, the support for it is done by dmxdev implementation. So, add a proper documentation for it, based on the descrip

[PATCH 1/4] [media] em28xx_dvb: only call the software filter if data

2014-03-03 Thread Mauro Carvalho Chehab
Several URBs will be simply not filled. Don't call the DVB core software filter for those empty URBs. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/usb/em28xx/em28xx-dvb.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/media/usb/em28xx/em28xx-dvb.c b/drivers/media/usb/

[PATCH 2/4] [media] em28xx: Display the used DVB alternate

2014-03-03 Thread Mauro Carvalho Chehab
Signed-off-by: Mauro Carvalho Chehab --- drivers/media/usb/em28xx/em28xx-dvb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/usb/em28xx/em28xx-dvb.c b/drivers/media/usb/em28xx/em28xx-dvb.c index 301463f463c6..16c4d58a985b 100644 --- a/drivers/media/usb/em2

[PATCH 3/4] [media] dvb_frontend: better handle lna set errors

2014-03-03 Thread Mauro Carvalho Chehab
If an attempt to set LNA fails, restore the cache to LNA_AUTO, in order to make it to reflect the current LNA status. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-core/dvb_frontend.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/dvb-core/dvb_frontend.c b/driv

Re: [RFC v6,3/3] media: i2c: add new dual LED Flash driver, lm364

2014-03-03 Thread Daniel Jeong
2014년 02월 26일 21:56, Sakari Ailus 쓴 글: Hi Daniel, Just a few minor comments. On Wed, Feb 26, 2014 at 04:04:11PM +0900, Daniel Jeong wrote: This patch adds the driver for the LM3646, dual LED Flash driver. The LM3646 has two 1.5A sync. boost converter with dual white current source. It is con

Re: [RFC] [PATCH 4/6] media: em28xx-input - implement em28xx_ops: suspend/resume hooks

2014-03-03 Thread Mauro Carvalho Chehab
Em Sat, 01 Mar 2014 10:48:35 -0300 Mauro Carvalho Chehab escreveu: > Em Fri, 21 Feb 2014 17:50:16 -0700 > Shuah Khan escreveu: > > > Implement em28xx_ops: suspend/resume hooks. em28xx usb driver will > > invoke em28xx_ops: suspend and resume hooks for all its extensions > > from its suspend() a

  1   2   >