No need to check whether unsigned variable is less than 0.
CC: Mauro Carvalho Chehab
CC: linux-media@vger.kernel.org
Signed-off-by: Tushar Behera
---
drivers/media/pci/meye/meye.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/media/pci/meye/meye.c b/drivers/m
Checking '< 0' for unsigned variables always returns false. For error
codes, use IS_ERR_VALUE() instead.
CC: Mauro Carvalho Chehab
CC: linux-media@vger.kernel.org
Signed-off-by: Tushar Behera
---
drivers/media/platform/soc_camera/atmel-isi.c |2 +-
1 files changed, 1 insertions(+), 1 deleti
No need to check whether the unsigned variable is less than 0.
CC: Mauro Carvalho Chehab
CC: linux-media@vger.kernel.org
Signed-off-by: Tushar Behera
---
drivers/media/pci/saa7134/saa7134-video.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/media/pci/saa7134
No need to check whether unsigned variable is less than 0.
CC: Mauro Carvalho Chehab
CC: linux-media@vger.kernel.org
Signed-off-by: Tushar Behera
---
drivers/media/usb/tlg2300/pd-video.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/media/usb/tlg2300/pd-video
No need to check whether unsigned variable is less than 0.
CC: Mauro Carvalho Chehab
CC: ivtv-de...@ivtvdriver.org
CC: linux-media@vger.kernel.org
Signed-off-by: Tushar Behera
---
drivers/media/pci/ivtv/ivtv-ioctl.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drive
The occurrences were identified through the coccinelle script at
following location.
http://www.emn.fr/z-info/coccinelle/rules/find_unsigned.cocci
Signed checks for unsigned variables are removed if it is also checked
for upper error limit. For error checks, IS_ERR_VALUE() macros is used.
Tushar
On 11/16/2012 05:55 AM, Sachin Kamat wrote:
> devm_gpio_request is a device managed function and will make
> error handling and cleanup a bit simpler.
>
> Signed-off-by: Sachin Kamat
Acked-by: Tomasz Stanislawski
> ---
> drivers/media/platform/s5p-tv/sii9234_drv.c |6 +-
> 1 files cha
devm_gpio_request is a device managed function and will make
error handling and cleanup a bit simpler.
Signed-off-by: Sachin Kamat
---
drivers/media/platform/s5p-tv/sii9234_drv.c |6 +-
1 files changed, 1 insertions(+), 5 deletions(-)
diff --git a/drivers/media/platform/s5p-tv/sii9234_d
Hi Wei,
Thanks for the patch.
On Thu, Nov 15, 2012 at 6:48 PM, Wei Yongjun wrote:
> From: Wei Yongjun
>
> In case of error, the function vb2_dma_contig_init_ctx() returns
> ERR_PTR() and never returns NULL. The NULL test in the return value
> check should be replaced with IS_ERR().
>
> dpatch e
Compiling up 3.6.6 for my media box recently I noticed that the EM28XX
DVB driver doesn't auto select all of the appropriate DVB tuner modules
required. In particular I needed DVB_LGDT3305 for my a340, but it looks
like DVB_MT352 + DVB_S5H1409 were missing as well. Patch below adds the
appropriate
On Wed, Nov 14, 2012 at 09:30:14PM +0100, Philippe Valembois - Phil wrote:
> Hello,
> I have posted a bug report here :
> https://bugzilla.kernel.org/show_bug.cgi?id=50361 and I have been told
> to send it to the ML too.
>
> The commit causing the bug has been pushed to kernel between linux-3.5
>
Signed-off-by: Sakari Ailus
---
yavta.c | 12 +++-
1 files changed, 11 insertions(+), 1 deletions(-)
diff --git a/yavta.c b/yavta.c
index bf3e096..a50f11e 100644
--- a/yavta.c
+++ b/yavta.c
@@ -464,6 +464,7 @@ static int video_alloc_buffers(struct device *dev, int
nbufs,
/*
Hi,
This patchset adds timestamp type printing to yavta.
--
Kind regards,
Sakari Ailus
e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info
Hi all,
Here's my first monotonic timestamps patch series. Since the RFC series,
I've corrected a warning in drivers/media/usb/s2255/s2255drv.c that was
caused by an unused variable.
All affected drivers compile without warnings. I've tested this on the OMAP
3 ISP:
02:11:34 sailus@peruna [~]yavt
Set buffer timestamp flags for videobuf, videobuf2 and drivers that use
neither.
Signed-off-by: Sakari Ailus
Acked-by: Laurent Pinchart
---
drivers/media/pci/meye/meye.c |4 ++--
drivers/media/pci/zoran/zoran_driver.c|2 +-
drivers/media/platform/omap3isp/ispqueu
Convert drivers using wall clock time (CLOCK_REALTIME) to timestamp from the
monotonic timer (CLOCK_MONOTONIC).
Signed-off-by: Sakari Ailus
---
drivers/media/common/saa7146/saa7146_fops.c|2 +-
drivers/media/pci/bt8xx/bttv-driver.c |6 +++---
drivers/media/pci/cx2388
v4l2_get_timestamp() produces a monotonic timestamp but unlike
ktime_get_ts(), it uses struct timeval instead of struct timespec, saving
the drivers the conversion job when getting timestamps for v4l2_buffer's
timestamp field.
Signed-off-by: Sakari Ailus
---
drivers/media/v4l2-core/v4l2-common.c
Define video buffer flags for different timestamp types. Everything up to
now have used either realtime clock or monotonic clock, without a way to
tell which clock the timestamp was taken from.
Signed-off-by: Sakari Ailus
Acked-by: Laurent Pinchart
---
Documentation/DocBook/media/v4l/io.xml |
This patch series adds V4L2 driver for Samsung S3C244X/S3C64XX SoCs
camera interface.
Changes since v2:
- use V4L2_CID_TEST_PATTERN instead of a private control,
- added explicit PM_RUNTIME dependency,
- device name appended in bus_info in vidioc_querycap ioctl,
- added image effect controls,
On 2012-10-01 18:56, Anders Thomson wrote:
On 2012-09-23 23:06, Anders Thomson wrote:
> Awfully sorry about this. After having had the familty sit in and check
> the differences,
> I must say that the patch does not fix the issue. This time around I
> have x11grabs with
> ffmpeg to show if y
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date:Thu Nov 15 19:00:23 CET 2012
git hash:2c4e11b7c15af70580625657a154ea7ea70b8c76
gcc version: i686-linux-gcc (GCC
Hi Laurent,
Thanks for the comments.
On Thu, Nov 15, 2012 at 01:46:23AM +0100, Laurent Pinchart wrote:
> On Wednesday 14 November 2012 23:13:45 Sakari Ailus wrote:
> > On Wed, Nov 14, 2012 at 10:23:19AM +0100, Sylwester Nawrocki wrote:
> > > On 11/13/2012 03:24 PM, Sakari Ailus wrote:
> > > > Hi
Hello,
The following patch broke our userspace software builds. While it does
preserve BINARY compatibility, it breaks SOURCE compatibility as the parameter
names have changed. I don't see the rationale for breaking compatibility in
the patch description.
Please consider reverting to t
On Thursday 15 November 2012 18:03:59 Grant Likely wrote:
> On Thu, 15 Nov 2012 17:00:57 +0100, Laurent Pinchart wrote:
> > On Thursday 15 November 2012 15:47:53 Grant Likely wrote:
> > > On Thu, 15 Nov 2012 10:23:52 +0100, Steffen Trumtrar wrote:
> > > > Add display_timing structure and the accord
On 1 Oct 2012, at 10:09, Hans Verkuil wrote:
> On Sun September 30 2012 14:51:36 David Röthlisberger wrote:
>> I am using the Hauppauge HD PVR video-capture device with a GStreamer
>> "v4l2src". The HD PVR has an upstream driver called "hdpvr":
>> http://git.kernel.org/?p=linux/kernel/git/stable/li
On Thu, 15 Nov 2012 17:00:57 +0100, Laurent Pinchart
wrote:
> Hi Grant,
>
> On Thursday 15 November 2012 15:47:53 Grant Likely wrote:
> > On Thu, 15 Nov 2012 10:23:52 +0100, Steffen Trumtrar wrote:
> > > Add display_timing structure and the according helper functions. This
> > > allows the descr
Support both grayscale (Y8) and Bayer (SBGGR8, SGBRG8, SGRBG8 and
SRGGB8) formats.
Signed-off-by: Laurent Pinchart
Acked-by: Sakari Ailus
---
drivers/media/platform/omap3isp/isppreview.c | 41 +
1 files changed, 28 insertions(+), 13 deletions(-)
Changes since v2:
- S
Hi Mauro,
Once again, please cancel this pull request. One of the patches contains a
subtle bug, I'll resubmit it. Sorry for the inconvenience.
On Tuesday 13 November 2012 15:35:20 Laurent Pinchart wrote:
> Hi Mauro,
>
> The following changes since commit 01aea0bfd8dfa8bc868df33904461984bb10a87
Am 15.11.2012 17:35, schrieb Devin Heitmueller:
> On Thu, Nov 15, 2012 at 11:31 AM, Frank Schäfer
> wrote:
>> Hmm... I've made some experiments to find out what gcc does on x86 and
>> it seems to ignore bit shifting > 32.
>> I also noticed that this line has been removed in 3.7-rc.
>> So we do NOT
On Thu, Nov 15, 2012 at 11:31 AM, Frank Schäfer
wrote:
> Hmm... I've made some experiments to find out what gcc does on x86 and
> it seems to ignore bit shifting > 32.
> I also noticed that this line has been removed in 3.7-rc.
> So we do NOT want to halve the height for interlaced devices here, r
Am 14.11.2012 18:05, schrieb Devin Heitmueller:
> On Wed, Nov 14, 2012 at 11:58 AM, Frank Schäfer
> wrote:
>> This looks indeed like a bug.
>> a >>= b means a = a >> b, which in this case means shifting height 480
>> or 576 bits to the right...
>> height >> 1 means height /= 2 which seems to be sa
Hi Grant,
On Thursday 15 November 2012 15:47:53 Grant Likely wrote:
> On Thu, 15 Nov 2012 10:23:52 +0100, Steffen Trumtrar wrote:
> > Add display_timing structure and the according helper functions. This
> > allows the description of a display via its supported timing parameters.
> >
> > Every ti
On Thu, 15 Nov 2012 10:23:52 +0100, Steffen Trumtrar
wrote:
> Add display_timing structure and the according helper functions. This allows
> the description of a display via its supported timing parameters.
>
> Every timing parameter can be specified as a single value or a range
> .
>
> Also, a
From: Wei Yongjun
In case of error, the function vb2_dma_contig_init_ctx() returns
ERR_PTR() and never returns NULL. The NULL test in the return value
check should be replaced with IS_ERR().
dpatch engine is used to auto generate this patch.
(https://github.com/weiyj/dpatch)
Signed-off-by: Wei
This adds support for reading display timings from DT or/and convert one of
those
timings to a videomode.
The of_display_timing implementation supports multiple children where each
property can have up to 3 values. All children are read into an array, that
can be queried.
of_get_videomode converts
Add helper to get fb_videomode from devicetree.
Signed-off-by: Steffen Trumtrar
Reviewed-by: Thierry Reding
Acked-by: Thierry Reding
Tested-by: Thierry Reding
Tested-by: Philipp Zabel
---
drivers/video/fbmon.c | 42 +-
include/linux/fb.h|6 ++
Add helper to get drm_display_mode from devicetree.
Signed-off-by: Steffen Trumtrar
Reviewed-by: Thierry Reding
Acked-by: Thierry Reding
Tested-by: Thierry Reding
Tested-by: Philipp Zabel
---
drivers/gpu/drm/drm_modes.c | 35 ++-
include/drm/drmP.h
Hi!
Changes since v10:
- fix function name (drm_)display_mode_from_videomode
- add acked-by, reviewed-by, tested-by
Regards,
Steffen
Steffen Trumtrar (6):
video: add display_timing and videomode
video: add of helper for videomode
fbmon: add videomode helpers
fbmon: add o
Add display_timing structure and the according helper functions. This allows
the description of a display via its supported timing parameters.
Every timing parameter can be specified as a single value or a range
.
Also, add helper functions to convert from display timings to a generic
videomode
Add conversion from videomode to drm_display_mode
Signed-off-by: Steffen Trumtrar
Reviewed-by: Thierry Reding
Acked-by: Thierry Reding
Tested-by: Thierry Reding
Tested-by: Philipp Zabel
---
drivers/gpu/drm/drm_modes.c | 37 +
include/drm/drmP.h
Add a function to convert from the generic videomode to a fb_videomode.
Signed-off-by: Steffen Trumtrar
Reviewed-by: Thierry Reding
Acked-by: Thierry Reding
Tested-by: Thierry Reding
Tested-by: Philipp Zabel
---
drivers/video/fbmon.c | 46 ++
inc
On Thu, Nov 15, 2012 at 11:24:11AM +0100, Thierry Reding wrote:
> On Thu, Nov 15, 2012 at 10:23:51AM +0100, Steffen Trumtrar wrote:
> > Hi!
> >
> > Changes since v9:
> > - don't leak memory when previous timings were correct
> > - CodingStyle fixes
> > - move blank lines around
> >
>
On Thu, Nov 15, 2012 at 11:24:11AM +0100, Thierry Reding wrote:
> On Thu, Nov 15, 2012 at 10:23:51AM +0100, Steffen Trumtrar wrote:
> > Hi!
> >
> > Changes since v9:
> > - don't leak memory when previous timings were correct
> > - CodingStyle fixes
> > - move blank lines around
> >
>
On Thu, Nov 15, 2012 at 10:23:51AM +0100, Steffen Trumtrar wrote:
> Hi!
>
> Changes since v9:
> - don't leak memory when previous timings were correct
> - CodingStyle fixes
> - move blank lines around
>
> Regards,
> Steffen
>
>
> Steffen Trumtrar (6):
> video: add display_ti
On Thu, Nov 15, 2012 at 10:58:49AM +0100, Thierry Reding wrote:
> On Thu, Nov 15, 2012 at 10:23:57AM +0100, Steffen Trumtrar wrote:
> [...]
> > +int of_get_drm_display_mode(struct device_node *np,
> > + struct drm_display_mode *dmode, unsigned int index)
> > +{
> > + struct
On Thu, Nov 15, 2012 at 10:23:57AM +0100, Steffen Trumtrar wrote:
[...]
> +int of_get_drm_display_mode(struct device_node *np,
> + struct drm_display_mode *dmode, unsigned int index)
> +{
> + struct videomode vm;
> + int ret;
> +
> + ret = of_get_videomode(np, &v
Hi!
Changes since v9:
- don't leak memory when previous timings were correct
- CodingStyle fixes
- move blank lines around
Regards,
Steffen
Steffen Trumtrar (6):
video: add display_timing and videomode
video: add of helper for videomode
fbmon: add videomode helpers
Add a function to convert from the generic videomode to a fb_videomode.
Signed-off-by: Steffen Trumtrar
---
drivers/video/fbmon.c | 46 ++
include/linux/fb.h|6 ++
2 files changed, 52 insertions(+)
diff --git a/drivers/video/fbmon.c b/dr
Add helper to get drm_display_mode from devicetree.
Signed-off-by: Steffen Trumtrar
---
drivers/gpu/drm/drm_modes.c | 35 ++-
include/drm/drmP.h |6 ++
2 files changed, 40 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_modes.c b/
Add display_timing structure and the according helper functions. This allows
the description of a display via its supported timing parameters.
Every timing parameter can be specified as a single value or a range
.
Also, add helper functions to convert from display timings to a generic
videomode
This adds support for reading display timings from DT or/and convert one of
those
timings to a videomode.
The of_display_timing implementation supports multiple children where each
property can have up to 3 values. All children are read into an array, that
can be queried.
of_get_videomode converts
Add helper to get fb_videomode from devicetree.
Signed-off-by: Steffen Trumtrar
---
drivers/video/fbmon.c | 42 +-
include/linux/fb.h|6 ++
2 files changed, 47 insertions(+), 1 deletion(-)
diff --git a/drivers/video/fbmon.c b/drivers/video/f
Add conversion from videomode to drm_display_mode
Signed-off-by: Steffen Trumtrar
---
drivers/gpu/drm/drm_modes.c | 37 +
include/drm/drmP.h |6 ++
2 files changed, 43 insertions(+)
diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm
53 matches
Mail list logo
