[PATCH] Staging: media: solo6x10: core.c Fix some coding style issue

2012-03-09 Thread Andrew Miller
Replaced spaces with tabs Signed-off-by: Andrew Miller --- drivers/staging/media/solo6x10/core.c | 32 1 files changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/staging/media/solo6x10/core.c b/drivers/staging/media/solo6x10/core.c index f974f64.

Re: [PATCH v5 1/1] v4l: Add driver for Micron MT9M032 camera sensor

2012-03-09 Thread Sylwester Nawrocki
Hi Laurent, I have a few minor comments, if you don't mind. :) On 03/09/2012 09:21 PM, Laurent Pinchart wrote: > From: Martin Hostettler > > The MT9M032 is a parallel 1.6MP sensor from Micron controlled through I2C. > > The driver creates a V4L2 subdevice. It currently supports cropping, gain,

Re: [PATCH 3/3] wl128x: Add sysfs based support for FM features

2012-03-09 Thread halli manjunatha
On Fri, Mar 9, 2012 at 2:29 AM, Hans Verkuil wrote: > On Wednesday, March 07, 2012 22:42:05 halli manjunatha wrote: >> On Mon, Mar 5, 2012 at 10:24 AM, halli manjunatha >> wrote: >> > On Fri, Mar 2, 2012 at 3:22 AM, Hans Verkuil wrote: >> >> On Wednesday, February 29, 2012 18:19:27 halli manjun

[PATCH] media_build: add module_driver and module_i2c_driver macros to compat.h

2012-03-09 Thread Gianluca Gennari
This patch eliminates a lot of warnings like this on old kernels: media_build/v4l/au8522_decoder.c:842: warning: data definition has no type or storage class media_build/v4l/au8522_decoder.c:842: warning: type defaults to 'int' in declaration of 'module_i2c_driver' media_build/v4l/au8522_decoder

Re: [PATCH v5.3 25/35] omap3isp: Collect entities that are part of the pipeline

2012-03-09 Thread Laurent Pinchart
Hi Sakari, Thanks for the patch. On Friday 09 March 2012 22:31:25 Sakari Ailus wrote: > Collect entities which are part of the pipeline into a single bit mask. > > Signed-off-by: Sakari Ailus Acked-by: Laurent Pinchart -- Regards, Laurent Pinchart -- To unsubscribe from this list: send th

[PATCH v5.3 25/35] omap3isp: Collect entities that are part of the pipeline

2012-03-09 Thread Sakari Ailus
Collect entities which are part of the pipeline into a single bit mask. Signed-off-by: Sakari Ailus --- since last version: - state is set in isp_video_streamon() rather than isp_video_get_graph_data(). - Get information from all entities which was broken by the previous version. drivers/m

[PATCH v5 1/1] v4l: Add driver for Micron MT9M032 camera sensor

2012-03-09 Thread Laurent Pinchart
From: Martin Hostettler The MT9M032 is a parallel 1.6MP sensor from Micron controlled through I2C. The driver creates a V4L2 subdevice. It currently supports cropping, gain, exposure and v/h flipping controls in monochrome mode with an external pixel clock. Signed-off-by: Martin Hostettler [Lo

Re: [PATCH v4 5/5] v4l: Add driver for Micron MT9M032 camera sensor

2012-03-09 Thread Laurent Pinchart
Hi Sakari, On Friday 09 March 2012 21:15:28 Sakari Ailus wrote: > Hi Laurent, > > Thanks for the patch. Just a few minor comments below. Thanks for the review. > Laurent Pinchart wrote: > ... > > > +static int mt9m032_setup_pll(struct mt9m032 *sensor) > > +{ > > + static const struct aptina_

Re: [PATCH v4 5/5] v4l: Add driver for Micron MT9M032 camera sensor

2012-03-09 Thread Sakari Ailus
Hi Laurent, Thanks for the patch. Just a few minor comments below. Laurent Pinchart wrote: ... > +static int mt9m032_setup_pll(struct mt9m032 *sensor) > +{ > + static const struct aptina_pll_limits limits = { > + .ext_clock_min = 800, > + .ext_clock_max = 1650,

cron job: media_tree daily build: ERRORS

2012-03-09 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date:Fri Mar 9 19:00:19 CET 2012 git hash:632fba4d012458fd5fedc678fb9b0f8bc59ceda2 gcc version: i686-linux-gcc (GCC

[PATCH 25/35] omap3isp: Collect entities that are part of the pipeline

2012-03-09 Thread Sakari Ailus
Collect entities which are part of the pipeline into a single bit mask. Signed-off-by: Sakari Ailus --- drivers/media/video/omap3isp/ispvideo.c | 61 +-- drivers/media/video/omap3isp/ispvideo.h |2 + 2 files changed, 35 insertions(+), 28 deletions(-) diff --git

Re: Lockup on second streamon with omap3-isp

2012-03-09 Thread jean-philippe francois
>> Thank you, I will try this and keep you posted. >> With this sensor it is possible, but that is not the case for every >> sensor out there. >> Is this an ISP bug ? > > From my experience, the ISP doesn't handle free-running sensors very well. > There are other things it doesn't handle well, such

[PATCH v4 5/5] v4l: Add driver for Micron MT9M032 camera sensor

2012-03-09 Thread Laurent Pinchart
From: Martin Hostettler The MT9M032 is a parallel 1.6MP sensor from Micron controlled through I2C. The driver creates a V4L2 subdevice. It currently supports cropping, gain, exposure and v/h flipping controls in monochrome mode with an external pixel clock. Signed-off-by: Martin Hostettler [Lo

[PATCH v4 2/5] mt9p031: Remove unused xskip and yskip fields in struct mt9p031

2012-03-09 Thread Laurent Pinchart
The fields are set but never used, remove them. Signed-off-by: Laurent Pinchart Reviewed-by: Sakari Ailus --- drivers/media/video/mt9p031.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/media/video/mt9p031.c b/drivers/media/video/mt9p031.c index dd937df..52

[PATCH v4 3/5] v4l: Aptina-style sensor PLL support

2012-03-09 Thread Laurent Pinchart
Add a generic helper function to compute PLL parameters for PLL found in several Aptina sensors. Signed-off-by: Laurent Pinchart Acked-by: Sakari Ailus --- drivers/media/video/Kconfig |3 + drivers/media/video/Makefile |4 + drivers/media/video/aptina-pll.c | 174 +

[PATCH v4 4/5] mt9p031: Use generic PLL setup code

2012-03-09 Thread Laurent Pinchart
Compute the PLL parameters at runtime using the generic Aptina PLL helper. Signed-off-by: Laurent Pinchart Acked-by: Sakari Ailus --- drivers/media/video/Kconfig |1 + drivers/media/video/mt9p031.c | 62 ++--- 2 files changed, 28 insertions(+), 35 del

[PATCH v4 1/5] mt9p031: Remove duplicate media/v4l2-subdev.h include

2012-03-09 Thread Laurent Pinchart
From: Danny Kukawka drivers/media/video/mt9p031.c included 'media/v4l2-subdev.h' twice, remove the duplicate. Signed-off-by: Danny Kukawka Acked-by: Laurent Pinchart --- drivers/media/video/mt9p031.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/

[PATCH v4 0/5] MT9M032 and MT9P031 sensor patches

2012-03-09 Thread Laurent Pinchart
Here's the fourth version of the MT9M032 and MT9P031 sensor patches for v3.4. Compared to v3, only patch 5/5 has been changed. I've added locking to the driver, removed the memset to 0 for the reserved fields in the frame interval set handler, fixed a typo in a kernel log message and moved the dri

Re: [PATCH] fix backport patch v2.6.32_kfifo

2012-03-09 Thread Mauro Carvalho Chehab
Em 09-03-2012 09:26, Gianluca Gennari escreveu: > Sorry, I forgot the [media_build] tag. > This patch is required to fix compilation of the media_build tree on my > Ubuntu 10.04 system with kernel 2.6.32. Both patches applied, thanks! Mauro. > > Regards, > Gianluca -- To unsubscribe from this l

Re: Lockup on second streamon with omap3-isp

2012-03-09 Thread Michael Jones
Hi Laurent, On 03/09/2012 11:42 AM, Laurent Pinchart wrote: Hi Jean-Philippe, [snip] From my experience, the ISP doesn't handle free-running sensors very well. There are other things it doesn't handle well, such as sensors stopping in the middle of the frame. I would consider this as limitat

Re: Lockup on second streamon with omap3-isp

2012-03-09 Thread Laurent Pinchart
Hi Michael, On Friday 09 March 2012 13:54:31 Michael Jones wrote: > On 03/09/2012 11:42 AM, Laurent Pinchart wrote: > > Hi Jean-Philippe, > > [snip] > > > From my experience, the ISP doesn't handle free-running sensors very > > well. > > > > There are other things it doesn't handle well, such

[PATCH] s5p-csis: Fix compilation with PM_SLEEP disabled

2012-03-09 Thread Sylwester Nawrocki
Fix following compilation error when CONFIG_PM_SLEEP is disabled: CC drivers/media/video/s5p-fimc/mipi-csis.o drivers/media/video/s5p-fimc/mipi-csis.c: In function ‘s5pcsis_remove’: drivers/media/video/s5p-fimc/mipi-csis.c:956: error: implicit declaration of function ‘s5pcsis_suspend’ Rep

Re: [PATCH] fix backport patch v2.6.32_kfifo

2012-03-09 Thread Gianluca Gennari
Sorry, I forgot the [media_build] tag. This patch is required to fix compilation of the media_build tree on my Ubuntu 10.04 system with kernel 2.6.32. Regards, Gianluca -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org M

Re: [PATCH] disable IR_GPIO_CIR module for kernels older than 2.6.35

2012-03-09 Thread Gianluca Gennari
Sorry, I forgot the [media_build] tag. This patch is required to fix compilation of the media_buid tree on my Ubuntu 10.04 system with kernel 2.6.32. Regards, Gianluca -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org Mo

Re: [PATCH v3 5/5] v4l: Add driver for Micron MT9M032 camera sensor

2012-03-09 Thread Laurent Pinchart
Hi Sakari, On Thursday 08 March 2012 19:17:46 Sakari Ailus wrote: > On Wed, Mar 07, 2012 at 12:31:34PM +0100, Laurent Pinchart wrote: [snip] > > > > +static int mt9m032_set_frame_interval(struct v4l2_subdev *subdev, > > > > + struct v4l2_subdev_frame_interval

[PATCH] disable IR_GPIO_CIR module for kernels older than 2.6.35

2012-03-09 Thread Gianluca Gennari
The new module introduced with this patch: http://patchwork.linuxtv.org/patch/10083/ requires request_any_context_irq() first introduced in 2.6.35 Signed-off-by: Gianluca Gennari --- v4l/versions.txt |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/v4l/versions.txt b/v

[PATCH] fix backport patch v2.6.32_kfifo

2012-03-09 Thread Gianluca Gennari
The backport patch v2.6.32_kfifo-patch collides with: http://patchwork.linuxtv.org/patch/9914/ Moreover, struct kfifo_rec_ptr_1 is not defined in 2.6.32, so we have to stay with the old buggy implementation. Signed-off-by: Gianluca Gennari --- backports/v2.6.32_kfifo.patch |2 +- 1 files ch

[PATCH] video: Kconfig: Select VIDEOBUF2_DMA_CONTIG for VIDEO_MX2

2012-03-09 Thread Fabio Estevam
Fix the following build error: LD .tmp_vmlinux1 drivers/built-in.o: In function `mx2_camera_init_videobuf': clkdev.c:(.text+0xcfaf4): undefined reference to `vb2_dma_contig_memops' drivers/built-in.o: In function `mx2_camera_probe': clkdev.c:(.devinit.text+0x5734): undefined reference to `vb

[PATCH] omap_vout: Fix the build warning and section miss-match warning

2012-03-09 Thread Vaibhav Hiremath
Patch fixes below build warning and section miss-match warning from omap_vout driver - Build warnings: = drivers/media/video/omap/omap_vout.c: In function 'omapvid_setup_overlay': drivers/media/video/omap/omap_vout.c:381:17: warning: 'mode' may be used uninitialized in this function

[PATCH] omap_vout: Fix "DMA transaction error" issue when rotation is enabled

2012-03-09 Thread Vaibhav Hiremath
When rotation is enabled and driver is configured in USERPTR buffer exchange mechanism, in specific use-case driver reports an error, "DMA transaction error with device 0". In driver _buffer_prepare funtion, we were using "vout->buf_phy_addr[vb->i]" for buffer physical address to configure SDMA

[PATCH] V4L: Improve the selection API documentation

2012-03-09 Thread Sylwester Nawrocki
Make the VIDIOC_G/S_SELECTION ioctls documentation more consistent with the rest of media Docbook, use capital letters where necessary and correct few minor errors. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- Documentation/DocBook/media/v4l/selection-api.xml |8 +- .

Re: Lockup on second streamon with omap3-isp

2012-03-09 Thread Laurent Pinchart
Hi Jean-Philippe, On Friday 09 March 2012 08:30:10 jean-philippe francois wrote: > Le 9 mars 2012 00:28, Laurent Pinchart a écrit : > > On Thursday 08 March 2012 19:22:53 Sakari Ailus wrote: > >> On Wed, Mar 07, 2012 at 03:24:29PM +0100, jean-philippe francois wrote: > >> > Le 6 mars 2012 18:08, j

Re: [PATCH 3/3] wl128x: Add sysfs based support for FM features

2012-03-09 Thread Hans Verkuil
On Wednesday, March 07, 2012 22:42:05 halli manjunatha wrote: > On Mon, Mar 5, 2012 at 10:24 AM, halli manjunatha > wrote: > > On Fri, Mar 2, 2012 at 3:22 AM, Hans Verkuil wrote: > >> On Wednesday, February 29, 2012 18:19:27 halli manjunatha wrote: > >>> On Wed, Feb 29, 2012 at 5:25 AM, Hans Ver

RE: [PATCH] omap_vout: Set DSS overlay_info only if paddr is non zero

2012-03-09 Thread Hiremath, Vaibhav
On Fri, Mar 09, 2012 at 05:17:41, Laurent Pinchart wrote: > Hi Archit, > > On Wednesday 07 March 2012 14:31:16 Archit Taneja wrote: > > The omap_vout driver tries to set the DSS overlay_info using > > set_overlay_info() when the physical address for the overlay is still not > > configured. This ha