Re: [PATCH] v4l2: v4l2-fh: v4l2_fh_is_singular should use list head to test

2012-01-04 Thread Sakari Ailus
On Thu, Jan 05, 2012 at 10:52:02AM +0800, Scott Jiang wrote: > 2012/1/4 Sakari Ailus : > > Hi Scott, > > > > Thanks for the patch. > > > > On Wed, Dec 21, 2011 at 10:30:54AM -0500, Scott Jiang wrote: > >> list_is_singular accepts a list head to test whether a list has just one > >> entry. > >> fh-

[patch -longterm v2] V4L/DVB: v4l2-ioctl: integer overflow in video_usercopy()

2012-01-04 Thread Dan Carpenter
If p->count is too high the multiplication could overflow and array_size would be lower than expected. Mauro and Hans Verkuil suggested that we cap it at 1024. That comes from the maximum number of controls with lots of room for expantion. $ grep V4L2_CID include/linux/videodev2.h | wc -l 211 S

[patch -next] V4L/DVB: v4l2-ioctl: integer overflow in video_usercopy()

2012-01-04 Thread Dan Carpenter
If ctrls->count is too high the multiplication could overflow and array_size would be lower than expected. Mauro and Hans Verkuil suggested that we cap it at 1024. That comes from the maximum number of controls with lots of room for expantion. $ grep V4L2_CID include/linux/videodev2.h | wc -l 21

[patch] [media] saa7134: use correct array offset

2012-01-04 Thread Dan Carpenter
Smatch complains that i can be one passed the end of the array if we don't hit the break statement. We should be using the "audio" here like we do in the other places. Signed-off-by: Dan Carpenter --- Compile tested only. Please review carefully. diff --git a/drivers/media/video/saa7134/saa713

linux-media@vger.kernel.org

2012-01-04 Thread Dan Carpenter
This is just a cleanup, it doesn't change how the code works. These are compound conditions and not bitwise operations so it should be && and not &. Signed-off-by: Dan Carpenter diff --git a/drivers/media/dvb/frontends/af9013.c b/drivers/media/dvb/frontends/af9013.c index e6ba3e0..1413c51 1006

Fwd: updated DVB-T frequencies for Italy

2012-01-04 Thread Mark Purcell
-- Forwarded Message -- Subject: updated DVB-T frequencies for Italy Date: Sun, 13 Feb 2011, 07:26:43 From: "Marco d'Itri" To: Debian Bug Tracking System CC: debian-ital...@lists.debian.org Package: dvb-apps Version: 1.1.1+rev1355-1 Severity: normal Tags: patch In Italy ther

Re: subdev support for querying struct v4l2_input *

2012-01-04 Thread Scott Jiang
2012/1/5 Steven Toth : > Hans, > > In the cx23885 driver as part of vidioc_enum_input call, I have a need > to return V4L2_IN_ST_NO_SIGNAL in the status > field as part of struct v4l2_input. Thus, when no signal is detected > by the video decoder it can be signalled to the calling application. > v4

Re: [PATCH] v4l2: v4l2-fh: v4l2_fh_is_singular should use list head to test

2012-01-04 Thread Scott Jiang
2012/1/4 Sakari Ailus : > Hi Scott, > > Thanks for the patch. > > On Wed, Dec 21, 2011 at 10:30:54AM -0500, Scott Jiang wrote: >> list_is_singular accepts a list head to test whether a list has just one >> entry. >> fh->list is the entry, fh->vdev->fh_list is the list head. >> >> Signed-off-by: Sc

[PATCH] [media] Don't test for ops->info.type inside drivers

2012-01-04 Thread Mauro Carvalho Chehab
Now, ops->info.type is handled inside the dvb_frontend core, only for DVBv3 calls, and according with the delivery system. So, drivers should not care or use it, otherwise, it may have issues with DVBv5 calls. The drivers that were still using it were detected via this small temporary hack: --- a

[PATCH 17/47] [media] mt2063: Remove the code for more than one adjacent mt2063 tuners

2012-01-04 Thread Mauro Carvalho Chehab
Such code is disabled via ifdef's. Also, they're ugly and rely on some static structures. Just remove. If ever needed, the git log can be used to recover it. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/common/tuners/mt2063.c | 328 +- 1 files changed,

[PATCH 19/47] [media] mt2063: Simplify some functions

2012-01-04 Thread Mauro Carvalho Chehab
Signed-off-by: Mauro Carvalho Chehab --- drivers/media/common/tuners/mt2063.c | 150 +++--- 1 files changed, 12 insertions(+), 138 deletions(-) diff --git a/drivers/media/common/tuners/mt2063.c b/drivers/media/common/tuners/mt2063.c index 0ae6c15..1011635 100644 ---

[PATCH 18/47] [media] mt2063: Rewrite read/write logic at the driver

2012-01-04 Thread Mauro Carvalho Chehab
Signed-off-by: Mauro Carvalho Chehab --- drivers/media/common/tuners/mt2063.c | 262 ++ 1 files changed, 73 insertions(+), 189 deletions(-) diff --git a/drivers/media/common/tuners/mt2063.c b/drivers/media/common/tuners/mt2063.c index 534e970..0ae6c15 100644 ---

[PATCH 21/47] [media] mt2063: Don't violate the DVB API

2012-01-04 Thread Mauro Carvalho Chehab
Signed-off-by: Mauro Carvalho Chehab --- drivers/media/common/tuners/mt2063.c | 51 ++ 1 files changed, 9 insertions(+), 42 deletions(-) diff --git a/drivers/media/common/tuners/mt2063.c b/drivers/media/common/tuners/mt2063.c index c5e95dd..6c73bfd 100644 --- a

[PATCH 11/47] [media] mt2063: Move data structures to the driver

2012-01-04 Thread Mauro Carvalho Chehab
Signed-off-by: Mauro Carvalho Chehab --- drivers/media/common/tuners/mt2063.c | 529 +- drivers/media/common/tuners/mt2063.h | 526 - 2 files changed, 528 insertions(+), 527 deletions(-) diff --git a/drivers/media/common/tuners/mt

[PATCH 23/47] [media] mt2063: Remove several unused parameters

2012-01-04 Thread Mauro Carvalho Chehab
Signed-off-by: Mauro Carvalho Chehab --- drivers/media/common/tuners/mt2063.c | 364 +- 1 files changed, 2 insertions(+), 362 deletions(-) diff --git a/drivers/media/common/tuners/mt2063.c b/drivers/media/common/tuners/mt2063.c index 8662007..a43a859 100644 ---

[PATCH 24/47] [media] mt2063: simplify lockstatus logic

2012-01-04 Thread Mauro Carvalho Chehab
Signed-off-by: Mauro Carvalho Chehab --- drivers/media/common/tuners/mt2063.c | 137 +++--- 1 files changed, 43 insertions(+), 94 deletions(-) diff --git a/drivers/media/common/tuners/mt2063.c b/drivers/media/common/tuners/mt2063.c index a43a859..3c0b3f1 100644 ---

[PATCH 26/47] [media] mt2063: Rework on the publicly-exported functions

2012-01-04 Thread Mauro Carvalho Chehab
Signed-off-by: Mauro Carvalho Chehab --- drivers/media/common/tuners/mt2063.c | 44 ++ drivers/media/common/tuners/mt2063.h |2 +- 2 files changed, 14 insertions(+), 32 deletions(-) diff --git a/drivers/media/common/tuners/mt2063.c b/drivers/media/common/tu

[PATCH 25/47] [media] mt2063: Simplify mt2063_setTune logic

2012-01-04 Thread Mauro Carvalho Chehab
Signed-off-by: Mauro Carvalho Chehab --- drivers/media/common/tuners/mt2063.c | 37 ++--- 1 files changed, 3 insertions(+), 34 deletions(-) diff --git a/drivers/media/common/tuners/mt2063.c b/drivers/media/common/tuners/mt2063.c index 3c0b3f1..53e3960 100644 --- a/

[PATCH 29/47] [media] mt2063: Cleanup some function prototypes

2012-01-04 Thread Mauro Carvalho Chehab
No functional changes here. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/common/tuners/mt2063.c | 44 - 1 files changed, 16 insertions(+), 28 deletions(-) diff --git a/drivers/media/common/tuners/mt2063.c b/drivers/media/common/tuners/mt2063.c index

[PATCH 22/47] [media] mt2063: Use linux default max function

2012-01-04 Thread Mauro Carvalho Chehab
Signed-off-by: Mauro Carvalho Chehab --- drivers/media/common/tuners/mt2063.c | 34 +++--- 1 files changed, 3 insertions(+), 31 deletions(-) diff --git a/drivers/media/common/tuners/mt2063.c b/drivers/media/common/tuners/mt2063.c index 6c73bfd..8662007 100644 --- a

[PATCH 30/47] [media] mt2063: make checkpatch.pl happy

2012-01-04 Thread Mauro Carvalho Chehab
Fix everything but 80 columns and two msleep warnings Signed-off-by: Mauro Carvalho Chehab --- drivers/media/common/tuners/mt2063.c | 129 +- 1 files changed, 48 insertions(+), 81 deletions(-) diff --git a/drivers/media/common/tuners/mt2063.c b/drivers/media/co

[PATCH 34/47] [media] mt2063: Properly document the author of the original driver

2012-01-04 Thread Mauro Carvalho Chehab
Signed-off-by: Mauro Carvalho Chehab --- drivers/media/common/tuners/mt2063.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/media/common/tuners/mt2063.c b/drivers/media/common/tuners/mt2063.c index 5e9655a..b2678a4 100644 --- a/drivers/media/common/tuners/

[PATCH 00/47] Add mt2063 frontend driver

2012-01-04 Thread Mauro Carvalho Chehab
Add a new driver for mt2063 tuner. This driver come originally from Terratec: http://linux.terratec.de/files/TERRATEC_H7/20110323_TERRATEC_H7_Linux.tar.gz And it is GPL'd, as declared at MODULE_LICENSE(). The original code doesn't met Linux Coding Style, and had several bad issues on i

[PATCH 15/47] [media] mt2063: Merge the two state structures into one

2012-01-04 Thread Mauro Carvalho Chehab
Signed-off-by: Mauro Carvalho Chehab --- drivers/media/common/tuners/mt2063.c | 1021 +++--- 1 files changed, 454 insertions(+), 567 deletions(-) diff --git a/drivers/media/common/tuners/mt2063.c b/drivers/media/common/tuners/mt2063.c index 30c72c0..66633fa 100644 --

[PATCH 35/47] [media] mt2063: Convert it to the DVBv5 way for set_params()

2012-01-04 Thread Mauro Carvalho Chehab
Signed-off-by: Mauro Carvalho Chehab --- drivers/media/common/tuners/mt2063.c | 46 - 1 files changed, 17 insertions(+), 29 deletions(-) diff --git a/drivers/media/common/tuners/mt2063.c b/drivers/media/common/tuners/mt2063.c index b2678a4..75cb1d2 100644 --- a

[PATCH 37/47] [media] mt2063: Rewrite tuning logic

2012-01-04 Thread Mauro Carvalho Chehab
Several vars at set_parms functions were set, but unused. Remove them and change the logic to return -EINVAL if the analog set_param is used for digital mode. At the analog side, cleans the logic that sets the several analog standards. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/com

[PATCH 38/47] [media] mt2063: Remove two unused temporary vars

2012-01-04 Thread Mauro Carvalho Chehab
mt2063.c:1531:12: warning: variable 'ofout' set but not used [-Wunused-but-set-variable] mt2063.c:1531:6: warning: variable 'ofin' set but not used [-Wunused-but-set-variable] Signed-off-by: Mauro Carvalho Chehab --- drivers/media/common/tuners/mt2063.c |5 + 1 files changed, 1 inserti

[PATCH 28/47] [media] mt2063: Reorder the code to avoid function prototypes

2012-01-04 Thread Mauro Carvalho Chehab
Signed-off-by: Mauro Carvalho Chehab --- drivers/media/common/tuners/mt2063.c | 331 +++--- 1 files changed, 150 insertions(+), 181 deletions(-) diff --git a/drivers/media/common/tuners/mt2063.c b/drivers/media/common/tuners/mt2063.c index f9ebe24..0f4bf96 100644 --

[PATCH 33/47] [media] mt2063: Rearrange the delivery system functions

2012-01-04 Thread Mauro Carvalho Chehab
No functional changes on this patch. Better organize the delivery system information and data types, putting everything together, to improve readability. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/common/tuners/mt2063.c | 143 -- 1 files changed, 66 i

[PATCH 40/47] [media] mt2063: Print a message about the detected mt2063 type

2012-01-04 Thread Mauro Carvalho Chehab
This also helps to identify when a device is not initialized, if the bridge doesn't return an error for a I2C failed transfer. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/common/tuners/mt2063.c | 26 ++ 1 files changed, 22 insertions(+), 4 deletions(-) diff

[PATCH 45/47] [media] mt2063: Add it to the building system

2012-01-04 Thread Mauro Carvalho Chehab
Signed-off-by: Mauro Carvalho Chehab --- drivers/media/common/tuners/Kconfig |7 +++ drivers/media/common/tuners/Makefile |1 + 2 files changed, 8 insertions(+), 0 deletions(-) diff --git a/drivers/media/common/tuners/Kconfig b/drivers/media/common/tuners/Kconfig index 996302a..ab8

[PATCH 08/47] [media] mt2063: Re-define functions as static

2012-01-04 Thread Mauro Carvalho Chehab
Signed-off-by: Mauro Carvalho Chehab --- drivers/media/common/tuners/mt2063.c | 84 ++ drivers/media/common/tuners/mt2063.h | 74 -- 2 files changed, 44 insertions(+), 114 deletions(-) diff --git a/drivers/media/common/tuners/mt2063

[PATCH 39/47] [media] mt2063: don't crash if device is not initialized

2012-01-04 Thread Mauro Carvalho Chehab
Instead of crash, return -ENODEV, if the device is not poperly initialized. Also, give a second chance for it to initialize, at set_params calls. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/common/tuners/mt2063.c | 25 + 1 files changed, 25 insertions(+), 0

[PATCH 31/47] [media] mt2063: Fix analog/digital set params logic

2012-01-04 Thread Mauro Carvalho Chehab
The driver were using a hacky way of setting analog and digital frequencies. Remove the hack and properly add the tuner logic for each supported type of standard. I was tempted to add more standards there, like SECAM and to fix radio (as stepping seems broken), but I opted to keep it as-is, as tes

[PATCH 36/47] [media] mt2063: Add some debug printk's

2012-01-04 Thread Mauro Carvalho Chehab
Signed-off-by: Mauro Carvalho Chehab --- drivers/media/common/tuners/mt2063.c | 76 ++ 1 files changed, 68 insertions(+), 8 deletions(-) diff --git a/drivers/media/common/tuners/mt2063.c b/drivers/media/common/tuners/mt2063.c index 75cb1d2..cd67417 100644 --- a

[PATCH 42/47] [media] mt2063: print the detected version

2012-01-04 Thread Mauro Carvalho Chehab
Instead of printing it just for debug purposes, outputs the detected version at the logs. This may be useful if someone wants to report a problem. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/common/tuners/mt2063.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --gi

[PATCH 41/47] [media] mt2063: Fix i2c read message

2012-01-04 Thread Mauro Carvalho Chehab
While here, improve a few debug messages that helped to track the issue and may be useful in the future. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/common/tuners/mt2063.c | 24 1 files changed, 16 insertions(+), 8 deletions(-) diff --git a/drivers/media/co

[PATCH 43/47] [media] mt2063: add some useful info for the dvb callback calls

2012-01-04 Thread Mauro Carvalho Chehab
The per-delivery system tables are confusing. Add an extra table that explains them, and some dprintk calls, that allows to check if mt2063 driver is working as expected. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/common/tuners/mt2063.c | 68 +++-- 1 fil

[PATCH 44/47] [media] mt2063: Add support for get_if_frequency()

2012-01-04 Thread Mauro Carvalho Chehab
get_if_frequency() is needed, in order to work with DRX-K. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/common/tuners/mt2063.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/common/tuners/mt2063.c b/drivers/media/common/tuners/mt2063.c in

[PATCH 46/47] [media] drxk: Improve a few debug messages

2012-01-04 Thread Mauro Carvalho Chehab
Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb/frontends/drxk_hard.c | 12 +--- 1 files changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/media/dvb/frontends/drxk_hard.c b/drivers/media/dvb/frontends/drxk_hard.c index 67a1e39..817d3ec 100644 --- a/drivers/media

[PATCH 32/47] [media] mt2063: Fix comments

2012-01-04 Thread Mauro Carvalho Chehab
Signed-off-by: Mauro Carvalho Chehab --- drivers/media/common/tuners/mt2063.c | 959 +- 1 files changed, 370 insertions(+), 589 deletions(-) diff --git a/drivers/media/common/tuners/mt2063.c b/drivers/media/common/tuners/mt2063.c index 4f634ad..181deac 100644 --

[PATCH 47/47] [media] drxk: Add support for parallel mode and prints mpeg mode

2012-01-04 Thread Mauro Carvalho Chehab
While the driver has support for both serial and parallel mode, There's was way to select serial mode via configuration. Add a config option for that, while keeping the default in serial mode. Also, at debug mode, it will now print a message when mpeg is enabled/disabled, and showing if parallel o

[PATCH 27/47] [media] mt2063: Remove setParm/getParm abstraction layer

2012-01-04 Thread Mauro Carvalho Chehab
This layer just increases the code size for no good reason, and makes harder to debug. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/common/tuners/mt2063.c | 1130 +- drivers/media/common/tuners/mt2063.h |2 +- 2 files changed, 172 insertions(+), 960

[PATCH 20/47] [media] mt2063: Simplify device init logic

2012-01-04 Thread Mauro Carvalho Chehab
Signed-off-by: Mauro Carvalho Chehab --- drivers/media/common/tuners/mt2063.c | 575 ++ 1 files changed, 242 insertions(+), 333 deletions(-) diff --git a/drivers/media/common/tuners/mt2063.c b/drivers/media/common/tuners/mt2063.c index 1011635..c5e95dd 100644 --

[PATCH 09/47] [media] mt2063: Remove unused stuff

2012-01-04 Thread Mauro Carvalho Chehab
Signed-off-by: Mauro Carvalho Chehab --- drivers/media/common/tuners/mt2063.c | 512 -- 1 files changed, 0 insertions(+), 512 deletions(-) diff --git a/drivers/media/common/tuners/mt2063.c b/drivers/media/common/tuners/mt2063.c index 85980cc..c181332 100644 ---

[PATCH 10/47] [media] mt2063: get rid of compilation warnings

2012-01-04 Thread Mauro Carvalho Chehab
Signed-off-by: Mauro Carvalho Chehab --- drivers/media/common/tuners/mt2063.c | 35 + drivers/media/common/tuners/mt2063.h | 11 +- 2 files changed, 24 insertions(+), 22 deletions(-) diff --git a/drivers/media/common/tuners/mt2063.c b/drivers/media/co

[PATCH 14/47] [media] mt2063: Remove unused data structures

2012-01-04 Thread Mauro Carvalho Chehab
Signed-off-by: Mauro Carvalho Chehab --- drivers/media/common/tuners/mt2063.c | 97 +- 1 files changed, 14 insertions(+), 83 deletions(-) diff --git a/drivers/media/common/tuners/mt2063.c b/drivers/media/common/tuners/mt2063.c index a1acfcc..30c72c0 100644 ---

[PATCH 12/47] [media] mt2063: Remove internal version checks

2012-01-04 Thread Mauro Carvalho Chehab
Signed-off-by: Mauro Carvalho Chehab --- drivers/media/common/tuners/mt2063.c |8 +--- 1 files changed, 1 insertions(+), 7 deletions(-) diff --git a/drivers/media/common/tuners/mt2063.c b/drivers/media/common/tuners/mt2063.c index 0c4ae7f..98bc2e2 100644 --- a/drivers/media/common/tuner

[PATCH 07/47] [media] mt2063: Remove most of the #if's

2012-01-04 Thread Mauro Carvalho Chehab
Signed-off-by: Mauro Carvalho Chehab --- drivers/media/common/tuners/mt2063.c | 89 ++ drivers/media/common/tuners/mt2063.h |8 --- 2 files changed, 4 insertions(+), 93 deletions(-) diff --git a/drivers/media/common/tuners/mt2063.c b/drivers/media/common/tu

[PATCH 04/47] [media] mt2063: Move code from mt2063_cfg.h

2012-01-04 Thread Mauro Carvalho Chehab
Signed-off-by: Mauro Carvalho Chehab --- drivers/media/common/tuners/mt2063.c | 129 ++ drivers/media/common/tuners/mt2063_cfg.h | 122 2 files changed, 129 insertions(+), 122 deletions(-) delete mode 100644 drivers/media/common/tune

[PATCH 03/47] [media] mt2063: Fix some Coding styles at mt2063.h

2012-01-04 Thread Mauro Carvalho Chehab
Signed-off-by: Mauro Carvalho Chehab --- drivers/media/common/tuners/mt2063.h | 271 +++--- 1 files changed, 119 insertions(+), 152 deletions(-) diff --git a/drivers/media/common/tuners/mt2063.h b/drivers/media/common/tuners/mt2063.h index 4912f89..8fa4411 100644 --

[PATCH 05/47] [media] mt2063: Fix the driver to make it compile

2012-01-04 Thread Mauro Carvalho Chehab
Signed-off-by: Mauro Carvalho Chehab --- drivers/media/common/tuners/mt2063.c |1 - drivers/media/common/tuners/mt2063.h | 25 + 2 files changed, 17 insertions(+), 9 deletions(-) diff --git a/drivers/media/common/tuners/mt2063.c b/drivers/media/common/tuners/mt2063

subdev support for querying struct v4l2_input *

2012-01-04 Thread Steven Toth
Hans, In the cx23885 driver as part of vidioc_enum_input call, I have a need to return V4L2_IN_ST_NO_SIGNAL in the status field as part of struct v4l2_input. Thus, when no signal is detected by the video decoder it can be signalled to the calling application. I looks like subdev_core_ops doesn't

Re: [PULL] git://git.kernellabs.com/stoth/cx23885-hvr1850.git media-master branch

2012-01-04 Thread Steven Toth
> There's something wrong on this patch. It breaks compilation: Mauro, My mistake, I've corrected the issue: The following changes since commit 9c9c3d078b0dd81a74e5f531aa1efa30add5b419: [media] cx23885: Configure the MPEG encoder early to avoid jerky video (2012-01-04 20:51:18 -0200) are avai

Re: [git:v4l-dvb/for_v3.3] [media] cx25840 / cx23885: Fixing audio/volume regression

2012-01-04 Thread Steven Toth
Mauro, My mistake, I've corrected the issue: The following changes since commit 9c9c3d078b0dd81a74e5f531aa1efa30add5b419: [media] cx23885: Configure the MPEG encoder early to avoid jerky video (2012-01-04 20:51:18 -0200) are available in the git repository at: git://git.kernellabs.com/stoth

Re: Fix Leadtek DTV2000H radio tuner

2012-01-04 Thread Mauro Carvalho Chehab
On 04-01-2012 21:54, Miroslav Slugeň wrote: > Resending signed version... You need to do the same for the other patches you've sent ;) Thanks Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info

Re: Fix Leadtek DTV2000H radio tuner

2012-01-04 Thread Miroslav Slugeň
Resending signed version... Signed-off-by: Miroslav Slugen From dadfa45664f765297e03e73a907ac04bd55e9b25 Mon Sep 17 00:00:00 2001 From: Miroslav Slugen Date: Tue, 13 Dec 2011 19:36:15 +0100 Subject: [PATCH] Leadtek DTV2000H J has Philips FMD1216MEX tuner, this patch fixed not working radio part,

Re: Fix Leadtek DTV2000H radio tuner

2012-01-04 Thread Mauro Carvalho Chehab
On 16-12-2011 22:39, Miroslav Slugeň wrote: > Leadtek DTV2000H J revision has FMD1216MEX, no older FMD1216ME. But > there is still another unknown issue with radio, because some stations > are just not working or are very noisy. Miroslav, Please sign your patches with: Signed-off-by: your

Re: [PULL] git://git.kernellabs.com/stoth/cx23885-hvr1850.git media-master branch

2012-01-04 Thread Mauro Carvalho Chehab
On 04-01-2012 20:44, Mauro Carvalho Chehab wrote: > On 04-01-2012 13:28, Steven Toth wrote: >> Mauro, >> >> I've been adding support to the CX23885 and CX25840 drivers for the >> Hauppauge HVR1850 >> card. These patches enable the use of raw video, audio and/or the mpeg >> encoder, via all >> video

Re: [PATCHv4 1/2] v4l: Add new framesamples field to struct v4l2_mbus_framefmt

2012-01-04 Thread Sylwester Nawrocki
Hi Sakari, On 01/04/2012 01:21 PM, Sakari Ailus wrote: > On Sun, Jan 01, 2012 at 07:56:03PM +0100, Sylwester Nawrocki wrote: >> On 12/31/2011 02:16 PM, Sakari Ailus wrote: > Something else that should probably belong there is information on the > frame > format: contrary to what I've

Re: [PULL] git://git.kernellabs.com/stoth/cx23885-hvr1850.git media-master branch

2012-01-04 Thread Mauro Carvalho Chehab
On 04-01-2012 13:28, Steven Toth wrote: > Mauro, > > I've been adding support to the CX23885 and CX25840 drivers for the > Hauppauge HVR1850 > card. These patches enable the use of raw video, audio and/or the mpeg > encoder, via all > video and audio inputs. Support for the HVR1850 is now in prett

Re: [RFC PATCH 1/4] v4l: Add V4L2_CID_PRESET_WHITE_BALANCE menu control

2012-01-04 Thread Sylwester Nawrocki
Hi Sakari, On 01/04/2012 10:24 PM, Sakari Ailus wrote: > I don't quite understand the purpose of the do_white_balance; the > automatic white balance algorithm is operational until it's disabled, > and after disabling it the white balance shouldn't change. What is the > extra functi

Re: [RFC/PATCH 1/5] v4l: Convert V4L2_CID_FOCUS_AUTO control to a menu control

2012-01-04 Thread Sylwester Nawrocki
Hi Laurent, On 01/03/2012 02:55 PM, Laurent Pinchart wrote: > parameter. We also need to discuss how the af statistics window > configuration is done. I'm not certain there could even be a > standardised Do we need multiple windows for AF statistics ? If not, I'm in

Re: [PATCH] V4L: soc-camera: provide support for S_INPUT.

2012-01-04 Thread Guennadi Liakhovetski
On Wed, 4 Jan 2012, Laurent Pinchart wrote: > On Wednesday 04 January 2012 18:13:58 Guennadi Liakhovetski wrote: > > On Wed, 4 Jan 2012, Laurent Pinchart wrote: > > > On Wednesday 04 January 2012 17:35:27 Guennadi Liakhovetski wrote: > > > > On Wed, 4 Jan 2012, javier Martin wrote: > > > > > > >

Re: [RFC PATCH 1/4] v4l: Add V4L2_CID_PRESET_WHITE_BALANCE menu control

2012-01-04 Thread Sakari Ailus
Hi Laurent, Laurent Pinchart wrote: Hi Sakari, On Wednesday 04 January 2012 21:39:34 Sakari Ailus wrote: On Sun, Jan 01, 2012 at 04:38:21PM +0100, Sylwester Nawrocki wrote: On 12/30/2011 09:41 PM, Sakari Ailus wrote: On Fri, Dec 30, 2011 at 11:14:39AM +0100, Sylwester Nawrocki wrote: On 12/

Re: [RFC PATCH 0/4] Add some new camera controls

2012-01-04 Thread Sakari Ailus
Hi Sylwester, On Fri, Dec 30, 2011 at 12:18:40PM +0100, Sylwester Nawrocki wrote: > On 12/28/2011 03:01 PM, Laurent Pinchart wrote: > > On Wednesday 28 December 2011 07:23:44 HeungJun, Kim wrote: > >> This RFC patch series include new 4 controls ID for digital camera. > >> I about to suggest these

Re: [RFC PATCH 1/4] v4l: Add V4L2_CID_PRESET_WHITE_BALANCE menu control

2012-01-04 Thread Laurent Pinchart
Hi Sakari, On Wednesday 04 January 2012 21:39:34 Sakari Ailus wrote: > On Sun, Jan 01, 2012 at 04:38:21PM +0100, Sylwester Nawrocki wrote: > > On 12/30/2011 09:41 PM, Sakari Ailus wrote: > > > On Fri, Dec 30, 2011 at 11:14:39AM +0100, Sylwester Nawrocki wrote: > > >> On 12/30/2011 12:34 AM, Sakari

Re: [PATCH] V4L: soc-camera: provide support for S_INPUT.

2012-01-04 Thread Laurent Pinchart
On Wednesday 04 January 2012 18:13:58 Guennadi Liakhovetski wrote: > On Wed, 4 Jan 2012, Laurent Pinchart wrote: > > On Wednesday 04 January 2012 17:35:27 Guennadi Liakhovetski wrote: > > > On Wed, 4 Jan 2012, javier Martin wrote: > > > > > > [snip] > > > > > > > For ov7725 it is a natural thing

Re: [RFC PATCH 1/4] v4l: Add V4L2_CID_PRESET_WHITE_BALANCE menu control

2012-01-04 Thread Sakari Ailus
Hi Sylwester, On Sun, Jan 01, 2012 at 04:38:21PM +0100, Sylwester Nawrocki wrote: > On 12/30/2011 09:41 PM, Sakari Ailus wrote: > > On Fri, Dec 30, 2011 at 11:14:39AM +0100, Sylwester Nawrocki wrote: > >> On 12/30/2011 12:34 AM, Sakari Ailus wrote: > >>> On Wed, Dec 28, 2011 at 02:51:38PM +0100, L

Re: [PATCH 0/3] V4L: mt9m111: clean up and fix .s_crop() / .s_fmt()

2012-01-04 Thread Robert Jarzmik
Guennadi Liakhovetski writes: > Hi all > > While working on a context-switching test, I've cleaned up the mt9m111 > driver a bit and fixed its cropping and scaling functions. These are > planned for 3.3. Hi Guennadi, I've been on holidays ... so I've not dived into your changes. >From a quick

[PATCH v3] xc3028: fix center frequency calculation for DTV78 firmware

2012-01-04 Thread Gianluca Gennari
Hi all, this v3 version has been sent through "git send-email" to avoid line-wrapping problems. This patch replaces the previous one proposed in the thread "xc3028: force reload of DTV7 firmware in VHF band with Zarlink demodulator". The problem is that the firmware DTV78 works fine in UHF band (8

Re: [PATCH v4 16/47] [media] tuner-xc2028: use DVBv5 parameters on set_params()

2012-01-04 Thread Gianluca Gennari
Il 04/01/2012 19:50, Mauro Carvalho Chehab ha scritto: > On 02-01-2012 17:32, Gianluca Gennari wrote: >> Il 24/12/2011 16:50, Mauro Carvalho Chehab ha scritto: >>> Instead of using DVBv3 parameters, rely on DVBv5 parameters to >>> set the tuner. >>> >>> Signed-off-by: Mauro Carvalho Chehab >>> ---

Re: [PATCH v4 16/47] [media] tuner-xc2028: use DVBv5 parameters on set_params()

2012-01-04 Thread Mauro Carvalho Chehab
On 02-01-2012 17:32, Gianluca Gennari wrote: > Il 24/12/2011 16:50, Mauro Carvalho Chehab ha scritto: >> Instead of using DVBv3 parameters, rely on DVBv5 parameters to >> set the tuner. >> >> Signed-off-by: Mauro Carvalho Chehab >> --- >> drivers/media/common/tuners/tuner-xc2028.c | 83 >>

cron job: media_tree daily build: ERRORS

2012-01-04 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date:Wed Jan 4 19:00:20 CET 2012 git hash:1e73fa5d56333230854ae9460579eb2fcee8af02 gcc version: i686-linux-gcc (GCC

[PATCH] drxk: Fix regression introduced by commit '[media] Remove Annex A/C selection via roll-off factor'

2012-01-04 Thread Oliver Endriss
Fix regression introduced by commit '[media] Remove Annex A/C selection via roll-off factor' As a result of this commit, DVB-T tuning did not work anymore. Signed-off-by: Oliver Endriss diff --git a/drivers/media/dvb/frontends/drxk_hard.c b/drivers/media/dvb/frontends/drxk_hard.c index 36e1c82

Re: [PATCH] V4L: soc-camera: provide support for S_INPUT.

2012-01-04 Thread Guennadi Liakhovetski
On Wed, 4 Jan 2012, Laurent Pinchart wrote: > Hi Guennadi, > > On Wednesday 04 January 2012 17:35:27 Guennadi Liakhovetski wrote: > > On Wed, 4 Jan 2012, javier Martin wrote: > > > > [snip] > > > > > For ov7725 it is a natural thing to do since it was originally > > > developed for soc-camera a

Re: [PATCH] V4L: soc-camera: provide support for S_INPUT.

2012-01-04 Thread Laurent Pinchart
Hi Guennadi, On Wednesday 04 January 2012 17:35:27 Guennadi Liakhovetski wrote: > On Wed, 4 Jan 2012, javier Martin wrote: > > [snip] > > > For ov7725 it is a natural thing to do since it was originally > > developed for soc-camera and it can easily do the following to access > > platform data:

Re: [PATCH] V4L: soc-camera: provide support for S_INPUT.

2012-01-04 Thread Guennadi Liakhovetski
On Wed, 4 Jan 2012, javier Martin wrote: [snip] > For ov7725 it is a natural thing to do since it was originally > developed for soc-camera and it can easily do the following to access > platform data: > > struct soc_camera_link*icl = soc_camera_i2c_to_link(client); > pdata = icl->priv;

Re: v4l: how to get blanking clock count?

2012-01-04 Thread Sakari Ailus
On Wed, Jan 04, 2012 at 05:59:45PM +0800, Scott Jiang wrote: > >> If I disable this interrupt, other errors like fifo underflow are ignored. > >> Perhaps I can add a parameter in platform data to let user decide to > >> register this interrupt or not. > > > > I think a more generic solution would b

[PATCH 1/2 v4] media: vb2: support userptr for PFN mappings.

2012-01-04 Thread Javier Martin
Some video devices need to use contiguous memory which is not backed by pages as it happens with vmalloc. This patch provides userptr handling for those devices. --- Changes since v3: - Remove vma_res variable. Signed-off-by: Javier Martin --- drivers/media/video/videobuf2-vmalloc.c | 70 +++

Re: RFC: dvbzap application based on DVBv5 API

2012-01-04 Thread Mauro Carvalho Chehab
Hi Akihiro, On 30-12-2011 04:46, Akihiro TSUKADA wrote: >> [channel name] >> property = value >> ... >> property = value > > Currently, at least gstreamer's dvbbasebin and mplayer assumue that > the channel configuration file has the format of one line per channel. > So when I personall

Re: [PATCH] V4L: soc-camera: provide support for S_INPUT.

2012-01-04 Thread javier Martin
Hi Guennadi. Thanks for your help. On 3 January 2012 16:05, Guennadi Liakhovetski wrote: > Hi Javier > > On Tue, 3 Jan 2012, javier Martin wrote: > >> Guennadi, >> probably you could answer me some question: >> >> as we agreed I'm trying to implement ENUM_INPUT support to soc-camera >> through pa

Re: [PATCH 1/2 v3] media: vb2: support userptr for PFN mappings.

2012-01-04 Thread Laurent Pinchart
Hi Javier, Thanks for the patch. On Wednesday 04 January 2012 16:46:51 Javier Martin wrote: > Some video devices need to use contiguous memory > which is not backed by pages as it happens with > vmalloc. This patch provides userptr handling for > those devices. > > --- > Changes since v2: > - D

Re: [PATCH] v4l2: v4l2-fh: v4l2_fh_is_singular should use list head to test

2012-01-04 Thread Sakari Ailus
Hi Scott, Thanks for the patch. On Wed, Dec 21, 2011 at 10:30:54AM -0500, Scott Jiang wrote: > list_is_singular accepts a list head to test whether a list has just one > entry. > fh->list is the entry, fh->vdev->fh_list is the list head. > > Signed-off-by: Scott Jiang > --- > drivers/media/vi

[PATCH 1/2 v3] media: vb2: support userptr for PFN mappings.

2012-01-04 Thread Javier Martin
Some video devices need to use contiguous memory which is not backed by pages as it happens with vmalloc. This patch provides userptr handling for those devices. --- Changes since v2: - Do not grab mm->mmap_sem. Signed-off-by: Javier Martin --- drivers/media/video/videobuf2-vmalloc.c | 71 ++

[PULL] git://git.kernellabs.com/stoth/cx23885-hvr1850.git media-master branch

2012-01-04 Thread Steven Toth
Mauro, I've been adding support to the CX23885 and CX25840 drivers for the Hauppauge HVR1850 card. These patches enable the use of raw video, audio and/or the mpeg encoder, via all video and audio inputs. Support for the HVR1850 is now in pretty good shape. The card uses the CX23888 PCIe bridge w

Re: [RFC/PATCH] v4l: Add V4L2_CID_FLASH_HW_STROBE_MODE control

2012-01-04 Thread Sakari Ailus
Hi Sylwester, On Wed, Dec 28, 2011 at 05:06:55PM +0100, Sylwester Nawrocki wrote: > On 12/14/2011 10:51 PM, Sakari Ailus wrote: > > On Sat, Dec 10, 2011 at 02:55:19PM +0100, Sylwester Nawrocki wrote: > >> On 12/05/2011 11:41 PM, Sakari Ailus wrote: > >>> On Mon, Dec 05, 2011 at 08:56:46PM +0100,

RE: [PATCH v8 1/2] davinci: vpif: remove machine specific header file inclusion from the driver

2012-01-04 Thread Hadli, Manjunath
Sergei, On Wed, Jan 04, 2012 at 18:29:13, Sergei Shtylyov wrote: > Hello. > > On 04-01-2012 11:17, Manjunath Hadli wrote: > > > remove unnecessary inclusion of machine specific header files > > mach/dm646x.h, mach/hardware.h from vpif.h and aslo mach/dm646x.h > > from vpif_display.c driver whi

I2C and SPI subdevs unregistration

2012-01-04 Thread Laurent Pinchart
Hi Hans, Do you know why I2C and SPI devices are unregistered in v4l2_device_unregister() but not in v4l2_device_unregister_subdev() ? If I call the later manually before calling v4l2_device_unregister(), the I2C and SPI devices won't be unregistered. Is that expected ? -- Regards, Laurent P

Re: [RFC/PATCH 1/5] v4l: Convert V4L2_CID_FOCUS_AUTO control to a menu control

2012-01-04 Thread Sakari Ailus
Hi Sylwester, On Mon, Jan 02, 2012 at 09:55:31PM +0100, Sylwester Nawrocki wrote: > Hi Laurent, > > On 01/02/2012 12:16 PM, Laurent Pinchart wrote: > >> * controls for starting/stopping auto focusing (V4L2_CID_FOCUS_AUTO == > >> false) > >> > >> V4L2_CID_START_AUTO_FOCUS (button) - start auto f

Re: [patch -longterm] V4L/DVB: v4l2-ioctl: integer overflow in video_usercopy()

2012-01-04 Thread Dan Carpenter
On Tue, Jan 03, 2012 at 12:55:39PM -0800, Greg KH wrote: > Ok, can someone please send me the "accepted" version of this patch for > inclusion in the 2.6.32-stable tree? > Sorry for that. Holidays and all. I'll send a patch tomorrow. regards, dan carpenter signature.asc Description: Digital

Re: [RFC/PATCH 1/5] v4l: Convert V4L2_CID_FOCUS_AUTO control to a menu control

2012-01-04 Thread Sakari Ailus
Hi Sylwester, On Sun, Jan 01, 2012 at 05:49:11PM +0100, Sylwester Nawrocki wrote: > On 12/31/2011 01:00 PM, Sakari Ailus wrote: > > Hi Sylwester, > > > > Apologies for my late answer. > > No problem, thanks for your comments! > > > On Sat, Dec 10, 2011 at 03:42:41PM +0100, Sylwester Nawrocki wr

Re: [PATCH v8 1/2] davinci: vpif: remove machine specific header file inclusion from the driver

2012-01-04 Thread Sergei Shtylyov
Hello. On 04-01-2012 11:17, Manjunath Hadli wrote: remove unnecessary inclusion of machine specific header files mach/dm646x.h, mach/hardware.h from vpif.h and aslo mach/dm646x.h from vpif_display.c driver which comes in the way of platform code consolidation. Add linux/i2c.h header file in vp

Re: [PATCHv4 1/2] v4l: Add new framesamples field to struct v4l2_mbus_framefmt

2012-01-04 Thread Sakari Ailus
Hi Sylwester, On Sun, Jan 01, 2012 at 07:56:03PM +0100, Sylwester Nawrocki wrote: > Hi Sakari, > > On 12/31/2011 02:16 PM, Sakari Ailus wrote: > >>> I could think of an in-kernel counterpart for v4l2_mbus_framefmt, say, > >>> v4l2_mbus_framedesc. This could then be passed from subdev to another

RE: [RFC] Resolution change support in video codecs in v4l2

2012-01-04 Thread Kamil Debski
Hi Sakari, > From: 'Sakari Ailus' [mailto:sakari.ai...@iki.fi] > Sent: 01 January 2012 23:29 decs in v4l2 > > Hi Kamil, > > Apologies for my later reply. > > On Mon, Dec 12, 2011 at 11:17:06AM +0100, Kamil Debski wrote: > > > -Original Message- > > > From: 'Sakari Ailus' [mailto:sakari.

Re: v4l: how to get blanking clock count?

2012-01-04 Thread Scott Jiang
>> If I disable this interrupt, other errors like fifo underflow are ignored. >> Perhaps I can add a parameter in platform data to let user decide to >> register this interrupt or not. > > I think a more generic solution would be preferrable. If that causes > ignoring real errors, that's of course

Re: More adapters on v4l

2012-01-04 Thread Josu Lazkano
2012/1/3 Gianluca Gennari : > Il 03/01/2012 17:09, Josu Lazkano ha scritto: >> Hello, I am trying to compile the v4l drivers, I make this way: >> >> mkdir /usr/local/src/dvb >> cd /usr/local/src/dvb >> git clone git://linuxtv.org/media_build.git >> cd media_build >> ./build >> >> I got this message

Re: v4l: how to get blanking clock count?

2012-01-04 Thread Sakari Ailus
On Wed, Jan 04, 2012 at 05:10:40PM +0800, Scott Jiang wrote: > 2012/1/4 Sakari Ailus : > > Hi Scott, > > > > On Wed, Jan 04, 2012 at 01:50:17PM +0800, Scott Jiang wrote: > >> >> I the case of your bridge, that may not be possible, but that's the > >> >> only one > >> >> I've heard of so I think it

Re: v4l: how to get blanking clock count?

2012-01-04 Thread Scott Jiang
2012/1/4 Sakari Ailus : > Hi Scott, > > On Wed, Jan 04, 2012 at 01:50:17PM +0800, Scott Jiang wrote: >> >> I the case of your bridge, that may not be possible, but that's the only >> >> one >> >> I've heard of so I think it's definitely a special case. In that case the >> >> sensor driver can't be

[ANN] IRC meeting on new sensor control interface, 2012-01-09 14:00 GMT+2

2012-01-04 Thread Sakari Ailus
Hi all, I'd like to announce that we'll have an IRC meeting on #v4l-meeting channel on the new sensor control interface. The date is next Monday 2012-01-09 14:00 GMT + 2. Most important background information is this; it discusses how image sensors should be controlled: http://www.spinics.net/lis

  1   2   >