Re: [PATCH]video:gspca.c Fix warning: case value '7' not in enumerated type 'enum v4l2_memory'

2010-07-07 Thread Jean-Francois Moine
On Wed, 7 Jul 2010 21:46:18 -0700 "Justin P. Mattock" wrote: > This fixes a warning I'm seeing when building: > CC [M] drivers/media/video/gspca/gspca.o > drivers/media/video/gspca/gspca.c: In function 'vidioc_reqbufs': > drivers/media/video/gspca/gspca.c:1508:2: warning: case value '7' not >

Re: [linux-dvb] ca_zap source available?

2010-07-07 Thread Timofte Bogdan
On 24.06.2010 05:53, YD wrote: Hello, Is it avaiable to have the ca_zap source code? I read the ci.txt and it said we could test the ci function with ca_zap. But I could not find out yet. Also please recommend good reference about the DVB-CI implementation. Thanks, __

[PATCH]video:gspca.c Fix warning: case value '7' not in enumerated type 'enum v4l2_memory'

2010-07-07 Thread Justin P. Mattock
This fixes a warning I'm seeing when building: CC [M] drivers/media/video/gspca/gspca.o drivers/media/video/gspca/gspca.c: In function 'vidioc_reqbufs': drivers/media/video/gspca/gspca.c:1508:2: warning: case value '7' not in enumerated type 'enum v4l2_memory' Signed-off-by: Justin P. Mattock

Re: Status of the patches under review at LMML (60 patches)

2010-07-07 Thread Mike Isely
On Tue, 6 Jul 2010, Mauro Carvalho Chehab wrote: > This is the summary of the patches that are currently under review at > Linux Media Mailing List . > Each patch is represented by its submission date, the subject (up to 70 > chars) and the patchwork link (if submitted via email). > > P.S.: This

Re: em28xx: success report for KWORLD DVD Maker USB 2.0 (VS-USB2800) [eb1a:2860]

2010-07-07 Thread Devin Heitmueller
On Wed, Jul 7, 2010 at 9:56 PM, Ivan wrote: > I recently purchased ($20 special deal from newegg; the price has gone back > up) the following USB stick that captures composite video and S-video (no TV > tuner): > > KWORLD DVD Maker USB 2.0 (VS-USB2800) > > It seemed likely to be supported by the e

em28xx: success report for KWORLD DVD Maker USB 2.0 (VS-USB2800) [eb1a:2860]

2010-07-07 Thread Ivan
I recently purchased ($20 special deal from newegg; the price has gone back up) the following USB stick that captures composite video and S-video (no TV tuner): KWORLD DVD Maker USB 2.0 (VS-USB2800) It seemed likely to be supported by the em28xx driver, and I'm pleased to report that, in fact

[PATCH -next] IR: jvc-decoder needs BITREVERSE

2010-07-07 Thread Randy Dunlap
Wilson Cc: David Härdeman Cc: Mauro Carvalho Chehab --- drivers/media/IR/Kconfig |1 + 1 file changed, 1 insertion(+) --- linux-next-20100707.orig/drivers/media/IR/Kconfig +++ linux-next-20100707/drivers/media/IR/Kconfig @@ -53,6 +53,7 @@ config IR_RC6_DECODER config IR_JVC_DECODER

Re: [PATCH/RFC v2 0/8] dsbr100: driver cleanup and fixes

2010-07-07 Thread David Ellingsworth
On Thu, May 27, 2010 at 12:39 PM, David Ellingsworth wrote: > This patch series addresses several issues in the dsbr100 driver. > This series is based on the v4l-dvb master git branch and has been > compile tested only. It should be tested before applying. > > This is the second version of this se

Re: Microsoft VX-1000 Microphone Drivers Crash in x86_64

2010-07-07 Thread Kyle Baker
On Wed, Jul 7, 2010 at 5:06 AM, Jean-Francois Moine wrote: > > The video and audio don't work at the same time because the video is > opened before the audio and it takes all the USB bandwidth. > > The problem is in the main gspca.c, not in sonixj.c. It may fixed using > a lower alternate setting.

Re: [RFC/PATCH 2/6] v4l: subdev: Add device node support

2010-07-07 Thread Mauro Carvalho Chehab
Em 07-07-2010 16:44, Laurent Pinchart escreveu: > Hi Mauro, > > Thanks for the review. > > On Wednesday 07 July 2010 16:58:01 Mauro Carvalho Chehab wrote: >> Em 07-07-2010 08:53, Laurent Pinchart escreveu: >>> Create a device node named subdevX for every registered subdev. >>> As the device node i

Re: [RFC/PATCH 2/6] v4l: subdev: Add device node support

2010-07-07 Thread Laurent Pinchart
Hi Mauro, Thanks for the review. On Wednesday 07 July 2010 16:58:01 Mauro Carvalho Chehab wrote: > Em 07-07-2010 08:53, Laurent Pinchart escreveu: > > Create a device node named subdevX for every registered subdev. > > As the device node is registered before the subdev core::s_config > > function

[cron job] v4l-dvb daily build 2.6.22 and up: ERRORS, 2.6.16-2.6.21: ERRORS

2010-07-07 Thread Hans Verkuil
This message is generated daily by a cron job that builds v4l-dvb for the kernels and architectures in the list below. Results of the daily build of v4l-dvb: date:Wed Jul 7 19:00:18 CEST 2010 path:http://www.linuxtv.org/hg/v4l-dvb changeset: 14993:9652f85e688a git master:

Re: Some issues with imon input driver

2010-07-07 Thread Anssi Hannula
Jarod Wilson kirjoitti keskiviikko, 7. heinäkuuta 2010 16:52:59: > On Wed, Jul 07, 2010 at 05:36:45AM +0300, Anssi Hannula wrote: > > Hi! > > > > I tried to set up my imon remote, but run into the issue of buttons > > getting easily stuck. And while looking at the code, I noticed some more > > iss

libv4lconvert & Logitech Webcam 9000 Pro

2010-07-07 Thread Uwe Sauter
Hi everybody, I have a problem concerning libv4lconvert, Logitech Webcam 9000 Pro and perhaps OpenCV. When I try to run OpenCV's examples that access the webcam they crash with the following: libv4lconvert: warning more framesizes then I can handle! libv4lconvert: warni

Re: Status of the patches under review at LMML (60 patches)

2010-07-07 Thread Mike Isely
On Wed, 7 Jul 2010, Sven Barth wrote: > Hi! > > Am 06.07.2010 15:06, schrieb Mauro Carvalho Chehab: > > == Waiting for Mike Isely review == > > > > Apr,25 2010: Problem with cx25840 and Terratec Grabster AV400 > http://patchwork.kernel.org/patch/94960 > > Is Mike really the maintain

Re: [RFC/PATCH 2/6] v4l: subdev: Add device node support

2010-07-07 Thread Mauro Carvalho Chehab
Em 07-07-2010 11:14, Karicheri, Muralidharan escreveu: > > >> v4l2_device *v4l2_dev, >> if (err && err != -ENOIOCTLCMD) { >> v4l2_device_unregister_subdev(sd); >> sd = NULL; >> +} else { >> +sd->initialized = 1

Re: [RFC/PATCH 2/6] v4l: subdev: Add device node support

2010-07-07 Thread Mauro Carvalho Chehab
Em 07-07-2010 08:53, Laurent Pinchart escreveu: > Create a device node named subdevX for every registered subdev. > As the device node is registered before the subdev core::s_config > function is called, return -EGAIN on open until initialization > completes. > > Signed-off-by: Laurent Pinchart >

RE: [RFC/PATCH 2/6] v4l: subdev: Add device node support

2010-07-07 Thread Sylwester Nawrocki
Isn't it like there need to be {} for both "if" and "else" when there is more than one line in either block? Regards, -- Sylwester Nawrocki > -Original Message- > From: linux-media-ow...@vger.kernel.org [mailto:linux-media- > ow...@vger.kernel.org] On Behalf Of Karicheri, Muralidharan >

[PATCH] IR/lirc_dev: fix locking in lirc_dev_fop_read

2010-07-07 Thread Jarod Wilson
On Wed, Jul 07, 2010 at 02:52:58PM +0200, Jiri Slaby wrote: > Hi, > > stanse found a locking error in lirc_dev_fop_read: > if (mutex_lock_interruptible(&ir->irctl_lock)) > return -ERESTARTSYS; > ... > while (written < length && ret == 0) { > if (mutex_lock_interruptible(&ir->irctl_lock)) {

RE: [RFC/PATCH 2/6] v4l: subdev: Add device node support

2010-07-07 Thread Karicheri, Muralidharan
>v4l2_device *v4l2_dev, > if (err && err != -ENOIOCTLCMD) { > v4l2_device_unregister_subdev(sd); > sd = NULL; >+ } else { >+ sd->initialized = 1; > } Wouldn't checkpatch.pl script complain a

Re: MEDIA: lirc, improper locking

2010-07-07 Thread Jarod Wilson
On Wed, Jul 07, 2010 at 02:52:58PM +0200, Jiri Slaby wrote: > Hi, > > stanse found a locking error in lirc_dev_fop_read: > if (mutex_lock_interruptible(&ir->irctl_lock)) > return -ERESTARTSYS; > ... > while (written < length && ret == 0) { > if (mutex_lock_interruptible(&ir->irctl_lock)) {

RE: [RFC/PATCH 1/6] v4l: subdev: Don't require core operations

2010-07-07 Thread Karicheri, Muralidharan
Laurent, This is a good fix. For example, soc based sub devices may not have core ops implemented. Murali Karicheri Software Design Engineer Texas Instruments Inc. Germantown, MD 20874 email: m-kariche...@ti.com >-Original Message- >From: linux-media-ow...@vger.kernel.org [mailto:linux-

Re: [RFC/PATCH 2/6] v4l: subdev: Add device node support

2010-07-07 Thread Laurent Pinchart
Hi Hans, On Wednesday 07 July 2010 14:43:08 Hans Verkuil wrote: > > Create a device node named subdevX for every registered subdev. > > > > As the device node is registered before the subdev core::s_config > > function is called, return -EGAIN on open until initialization > > completes. [snip]

Re: Some issues with imon input driver

2010-07-07 Thread Jarod Wilson
On Wed, Jul 07, 2010 at 05:36:45AM +0300, Anssi Hannula wrote: > Hi! > > I tried to set up my imon remote, but run into the issue of buttons getting > easily stuck. And while looking at the code, I noticed some more issues :) I'm not entirely surprised, I knew there were a few quirks left I'd no

Re: [RFC/PATCH 2/6] v4l: subdev: Add device node support

2010-07-07 Thread Hans Verkuil
> Hi Hans, > > Thanks for the quick review. > > On Wednesday 07 July 2010 14:30:45 Hans Verkuil wrote: >> > Create a device node named subdevX for every registered subdev. >> > >> > As the device node is registered before the subdev core::s_config >> > function is called, return -EGAIN on open unt

Re: [RFC/PATCH 2/6] v4l: subdev: Add device node support

2010-07-07 Thread Laurent Pinchart
Hi Hans, Thanks for the quick review. On Wednesday 07 July 2010 14:30:45 Hans Verkuil wrote: > > Create a device node named subdevX for every registered subdev. > > > > As the device node is registered before the subdev core::s_config > > function is called, return -EGAIN on open until initializ

MEDIA: lirc, improper locking

2010-07-07 Thread Jiri Slaby
Hi, stanse found a locking error in lirc_dev_fop_read: if (mutex_lock_interruptible(&ir->irctl_lock)) return -ERESTARTSYS; ... while (written < length && ret == 0) { if (mutex_lock_interruptible(&ir->irctl_lock)) {#1 ret = -ERESTARTSYS; break; } ... } remove_wait_queue(&ir->bu

Re: Status of the patches under review (85 patches) and some misc notes about the devel procedures

2010-07-07 Thread Bjørn Mork
Mauro Carvalho Chehab writes: > Em 01-07-2010 08:46, Bjørn Mork escreveu: >> Any chance of a new status update anytime soon? > > Updated today, after two or three weeks spent to handle the backlog. Great! Thanks. It's really appreciated, and I do note that it made quite a few people finally a

Re: [RFC/PATCH 2/6] v4l: subdev: Add device node support

2010-07-07 Thread Hans Verkuil
> Create a device node named subdevX for every registered subdev. > > As the device node is registered before the subdev core::s_config > function is called, return -EGAIN on open until initialization > completes. > > Signed-off-by: Laurent Pinchart > Signed-off-by: Vimarsh Zutshi > --- > drive

Re: [RFC/PATCH 6/6] v4l: subdev: Generic ioctl support

2010-07-07 Thread Hans Verkuil
> Instead of returning an error when receiving an ioctl call with an > unsupported command, forward the call to the subdev core::ioctl handler. > > Signed-off-by: Laurent Pinchart > --- > Documentation/video4linux/v4l2-framework.txt |5 + > drivers/media/video/v4l2-subdev.c|

Re: [RFC/PATCH 5/6] v4l: subdev: Events support

2010-07-07 Thread Hans Verkuil
> From: Sakari Ailus > > Provide v4l2_subdevs with v4l2_event support. Subdev drivers only need > very > little to support events. > > Signed-off-by: Sakari Ailus > Signed-off-by: David Cohen > Signed-off-by: Laurent Pinchart > --- > Documentation/video4linux/v4l2-framework.txt | 18 +++

Re: [RFC/PATCH 4/6] v4l: subdev: Control ioctls support

2010-07-07 Thread Laurent Pinchart
Hi Hans, Thanks for the quick review. On Wednesday 07 July 2010 14:33:52 Hans Verkuil wrote: > > Pass the control-related ioctls to the subdev driver through the core > > operations. > > > > Signed-off-by: Laurent Pinchart [snip] > This should simplify substantially once the control framework

Re: [RFC/PATCH 4/6] v4l: subdev: Control ioctls support

2010-07-07 Thread Hans Verkuil
> Pass the control-related ioctls to the subdev driver through the core > operations. > > Signed-off-by: Laurent Pinchart > --- > Documentation/video4linux/v4l2-framework.txt | 24 > > drivers/media/video/v4l2-subdev.c| 24 > > 2

Re: [RFC/PATCH 3/6] v4l: subdev: Uninline the v4l2_subdev_init function

2010-07-07 Thread Hans Verkuil
> The function isn't small or performance sensitive enough to be inlined. > > Signed-off-by: Laurent Pinchart Reviewed-by: Hans Verkuil Looks good! Hans > --- > drivers/media/video/v4l2-subdev.c | 14 ++ > include/media/v4l2-subdev.h | 15 ++- > 2 fi

Re: [RFC/PATCH 2/6] v4l: subdev: Add device node support

2010-07-07 Thread Hans Verkuil
> Create a device node named subdevX for every registered subdev. > > As the device node is registered before the subdev core::s_config > function is called, return -EGAIN on open until initialization > completes. The only reason we have s_config is for old i2c drivers that need to be supported i

Re: [RFC/PATCH 1/6] v4l: subdev: Don't require core operations

2010-07-07 Thread Hans Verkuil
> There's no reason to require subdevices to implement the core > operations. Remove the check for non-NULL core operations when > initializing the subdev. > > Signed-off-by: Laurent Pinchart Reviewed-by: Hans Verkuil Yeah, that test was a bit overkill. Regards, Hans > --- > inclu

[RFC/PATCH 5/6] v4l: subdev: Events support

2010-07-07 Thread Laurent Pinchart
From: Sakari Ailus Provide v4l2_subdevs with v4l2_event support. Subdev drivers only need very little to support events. Signed-off-by: Sakari Ailus Signed-off-by: David Cohen Signed-off-by: Laurent Pinchart --- Documentation/video4linux/v4l2-framework.txt | 18 +++ drivers/media/video

[RFC/PATCH 4/6] v4l: subdev: Control ioctls support

2010-07-07 Thread Laurent Pinchart
Pass the control-related ioctls to the subdev driver through the core operations. Signed-off-by: Laurent Pinchart --- Documentation/video4linux/v4l2-framework.txt | 24 drivers/media/video/v4l2-subdev.c| 24 2 files changed, 48 in

[RFC/PATCH 6/6] v4l: subdev: Generic ioctl support

2010-07-07 Thread Laurent Pinchart
Instead of returning an error when receiving an ioctl call with an unsupported command, forward the call to the subdev core::ioctl handler. Signed-off-by: Laurent Pinchart --- Documentation/video4linux/v4l2-framework.txt |5 + drivers/media/video/v4l2-subdev.c|2 +- 2 fil

[RFC/PATCH 3/6] v4l: subdev: Uninline the v4l2_subdev_init function

2010-07-07 Thread Laurent Pinchart
The function isn't small or performance sensitive enough to be inlined. Signed-off-by: Laurent Pinchart --- drivers/media/video/v4l2-subdev.c | 14 ++ include/media/v4l2-subdev.h | 15 ++- 2 files changed, 16 insertions(+), 13 deletions(-) diff --git a/drivers/

[RFC/PATCH 2/6] v4l: subdev: Add device node support

2010-07-07 Thread Laurent Pinchart
Create a device node named subdevX for every registered subdev. As the device node is registered before the subdev core::s_config function is called, return -EGAIN on open until initialization completes. Signed-off-by: Laurent Pinchart Signed-off-by: Vimarsh Zutshi --- drivers/media/video/Make

[RFC/PATCH 0/6] V4L2 subdev userspace API

2010-07-07 Thread Laurent Pinchart
Hi everybody, Here are 6 patches that add a userspace API to the V4L2 subdevices. The API has been developed to support the media controller and the OMAP3 ISP driver. A few people have shown interest in the subdev userspace API already. As the patches are not dependent on the media controller its

[RFC/PATCH 1/6] v4l: subdev: Don't require core operations

2010-07-07 Thread Laurent Pinchart
There's no reason to require subdevices to implement the core operations. Remove the check for non-NULL core operations when initializing the subdev. Signed-off-by: Laurent Pinchart --- include/media/v4l2-subdev.h |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/include

Re: Status of the patches under review at LMML (60 patches)

2010-07-07 Thread Sven Barth
Hi! Am 06.07.2010 15:06, schrieb Mauro Carvalho Chehab: >== Waiting for Mike Isely review == > > Apr,25 2010: Problem with cx25840 and Terratec Grabster AV400 http://patchwork.kernel.org/patch/94960 Is Mike really the maintainer of the cx25840 module and not only of

Re: Microsoft VX-1000 Microphone Drivers Crash in x86_64

2010-07-07 Thread Jean-Francois Moine
On Wed, 7 Jul 2010 02:57:54 -0400 Kyle Baker wrote: > If the microphone works when used alone (with the sound recorder > application) and video works in Cheese, why would they not work > together at the same time? > > I'm looking through the sonixj.c code to see if I can find where its > breakin