On Tue, 6 Jul 2010, Mauro Carvalho Chehab wrote: > This is the summary of the patches that are currently under review at > Linux Media Mailing List <linux-media@vger.kernel.org>. > Each patch is represented by its submission date, the subject (up to 70 > chars) and the patchwork link (if submitted via email). > > P.S.: This email is c/c to the developers where some action is expected. > If you were copied, please review the patches, acking/nacking or > submitting an update. >
[...] > == Waiting for Mike Isely <is...@isely.net> review == > > Apr,25 2010: Problem with cx25840 and Terratec Grabster AV400 > http://patchwork.kernel.org/patch/94960 > These are cx25840 patches and I'm not the maintainer of that module. I can't really speak to the correctness of the changes. Best I can do is to try the patch with a few pvrusb2-driven devices here that use the cx25840 module. I've done that now (HVR-1950 and PVR-USB2 model 24012) and everything continues to work fine. Note, this part of the patch: int hw_fix = state->pvr150_workaround; - - if (std == V4L2_STD_NTSC_M_JP) { + if (std == V4L2_STD_NTSC_M_JP) { /* Japan uses EIAJ audio standard */ cx25840_write(client, 0x808, hw_fix ? 0x2f : 0xf7); } else if (std == V4L2_STD_NTSC_M_KR) { is a whitespace-only change which introduces a bogus tab and messes up the indentation of that opening if-statement. It should probably be removed from the patch. Other than that, you have my ack: Acked-By: Mike Isely <is...@pobox.com> -Mike -- Mike Isely isely @ isely (dot) net PGP: 03 54 43 4D 75 E5 CC 92 71 16 01 E2 B5 F5 C1 E8 -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
