Re: [PATCH v2] selftests/user_events: Fix failures when user_events is not installed

2023-09-15 Thread Shuah Khan
On 9/12/23 11:46, Steven Rostedt wrote: On Tue, 12 Sep 2023 10:12:34 -0700 Beau Belgrave wrote: I guess I was wrong and some people do care ;-) -- Steve It looks like this change got applied [1] to the fixes branch of linux-kselftest. I can either send a V3 with this addressed or build a p

Re: [PATCH v2] selftests/user_events: Fix failures when user_events is not installed

2023-09-15 Thread Shuah Khan
On 9/15/23 09:54, Shuah Khan wrote: On 9/12/23 11:46, Steven Rostedt wrote: On Tue, 12 Sep 2023 10:12:34 -0700 Beau Belgrave wrote: I guess I was wrong and some people do care ;-) -- Steve It looks like this change got applied [1] to the fixes branch of linux-kselftest. I can either send

[GIT PULL] Kselftest second fixes update for Linux 6.6-rc2

2023-09-15 Thread Shuah Khan
Hi Linus, Please pull the following second Kselftest fixes update for Linux 6.6-rc2. This kselftest fixes update for Linux 6.6-rc2 consists of important fixes to user_events test and ftrace test. user_events test has been enabled for default run in Linux 6.6-rc1. The following fixes are for bug

Re: [PATCH] selftests: uevent filtering: fix return on error in uevent_listener

2023-09-18 Thread Shuah Khan
On 9/16/23 10:11, Javier Carrasco wrote: Assign the error value to the real returned variable fret. The ret variable is used to check function return values and assigning values to it on error has no effect as it is an unused value. Signed-off-by: Javier Carrasco --- tools/testing/selftests/u

Re: [PATCH v2 2/3] selftests/hid: do not manually call headers_install

2023-09-18 Thread Shuah Khan
ntinues to compile and run though. Acked-by: Shuah Khan thanks, -- Shuah

Re: [PATCH V7 0/7] amd-pstate preferred core

2023-09-18 Thread Shuah Khan
On 9/18/23 02:14, Meng Li wrote: Hi all: The core frequency is subjected to the process variation in semiconductors. Not all cores are able to reach the maximum frequency respecting the infrastructure limits. Consequently, AMD has redefined the concept of maximum frequency of a part. This means

[GIT PULL] Kselftest fixes update for Linux 6.6-rc4

2023-09-26 Thread Shuah Khan
Hi Linus, Please pull the following Kselftest fixes update for Linux 6.6-rc4. This kselftest fixes update for Linux 6.6-rc4 consists of one single fix to unmount tracefs when test created mount. diff is attached. thanks. -- Shuah ---

Re: [PATCH] selftests/rseq: fix kselftest Clang build warnings

2023-09-26 Thread Shuah Khan
On 9/26/23 13:02, Mathieu Desnoyers wrote: On 9/26/23 08:20, Justin Stitt wrote: Ping. Looking to get this patch and [1] slated for 6.7 which fixes some kselftest builds on older kernels. On Wed, Sep 13, 2023 at 6:03 AM Justin Stitt wrote: When building with Clang, I am getting many warning

Re: [PATCH] selftests: Fix wrong TARGET in kselftest top level Makefile

2023-09-26 Thread Shuah Khan
On 9/26/23 12:03, Juntong Deng wrote: The 'uevents' subdirectory does not exist in tools/testing/selftests/ and adding 'uevents' to the TARGETS list results in the following error: make[1]: Entering directory 'xx/tools/testing/selftests/uevents' make[1]: *** No targets specified and no makefile

Re: [PATCH] selftests/rseq: fix kselftest Clang build warnings

2023-09-26 Thread Shuah Khan
On 9/26/23 14:39, Shuah Khan wrote: On 9/26/23 13:02, Mathieu Desnoyers wrote: On 9/26/23 08:20, Justin Stitt wrote: Ping. Looking to get this patch and [1] slated for 6.7 which fixes some kselftest builds on older kernels. On Wed, Sep 13, 2023 at 6:03 AM Justin Stitt wrote: When building

Re: [PATCH v2] Added missing TARGETS in kselftest top level Makefile

2023-10-02 Thread Shuah Khan
On 10/2/23 05:46, Abhinav wrote: Some tests like dma, ia64, etc. were not present in top level of selftest Makefile, so when someone ran 'make run_tests' they would miss these tests. This patches adds those left out tests. Signed-off-by: Abhinav --- I removed sched, safesetid and filelock from

Re: [PATCH 2/2] selftests/user_events: Fix abi_test for BE archs

2023-10-04 Thread Shuah Khan
On 10/3/23 18:59, Steven Rostedt wrote: Note, this doesn't seem to apply to my tree so I only added the first patch. I think this needs to go through Shuah's tree. -- Steve Yes. I sent a fix up for rc4 - I can pull these two patches into linux-kselftest next Steve! Does that work for you?

[GIT PULL] Kselftest fixes update for Linux 6.6-rc5

2023-10-04 Thread Shuah Khan
Hi Linus, Please pull the following Kselftest fixes update for Linux 6.6-rc5. This kselftest fixes update for Linux 6.6-rc5 consists of one single fix to Makefile to fix the incorrect TARGET name for uevent test. diff is attached. thanks. -- Shuah -

Re: [PATCH 2/2] selftests/user_events: Fix abi_test for BE archs

2023-10-04 Thread Shuah Khan
On 10/4/23 09:14, Steven Rostedt wrote: On Wed, 4 Oct 2023 09:10:52 -0600 Shuah Khan wrote: On 10/3/23 18:59, Steven Rostedt wrote: Note, this doesn't seem to apply to my tree so I only added the first patch. I think this needs to go through Shuah's tree. -- Steve Yes. I

Re: [PATCH 2/2] selftests/user_events: Fix abi_test for BE archs

2023-10-05 Thread Shuah Khan
On 10/4/23 10:38, Shuah Khan wrote: On 10/4/23 09:14, Steven Rostedt wrote: On Wed, 4 Oct 2023 09:10:52 -0600 Shuah Khan wrote: On 10/3/23 18:59, Steven Rostedt wrote: Note, this doesn't seem to apply to my tree so I only added the first patch. I think this needs to go through Shuah&#

Re: [PATCH 1/6] selftests: capabilities: remove duplicate unneeded defines

2023-10-06 Thread Shuah Khan
On 10/6/23 04:09, Muhammad Usama Anjum wrote: On 10/6/23 1:33 PM, Muhammad Usama Anjum wrote: On 9/4/23 3:48 PM, Muhammad Usama Anjum wrote: On 8/22/23 1:57 PM, Muhammad Usama Anjum wrote: Hi Shuah, Christian Brauner had picked [PATCH 4/6]. Others are still not picked. Please have a look. Sh

Re: [PATCH v4 0/8] Add printf attribute to kselftest functions

2023-10-09 Thread Shuah Khan
On 10/9/23 04:28, Maciej Wieczor-Retman wrote: Kselftest.h declares many variadic functions that can print some formatted message while also executing selftest logic. These declarations don't have any compiler mechanism to verify if passed arguments are valid in comparison with format specifiers

Re: [PATCH v5 1/8] selftests: Add printf attribute to kselftest prints

2023-10-12 Thread Shuah Khan
On 10/12/23 01:32, Maciej Wieczór-Retman wrote: On 2023-10-11 at 13:40:48 -0600, Shuah wrote: On 10/11/23 02:23, Maciej Wieczor-Retman wrote: Kselftest header defines multiple variadic functions that use printf along with other logic. There is no format checking for the variadic functions that

Re: [PATCH v4 0/2] Fix issues observed in selftests/amd-pstate

2023-10-16 Thread Shuah Khan
On 10/12/23 03:32, Swapnil Sapkal wrote: This series fixes issues observed with selftests/amd-pstate while running performance comparison tests with different governors. First patch changes relative paths with absolute paths and also change it with correct paths wherever it is broken. The second

Re: [PATCH v2] selftests/x86/lam: Zero out buffer for readlink()

2023-10-16 Thread Shuah Khan
On 10/16/23 02:47, kirill.shute...@linux.intel.com wrote: On Mon, Oct 16, 2023 at 02:24:46PM +0800, Binbin Wu wrote: Zero out the buffer for readlink() since readlink() does not append a terminating null byte to the buffer. Also change the buffer length passed to readlink() to 'PATH_MAX - 1' to

Re: [PATCH] selftests:modify the incorrect print format

2023-10-16 Thread Shuah Khan
On 10/15/23 20:50, zhujun2 wrote: printf %d in format string requires 'int' but the argument type is 'unsigned int' This line to long. Character limit is < 75/line. How did you find this problem? Please add the details to the commit log. Signed-off-by: zhujun2 --- thanks, -- Shuah

Re: [PATCH v2] selftests: futex: remove duplicate unneeded defines

2023-10-16 Thread Shuah Khan
On 10/6/23 03:55, Muhammad Usama Anjum wrote: Kselftests are kernel tests and must be build with kernel headers from same source version. The kernel headers are already being included correctly in futex selftest Makefile with the help of KHDR_INCLUDE. In this patch, only the dead code is being re

Re: [PATCH] selftests/efivarfs: create-read: fix a resource leak

2023-10-17 Thread Shuah Khan
On 10/16/23 20:33, zhujun2 wrote: The opened file should be closed in main(), otherwise resource leak will occur Did you find this by code reading or by any other means. Please add how you found the problem to the change log. Signed-off-by: zhujun2 --- tools/testing/selftests/efivarfs/cre

Re: [PATCH] selftests:modify the incorrect print format

2023-10-17 Thread Shuah Khan
On 10/16/23 20:08, zhujun2 wrote: when the argument type is 'unsigned int',printf '%u' in format string Please add how you found the problem to the commit log. Signed-off-by: zhujun2 thanks, -- Shuah

Re: [PATCH v3] selftests/user_events: Fix abi_test for BE archs

2023-10-17 Thread Shuah Khan
On 10/17/23 14:38, Steven Rostedt wrote: On Thu, 5 Oct 2023 21:57:12 + Beau Belgrave wrote: The abi_test currently uses a long sized test value for enablement checks. On LE this works fine, however, on BE this results in inaccurate assert checks due to a bit being used and assuming it's v

Re: [PATCH -next 0/2] add loongarch and riscv support for kprobe args test

2023-10-17 Thread Shuah Khan
On 10/17/23 11:37, Steven Rostedt wrote: On Tue, 15 Aug 2023 16:59:10 +0800 Yu Liao wrote: Yu Liao (2): selftests/ftrace: add loongarch support for kprobe args char tests selftests/ftrace: Add riscv support for kprobe arg tests .../selftests/ftrace/test.d/kprobe/kprobe_args_char.tc

Re: [PATCH] selftests/clone3: Report descriptive test names

2023-10-18 Thread Shuah Khan
On 10/17/23 17:01, Mark Brown wrote: The clone3() selftests currently report test results in a format that does not mesh entirely well with automation. They log output for each test such as: # [1382411] Trying clone3() with flags 0 (size 0) # I am the parent (1382411). My child's pid is 13

Re: [PATCH v2 1/1] selftests/resctrl: Fix MBM test failure when MBA unavailable

2023-10-18 Thread Shuah Khan
On 10/18/23 02:10, Ilpo Järvinen wrote: On Wed, 18 Oct 2023, Ilpo Järvinen wrote: Commit 20d96b25cc4c ("selftests/resctrl: Fix schemata write error check") exposed a problem in feature detection logic in MBM selftest. If schemata does not support MB:x=x entries, the schemata write to initialize

Re: [PATCH] selftests/efivarfs: create-read: fix a resource leak

2023-10-18 Thread Shuah Khan
On 10/17/23 19:59, zhujun2 wrote: The opened file should be closed in main(), otherwise resource leak will occur that this problem was discovered by code reading Signed-off-by: zhujun2 --- tools/testing/selftests/efivarfs/create-read.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/to

Re: [PATCH] selftests:modify the incorrect print format

2023-10-18 Thread Shuah Khan
On 10/17/23 09:54, Shuah Khan wrote: On 10/16/23 20:08, zhujun2 wrote: when the argument type is 'unsigned int',printf '%u' in format string Please add how you found the problem to the commit log. Signed-off-by: zhujun2 thanks, -- Shuah Applied to linux-kselftes

Re: [PATCH v2] selftests: futex: remove duplicate unneeded defines

2023-10-18 Thread Shuah Khan
On 10/16/23 15:43, Peter Zijlstra wrote: On Mon, Oct 16, 2023 at 01:21:20PM -0600, Shuah Khan wrote: On 10/6/23 03:55, Muhammad Usama Anjum wrote: Kselftests are kernel tests and must be build with kernel headers from same source version. The kernel headers are already being included correctly

[GIT PULL] Kselftest fixes update for Linux 6.6-rc7

2023-10-20 Thread Shuah Khan
Hi Linus, Please pull the following Kselftest fixes update for Linux 6.6-rc7. This Kselftest update for Linux 6.6-rc7 consists of one single fix to assert check in user_events abi_test to properly check bit value on Big Endian architectures. The current code treats the bit values as Little Endia

Re: Purpose of gen_tar

2023-10-25 Thread Shuah Khan
On 10/24/23 12:34, Bird, Tim wrote: -Original Message- From: Marcos Paulo de Souza ... Per the kselftests documentation[1], the gen_tar target is used to package the tests to run "on different systems". But what if the different system has different libraries/library versions? Woul

[GIT PULL] KUnit next update for Linux 6.7-rc1

2023-11-01 Thread Shuah Khan
Hi Linus, Please pull the following KUnit next update for Linux 6.7-rc1. This kunit update for Linux 6.7-rc1 consists of: -- string-stream testing enhancements -- several fixes memory leaks -- fix to reset status during parameter handling diff is attached. thanks, -- Shuah --

Re: [PATCH] selftests: capabilities: namespace create varies for root and normal user

2023-11-07 Thread Shuah Khan
On 9/29/23 06:53, Swarup Laxman Kotiaklapudi wrote: Change namespace creation for root and non-root user differently in create_and_enter_ns() function Sorry for the delay on reviewing this. Can you tell me more about why this change is needed and include it in the change log. thanks, -- Shua

Re: [PATCH v6] selftests: rtc: Fixes rtctest error handling.

2023-11-07 Thread Shuah Khan
On 10/7/23 09:43, Atul Kumar Pant wrote: On Sat, Sep 23, 2023 at 11:06:58PM +0530, Atul Kumar Pant wrote: On Thu, Aug 17, 2023 at 02:44:01PM +0530, Atul Kumar Pant wrote: Adds a check to verify if the rtc device file is valid or not and prints a useful error message if the file is not accessibl

[GIT PULL] KUnit fixes update for Linux 6.7-rc4

2023-11-30 Thread Shuah Khan
Hi Linus, Please pull the following KUnit fixes update for Linux 6.7-rc4. This KUnit fixes update for Linux 6.7-rc4 consists of three fixes to warnings and run-time test behavior. With these fixes, test suite counter will be reset correctly before running tests, kunit will warn if tests are too

Re: [PATCH] selftests:proc: Resolve 'Unused Result' Warning from proc-empty-vm.c

2023-11-30 Thread Shuah Khan
On 11/28/23 20:45, angquan yu wrote: From: angquan yu In tools/testing/selftests/proc/proc-empty->because the return value of a write call was being ignored. This call was partof a conditional debugging block (if (0) { ... }), which meant it would neveractually execute. This patch removes the

Re: [PATCH] selftests/breakpoints: Fix format specifier in ksft_print_msg in step_after_suspend_test.c

2023-11-30 Thread Shuah Khan
On 11/28/23 14:48, angquan yu wrote: From: angquan yu In the function 'tools/testing/selftests/breakpoints/run_test' within step_after_suspend_test.c, the ksft_print_msg function call incorrectly used '$s' as a format specifier. This commit corrects this typo to use the proper '%s' format speci

Re: [PATCH] selftests:breakpoints: Fix Format String Warning in breakpoint_test

2023-11-30 Thread Shuah Khan
On 11/28/23 20:57, angquan yu wrote: From: angquan yu This commit resolves a compiler warning regardingthe use of non-literal format strings in breakpoint_test.c. The functions `ksft_test_result_pass` and `ksft_test_result_fail` were previously called with a variable `msg` directly, which coul

Re: [PATCH 0/3] kselftest/vDSO: Output formatting cleanups for vdso_test_abi

2023-11-30 Thread Shuah Khan
On 11/23/23 03:45, Mark Brown wrote: These patches update the output of the vdso_test_abi test program to bring it into line with expected KTAP usage, the main one being the first patch which ensures we log distinct test names for each reported result making it much easier for automated systems t

Re: [PATCH v3 3/3] selftests: livepatch: Test livepatching a heavily called syscall

2023-11-30 Thread Shuah Khan
On 10/31/23 15:10, Marcos Paulo de Souza wrote: The test proves that a syscall can be livepatched. It is interesting because syscalls are called a tricky way. Also the process gets livepatched either when sleeping in the userspace or when entering or leaving the kernel space. The livepatch is a

Re: [PATCH v2] selftests: prctl: Add prctl test for PR_GET_NAME

2023-11-30 Thread Shuah Khan
On 11/11/23 12:23, Osama Muhammad wrote: Signed-off-by: Osama Muhammad --- .../selftests/prctl/set-process-name.c| 32 +++ 1 file changed, 32 insertions(+) Applied to linux-kselftest next for Linux 6.8-rc1. thanks, -- Shuah

Re: [PATCH v2] selftests: capabilities: namespace create varies for root and normal user

2023-11-30 Thread Shuah Khan
On 11/11/23 10:38, Swarup Laxman Kotiaklapudi wrote: This patchset fixes TODO: "If we're already root, we could skip creating the userns." Change namespace creation for root and non-root user differently in create_and_enter_ns() function in this file: tools/testing/selftests/capabilities/test_ex

Re: [PATCH v1] selftests: cgroup: Fixes code style errors

2023-11-30 Thread Shuah Khan
On 11/6/23 11:11, Atul Kumar Pant wrote: Fixes following checkpatch.pl issues: ERROR: do not use assignment in if condition ERROR: Macros starting with if should be enclosed by a do - while Signed-off-by: Atul Kumar Pant --- tools/testing/selftests/cgroup/cgroup_util.c | 14 -- t

Re: [PATCH v3 3/3] selftests: livepatch: Test livepatching a heavily called syscall

2023-12-01 Thread Shuah Khan
On 12/1/23 06:13, Marcos Paulo de Souza wrote: On Thu, Nov 30, 2023 at 04:24:26PM -0700, Shuah Khan wrote: Missing module name? Is there a reason to not name this module? Can you please elaborate? This new module use the same MODULE_ macros used by the current livepatch selftests. What do

Re: [PATCH v3 3/3] selftests: livepatch: Test livepatching a heavily called syscall

2023-12-05 Thread Shuah Khan
On 12/5/23 05:52, mpdeso...@suse.com wrote: On Fri, 2023-12-01 at 16:38 +, Shuah Khan wrote: 0003-selftests-livepatch-Test-livepatching-a-heavily-call.patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see

Re: [PATCH v3 3/3] selftests: livepatch: Test livepatching a heavily called syscall

2023-12-11 Thread Shuah Khan
On 12/6/23 07:39, Miroslav Benes wrote: Hi, On Tue, 5 Dec 2023, Shuah Khan wrote: On 12/5/23 05:52, mpdeso...@suse.com wrote: On Fri, 2023-12-01 at 16:38 +, Shuah Khan wrote: 0003-selftests-livepatch-Test-livepatching-a-heavily-call.patch has style problems, please review. NOTE: If

Re: [PATCH v3 2/3] livepatch: Move tests from lib/livepatch to selftests/livepatch

2023-12-11 Thread Shuah Khan
On 12/7/23 12:19, mpdeso...@suse.com wrote: On Thu, 2023-12-07 at 10:20 -0500, Joe Lawrence wrote: On 12/6/23 10:05, Miroslav Benes wrote: On Fri, 1 Dec 2023, Joe Lawrence wrote: On Tue, Oct 31, 2023 at 06:10:52PM -0300, Marcos Paulo de Souza wrote: The modules are being moved from lib/livep

Re: [PATCH v3 3/3] selftests: livepatch: Test livepatching a heavily called syscall

2023-12-18 Thread Shuah Khan
On 12/15/23 13:36, Joe Lawrence wrote: On 12/11/23 16:53, Shuah Khan wrote: On 12/6/23 07:39, Miroslav Benes wrote: Hi, On Tue, 5 Dec 2023, Shuah Khan wrote: On 12/5/23 05:52, mpdeso...@suse.com wrote: On Fri, 2023-12-01 at 16:38 +, Shuah Khan wrote: 0003-selftests-livepatch-Test

Re: [PATCH v4] tracing/selftests: Add test to test the trace_marker

2023-12-18 Thread Shuah Khan
good to me. and tested. Acked-by: Masami Hiramatsu (Google) Tested-by: Masami Hiramatsu (Google) Assuming this is going through tracing: Acked-by: Shuah Khan If not just let me know, I will take this through kselftest tree. thanks, -- Shuah

Re: [PATCH 0/6] Add some more cfg80211 and mac80211 kunit tests

2023-12-21 Thread Shuah Khan
On 12/21/23 12:39, Johannes Berg wrote: This patchset adds a couple of helpers for kunit as well as tests for cfg80211 and mac80211 that use them. I can take this through the wireless tree, but then I'd like to have ACKs from kunit folks for the kunit patches: We have run into conflicts in

Re: [PATCH RESEND v4 0/3] livepatch: Move modules to selftests and add a new test

2023-12-21 Thread Shuah Khan
On 12/21/23 05:17, Marcos Paulo de Souza wrote: On Wed, 2023-12-20 at 13:53 -0300, Marcos Paulo de Souza wrote: Changes in v4: * Documented how to compile the livepatch selftests without running the   tests (Joe) * Removed the mention to lib/livepatch on MAINTAINERS file, reported by   checkpa

Re: [PATCH v2] selftests: uevent: use shared makefile library

2023-12-21 Thread Shuah Khan
On 12/21/23 13:49, Antonio Terceiro wrote: This makes the uevent selftests build not write to the source tree unconditionally, as that breaks out of tree builds when the source tree is read-only. It also avoids leaving a git repository in a dirty state after a build. Why can't you do that usin

Re: [PATCH 0/6] Add some more cfg80211 and mac80211 kunit tests

2023-12-21 Thread Shuah Khan
On 12/21/23 13:40, Johannes Berg wrote: On Thu, 2023-12-21 at 13:06 -0700, Shuah Khan wrote: On 12/21/23 12:39, Johannes Berg wrote: This patchset adds a couple of helpers for kunit as well as tests for cfg80211 and mac80211 that use them. I can take this through the wireless tree, but then

Re: [PATCH 0/6] Add some more cfg80211 and mac80211 kunit tests

2023-12-22 Thread Shuah Khan
huah decide. Thank you David for the reviews. johannes, Please take these through wireless - makes it easier for all of us. Acked-by: Shuah Khan thanks, -- Shuah

Re: [PATCH v3] tracing/selftests: Add ownership modification tests for eventfs

2023-12-22 Thread Shuah Khan
On 12/21/23 19:16, Steven Rostedt wrote: Shuah, This patch has no dependencies. You can take it through your tree for the next merge window if you want. If not, I can take it. Tried to apply this and seeing a couple of issues: -- missing SPDX -- this file has executable permission set unlike

Re: [PATCH v4] tracing/selftests: Add ownership modification tests for eventfs

2023-12-22 Thread Shuah Khan
by: Masami Hiramatsu (Google) Signed-off-by: Steven Rostedt (Google) --- Changes since v3: https://lore.kernel.org/linux-trace-kernel/20231221211229.13398...@gandalf.local.home - Added missing SPDX and removed exec permission from file (Shuah Khan) Thank you. Applied to linux-kselftest next

Re: [PATCH RESEND v4 1/3] kselftests: lib.mk: Add TEST_GEN_MODS_DIR variable

2024-01-03 Thread Shuah Khan
On 1/2/24 15:31, Joe Lawrence wrote: On Wed, Dec 20, 2023 at 01:53:12PM -0300, Marcos Paulo de Souza wrote: Add TEST_GEN_MODS_DIR variable for kselftests. It can point to a directory containing kernel modules that will be used by selftest scripts. The modules are built as external modules for t

[GIT PULL] nolibc changes for Linux 6.8-rc1

2024-01-08 Thread Shuah Khan
Hi Linus, Please pull the nolibc update for Linux 6.8-rc1. This nolibc update for Linux 6.8-rc1 consists of: * Support for PIC mode on MIPS. * Support for getrlimit()/setrlimit(). * Replace some custom declarations with UAPI includes. * A new script "run-tests.sh" to run the testsuite over diff

[GIT PULL] KUnit next update for Linux 6.8-rc1

2024-01-09 Thread Shuah Khan
Hi Linus, Please pull the following KUnit next update for Linux 6.8-rc1. This KUnit update for Linux 6.8-rc1 consists of: - a new feature that adds APIs for managing devices introducing a set of helper functions which allow devices (internally a struct kunit_device) to be created and manage

[GIT PULL] Kselftest next update for Linux 6.8-rc1

2024-01-09 Thread Shuah Khan
Hi Linus, Please pull the following Kselftest update for Linux 6.8-rc1. This kselftest update for Linux 6.8-rc1 consists of enhancements to reporting test results, fixes to root and user run behavior and fixing ksft_print_msg() calls. diff is attached. thanks, -- Shuah ---

Re: [PATCH RESEND v4 1/3] kselftests: lib.mk: Add TEST_GEN_MODS_DIR variable

2024-01-09 Thread Shuah Khan
On 1/8/24 10:13, Marcos Paulo de Souza wrote: On Wed, 2024-01-03 at 15:09 -0700, Shuah Khan wrote: Copying source files and object files doesn't sound right. This isn't how the ksleftest installs work. Let's fix this. Hi Shuah, what do you think about the proposed solu

Re: [PATCH v6 1/3] kselftests: lib.mk: Add TEST_GEN_MODS_DIR variable

2024-01-22 Thread Shuah Khan
On 1/12/24 10:43, Marcos Paulo de Souza wrote: Add TEST_GEN_MODS_DIR variable for kselftests. It can point to a directory containing kernel modules that will be used by selftest scripts. The modules are built as external modules for the running kernel. As a result they are always binary compatib

Re: [PATCH v6 2/3] livepatch: Move tests from lib/livepatch to selftests/livepatch

2024-01-22 Thread Shuah Khan
On 1/22/24 05:55, Marcos Paulo de Souza wrote: On Fri, 2024-01-19 at 14:19 +0100, Alexander Gordeev wrote: On Fri, Jan 19, 2024 at 02:11:01PM +0100, Alexander Gordeev wrote: FWIW, for s390 part: Alexander Gordeev Acked-by: Alexander Gordeev Thanks Alexandre and Joe for testing and suppor

Re: [PATCH v6 1/3] kselftests: lib.mk: Add TEST_GEN_MODS_DIR variable

2024-01-22 Thread Shuah Khan
On 1/22/24 10:37, Marcos Paulo de Souza wrote: On Mon, 2024-01-22 at 10:15 -0700, Shuah Khan wrote: On 1/12/24 10:43, Marcos Paulo de Souza wrote: Add TEST_GEN_MODS_DIR variable for kselftests. It can point to a directory containing kernel modules that will be used by selftest scripts. The

Re: [PATCH v2 2/2] kselftest/seccomp: Report each expectation we assert as a KTAP test

2024-01-22 Thread Shuah Khan
On 1/22/24 09:04, Mark Brown wrote: The seccomp benchmark test makes a number of checks on the performance it measures and logs them to the output but does so in a custom format which none of the automated test runners understand meaning that the chances that anyone is paying attention are slim.

Re: [PATCH v3 2/2] kselftest/seccomp: Report each expectation we assert as a KTAP test

2024-01-23 Thread Shuah Khan
On 1/22/24 14:08, Mark Brown wrote: The seccomp benchmark test makes a number of checks on the performance it measures and logs them to the output but does so in a custom format which none of the automated test runners understand meaning that the chances that anyone is paying attention are slim.

Re: [PATCH v4 0/2] kselftest/seccomp: Convert to KTAP output

2024-01-25 Thread Shuah Khan
On 1/24/24 06:00, Mark Brown wrote: Currently the seccomp benchmark selftest produces non-standard output, meaning that while it makes a number of checks of the performance it observes this has to be parsed by humans. This means that automated systems running this suite of tests are almost certa

[GIT PULL] Kselftest fixes update for Linux 6.8-rc3

2024-01-30 Thread Shuah Khan
Hi Linus, Please pull the following kselftest fixes update for Linux 6.8-rc3. This kselftest fixes update for Linux 6.8-rc3 consists of three fixes to livepatch, rseq, and seccomp tests. diff is attached thanks, -- Shuah The fol

[GIT PULL] KUnit fixes update for Linux 6.8-rc3

2024-01-30 Thread Shuah Khan
Hi Linus, Please pull the following KUnit fixes update for Linux 6.8-rc3. This kunit fixes update for Linux 6.8-rc3 consists of NULL vs IS_ERR() bug fixes, documentation update, MAINTAINERS file update to add Rae Moar as a reviewer, and a fix to run test suites only after module initialization c

[GIT PULL] KUnit fixes update for Linux 6.8-rc5

2024-02-13 Thread Shuah Khan
Hi Linus, Please pull the following KUnit fixes update for Linux 6.8-rc5. This KUnit update for Linux 6.8-rc5 consists of one important fix to unregister kunit_bus when KUnit module is unloaded. Not doing so causes an error when KUnit module tries to re-register the bus when it gets reloaded. d

Re: [PATCH] selftests: fuxex: Report a unique test name per run of futex_requeue_pi

2024-02-19 Thread Shuah Khan
On 2/19/24 08:58, Thomas Gleixner wrote: On Tue, Feb 13 2024 at 19:06, Mark Brown wrote: The futex_requeue_pi test program is run a number of times with different options to provide multiple test cases. Currently every time it runs it reports the result with a consistent string, meaning that aut

Re: [PATCH] selftest/ftrace: fix typo in ftracetest script

2024-02-20 Thread Shuah Khan
On 1/31/24 07:52, Masami Hiramatsu (Google) wrote: Hi, On Mon, 29 Jan 2024 21:58:07 +0530 Kousik Sanagavarapu wrote: Fix a typo in ftracetest script which is run when running the kselftests for ftrace. s/faii/fail Thanks, this looks obvious typo. Signed-off-by: Kousik Sanagavarapu Ac

Re: [PATCH] selftests: ftrace: fix typo in test description

2024-02-20 Thread Shuah Khan
On 1/31/24 08:13, Masami Hiramatsu (Google) wrote: On Wed, 31 Jan 2024 14:33:06 +0100 Ali Zahraee wrote: The typo in the description shows up in test logs and output. This patch submission is part of my application to the Linux Foundation mentorship program: Linux kernel Bug Fixing Spring Unpa

Re: [PATCH] selftests: Move KTAP bash helpers to selftests common folder

2024-02-20 Thread Shuah Khan
On 2/12/24 08:01, Nícolas F. R. A. Prado wrote: On Tue, Jan 02, 2024 at 03:15:28PM +0100, Laura Nao wrote: Move bash helpers for outputting in KTAP format to the common selftests folder. This allows kselftests other than the dt one to source the file and make use of the helper functions. Define

Re: [PATCH 0/4] selftests: ktap_helpers: Add some missing helpers

2024-02-20 Thread Shuah Khan
On 1/31/24 15:02, Nícolas F. R. A. Prado wrote: This series adds a few missing functions to the shell KTAP helpers script which are present in the C counterpart, kselftest.h. This series depends on "selftests: Move KTAP bash helpers to selftests common folder" https://lore.kernel.org/all/2024010

Re: Linux 6.8-rc5

2024-02-20 Thread Shuah Khan
On 2/20/24 13:16, Linus Torvalds wrote: On Tue, 20 Feb 2024 at 11:57, Linus Torvalds wrote: It turns out that that commit is buggy for another reason, but it's hidden by the fact that apparently KUNIT_ASSERT_FALSE_MSG() doesn't check the format string. The fix for that is this: --- a/inc

Re: [PATCH v4 0/3] selftests: add missing gitignore files and include generated objects

2024-02-20 Thread Shuah Khan
it is not always followed as desired. After adding these .gitignore files and including the generated objects, the working tree appears clean again. To: Shuah Khan To: SeongJae Park Cc: linux-ker...@vger.kernel.org Cc: linux-kselftest@vger.kernel.org Signed-off-by: Javier Carrasco Changes in

Re: [PATCH] selftest: ftrace: fix minor typo in log

2024-02-20 Thread Shuah Khan
On 2/11/24 04:18, Vincenzo Mezzela wrote: Resolves a spelling error in the test log, preventing potential confusion. Signed-off-by: Vincenzo Mezzela --- It is submitted as part of my application to the "Linux Kernel Bug Fixing Spring Unpaid 2024" mentorship program of the Linux Foundation.

Re: [PATCH RESEND] selftests/ftrace: Add test to exercize function tracer across cpu hotplug

2024-02-20 Thread Shuah Khan
On 2/16/24 07:23, Steven Rostedt wrote: On Fri, 16 Feb 2024 15:26:26 +0530 Naveen N Rao wrote: Add a test to exercize cpu hotplug with the function tracer active to ensure that sensitive functions in idle path are excluded from being traced. This helps catch issues such as the one fixed by com

Re: [PATCH] tools: selftests: Remove unnecessary semicolons

2024-02-20 Thread Shuah Khan
On 2/13/24 05:23, Thorsten Blum wrote: Remove unnecessary semicolons reported by Coccinelle/coccicheck and the semantic patch at scripts/coccinelle/misc/semicolon.cocci. Signed-off-by: Thorsten Blum --- tools/testing/selftests/bpf/benchs/bench_local_storage_create.c | 2 +- tools/testing/sel

Re: [PATCH 08/10] selftests/sched: Migrate cs_prctl_test to kselfttest

2024-02-20 Thread Shuah Khan
: pass:17 fail:0 xfail:0 xpass:0 skip:0 error:0 Signed-off-by: Joel Fernandes (Google) Reviewed-by: Chris Hyser Assuming this is going through sched tree, Acked-by: Shuah Khan thanks, -- Shuah

Re: [PATCH v3] selftests/mqueue: Set timeout to 180 seconds

2024-02-20 Thread Shuah Khan
On 2/19/24 17:08, SeongJae Park wrote: While mq_perf_tests runs with the default kselftest timeout limit, which is 45 seconds, the test takes about 60 seconds to complete on i3.metal AWS instances. Hence, the test always times out. Increase the timeout to 180 seconds. Fixes: 852c8cbf34d3 ("sel

Re: [PATCH 1/3] selftests: lib.mk: Do not process TEST_GEN_MODS_DIR

2024-02-20 Thread Shuah Khan
On 2/19/24 06:53, Marcos Paulo de Souza wrote: On Mon, 19 Feb 2024 09:15:15 -0300 Marcos Paulo de Souza wrote: On Mon, 19 Feb 2024 14:35:16 +0800 kernel test robot wrote: Hi Marcos, kernel test robot noticed the following build errors: [auto build test ERROR on 345e8abe4c355bc24bab3f4a56

Re: [PATCH][next] selftests: sched: Fix spelling mistake "hiearchy" -> "hierarchy"

2024-02-20 Thread Shuah Khan
On 2/20/24 02:23, Colin Ian King wrote: There is a spelling mistake in a printed message. Fix it. Signed-off-by: Colin Ian King --- tools/testing/selftests/sched/cs_prctl_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/sched/cs_prctl_test.c

Re: [PATCH 1/3] selftests: lib.mk: Do not process TEST_GEN_MODS_DIR

2024-02-21 Thread Shuah Khan
On 2/21/24 05:26, Marcos Paulo de Souza wrote: On Tue, 20 Feb 2024 17:19:54 -0700 Shuah Khan wrote: On 2/19/24 06:53, Marcos Paulo de Souza wrote: On Mon, 19 Feb 2024 09:15:15 -0300 Marcos Paulo de Souza wrote: On Mon, 19 Feb 2024 14:35:16 +0800 kernel test robot wrote: Hi Marcos

Re: [PATCH 0/9] kunit: Fix printf format specifier issues in KUnit assertions

2024-02-22 Thread Shuah Khan
On 2/21/24 02:27, David Gow wrote: KUnit has several macros which accept a log message, which can contain printf format specifiers. Some of these (the explicit log macros) already use the __printf() gcc attribute to ensure the format specifiers are valid, but those which could fail the test, and

Re: [PATCH v3] kselftest: Add basic test for probing the rust sample modules

2024-02-23 Thread Shuah Khan
On 2/22/24 09:29, Laura Nao wrote: Add new basic kselftest that checks if the available rust sample modules can be added and removed correctly. Signed-off-by: Laura Nao Reviewed-by: Sergio Gonzalez Collado Reviewed-by: Muhammad Usama Anjum --- Changes in v3: - Removed useless KSFT_PASS, KSFT_

Re: [PATCH v3] kselftest: Add basic test for probing the rust sample modules

2024-02-23 Thread Shuah Khan
On 2/23/24 14:48, Shuah Khan wrote: On 2/22/24 09:29, Laura Nao wrote: Add new basic kselftest that checks if the available rust sample modules can be added and removed correctly. Signed-off-by: Laura Nao Reviewed-by: Sergio Gonzalez Collado Reviewed-by: Muhammad Usama Anjum --- Changes in

Re: [PATCH 1/3] selftests: lib.mk: Do not process TEST_GEN_MODS_DIR

2024-02-23 Thread Shuah Khan
On 2/21/24 15:04, Marcos Paulo de Souza wrote: On Wed, 21 Feb 2024 14:12:00 -0700 Shuah Khan wrote: On 2/21/24 05:26, Marcos Paulo de Souza wrote: On Tue, 20 Feb 2024 17:19:54 -0700 Shuah Khan wrote: On 2/19/24 06:53, Marcos Paulo de Souza wrote: On Mon, 19 Feb 2024 09:15:15 -0300 Marcos

Re: [PATCH 1/3] selftests: lib.mk: Do not process TEST_GEN_MODS_DIR

2024-02-23 Thread Shuah Khan
On 2/21/24 19:04, Marcos Paulo de Souza wrote: On Thu, 22 Feb 2024 09:28:19 +0800 Yujie Liu wrote: On Wed, Feb 21, 2024 at 07:04:03PM -0300, Marcos Paulo de Souza wrote: On Wed, 21 Feb 2024 14:12:00 -0700 Shuah Khan wrote: On 2/21/24 05:26, Marcos Paulo de Souza wrote: On Tue, 20 Feb

Re: [PATCH v6 0/5] selftests/resctrl: Add non-contiguous CBMs in Intel CAT selftest

2024-02-23 Thread Shuah Khan
On 2/22/24 10:05, Reinette Chatre wrote: Hi Shuah, Could you please consider this series for inclusion? Thank you very much. Reinette On 2/16/2024 12:34 AM, Maciej Wieczor-Retman wrote: Non-contiguous CBM support for Intel CAT has been merged into the kernel with Commit 0e3cd31f6e90 ("x86/re

Re: [PATCH v6 0/5] selftests/resctrl: Add non-contiguous CBMs in Intel CAT selftest

2024-02-23 Thread Shuah Khan
On 2/23/24 15:33, Reinette Chatre wrote: On 2/23/2024 2:29 PM, Shuah Khan wrote: Applied to linux-ksefltest next for Linux 6.9-rc1 Thank you very much Shuah. Reinette Hi Reinette, Okay ran a quick test. Why does this test leave "/sys/fs/resctrl" mounted when it exits.

Re: [RESEND PATCH] selftests/overlayfs: fix compilation error in overlayfs

2024-02-27 Thread Shuah Khan
On 2/27/24 00:42, Meng Li wrote: make -C tools/testing/selftests, compiling dev_in_maps fail. In file included from dev_in_maps.c:10: /usr/include/x86_64-linux-gnu/sys/mount.h:35:3: error: expected identifier before numeric constant 35 | MS_RDONLY = 1,/* Mount read-only. *

Re: [PATCH 5/9] rtc: test: Fix invalid format specifier.

2024-02-27 Thread Shuah Khan
On 2/27/24 13:32, Alexandre Belloni wrote: Hello, On 21/02/2024 17:27:18+0800, David Gow wrote: 'days' is a s64 (from div_s64), and so should use a %lld specifier. This was found by extending KUnit's assertion macros to use gcc's __printf attribute. Fixes: 1d1bb12a8b18 ("rtc: Improve performa

Re: [RESEND PATCH] selftests/overlayfs: fix compilation error in overlayfs

2024-02-27 Thread Shuah Khan
On 2/27/24 14:20, Andrei Vagin wrote: On Tue, Feb 27, 2024 at 8:41 AM Shuah Khan wrote: On 2/27/24 00:42, Meng Li wrote: make -C tools/testing/selftests, compiling dev_in_maps fail. In file included from dev_in_maps.c:10: /usr/include/x86_64-linux-gnu/sys/mount.h:35:3: error: expected

Re: [PATCH 7/9] drm: tests: Fix invalid printf format specifiers in KUnit tests

2024-02-27 Thread Shuah Khan
On 2/21/24 14:29, Justin Stitt wrote: Hi, On Wed, Feb 21, 2024 at 05:27:20PM +0800, David Gow wrote: The drm_buddy_test's alloc_contiguous test used a u64 for the page size, which was then updated to be an 'unsigned long' to avoid 64-bit multiplication division helpers. However, the variable i

Re: [PATCH 0/9] kunit: Fix printf format specifier issues in KUnit assertions

2024-02-27 Thread Shuah Khan
On 2/21/24 02:27, David Gow wrote: KUnit has several macros which accept a log message, which can contain printf format specifiers. Some of these (the explicit log macros) already use the __printf() gcc attribute to ensure the format specifiers are valid, but those which could fail the test, and

Re: [PATCH v4] kselftest: Add basic test for probing the rust sample modules

2024-02-27 Thread Shuah Khan
Hi Laura, On 2/26/24 03:16, Laura Nao wrote: Add new basic kselftest that checks if the available rust sample modules can be added and removed correctly. Signed-off-by: Laura Nao Reviewed-by: Sergio Gonzalez Collado Reviewed-by: Muhammad Usama Anjum --- Depends on: - https://lore.kernel.org

  1   2   3   4   5   >