On 10/2/23 05:46, Abhinav wrote:
Some tests like dma, ia64, etc. were not present in top level of
selftest Makefile, so when someone ran 'make run_tests' they would miss
these tests. This patches adds those left out tests.
Signed-off-by: Abhinav <singhabhinav9051571...@gmail.com>
---
I removed sched, safesetid and filelock from the Makefile, because these
tests were actually triggered when we run 'make run_tests' even though it
has not been mentioned explicitly inside top level Makefile of selftest.
tools/testing/selftests/Makefile | 7 +++++++
1 file changed, 7 insertions(+)
There are good reasons to leave out tests from the kselftest default
run.
1. test requires specific hardware or driver or system configuration
which includes kernel configuration options.
e.g: media_tests, dma
2. It is a benchmark and/or destructive test that doesn't fit into
default run category: watchdog, kmod
3. test Makefile doesn't support kselftest framework
Any patch adding a test left out of default run to the default
run has to explain the reasons why it is a good idea to add it
and more importantly showing that this doesn't impact the default
run with report from the test run "make kselftest"
Sorry. I am not going to take this patch.
thanks,
-- Shuah
